*** dims_ has quit IRC | 00:07 | |
*** Qiming has quit IRC | 00:19 | |
*** pratikmallya has quit IRC | 00:22 | |
*** devth_ is now known as devth | 00:24 | |
*** dims has joined #openstack-sdks | 00:56 | |
*** jaypipes has quit IRC | 00:59 | |
*** gouthamr_ has joined #openstack-sdks | 01:07 | |
*** gouthamr has quit IRC | 01:10 | |
*** Qiming has joined #openstack-sdks | 01:12 | |
*** boris-42 has quit IRC | 01:13 | |
*** devth is now known as devth_afk | 01:42 | |
openstackgerrit | Merged openstack/python-openstackclient: Updated from global requirements https://review.openstack.org/264406 | 02:22 |
---|---|---|
*** lhcheng_ has quit IRC | 02:23 | |
*** salv-orl_ has quit IRC | 02:23 | |
*** salv-orlando has joined #openstack-sdks | 02:23 | |
openstackgerrit | Merged openstack/keystoneauth: Updated from global requirements https://review.openstack.org/264427 | 02:35 |
*** devth_afk is now known as devth | 02:48 | |
openstackgerrit | Merged openstack/python-openstackclient: Delete the unused LOG configure code https://review.openstack.org/263612 | 02:56 |
*** dims has quit IRC | 02:58 | |
*** boris-42 has joined #openstack-sdks | 03:02 | |
*** salv-orlando has quit IRC | 03:26 | |
*** salv-orlando has joined #openstack-sdks | 03:27 | |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: experimental: test the exp. job to detect naming conflicts https://review.openstack.org/264534 | 03:37 |
*** thrash is now known as thrash|g0ne | 03:42 | |
openstackgerrit | Einst Crazy proposed openstack/cliff: Fix wrong use of 'an' https://review.openstack.org/264535 | 03:45 |
*** gouthamr_ has quit IRC | 04:05 | |
*** gouthamr has joined #openstack-sdks | 04:06 | |
*** salv-orl_ has joined #openstack-sdks | 04:09 | |
*** salv-orlando has quit IRC | 04:11 | |
*** gouthamr_ has joined #openstack-sdks | 04:28 | |
*** gouthamr has quit IRC | 04:31 | |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: experimental: test the exp. job to detect naming conflicts https://review.openstack.org/264534 | 04:56 |
openstackgerrit | Sai Kiran proposed openstack/python-openstackclient: Add support to delete the ports https://review.openstack.org/260568 | 05:21 |
*** gouthamr_ has quit IRC | 05:30 | |
*** Yanyanhu has joined #openstack-sdks | 05:36 | |
*** salv-orl_ has quit IRC | 06:08 | |
*** salv-orlando has joined #openstack-sdks | 06:08 | |
*** markvoelker has quit IRC | 06:11 | |
openstackgerrit | Einst Crazy proposed openstack/python-openstackclient: Replace assertEqual(*, None) with assertIsNone in tests https://review.openstack.org/264601 | 06:39 |
openstackgerrit | Merged openstack/python-openstacksdk: Remove status property from LBaaS resources https://review.openstack.org/264336 | 06:56 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-openstacksdk: Updated from global requirements https://review.openstack.org/264407 | 06:57 |
openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/python-openstackclient: Use assertTrue/False instead of assertEqual(T/F) https://review.openstack.org/264624 | 07:10 |
*** markvoelker has joined #openstack-sdks | 07:11 | |
openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/python-openstacksdk: Use assertTrue/False instead of assertEqual(T/F) https://review.openstack.org/264626 | 07:12 |
*** markvoelker has quit IRC | 07:16 | |
openstackgerrit | LiuNanke proposed openstack/os-client-config: Remove openstack-common.conf https://review.openstack.org/264635 | 07:22 |
*** fzdarsky has joined #openstack-sdks | 08:00 | |
*** salv-orlando has quit IRC | 08:04 | |
*** salv-orlando has joined #openstack-sdks | 08:04 | |
*** salv-orlando has quit IRC | 08:30 | |
*** salv-orlando has joined #openstack-sdks | 08:30 | |
openstackgerrit | Merged openstack/python-openstackclient: Replace assertEqual(*, None) with assertIsNone in tests https://review.openstack.org/264601 | 08:52 |
*** markvoelker has joined #openstack-sdks | 09:12 | |
*** markvoelker has quit IRC | 09:17 | |
openstackgerrit | Merged openstack/python-openstackclient: Use assertTrue/False instead of assertEqual(T/F) https://review.openstack.org/264624 | 09:21 |
*** fzdarsky is now known as fzdarsky|afk | 09:22 | |
openstackgerrit | Jude Augustine Job proposed openstack/python-openstackclient: change owner to project for image commands https://review.openstack.org/264684 | 09:27 |
*** salv-orl_ has joined #openstack-sdks | 10:08 | |
*** salv-orlando has quit IRC | 10:11 | |
*** fzdarsky|afk is now known as fzdarsky | 10:15 | |
*** Yanyanhu has quit IRC | 10:16 | |
*** Qiming has quit IRC | 10:22 | |
*** cdent has joined #openstack-sdks | 10:49 | |
*** lhcheng has joined #openstack-sdks | 11:07 | |
*** salv-orl_ has quit IRC | 11:07 | |
*** salv-orlando has joined #openstack-sdks | 11:08 | |
*** dims has joined #openstack-sdks | 11:10 | |
*** markvoelker has joined #openstack-sdks | 11:13 | |
*** Qiming has joined #openstack-sdks | 11:14 | |
*** markvoelker has quit IRC | 11:18 | |
*** lucas-dinner is now known as lucasagomes | 11:20 | |
openstackgerrit | Sai Kiran proposed openstack/python-openstackclient: Refactor abstract columns and datalist out in compute test cases https://review.openstack.org/264731 | 11:38 |
*** enthurohini has joined #openstack-sdks | 11:50 | |
*** markvoelker has joined #openstack-sdks | 12:14 | |
*** markvoelker has quit IRC | 12:18 | |
*** thrash|g0ne is now known as thrash | 12:20 | |
*** rtheis has joined #openstack-sdks | 12:22 | |
*** woodster_ has joined #openstack-sdks | 12:54 | |
*** salv-orlando has quit IRC | 13:03 | |
*** salv-orlando has joined #openstack-sdks | 13:03 | |
*** enthurohini has quit IRC | 13:03 | |
*** markvoelker has joined #openstack-sdks | 13:18 | |
*** gouthamr has joined #openstack-sdks | 13:35 | |
*** cdent has quit IRC | 14:02 | |
*** cdent has joined #openstack-sdks | 14:24 | |
*** lucasagomes is now known as lucas-hungry | 14:32 | |
*** jose4183 has joined #openstack-sdks | 14:41 | |
*** petertr7_away is now known as petertr7 | 14:43 | |
*** petertr7 is now known as petertr7_away | 14:55 | |
*** woodster_ has quit IRC | 15:06 | |
*** enthurohini has joined #openstack-sdks | 15:14 | |
*** jaypipes has joined #openstack-sdks | 15:15 | |
*** navidp has left #openstack-sdks | 15:23 | |
*** lucas-hungry is now known as lucasagomes | 15:34 | |
*** dims_ has joined #openstack-sdks | 15:35 | |
*** dims has quit IRC | 15:36 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 15:42 | |
openstackgerrit | Merged openstack/python-openstacksdk: Use assertTrue/False instead of assertEqual(T/F) https://review.openstack.org/264626 | 15:53 |
openstackgerrit | Merged openstack/python-openstacksdk: Correct response value in resource unittests https://review.openstack.org/261969 | 15:54 |
*** devth_ has joined #openstack-sdks | 16:05 | |
*** devth has quit IRC | 16:05 | |
*** devth has joined #openstack-sdks | 16:06 | |
*** salv-orl_ has joined #openstack-sdks | 16:08 | |
*** devth_ has quit IRC | 16:10 | |
*** salv-orlando has quit IRC | 16:11 | |
*** Qiming has quit IRC | 16:12 | |
*** woodster_ has joined #openstack-sdks | 16:13 | |
*** devth has quit IRC | 16:26 | |
*** devth has joined #openstack-sdks | 16:26 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-openstacksdk: Updated from global requirements https://review.openstack.org/264407 | 16:49 |
*** enthurohini has quit IRC | 16:59 | |
*** dims has joined #openstack-sdks | 16:59 | |
*** dims_ has quit IRC | 17:02 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 17:27 | |
openstackgerrit | Merged openstack/python-openstackclient: Further improve output for "os security group show" https://review.openstack.org/263843 | 17:35 |
openstackgerrit | Merged openstack/os-client-config: Replace assertEqual(None, *) with assertIsNone in tests https://review.openstack.org/264206 | 17:40 |
openstackgerrit | Merged openstack/os-client-config: Remove openstack-common.conf https://review.openstack.org/264635 | 17:40 |
*** breton has quit IRC | 17:44 | |
openstackgerrit | Merged openstack/python-openstacksdk: Updated from global requirements https://review.openstack.org/264407 | 17:47 |
etoews | briancurtin: terrylhowe: i'm looking at the exception mapping issue. now that we use ksa session, there isn't one single place where we can try/except and make sure everything is mapped properly. i'm not totally sure what's the best design here. | 17:51 |
etoews | some stuff i'm considering... | 17:51 |
etoews | 1. move all calls to ksa session methods into our own *very thin* session so we can wrap calls to ksa session in try/except. | 17:52 |
etoews | 2. decorate the calls in ksa session to wrap them in a try/except (not sure how feasible this is) | 17:53 |
*** breton has joined #openstack-sdks | 17:53 | |
etoews | 3. something i haven't thought of | 17:53 |
briancurtin | etoews: on 2, that’s pretty much how we could solve this from within Resource, decorating any calls that go out via the session and just have a handler that knows how to translate | 17:55 |
briancurtin | still thinking about how that works compared to #1, though | 17:57 |
*** cdent has quit IRC | 17:59 | |
*** breton has quit IRC | 18:01 | |
*** breton has joined #openstack-sdks | 18:01 | |
briancurtin | etoews: we probably want #1. get the transition done at the earliest time and inside of the SDK we work with our own exceptions | 18:04 |
etoews | briancurtin: okay. i'll take a stab at that one | 18:06 |
*** elmiko has quit IRC | 18:14 | |
rtheis | I'm running into problems with proxy methods for PoolMember... These proxy methods need path_args to set pool_id in URL, but neutron doesn't like pool_id also being passed on the request. It appears the base proxy updates the resource to include path_args. | 18:14 |
rtheis | not sure the best way to fix this... | 18:14 |
*** markvoelker has quit IRC | 18:14 | |
briancurtin | rtheis: i think that’s one of the places that is the basis for needing to fix how we do path_args IIRC. i’ll take a look | 18:15 |
rtheis | ok | 18:15 |
*** elmiko has joined #openstack-sdks | 18:16 | |
*** e0ne has joined #openstack-sdks | 18:23 | |
briancurtin | rtheis: what exactly do you mean “also being passed on the request”? do you mean it’s coughing on pool_id showing up in the body as well as in the URI? | 18:23 |
rtheis | briancurtin: yes, exactly | 18:23 |
rtheis | PUT http://127.0.0.1:9696/v2.0/lbaas/pools/57234610-760a-47ce-bfe2-179c789e24cc/members/42db89a5-2f96-4d5c-bd00-d25b89bcf430 | 18:24 |
briancurtin | ah, ok, yeah there’s a review out that sort of fixes some of that but needs to be fixed up as we have this issue in a few other areas. | 18:24 |
rtheis | {"member": {"protocol_port": "81", "pool_id": "57234610-760a-47ce-bfe2-179c789e24cc"}} | 18:24 |
briancurtin | i’ve been meaning to get back into that one as path_args in general is one of the bigger things left that we need to get figured out. i’ll take a look after i finish what i’m on right now | 18:25 |
rtheis | briancurtin: cool thanks ... I'll take a look at that review | 18:25 |
rtheis | briancurtin: Is https://review.openstack.org/#/c/262367/ the review that you are referring to? | 18:28 |
briancurtin | rtheis: https://review.openstack.org/#/c/219840/ is the old one, and i’m going to probably revive it there if i can and incorporate ideas from my comment | 18:29 |
rtheis | thanks | 18:29 |
*** fzdarsky has quit IRC | 18:47 | |
*** fzdarsky has joined #openstack-sdks | 18:48 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 18:54 | |
*** markvoelker has joined #openstack-sdks | 19:03 | |
*** markvoelker_ has joined #openstack-sdks | 19:05 | |
*** e0ne has quit IRC | 19:08 | |
*** markvoelker has quit IRC | 19:09 | |
*** markvoelker has joined #openstack-sdks | 19:14 | |
*** markvoelker_ has quit IRC | 19:17 | |
openstackgerrit | Hardik Italia proposed openstack/python-openstacksdk: Update router's functional tests to validate is_ha property https://review.openstack.org/264932 | 19:17 |
*** petertr7_away is now known as petertr7 | 19:20 | |
*** rtheis_ has joined #openstack-sdks | 19:29 | |
*** nikhil_k has joined #openstack-sdks | 19:31 | |
sigmavirus24 | etoews: briancurtin did either of you see the message on the ML from Qiming Teng about namespace conflicts? | 19:31 |
*** breton_ has joined #openstack-sdks | 19:31 | |
*** tangchen__ has joined #openstack-sdks | 19:32 | |
*** dims_ has joined #openstack-sdks | 19:33 | |
sigmavirus24 | woops missed that dhellmann already responded. Mail.app is being not great today | 19:33 |
*** dims has quit IRC | 19:34 | |
*** ameade_ has joined #openstack-sdks | 19:35 | |
*** etoews_ has joined #openstack-sdks | 19:35 | |
*** stevemar_znc has joined #openstack-sdks | 19:37 | |
*** breton has quit IRC | 19:38 | |
*** rtheis has quit IRC | 19:38 | |
*** nikhil has quit IRC | 19:38 | |
*** ameade has quit IRC | 19:38 | |
*** briancurtin has quit IRC | 19:38 | |
*** tangchen_ has quit IRC | 19:38 | |
*** etoews has quit IRC | 19:38 | |
*** stevemar has quit IRC | 19:38 | |
*** stevemar_znc is now known as stevemar | 19:40 | |
*** lhcheng_ has joined #openstack-sdks | 19:40 | |
*** ameade_ is now known as ameade | 19:40 | |
*** etoews_ is now known as etoews | 19:42 | |
*** lhcheng has quit IRC | 19:43 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 19:45 | |
*** briancurtin has joined #openstack-sdks | 19:46 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 19:48 | |
*** lucasagomes is now known as lucas-dinner | 19:49 | |
*** dhellmann_ has joined #openstack-sdks | 19:55 | |
*** dims_ has quit IRC | 20:00 | |
stevemar | dtroyer: whelp, no meeting today i suppose :) | 20:06 |
dtroyer | stevemar: jeez… | 20:08 |
dtroyer | my bad there | 20:08 |
*** dhellmann has quit IRC | 20:11 | |
*** dhellmann_ is now known as dhellmann | 20:11 | |
*** dhellmann has quit IRC | 20:12 | |
stevemar | dtroyer: np | 20:12 |
*** dims has joined #openstack-sdks | 20:12 | |
*** cdent has joined #openstack-sdks | 20:13 | |
*** dhellmann has joined #openstack-sdks | 20:14 | |
*** dims has quit IRC | 20:19 | |
etoews | briancurtin: looking at things a bit more closely. the sdk already has https://github.com/openstack/python-openstacksdk/blob/master/openstack/session.py | 20:20 |
etoews | so for 1. it would be a matter of overriding the methods and wrapping the calls there. | 20:20 |
etoews | but that can potentially break if ksa session methods change or are deleted or added. | 20:21 |
*** dims has joined #openstack-sdks | 20:22 | |
etoews | for 2 i think it would look something like this http://stackoverflow.com/questions/16697545/wrap-calls-to-methods-of-a-python-class | 20:23 |
*** openstackgerrit has quit IRC | 20:23 | |
*** dims has quit IRC | 20:23 | |
*** openstackgerrit has joined #openstack-sdks | 20:25 | |
etoews | i think i'm going to take a stab at 2. just to see how it works. | 20:28 |
briancurtin | etoews: yeah, sort of, but we’d know which ones we’re using since we’re calling through them. i’m interested in seeing 2 though so go for it | 20:38 |
*** dims has joined #openstack-sdks | 20:39 | |
*** petertr7 is now known as petertr7_away | 20:48 | |
*** petertr7_away is now known as petertr7 | 20:51 | |
*** fzdarsky has quit IRC | 21:03 | |
*** petertr7 is now known as petertr7_away | 21:04 | |
*** petertr7_away is now known as petertr7 | 21:05 | |
openstackgerrit | Brant Knudson proposed openstack/keystoneauth: Switch saml2 from lxml to built-in xml https://review.openstack.org/242512 | 21:21 |
*** nikhil_k is now known as nikhil | 21:29 | |
*** gouthamr has quit IRC | 21:48 | |
*** jaypipes has quit IRC | 21:50 | |
*** boris-42 has quit IRC | 21:50 | |
openstackgerrit | Richard Theis proposed openstack/python-openstacksdk: Fix create_pool_member and update_pool_member https://review.openstack.org/264980 | 21:51 |
*** jaypipes has joined #openstack-sdks | 21:51 | |
*** boris-42 has joined #openstack-sdks | 21:51 | |
*** cdent has quit IRC | 21:54 | |
*** rtheis_ has quit IRC | 22:05 | |
*** salv-orlando has joined #openstack-sdks | 22:09 | |
*** salv-orl_ has quit IRC | 22:11 | |
*** gouthamr has joined #openstack-sdks | 22:19 | |
*** petertr7 is now known as petertr7_away | 22:22 | |
*** jose4183 has quit IRC | 22:23 | |
*** thrash is now known as thrash|g0ne | 22:45 | |
*** lhcheng_ has quit IRC | 22:48 | |
jamielennox | etoews, briancurtin: not sure if either of you is still here, but what's the probably with the ksa excs? | 22:52 |
briancurtin | jamielennox: no problem per se with the exceptions, but i don’t want SDK end-users to have to be handling keystonauth1.exceptions.* or something like that. we shouldn’t be leaking things from below | 22:59 |
*** dims_ has joined #openstack-sdks | 23:00 | |
jamielennox | briancurtin: that makes sense for most things - are you going to end up replicating everything though? | 23:01 |
*** dims has quit IRC | 23:01 | |
briancurtin | jamielennox: what i think it’ll end up being is just catching the base HttpError and re-raising as SDK’s HTTPException, using the status and code and stuff. SDK doesn’t have an exception per code (though it does on some common ones we use, such as 404) | 23:02 |
briancurtin | mostly coalescing down to that one, though we haven’t worked out exactly how it’s being done yet so that may change | 23:02 |
jamielennox | briancurtin: that makes sense, i agree ksa should mostly be an implementation detail | 23:03 |
*** sigmavirus24 is now known as sigmavirus24_awa | 23:12 | |
*** Qiming has joined #openstack-sdks | 23:32 | |
*** dims_ has quit IRC | 23:39 | |
*** dims_ has joined #openstack-sdks | 23:45 | |
*** dims_ has quit IRC | 23:50 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!