| *** bryan_att has quit IRC | 00:09 | |
| *** pratikmallya has quit IRC | 00:10 | |
| *** markvoelker has quit IRC | 00:14 | |
| *** markvoelker has joined #openstack-sdks | 00:17 | |
| *** Qiming has quit IRC | 00:45 | |
| *** abitha has quit IRC | 00:59 | |
| *** salv-orlando has quit IRC | 01:12 | |
| *** tangchen__ has quit IRC | 01:29 | |
| *** david-lyle has quit IRC | 01:31 | |
| *** Qiming has joined #openstack-sdks | 01:42 | |
| *** Yanyanhu has joined #openstack-sdks | 02:03 | |
| *** hitalia has quit IRC | 02:20 | |
| *** fzdarsky|afk has quit IRC | 02:20 | |
| *** fzdarsky has joined #openstack-sdks | 02:26 | |
| *** markvoelker has quit IRC | 02:42 | |
| *** annegentle has quit IRC | 02:43 | |
| *** devth has joined #openstack-sdks | 02:49 | |
| *** devth_ has quit IRC | 02:52 | |
| *** jaypipes has quit IRC | 02:55 | |
| *** gouthamr has joined #openstack-sdks | 03:16 | |
| *** woodster_ has quit IRC | 03:46 | |
| *** thrash is now known as thrash|g0ne | 03:46 | |
| *** dims has quit IRC | 03:54 | |
| *** dims has joined #openstack-sdks | 03:59 | |
| *** annegentle has joined #openstack-sdks | 04:06 | |
| *** lhcheng has quit IRC | 04:07 | |
| *** annegentle has quit IRC | 04:10 | |
| *** dims has quit IRC | 04:13 | |
| *** markvoelker has joined #openstack-sdks | 04:14 | |
| *** lhcheng has joined #openstack-sdks | 04:25 | |
| *** lhcheng has quit IRC | 04:26 | |
| *** lhcheng has joined #openstack-sdks | 04:26 | |
| *** gouthamr has quit IRC | 04:30 | |
| *** gouthamr has joined #openstack-sdks | 04:31 | |
| *** gouthamr has quit IRC | 04:32 | |
| *** david-lyle has joined #openstack-sdks | 04:44 | |
| *** oomichi_away has quit IRC | 05:04 | |
| *** oomichi has joined #openstack-sdks | 05:10 | |
| openstackgerrit | Sai Kiran proposed openstack/python-openstackclient: Add support to delete the ports https://review.openstack.org/260568 | 05:13 |
|---|---|---|
| *** dixiaoli has joined #openstack-sdks | 05:18 | |
| openstackgerrit | Sai Kiran proposed openstack/python-openstackclient: Refactor: Abstract columns and datalist out in volume test cases https://review.openstack.org/266431 | 05:34 |
| *** salv-orlando has joined #openstack-sdks | 05:49 | |
| *** annegentle has joined #openstack-sdks | 06:06 | |
| *** annegentle has quit IRC | 06:11 | |
| *** lhcheng has quit IRC | 06:28 | |
| *** jamielennox is now known as jamielennox|away | 06:40 | |
| *** gildub has quit IRC | 06:52 | |
| *** markvoelker has quit IRC | 07:11 | |
| *** markvoelker has joined #openstack-sdks | 07:12 | |
| *** markvoelker_ has joined #openstack-sdks | 07:18 | |
| *** markvoelker has quit IRC | 07:20 | |
| *** markvoel_ has joined #openstack-sdks | 07:42 | |
| *** markvoelker_ has quit IRC | 07:43 | |
| *** GheRivero is now known as Rivero | 07:48 | |
| *** GheRiver1 is now known as GheRivero | 07:49 | |
| *** salv-orlando has quit IRC | 07:49 | |
| *** fzdarsky has quit IRC | 08:02 | |
| *** annegentle has joined #openstack-sdks | 08:07 | |
| *** annegentle has quit IRC | 08:12 | |
| openstackgerrit | Ethan Lynn proposed openstack/python-openstacksdk: Raise NotFound exception when get a deleted stack https://review.openstack.org/270094 | 09:49 |
| *** dixiaoli has quit IRC | 10:05 | |
| *** dixiaoli has joined #openstack-sdks | 10:05 | |
| *** annegentle has joined #openstack-sdks | 10:08 | |
| *** Qiming has quit IRC | 10:12 | |
| *** annegentle has quit IRC | 10:13 | |
| *** fzdarsky has joined #openstack-sdks | 10:25 | |
| *** e0ne has joined #openstack-sdks | 10:25 | |
| *** Yanyanhu has quit IRC | 10:40 | |
| *** dixiaoli has quit IRC | 10:49 | |
| *** cdent has joined #openstack-sdks | 11:05 | |
| *** Qiming has joined #openstack-sdks | 11:08 | |
| *** openstackgerrit has quit IRC | 11:43 | |
| -openstackstatus- NOTICE: review.openstack.org is being restarted to apply patches | 11:43 | |
| *** ChanServ changes topic to "review.openstack.org is being restarted to apply patches" | 11:43 | |
| *** openstackgerrit has joined #openstack-sdks | 11:44 | |
| *** ChanServ changes topic to "#openstack-sdks" | 11:54 | |
| -openstackstatus- NOTICE: Restart done, review.openstack.org is available | 11:55 | |
| *** amotoki has joined #openstack-sdks | 12:04 | |
| *** annegentle has joined #openstack-sdks | 12:09 | |
| *** thrash|g0ne is now known as thrash | 12:09 | |
| *** annegentle has quit IRC | 12:13 | |
| *** boris-42 has quit IRC | 12:13 | |
| *** thrash has quit IRC | 12:17 | |
| *** thrash has joined #openstack-sdks | 12:19 | |
| *** thrash has quit IRC | 12:19 | |
| *** thrash has joined #openstack-sdks | 12:19 | |
| *** jaypipes has joined #openstack-sdks | 12:23 | |
| *** rtheis has joined #openstack-sdks | 12:29 | |
| *** dims has joined #openstack-sdks | 12:49 | |
| openstackgerrit | Akihiro Motoki proposed openstack/python-openstackclient: Drop explicit logger definition (volume) https://review.openstack.org/269613 | 13:05 |
| openstackgerrit | Akihiro Motoki proposed openstack/python-openstackclient: Drop explicit logger definition (compute) https://review.openstack.org/269612 | 13:05 |
| openstackgerrit | Akihiro Motoki proposed openstack/python-openstackclient: Drop explicit logger definition (common, image, network, object) https://review.openstack.org/269615 | 13:05 |
| openstackgerrit | Akihiro Motoki proposed openstack/python-openstackclient: Drop explicit logger definition (identity) https://review.openstack.org/269614 | 13:05 |
| openstackgerrit | Akihiro Motoki proposed openstack/python-openstackclient: Set up logger of each command by metaclass https://review.openstack.org/265504 | 13:05 |
| openstackgerrit | Akihiro Motoki proposed openstack/python-openstackclient: log_method: get logger from decorated method if unspecified https://review.openstack.org/265520 | 13:05 |
| openstackgerrit | Akihiro Motoki proposed openstack/python-openstackclient: Drop explicit logger definition (volume) https://review.openstack.org/269613 | 13:14 |
| openstackgerrit | Akihiro Motoki proposed openstack/python-openstackclient: Drop explicit logger definition (compute) https://review.openstack.org/269612 | 13:14 |
| openstackgerrit | Akihiro Motoki proposed openstack/python-openstackclient: Drop explicit logger definition (common, image, network, object) https://review.openstack.org/269615 | 13:14 |
| openstackgerrit | Akihiro Motoki proposed openstack/python-openstackclient: Drop explicit logger definition (identity) https://review.openstack.org/269614 | 13:14 |
| *** gouthamr has joined #openstack-sdks | 13:43 | |
| *** annegentle has joined #openstack-sdks | 13:44 | |
| *** crinkle_ has joined #openstack-sdks | 13:49 | |
| *** baffle__ has joined #openstack-sdks | 13:51 | |
| *** gouthamr has quit IRC | 13:51 | |
| *** lifeless_ has joined #openstack-sdks | 13:51 | |
| *** gouthamr has joined #openstack-sdks | 13:52 | |
| *** electrichead has joined #openstack-sdks | 13:55 | |
| *** keekz_ has joined #openstack-sdks | 13:55 | |
| *** krotscheck_ has joined #openstack-sdks | 13:55 | |
| *** electrichead is now known as Guest10164 | 13:55 | |
| *** d0ugal has quit IRC | 13:56 | |
| *** redrobot has quit IRC | 13:56 | |
| *** keekz has quit IRC | 13:56 | |
| *** crinkle has quit IRC | 13:56 | |
| *** lifeless has quit IRC | 13:56 | |
| *** krotscheck has quit IRC | 13:56 | |
| *** baffle has quit IRC | 13:56 | |
| *** krotscheck_ is now known as krotscheck | 13:56 | |
| *** d0ugal has joined #openstack-sdks | 14:03 | |
| *** petertr7_away is now known as petertr7 | 14:40 | |
| *** keekz_ is now known as keekz | 14:52 | |
| *** gouthamr has quit IRC | 14:53 | |
| *** gouthamr has joined #openstack-sdks | 14:54 | |
| *** gouthamr has quit IRC | 14:58 | |
| *** bryan_att has joined #openstack-sdks | 15:06 | |
| *** petertr7 is now known as petertr7_away | 15:06 | |
| *** pratikmallya has joined #openstack-sdks | 15:09 | |
| *** pratikma_ has joined #openstack-sdks | 15:10 | |
| *** pratikmallya has quit IRC | 15:13 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 15:13 | |
| *** boris-42 has joined #openstack-sdks | 15:16 | |
| *** markvoel_ has quit IRC | 15:25 | |
| *** markvoelker_ has joined #openstack-sdks | 15:46 | |
| *** Guest10164 is now known as redrobot | 15:49 | |
| *** Eva-i has joined #openstack-sdks | 15:55 | |
| *** jaypipes has quit IRC | 16:06 | |
| *** jaypipes has joined #openstack-sdks | 16:11 | |
| *** cdent has quit IRC | 16:12 | |
| briancurtin | rtheis: the more i think about it, with the issues i had in block_store, the issues you’re seeing in network, and inevitably the issue we’ll see in compute, on top of the fact that all of our APIs work either with a resource or an ID itself, we probably should back out the resources-as-prop-type changes. it’s proving to be much harder to maintain, and | 16:20 |
| briancurtin | because of that it’ll never be consistent | 16:20 |
| rtheis | briancurtin: okay, that's what I was thinking too. I'll work on backing out the resources-as-prop-type changes. | 16:21 |
| rtheis | thanks | 16:21 |
| briancurtin | rtheis: hold on a second | 16:21 |
| openstackgerrit | Merged openstack/python-openstackclient: Add support to delete the ports https://review.openstack.org/260568 | 16:21 |
| rtheis | ok | 16:22 |
| briancurtin | ah, terry isn’t online. etoews what do you think about above? | 16:22 |
| etoews | 1 min... | 16:24 |
| briancurtin | the grand idea of resources-as-prop-types would have been better if those props were populated with the “detail” version of said resources (which happen after a GET), but they aren’t so they’re just a simple wrapper around the ID, so not even that useful anyway | 16:24 |
| etoews | ah. i think i see what you're saying. you'd have to do an eager get to provide what you originally envisioned. does that sound right? | 16:25 |
| briancurtin | etoews: yeah, so we’d end up in some cases making 2-3 extra GET calls to provide “everything”, when in reality they might not need or care about those other ones | 16:26 |
| briancurtin | there’s basically zero plumbing to even make that part of this happen right now anyway, so even getting to the point where we can make things slower and marginally more useful would take quite a bit, i think | 16:28 |
| etoews | ya. being explicit about only providing ids and having the user do an explicit GET the full resources they need makes sense to me. otherwise you're optimizing around something (eager fetch) that users might not even want but have a cost in terms of performance. | 16:28 |
| etoews | briancurtin: as in, providing a flag to automatically do eager fetch? | 16:29 |
| briancurtin | etoews: i don’t even think we should do that. there’s currently no tie to a session inside a prop, and even enabling that possibility is going to be ugly | 16:30 |
| *** salv-orlando has joined #openstack-sdks | 16:30 | |
| briancurtin | i think i put us down a path we can’t really complete. i hadn’t even thought of the extra-get idea until right now, i had just seen those nested resources as providing “enough data” but they really dont | 16:31 |
| etoews | alright. well i'm totally fine with just ids for now. if there's user driven demand for eager fetch in the future we can do it then. | 16:31 |
| etoews | briancurtin: rtheis: what does the nested resource wind up being called? e.g. volume or volume_id? | 16:32 |
| etoews | i'd lean towards volume but document it and say volume id. that way if it winds up returning a full resource in the future we don't have to rename the prop. | 16:33 |
| rtheis | etoews: the nested resource was called volume, "_id" is dropped. | 16:33 |
| *** cdent has joined #openstack-sdks | 16:34 | |
| briancurtin | i’m fine with that issue becoming just a stripping of _id | 16:34 |
| rtheis | that sounds good to me | 16:34 |
| briancurtin | i’ll update https://bugs.launchpad.net/python-openstacksdk/+bug/1461200 | 16:34 |
| openstack | Launchpad bug 1461200 in OpenStack SDK "Create resource.props type=Resource for attributes with _id names" [Critical,In progress] - Assigned to Richard Theis (rtheis) | 16:34 |
| rtheis | cool | 16:35 |
| briancurtin | rtheis: let’s wait for terry to respond on it since he opened it before moving forward with the change. i think he’ll agree though | 16:35 |
| rtheis | briancurtin: will do | 16:36 |
| briancurtin | fwiw, from an older bug (https://bugs.launchpad.net/python-openstacksdk/+bug/1417175) he was in favor of keeping _id on id-based names, since it makes it more clear that it’s like a foreign key | 16:37 |
| openstack | Launchpad bug 1417175 in OpenStack SDK "Consistency in *_id property names" [Medium,Fix released] - Assigned to Brian Curtin (brian.curtin) | 16:37 |
| rtheis | briancurtin, etoews: in network, there are some properties that are list of IDs but do not have *_ids property names. So dropping _id would be consistent with the list property names. Or we could change the list property names to use _ids. | 16:43 |
| *** devth_ has joined #openstack-sdks | 16:43 | |
| briancurtin | i think if it’s going to be a list, _ids makes sense (or if we decide we’re going anti-_ids, then pluralize whatever the thing is) | 16:43 |
| briancurtin | terry’s comment about the foreign key thing makes me think _id/_ids is probably better though | 16:44 |
| rtheis | yeah, consistency is good | 16:44 |
| etoews | i don't have a strong opinion on it really. i could go either way as long as it's consistent. | 16:46 |
| rtheis | same here | 16:46 |
| *** annegentle has quit IRC | 16:46 | |
| etoews | _id/_ids is certainly more clear for the current design so probably best to go with that. | 16:46 |
| *** annegentle has joined #openstack-sdks | 16:47 | |
| *** devth has quit IRC | 16:47 | |
| etoews | if we did eager fetch, we could potentially add another prop that drops the id. e.g. volume_id and volume props or volume_ids and volumes. i dunno. kinda frivolous to even attempt to do future design. | 16:48 |
| briancurtin | etoews: yeah, if we end up finding some magical way of even doing that, i’d prefer those didn’t have _id/_ids, and then we’d phase out just the IDs through some deprecation…but i don’t really see how we can get that functionality inside of the props themselves to be able to make calls without some nightmare of a solution | 16:51 |
| *** hitalia has joined #openstack-sdks | 17:02 | |
| *** lhcheng has joined #openstack-sdks | 17:04 | |
| *** e0ne has quit IRC | 17:13 | |
| *** dims has quit IRC | 17:16 | |
| *** dims has joined #openstack-sdks | 17:26 | |
| openstackgerrit | Tom Cocozzello proposed openstack/python-openstackclient: WIP Include name in list assignment https://review.openstack.org/255363 | 17:30 |
| *** pratikma_ has quit IRC | 17:46 | |
| rtheis | briancurtin: should I proceed with https://bugs.launchpad.net/python-openstacksdk/+bug/1461200 to use _id/_ids or wait for terry to respond? | 17:50 |
| openstack | Launchpad bug 1461200 in OpenStack SDK "Create resource.props type=Resource for attributes with _id names" [Critical,In progress] - Assigned to Richard Theis (rtheis) | 17:50 |
| *** hitalia has quit IRC | 17:50 | |
| briancurtin | rtheis: per the discussion on https://bugs.launchpad.net/python-openstacksdk/+bug/1417175 i think just go ahead. he was a fan of the _id name and created the type=Resource issue out of that discussion | 17:51 |
| openstack | Launchpad bug 1417175 in OpenStack SDK "Consistency in *_id property names" [Medium,Fix released] - Assigned to Brian Curtin (brian.curtin) | 17:51 |
| rtheis | thanks | 17:51 |
| *** jose4183 has joined #openstack-sdks | 18:00 | |
| *** crinkle_ is now known as crinkle | 18:04 | |
| *** cdent has quit IRC | 18:05 | |
| *** hitalia has joined #openstack-sdks | 18:06 | |
| openstackgerrit | Richard Theis proposed openstack/python-openstacksdk: Add LoadBalancer vip_port_id and provider properties https://review.openstack.org/264267 | 18:07 |
| *** lifeless_ is now known as lifeless | 18:12 | |
| openstackgerrit | Andreas Jaeger proposed openstack/keystoneauth: Remove argparse from requirements https://review.openstack.org/270370 | 18:16 |
| *** kragniz_ has joined #openstack-sdks | 18:17 | |
| *** e0ne has joined #openstack-sdks | 18:18 | |
| *** dhellmann_ has joined #openstack-sdks | 18:20 | |
| *** annegentle has quit IRC | 18:22 | |
| *** Eva-i has quit IRC | 18:22 | |
| *** dhellmann has quit IRC | 18:22 | |
| *** kragniz has quit IRC | 18:22 | |
| *** dhellmann_ is now known as dhellmann | 18:22 | |
| *** annegentle has joined #openstack-sdks | 18:24 | |
| *** Eva-i has joined #openstack-sdks | 18:30 | |
| *** Qiming has quit IRC | 18:34 | |
| *** cdent has joined #openstack-sdks | 18:35 | |
| *** annegentle has quit IRC | 18:35 | |
| *** annegentle has joined #openstack-sdks | 18:37 | |
| *** annegentle has quit IRC | 18:48 | |
| *** annegentle has joined #openstack-sdks | 18:48 | |
| *** pratikmallya has joined #openstack-sdks | 18:57 | |
| *** bryan_att has quit IRC | 18:57 | |
| *** bryan_att has joined #openstack-sdks | 18:57 | |
| *** boris-42 has quit IRC | 18:57 | |
| *** boris-42 has joined #openstack-sdks | 18:57 | |
| *** pratikma_ has joined #openstack-sdks | 18:58 | |
| *** hitalia has quit IRC | 18:58 | |
| *** hitalia has joined #openstack-sdks | 18:58 | |
| *** annegentle has quit IRC | 18:59 | |
| *** pratikma_ has quit IRC | 19:00 | |
| *** pratikma_ has joined #openstack-sdks | 19:00 | |
| *** pratikmallya has quit IRC | 19:02 | |
| *** woodster_ has joined #openstack-sdks | 19:03 | |
| *** hitalia has quit IRC | 19:16 | |
| *** bnemec has quit IRC | 19:17 | |
| *** bnemec has joined #openstack-sdks | 19:25 | |
| elmiko | etoews: man, that pagination spec is turning out much more controversial than i imagined | 20:10 |
| *** hitalia has joined #openstack-sdks | 20:18 | |
| *** annegentle has joined #openstack-sdks | 20:18 | |
| *** salv-orlando has quit IRC | 20:18 | |
| *** hitalia has quit IRC | 20:18 | |
| *** hitalia has joined #openstack-sdks | 20:18 | |
| *** hitalia has quit IRC | 20:28 | |
| *** annegentle has quit IRC | 20:28 | |
| openstackgerrit | Tom Cocozzello proposed openstack/python-openstackclient: WIP Include name in list assignment https://review.openstack.org/255363 | 20:38 |
| *** annegentle has joined #openstack-sdks | 20:42 | |
| *** boris-42 has quit IRC | 20:43 | |
| openstackgerrit | Tom Cocozzello proposed openstack/python-openstackclient: WIP Include name in list assignment https://review.openstack.org/255363 | 20:47 |
| *** pratikma_ has quit IRC | 20:48 | |
| *** annegentle has quit IRC | 20:53 | |
| *** dolphm has left #openstack-sdks | 20:53 | |
| *** rtheis has quit IRC | 21:15 | |
| *** salv-orlando has joined #openstack-sdks | 21:18 | |
| *** salv-orlando has quit IRC | 21:19 | |
| *** salv-orlando has joined #openstack-sdks | 21:19 | |
| *** terrylhowe has joined #openstack-sdks | 21:29 | |
| cdent | elmiko: you still around? I think we're going to need to take https://review.openstack.org/#/c/190743/ back to the drawing board? | 21:39 |
| *** pratikmallya has joined #openstack-sdks | 21:45 | |
| *** cdent has quit IRC | 21:49 | |
| *** annegentle has joined #openstack-sdks | 22:01 | |
| *** annegent_ has joined #openstack-sdks | 22:04 | |
| *** annegentle has quit IRC | 22:04 | |
| *** annegentle has joined #openstack-sdks | 22:04 | |
| *** annegent_ has quit IRC | 22:08 | |
| *** annegentle has quit IRC | 22:11 | |
| *** annegentle has joined #openstack-sdks | 22:11 | |
| *** kragniz_ is now known as kragniz | 22:12 | |
| *** annegentle has quit IRC | 22:22 | |
| *** jose4183 has quit IRC | 22:22 | |
| *** thrash is now known as thrash|g0ne | 22:22 | |
| *** boris-42 has joined #openstack-sdks | 22:23 | |
| *** dims has quit IRC | 22:24 | |
| *** dims has joined #openstack-sdks | 22:30 | |
| *** jamielennox|away is now known as jamielennox | 22:47 | |
| openstackgerrit | Lin Hua Cheng proposed openstack/python-openstackclient: Drop explicit logger definition (volume) https://review.openstack.org/269613 | 22:52 |
| openstackgerrit | Lin Hua Cheng proposed openstack/python-openstackclient: Drop explicit logger definition (volume) https://review.openstack.org/269613 | 22:54 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 22:54 | |
| *** mordred has quit IRC | 23:04 | |
| *** lhcheng_ has joined #openstack-sdks | 23:05 | |
| *** mordred has joined #openstack-sdks | 23:05 | |
| *** lhcheng__ has joined #openstack-sdks | 23:06 | |
| *** e0ne has quit IRC | 23:07 | |
| *** lhcheng has quit IRC | 23:07 | |
| *** dims has quit IRC | 23:07 | |
| *** lhcheng_ has quit IRC | 23:09 | |
| *** hitalia has joined #openstack-sdks | 23:11 | |
| *** johnthetubaguy has quit IRC | 23:13 | |
| *** pratikmallya has quit IRC | 23:16 | |
| *** johnthetubaguy has joined #openstack-sdks | 23:16 | |
| etoews | elmiko: sorry i missed you. i had a busy day getting things squared away before taking the next couple of days off. see you next week! | 23:20 |
| *** terrylhowe has quit IRC | 23:25 | |
| *** gildub has joined #openstack-sdks | 23:30 | |
| *** dims has joined #openstack-sdks | 23:32 | |
| *** jaypipes has quit IRC | 23:32 | |
| *** lhcheng__ has quit IRC | 23:38 | |
| *** lhcheng has joined #openstack-sdks | 23:41 | |
| *** gildub has quit IRC | 23:44 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 23:46 | |
| elmiko | etoews: no worries, enjoy the time off! =) | 23:59 |
| elmiko | i was mainly just commenting on the review, nothing major | 23:59 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!