*** singhj has quit IRC | 00:08 | |
*** jamielennox is now known as jamielennox|away | 00:49 | |
*** zhurong has joined #openstack-sdks | 01:12 | |
*** yanyanhu has joined #openstack-sdks | 01:15 | |
*** bvandewa has quit IRC | 01:28 | |
*** jamielennox|away is now known as jamielennox | 01:34 | |
*** hoangcx has joined #openstack-sdks | 02:04 | |
openstackgerrit | QiangTang proposed openstack/osc-lib: Prevent null key setting for property https://review.openstack.org/345305 | 02:05 |
---|---|---|
*** zhurong has quit IRC | 02:24 | |
*** zhurong has joined #openstack-sdks | 02:24 | |
*** jamielennox is now known as jamielennox|away | 02:32 | |
*** gouthamr_ has quit IRC | 02:51 | |
openstackgerrit | QiangTang proposed openstack/osc-lib: Add reno for osc-lib release notes management https://review.openstack.org/348210 | 02:53 |
*** yuanying_ has quit IRC | 02:57 | |
*** mbonell has joined #openstack-sdks | 02:58 | |
*** thrash is now known as thrash|g0ne | 03:00 | |
openstackgerrit | QiangTang proposed openstack/osc-lib: Add reno for osc-lib release notes management https://review.openstack.org/348210 | 03:06 |
openstackgerrit | QiangTang proposed openstack/python-openstackclient: Update the description of project in releasenotes. https://review.openstack.org/348704 | 03:13 |
openstackgerrit | Merged openstack/osc-lib: Updated from global requirements https://review.openstack.org/348655 | 03:34 |
*** yuanying has joined #openstack-sdks | 03:51 | |
*** hieulq has joined #openstack-sdks | 03:51 | |
*** mbonell has quit IRC | 04:06 | |
*** NanKe has joined #openstack-sdks | 04:59 | |
openstackgerrit | QiangTang proposed openstack/osc-lib: Add reno for osc-lib release notes management https://review.openstack.org/348210 | 05:01 |
openstackgerrit | Merged openstack/keystoneauth: Updated from global requirements https://review.openstack.org/348629 | 05:09 |
*** amitkqed has quit IRC | 05:19 | |
*** yanyanhu has quit IRC | 05:19 | |
*** amitkqed has joined #openstack-sdks | 05:20 | |
*** yanyanhu has joined #openstack-sdks | 05:21 | |
*** amotoki has joined #openstack-sdks | 05:46 | |
openstackgerrit | Merged openstack/python-openstackclient: Updated from global requirements https://review.openstack.org/348680 | 05:51 |
*** gouthamr has joined #openstack-sdks | 06:01 | |
*** gouthamr has quit IRC | 06:10 | |
*** e0ne has joined #openstack-sdks | 06:12 | |
*** hoangcx has quit IRC | 06:42 | |
*** bvandewa has joined #openstack-sdks | 07:16 | |
*** yanyanhu has quit IRC | 07:17 | |
*** gildub has quit IRC | 07:19 | |
*** sheel has joined #openstack-sdks | 07:32 | |
*** fzdarsky|afk has joined #openstack-sdks | 07:44 | |
*** bvandewa has quit IRC | 07:45 | |
*** e0ne has quit IRC | 08:00 | |
*** fzdarsky has joined #openstack-sdks | 08:11 | |
*** fzdarsky|afk has quit IRC | 08:11 | |
*** bvandewa has joined #openstack-sdks | 08:32 | |
*** NanKe has quit IRC | 08:42 | |
*** NanKe has joined #openstack-sdks | 08:44 | |
*** hoangcx has joined #openstack-sdks | 08:46 | |
*** yanyanhu has joined #openstack-sdks | 08:51 | |
*** e0ne has joined #openstack-sdks | 08:52 | |
*** amotoki has quit IRC | 08:56 | |
*** amotoki has joined #openstack-sdks | 09:00 | |
*** e0ne has quit IRC | 09:05 | |
*** yanyanhu has quit IRC | 09:20 | |
*** bvandewa has quit IRC | 09:27 | |
*** cdent has joined #openstack-sdks | 09:49 | |
*** Klumben has quit IRC | 09:54 | |
*** Romanenko_K has joined #openstack-sdks | 09:56 | |
*** Klumben has joined #openstack-sdks | 09:58 | |
*** e0ne has joined #openstack-sdks | 10:01 | |
*** zhurong has quit IRC | 10:03 | |
*** Qiming has quit IRC | 10:08 | |
*** e0ne has quit IRC | 10:12 | |
*** Qiming has joined #openstack-sdks | 10:13 | |
*** sheel has quit IRC | 10:16 | |
*** gildub has joined #openstack-sdks | 10:16 | |
*** sdague has joined #openstack-sdks | 10:19 | |
*** Qiming has quit IRC | 10:25 | |
*** Qiming has joined #openstack-sdks | 10:27 | |
*** hoangcx has quit IRC | 10:33 | |
*** Qiming has quit IRC | 10:46 | |
*** Qiming has joined #openstack-sdks | 10:52 | |
*** Qiming has quit IRC | 10:57 | |
*** e0ne has joined #openstack-sdks | 10:58 | |
*** e0ne has quit IRC | 11:01 | |
*** Qiming has joined #openstack-sdks | 11:01 | |
*** Romanenko_K has quit IRC | 11:10 | |
*** lucasagomes is now known as lucas-hungry | 11:14 | |
*** rtheis has joined #openstack-sdks | 11:21 | |
*** Romanenko_K has joined #openstack-sdks | 11:24 | |
*** tangchen has quit IRC | 11:40 | |
*** tangchen_ has quit IRC | 11:40 | |
*** thrash|g0ne is now known as thrash | 11:41 | |
*** tangchen_ has joined #openstack-sdks | 11:42 | |
*** tangchen has joined #openstack-sdks | 11:42 | |
*** e0ne has joined #openstack-sdks | 11:51 | |
*** tangchen has quit IRC | 11:58 | |
*** tangchen_ has quit IRC | 11:58 | |
*** lucas-hungry is now known as lucasagomes | 12:20 | |
*** edleafe is now known as figleaf | 12:21 | |
*** NanKe has quit IRC | 12:41 | |
*** NanKe has joined #openstack-sdks | 12:46 | |
*** _elmiko is now known as elmiko | 12:48 | |
*** edmondsw has joined #openstack-sdks | 12:54 | |
*** NanKe has quit IRC | 13:05 | |
openstackgerrit | Merged openstack/python-openstackclient: Update the description of project in releasenotes. https://review.openstack.org/348704 | 13:13 |
*** gouthamr has joined #openstack-sdks | 13:18 | |
openstackgerrit | Merged openstack/python-openstackclient: Pass security group id to novaclient while adding security group to server https://review.openstack.org/348463 | 13:21 |
*** cleong has joined #openstack-sdks | 13:22 | |
*** michaelgugino has joined #openstack-sdks | 13:26 | |
*** cdent_ has joined #openstack-sdks | 13:33 | |
*** cdent has quit IRC | 13:36 | |
*** cdent_ is now known as cdent | 13:36 | |
*** gildub has quit IRC | 13:53 | |
*** edmondsw has quit IRC | 13:56 | |
*** amotoki has quit IRC | 13:58 | |
openstackgerrit | Dean Troyer proposed openstack/python-openstackclient: osc-lib: shell https://review.openstack.org/346113 | 13:59 |
*** edmondsw has joined #openstack-sdks | 14:34 | |
*** cdent has quit IRC | 14:36 | |
*** zhurong has joined #openstack-sdks | 14:40 | |
*** david-lyle has joined #openstack-sdks | 14:42 | |
*** zhurong_ has joined #openstack-sdks | 14:44 | |
*** zhurong has quit IRC | 14:46 | |
*** david-lyle has quit IRC | 14:47 | |
*** cdent has joined #openstack-sdks | 14:49 | |
*** mbonell has joined #openstack-sdks | 15:03 | |
*** mbonell has quit IRC | 15:09 | |
*** singhj has joined #openstack-sdks | 15:10 | |
*** e0ne has quit IRC | 15:14 | |
*** mbonell has joined #openstack-sdks | 15:17 | |
*** david-lyle has joined #openstack-sdks | 15:23 | |
*** zhurong_ has quit IRC | 15:28 | |
openstackgerrit | Merged openstack/python-openstackclient: Implement network rbac create and delete commands https://review.openstack.org/346705 | 15:47 |
*** sdague has quit IRC | 15:59 | |
*** mbonell has quit IRC | 16:06 | |
*** mbonell has joined #openstack-sdks | 16:06 | |
*** bvandewa has joined #openstack-sdks | 16:14 | |
*** bvandewa has quit IRC | 16:15 | |
*** mbonell has quit IRC | 16:24 | |
*** mbonell has joined #openstack-sdks | 16:24 | |
openstackgerrit | Merged openstack/osc-lib: Add reno for osc-lib release notes management https://review.openstack.org/348210 | 16:24 |
*** jamielennox|away is now known as jamielennox | 16:32 | |
*** mbonell has quit IRC | 16:39 | |
*** lucasagomes is now known as lucas-dinner | 16:41 | |
*** e0ne has joined #openstack-sdks | 16:45 | |
*** michaelgugino has quit IRC | 16:45 | |
*** mbonell has joined #openstack-sdks | 16:45 | |
*** e0ne has quit IRC | 16:46 | |
openstackgerrit | henry-nash proposed openstack/python-openstackclient: Add support for domain specific roles https://review.openstack.org/283554 | 16:50 |
*** mbonell has quit IRC | 16:50 | |
*** mbonell has joined #openstack-sdks | 16:51 | |
*** thrash is now known as thrash|biab | 16:56 | |
*** tangchen has joined #openstack-sdks | 16:56 | |
*** tangchen_ has joined #openstack-sdks | 16:56 | |
*** tangchen_ has quit IRC | 17:01 | |
*** tangchen has quit IRC | 17:01 | |
*** mbonell has quit IRC | 17:09 | |
*** sdague has joined #openstack-sdks | 17:17 | |
openstackgerrit | Brian Haley proposed openstack/python-openstackclient: Add Subnet service-types to subnets https://review.openstack.org/342976 | 17:19 |
*** mbonell has joined #openstack-sdks | 17:21 | |
*** singhj has quit IRC | 17:23 | |
*** jamielennox is now known as jamielennox|away | 17:35 | |
*** singhj has joined #openstack-sdks | 17:38 | |
*** Romanenko_K has quit IRC | 17:41 | |
*** singhj has quit IRC | 17:42 | |
*** mbonell has quit IRC | 17:49 | |
*** e0ne has joined #openstack-sdks | 17:50 | |
*** mbonell has joined #openstack-sdks | 17:57 | |
*** singhj has joined #openstack-sdks | 18:08 | |
*** singhj has quit IRC | 18:13 | |
openstackgerrit | Merged openstack/js-openstack-lib: Spec for ECMAScript 2015 and Transpiler support https://review.openstack.org/332458 | 18:21 |
openstackgerrit | Polly Zhou proposed openstack/microversion-parse: Convert dict headers and Webob headers into lowercase. https://review.openstack.org/347993 | 18:23 |
*** singhj has joined #openstack-sdks | 18:26 | |
*** thrash|biab is now known as thrash | 18:34 | |
rtheis | dtroyer: ping | 18:49 |
*** mbonell has quit IRC | 18:50 | |
*** mbonell has joined #openstack-sdks | 18:50 | |
dtroyer | rtheis: hey | 18:53 |
rtheis | dtroyer: neutron has several apis to list resources for a given resource... | 18:54 |
rtheis | dtroyer: something like "router list port" | 18:54 |
rtheis | dtroyer: but it appears that "router list" would hide a "router list port" command | 18:55 |
dtroyer | I'd look at "router list —port" for that | 18:55 |
dtroyer | or "port list —router <router>" | 18:55 |
dtroyer | My thinking is along the lins of "what is it you are listing?" | 18:55 |
*** mbonell has quit IRC | 18:55 | |
dtroyer | that is where the command should be, with filtering | 18:56 |
dtroyer | so my second example, not the first | 18:56 |
dtroyer | it is really the nested resource problem that we have not solved yet | 18:56 |
rtheis | dtroyer: okay, thanks | 18:57 |
rtheis | dtroyer: so the nested resource problem is what hides the "router list port" command? | 18:57 |
*** mctaylor has joined #openstack-sdks | 18:58 | |
rtheis | The command hiding is what is prompting a new "enumerate" action being considered in https://review.openstack.org/#/c/340624/18 | 18:59 |
dtroyer | I sw that, and don't like it | 19:00 |
dtroyer | I'm not talking about command hiding, which I assume is in regards to help and parsing? | 19:00 |
dtroyer | I am talking about the general problem of a resource A that has a one-to-many relationship with another resource B | 19:00 |
dtroyer | A==router, B==port in your example | 19:00 |
rtheis | okay | 19:01 |
dtroyer | how to cleanly list all of the Bs associated with a specific A | 19:01 |
dtroyer | there is a problem of output format, particualrly when you want output to contain multiple A resources | 19:01 |
dtroyer | but the general rule of the command format to do the listing | 19:01 |
dtroyer | that's why my first choice is to start with what it is you are actually listing (B, or ports) and aply A as a filter | 19:02 |
rtheis | okay, thanks | 19:02 |
dtroyer | we have this problem in a number of places | 19:03 |
rtheis | It seems like in this case "subports" cannot be listed on their own without the owning "network trunk". | 19:04 |
dtroyer | right now, that's where we put a list of B's into a single field in list and show outputs | 19:04 |
dtroyer | so subport list —trunk <trunk> would be required? | 19:04 |
rtheis | I think so | 19:04 |
rtheis | maybe turn the option into positional argument? | 19:05 |
dtroyer | is a subport a regular port that has been assigned to a trunk? oris it differnt? | 19:05 |
*** cleong has quit IRC | 19:05 | |
dtroyer | positionals are used for the resource names in the command | 19:05 |
rtheis | a subport is a regular port with additional metadata wrapping it | 19:06 |
rtheis | that is stored with the trunk | 19:07 |
dtroyer | ok, so should we always call it 'port' then? | 19:07 |
*** fifieldt has quit IRC | 19:07 | |
dtroyer | or is subport going to be what users will expect? | 19:07 |
rtheis | trunks have a parent port too | 19:07 |
rtheis | so they may expect subport | 19:07 |
dtroyer | ok. so then would it make sense to have 'subport list —trunk <trunk>' as a distinction? | 19:08 |
dtroyer | I'm not sure how I feel about that | 19:08 |
rtheis | yeah | 19:09 |
dtroyer | but if ports are called subports everywhere they are associated with a trunk (ignoring parent ports) then it might make sense to users | 19:09 |
rtheis | these subports would still show up with 'port list' | 19:10 |
rtheis | but no subport specific information for them | 19:11 |
dtroyer | so then a —trunk filter on port list would be more consistent with the other list commands | 19:11 |
dtroyer | that would get the subport info | 19:11 |
*** bnemec is now known as beekneemech | 19:12 | |
rtheis | yes that's another option | 19:12 |
rtheis | but then we bridge the trunk support between osc and neutron osc plugin | 19:12 |
dtroyer | so that hurries up our work to getting plugins to modify built-in commands, which has a lot of scary implications to it given we are dealing with credentials and trusting plugins | 19:13 |
rtheis | right | 19:13 |
rtheis | in the meantime 'subport list' could make sense too by itself | 19:13 |
rtheis | it could list all subports across all trunks | 19:14 |
dtroyer | right, and would be easy enough to transplant if/when it moves into the osc repo | 19:14 |
dtroyer | into the port command | 19:14 |
rtheis | sure | 19:14 |
dtroyer | I could imagine where you might want a subport list filtered by all trunks on a specific router. | 19:15 |
rtheis | sure | 19:15 |
dtroyer | but that can still fit into port list | 19:15 |
rtheis | dtroyer: are you okay with 'subport' as the object or would you prefer 'network subport' ? | 19:17 |
dtroyer | I really want to minimize the use of the API names like that… we have port already, subport seems the right match | 19:18 |
dtroyer | I can't think of where else port or subport would be used… | 19:18 |
*** fifieldt has joined #openstack-sdks | 19:18 | |
dtroyer | famous last words... | 19:18 |
rtheis | :) | 19:18 |
rtheis | sounds good | 19:18 |
rtheis | thanks for working through this with me | 19:19 |
*** fzdarsky is now known as fzdarsky|afk | 19:19 | |
*** fzdarsky|afk has quit IRC | 19:19 | |
dtroyer | np, the networking stuff gets gnarly, and helps sanity check what we already have | 19:19 |
rtheis | definitely | 19:19 |
*** bvandewa has joined #openstack-sdks | 19:22 | |
*** edmondsw has quit IRC | 19:35 | |
*** bvandewa has quit IRC | 19:35 | |
*** e0ne has quit IRC | 20:04 | |
*** bvandewa has joined #openstack-sdks | 20:12 | |
rtheis | dtroyer: still around? | 20:26 |
dtroyer | rtheis: yup | 20:26 |
rtheis | more trunk questions | 20:27 |
rtheis | https://review.openstack.org/#/c/340624/18 | 20:27 |
rtheis | see my latest comment | 20:27 |
rtheis | on add/remove versus set/unset | 20:27 |
rtheis | I'm not sure which is best way to go | 20:28 |
dtroyer | frankly, if trunk is really metadata on ports, it should have been implemented like that. | 20:30 |
dtroyer | in this case, add/remove fits the model better | 20:31 |
dtroyer | but we didn't anticipate adding multiple in one command | 20:31 |
dtroyer | port set —trunk <trunk> <port> seems cleaner to me | 20:32 |
dtroyer | still doesn't get multiple in one command though | 20:32 |
dtroyer | how important is that? | 20:32 |
rtheis | I'm not sure | 20:32 |
rtheis | trunk create --subport | 20:33 |
rtheis | subport can be set on create | 20:33 |
dtroyer | so how about this? | 20:33 |
rtheis | which is why I was thinking trunk set --subport | 20:33 |
dtroyer | trunk add subport <trunk> <subport> <subport> … | 20:33 |
dtroyer | multiple positionals? | 20:33 |
dtroyer | min == 2 | 20:33 |
dtroyer | we havent done that anywhere else yet, but it fits the model | 20:34 |
rtheis | The problem is that each subport needs segmentation ID and type set | 20:34 |
dtroyer | would extend the rules slightly | 20:34 |
dtroyer | (no doc in that review yet) how is that handled in create? | 20:35 |
dtroyer | multiple options? | 20:35 |
rtheis | one option | 20:35 |
dtroyer | can we use the same syntax to make it one positional then? | 20:35 |
rtheis | --sub-port <port=,segmentation-type=,segmentation-id=> | 20:35 |
dtroyer | ah, but there is an additional port name/id? | 20:36 |
rtheis | yes port= is name/id | 20:36 |
rtheis | That option can be repeated | 20:36 |
*** cardeois_ has joined #openstack-sdks | 20:36 | |
dtroyer | so since the add is more than just an add, it is an add + set, it makes this hard ;) | 20:36 |
dtroyer | there is a convention for doing this, but I'm not sure if argparse can handle it | 20:37 |
dtroyer | trunk add —opt1 aaa —opt 2 bbb port1 —opt1 ccc —opt2 ddd port2 | 20:38 |
dtroyer | so it is processed in command order, and whatever options are in place get used when the positional comes | 20:38 |
dtroyer | I think tar does this | 20:38 |
dtroyer | it's obscure though and would be totally confusing for many users | 20:38 |
rtheis | I agree | 20:39 |
dtroyer | right now I don't see a clean way to do more than one add per command | 20:39 |
rtheis | I didn't understand your comment about add + set | 20:39 |
dtroyer | the real operation being performed here is adding a subport to a trunk, and setting some metadata on that combination. | 20:40 |
rtheis | ah yes, I understand now | 20:40 |
dtroyer | in pure port terms, it is setting a trunk and other metadata on a port | 20:40 |
dtroyer | which I still think is cleaner | 20:40 |
dtroyer | but get a lot of pushback from folks on… volume-type had this a while back | 20:41 |
dtroyer | they wanted a new resource name for what amounted to more properties on volume-type, because it was a separate table in the database | 20:41 |
*** gouthamr has quit IRC | 20:41 | |
dtroyer | that stuff shouldn't leak | 20:41 |
rtheis | dtroyer: so with --sub-port <port=,segmentation-type=,segmentation-id=> on 'network trunk create' ... could they do the same on 'network trunk set' | 20:43 |
rtheis | or is that not good either? | 20:43 |
dtroyer | create and set should usually be very similar, so that should be ok. is create already like that? | 20:43 |
rtheis | yes | 20:44 |
rtheis | you can do 'network trunk create --sub-port <port=,segmentation-type=,segmentation-id=>' | 20:44 |
rtheis | and repeat --sub-port | 20:44 |
dtroyer | oh, well then… even if add has the options, set needs it too. and that then makes adding it to add unnecessary ;) | 20:45 |
dtroyer | create is nearly always a subset of set | 20:45 |
dtroyer | in theory anyway | 20:45 |
rtheis | sure | 20:45 |
rtheis | thanks dtroyer | 20:46 |
dtroyer | anytime | 20:46 |
*** cdent has quit IRC | 20:50 | |
*** cardeois_ is now known as cardeois | 21:00 | |
*** cdent has joined #openstack-sdks | 21:04 | |
*** bvandewa has quit IRC | 21:04 | |
*** singhj has quit IRC | 21:07 | |
*** singhj has joined #openstack-sdks | 21:11 | |
*** cdent has quit IRC | 21:12 | |
*** singhj has quit IRC | 21:23 | |
*** singhj has joined #openstack-sdks | 21:25 | |
*** elmiko is now known as _elmiko | 21:32 | |
*** bvandewa has joined #openstack-sdks | 21:35 | |
openstackgerrit | Dean Troyer proposed openstack/python-openstackclient: Add shell integration test https://review.openstack.org/349079 | 21:40 |
*** dims_ has quit IRC | 21:44 | |
*** dims has joined #openstack-sdks | 21:46 | |
*** singhj has quit IRC | 21:48 | |
*** rtheis has quit IRC | 21:49 | |
*** singhj has joined #openstack-sdks | 21:50 | |
*** singhj has quit IRC | 21:56 | |
*** bvandewa has quit IRC | 21:57 | |
*** singhj has joined #openstack-sdks | 21:58 | |
*** singhj has quit IRC | 22:03 | |
*** mctaylor has quit IRC | 22:14 | |
*** singhj has joined #openstack-sdks | 22:15 | |
*** cardeois has quit IRC | 22:34 | |
*** mctaylor has joined #openstack-sdks | 22:43 | |
*** mctaylor has quit IRC | 22:44 | |
*** mctaylor has joined #openstack-sdks | 22:45 | |
*** gouthamr has joined #openstack-sdks | 22:45 | |
*** singhj has quit IRC | 22:50 | |
*** singhj has joined #openstack-sdks | 22:52 | |
*** GreenBlood has quit IRC | 22:56 | |
*** kuzko has quit IRC | 22:56 | |
*** sdague has quit IRC | 22:59 | |
openstackgerrit | Merged openstack/keystoneauth: Fix arguments to _auth_required() https://review.openstack.org/348523 | 22:59 |
*** mctaylor has quit IRC | 23:08 | |
*** singhj has quit IRC | 23:08 | |
*** thrash is now known as thrash|wknd | 23:32 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!