*** jamielennox is now known as jamielennox|away | 00:07 | |
*** purplerbot has quit IRC | 00:11 | |
*** jamielennox|away is now known as jamielennox | 00:11 | |
*** markvoelker has quit IRC | 00:12 | |
*** vdrok has quit IRC | 00:12 | |
*** johnsom has quit IRC | 00:12 | |
*** purplerbot has joined #openstack-sdks | 00:12 | |
*** markvoelker has joined #openstack-sdks | 00:12 | |
*** hongbin has quit IRC | 00:15 | |
*** vdrok has joined #openstack-sdks | 00:22 | |
*** johnsom has joined #openstack-sdks | 00:22 | |
*** vdrok has quit IRC | 00:25 | |
*** vdrok has joined #openstack-sdks | 00:25 | |
*** johnsom has quit IRC | 00:25 | |
*** johnsom has joined #openstack-sdks | 00:25 | |
openstackgerrit | Merged openstack/osc-lib: To display image size in human friendly format https://review.openstack.org/418553 | 00:27 |
---|---|---|
*** huanxuan has joined #openstack-sdks | 01:22 | |
*** yanyanhu has joined #openstack-sdks | 01:32 | |
*** briancurtin has joined #openstack-sdks | 01:35 | |
*** namnh has joined #openstack-sdks | 01:39 | |
*** markvoelker has quit IRC | 01:43 | |
*** markvoelker has joined #openstack-sdks | 01:44 | |
*** markvoelker has quit IRC | 01:49 | |
*** kevo has quit IRC | 01:59 | |
*** john-davidge has joined #openstack-sdks | 02:01 | |
*** john-davidge has quit IRC | 02:05 | |
openstackgerrit | Steve Martinelli proposed openstack/osc-lib: Implement auth caching https://review.openstack.org/359489 | 02:07 |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: To display image size in human friendly format https://review.openstack.org/398126 | 02:08 |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: To display image size in human friendly format https://review.openstack.org/398126 | 02:09 |
Qiming | stevemar, available for a quick sync? | 02:15 |
jiahui | stevemar: When i want to fix the bug in osc network, i find the result of my functional test is different with the Jenkins. I also test the command like "openstack network create", it is ok in my local environment. | 02:21 |
Qiming | jiahui, speaking of bug in osc network, are you referring to the ones triggered by by SDK refactoring? | 02:22 |
jiahui | stevemar: I have upgrade my local python-openstackclient. | 02:22 |
stevemar | Qiming: jiahui hey hey | 02:23 |
jiahui | Qiming: YES:). | 02:23 |
Qiming | cool. | 02:23 |
Qiming | good to know there are hands working on this | 02:23 |
stevemar | jiahui: hmm, can you check what version of the SDK you are using in your local box? | 02:24 |
stevemar | jiahui: i think in the gate, we now block SDK v0.9.12 | 02:24 |
jiahui | stevemar: SDK v0.9.10 in my box | 02:26 |
stevemar | jiahui: i think the gate will test with that too | 02:27 |
stevemar | jiahui: which patch are you referring to? | 02:27 |
jiahui | stevemar: I have look the skip you have done in https://review.openstack.org/#/c/417576/ | 02:29 |
*** chlong has quit IRC | 02:32 | |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Revert "Updated from global requirements" https://review.openstack.org/418650 | 02:35 |
stevemar | jiahui: ah let me see -- the gate is currently testing with sdk 0.9.10 i believe, let's see what happens with ^ | 02:49 |
jiahui | stevemar: thank you steve :) | 02:53 |
*** annp has joined #openstack-sdks | 03:07 | |
openstackgerrit | Merged openstack/osc-lib: Calls to federated service providers using Keystone-to-Keystone https://review.openstack.org/371709 | 03:08 |
*** gouthamr has quit IRC | 03:21 | |
*** amotoki has quit IRC | 03:21 | |
jiahui | stevermar:I run the command "tox -e functional openstackclient.tests.functional.network.v2" to test all network functional tests, it fails 3 tests. I reinstall devstack ,the same three tests fail. | 03:23 |
*** amotoki has joined #openstack-sdks | 03:29 | |
*** salv-orl_ has quit IRC | 03:32 | |
*** salv-orlando has joined #openstack-sdks | 03:32 | |
*** amotoki has quit IRC | 03:33 | |
*** markvoelker has joined #openstack-sdks | 03:36 | |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Revert "Updated from global requirements" https://review.openstack.org/418650 | 03:41 |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Revert "Updated from global requirements" https://review.openstack.org/418650 | 03:49 |
*** abhiraut has joined #openstack-sdks | 04:16 | |
*** salv-orl_ has joined #openstack-sdks | 04:23 | |
*** salv-orlando has quit IRC | 04:26 | |
*** sheel has joined #openstack-sdks | 04:34 | |
*** adriant has quit IRC | 04:47 | |
*** abhiraut has quit IRC | 04:53 | |
stevemar | jiahui: https://review.openstack.org/#/c/418650/ should have functional test results with SDK v0.9.12 | 05:20 |
stevemar | in about 30 minutes :) | 05:20 |
openstackgerrit | zhiyong.dai proposed openstack/python-openstackclient: Update functional test for aggregate. https://review.openstack.org/418685 | 05:22 |
openstackgerrit | jiahui.qiang proposed openstack/python-openstackclient: Fix filter error in os volume list https://review.openstack.org/416852 | 05:40 |
*** john-davidge has joined #openstack-sdks | 06:03 | |
*** john-davidge has quit IRC | 06:08 | |
*** dims has quit IRC | 06:13 | |
jiahui | stevemar: Yes, i am thinking about how to upgrade my local SDK to SDK v0.9.12. It should be late in your place and good night! Thank you steve :) | 06:18 |
*** dfflanders has quit IRC | 06:19 | |
*** sheel has quit IRC | 06:37 | |
openstackgerrit | Reedip proposed openstack/python-openstacksdk: Fix quota show output https://review.openstack.org/418729 | 06:40 |
*** gildub has quit IRC | 07:15 | |
*** amotoki has joined #openstack-sdks | 07:28 | |
RuiChen | hi jiahui if you want to update your local sdk to 0.9.12, you should modify your local /opt/stack/requirements/upper-constraints.txt, then change python-openstackclient/tox.ini, like this {env:UPPER_CONSTRAINTS_FILE:/opt/stack/requirements/upper-constraints.txt} | 07:40 |
*** ralonsoh has joined #openstack-sdks | 07:48 | |
jiahui | RuiChen: hi ,thank you for your advice. Is the gate testing with sdk 0.9.10? I find 'functional installed: ...openstacksdk==0.9.10...', when i read this http://logs.openstack.org/50/418650/3/check/gate-osc-dsvm-functional-ubuntu-xenial/7c4daa7/console.html | 07:55 |
*** hogepodge has quit IRC | 07:56 | |
RuiChen | jiahui: yes, current gate run on 0.9.10 https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L214 | 08:01 |
RuiChen | jiahui: I found export UPPER_CONSTRAINTS_FILE=/opt/stack/requirements/upper-constraints.txt is better way :-) | 08:12 |
jiahui | RuiChen: Thank you, it is so helpful to me! | 08:13 |
*** amotoki has quit IRC | 08:16 | |
*** salv-orl_ has quit IRC | 08:21 | |
*** Matias has quit IRC | 08:37 | |
*** Matias has joined #openstack-sdks | 08:43 | |
*** kevo has joined #openstack-sdks | 08:54 | |
*** namnh has quit IRC | 09:20 | |
*** amotoki has joined #openstack-sdks | 09:22 | |
reedip | anyone here ?? | 09:31 |
reedip | RuiChen, dtroyer, stevemar ?? | 09:31 |
RuiChen | yeah reedip | 09:32 |
reedip | RuiChen : question | 09:32 |
reedip | RuiChen, dtroyer, stevemar : while working on Neutron's quota update API, I found that this bug exists : https://bugs.launchpad.net/python-openstackclient/+bug/1655445 | 09:33 |
openstack | Launchpad bug 1655445 in python-openstackclient "Cannot update subnetpool quota" [Undecided,New] - Assigned to Reedip (reedip-banerjee) | 09:33 |
RuiChen | so your question is ? | 09:34 |
reedip | RuiChen, dtroyer, stevemar : I found that the issue is because of this line: https://github.com/openstack/python-openstacksdk/blob/master/openstack/proxy2.py#L64 | 09:35 |
reedip | RuiChen, dtroyer, stevemar : now not all End Points accept id=PROJECT_ID for each type of resource. | 09:36 |
reedip | for example, Neutron doesnt accept Project ID while updating the quotas | 09:36 |
reedip | Now, changing Neutron API would take some time and as we are near Ocata-3 , I am not sure if it would be accepted. | 09:36 |
*** lucas-afk is now known as lucasagomes | 09:38 | |
RuiChen | i'm not clear your means, let me check the bug details | 09:40 |
reedip | RuiChen: Sure, I will wait | 09:41 |
RuiChen | I try the command in my env, no error exist, something I miss? (openstack) quota set --subnetpools 1234 ${proejct_id} | 09:45 |
RuiChen | my openstack sdk is openstacksdk-0.9.10 | 09:46 |
reedip | How do I check my openstacksdk ? | 09:49 |
reedip | I mean RuiChen how do I check my version of openstacksdk | 09:50 |
RuiChen | in your python install dir site-package | 09:50 |
RuiChen | pip freeze | 09:51 |
reedip | I have openstacksdk==0.9.12 | 09:51 |
*** john-davidge has joined #openstack-sdks | 09:52 | |
RuiChen | seems it cause by the bug https://bugs.launchpad.net/python-openstackclient/+bug/1652317 | 09:53 |
openstack | Launchpad bug 1652317 in Manila "OpenStackSDK refactoring caused various OSC networking commands to fail" [Critical,New] | 09:53 |
reedip | RuiChen : Okay | 09:54 |
reedip | RuiChen : my bug may not be caused due to returning dicts , but yes it doesnt accept ID in it as mentioned in https://bugs.launchpad.net/python-openstackclient/+bug/1652317/comments/13 | 09:55 |
openstack | Launchpad bug 1652317 in Manila "OpenStackSDK refactoring caused various OSC networking commands to fail" [Critical,New] | 09:55 |
*** e0ne has joined #openstack-sdks | 10:02 | |
RuiChen | reedip: yeah, I decide to install sdk 0.9.12, try to find out something wrong about it :) | 10:03 |
reedip | :D | 10:15 |
*** kevo has quit IRC | 10:16 | |
reedip | RuiChen: I resolved it in a PS | 10:34 |
reedip | can you try the patch and lemme know of the result ? | 10:35 |
reedip | Basically I modified the refactoring of Openstack SDK for this fix. | 10:35 |
reedip | RuiChen : Never mind, anyways I am looking into this bug, will post the PS today | 10:43 |
RuiChen | I will go to dinner in a moment, sorry, please show me the patch link, I will check it when I have time | 10:46 |
*** aarefiev has joined #openstack-sdks | 10:47 | |
*** aarefiev_afk has quit IRC | 10:50 | |
*** cdent has joined #openstack-sdks | 11:00 | |
*** sdague has joined #openstack-sdks | 11:15 | |
*** yanyanhu has quit IRC | 11:24 | |
*** annp has quit IRC | 11:29 | |
*** dims has joined #openstack-sdks | 11:39 | |
*** huanxuan has quit IRC | 11:58 | |
*** huanxuan has joined #openstack-sdks | 12:00 | |
*** huanxuan has quit IRC | 12:00 | |
*** rtheis has joined #openstack-sdks | 12:09 | |
*** amotoki has quit IRC | 12:14 | |
*** amotoki has joined #openstack-sdks | 12:26 | |
*** huanxuan has joined #openstack-sdks | 12:30 | |
openstackgerrit | yuval shalev proposed openstack/python-openstacksdk: Added project role assignment https://review.openstack.org/416598 | 12:31 |
*** jiahui has quit IRC | 12:38 | |
*** fzdarsky has joined #openstack-sdks | 12:42 | |
*** lucasagomes is now known as lucas-hungry | 12:50 | |
*** amotoki has quit IRC | 12:50 | |
*** amotoki has joined #openstack-sdks | 13:00 | |
*** amotoki has quit IRC | 13:02 | |
*** amotoki has joined #openstack-sdks | 13:05 | |
*** chlong has joined #openstack-sdks | 13:07 | |
*** amotoki has quit IRC | 13:28 | |
*** amotoki has joined #openstack-sdks | 13:39 | |
*** lucas-hungry has quit IRC | 13:41 | |
*** annegentle has joined #openstack-sdks | 13:45 | |
openstackgerrit | Huanxuan Ao proposed openstack/python-openstackclient: Add "encryption-*" options in volume type commands https://review.openstack.org/414197 | 13:47 |
*** lucasagomes has joined #openstack-sdks | 13:47 | |
*** _elmiko is now known as elmiko | 13:55 | |
*** john-dav_ has joined #openstack-sdks | 13:55 | |
*** john-davidge has quit IRC | 13:55 | |
*** john-dav_ is now known as john-davidge | 13:56 | |
*** david-lyle has quit IRC | 13:56 | |
*** crinkle_ has quit IRC | 13:59 | |
*** amotoki has quit IRC | 13:59 | |
*** david-lyle has joined #openstack-sdks | 13:59 | |
*** crinkle_ has joined #openstack-sdks | 13:59 | |
*** lamt has joined #openstack-sdks | 14:01 | |
*** jamielennox is now known as jamielennox|away | 14:14 | |
*** david-lyle has quit IRC | 14:16 | |
*** fguillot has joined #openstack-sdks | 14:17 | |
*** annegentle has quit IRC | 14:18 | |
*** huanxuan has quit IRC | 14:26 | |
*** chlong has quit IRC | 14:37 | |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Run functional tests with SDK 0.9.12 https://review.openstack.org/418650 | 14:37 |
stevemar | dtroyer: so i pushed ^ -- we probably want that to be successful before releasing | 14:38 |
stevemar | it ensure we will work with the latest SDK release | 14:38 |
stevemar | cause right now our CI is passing, not because of skipped tests, but because the latest SDK versions are blacklisted | 14:39 |
*** amotoki has joined #openstack-sdks | 14:39 | |
*** lamt has quit IRC | 14:40 | |
*** cleong has joined #openstack-sdks | 14:51 | |
*** gouthamr has joined #openstack-sdks | 14:52 | |
dtroyer | stevemar: right… thanks | 15:01 |
dtroyer | I want to release osc-lib Real Soon Now | 15:02 |
dtroyer | I'm still not sure I want to force-include keyring, we've already been down that road… | 15:02 |
dtroyer | stevemar: I'm thinking we need to add OSC functional tests to osc-lib and the sdk jobs... | 15:04 |
*** hongbin has joined #openstack-sdks | 15:06 | |
stevemar | dtroyer: definitely need to do that | 15:15 |
dtroyer | so osc-lib auth cache… include or not? I'll release now if we leave it out | 15:16 |
stevemar | i am negative on that | 15:16 |
stevemar | untested (mostly) | 15:16 |
dtroyer | roger that… agreed | 15:17 |
stevemar | dtroyer: want to add a functional test job to osc-lib before releasing? | 15:17 |
stevemar | or are you comfortable enough to release? | 15:17 |
stevemar | i think the changes were mostly additive | 15:17 |
dtroyer | depends on how long it takes to get it added :) | 15:17 |
dtroyer | I made those compat-changes, the case I am concerned about we get in the dsvm jobs (using env vars for auth) | 15:18 |
*** john-davidge has quit IRC | 15:18 | |
* stevemar puts on his infra thinking hat | 15:18 | |
dtroyer | rather, using having the comat bits in osc-lib and also in osc | 15:18 |
*** john-davidge has joined #openstack-sdks | 15:19 | |
dtroyer | in one case it's doing double work and is not (should not be) harmful | 15:19 |
stevemar | dtroyer: looks like only one thing is failing with sdk 0.9.12 -- http://logs.openstack.org/50/418650/4/check/gate-osc-dsvm-functional-ubuntu-xenial/abbb8d4/testr_results.html.gz ? | 15:19 |
dtroyer | woo! | 15:20 |
dtroyer | qos rule type... | 15:20 |
dtroyer | is anyone workign on that (I just skimmed the overnight scrollback) | 15:20 |
dtroyer | I'll jump on it after adding the func tests and releasing osc-lib | 15:20 |
stevemar | dtroyer: for the functional job in osc-lib... it should test with master osc-lib and master osc? | 15:20 |
dtroyer | we need that combination somewhere, but I was thinking master osc-lib with released osc | 15:21 |
dtroyer | we've found that dsvm jobs are insufficient for validating we don't break anything | 15:21 |
stevemar | right | 15:21 |
stevemar | dtroyer: i did the combination before but i don't recall how to do it, may take a few hours | 15:22 |
dtroyer | release osc + master osc-lib would be the default, right? | 15:22 |
dtroyer | ie, no extra work | 15:23 |
*** markvoelker has quit IRC | 15:28 | |
stevemar | i think so, but we'll need to run the functional tests *in* the osc repo, so i'm not sure how that works :\ | 15:29 |
dtroyer | ugh, right | 15:29 |
*** markvoelker has joined #openstack-sdks | 15:29 | |
stevemar | dtroyer: and we'll need to probably run the master version of those tests? | 15:31 |
stevemar | dtroyer: you know, we could have another job in the OSC gate that tests osc-lib master and osc master | 15:31 |
stevemar | instead of osc-lib release and osc master | 15:31 |
stevemar | that'll be *really* easy | 15:31 |
stevemar | i think | 15:31 |
dtroyer | lets do it that way… in gate, check or experimental so it can go on-demand? | 15:32 |
stevemar | just copy+paste the old job and force it to install osc-lib in master | 15:32 |
stevemar | non-voting check for now i think | 15:32 |
dtroyer | kk | 15:33 |
*** markvoelker has quit IRC | 15:35 | |
stevemar | dtroyer: aside from copying https://github.com/openstack/python-openstackclient/blob/master/openstackclient/tests/functional/post_test_hook.sh and the 'functional' job | 15:37 |
stevemar | sorry | 15:37 |
stevemar | dtroyer: let me tell you in steps what i was going to do, see if you can think of a simpler way | 15:37 |
dtroyer | ok | 15:38 |
stevemar | 1) copy the functional job here, but call a different post_test_hook.sh, maybe post_test_osc_lib_hook.sh ? https://github.com/openstack-infra/project-config/blob/e172a5e4107f1774a77e212d82218086ed39329e/jenkins/jobs/osc.yaml#L2 | 15:38 |
stevemar | 2) copy https://github.com/openstack/python-openstackclient/blob/master/openstackclient/tests/functional/post_test_hook.sh to the new name and have it clone and install osc-lib master | 15:38 |
stevemar | 3) make money | 15:39 |
stevemar | i could get fancy and maybe set an ENV variable somewhere that says we're using osc-lib from master, but ... i know this will work | 15:40 |
dtroyer | I don't know the job stuff well enough to know the shortcuts, your plan sounds like it will work | 15:41 |
dtroyer | should we commit the shell script first? | 15:41 |
dtroyer | also, stable jobs? | 15:41 |
stevemar | the shell script will be in osc no? | 15:43 |
dtroyer | yes | 15:43 |
stevemar | oh i thought you were asking about getting that in before osc-lib is released | 15:44 |
stevemar | ignore me | 15:44 |
dtroyer | should we also do sdk? can we do both in the same job? | 15:44 |
dtroyer | so many questions! | 15:44 |
*** lucasagomes has quit IRC | 15:44 | |
dtroyer | a) I was thinking we'd want the new *-hook.sh merged before defining the job that calls it | 15:45 |
dtroyer | b) I'm still thinking through how this affects (or if it should?) stable jobs | 15:45 |
dtroyer | c) we should also do the sdk this way, can we do both in the same job in a sane manner? | 15:46 |
*** lucasagomes has joined #openstack-sdks | 15:46 | |
stevemar | dtroyer: i think we can | 15:47 |
dtroyer | o-c-c too? | 15:49 |
dtroyer | how much can we add??? :) | 15:50 |
dtroyer | those are the three primary break-risk libs for OSC | 15:50 |
*** john-davidge has quit IRC | 15:53 | |
*** markvoelker has joined #openstack-sdks | 15:57 | |
*** lamt has joined #openstack-sdks | 16:03 | |
*** salv-orlando has joined #openstack-sdks | 16:09 | |
*** chlong has joined #openstack-sdks | 16:11 | |
*** annegentle has joined #openstack-sdks | 16:13 | |
*** salv-orl_ has joined #openstack-sdks | 16:22 | |
*** salv-orlando has quit IRC | 16:25 | |
dtroyer | stevemar: I just got the same results in my local OSC functional tests (same devstack-related failures) for both current and master osc-lib. Are you OK with pushing the release now or do you still want to wait intil the new job is in? | 16:27 |
stevemar | dtroyer: i'm OK with pushing | 16:31 |
stevemar | dtroyer: i'm trying to figure out the pip command to install the sdk | 16:32 |
*** ankur-gupta-f has left #openstack-sdks | 16:32 | |
briancurtin | pip install openstacksdk | 16:32 |
*** ankur-gupta-f has joined #openstack-sdks | 16:32 | |
stevemar | hehe | 16:32 |
stevemar | briancurtin: from master instead? | 16:32 |
briancurtin | what? | 16:32 |
stevemar | i was thinking ... pip install -q -U -e "git+https://git.openstack.org/python-openstacksdk/openstacksdk.git#egg=openstacksdk" | 16:33 |
briancurtin | that probably works. or maybe egg=openstack. i can’t remember exactly what goes in the egg part | 16:33 |
stevemar | briancurtin: thats where i'm stumbling :) | 16:33 |
briancurtin | the PyPI package name is openstacksdk but the package that python itself deals with is called openstack, so maybe egg=openstack | 16:34 |
* dtroyer looks at git-installed pip | 16:34 | |
dtroyer | looks like egg=python_openstackclient is used for that case, so pypi package name? | 16:35 |
dtroyer | with '-' -> '_' mapping | 16:35 |
stevemar | dtroyer: sorta, pip install -q -U -e "git+https://git.openstack.org/openstack/osc-lib.git#egg=osc_lib" works for osc-lib | 16:36 |
dtroyer | so I'd expect #egg=puthon_openstacksdk to be the magic | 16:36 |
dtroyer | s/pu/py/ | 16:37 |
*** cdent has quit IRC | 16:38 | |
dtroyer | pip install -q -U -e "git+https://git.openstack.org/openstack/python-openstacksdk.git#egg=python_openstacksdk" | 16:38 |
dtroyer | appears to have worked for me | 16:38 |
stevemar | *smh* i had an extra openstack in there | 16:40 |
*** reedip_outofmemo has joined #openstack-sdks | 16:40 | |
reedip_outofmemo | briancurtin : ping | 16:41 |
briancurtin | reedip_outofmemo: what’s up | 16:41 |
reedip_outofmemo | briancurtin : hi , busy ? | 16:42 |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: add support for running tests with master dependencies https://review.openstack.org/419032 | 16:42 |
briancurtin | reedip_outofmemo: no, what’s up | 16:42 |
stevemar | dtroyer: ^ | 16:42 |
reedip_outofmemo | briancurtin : it was related to https://review.openstack.org/#/c/418729/ | 16:42 |
briancurtin | yeah, what is the question? | 16:42 |
reedip_outofmemo | briancurtin : earlier, quota show for openstackclient ( before 0.9.12 version ) was working smoothly | 16:43 |
reedip_outofmemo | with 0.9.12, there has been a change and quota show now fails | 16:43 |
reedip_outofmemo | briancurtin :https://bugs.launchpad.net/python-openstackclient/+bug/1655537 | 16:43 |
openstack | Launchpad bug 1655537 in python-openstackclient "Cannot see Network quota using "openstack quota show"" [Undecided,New] - Assigned to Reedip (reedip-banerjee) | 16:43 |
briancurtin | reedip_outofmemo: there was no change in 0.9.12, i think it was in 0.9.11, but this is an OSC problem and not an SDK problem | 16:44 |
reedip_outofmemo | briancurtin: the reason is though the Compute and Volume quotas are returned as dict, network quota is returned as an object | 16:44 |
reedip_outofmemo | briancurtin : ok , one question | 16:44 |
reedip_outofmemo | briancurtin : is the compute client and volume client part of Openstack SDK ? | 16:45 |
briancurtin | reedip_outofmemo: openstacksdk hasn’t explicitly returned dictionaries ever, though some time ago it did return objects that can act like dictionaries. compute hasn’t done that for probably 8 months | 16:45 |
reedip_outofmemo | briancurtin : like Network client | 16:45 |
briancurtin | reedip_outofmemo: I’m not sure, i don’t work on OSC. i think OSC only uses openstacksdk for the network related commands though, not for compute and volume | 16:45 |
reedip_outofmemo | stevemar : any suggestions related to above query ? | 16:46 |
dtroyer | reedip: briancurtin is correct re compute and volume quotas | 16:46 |
reedip_outofmemo | dtroyer : ok, so sdk is used only for Networks?????? | 16:46 |
dtroyer | the root problem is that OSC was not ready for the 0.9.11 changes in the SDK because our functioanl tests were producing false positives for a time | 16:46 |
dtroyer | reedip: yes | 16:47 |
reedip_outofmemo | briancurtin : one more query | 16:47 |
briancurtin | reedip_outofmemo: sure | 16:47 |
reedip_outofmemo | dtroyer :okay, then I will fix the bug in OSC and not SDK | 16:47 |
reedip_outofmemo | briancurtin : this is related to quota set | 16:47 |
dtroyer | OSc needs to work with sdk >= 0.9.10 for a while yet | 16:47 |
reedip_outofmemo | briancurtin : in openstack SDK , you updated the proxy2 | 16:47 |
reedip_outofmemo | briancurtin : https://github.com/openstack/python-openstacksdk/blob/master/openstack/proxy2.py#L64 | 16:49 |
briancurtin | correct, there is a proxy2 | 16:49 |
reedip_outofmemo | briancurtin : Neutron Quota set does not need the ID which is being passed here in the PUT request | 16:49 |
reedip_outofmemo | Neutron Quota API do not need the tenant/project ID as they have an endpoint in the quota resource itself for the tenant ID. For example. if Tenant ID is ABCDE , then Neutron has the quota endpoint for tenant as http://10.0.0.1:23423/v2/quotas/ABCDE.json | 16:50 |
briancurtin | so when building the request don’t make it require an ID. you might need to override the create method of the Quota resource and pass requires_id=False to the _prepare_request method https://github.com/openstack/python-openstacksdk/blob/master/openstack/resource2.py#L502 | 16:50 |
reedip_outofmemo | briancurtin : Yup , I am trying to do that | 16:51 |
*** cdent has joined #openstack-sdks | 16:51 | |
reedip_outofmemo | briancurtin : Just wanted to update you. There might be one more change, I will put up the patch tomorrow | 16:51 |
briancurtin | reedip_outofmemo: ok cool | 16:51 |
reedip_outofmemo | briancurtin : thanks , hope this resolves soon :) | 16:52 |
reedip_outofmemo | dtroyer : sorry for bugging you , but if OSC needs to work with SDK >=0.9.10, then should I just put a type check ? | 16:52 |
reedip_outofmemo | dtroyer: that would be simpler and can be removed once everything comes in line? Currently network quota is returned as an object, but earlier it was returned as a dict ( or something similar to a dict) | 16:53 |
dtroyer | reedip: there is currently a bit of compatibility code in the networking commands for this reason, do the same thing in the quota command and leave a note to remove it later | 16:55 |
reedip_outofmemo | dtroyer: aye aye ! | 16:56 |
dtroyer | dhellmann, stevemar: I'd like to do a cliff release this week yet, likely last before freeze. I'm OK with https://review.openstack.org/412742, chime in when you get a minute if we should include it or not... | 17:00 |
*** e0ne has quit IRC | 17:06 | |
stevemar | dtroyer: we can probably release without that patch, it's more for making sure our gates aren't busted | 17:09 |
stevemar | dtroyer: i've also released ksa for us, but getting blocked for the u-c bump | 17:09 |
stevemar | https://review.openstack.org/#/c/418608/ | 17:10 |
*** briancurtin has quit IRC | 17:11 | |
*** abhiraut has joined #openstack-sdks | 17:17 | |
openstackgerrit | Reedip proposed openstack/python-openstackclient: Fix quota show output https://review.openstack.org/419067 | 17:36 |
reedip_outofmemo | stevemar , briancurtin : ^^ | 17:38 |
openstackgerrit | Shashank Kumar Shankar proposed openstack/python-openstackclient: Introduce Neutron DHCP agent commands to OSC. https://review.openstack.org/387611 | 17:38 |
openstackgerrit | Shashank Kumar Shankar proposed openstack/python-openstackclient: Introduce Neutron DHCP agent commands to OSC. https://review.openstack.org/387611 | 17:44 |
*** abhiraut has quit IRC | 17:49 | |
*** kevo has joined #openstack-sdks | 17:50 | |
*** lucasagomes is now known as lucas-afk | 17:50 | |
*** aarefiev is now known as aarefiev_afk | 17:54 | |
*** ralonsoh has quit IRC | 18:03 | |
*** abhiraut has joined #openstack-sdks | 18:04 | |
*** abhiraut has quit IRC | 18:08 | |
*** reedip_outofmemo has quit IRC | 18:11 | |
*** david-lyle has joined #openstack-sdks | 18:16 | |
*** reedip_outofmemo has joined #openstack-sdks | 18:27 | |
ankur-gupta-f | dtroyer: here? | 18:30 |
dtroyer | ankur-gupta-f: yo | 18:30 |
ankur-gupta-f | Client functional tests :D | 18:31 |
ankur-gupta-f | so we tried the regexes | 18:31 |
ankur-gupta-f | now JSON | 18:31 |
ankur-gupta-f | but for existing patches can we leave regexes and follow up with JSON | 18:31 |
dtroyer | yes. it may still evolve more, I don't want you guys to chase too much of a moving target, OSC does that all the time anyway | 18:32 |
*** amotoki has quit IRC | 18:32 | |
dtroyer | ther are a couple of things I'd like to make sure get in theough, | 18:32 |
dtroyer | using addCleanup() is one of those | 18:32 |
dtroyer | that is more than a cosmentic/developer preference thing | 18:32 |
ankur-gupta-f | for everything created. | 18:33 |
ankur-gupta-f | I do like the change that every test does the creation, <list, show, etc..> deletion | 18:33 |
ankur-gupta-f | Okay thats all. Thanks | 18:34 |
dtroyer | stevemar: I ran the -efunctional-tips locally, no tests ran…do we need to include the ostestr command in that section? | 18:40 |
*** john-davidge has joined #openstack-sdks | 18:41 | |
*** chlong has quit IRC | 18:46 | |
cdent | elmiko: that link you tweeted a while ago to radanalytics wants auth? | 18:52 |
*** cdent has quit IRC | 18:53 | |
openstackgerrit | Dean Troyer proposed openstack/python-openstackclient: add support for running tests with master dependencies https://review.openstack.org/419032 | 18:56 |
*** chlong has joined #openstack-sdks | 18:59 | |
stevemar | dtroyer: thats a good question, the [fucntional] target doesn't have any ostestr stuff | 19:00 |
stevemar | dtroyer: do you know why we have to add ostestr to -tips but not the other? | 19:00 |
openstackgerrit | Merged openstack/python-openstackclient: Fix filter error in os volume list https://review.openstack.org/416852 | 19:01 |
dtroyer | I just added it to the command list. I think tox inherits from [env] if there isn't a command= | 19:01 |
thingee | dtroyer seems to be working now | 19:01 |
*** reedip_outofmemo has quit IRC | 19:02 | |
*** briancurtin has joined #openstack-sdks | 19:09 | |
thingee | sorry I missed that | 19:12 |
dtroyer | heh, I did too until I actually tried it :) | 19:18 |
stevemar | dtroyer: ahh, but since there is a command= there, it doesn't inherit from env | 19:20 |
openstackgerrit | Diana Clarke proposed openstack/python-openstackclient: WIP - Add nova microversion 2.40 support https://review.openstack.org/419108 | 19:29 |
*** amotoki has joined #openstack-sdks | 19:32 | |
openstackgerrit | Merged openstack/cliff: Add Constraints support https://review.openstack.org/412742 | 19:40 |
*** fguillot has quit IRC | 19:43 | |
*** salv-orl_ has quit IRC | 19:45 | |
openstackgerrit | Ankur proposed openstack/python-openstackclient: Add meter rule to OSC https://review.openstack.org/378058 | 19:49 |
*** e0ne has joined #openstack-sdks | 20:14 | |
stevemar | dtroyer: have you been keeping track of what networking commands broke and are fixed in osc? | 20:27 |
dtroyer | I don't have an exhaustive list… AFAIK only the qos rule type is left though? | 20:39 |
dtroyer | well, I haven't gone looking for the remaining skips yet | 20:39 |
dtroyer | erg, there are still 4 | 20:40 |
dtroyer | stevemar: do you recall how many tests were being skipped before this mess started? | 20:41 |
stevemar | only 4 (they were conditional on a networking extension) | 20:41 |
stevemar | we had no skipped tests otherwise | 20:41 |
dtroyer | ok then, your 418650 has them all then | 20:42 |
*** e0ne has quit IRC | 20:43 | |
openstackgerrit | Shashank Kumar Shankar proposed openstack/python-openstackclient: Introduce Neutron DHCP agent commands to OSC. https://review.openstack.org/387611 | 20:46 |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: unskip network qos rule type functional test https://review.openstack.org/419129 | 20:47 |
stevemar | dtroyer: ^ i think that one worked, just a bad test | 20:47 |
dtroyer | I think it is more than a bad test, I get a 404 when I try the command | 20:48 |
dtroyer | #$^%&%$#$!@#$%^*%&$#@#$%^*&^&%^%$@#^$&%&^*&%^$%#$@#!@#$^%&^ | 20:53 |
dtroyer | Why did we let an extension command into the main repo?????????????????? | 20:54 |
dtroyer | so nevermind my 404, I don't have the (*&^%$#$%^&*( extension enabled | 20:55 |
dtroyer | we gotta handle that better… and by better I mean at all | 20:56 |
dtroyer | Is ther any way to make the tests discover and auto-skip this? | 20:56 |
stevemar | dtroyer: i thought there was a discover and skip mechanism | 20:57 |
stevemar | i guess not, since it didn't skip for you | 20:57 |
stevemar | dtroyer: that test and command was created by rich back in the early networking days, before we had a fleshed out plan for extensions and had the neutron team on board | 20:58 |
dtroyer | hmmm… git sez it was committed on Aug 12 | 21:00 |
dtroyer | by https://github.com/ralonsoh | 21:00 |
dtroyer | well, that was an auto-complete | 21:01 |
dtroyer | ralonsoh, may or may not be the same person | 21:01 |
*** jamielennox|away is now known as jamielennox | 21:01 | |
stevemar | dtroyer: i was referring to https://github.com/openstack/python-openstackclient/commit/4f23a77de04bfdfafd4bf8f16b0365df7663e9e5 | 21:02 |
stevemar | dtroyer: skippage is here: https://github.com/openstack/python-openstackclient/blob/2026dee17e7b6b8d738345fd27dc905efb6561f1/openstackclient/tests/functional/network/v2/test_network_segment.py#L54-L66 | 21:02 |
dtroyer | oh, I thought we were talking about qos rule type still | 21:02 |
*** adriant has joined #openstack-sdks | 21:04 | |
stevemar | dtroyer: i thought we were tlaking about skipped tests -- 418650 unskips all the skipped ones, except those network segment ones | 21:05 |
stevemar | i have no idea what qos rule type is | 21:06 |
dtroyer | that's the one test that failed in your 418650 test with sdk 0.9.12 | 21:06 |
dtroyer | I can't tell (yet) if it ever worked | 21:06 |
dtroyer | have to restart my devstack with q-qos running, and that takes a long time these days | 21:07 |
stevemar | dtroyer: wel https://review.openstack.org/#/c/419129/ fixes it, i think | 21:07 |
dtroyer | I believe this is the last blocker for sdk 0.9.12 | 21:07 |
stevemar | let me run it for you | 21:07 |
*** john-davidge has quit IRC | 21:08 | |
dtroyer | so is that a fix or just not testing for the missing piece? | 21:08 |
dtroyer | ie, is something still broken since minimum_bandwidth was expected to be ther at one time? | 21:08 |
*** fzdarsky has quit IRC | 21:09 | |
stevemar | dtroyer: i'm wondering that myself, looking at the neutron APIs while I'm stacking with qos enabled | 21:12 |
dtroyer | I don't see it in http://developer.openstack.org/api-ref/networking/v2/ | 21:12 |
stevemar | dtroyer: looking at http://developer.openstack.org/api-ref/networking/v2/?expanded=#quality-of-service | 21:13 |
stevemar | theres definitely bandwidth_limit_rules and dscp_marking_rules | 21:14 |
stevemar | no idea where minimum bandwidth came from | 21:14 |
dtroyer | ok, that's good enough for moi | 21:14 |
stevemar | also, the functional command returned only the two, i added that to the commit message | 21:14 |
stevemar | dtroyer: did you want me to punt some things through while we're short on time? | 21:15 |
dtroyer | http://docs.openstack.org/developer/neutron/devref/quality_of_service.html#qos-versioned-objects lists a QosMinimumBandwidth object | 21:16 |
stevemar | dtroyer: *shrug* | 21:19 |
*** cdent has joined #openstack-sdks | 21:19 | |
dtroyer | I guess at this point… if that passes, let's roll with it | 21:20 |
dtroyer | I just +W the hook_tips.sh review | 21:21 |
dtroyer | stevemar: if you have a minute, I think https://review.openstack.org/#/c/352477/ is ready | 21:23 |
dtroyer | and lookie there, it includes minimum-bandwidth | 21:23 |
*** salv-orlando has joined #openstack-sdks | 21:25 | |
*** abhiraut has joined #openstack-sdks | 21:32 | |
*** rtheis has quit IRC | 21:38 | |
openstackgerrit | Abhishek Raut proposed openstack/python-openstackclient: SDK refactor: Prepare security group commands https://review.openstack.org/418183 | 21:39 |
openstackgerrit | Dean Troyer proposed openstack/python-openstackclient: Add one option to "volume host set" command https://review.openstack.org/411259 | 21:43 |
*** cleong has quit IRC | 21:49 | |
*** fzdarsky has joined #openstack-sdks | 22:02 | |
*** fzdarsky has quit IRC | 22:08 | |
*** john-davidge has joined #openstack-sdks | 22:08 | |
stevemar | dtroyer: ahh theres the bugger | 22:12 |
*** john-davidge has quit IRC | 22:13 | |
* dtroyer readies the giant can of RAID | 22:14 | |
*** cdent has quit IRC | 22:15 | |
*** fzdarsky has joined #openstack-sdks | 22:21 | |
stevemar | dtroyer: punted | 22:21 |
stevemar | dtroyer: that should make https://review.openstack.org/#/c/419129/ unnecessary | 22:22 |
*** salv-orl_ has joined #openstack-sdks | 22:22 | |
stevemar | dtroyer: so i'm not sure if briancurtin will release a new SDK in the next week or two, how do we want to handle the SDK version in our requirements file? | 22:23 |
stevemar | should we revert the SDK blacklist? | 22:23 |
stevemar | hmm... that'll cause gate issues with rally and others | 22:24 |
dtroyer | yeah, not until after we release, at least... | 22:24 |
stevemar | dtroyer: we may have to release osc 3.7.0, revert the sdk blacklist, and do a quick release with SDK 0.9.12 included? | 22:24 |
stevemar | it would be wonky to do all this compatability work and not have it work with sdk 0.9.12 | 22:25 |
dtroyer | That's partly why I was wanting to do two releases before freeze, the second, without the blacklists, will become stable and we don't live with that for a long time | 22:25 |
dtroyer | also, there's stuff that wants sdk 0.9.11 as min anyway | 22:25 |
*** salv-orlando has quit IRC | 22:26 | |
dtroyer | so maybe that's what we set when we remove the blacklist? | 22:26 |
openstackgerrit | Merged openstack/python-openstackclient: add support for running tests with master dependencies https://review.openstack.org/419032 | 22:27 |
*** kevo has quit IRC | 22:27 | |
openstackgerrit | Merged openstack/python-openstackclient: Add support for Glance 'update image members' feature https://review.openstack.org/410848 | 22:28 |
openstackgerrit | Merged openstack/python-openstackclient: Error handling for delete commands in identity https://review.openstack.org/415799 | 22:28 |
stevemar | ok with me | 22:28 |
*** markvoelker has quit IRC | 22:29 | |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Add unit test for multi volume types delete https://review.openstack.org/405947 | 22:30 |
*** gildub has joined #openstack-sdks | 22:30 | |
*** gildub has quit IRC | 22:31 | |
*** markvoelker has joined #openstack-sdks | 22:32 | |
*** annegentle has quit IRC | 22:33 | |
*** markvoelker has quit IRC | 22:34 | |
*** markvoelker has joined #openstack-sdks | 22:34 | |
*** markvoelker_ has joined #openstack-sdks | 22:39 | |
*** markvoelker has quit IRC | 22:39 | |
*** kevo has joined #openstack-sdks | 22:41 | |
*** gildub has joined #openstack-sdks | 22:47 | |
*** chlong has quit IRC | 22:55 | |
*** abhiraut has quit IRC | 23:02 | |
openstackgerrit | Ankur proposed openstack/python-openstackclient: Add meter rule to OSC https://review.openstack.org/378058 | 23:04 |
*** fzdarsky is now known as fzdarsky|afk | 23:07 | |
*** john-davidge has joined #openstack-sdks | 23:10 | |
*** lamt has quit IRC | 23:11 | |
*** fzdarsky|afk has quit IRC | 23:12 | |
openstackgerrit | Merged openstack/python-openstackclient: Add two consistency group commands https://review.openstack.org/407983 | 23:12 |
*** john-davidge has quit IRC | 23:15 | |
*** markvoelker_ has quit IRC | 23:32 | |
openstackgerrit | Merged openstack/python-openstackclient: Add support for Network QoS rule commands https://review.openstack.org/352477 | 23:37 |
*** markvoelker has joined #openstack-sdks | 23:40 | |
*** salv-orl_ has quit IRC | 23:52 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!