Wednesday, 2017-01-11

*** jamielennox is now known as jamielennox|away00:07
*** purplerbot has quit IRC00:11
*** jamielennox|away is now known as jamielennox00:11
*** markvoelker has quit IRC00:12
*** vdrok has quit IRC00:12
*** johnsom has quit IRC00:12
*** purplerbot has joined #openstack-sdks00:12
*** markvoelker has joined #openstack-sdks00:12
*** hongbin has quit IRC00:15
*** vdrok has joined #openstack-sdks00:22
*** johnsom has joined #openstack-sdks00:22
*** vdrok has quit IRC00:25
*** vdrok has joined #openstack-sdks00:25
*** johnsom has quit IRC00:25
*** johnsom has joined #openstack-sdks00:25
openstackgerritMerged openstack/osc-lib: To display image size in human friendly format  https://review.openstack.org/41855300:27
*** huanxuan has joined #openstack-sdks01:22
*** yanyanhu has joined #openstack-sdks01:32
*** briancurtin has joined #openstack-sdks01:35
*** namnh has joined #openstack-sdks01:39
*** markvoelker has quit IRC01:43
*** markvoelker has joined #openstack-sdks01:44
*** markvoelker has quit IRC01:49
*** kevo has quit IRC01:59
*** john-davidge has joined #openstack-sdks02:01
*** john-davidge has quit IRC02:05
openstackgerritSteve Martinelli proposed openstack/osc-lib: Implement auth caching  https://review.openstack.org/35948902:07
openstackgerritSteve Martinelli proposed openstack/python-openstackclient: To display image size in human friendly format  https://review.openstack.org/39812602:08
openstackgerritSteve Martinelli proposed openstack/python-openstackclient: To display image size in human friendly format  https://review.openstack.org/39812602:09
Qimingstevemar, available for a quick sync?02:15
jiahuistevemar: When i want to fix the bug in osc network, i find the result of my functional test is different with the Jenkins. I also test the command like "openstack network create", it is ok in my local environment.02:21
Qimingjiahui, speaking of bug in osc network, are you referring to the ones triggered by by SDK refactoring?02:22
jiahuistevemar: I have upgrade my local python-openstackclient.02:22
stevemarQiming: jiahui hey hey02:23
jiahuiQiming: YES:).02:23
Qimingcool.02:23
Qiminggood to know there are hands working on this02:23
stevemarjiahui: hmm, can you check what version of the SDK you are using in your local box?02:24
stevemarjiahui: i think in the gate, we now block SDK v0.9.1202:24
jiahuistevemar: SDK v0.9.10 in my box02:26
stevemarjiahui: i think the gate will test with that too02:27
stevemarjiahui: which patch are you referring to?02:27
jiahuistevemar: I have look the skip you have done in https://review.openstack.org/#/c/417576/02:29
*** chlong has quit IRC02:32
openstackgerritSteve Martinelli proposed openstack/python-openstackclient: Revert "Updated from global requirements"  https://review.openstack.org/41865002:35
stevemarjiahui: ah let me see -- the gate is currently testing with sdk 0.9.10 i believe, let's see what happens with ^02:49
jiahuistevemar: thank you steve :)02:53
*** annp has joined #openstack-sdks03:07
openstackgerritMerged openstack/osc-lib: Calls to federated service providers using Keystone-to-Keystone  https://review.openstack.org/37170903:08
*** gouthamr has quit IRC03:21
*** amotoki has quit IRC03:21
jiahuistevermar:I run the command "tox -e functional openstackclient.tests.functional.network.v2" to test all network functional tests, it fails 3 tests. I reinstall devstack ,the same three tests fail.03:23
*** amotoki has joined #openstack-sdks03:29
*** salv-orl_ has quit IRC03:32
*** salv-orlando has joined #openstack-sdks03:32
*** amotoki has quit IRC03:33
*** markvoelker has joined #openstack-sdks03:36
openstackgerritSteve Martinelli proposed openstack/python-openstackclient: Revert "Updated from global requirements"  https://review.openstack.org/41865003:41
openstackgerritSteve Martinelli proposed openstack/python-openstackclient: Revert "Updated from global requirements"  https://review.openstack.org/41865003:49
*** abhiraut has joined #openstack-sdks04:16
*** salv-orl_ has joined #openstack-sdks04:23
*** salv-orlando has quit IRC04:26
*** sheel has joined #openstack-sdks04:34
*** adriant has quit IRC04:47
*** abhiraut has quit IRC04:53
stevemarjiahui: https://review.openstack.org/#/c/418650/ should have functional test results with SDK v0.9.1205:20
stevemarin about 30 minutes :)05:20
openstackgerritzhiyong.dai proposed openstack/python-openstackclient: Update functional test for aggregate.  https://review.openstack.org/41868505:22
openstackgerritjiahui.qiang proposed openstack/python-openstackclient: Fix filter error in os volume list  https://review.openstack.org/41685205:40
*** john-davidge has joined #openstack-sdks06:03
*** john-davidge has quit IRC06:08
*** dims has quit IRC06:13
jiahuistevemar: Yes, i am thinking about how to upgrade my local SDK to SDK v0.9.12. It should be late in your place and good night! Thank you steve :)06:18
*** dfflanders has quit IRC06:19
*** sheel has quit IRC06:37
openstackgerritReedip proposed openstack/python-openstacksdk: Fix quota show output  https://review.openstack.org/41872906:40
*** gildub has quit IRC07:15
*** amotoki has joined #openstack-sdks07:28
RuiChenhi jiahui if you want to update your local sdk to 0.9.12, you should modify your local /opt/stack/requirements/upper-constraints.txt, then change python-openstackclient/tox.ini, like this {env:UPPER_CONSTRAINTS_FILE:/opt/stack/requirements/upper-constraints.txt}07:40
*** ralonsoh has joined #openstack-sdks07:48
jiahuiRuiChen: hi ,thank you for your advice. Is the gate testing with sdk 0.9.10? I find 'functional installed: ...openstacksdk==0.9.10...', when i read this http://logs.openstack.org/50/418650/3/check/gate-osc-dsvm-functional-ubuntu-xenial/7c4daa7/console.html07:55
*** hogepodge has quit IRC07:56
RuiChenjiahui: yes, current gate run on 0.9.10 https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L21408:01
RuiChenjiahui: I found export UPPER_CONSTRAINTS_FILE=/opt/stack/requirements/upper-constraints.txt is better way :-)08:12
jiahuiRuiChen: Thank you, it is so helpful to me!08:13
*** amotoki has quit IRC08:16
*** salv-orl_ has quit IRC08:21
*** Matias has quit IRC08:37
*** Matias has joined #openstack-sdks08:43
*** kevo has joined #openstack-sdks08:54
*** namnh has quit IRC09:20
*** amotoki has joined #openstack-sdks09:22
reedipanyone here ??09:31
reedipRuiChen, dtroyer, stevemar ??09:31
RuiChenyeah reedip09:32
reedipRuiChen : question09:32
reedipRuiChen, dtroyer, stevemar : while working on Neutron's quota update API, I found that this bug exists : https://bugs.launchpad.net/python-openstackclient/+bug/165544509:33
openstackLaunchpad bug 1655445 in python-openstackclient "Cannot update subnetpool quota" [Undecided,New] - Assigned to Reedip (reedip-banerjee)09:33
RuiChenso your question is ?09:34
reedipRuiChen, dtroyer, stevemar : I found that the issue is because of this line: https://github.com/openstack/python-openstacksdk/blob/master/openstack/proxy2.py#L6409:35
reedipRuiChen, dtroyer, stevemar : now not all End Points accept id=PROJECT_ID for each type of resource.09:36
reedipfor example, Neutron doesnt accept Project ID while updating the quotas09:36
reedipNow, changing Neutron API would take some time and as we are near Ocata-3 , I am not sure if it would be accepted.09:36
*** lucas-afk is now known as lucasagomes09:38
RuiCheni'm not clear your means, let me check the bug details09:40
reedipRuiChen: Sure, I will wait09:41
RuiChenI try the command in my env, no error exist, something I miss? (openstack) quota set --subnetpools 1234 ${proejct_id}09:45
RuiChenmy openstack sdk is openstacksdk-0.9.1009:46
reedipHow do I check my openstacksdk ?09:49
reedipI mean RuiChen how do I check my version of openstacksdk09:50
RuiChenin your python install dir site-package09:50
RuiChenpip freeze09:51
reedipI have openstacksdk==0.9.1209:51
*** john-davidge has joined #openstack-sdks09:52
RuiChenseems it cause by the bug https://bugs.launchpad.net/python-openstackclient/+bug/165231709:53
openstackLaunchpad bug 1652317 in Manila "OpenStackSDK refactoring caused various OSC networking commands to fail" [Critical,New]09:53
reedipRuiChen : Okay09:54
reedipRuiChen : my bug may not be caused due to returning dicts , but yes it doesnt accept ID in it as mentioned in https://bugs.launchpad.net/python-openstackclient/+bug/1652317/comments/1309:55
openstackLaunchpad bug 1652317 in Manila "OpenStackSDK refactoring caused various OSC networking commands to fail" [Critical,New]09:55
*** e0ne has joined #openstack-sdks10:02
RuiChenreedip: yeah, I decide to install sdk 0.9.12, try to find out something wrong about it :)10:03
reedip:D10:15
*** kevo has quit IRC10:16
reedipRuiChen: I resolved it in a PS10:34
reedipcan you try the patch and lemme know of the result ?10:35
reedipBasically I modified the refactoring of Openstack SDK for this fix.10:35
reedipRuiChen : Never mind, anyways I am looking into this bug, will post the PS today10:43
RuiChenI will go to dinner in a moment, sorry, please show me the patch link, I will check it when I have time10:46
*** aarefiev has joined #openstack-sdks10:47
*** aarefiev_afk has quit IRC10:50
*** cdent has joined #openstack-sdks11:00
*** sdague has joined #openstack-sdks11:15
*** yanyanhu has quit IRC11:24
*** annp has quit IRC11:29
*** dims has joined #openstack-sdks11:39
*** huanxuan has quit IRC11:58
*** huanxuan has joined #openstack-sdks12:00
*** huanxuan has quit IRC12:00
*** rtheis has joined #openstack-sdks12:09
*** amotoki has quit IRC12:14
*** amotoki has joined #openstack-sdks12:26
*** huanxuan has joined #openstack-sdks12:30
openstackgerrityuval shalev proposed openstack/python-openstacksdk: Added project role assignment  https://review.openstack.org/41659812:31
*** jiahui has quit IRC12:38
*** fzdarsky has joined #openstack-sdks12:42
*** lucasagomes is now known as lucas-hungry12:50
*** amotoki has quit IRC12:50
*** amotoki has joined #openstack-sdks13:00
*** amotoki has quit IRC13:02
*** amotoki has joined #openstack-sdks13:05
*** chlong has joined #openstack-sdks13:07
*** amotoki has quit IRC13:28
*** amotoki has joined #openstack-sdks13:39
*** lucas-hungry has quit IRC13:41
*** annegentle has joined #openstack-sdks13:45
openstackgerritHuanxuan Ao proposed openstack/python-openstackclient: Add "encryption-*" options in volume type commands  https://review.openstack.org/41419713:47
*** lucasagomes has joined #openstack-sdks13:47
*** _elmiko is now known as elmiko13:55
*** john-dav_ has joined #openstack-sdks13:55
*** john-davidge has quit IRC13:55
*** john-dav_ is now known as john-davidge13:56
*** david-lyle has quit IRC13:56
*** crinkle_ has quit IRC13:59
*** amotoki has quit IRC13:59
*** david-lyle has joined #openstack-sdks13:59
*** crinkle_ has joined #openstack-sdks13:59
*** lamt has joined #openstack-sdks14:01
*** jamielennox is now known as jamielennox|away14:14
*** david-lyle has quit IRC14:16
*** fguillot has joined #openstack-sdks14:17
*** annegentle has quit IRC14:18
*** huanxuan has quit IRC14:26
*** chlong has quit IRC14:37
openstackgerritSteve Martinelli proposed openstack/python-openstackclient: Run functional tests with SDK 0.9.12  https://review.openstack.org/41865014:37
stevemardtroyer: so i pushed ^ -- we probably want that to be successful before releasing14:38
stevemarit ensure we will work with the latest SDK release14:38
stevemarcause right now our CI is passing, not because of skipped tests, but because the latest SDK versions are blacklisted14:39
*** amotoki has joined #openstack-sdks14:39
*** lamt has quit IRC14:40
*** cleong has joined #openstack-sdks14:51
*** gouthamr has joined #openstack-sdks14:52
dtroyerstevemar: right… thanks15:01
dtroyerI want to release osc-lib Real Soon Now15:02
dtroyerI'm still not sure I want to force-include keyring, we've already been down that road…15:02
dtroyerstevemar: I'm thinking we need to add OSC functional tests to osc-lib and the sdk jobs...15:04
*** hongbin has joined #openstack-sdks15:06
stevemardtroyer: definitely need to do that15:15
dtroyerso osc-lib auth cache… include or not?   I'll release now if we leave it out15:16
stevemari am negative on that15:16
stevemaruntested (mostly)15:16
dtroyerroger that… agreed15:17
stevemardtroyer: want to add a functional test job to osc-lib before releasing?15:17
stevemaror are you comfortable enough to release?15:17
stevemari think the changes were mostly additive15:17
dtroyerdepends on how long it takes to get it added :)15:17
dtroyerI made those compat-changes, the case I am concerned about we get in the dsvm jobs (using env vars for auth)15:18
*** john-davidge has quit IRC15:18
* stevemar puts on his infra thinking hat15:18
dtroyerrather, using having the comat bits in osc-lib and also in osc15:18
*** john-davidge has joined #openstack-sdks15:19
dtroyerin one case it's doing double work and is not (should not be) harmful15:19
stevemardtroyer: looks like only one thing is failing with sdk 0.9.12 -- http://logs.openstack.org/50/418650/4/check/gate-osc-dsvm-functional-ubuntu-xenial/abbb8d4/testr_results.html.gz ?15:19
dtroyerwoo!15:20
dtroyerqos rule type...15:20
dtroyeris anyone workign on that (I just skimmed the overnight scrollback)15:20
dtroyerI'll jump on it after adding the func tests and releasing osc-lib15:20
stevemardtroyer: for the functional job in osc-lib... it should test with master osc-lib and master osc?15:20
dtroyerwe need that combination somewhere, but I was thinking master osc-lib with released osc15:21
dtroyerwe've found that dsvm jobs are insufficient for validating we don't break anything15:21
stevemarright15:21
stevemardtroyer: i did the combination before but i don't recall how to do it, may take a few hours15:22
dtroyerrelease osc + master osc-lib would be the default, right?15:22
dtroyerie, no extra work15:23
*** markvoelker has quit IRC15:28
stevemari think so, but we'll need to run the functional tests *in* the osc repo, so i'm not sure how that works :\15:29
dtroyerugh, right15:29
*** markvoelker has joined #openstack-sdks15:29
stevemardtroyer: and we'll need to probably run the master version of those tests?15:31
stevemardtroyer: you know, we could have another job in the OSC gate that tests osc-lib master and osc master15:31
stevemarinstead of osc-lib release and osc master15:31
stevemarthat'll be *really* easy15:31
stevemari think15:31
dtroyerlets do it that way… in gate, check or experimental so it can go on-demand?15:32
stevemarjust copy+paste the old job and force it to install osc-lib in master15:32
stevemarnon-voting check for now i think15:32
dtroyerkk15:33
*** markvoelker has quit IRC15:35
stevemardtroyer: aside from copying https://github.com/openstack/python-openstackclient/blob/master/openstackclient/tests/functional/post_test_hook.sh and the 'functional' job15:37
stevemarsorry15:37
stevemardtroyer: let me tell you in steps what i was going to do, see if you can think of a simpler way15:37
dtroyerok15:38
stevemar1) copy the functional job here, but call a different post_test_hook.sh, maybe post_test_osc_lib_hook.sh ? https://github.com/openstack-infra/project-config/blob/e172a5e4107f1774a77e212d82218086ed39329e/jenkins/jobs/osc.yaml#L215:38
stevemar2) copy https://github.com/openstack/python-openstackclient/blob/master/openstackclient/tests/functional/post_test_hook.sh to the new name and have it clone and install osc-lib master15:38
stevemar3) make money15:39
stevemari could get fancy and maybe set an ENV variable somewhere that says we're using osc-lib from master, but ... i know this will work15:40
dtroyerI don't know the job stuff well enough to know the shortcuts, your plan sounds like it will work15:41
dtroyershould we commit the shell script first?15:41
dtroyeralso, stable jobs?15:41
stevemarthe shell script will be in osc no?15:43
dtroyeryes15:43
stevemaroh i thought you were asking about getting that in before osc-lib is released15:44
stevemarignore me15:44
dtroyershould we also do sdk?  can we do both in the same job?15:44
dtroyerso many questions!15:44
*** lucasagomes has quit IRC15:44
dtroyera) I was thinking we'd want the new *-hook.sh merged before defining the job that calls it15:45
dtroyerb) I'm still thinking through how this affects (or if it should?) stable jobs15:45
dtroyerc) we should also do the sdk this way, can we do both in the same job in a sane manner?15:46
*** lucasagomes has joined #openstack-sdks15:46
stevemardtroyer: i think we can15:47
dtroyero-c-c too?15:49
dtroyerhow much can we add??? :)15:50
dtroyerthose are the three primary break-risk libs for OSC15:50
*** john-davidge has quit IRC15:53
*** markvoelker has joined #openstack-sdks15:57
*** lamt has joined #openstack-sdks16:03
*** salv-orlando has joined #openstack-sdks16:09
*** chlong has joined #openstack-sdks16:11
*** annegentle has joined #openstack-sdks16:13
*** salv-orl_ has joined #openstack-sdks16:22
*** salv-orlando has quit IRC16:25
dtroyerstevemar: I just got the same results in my local OSC functional tests (same devstack-related failures) for both current and master osc-lib.  Are you OK with pushing the release now or do you still want to wait intil the new job is in?16:27
stevemardtroyer: i'm OK with pushing16:31
stevemardtroyer: i'm trying to figure out the pip command to install the sdk16:32
*** ankur-gupta-f has left #openstack-sdks16:32
briancurtinpip install openstacksdk16:32
*** ankur-gupta-f has joined #openstack-sdks16:32
stevemarhehe16:32
stevemarbriancurtin: from master instead?16:32
briancurtinwhat?16:32
stevemari was thinking ... pip install -q -U -e "git+https://git.openstack.org/python-openstacksdk/openstacksdk.git#egg=openstacksdk"16:33
briancurtinthat probably works. or maybe egg=openstack. i can’t remember exactly what goes in the egg part16:33
stevemarbriancurtin: thats where i'm stumbling :)16:33
briancurtinthe PyPI package name is openstacksdk but the package that python itself deals with is called openstack, so maybe egg=openstack16:34
* dtroyer looks at git-installed pip16:34
dtroyerlooks like egg=python_openstackclient is used for that case, so pypi package name?16:35
dtroyerwith '-' -> '_' mapping16:35
stevemardtroyer: sorta, pip install -q -U -e "git+https://git.openstack.org/openstack/osc-lib.git#egg=osc_lib" works for osc-lib16:36
dtroyerso I'd expect #egg=puthon_openstacksdk to be the magic16:36
dtroyers/pu/py/16:37
*** cdent has quit IRC16:38
dtroyerpip install -q -U -e "git+https://git.openstack.org/openstack/python-openstacksdk.git#egg=python_openstacksdk"16:38
dtroyerappears to have worked for me16:38
stevemar*smh* i had an extra openstack in there16:40
*** reedip_outofmemo has joined #openstack-sdks16:40
reedip_outofmemobriancurtin : ping16:41
briancurtinreedip_outofmemo: what’s up16:41
reedip_outofmemobriancurtin : hi , busy ?16:42
openstackgerritSteve Martinelli proposed openstack/python-openstackclient: add support for running tests with master dependencies  https://review.openstack.org/41903216:42
briancurtinreedip_outofmemo: no, what’s up16:42
stevemardtroyer: ^16:42
reedip_outofmemobriancurtin : it was related to https://review.openstack.org/#/c/418729/16:42
briancurtinyeah, what is the question?16:42
reedip_outofmemobriancurtin : earlier, quota show for openstackclient ( before 0.9.12 version ) was working smoothly16:43
reedip_outofmemowith 0.9.12, there has been a change and quota show now fails16:43
reedip_outofmemobriancurtin :https://bugs.launchpad.net/python-openstackclient/+bug/165553716:43
openstackLaunchpad bug 1655537 in python-openstackclient "Cannot see Network quota using "openstack quota show"" [Undecided,New] - Assigned to Reedip (reedip-banerjee)16:43
briancurtinreedip_outofmemo: there was no change in 0.9.12, i think it was in 0.9.11, but this is an OSC problem and not an SDK problem16:44
reedip_outofmemobriancurtin: the reason is though the Compute and Volume quotas are returned as dict, network quota is returned as an object16:44
reedip_outofmemobriancurtin : ok , one question16:44
reedip_outofmemobriancurtin : is the compute client and volume client part of Openstack SDK ?16:45
briancurtinreedip_outofmemo: openstacksdk hasn’t explicitly returned dictionaries ever, though some time ago it did return objects that can act like dictionaries. compute hasn’t done that for probably 8 months16:45
reedip_outofmemobriancurtin : like Network client16:45
briancurtinreedip_outofmemo: I’m not sure, i don’t work on OSC. i think OSC only uses openstacksdk for the network related commands though, not for compute and volume16:45
reedip_outofmemostevemar  : any suggestions related to above query ?16:46
dtroyerreedip: briancurtin is correct re compute and volume quotas16:46
reedip_outofmemodtroyer : ok, so sdk is used only for Networks??????16:46
dtroyerthe root problem is that OSC was not ready for the 0.9.11 changes in the SDK because our functioanl tests were producing false positives for a time16:46
dtroyerreedip: yes16:47
reedip_outofmemobriancurtin : one more query16:47
briancurtinreedip_outofmemo: sure16:47
reedip_outofmemodtroyer :okay, then I will fix the bug in OSC and not SDK16:47
reedip_outofmemobriancurtin : this is related to quota set16:47
dtroyerOSc needs to work with sdk >= 0.9.10 for a while yet16:47
reedip_outofmemobriancurtin : in openstack SDK , you updated the proxy216:47
reedip_outofmemobriancurtin : https://github.com/openstack/python-openstacksdk/blob/master/openstack/proxy2.py#L6416:49
briancurtincorrect, there is a proxy216:49
reedip_outofmemobriancurtin : Neutron Quota set does not need the ID which is being passed here in the PUT request16:49
reedip_outofmemoNeutron Quota API do not need the tenant/project ID as they have an endpoint in the quota resource itself for the tenant ID. For example. if Tenant ID is ABCDE , then Neutron has the quota endpoint for tenant as  http://10.0.0.1:23423/v2/quotas/ABCDE.json16:50
briancurtinso when building the request don’t make it require an ID. you might need to override the create method of the Quota resource and pass requires_id=False to the _prepare_request method https://github.com/openstack/python-openstacksdk/blob/master/openstack/resource2.py#L50216:50
reedip_outofmemobriancurtin : Yup , I am trying to do that16:51
*** cdent has joined #openstack-sdks16:51
reedip_outofmemobriancurtin : Just wanted to update you. There might be one more change, I will put up the patch tomorrow16:51
briancurtinreedip_outofmemo: ok cool16:51
reedip_outofmemobriancurtin : thanks , hope this resolves soon :)16:52
reedip_outofmemodtroyer : sorry for bugging you , but if OSC needs to work with SDK  >=0.9.10, then should I just put a type check ?16:52
reedip_outofmemodtroyer: that would be simpler and can be removed once everything comes in line? Currently network quota is returned as an object, but earlier it was returned as a dict ( or something similar to a dict)16:53
dtroyerreedip: there is currently a bit of compatibility code in the networking commands for this reason, do the same thing in the quota command and leave a note to remove it later16:55
reedip_outofmemodtroyer: aye aye !16:56
dtroyerdhellmann, stevemar: I'd like to do a cliff release this week yet, likely last before freeze.  I'm OK with https://review.openstack.org/412742, chime in when you get a minute if we should include it or not...17:00
*** e0ne has quit IRC17:06
stevemardtroyer: we can probably release without that patch, it's more for making sure our gates aren't busted17:09
stevemardtroyer: i've also released ksa for us, but getting blocked for the u-c bump17:09
stevemarhttps://review.openstack.org/#/c/418608/17:10
*** briancurtin has quit IRC17:11
*** abhiraut has joined #openstack-sdks17:17
openstackgerritReedip proposed openstack/python-openstackclient: Fix quota show output  https://review.openstack.org/41906717:36
reedip_outofmemostevemar , briancurtin : ^^17:38
openstackgerritShashank Kumar Shankar proposed openstack/python-openstackclient: Introduce Neutron DHCP agent commands to OSC.  https://review.openstack.org/38761117:38
openstackgerritShashank Kumar Shankar proposed openstack/python-openstackclient: Introduce Neutron DHCP agent commands to OSC.  https://review.openstack.org/38761117:44
*** abhiraut has quit IRC17:49
*** kevo has joined #openstack-sdks17:50
*** lucasagomes is now known as lucas-afk17:50
*** aarefiev is now known as aarefiev_afk17:54
*** ralonsoh has quit IRC18:03
*** abhiraut has joined #openstack-sdks18:04
*** abhiraut has quit IRC18:08
*** reedip_outofmemo has quit IRC18:11
*** david-lyle has joined #openstack-sdks18:16
*** reedip_outofmemo has joined #openstack-sdks18:27
ankur-gupta-fdtroyer: here?18:30
dtroyerankur-gupta-f: yo18:30
ankur-gupta-fClient functional tests :D18:31
ankur-gupta-fso we tried the regexes18:31
ankur-gupta-fnow JSON18:31
ankur-gupta-fbut for existing patches can we leave regexes and follow up with JSON18:31
dtroyeryes.  it may still evolve more, I don't want you guys to chase too much of a moving target, OSC does that all the time anyway18:32
*** amotoki has quit IRC18:32
dtroyerther are a couple of things I'd like to make sure get in theough,18:32
dtroyerusing addCleanup() is one of those18:32
dtroyerthat is more than a cosmentic/developer preference thing18:32
ankur-gupta-ffor everything created.18:33
ankur-gupta-fI do like the change that every test does the creation, <list, show, etc..> deletion18:33
ankur-gupta-fOkay thats all. Thanks18:34
dtroyerstevemar: I ran the -efunctional-tips locally, no tests ran…do we need to include the ostestr command in that section?18:40
*** john-davidge has joined #openstack-sdks18:41
*** chlong has quit IRC18:46
cdentelmiko: that link you tweeted a while ago to radanalytics wants auth?18:52
*** cdent has quit IRC18:53
openstackgerritDean Troyer proposed openstack/python-openstackclient: add support for running tests with master dependencies  https://review.openstack.org/41903218:56
*** chlong has joined #openstack-sdks18:59
stevemardtroyer: thats a good question, the [fucntional] target doesn't have any ostestr stuff19:00
stevemardtroyer: do you know why we have to add ostestr to -tips but not the other?19:00
openstackgerritMerged openstack/python-openstackclient: Fix filter error in os volume list  https://review.openstack.org/41685219:01
dtroyerI just added it to the command list.  I think tox inherits from [env] if there isn't a command=19:01
thingeedtroyer seems to be working now19:01
*** reedip_outofmemo has quit IRC19:02
*** briancurtin has joined #openstack-sdks19:09
thingeesorry I missed that19:12
dtroyerheh, I did too until I actually tried it :)19:18
stevemardtroyer: ahh, but since there is a command= there, it doesn't inherit from env19:20
openstackgerritDiana Clarke proposed openstack/python-openstackclient: WIP - Add nova microversion 2.40 support  https://review.openstack.org/41910819:29
*** amotoki has joined #openstack-sdks19:32
openstackgerritMerged openstack/cliff: Add Constraints support  https://review.openstack.org/41274219:40
*** fguillot has quit IRC19:43
*** salv-orl_ has quit IRC19:45
openstackgerritAnkur proposed openstack/python-openstackclient: Add meter rule to OSC  https://review.openstack.org/37805819:49
*** e0ne has joined #openstack-sdks20:14
stevemardtroyer: have you been keeping track of what networking commands broke and are fixed in osc?20:27
dtroyerI don't have an exhaustive list… AFAIK only the qos rule type is left though?20:39
dtroyerwell, I haven't gone looking for the remaining skips yet20:39
dtroyererg, there are still 420:40
dtroyerstevemar: do you recall how many tests were being skipped before this mess started?20:41
stevemaronly 4 (they were conditional on a networking extension)20:41
stevemarwe had no skipped tests otherwise20:41
dtroyerok then, your 418650 has them all then20:42
*** e0ne has quit IRC20:43
openstackgerritShashank Kumar Shankar proposed openstack/python-openstackclient: Introduce Neutron DHCP agent commands to OSC.  https://review.openstack.org/38761120:46
openstackgerritSteve Martinelli proposed openstack/python-openstackclient: unskip network qos rule type functional test  https://review.openstack.org/41912920:47
stevemardtroyer: ^ i think that one worked, just a bad test20:47
dtroyerI think it is more than a bad test, I get a 404 when I try the command20:48
dtroyer#$^%&%$#$!@#$%^*%&$#@#$%^*&^&%^%$@#^$&%&^*&%^$%#$@#!@#$^%&^20:53
dtroyerWhy did we let an extension command into the main repo??????????????????20:54
dtroyerso nevermind my 404, I don't have the (*&^%$#$%^&*( extension enabled20:55
dtroyerwe gotta handle that better… and by better I mean at all20:56
dtroyerIs ther any way to make the tests discover and auto-skip this?20:56
stevemardtroyer: i thought there was a discover and skip mechanism20:57
stevemari guess not, since it didn't skip for you20:57
stevemardtroyer: that test and command was created by rich back in the early networking days, before we had a fleshed out plan for extensions and had the neutron team on board20:58
dtroyerhmmm… git sez it was committed on Aug 1221:00
dtroyerby https://github.com/ralonsoh21:00
dtroyerwell, that was an auto-complete21:01
dtroyerralonsoh, may or may not be the same person21:01
*** jamielennox|away is now known as jamielennox21:01
stevemardtroyer: i was referring to https://github.com/openstack/python-openstackclient/commit/4f23a77de04bfdfafd4bf8f16b0365df7663e9e521:02
stevemardtroyer: skippage is here: https://github.com/openstack/python-openstackclient/blob/2026dee17e7b6b8d738345fd27dc905efb6561f1/openstackclient/tests/functional/network/v2/test_network_segment.py#L54-L6621:02
dtroyeroh, I thought we were talking about qos rule type still21:02
*** adriant has joined #openstack-sdks21:04
stevemardtroyer: i thought we were tlaking about skipped tests -- 418650 unskips all the skipped ones, except those network segment ones21:05
stevemari have no idea what qos rule type is21:06
dtroyerthat's the one test that failed in your 418650 test with sdk 0.9.1221:06
dtroyerI can't tell (yet) if it ever worked21:06
dtroyerhave to restart my devstack with q-qos running, and that takes a long time these days21:07
stevemardtroyer: wel https://review.openstack.org/#/c/419129/ fixes it, i think21:07
dtroyerI believe this is the last blocker for sdk 0.9.1221:07
stevemarlet me run it for you21:07
*** john-davidge has quit IRC21:08
dtroyerso is that a fix or just not testing for the missing piece?21:08
dtroyerie, is something still broken since minimum_bandwidth was expected to be ther at one time?21:08
*** fzdarsky has quit IRC21:09
stevemardtroyer: i'm wondering that myself, looking at the neutron APIs while I'm stacking with qos enabled21:12
dtroyerI don't see it in http://developer.openstack.org/api-ref/networking/v2/21:12
stevemardtroyer: looking at http://developer.openstack.org/api-ref/networking/v2/?expanded=#quality-of-service21:13
stevemartheres definitely bandwidth_limit_rules and dscp_marking_rules21:14
stevemarno idea where minimum bandwidth came from21:14
dtroyerok, that's good enough for moi21:14
stevemaralso, the functional command returned only the two, i added that to the commit message21:14
stevemardtroyer: did you want me to punt some things through while we're short on time?21:15
dtroyerhttp://docs.openstack.org/developer/neutron/devref/quality_of_service.html#qos-versioned-objects lists a QosMinimumBandwidth object21:16
stevemardtroyer: *shrug*21:19
*** cdent has joined #openstack-sdks21:19
dtroyerI guess at this point… if that passes, let's roll with it21:20
dtroyerI just +W the hook_tips.sh review21:21
dtroyerstevemar: if you have a minute, I think https://review.openstack.org/#/c/352477/ is ready21:23
dtroyerand lookie there, it includes minimum-bandwidth21:23
*** salv-orlando has joined #openstack-sdks21:25
*** abhiraut has joined #openstack-sdks21:32
*** rtheis has quit IRC21:38
openstackgerritAbhishek Raut proposed openstack/python-openstackclient: SDK refactor: Prepare security group commands  https://review.openstack.org/41818321:39
openstackgerritDean Troyer proposed openstack/python-openstackclient: Add one option to "volume host set" command  https://review.openstack.org/41125921:43
*** cleong has quit IRC21:49
*** fzdarsky has joined #openstack-sdks22:02
*** fzdarsky has quit IRC22:08
*** john-davidge has joined #openstack-sdks22:08
stevemardtroyer: ahh theres the bugger22:12
*** john-davidge has quit IRC22:13
* dtroyer readies the giant can of RAID22:14
*** cdent has quit IRC22:15
*** fzdarsky has joined #openstack-sdks22:21
stevemardtroyer: punted22:21
stevemardtroyer: that should make https://review.openstack.org/#/c/419129/ unnecessary22:22
*** salv-orl_ has joined #openstack-sdks22:22
stevemardtroyer: so i'm not sure if briancurtin will release a new SDK in the next week or two, how do we want to handle the SDK version in our requirements file?22:23
stevemarshould we revert the SDK blacklist?22:23
stevemarhmm... that'll cause gate issues with rally and others22:24
dtroyeryeah, not until after we release, at least...22:24
stevemardtroyer: we may have to release osc 3.7.0, revert the sdk blacklist, and do a quick release with SDK 0.9.12 included?22:24
stevemarit would be wonky to do all this compatability work and not have it work with sdk 0.9.1222:25
dtroyerThat's partly why I was wanting to do two releases before freeze, the second, without the blacklists, will become stable and we don't live with that for a long time22:25
dtroyeralso, there's stuff that wants sdk 0.9.11 as min anyway22:25
*** salv-orlando has quit IRC22:26
dtroyerso maybe that's what we set when we remove the blacklist?22:26
openstackgerritMerged openstack/python-openstackclient: add support for running tests with master dependencies  https://review.openstack.org/41903222:27
*** kevo has quit IRC22:27
openstackgerritMerged openstack/python-openstackclient: Add support for Glance 'update image members' feature  https://review.openstack.org/41084822:28
openstackgerritMerged openstack/python-openstackclient: Error handling for delete commands in identity  https://review.openstack.org/41579922:28
stevemarok with me22:28
*** markvoelker has quit IRC22:29
openstackgerritSteve Martinelli proposed openstack/python-openstackclient: Add unit test for multi volume types delete  https://review.openstack.org/40594722:30
*** gildub has joined #openstack-sdks22:30
*** gildub has quit IRC22:31
*** markvoelker has joined #openstack-sdks22:32
*** annegentle has quit IRC22:33
*** markvoelker has quit IRC22:34
*** markvoelker has joined #openstack-sdks22:34
*** markvoelker_ has joined #openstack-sdks22:39
*** markvoelker has quit IRC22:39
*** kevo has joined #openstack-sdks22:41
*** gildub has joined #openstack-sdks22:47
*** chlong has quit IRC22:55
*** abhiraut has quit IRC23:02
openstackgerritAnkur proposed openstack/python-openstackclient: Add meter rule to OSC  https://review.openstack.org/37805823:04
*** fzdarsky is now known as fzdarsky|afk23:07
*** john-davidge has joined #openstack-sdks23:10
*** lamt has quit IRC23:11
*** fzdarsky|afk has quit IRC23:12
openstackgerritMerged openstack/python-openstackclient: Add two consistency group commands  https://review.openstack.org/40798323:12
*** john-davidge has quit IRC23:15
*** markvoelker_ has quit IRC23:32
openstackgerritMerged openstack/python-openstackclient: Add support for Network QoS rule commands  https://review.openstack.org/35247723:37
*** markvoelker has joined #openstack-sdks23:40
*** salv-orl_ has quit IRC23:52

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!