*** Kuwagata has quit IRC | 00:10 | |
*** hongbin has quit IRC | 00:12 | |
*** john-davidge has joined #openstack-sdks | 00:34 | |
openstackgerrit | YAMAMOTO Takashi proposed openstack/python-openstackclient: Remove the fixed set of choices for network_type https://review.openstack.org/421598 | 00:38 |
---|---|---|
*** john-davidge has quit IRC | 00:39 | |
*** lamt has joined #openstack-sdks | 00:39 | |
*** shu-mutou-AWAY is now known as shu-mutou | 00:43 | |
*** mattmceuen has joined #openstack-sdks | 00:44 | |
*** hoangcx has joined #openstack-sdks | 00:52 | |
*** bobh has joined #openstack-sdks | 00:55 | |
*** huanxuan has joined #openstack-sdks | 01:09 | |
*** adriant has quit IRC | 01:18 | |
*** lamt has quit IRC | 01:22 | |
*** salv-orlando has joined #openstack-sdks | 01:22 | |
*** bobh has quit IRC | 01:22 | |
*** annp has joined #openstack-sdks | 01:23 | |
openstackgerrit | Huanxuan Ao proposed openstack/python-openstackclient: Fix functional test for creating subnet https://review.openstack.org/421310 | 01:26 |
*** salv-orlando has quit IRC | 01:27 | |
*** elmiko has quit IRC | 01:27 | |
*** Dinesh_Bhor has quit IRC | 01:27 | |
*** stevemar has quit IRC | 01:27 | |
*** kevo has quit IRC | 01:28 | |
*** elmiko has joined #openstack-sdks | 01:29 | |
*** Dinesh_Bhor has joined #openstack-sdks | 01:29 | |
*** stevemar has joined #openstack-sdks | 01:29 | |
*** bobh has joined #openstack-sdks | 01:30 | |
*** bobh has quit IRC | 01:32 | |
*** bobh has joined #openstack-sdks | 01:33 | |
*** mattmceuen has quit IRC | 01:34 | |
*** yanyanhu has joined #openstack-sdks | 01:34 | |
*** bobh has quit IRC | 01:36 | |
*** john-davidge has joined #openstack-sdks | 01:45 | |
*** john-davidge has quit IRC | 01:50 | |
*** bobh has joined #openstack-sdks | 01:54 | |
openstackgerrit | Wang Hui proposed openstack/golang-client: Update crud operation of volume API v3 https://review.openstack.org/421620 | 01:58 |
openstackgerrit | Ha Van Tu proposed openstack/python-openstackclient: Add "qos-policy" option to "port create" & "port set" https://review.openstack.org/419236 | 02:03 |
openstackgerrit | zhiyong.dai proposed openstack/python-openstackclient: Add "volume host failover" command https://review.openstack.org/411259 | 02:04 |
*** zhiyong has joined #openstack-sdks | 02:08 | |
*** zhiyong_ has joined #openstack-sdks | 02:09 | |
*** zhiyong has quit IRC | 02:09 | |
*** zhiyong_ is now known as zhiyong | 02:10 | |
*** bobh has quit IRC | 02:14 | |
*** zhiyong_ has joined #openstack-sdks | 02:31 | |
*** zhiyong has quit IRC | 02:31 | |
*** john-davidge has joined #openstack-sdks | 02:35 | |
*** john-davidge has quit IRC | 02:40 | |
*** fzdarsky_ has joined #openstack-sdks | 02:46 | |
*** fzdarsky|afk has quit IRC | 02:50 | |
*** Kuwagata has joined #openstack-sdks | 02:56 | |
openstackgerrit | Wang Hui proposed openstack/golang-client: Update crud operation of volume API v3 https://review.openstack.org/421641 | 03:09 |
openstackgerrit | Merged openstack/keystoneauth: Correctly Omit Response Body in Debug Mode https://review.openstack.org/421319 | 03:15 |
*** huanxuan has quit IRC | 03:18 | |
*** Kuwagata has quit IRC | 03:20 | |
openstackgerrit | Merged openstack/python-openstackclient: Add plugin adoption for trove https://review.openstack.org/421336 | 03:21 |
*** salv-orlando has joined #openstack-sdks | 03:23 | |
*** zhiyong_ has quit IRC | 03:26 | |
*** amotoki has quit IRC | 03:27 | |
*** gouthamr has quit IRC | 03:28 | |
*** salv-orlando has quit IRC | 03:28 | |
*** sheel has joined #openstack-sdks | 03:34 | |
*** elmiko is now known as _elmiko | 03:34 | |
*** john-davidge has joined #openstack-sdks | 03:35 | |
*** john-davidge has quit IRC | 03:40 | |
*** amotoki has joined #openstack-sdks | 03:42 | |
*** zhiyong_ has joined #openstack-sdks | 03:48 | |
*** amotoki_ has joined #openstack-sdks | 03:51 | |
*** amotoki has quit IRC | 03:54 | |
*** zhiyong_ has quit IRC | 04:05 | |
*** amotoki_ has quit IRC | 04:11 | |
*** zhiyong_ has joined #openstack-sdks | 04:17 | |
*** amotoki has joined #openstack-sdks | 04:25 | |
*** amotoki has quit IRC | 04:44 | |
*** shu-mutou has quit IRC | 04:56 | |
openstackgerrit | Andy Botting proposed openstack/os-client-config: Add support for Murano https://review.openstack.org/421668 | 04:56 |
openstackgerrit | Andy Botting proposed openstack/os-client-config: Add support for Murano https://review.openstack.org/421668 | 05:02 |
openstackgerrit | Andy Botting proposed openstack/os-client-config: Add support for Murano https://review.openstack.org/421668 | 05:10 |
*** kevo has joined #openstack-sdks | 05:50 | |
*** john-davidge has joined #openstack-sdks | 05:54 | |
*** john-davidge has quit IRC | 05:59 | |
*** amotoki has joined #openstack-sdks | 06:00 | |
openstackgerrit | zhiyong.dai proposed openstack/python-openstackclient: Support "--no-property" option in volume snapshot set https://review.openstack.org/416182 | 06:03 |
openstackgerrit | zhiyong.dai proposed openstack/python-openstackclient: Support "--no-property" option in volume snapshot set https://review.openstack.org/416182 | 06:11 |
*** zhiyong_ has quit IRC | 06:16 | |
*** zhiyong_ has joined #openstack-sdks | 06:30 | |
openstackgerrit | zhiyong.dai proposed openstack/python-openstackclient: Support "--no-property" option in flavor set https://review.openstack.org/421690 | 06:41 |
openstackgerrit | zhiyong.dai proposed openstack/python-openstackclient: Support "--no-property" option in volume snapshot set https://review.openstack.org/416182 | 06:44 |
*** john-davidge has joined #openstack-sdks | 06:51 | |
*** john-davidge has quit IRC | 06:56 | |
*** salv-orlando has joined #openstack-sdks | 07:12 | |
*** bapalm has quit IRC | 07:16 | |
*** salv-orlando has quit IRC | 07:17 | |
*** bapalm has joined #openstack-sdks | 07:18 | |
openstackgerrit | zhiyong.dai proposed openstack/python-openstackclient: Fill the missing colon https://review.openstack.org/421705 | 07:21 |
*** dfflanders has quit IRC | 07:29 | |
reedip | RuiChen: ping | 07:31 |
reedip | RuiChen : lemme know when you are online, would like to discuss on https://review.openstack.org/#/c/419911/2 | 07:42 |
*** john-davidge has joined #openstack-sdks | 07:44 | |
*** salv-orlando has joined #openstack-sdks | 07:45 | |
*** john-davidge has quit IRC | 07:48 | |
*** salv-orlando has quit IRC | 07:53 | |
RuiChen | reedip: hi, let me check it | 07:55 |
reedip | RuiChen: I will explain here, it would be easier to understand than my comment :) | 07:55 |
reedip | RuiChen : please see the function in openstack/resource2.py _prepare_request() | 07:56 |
reedip | That class uses a parameter request_id | 07:56 |
RuiChen | yeah, i am reading your comment | 07:56 |
reedip | sorry requires_id() | 07:56 |
reedip | RuiChen : https://github.com/openstack/python-openstacksdk/blob/master/openstack/resource2.py#L502 | 07:58 |
reedip | RuiChen : if you see https://github.com/openstack/python-openstacksdk/blob/master/openstack/resource2.py#L523-L529 , then you will know that if I pass requires_id as False, then URI would not have the project ID. But if I pass requires_id as True, then the InvalidRequest exception will be raised | 07:59 |
RuiChen | i think it should work, Quota class have id that be passed by def get_quota() | 07:59 |
reedip | RuiChen : if I call the base_class's prepare_request, then it fails because Quota classes do not use ID | 08:00 |
reedip | so putting requires_id as True raises the exception | 08:00 |
reedip | But if I put requires_id as False, then the URI doesnt have the Project ID , and therefore the Neutron Server doesnt get the proper REST request | 08:01 |
*** john-davidge has joined #openstack-sdks | 08:01 | |
reedip | That was why I re-wrote the prepare_request for Quotas | 08:01 |
RuiChen | please wait a minute, let me try the patch in my devstack | 08:02 |
reedip | Similarly, default quotas do not have ID ( like Quotas) and they do not need Project ID in the URI, therefore the defaultQuotas class needs the requires_id | 08:02 |
reedip | RuiChen : ok | 08:02 |
RuiChen | default quota need project id too, it's passed by project=res.id in your other patch | 08:04 |
*** e0ne has joined #openstack-sdks | 08:04 | |
reedip | sorry , wrong statement. It needs project id but not in the URI | 08:05 |
reedip | thats why i put requires_id as false for default quotas in the second patch | 08:05 |
reedip | I was typing faster than I was thinking, thats why the wrong statement :D | 08:06 |
RuiChen | never mind, I debug the patch in my devstack to try openstack quota show, like this | 08:10 |
RuiChen | https://www.irccloud.com/pastebin/LaHmzLVV/ | 08:10 |
reedip | this is quota show, right ? | 08:12 |
RuiChen | yes | 08:13 |
reedip | try quota set and quota-show --default | 08:13 |
reedip | this is your code ? | 08:13 |
RuiChen | https://www.irccloud.com/pastebin/Lpl0Srf1/ | 08:14 |
RuiChen | this quota set --network -1 xxx | 08:14 |
RuiChen | quota show --default have to apply your other patch | 08:14 |
reedip | RuiChen, how did the request body have ID when you deleted it using the if loop ? | 08:15 |
RuiChen | yeah, have to handle the resource_key in body, then delete 'id' | 08:17 |
*** ralonsoh has joined #openstack-sdks | 08:18 | |
reedip | RuiChen : and you are trying this with SDK 0.9.12 right ??? :) | 08:19 |
reedip | just confirming , please do not mind :) | 08:19 |
reedip | Actually with 0.9.12, https://www.irccloud.com/pastebin/Lpl0Srf1/ was not happening for me, without my patch. It was failing at the _prepare_requests because quotas didnt have the ID | 08:20 |
RuiChen | I try the patch in current openstack sdk master, I think the code same with 0.9.12 | 08:20 |
reedip | Yes, it should be | 08:21 |
reedip | :) | 08:21 |
RuiChen | if we can call the super class _prepare_request(), then delete 'id' in body or body[resource_key] to handle the special case for quota and default quota, i think it's better solution | 08:24 |
RuiChen | you don't have to care the _prepare_request() change in the future. | 08:24 |
reedip | RuiChen : wait, I am trying your change | 08:25 |
reedip | I am cloning the latest release and putting your change | 08:25 |
reedip | I still feel I will get a bug :P | 08:25 |
*** markvoelker has joined #openstack-sdks | 08:26 | |
*** john-davidge has quit IRC | 08:28 | |
RuiChen | : ), I'm trying to make small change to handle quota and default quota (show and set action) | 08:28 |
reedip | RuiChen : I think there has been some change somewhere :D | 08:31 |
*** Serlex has joined #openstack-sdks | 08:32 | |
*** amotoki_ has joined #openstack-sdks | 08:33 | |
RuiChen | finally, it worked | 08:35 |
reedip | RuiChen: found the bug ! | 08:35 |
reedip | :) | 08:35 |
reedip | Wait RuiChen :) | 08:36 |
*** amotoki has quit IRC | 08:36 | |
reedip | I had 0.9.10 :P | 08:36 |
reedip | thats why the above code worked. Now using 0.9.12 and ur patch ! | 08:36 |
reedip | and got the issue | 08:36 |
RuiChen | https://www.irccloud.com/pastebin/H5yOdoYA/ | 08:37 |
RuiChen | https://www.irccloud.com/pastebin/xFXl6TFa/ | 08:37 |
*** salv-orlando has joined #openstack-sdks | 08:37 | |
*** amotoki has joined #openstack-sdks | 08:37 | |
reedip | Ok, now it worked ! | 08:39 |
RuiChen | \o/ | 08:40 |
RuiChen | thank you mention the quota set case, that make the patch better | 08:41 |
*** amotoki_ has quit IRC | 08:41 | |
reedip | RuiChen but what about the Default Quota now | 08:42 |
reedip | I need to remove the ID from URI | 08:42 |
reedip | :) | 08:42 |
RuiChen | in default quota case, project_id is not the resource id, it's attribute | 08:43 |
RuiChen | the resource base_path is base_path = '/quotas/%(project)s/default' | 08:43 |
reedip | So how would that work ? | 08:44 |
*** amotoki has quit IRC | 08:44 | |
RuiChen | uri = self.base_path % self._uri.attributes in resource class | 08:44 |
*** amotoki has joined #openstack-sdks | 08:44 | |
RuiChen | in _prepare_request() | 08:44 |
reedip | so you are stating that we do not need to change anything for DefaultQuotas?> | 08:46 |
RuiChen | only to change the def get_quota-default(), pass id and requires_id=False | 08:47 |
reedip | yes, thats what I was thinking | 08:48 |
reedip | so I do not need to change much for the defaultquotas patch | 08:48 |
reedip | from the defaultquotas class | 08:48 |
openstackgerrit | Reedip proposed openstack/python-openstacksdk: Fix Setting Quotas in Neutron https://review.openstack.org/419911 | 08:50 |
reedip | RuiChen vv | 08:50 |
reedip | RuiChen vv | 08:53 |
openstackgerrit | Reedip proposed openstack/python-openstacksdk: Add project ID in QuotaDefault requests https://review.openstack.org/420301 | 08:53 |
openstackgerrit | Reedip proposed openstack/python-openstacksdk: Add project ID in QuotaDefault requests https://review.openstack.org/420301 | 08:54 |
RuiChen | reedip: I had added my +1 for the two patches, thank you | 08:57 |
reedip | Thanks RuiChen :) | 08:58 |
*** kevo has quit IRC | 09:03 | |
*** fzdarsky_ is now known as fzdarsky | 09:15 | |
*** salv-orlando has quit IRC | 09:21 | |
*** dfflanders has joined #openstack-sdks | 09:26 | |
*** amotoki_ has joined #openstack-sdks | 09:29 | |
*** amotoki has quit IRC | 09:31 | |
*** lucas-afk is now known as lucasagomes | 09:45 | |
*** john-davidge has joined #openstack-sdks | 09:48 | |
*** john-davidge has quit IRC | 09:50 | |
*** john-davidge has joined #openstack-sdks | 09:50 | |
*** nandal has joined #openstack-sdks | 10:00 | |
*** hoangcx has quit IRC | 10:06 | |
*** annp has quit IRC | 10:52 | |
*** cdent has joined #openstack-sdks | 10:58 | |
*** yanyanhu has quit IRC | 11:04 | |
*** dfflanders has quit IRC | 11:05 | |
openstackgerrit | Chris Dent proposed openstack/api-wg: [WIP] Refactor and re-validate api change guidelines https://review.openstack.org/421846 | 11:37 |
*** salv-orlando has joined #openstack-sdks | 11:49 | |
*** amotoki_ has quit IRC | 12:01 | |
*** sdague has joined #openstack-sdks | 12:25 | |
*** amotoki has joined #openstack-sdks | 12:46 | |
*** zhiyong_ has quit IRC | 12:50 | |
*** jamielennox is now known as jamielennox|away | 12:59 | |
*** bobh has joined #openstack-sdks | 13:05 | |
*** amotoki has quit IRC | 13:08 | |
*** lucasagomes is now known as lucas-hungry | 13:15 | |
*** jamielennox|away is now known as jamielennox | 13:19 | |
*** lamt has joined #openstack-sdks | 13:23 | |
*** bobh has quit IRC | 13:24 | |
*** lamt has quit IRC | 13:24 | |
*** amotoki has joined #openstack-sdks | 13:28 | |
*** salv-orlando has quit IRC | 13:36 | |
*** _elmiko is now known as elmiko | 14:01 | |
*** amotoki has quit IRC | 14:04 | |
*** cleong has joined #openstack-sdks | 14:09 | |
*** gouthamr has joined #openstack-sdks | 14:13 | |
*** zhiyong_ has joined #openstack-sdks | 14:16 | |
*** amotoki has joined #openstack-sdks | 14:18 | |
*** salv-orlando has joined #openstack-sdks | 14:21 | |
*** lucas-hungry is now known as lucasagomes | 14:25 | |
*** fguillot has joined #openstack-sdks | 14:33 | |
*** fguillot has quit IRC | 14:48 | |
*** mattmceuen has joined #openstack-sdks | 14:52 | |
*** hongbin has joined #openstack-sdks | 14:53 | |
*** bobh has joined #openstack-sdks | 15:01 | |
*** bobh has quit IRC | 15:01 | |
*** bobh has joined #openstack-sdks | 15:01 | |
*** mattmceuen has quit IRC | 15:06 | |
*** openstack has joined #openstack-sdks | 15:21 | |
*** dstanek has joined #openstack-sdks | 15:22 | |
*** zacksh has joined #openstack-sdks | 15:22 | |
*** Matias has joined #openstack-sdks | 15:22 | |
*** Daviey has joined #openstack-sdks | 15:22 | |
*** amotoki has joined #openstack-sdks | 15:22 | |
*** dtroyer has joined #openstack-sdks | 15:22 | |
*** Matias has quit IRC | 15:22 | |
*** Matias has joined #openstack-sdks | 15:22 | |
*** sindhu has joined #openstack-sdks | 15:26 | |
*** DuncanT has joined #openstack-sdks | 15:26 | |
*** briancurtin has joined #openstack-sdks | 15:29 | |
*** john-davidge has quit IRC | 15:32 | |
*** john-davidge has joined #openstack-sdks | 15:32 | |
*** john-davidge has quit IRC | 15:37 | |
*** sheel has quit IRC | 15:37 | |
*** david-lyle has joined #openstack-sdks | 15:47 | |
mordred | dtroyer, stevemar: did we release occ already? | 15:48 |
mordred | ah - looks like we have | 15:49 |
dtroyer | https://review.openstack.org/#/c/421469/ yes | 15:49 |
dtroyer | need another? | 15:49 |
mordred | well - we got this submitted: https://review.openstack.org/#/c/421668/ which seems both easy and friendly - but also not _super_ important | 15:49 |
*** ankur-gupta-f2 has joined #openstack-sdks | 15:51 | |
dtroyer | +A, the deadline is tomorrow if we want that in stable | 15:51 |
dtroyer | wait | 15:51 |
dtroyer | o-c-c- doesn't do stable | 15:51 |
dtroyer | so its just a matter of when it would be released, today/tomorrow or next month | 15:52 |
mordred | oh - neat. cool - no rush then | 15:54 |
openstackgerrit | Dean Troyer proposed openstack/golang-client: Revert "Add crud operation of volume API v3" https://review.openstack.org/422055 | 15:59 |
ankur-gupta-f2 | dtroyer: similar note. Does OSC do a feature freeze? | 16:01 |
dtroyer | ankur-gupta-f: yes, next week. we will have one more release before then, early next week | 16:02 |
dtroyer | osc-lib freezes tomorrow, its to-become-stable-brans is the current release | 16:03 |
dtroyer | s/brans/branch/ | 16:03 |
stevemar | dtroyer: we'll have to get more strict about feature freeze and such soon | 16:03 |
dtroyer | stevemar: soon == now for the new bits (volume v3, etc). | 16:04 |
*** zhiyong_ has quit IRC | 16:05 | |
*** rosmaita has joined #openstack-sdks | 16:07 | |
rosmaita | cdent: would be interested in your opinion of the discussion happening on https://review.openstack.org/#/c/420038/ , especially in light of your email this morning about the new tag proposal | 16:08 |
rosmaita | elmiko: ^^ etoews: ^^ | 16:09 |
ankur-gupta-f2 | dtroyer: Okay. I have told our team that any reviews coming in on any of these https://etherpad.openstack.org/p/osc-transition-priorities to be addressed ASAP. Thanks | 16:09 |
cdent | rosmaita: thanks, will look. I'm experiencing "stability" fatigue | 16:09 |
rosmaita | cdent: ha! well, i will warn you in advance, that this will not help :) | 16:09 |
*** markvoelker has quit IRC | 16:11 | |
elmiko | rosmaita: i'll try to take a look, i'm putting out fires at the moment :/ | 16:11 |
dtroyer | ankur-gupta-f: at this point new commands (not already in-flight) are probably doubtful | 16:11 |
* dtroyer passes cdent some of his anti-consistency-fatigue pills and throws in a s/consistency/stability/ macro for fun | 16:12 | |
ankur-gupta-f2 | dtroyer: most have been in flight and are nearing completion. Just waiting for the final few reviews | 16:13 |
rosmaita | elmiko: best wishes for your firefighting! | 16:13 |
cdent | dtroyer: yeah, I have labeling fatigue too | 16:13 |
elmiko | rosmaita: cheers! | 16:13 |
cdent | dtroyer: I tend to think of consistency on the spatial (amongst apis) dimension and some term (maybe stability) is need for the time (within an api) dimension | 16:15 |
dtroyer | cdent: they both make me tired and make me wonder why in the world this is all so hard | 16:17 |
*** zhiyong_ has joined #openstack-sdks | 16:18 | |
*** reedip_ has joined #openstack-sdks | 16:20 | |
cdent | my eyes are fuzzy enough that I ready dtroyer as saying "makes me wonder why I'm in this world" | 16:21 |
openstackgerrit | Dean Troyer proposed openstack/golang-client: Fix unit tests https://review.openstack.org/422080 | 16:22 |
cdent | I've withheld my opinion on this topic because at least for the time being it is probably too poorly informed to be useful, but yeah it all makes me pretty tired | 16:23 |
*** salv-orl_ has joined #openstack-sdks | 16:24 | |
dtroyer | here is mine: one place that a BDFL is useful is in keeping at least some of the cats in the same order everywhere. I've had to say no so many times to OSC command stuff just to be as close to consistent as we are (still a ways to go). There is no way in h3ll that we'd have accomplished that with teams doing their own thing, even if they agreed on the idea. Even now, many of the OSC plugins slide past the guidelines (I d | 16:26 |
dtroyer | That is just the CLI, and "CLI's are easy" | 16:26 |
*** salv-orlando has quit IRC | 16:27 | |
dtroyer | the only way we will get a clean, consistent REST API for OpenStack is to have a single unit (team, working group, whatever) build it <cough>oaktree</cough> | 16:27 |
dtroyer | </rant> | 16:28 |
cdent | I can get behind that (modulo corporate enterprisey nonsense) | 16:28 |
*** zhiyong_ has quit IRC | 16:28 | |
dtroyer | I think it would take a corporate-type sponsor without an API to defend/enhance to sponsor it to ever get anywhere | 16:30 |
dtroyer | and those are hard to find that also have $$$ to spend "for the good of OpenStack users" | 16:30 |
dtroyer | dang, Wednesday isn't supposed to be "grumpy day" | 16:30 |
openstackgerrit | zhiyong.dai proposed openstack/python-openstackclient: Support "--no-property" option in volume snapshot set https://review.openstack.org/416182 | 16:31 |
openstackgerrit | Shashank Kumar Shankar proposed openstack/python-openstackclient: OSC Network Flavor https://review.openstack.org/382530 | 16:45 |
openstackgerrit | Shashank Kumar Shankar proposed openstack/python-openstackclient: Introduce neutron flavor associate, disassociate to OSC https://review.openstack.org/403907 | 16:45 |
*** zhiyong_ has joined #openstack-sdks | 16:46 | |
*** sheel has joined #openstack-sdks | 16:48 | |
*** e0ne has quit IRC | 16:50 | |
openstackgerrit | Dean Troyer proposed openstack/golang-client: Fix unit tests https://review.openstack.org/422080 | 16:52 |
*** salv-orl_ has quit IRC | 16:58 | |
openstackgerrit | Shashank Kumar Shankar proposed openstack/python-openstackclient: OSC Network Flavor https://review.openstack.org/382530 | 17:08 |
openstackgerrit | Merged openstack/golang-client: Fix unit tests https://review.openstack.org/422080 | 17:31 |
openstackgerrit | Merged openstack/os-client-config: Add support for Murano https://review.openstack.org/421668 | 17:32 |
stevemar | dtroyer: are we waiting for anything in particular before releasing 3.8.0? | 17:34 |
stevemar | oh i guess we have til next week | 17:34 |
stevemar | ignore me | 17:34 |
dtroyer | stevemar: even so, the only release blocker is the broken quota set command, once that is covered the rest is nice to have | 17:35 |
dtroyer | that gets us in a position for SDK 0.9.13 to be released when it is ready and not be rushed | 17:36 |
*** e0ne has joined #openstack-sdks | 17:36 | |
dtroyer | (not that it would be, it just doesn't add any pressure) | 17:36 |
*** david-lyle is now known as bailing-wire | 17:37 | |
stevemar | dtroyer: mm, ok, the quota set command is fixed though? | 17:37 |
stevemar | dtroyer: why not release it sooner and give andrey a chance to review it? we can let the dust settle a bit | 17:38 |
*** markvoelker has joined #openstack-sdks | 17:38 | |
dtroyer | maybe? I saw conversation in the overnight scrollback that I haven't followed up on yet… I'll be back to OSc this afternoon | 17:38 |
stevemar | (random thoughts, you can tell me to buzz off) | 17:38 |
dtroyer | then we'll release twice more | 17:38 |
dtroyer | I want SDK 0.9.12 to be what we use for stable | 17:39 |
openstackgerrit | Sindhu Devale proposed openstack/python-openstackclient: OSC Extension Show https://review.openstack.org/382023 | 17:39 |
*** markvoelker_ has joined #openstack-sdks | 17:44 | |
openstackgerrit | Sindhu Devale proposed openstack/python-openstackclient: OSC Extension Show https://review.openstack.org/382023 | 17:45 |
*** markvoelker has quit IRC | 17:46 | |
*** bailing-wire has quit IRC | 17:46 | |
*** mugsie has left #openstack-sdks | 17:48 | |
*** lucasagomes is now known as lucas-afk | 17:48 | |
*** kevo has joined #openstack-sdks | 17:49 | |
*** markvoelker has joined #openstack-sdks | 17:58 | |
*** reedip_ has quit IRC | 18:00 | |
*** markvoelker_ has quit IRC | 18:01 | |
*** ralonsoh has quit IRC | 18:05 | |
*** thomasem has joined #openstack-sdks | 18:16 | |
*** e0ne has quit IRC | 18:19 | |
*** ankur-gupta-f2 has left #openstack-sdks | 18:40 | |
*** fguillot has joined #openstack-sdks | 18:45 | |
cdent | elmiko, edleafe, etoews : reminder that I won't be around tomorrow to run api-wg meeting. I added the compatibility/stability thing to the agenda, just as a marker | 18:49 |
edleafe | cdent: cool, I can handle running the meeting | 18:53 |
cdent | sweet^wsolid^wthanks | 18:53 |
*** john-davidge has joined #openstack-sdks | 18:56 | |
openstackgerrit | Dean Troyer proposed openstack/python-openstackclient: DNM: OSC+SDK check https://review.openstack.org/422173 | 19:10 |
*** cdent has quit IRC | 19:14 | |
*** john-davidge has quit IRC | 19:25 | |
*** salv-orlando has joined #openstack-sdks | 19:27 | |
openstackgerrit | Dean Troyer proposed openstack/python-openstackclient: Fix functional test for creating subnet https://review.openstack.org/421310 | 19:33 |
openstackgerrit | Justin A Wilson proposed openstack/python-openstackclient: Add support for Cinder API 3.3 into OSC https://review.openstack.org/421585 | 19:35 |
openstackgerrit | Sindhu Devale proposed openstack/python-openstackclient: OSC Extension Show https://review.openstack.org/382023 | 19:37 |
*** ankur-gupta-f2 has joined #openstack-sdks | 19:47 | |
openstackgerrit | Justin A Wilson proposed openstack/python-openstackclient: Add support for Cinder API 3.3 into OSC https://review.openstack.org/421585 | 19:58 |
*** e0ne has joined #openstack-sdks | 19:58 | |
*** bailing-wire has joined #openstack-sdks | 20:00 | |
*** bailing-wire is now known as david-lyle | 20:02 | |
*** markvoelker_ has joined #openstack-sdks | 20:03 | |
*** salv-orlando has quit IRC | 20:04 | |
*** Serlex has quit IRC | 20:04 | |
*** markvoelker has quit IRC | 20:05 | |
openstackgerrit | OpenStack Release Bot proposed openstack/keystoneauth: Update reno for stable/ocata https://review.openstack.org/422208 | 20:06 |
briancurtin | stevemar: if (when, rather) sdk raised DeprecationWarning when certain calls were used, would you catch them in any tests? | 20:17 |
briancurtin | dtroyer: ^ | 20:17 |
dtroyer | briancurtin: I don't see that we catch that exception specifically anywhere | 20:18 |
*** Matias has quit IRC | 20:18 | |
briancurtin | currently nothing on the docket for deprecation would even affect you as there are only two things in network that are being changed, and you don’t use them, but it made me wonder if the process would work. obviously we’d try to find users and let them know and/or work on replacement | 20:19 |
briancurtin | dtroyer: it’s actually a warning, and I’m guessing you don’t have tox setup to run python with warnings enabled (few people ever do, sdk doesn’t so you can shame me too) | 20:19 |
briancurtin | dtroyer: as i’m doing this change on SDK i might poke around in OSC to see if you’d catch this stuff and if not, prepare you to catch it | 20:20 |
dtroyer | ok, cool. prepartions for stuff is good :) | 20:21 |
briancurtin | the warnings are generally outputted at call-time, and I’m sure they get swallowed up by the ostestr or something | 20:21 |
*** Matias has joined #openstack-sdks | 20:24 | |
openstackgerrit | Monty Taylor proposed openstack/os-client-config: Revert "Fix interface_key for identity clients" https://review.openstack.org/422222 | 20:26 |
waj334 | Is there any sort of instructions for adding new commands to the OSC? I can't seem to get it to pick up on the ones that I added. https://review.openstack.org/#/c/421585/ | 20:27 |
waj334 | I added a new .rst for these commands | 20:28 |
*** markvoelker_ has quit IRC | 20:32 | |
ankur-gupta-f2 | waj334: after pulling that patch into the osc dir. run a python setup.py install , or pip install -e . | 20:34 |
waj334 | that's exactly what I'm doing, but nada | 20:35 |
mordred | dtroyer: we discovered a lovely thing that the occ release broke - specifically, connecting identity CRUD on v2 only keystone on openstack (it's a REALLY specific break) - but the patch I just submitted fixes the issue | 20:35 |
ankur-gupta-f2 | waj334: bah. not in office today. See if you can grab Shashank or Sindhu | 20:37 |
mordred | dtroyer, Shrews: I'm torn on whether or not I thikn it's worth having an occ gate job with that config or not - we're adding a shade job that should at least inform us when it happens | 20:39 |
*** ankur-gupta-f2 has left #openstack-sdks | 20:40 | |
openstackgerrit | Steve Martinelli proposed openstack/keystoneauth: Update reno for stable/ocata https://review.openstack.org/422208 | 20:41 |
dtroyer | mordred: I'm going to lean toward yes… as occ grown more stuff it needs to handle the edge cases for a wide variety of configurations. If I ever get down my list far enough I have a pile-o-tests to add to it so OSC doesn't break in more fun areas… | 20:41 |
mordred | dtroyer: cool. I'll get the test job added and then trigger it on occ changes too | 20:43 |
*** adriant has joined #openstack-sdks | 20:44 | |
*** annegentle has joined #openstack-sdks | 20:49 | |
openstackgerrit | Merged openstack/python-openstacksdk: Corrections in DHCP Agent Resource listing. https://review.openstack.org/421568 | 20:51 |
*** e0ne has quit IRC | 20:51 | |
Shrews | shade is the client "canary in a coal mine" :) | 20:51 |
openstackgerrit | Merged openstack/python-openstackclient: Fill the missing colon https://review.openstack.org/421705 | 21:10 |
*** jamielennox is now known as jamielennox|away | 21:26 | |
*** gouthamr has quit IRC | 21:34 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/api-wg: Accurate status code vs. Backwards compatibility https://review.openstack.org/422264 | 21:53 |
*** gouthamr has joined #openstack-sdks | 21:57 | |
*** amotoki has quit IRC | 21:58 | |
*** Guest76124 has quit IRC | 22:01 | |
*** annegentle has quit IRC | 22:10 | |
*** jamielennox|away is now known as jamielennox | 22:10 | |
*** fguillot has quit IRC | 22:11 | |
*** jamielennox is now known as jamielennox|away | 22:24 | |
*** david-lyle has quit IRC | 22:32 | |
*** david-lyle has joined #openstack-sdks | 22:40 | |
*** annegentle has joined #openstack-sdks | 22:41 | |
*** amotoki has joined #openstack-sdks | 22:59 | |
*** salv-orlando has joined #openstack-sdks | 23:05 | |
*** salv-orlando has quit IRC | 23:09 | |
openstackgerrit | Merged openstack/keystoneauth: Update reno for stable/ocata https://review.openstack.org/422208 | 23:13 |
openstackgerrit | Merged openstack/os-client-config: Revert "Fix interface_key for identity clients" https://review.openstack.org/422222 | 23:19 |
dtroyer | mordred: https://review.openstack.org/422308 releases o-c-c 1.26.0 | 23:22 |
dtroyer | so murano is in too | 23:23 |
mordred | dtroyer: woot! thank you | 23:23 |
openstackgerrit | Ed Leafe proposed openstack/api-wg: Add guidelines for boolean names https://review.openstack.org/411529 | 23:23 |
openstackgerrit | Ankur proposed openstack/python-openstacksdk: Network L3 Router Commands https://review.openstack.org/385728 | 23:23 |
mordred | edleafe: soo ... not that it matters, because shade != openstack rest apis ... | 23:24 |
*** Matias has quit IRC | 23:24 | |
*** kevo has quit IRC | 23:24 | |
*** sheel has quit IRC | 23:24 | |
*** elmiko has quit IRC | 23:24 | |
*** Dinesh_Bhor has quit IRC | 23:24 | |
*** stevemar has quit IRC | 23:24 | |
mordred | edleafe: but shade went the oppposite way on booleans - prefixing them all with is_ or has_ | 23:24 |
*** Matias has joined #openstack-sdks | 23:24 | |
*** kevo has joined #openstack-sdks | 23:24 | |
*** sheel has joined #openstack-sdks | 23:24 | |
*** elmiko has joined #openstack-sdks | 23:24 | |
*** Dinesh_Bhor has joined #openstack-sdks | 23:24 | |
*** stevemar has joined #openstack-sdks | 23:24 | |
mordred | edleafe: although I definitely agree with the positive naming and see a place where we missed one of those | 23:27 |
openstackgerrit | Ed Leafe proposed openstack/api-wg: Clarify the status values in versions https://review.openstack.org/411849 | 23:28 |
edleafe | mordred: Please add those comments to the review. I simply did a cursory survey of several projects, and put that guideline up as a strawman for people to beat on. | 23:30 |
mordred | edleafe: woot! will do | 23:31 |
edleafe | kewl | 23:31 |
*** annegentle has quit IRC | 23:32 | |
openstackgerrit | Merged openstack/python-openstackclient: Fix functional test for creating subnet https://review.openstack.org/421310 | 23:53 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!