*** markvoelker has joined #openstack-sdks | 00:01 | |
*** markvoelker has quit IRC | 00:05 | |
*** bobh has joined #openstack-sdks | 00:11 | |
*** john-davidge has joined #openstack-sdks | 00:14 | |
*** john-davidge has quit IRC | 00:18 | |
*** dave-mccowan has joined #openstack-sdks | 00:21 | |
*** reedip has quit IRC | 00:25 | |
*** hoangcx has joined #openstack-sdks | 00:45 | |
*** hongbin has quit IRC | 00:45 | |
*** bobh has quit IRC | 00:52 | |
*** bobh has joined #openstack-sdks | 00:55 | |
*** jamielennox is now known as jamielennox|away | 01:02 | |
*** bobh has quit IRC | 01:08 | |
*** jamielennox|away is now known as jamielennox | 01:16 | |
*** e0ne has joined #openstack-sdks | 01:20 | |
*** e0ne has quit IRC | 01:25 | |
*** yanyanhu has joined #openstack-sdks | 01:26 | |
*** huanxuan has joined #openstack-sdks | 01:39 | |
*** amotoki has joined #openstack-sdks | 01:46 | |
*** huanxuan has quit IRC | 01:51 | |
openstackgerrit | Ethan Lynn proposed openstack/python-openstacksdk master: Add vlan_transparent property to network resource https://review.openstack.org/450080 | 01:51 |
---|---|---|
*** amotoki has quit IRC | 01:58 | |
*** huanxuan has joined #openstack-sdks | 02:11 | |
*** john-davidge has joined #openstack-sdks | 02:15 | |
*** huanxuan has quit IRC | 02:16 | |
*** john-davidge has quit IRC | 02:19 | |
*** e0ne has joined #openstack-sdks | 02:21 | |
*** e0ne has quit IRC | 02:25 | |
*** reedip has joined #openstack-sdks | 02:31 | |
*** gouthamr has quit IRC | 02:37 | |
*** gouthamr has joined #openstack-sdks | 02:43 | |
openstackgerrit | Merged openstack/python-openstacksdk master: Add vlan_transparent property to network resource https://review.openstack.org/450080 | 02:44 |
*** yuanying has quit IRC | 02:55 | |
*** amotoki has joined #openstack-sdks | 03:00 | |
*** dave-mccowan has quit IRC | 03:03 | |
reedip | dtroyer, stevemar there / | 03:05 |
*** annp has joined #openstack-sdks | 03:08 | |
openstackgerrit | Merged openstack/python-openstacksdk master: Find floating ip by ip address https://review.openstack.org/449879 | 03:16 |
openstackgerrit | Takashi NATSUME proposed openstack/python-openstackclient master: Add '--no-live' and '--force' option in 'server migrate' https://review.openstack.org/427565 | 03:19 |
*** gouthamr has quit IRC | 03:19 | |
*** e0ne has joined #openstack-sdks | 03:22 | |
*** e0ne has quit IRC | 03:23 | |
*** erlon has quit IRC | 03:35 | |
*** Dinesh_Bhor has joined #openstack-sdks | 04:00 | |
*** john-davidge has joined #openstack-sdks | 04:16 | |
openstackgerrit | Takashi NATSUME proposed openstack/python-openstackclient master: List/Show all server migration types https://review.openstack.org/450119 | 04:16 |
*** reedip has quit IRC | 04:17 | |
*** reedip has joined #openstack-sdks | 04:19 | |
*** john-davidge has quit IRC | 04:20 | |
*** e0ne has joined #openstack-sdks | 04:22 | |
*** e0ne has quit IRC | 04:27 | |
*** yuanying has joined #openstack-sdks | 04:39 | |
*** e0ne has joined #openstack-sdks | 05:23 | |
*** e0ne has quit IRC | 05:28 | |
*** huanxuan has joined #openstack-sdks | 05:42 | |
*** reedip has quit IRC | 05:54 | |
*** reedip has joined #openstack-sdks | 06:01 | |
*** jamielennox is now known as jamielennox|away | 06:10 | |
*** john-davidge has joined #openstack-sdks | 06:16 | |
*** john-davidge has quit IRC | 06:21 | |
*** Serlex has joined #openstack-sdks | 06:21 | |
*** rabel has joined #openstack-sdks | 06:21 | |
*** jamielennox|away is now known as jamielennox | 06:25 | |
*** jamielennox is now known as jamielennox|away | 06:50 | |
openstackgerrit | Takashi NATSUME proposed openstack/python-openstackclient master: List/Show all server migration types https://review.openstack.org/450119 | 06:53 |
*** jkilpatr has quit IRC | 06:53 | |
rabel | good morning | 06:56 |
*** jamielennox|away is now known as jamielennox | 06:57 | |
*** alex_xu has quit IRC | 07:13 | |
reedip | good afternoon | 07:14 |
*** alex_xu has joined #openstack-sdks | 07:16 | |
*** ralonsoh has joined #openstack-sdks | 07:25 | |
*** Matias has quit IRC | 07:27 | |
*** fzdarsky has joined #openstack-sdks | 07:29 | |
*** aarefiev_afk is now known as aarefiev | 07:32 | |
*** prg3 has quit IRC | 07:33 | |
*** Matias has joined #openstack-sdks | 07:39 | |
rabel | reedip: ;) | 07:48 |
reedip | :) | 07:49 |
rabel | could someone have a look at https://review.openstack.org/#/c/444924/ ? It is not of high priority, but it lies idle for a week now. | 07:52 |
*** fzdarsky has quit IRC | 07:54 | |
*** e0ne has joined #openstack-sdks | 07:54 | |
reedip | rabel hi | 07:57 |
reedip | i had a patch for smething you are doing in Line#614 | 07:57 |
reedip | but didnt push it again ... need to retake it | 07:58 |
reedip | you can put this logic in osc-lib | 07:58 |
reedip | the split on , and then dict key value pair logic | 07:58 |
reedip | https://review.openstack.org/#/c/425515/ | 07:59 |
openstackgerrit | Reedip proposed openstack/osc-lib master: [WIP]Add MultiKeyValueCommaAction to osc-lib https://review.openstack.org/425515 | 08:00 |
reedip | rabel : can you check this patch , it would avoid you repeating the same code ( probably ) | 08:00 |
*** fzdarsky has joined #openstack-sdks | 08:03 | |
rabel | reedip: i will have a look at it. it would make sense to use your class for my patch once it is merged. | 08:03 |
reedip | rabel yes . though I wont like to bliock you , so you can add a ToDo for yourself | 08:04 |
reedip | that ways, everything is perfect, I guess | 08:04 |
rabel | reedip: it's true that my patch could already be merged without yours. i use the same logic as the --nic implementation. so we could change both to use the new class in a separate patch. | 08:05 |
reedip | rabel : sounds good ... lets race :D | 08:06 |
reedip | just kidding, I will push mine a bit slower , but otherwise the code looks good , I will look at it once more though in the evening | 08:07 |
rabel | :D i added me as a reviewer for your patch. i will have a look at it now and once you finished it, i will review it in detail | 08:09 |
reedip | :D | 08:13 |
*** jamielennox is now known as jamielennox|away | 08:17 | |
*** john-davidge has joined #openstack-sdks | 08:17 | |
*** john-davidge has quit IRC | 08:22 | |
*** fzdarsky has quit IRC | 08:24 | |
*** fzdarsky has joined #openstack-sdks | 08:26 | |
*** yuanying has quit IRC | 08:31 | |
rabel | reedip: let's see if i understand it right: the difference between MultiKeyValueAction and MultiKeyValueCommaAction is the latter supports something like "--my_param key1=val,ue1,key2=val,ue3", is that right? | 08:32 |
reedip | something like that | 08:33 |
reedip | actually exatly liek that | 08:33 |
rabel | than i think --nic, --network and --port should use MultiKeyValueAction, since we don't have values containing commas or multiple values for a key, i think. | 08:35 |
rabel | by the way: your patch looks good to me | 08:36 |
reedip | --network can have IPV4 address, IPv6 address and Network ID | 08:43 |
reedip | as the addresses are one-to-one, so I guess yes, the multikeyvaluecomma action may not be required | 08:44 |
*** fzdarsky has quit IRC | 08:51 | |
*** fzdarsky has joined #openstack-sdks | 09:15 | |
RuiChen | hi dtroyer: I add comments in your patch https://review.openstack.org/#/c/450452/ | 09:19 |
*** sdague has joined #openstack-sdks | 09:29 | |
*** annp has quit IRC | 09:34 | |
*** reedip has quit IRC | 09:34 | |
*** reedip has joined #openstack-sdks | 09:37 | |
*** yuanying has joined #openstack-sdks | 09:39 | |
*** amotoki has quit IRC | 09:40 | |
*** reedip has quit IRC | 09:43 | |
*** yuanying has quit IRC | 09:44 | |
*** yuanying has joined #openstack-sdks | 09:47 | |
*** reedip has joined #openstack-sdks | 09:48 | |
*** yanyanhu has quit IRC | 09:51 | |
*** yanyanhu has joined #openstack-sdks | 09:52 | |
*** reedip has quit IRC | 10:01 | |
*** e0ne has quit IRC | 10:01 | |
*** e0ne has joined #openstack-sdks | 10:01 | |
*** amotoki has joined #openstack-sdks | 10:16 | |
*** amotoki has quit IRC | 10:17 | |
*** john-davidge has joined #openstack-sdks | 10:18 | |
*** john-davidge has quit IRC | 10:22 | |
*** yanyanhu has quit IRC | 10:23 | |
*** amotoki has joined #openstack-sdks | 10:31 | |
*** fzdarsky has quit IRC | 10:39 | |
*** amotoki has quit IRC | 10:40 | |
*** hoangcx has quit IRC | 10:43 | |
*** reedip has joined #openstack-sdks | 10:58 | |
*** jkilpatr has joined #openstack-sdks | 11:02 | |
*** jkilpatr has quit IRC | 11:07 | |
*** jkilpatr has joined #openstack-sdks | 11:07 | |
*** amotoki has joined #openstack-sdks | 11:11 | |
*** john-davidge has joined #openstack-sdks | 11:56 | |
*** chlong has quit IRC | 12:05 | |
dtroyer | RuiChen: thanks. FWIW, if we have not already set neutron to be the default for help we should do that so we can still do most help wihtout auth. | 12:08 |
dtroyer | it looks like that is the case… with no auth info, openstack help lists neutron commands now | 12:09 |
*** dave-mccowan has joined #openstack-sdks | 12:46 | |
*** gouthamr has joined #openstack-sdks | 12:47 | |
*** reedip has quit IRC | 12:52 | |
*** huanxuan has quit IRC | 13:04 | |
*** efried has left #openstack-sdks | 13:12 | |
*** bobh has joined #openstack-sdks | 13:14 | |
*** prg3 has joined #openstack-sdks | 13:18 | |
*** erlon has joined #openstack-sdks | 13:20 | |
*** fzdarsky has joined #openstack-sdks | 13:24 | |
*** Matias has quit IRC | 13:25 | |
*** jpich has joined #openstack-sdks | 13:34 | |
*** Matias has joined #openstack-sdks | 13:37 | |
*** chlong has joined #openstack-sdks | 13:40 | |
*** fzdarsky has quit IRC | 13:41 | |
*** e0ne has quit IRC | 13:41 | |
*** e0ne has joined #openstack-sdks | 13:41 | |
*** e0ne has quit IRC | 13:54 | |
*** reedip has joined #openstack-sdks | 14:00 | |
openstackgerrit | Jens Rosenboom proposed openstack/python-openstackclient master: Fix block-device-mapping when volume_size is empty https://review.openstack.org/451432 | 14:23 |
reedip | o/ | 14:32 |
frickler | why does e.g. "openstack server show" use compute API v2.1 by default and not something newer? | 14:43 |
frickler | that way it is not showing some information, like delete_on_termination attribute for volume attachments | 14:43 |
frickler | seems that was already discussed yesterday, so I'd just say that I'm +1 on "use the latest" | 14:45 |
openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: [WIP] Introduce Pool resource in Octavia Load Balancer Base https://review.openstack.org/449264 | 14:47 |
*** bobh has quit IRC | 14:56 | |
*** amotoki has quit IRC | 14:56 | |
*** bobh has joined #openstack-sdks | 15:06 | |
*** bobh has quit IRC | 15:06 | |
*** bobh has joined #openstack-sdks | 15:07 | |
*** cleong has joined #openstack-sdks | 15:07 | |
*** bobh has quit IRC | 15:11 | |
*** e0ne has joined #openstack-sdks | 15:13 | |
*** alex_xu has quit IRC | 15:33 | |
*** eliqiao has quit IRC | 15:33 | |
*** alex_xu has joined #openstack-sdks | 15:35 | |
*** eliqiao has joined #openstack-sdks | 15:37 | |
*** bobh has joined #openstack-sdks | 15:43 | |
*** eliqiao has quit IRC | 15:46 | |
*** eliqiao has joined #openstack-sdks | 15:53 | |
*** amotoki has joined #openstack-sdks | 15:57 | |
*** amotoki has quit IRC | 16:03 | |
*** e0ne has quit IRC | 16:06 | |
*** annegentle has joined #openstack-sdks | 16:06 | |
*** e0ne has joined #openstack-sdks | 16:06 | |
*** aarefiev is now known as aarefiev_afk | 16:08 | |
*** john-davidge has quit IRC | 16:10 | |
*** john-davidge has joined #openstack-sdks | 16:11 | |
*** d0ugal has quit IRC | 16:17 | |
ankur-gupta-f4 | reedip: can you verify or not this bug: https://bugs.launchpad.net/python-openstackclient/+bug/1677252 | 16:19 |
openstack | Launchpad bug 1677252 in python-openstackclient ""network auto allocated topology create --check-resources" Fails with: "Request requires an ID but none was found"" [Undecided,New] | 16:19 |
reedip | ankur-gupta-f4 : u r lucky .. I was just drowsing :D | 16:20 |
ankur-gupta-f4 | ah well then good night :P | 16:20 |
reedip | ankur-gupta-f4 : this seems to be a bug | 16:20 |
reedip | jsut checking on master | 16:21 |
reedip | ankur-gupta-f4 : assigning it to myself with a bit of homework done, rest in another 6 hours I guess | 16:23 |
reedip | if u have any opinion, please do lemme know | 16:24 |
ankur-gupta-f4 | K. I have a patch that is blocked till its resolved | 16:24 |
reedip | ohh then wait | 16:25 |
ankur-gupta-f4 | do you know where the bug resides? | 16:25 |
reedip | SDK | 16:25 |
reedip | request preparation | 16:25 |
ankur-gupta-f4 | too lazy today to dig in | 16:25 |
ankur-gupta-f4 | okay | 16:25 |
reedip | wait | 16:26 |
reedip | http://paste.openstack.org/show/604690/ | 16:26 |
reedip | The --check resources is | 16:27 |
reedip | --check-resources Validate the requirements for auto allocated topology. | 16:27 |
reedip | Does not return a topology. | 16:27 |
reedip | ankur-gupta-f4 : I guess the current tenant ID needs to be used up | 16:28 |
reedip | for aut-allocated-topology with --check-resource | 16:28 |
ankur-gupta-f4 | so its just not passing, getting from context, the tenant/project id | 16:29 |
reedip | guess so | 16:29 |
ankur-gupta-f4 | bah. annoying. | 16:29 |
reedip | welcome to my world :D | 16:29 |
reedip | that was the last patch on _proxy | 16:30 |
reedip | https://github.com/openstack/python-openstacksdk/commit/e5068ec46aa7bb6b1738b8a64c29e44307f4ba98 | 16:30 |
reedip | seems like it fixed some. broke some | 16:30 |
reedip | maybe | 16:31 |
ankur-gupta-f4 | hmmm | 16:35 |
ankur-gupta-f4 | its weird because the fix from terry was in the last release of the SDK | 16:36 |
ankur-gupta-f4 | :( | 16:36 |
reedip | did it have the check for --check-resources? | 16:36 |
ankur-gupta-f4 | yea --check-resources his the Validate... function in auto_allocated_topology and the changes are there | 16:36 |
reedip | hmm lem edebug | 16:37 |
reedip | wait I think my code is not up to date ! | 16:37 |
*** e0ne has quit IRC | 16:38 | |
*** d0ugal has joined #openstack-sdks | 16:39 | |
reedip | I have 0.9.13 | 16:39 |
reedip | Upgraded to 0.9.14 and now checking | 16:39 |
reedip | it works ! | 16:40 |
reedip | thats weird ! | 16:40 |
ankur-gupta-f4 | yea | 16:40 |
ankur-gupta-f4 | its a matter of bumping global reqs | 16:40 |
reedip | done! | 16:42 |
reedip | He may have pulled up the master for OSC but not SDK | 16:42 |
reedip | if he is on Neutron, then lemme drop him a ping | 16:42 |
*** d0ugal has quit IRC | 16:43 | |
ankur-gupta-f4 | briancurtin: here? | 16:47 |
reedip | ankur-gupta-f4; that bug is now closed ( or would be soon ) | 16:48 |
ankur-gupta-f4 | k thanks | 16:50 |
reedip | :) | 16:51 |
*** amotoki has joined #openstack-sdks | 16:59 | |
*** eliqiao has quit IRC | 17:01 | |
openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: [WIP] Introduce Member for Octavia (loadbalancing) https://review.openstack.org/451488 | 17:01 |
*** eliqiao has joined #openstack-sdks | 17:02 | |
*** chlong has quit IRC | 17:03 | |
*** amotoki has quit IRC | 17:04 | |
*** rabel has quit IRC | 17:09 | |
*** jpich has quit IRC | 17:24 | |
openstackgerrit | Ankur proposed openstack/python-openstackclient master: Network L3 Router Commands for OSC https://review.openstack.org/385729 | 17:28 |
*** e0ne has joined #openstack-sdks | 17:42 | |
*** eliqiao has quit IRC | 17:49 | |
*** eliqiao has joined #openstack-sdks | 17:50 | |
*** bobh has quit IRC | 17:53 | |
*** e0ne has quit IRC | 17:53 | |
*** ralonsoh has quit IRC | 17:57 | |
*** chlong has joined #openstack-sdks | 17:58 | |
*** amotoki has joined #openstack-sdks | 18:00 | |
*** amotoki has quit IRC | 18:05 | |
*** chlong has quit IRC | 18:07 | |
*** alex_xu has quit IRC | 18:07 | |
*** alex_xu has joined #openstack-sdks | 18:08 | |
*** chlong has joined #openstack-sdks | 18:21 | |
openstackgerrit | Sindhu Devale proposed openstack/python-openstackclient master: "floating ip set/unset port" for OSC https://review.openstack.org/383025 | 18:33 |
*** chlong has quit IRC | 18:34 | |
openstackgerrit | Sindhu Devale proposed openstack/python-openstackclient master: "floating ip set/unset port" for OSC https://review.openstack.org/383025 | 18:34 |
*** openstackstatus has joined #openstack-sdks | 18:45 | |
*** ChanServ sets mode: +v openstackstatus | 18:45 | |
*** chlong has joined #openstack-sdks | 18:49 | |
*** bobh has joined #openstack-sdks | 18:49 | |
*** e0ne has joined #openstack-sdks | 18:50 | |
*** hongbin has joined #openstack-sdks | 18:59 | |
*** amotoki has joined #openstack-sdks | 19:01 | |
*** brianw has quit IRC | 19:04 | |
*** amotoki has quit IRC | 19:05 | |
*** e0ne has quit IRC | 19:06 | |
openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: Introduce Member for Octavia (loadbalancing) https://review.openstack.org/451488 | 19:13 |
openstackgerrit | Ed Leafe proposed openstack/api-wg master: Recommend the correct HTTP method for tags https://review.openstack.org/451536 | 19:26 |
*** eliqiao has quit IRC | 19:28 | |
*** john-davidge has quit IRC | 19:31 | |
*** openstackgerrit has quit IRC | 19:33 | |
*** jamielennox|away is now known as jamielennox | 19:33 | |
*** eliqiao has joined #openstack-sdks | 19:33 | |
*** kfowler has quit IRC | 19:34 | |
*** chlong has quit IRC | 19:34 | |
dtroyer | frickler: /me catches up a bit | 19:35 |
dtroyer | The default compute API version is a bit of a mess because it may be set by OSC or by os-client-config. In either case it is '2' or '2.1'. This is equivalent to the Compute API itself that uses '2.1' if no microversion header is included in a request | 19:36 |
dtroyer | we accepted that behaviour because it meant OSC was backward-compatible | 19:36 |
dtroyer | as you've seen, specifying a microversion in —os-compute-api-version (or clouds.yaml) does work | 19:37 |
dtroyer | here's what I would like to do, need to get some feedback: | 19:37 |
dtroyer | change the meaning of version '2' to be '2.latest' without actually using the 'latest' text that the apiref warns is meant for testing. | 19:38 |
dtroyer | so while novaclient is available, we'd use novaclient.API_MAX_VERSION as the default for '2' | 19:38 |
frickler | dtroyer: sounds reasonable to me, seems like that would kind of ensure feature parity between osc and novaclient like for the volume status output | 19:43 |
frickler | dtroyer: also, using cloud.cfg with an explicit compute API version selected might in fact be a good enough workaround for me. I've been wanting to dump our openrc stuff in favor of that for some time now anyway | 19:45 |
*** d0ugal has joined #openstack-sdks | 19:49 | |
*** Serlex has quit IRC | 19:56 | |
*** d0ugal has quit IRC | 20:00 | |
*** amotoki has joined #openstack-sdks | 20:02 | |
*** annegentle has quit IRC | 20:04 | |
*** amotoki has quit IRC | 20:06 | |
*** annegentle has joined #openstack-sdks | 20:08 | |
*** john-davidge has joined #openstack-sdks | 20:16 | |
*** shadower has quit IRC | 20:27 | |
*** Guest6666 has quit IRC | 20:28 | |
*** Guest6666 has joined #openstack-sdks | 20:29 | |
*** annegentle has quit IRC | 20:51 | |
*** openstackgerrit has joined #openstack-sdks | 20:55 | |
openstackgerrit | Jim Rollenhagen proposed openstack/os-client-config master: Docs: add a note about rackspace API keys https://review.openstack.org/451563 | 20:55 |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/api-wg master: Clarify the meaning of BODY https://review.openstack.org/451568 | 21:00 |
*** amotoki has joined #openstack-sdks | 21:02 | |
*** amotoki has quit IRC | 21:07 | |
*** annegentle has joined #openstack-sdks | 21:12 | |
*** cleong has quit IRC | 21:19 | |
*** gouthamr has quit IRC | 21:21 | |
openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: Introduce Listener for Octavia (load balancing) https://review.openstack.org/451574 | 21:32 |
*** ssbarnea has quit IRC | 21:34 | |
*** timss has quit IRC | 21:44 | |
*** timss has joined #openstack-sdks | 21:45 | |
*** john-davidge has quit IRC | 21:47 | |
*** erlon has quit IRC | 21:55 | |
*** bobh has quit IRC | 21:58 | |
*** amotoki has joined #openstack-sdks | 22:03 | |
*** amotoki has quit IRC | 22:08 | |
*** jamielennox is now known as jamielennox|away | 22:09 | |
*** annegentle has quit IRC | 22:10 | |
*** jamielennox|away is now known as jamielennox | 22:12 | |
jamielennox | dtroyer: so the part i've always been stuck with is how to do negotiation | 22:18 |
jamielennox | it's pretty easy to add a header, and even do the discovery bit | 22:18 |
jamielennox | dtroyer: quieter here :) | 22:19 |
dtroyer | I'm just at discovery/negotiation | 22:19 |
jamielennox | dtroyer: the part i don't know how to do is the fallback for do X if something is available else do Y | 22:19 |
dtroyer | since for the moment novaclient is handling that. but the discovery they do is in the shell so OSC doesn't get it | 22:19 |
dtroyer | I think I'm glad for that | 22:19 |
jamielennox | i hate so much that they expose this stuff to the shell | 22:20 |
dtroyer | I think that is a higher-level problem. I see the version exception stuff going all the way up to OSC's command classes | 22:20 |
dtroyer | yeah, that was a good first-cut in novaclient, time to generalize cleanly :) | 22:21 |
jamielennox | dtroyer: so i'm keen to put that information into ksa, i just don't know how so if you come up with something at least we can discuss from there | 22:21 |
dtroyer | do you have an opinion on using a Version class like novaclient does? I did that in one of my other early attempts at this, not sure if that should go into ksa though | 22:21 |
jamielennox | will need to have another look at novaclient | 22:21 |
dtroyer | I'm going to work in osc I think for now until it becomes clearer. this is tightly tied into the plugin mechanism for osc | 22:22 |
jamielennox | dtroyer: do they do version class for microversions/ | 22:23 |
dtroyer | but the atomic bits can and shold go somewhere common | 22:23 |
dtroyer | yes | 22:23 |
dtroyer | nothing there is specific to microversions, it's just an x.y representation. I did x.y.z before… | 22:23 |
jamielennox | i have very simplistic versions of that in discover | 22:24 |
jamielennox | but i don't think there is any way to check a minimum there - because it never needed to | 22:24 |
jamielennox | so yea, i'd be happy to take that | 22:25 |
jamielennox | i think there is a version of that in one of the oslo libs already - but we can redirect that to ksa | 22:25 |
jamielennox | dtroyer: a possible implementation might be a request class you can pass to ksa? subclass the request() bit with a number of if microversion >x<y stuff | 22:27 |
jamielennox | i think i'll let you play with it | 22:28 |
jamielennox | though one of the things i meant to do after atlanta was draw up a new version of a cross-project discovery page | 22:28 |
dtroyer | I need to make version decisions in commands before I get that far | 22:28 |
jamielennox | something that did major and microversion discovery - and probably capabilities on the same request | 22:28 |
dtroyer | oooh, that would be helpful at some point :) | 22:29 |
jamielennox | ya, if we just put it on a new content-type and say ksa works if you implement this i think we might actually get some traction as opposed to last time i did it | 22:29 |
jamielennox | dtroyer: anyway i can wait and make sure to put everything we actually need in there first | 22:33 |
jamielennox | dtroyer: so on another front did you have a look at the os-c-c-2 WIP i put up | 22:33 |
jamielennox | ? | 22:33 |
jamielennox | i cannot figure out what i want that interface to look like | 22:33 |
dtroyer | I did last week and wasn't exactly sure I understood it all | 22:33 |
jamielennox | yea, i didn't make it easy, it was all experimenting and no comments | 22:34 |
dtroyer | I am ok with the current interface, basically decomposing get_one_cloud() so I can insert things and leave out other things is what I'm looking for | 22:35 |
dtroyer | that auth plugin loading bit me again this week | 22:35 |
dtroyer | it happens waaaaaay to early in o-c-c | 22:36 |
jamielennox | dtroyer: agreed, i'm not sure i want people overriding it | 22:37 |
jamielennox | my thought was it should be simply a datastore | 22:37 |
jamielennox | but i got way into the weeds | 22:37 |
dtroyer | that would be my preference | 22:39 |
dtroyer | I would love to hand it an argparse Namespace, have it merge that with clouds.*, do all of the hacky things to make interop work and be done | 22:40 |
jamielennox | that's part of where i was getting caught up, does o-c-c control the parser, what about envs? | 22:41 |
jamielennox | how do you handle the AllClouds object vs the get_one_cloud case | 22:43 |
dtroyer | OSC does the parser and env (via argparse) | 22:43 |
dtroyer | I don't look at AllClouds at all | 22:43 |
jamielennox | yea, but o-c-c has to maintain that | 22:44 |
dtroyer | altough commands to work with clouds.yaml might | 22:44 |
dtroyer | right, that's fine | 22:44 |
dtroyer | I would be OK with there being a common set of argparse declaration in o-c-c, but I want control over it | 22:45 |
*** gouthamr has joined #openstack-sdks | 22:46 | |
*** sdague has quit IRC | 22:46 | |
dtroyer | working with this again Monday I realized just how f-ed up OSC's use of the auth plugins is. IS it work fixing that before this rewrite is done? do those go together? | 22:46 |
jamielennox | dtroyer: i've attempted to mess with osc's auth plugins before and can never find a way to exactly maintain compatibility | 22:51 |
jamielennox | but i don't think you should wait for o-c-c | 22:51 |
*** reedip has quit IRC | 22:51 | |
*** john-davidge has joined #openstack-sdks | 22:51 | |
dtroyer | we can't avoid breaking some things. I'm preparing for a 4.0 where we can make some changes there | 22:51 |
dtroyer | since _everything else_ is doing some things differently than OSC, maybe its time OSC adjusts a bit | 22:52 |
jamielennox | would be nice to have the o-c-c fixed up for then | 22:53 |
jamielennox | not sure how likely that is though | 22:53 |
dtroyer | yeah, I expected some things to change there. I don't knwo what the timing of 4.0 is, June/July at the absolute earliest | 22:54 |
*** john-davidge has quit IRC | 22:56 | |
dtroyer | one other thing that's bugging me: you mentioned a long time ago that I should be making requests adapters rather than sessions. | 22:56 |
dtroyer | I'm thinking I need to fix that too | 22:57 |
*** amotoki has joined #openstack-sdks | 23:04 | |
jamielennox | dtroyer: so adapters were a direct response to how you create a client once and then reuse it with the same parameters | 23:04 |
jamielennox | it meant you could do things like set the service_type on an object and make calls via that rather than set it every time on a session.request | 23:05 |
jamielennox | it's _probably_ easier give that you do like a create_client thing that returns something specific to that usage | 23:05 |
jamielennox | but if you know what you're doing with a session you may not need it | 23:06 |
jamielennox | it really depends on how you want to use it | 23:06 |
dtroyer | ok. I was looking at shade and wanting to converge some of the lower-level stuff a bit more. I've got to implement some nova-net stuff that's being removed from novaclient so I was looknig again at OSC' api layer stuff | 23:07 |
*** amotoki has quit IRC | 23:09 | |
*** reedip has joined #openstack-sdks | 23:26 | |
*** reedip has quit IRC | 23:31 | |
*** reedip has joined #openstack-sdks | 23:45 | |
*** hieulq has quit IRC | 23:47 | |
*** reedip has quit IRC | 23:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!