*** jkilpatr has quit IRC | 00:04 | |
*** reedip has joined #openstack-sdks | 00:25 | |
*** bobh has joined #openstack-sdks | 00:38 | |
*** bobh has quit IRC | 00:44 | |
*** erlon has quit IRC | 00:45 | |
*** jamielennox|away is now known as jamielennox | 01:06 | |
*** hoangcx has joined #openstack-sdks | 01:13 | |
*** reedip has quit IRC | 01:40 | |
*** reedip has joined #openstack-sdks | 01:59 | |
reedip | o/ | 02:04 |
---|---|---|
ankur-gupta-f4 | reedip: dont file bug. Only if there was existing. But its just a refactor so its fine | 02:06 |
reedip | ankur-gupta-f4 : were u just waiting for me with that response already typed ???? :D | 02:07 |
reedip | I am not filing a bug :) , dont worry :P | 02:07 |
ankur-gupta-f4 | No just rmred u commented on patch | 02:08 |
ankur-gupta-f4 | N saw u wave | 02:08 |
reedip | :D | 02:09 |
openstackgerrit | Sean McCully proposed openstack/keystoneauth master: KeystoneAuth should default to system CAFile. https://review.openstack.org/452585 | 02:21 |
*** amotoki has joined #openstack-sdks | 02:39 | |
*** gouthamr has quit IRC | 02:41 | |
*** dave-mccowan has joined #openstack-sdks | 02:55 | |
*** dave-mcc_ has quit IRC | 02:57 | |
*** john-davidge has joined #openstack-sdks | 02:58 | |
*** amotoki has quit IRC | 03:00 | |
*** john-davidge has quit IRC | 03:03 | |
*** dave-mccowan has quit IRC | 03:05 | |
openstackgerrit | Sean McCully proposed openstack/keystoneauth master: KeystoneAuth should default to system CAFile. https://review.openstack.org/452585 | 03:10 |
*** amotoki has joined #openstack-sdks | 03:20 | |
*** amotoki has quit IRC | 03:29 | |
*** amotoki has joined #openstack-sdks | 03:38 | |
*** reedip has quit IRC | 03:52 | |
*** reedip has joined #openstack-sdks | 04:00 | |
*** Dinesh_Bhor has joined #openstack-sdks | 04:01 | |
*** amotoki has quit IRC | 04:01 | |
*** amotoki has joined #openstack-sdks | 04:08 | |
*** annp has joined #openstack-sdks | 04:28 | |
openstackgerrit | Sean McCully proposed openstack/keystoneauth master: KeystoneAuth should default to system CAFile. https://review.openstack.org/452585 | 05:06 |
*** hoangcx has quit IRC | 05:28 | |
*** e0ne has joined #openstack-sdks | 05:45 | |
*** e0ne has quit IRC | 05:52 | |
*** adriant has quit IRC | 05:55 | |
*** IRCFrEAK has joined #openstack-sdks | 05:57 | |
*** IRCFrEAK has left #openstack-sdks | 06:00 | |
*** yuanying has quit IRC | 06:07 | |
*** yuanying_ has joined #openstack-sdks | 06:13 | |
*** e0ne has joined #openstack-sdks | 06:23 | |
*** e0ne has quit IRC | 06:24 | |
openstackgerrit | Sean McCully proposed openstack/keystoneauth master: KeystoneAuth should default to system CAFile. https://review.openstack.org/452585 | 06:26 |
openstackgerrit | Reedip proposed openstack/python-openstackclient master: Add extra dhcp option to 'port create/set/unset' https://review.openstack.org/356263 | 06:31 |
*** bobh has joined #openstack-sdks | 06:37 | |
*** bobh has quit IRC | 06:42 | |
*** ralonsoh has joined #openstack-sdks | 06:43 | |
reedip | RuiChen : I updated the Floating IP Patch, awaiting your review :) | 06:48 |
*** Cagelin has joined #openstack-sdks | 06:57 | |
*** Cagelin has quit IRC | 07:04 | |
*** Serlex has joined #openstack-sdks | 07:29 | |
*** amotoki_ has joined #openstack-sdks | 07:41 | |
*** prg3 has quit IRC | 07:42 | |
*** prg3 has joined #openstack-sdks | 07:43 | |
*** amotoki has quit IRC | 07:44 | |
*** fzdarsky has joined #openstack-sdks | 07:50 | |
*** jpich has joined #openstack-sdks | 08:00 | |
*** openstackgerrit has quit IRC | 08:03 | |
*** e0ne has joined #openstack-sdks | 08:08 | |
*** reedip has quit IRC | 08:28 | |
*** bobh has joined #openstack-sdks | 08:38 | |
*** bobh has quit IRC | 08:43 | |
*** john-davidge has joined #openstack-sdks | 08:51 | |
*** ssbarnea has joined #openstack-sdks | 08:51 | |
*** reedip has joined #openstack-sdks | 09:08 | |
*** openstackgerrit has joined #openstack-sdks | 09:12 | |
openstackgerrit | Samriddhi proposed openstack/keystoneauth master: Updated inconsistent value of scope parameter https://review.openstack.org/452652 | 09:13 |
*** cdent has joined #openstack-sdks | 09:14 | |
*** amotoki_ has quit IRC | 09:25 | |
ZZelle_ | ok | 10:03 |
*** annp has quit IRC | 10:22 | |
*** sdague has joined #openstack-sdks | 10:23 | |
reedip | RuiChen : there? | 10:31 |
*** john-davidge has quit IRC | 10:46 | |
openstackgerrit | Reedip proposed openstack/python-openstackclient master: Add extra dhcp option to 'port create/set/unset' https://review.openstack.org/356263 | 10:57 |
*** jkilpatr has joined #openstack-sdks | 11:01 | |
openstackgerrit | Cedric Brandily proposed openstack/osc-lib master: Avoid to authenticate twice https://review.openstack.org/452711 | 11:06 |
*** john-davidge has joined #openstack-sdks | 11:22 | |
openstackgerrit | Jens Rosenboom proposed openstack/python-openstackclient master: Fix block-device-mapping when volume_size is empty https://review.openstack.org/451432 | 11:26 |
*** john-davidge has quit IRC | 11:27 | |
*** thingee has quit IRC | 11:36 | |
*** bobh has joined #openstack-sdks | 11:37 | |
*** dhellmann has quit IRC | 11:42 | |
*** dhellmann has joined #openstack-sdks | 11:42 | |
*** thingee has joined #openstack-sdks | 11:49 | |
*** elmiko_ is now known as elmiko | 12:19 | |
*** gouthamr has joined #openstack-sdks | 12:21 | |
*** ssbarnea has quit IRC | 12:23 | |
*** thingee has quit IRC | 12:27 | |
*** bobh has quit IRC | 12:27 | |
reedip | ankur-gupta-f4 : woke up ? | 12:29 |
*** ssbarnea has joined #openstack-sdks | 12:29 | |
reedip | sindhu : there ? | 12:29 |
*** thingee has joined #openstack-sdks | 12:44 | |
*** edleafe- is now known as edleafe | 12:51 | |
openstackgerrit | Dirk Mueller proposed openstack/cliff master: .gitignore: Ignore eggs https://review.openstack.org/449740 | 12:53 |
openstackgerrit | Reedip proposed openstack/python-openstackclient master: Add extra dhcp option to 'port create/set/unset' https://review.openstack.org/356263 | 13:02 |
*** john-davidge has joined #openstack-sdks | 13:06 | |
*** john-davidge has quit IRC | 13:11 | |
*** cleong has joined #openstack-sdks | 13:11 | |
*** thingee has quit IRC | 13:23 | |
*** dhellmann has quit IRC | 13:24 | |
*** thingee has joined #openstack-sdks | 13:25 | |
*** dhellmann has joined #openstack-sdks | 13:25 | |
*** fzdarsky has quit IRC | 13:43 | |
*** fzdarsky has joined #openstack-sdks | 13:51 | |
*** hongbin has joined #openstack-sdks | 13:53 | |
*** jkilpatr has quit IRC | 14:02 | |
*** bobh has joined #openstack-sdks | 14:03 | |
*** amotoki has joined #openstack-sdks | 14:05 | |
*** reedip has quit IRC | 14:13 | |
*** amotoki has quit IRC | 14:25 | |
*** reedip has joined #openstack-sdks | 14:26 | |
*** bobh has quit IRC | 14:30 | |
sindhu | reedip: hey wass up | 14:37 |
reedip | hey hi , small issue with unicode in the functional test of https://review.openstack.org/356263 | 14:38 |
reedip | sindhu : the unset command fails to find the dict in the list of dicts in https://review.openstack.org/#/c/356263/23/openstackclient/network/v2/port.py L#987 | 14:40 |
reedip | cant think straight as of now, if you have some time to day, would be great if you can tell me how to ignore the unicodes | 14:41 |
reedip | unicode mismatch is the only issue, the items are in the correct value | 14:41 |
sindhu | reedip: cool, will look into it today :) | 14:42 |
reedip | gr8 thanks :) | 14:42 |
*** chlong has joined #openstack-sdks | 14:45 | |
*** ZZelle_ has quit IRC | 14:46 | |
*** bobh has joined #openstack-sdks | 14:56 | |
ankur-gupta-f4 | reedip: good evening | 14:58 |
*** amotoki has joined #openstack-sdks | 14:59 | |
*** corey__ has joined #openstack-sdks | 15:05 | |
reedip | ankur-gupta-f4 : hello | 15:05 |
*** cleong has quit IRC | 15:05 | |
*** john-davidge has joined #openstack-sdks | 15:07 | |
*** john-davidge has quit IRC | 15:12 | |
*** dave-mccowan has joined #openstack-sdks | 15:21 | |
openstackgerrit | Reedip proposed openstack/python-openstackclient master: Add extra dhcp option to 'port create/set/unset' https://review.openstack.org/356263 | 15:23 |
reedip | sindhu : also need to get this merged so that the floating IP merges https://review.openstack.org/447938 | 15:23 |
*** Serlex has quit IRC | 15:24 | |
sindhu | reedip: yes, the change in SDK won't help us now like u mentioned | 15:25 |
reedip | yeah , so thats why want this to be merged so that the floating ip change merges soon | 15:25 |
sindhu | yeah, I agree :) | 15:27 |
*** annegentle has joined #openstack-sdks | 15:28 | |
*** amotoki has quit IRC | 15:39 | |
openstackgerrit | Stephen Finucane proposed openstack/cliff master: WIP: Add 'cliff' Sphinx directive https://review.openstack.org/450322 | 15:44 |
*** stevelle has left #openstack-sdks | 15:52 | |
*** e0ne has quit IRC | 15:57 | |
openstackgerrit | Ed Leafe proposed openstack/api-wg master: Recommend the correct HTTP method for tags https://review.openstack.org/451536 | 16:02 |
*** cdent has quit IRC | 16:11 | |
openstackgerrit | Merged openstack/cliff master: .gitignore: Ignore eggs https://review.openstack.org/449740 | 16:17 |
*** jkilpatr has joined #openstack-sdks | 16:18 | |
*** d0ugal has quit IRC | 16:19 | |
openstackgerrit | Stephen Finucane proposed openstack/cliff master: Add 'cliff-command' Sphinx directive https://review.openstack.org/450322 | 16:23 |
*** jpich has quit IRC | 16:24 | |
openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Add help commands withouth auth in functional https://review.openstack.org/452407 | 16:31 |
openstackgerrit | Merged openstack/os-client-config master: Docs: add a note about rackspace API keys https://review.openstack.org/451563 | 16:46 |
openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: Introduce L7Rule for Octavia (load balancing) https://review.openstack.org/452832 | 16:47 |
openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: Introduce L7Rule for Octavia (load balancing) https://review.openstack.org/452832 | 16:53 |
*** annegentle has quit IRC | 16:53 | |
*** e0ne has joined #openstack-sdks | 16:55 | |
*** aarefiev_afk is now known as aarefiev | 16:56 | |
openstackgerrit | Shashank Kumar Shankar proposed openstack/python-openstackclient master: Introduce neutron flavor associate, disassociate to OSC https://review.openstack.org/403907 | 17:02 |
*** jkilpatr has quit IRC | 17:05 | |
*** chlong has quit IRC | 17:05 | |
openstackgerrit | Ankur proposed openstack/python-openstacksdk master: Introduce Base for Octavia (load balancing) https://review.openstack.org/428414 | 17:06 |
openstackgerrit | Stephen Finucane proposed openstack/cliff master: Add 'cliff-command' Sphinx directive https://review.openstack.org/450322 | 17:06 |
*** john-davidge has joined #openstack-sdks | 17:08 | |
openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: WIP! Start using 'cliff.sphinxext' https://review.openstack.org/452861 | 17:12 |
*** john-davidge has quit IRC | 17:13 | |
*** d0ugal has joined #openstack-sdks | 17:15 | |
*** chlong has joined #openstack-sdks | 17:20 | |
*** cdent has joined #openstack-sdks | 17:23 | |
cdent | edleafe, elmiko : I'm cogitating on how to provide a final revision on https://review.openstack.org/#/c/421846/ (compatibility guidelines). I think I may do what I say in my last comment about "one tactic". Any thoughts? | 17:25 |
openstackgerrit | Ankur proposed openstack/python-openstackclient master: Network L3 Router Commands for OSC https://review.openstack.org/385729 | 17:25 |
edleafe | cdent: I thought the motivation for this *was* the TC tag | 17:29 |
cdent | the motivation was that they wanted to use the guidelines and they seemed bad | 17:29 |
cdent | but now that they are revised we should revise them so they are not about tags, but about the bigger thing, the mission | 17:30 |
cdent | thus my statement: interoperability right there in the mission | 17:30 |
cdent | if we guide to the mission, the relevancy for tags (or new tags) falls out of that, but the tags will be mission oriented, not "make some tags to deal with whatever situation is lying around" | 17:31 |
edleafe | I get that, but it seems like looking at it as a single concern will make it essentially useless for the vast majority of OpenStack developers | 17:34 |
edleafe | Really, I joke and call it the "Monty case", but I don't know anyone else who has such stringent requirements | 17:34 |
cdent | that's kind of the point: are we trying to describe interop or not? I felt that the outcome from a) the ptg, b) the discussion on the document and c) look at TheMission is that we are. If we are, then the implications are _severe_ | 17:35 |
cdent | and thus the document needs to be pretty explicit about just how difficult things are, and the things to look out for | 17:35 |
elmiko | i'm having a difficult time following the action item here, are we still trying to figure how to mention alternatives without blessing them?> | 17:37 |
cdent | elmiko: no, more general than that: get something published that is actionable | 17:37 |
elmiko | cdent: ok, cool. i thought we were in the weeds about that. | 17:38 |
cdent | ed pointed out a few more contradictions and issues in his comments shortly before my last one | 17:38 |
edleafe | I felt that the PTG was really a non-outcome, because we didn't have the two factions talking with each other | 17:38 |
elmiko | i agree with the sentiment that using these guidelines as the bar for a tag is problematic at best | 17:38 |
edleafe | elmiko: so how would the TC determine if a project has earned that tag? | 17:39 |
elmiko | edleafe: i guess it depends a little on the conversation here | 17:39 |
elmiko | like for example | 17:39 |
cdent | edleafe: I don't quite agree (about PTG). I think we established that there were some people who did not want to prioritize service wide interoperability and stability and that's okay, but that if you do, there are consequences | 17:40 |
elmiko | if the guidelines are about the mission and interop, then maybe we need a document that clearly defines what you need for the tag (ugh, more docs) | 17:40 |
elmiko | but, if the guidelines *are* about the tag, then we need to be more explicit i suppose | 17:40 |
elmiko | i have to admit, i feel we have gotten so far zoomed in as a result of one issue that i'm having trouble placing all this into the "bigger picture" as stated above | 17:41 |
edleafe | cdent: hence my blog post. The morning group was concerned with moving an API forward without breaking clients. They really showed no concern for interop at the level that Monty et al did in the afternoon | 17:41 |
cdent | edleafe: hence my suggestion of renaming this document to interoperability guidelines and being able to publish that as a step in a potentially multi-step process | 17:42 |
cdent | (elmiko, yes, it's hard to tell where to focus) | 17:42 |
elmiko | cdent: that seems like a sensible option to me | 17:43 |
edleafe | cdent: So this would be an "api-interoperability" guiddeline, and there would be another, similar "api-compatibility" guideline? Or just the former and forget about the latter? | 17:43 |
cdent | do the former, and if there is demand and/or time do the latter | 17:44 |
cdent | i'm not sure if there is demand for the latter, but there was clearly demand for the former because people we're wielding the older (incomplete) guideline as a weapon | 17:45 |
elmiko | ouch | 17:45 |
cdent | were | 17:46 |
edleafe | I think that the latter would be more widely useful OpenStack-wide in improving APIs | 17:46 |
cdent | because I know edleafe is watching out for such things | 17:46 |
elmiko | it's starting to sound like the tag should really be "api-interop" focused then? | 17:46 |
elmiko | edleafe: ++ | 17:46 |
edleafe | cdent: I let that one slide | 17:46 |
edleafe | Not many projects will implement microversions and be as strict about them as interop requires | 17:47 |
cdent | edleafe: how do you react to the assertion that forward stability/compatibility is impossible in the kind of environment that openstack projects exist in? | 17:47 |
cdent | or the other assertion, held by some, that if you're not concerning yourself with interop you shouldn't be openstack? | 17:47 |
edleafe | But I can see many projects improving their versioning (*cough* glance *cough*) to at least not break clients | 17:47 |
elmiko | lol | 17:48 |
cdent | how did microversions leak in here? | 17:48 |
edleafe | Impossible? No | 17:48 |
edleafe | Difficult? Sure | 17:48 |
edleafe | cdent: because we determined that no one knew of any versioning system that could meet the demands of interop besides microversions | 17:49 |
cdent | (is proxying assertions to cover bases, I've completely lost touch with my own position on this stuff) | 17:49 |
edleafe | And thus demanding interop means demanding microversions | 17:49 |
elmiko | cdent: i can totally empathize | 17:49 |
cdent | if glance improved their versioning, even if they didn't use microversions™ they would still be microversions if they were selectable in some fashion | 17:50 |
*** jamielennox is now known as jamielennox|away | 17:50 | |
cdent | if you are doing some kind of versioning | 17:51 |
edleafe | They could adopt semver | 17:51 |
edleafe | (and stick to it!) | 17:51 |
sdague | edleafe: that's actually a pretty accurate replay of what happened, we invented this thing because all the existing strategies broke down when you were talking about multiple deployments that were upgrading at independent schedules | 17:51 |
cdent | and you can choose what version you want at request time (by uri, or header, content type) then you have the equivalent functionality of microversioning, and thus you have interop | 17:51 |
sdague | edleafe: I really don't think semver is meaningful for network based services | 17:52 |
sdague | because semver is what you use in libraries to know what you can safely upgrade to, and what you just vendor. But you can't vendor a network api. :) | 17:52 |
cdent | brb | 17:52 |
edleafe | sdague: the point was that there are other ways to sanely version your API other than microversions | 17:53 |
dtroyer | besides, semver is hard enough to get right that consumers can't always trust it anyway… which is why I've come to the conclusion that I don't care _what_ you use to signal a change, just make it have an order (because ranges) and discoverable | 17:54 |
edleafe | Some projects have a visceral reaction to even thinking of microversions | 17:54 |
edleafe | I don't understand that, but it's there | 17:54 |
dtroyer | because anti-Nova sentiment? | 17:54 |
edleafe | dtroyer: that's part of it | 17:55 |
edleafe | but also because it's perceived as this huge amount of overhead | 17:55 |
cdent | it's perceived as a way to keep tech debt in both client libraries and servers | 17:55 |
dtroyer | heh, the overhead is thinking about the consumers of your API rathern than just treating it as write-only | 17:55 |
cdent | for some that's a valid cost, for the sake of the user, for others not so much | 17:56 |
cdent | round-about-jinx | 17:56 |
edleafe | sdague summarized the users well in https://review.openstack.org/#/c/444892/2/guidelines/microversions-architecture.rst | 17:57 |
edleafe | It's hard to satisfy all those use cases | 17:58 |
sdague | yeh, I need to get back to that document | 17:58 |
sdague | edleafe: right, well, it is why we ended up with the microversion solution | 17:58 |
sdague | that was our set of constraints | 17:58 |
sdague | solve for X | 17:58 |
elmiko | edleafe: i think there is another angle to avoiding microversions. for teams that are stretched or have hard downstream asks, it can be a tough load of tech debt to take on. | 17:59 |
*** d0ugal has quit IRC | 17:59 | |
cdent | if the current document didn't have a) any mention of microversions, b) the alternatives section what would it mean or imply for people? Would it serve a useful purpose? | 17:59 |
edleafe | elmiko: can you explain what the tech debt is that is taken on? | 17:59 |
cdent | it's not even debt, it's work | 18:00 |
*** aarefiev is now known as aarefiev_afk | 18:00 | |
elmiko | edleafe: so, imo, initially someone has to implement the handling of the microversion into the wsgi framework. additionally that knowledge needs to be communicated in a manner that will live on if the implementor disappears. | 18:00 |
sdague | cdent: what I heard in the room, it was the debt that people were concerned about. They didn't want to maintain old behaviors. | 18:00 |
*** ZZelle has joined #openstack-sdks | 18:01 | |
elmiko | after it's implemented, then there is the function of keeping the older pathways working while new bits are added | 18:01 |
cdent | sdague: yeah, but that's not what elmiko is talking about here | 18:01 |
sdague | right | 18:01 |
ZZelle | dtroyer, hi | 18:01 |
cdent | s/here/at first/ | 18:01 |
sdague | cdent: ok | 18:01 |
edleafe | elmiko: yeah, I get the initial workload to make the change, but really, any change requires work | 18:01 |
elmiko | as the old paths start to rot, i've experienced a brain-drain in the area of keeping them alive when bugs do creep in *or* if there needs to changes to the overall model of the application in question. | 18:01 |
elmiko | edleafe: agreed, i'm just airing my perceived drawbacks to a smaller team | 18:02 |
elmiko | my largest experience is with sahara | 18:02 |
edleafe | So for a project that wants to maintain compatibility, they have to maintain the old behaviors in any event | 18:02 |
sdague | elmiko: yeh, that's definitely a concern. But the real world implications of that are that a service is just going to stop working for existing clients. | 18:02 |
sdague | which, makes it a hard choice for people to choose to deploy and count on | 18:03 |
elmiko | sdague: agreed | 18:03 |
elmiko | bare in mind that i'm mainly talking about projects that may not be hot-beds of openstack activity. (for example sahara) | 18:03 |
edleafe | elmiko: re: bitrot - yeah, agreed. That's why I don't subscribe to the "once an API is released, you have to maintain it forever" school of thought | 18:03 |
edleafe | elmiko: see: https://blog.leafe.com/api-longevity/ | 18:04 |
*** ssbarnea has quit IRC | 18:04 | |
sdague | edleafe: it mostly depends on who has control over the deployment | 18:04 |
sdague | so... if sahara wasn't a thing the cloud operator deployed, but a thing that I deployed in my tenant | 18:04 |
elmiko | if my, downstream, employer has hot demands on what goals they would like to see for a particular cycle, it can extremely difficult to get traction for spending signifcant time doing a microversion re-write | 18:04 |
sdague | then I've got control on the upgrade cycle | 18:04 |
sdague | which makes it like vendored libraries | 18:04 |
sdague | and, then I think some of these concerns go away | 18:05 |
elmiko | sdague: totally agree | 18:05 |
*** ssbarnea has joined #openstack-sdks | 18:05 | |
elmiko | in-tenant services is a fantastic idea | 18:05 |
sdague | but when the user has no control of the upgrade schedule | 18:05 |
sdague | ... I have a hard time understanding a different path then the one we've taken | 18:06 |
elmiko | i feel like this is an area where, due to no ones fault, there are "services" that are embedded into the control plane which would be better served as application riding on top of openshift | 18:06 |
elmiko | er, openstack | 18:06 |
elmiko | sorry.. too many open* | 18:06 |
cdent | elmiko bleeds red | 18:06 |
sdague | heh | 18:06 |
elmiko | FOR THE HAT!!!! | 18:07 |
edleafe | sdague: I'm totally agreed on the microversion approach that nova has followed | 18:07 |
sdague | elmiko: yeh, that would have been an interesting different road to have taken | 18:07 |
* cdent gives elmiko the jokeexplainer award of the day, along with a bandaid | 18:07 | |
elmiko | honestly though, i've doing way more with kubernetes recently and the model of deploying "heroic" services on top the orchestration substrate is a powerful idea | 18:07 |
edleafe | sdague: but I'm trying to find a middle ground to help improve all OpenStack APIs, even for those projects that reject microversions | 18:07 |
elmiko | sdague: ack, c'est la vie ;) | 18:08 |
sdague | elmiko: I do kind of wonder if zaneb's ideas around application tokens might get us back headed towards that path | 18:08 |
elmiko | sdague: i have not seen that written up, but it sounds interesting | 18:08 |
cdent | elmiko: https://review.openstack.org/#/c/447031/ | 18:09 |
elmiko | cdent++ | 18:09 |
sdague | edleafe: sure, I applaud that effort. However, I also feel like we've got a set of services where this matches well, and it would be nice to get that flag in the ground. | 18:09 |
cdent | (in the links in the bottom) | 18:09 |
*** dhellmann has quit IRC | 18:10 | |
dtroyer | ZZelle: hey | 18:10 |
elmiko | i totally agree with the thought that for certain "core" services, mandating microversions is a much stronger idea. but that takes us away from the big tent idea | 18:11 |
*** dhellmann has joined #openstack-sdks | 18:11 | |
* edleafe runs to the kitchen to grab some lunch | 18:11 | |
cdent | (I'm going to need to go at any moment now, I think, if there's a concrete outcome to this conversation that is germane to the doc, can somebody leave a new comment there so I can act on it?) | 18:12 |
elmiko | cdent: ack | 18:12 |
cdent | thanks | 18:12 |
ZZelle | dtroyer, about your comment in https://review.openstack.org/#/c/452328/1/doc/source/command-objects/server.rst | 18:12 |
ZZelle | dtroyer, i am not sure to understand what you mean | 18:12 |
*** ssbarnea has quit IRC | 18:12 | |
cdent | I think being more specific about the scope of the doc and the rigor of the standard being set is probably a good way to go, especially if we leave open the option (we always do) for more docs later | 18:13 |
cdent | That moves the doc forward | 18:13 |
cdent | but I don't know that that helps us with what might be called the social problem. | 18:13 |
cdent | but it may be we don't need to do anything about that | 18:13 |
dtroyer | its just the form of the help line, we put the '(name or ID)' test at the end pretty much everywhere, except some differences have snuck in. Fix yours, I'll get the other ones | 18:14 |
dtroyer | there's an RST error in there too that stevemar noted but +2'd anyway | 18:14 |
ZZelle | dtroyer, so something like 'Server ... (name or ID).' instead of 'Server (name or ID) ...'? | 18:14 |
stevemar | ZZelle: yep | 18:15 |
ZZelle | stevemar, dtroyer good for me | 18:15 |
dtroyer | yes. look at nearly every other command in that file than the add commands near yours | 18:15 |
elmiko | cdent: imo, for a guideline that will define a tag, it should be as explicit as possible in terms of the hoops needed to jump through | 18:15 |
elmiko | so, that may speak to having 2 separate docs | 18:15 |
*** prg3 has quit IRC | 18:15 | |
cdent | I remain a bit unclear on what the second doc is | 18:17 |
*** prg3 has joined #openstack-sdks | 18:17 | |
elmiko | i guess that would be needed if we couldn't make the first one specific enough? | 18:18 |
elmiko | or just having 2 tags or something, one for interop and one for ? | 18:19 |
cdent | yes, that blank is what I'm blank on | 18:19 |
openstackgerrit | Cedric Brandily proposed openstack/python-openstackclient master: Enable to add/remove port to/from a server https://review.openstack.org/452328 | 18:19 |
ZZelle | stevemar, dtroyer ^^ | 18:19 |
*** d0ugal has joined #openstack-sdks | 18:20 | |
elmiko | cdent: yeah, sadly, i have no better answers here =( | 18:21 |
dtroyer | ZZelle: thanks | 18:22 |
cdent | elmiko: no worries. if/when edleafe comes back he may have something, I gotta run to dinner, thanks for the input, we'll figure something out. | 18:22 |
elmiko | cdent: cool, enjoy o/ | 18:22 |
*** cdent has quit IRC | 18:22 | |
*** ralonsoh has quit IRC | 18:23 | |
stevemar | ZZelle: ohhh are you cedric? | 18:23 |
*** annegentle has joined #openstack-sdks | 18:24 | |
sshank | dtroyer, I think https://review.openstack.org/#/c/403907/ (flavor associate, dissociate) is ready for reviews. | 18:27 |
openstackgerrit | Ankur proposed openstack/python-openstacksdk master: Introduce Base for Octavia (load balancing) https://review.openstack.org/428414 | 18:28 |
*** ssbarnea has joined #openstack-sdks | 18:28 | |
*** e0ne has quit IRC | 18:28 | |
openstackgerrit | Ankur proposed openstack/python-openstackclient master: Network L3 Router Commands for OSC https://review.openstack.org/385729 | 18:32 |
*** ssbarnea has quit IRC | 18:33 | |
dtroyer | ankur-gupta-f1: re https://review.openstack.org/#/c/449757/, why are you filtering the show output? we've removed specific fields before, I don't understand why you are treating this one like a list command | 18:39 |
*** john-davidge has joined #openstack-sdks | 18:50 | |
*** prg3 has quit IRC | 18:53 | |
*** prg3 has joined #openstack-sdks | 18:55 | |
*** john-davidge has quit IRC | 18:55 | |
openstackgerrit | Merged openstack/python-openstackclient master: Add help commands withouth auth in functional https://review.openstack.org/452407 | 18:55 |
ankur-gupta-f4 | dtroyer: based on the api response. Since the advanced commands hit different endpoints that the normal list commands | 19:01 |
ankur-gupta-f4 | I can go back thru them do verify if you want | 19:02 |
dtroyer | what happened to advanced commands going into plugins? | 19:03 |
ankur-gupta-f4 | Because its not advanced in the sense that certain features have to be enabled to use the commands. Its just a complex endpoint | 19:04 |
dtroyer | right, that's what I thought made it different. 'advanced services' has a specific meaning in neutron | 19:05 |
ankur-gupta-f4 | Yea. Will reword it. Sorry for confusion | 19:05 |
ZZelle | stevemar, yes i am | 19:06 |
dtroyer | but that doesn't change a) different endpoint and b) the same resource isn't represented by the same fields? | 19:06 |
dtroyer | what endpoint is it? | 19:06 |
ankur-gupta-f4 | i.e. for routers for the list command it hits /v2.0/routers for the list routers --agent <agent-id> it hits /v2.0/routers/<router-id>/l3-agents i believe | 19:07 |
dtroyer | ok, again, endpoint has a specific meaning: service catalog thing | 19:07 |
dtroyer | that's a route in wsgi terms | 19:07 |
ankur-gupta-f4 | okay. route. | 19:07 |
dtroyer | so much overloading of words! | 19:07 |
dtroyer | so the server returns a different object in that case? | 19:08 |
ankur-gupta-f4 | correct | 19:08 |
dtroyer | and the SDK doesn't fill it out? this is one place I'd expect the SDK's high-level-ness to step in and make things look right | 19:08 |
ankur-gupta-f4 | https://github.com/openstack/python-openstacksdk/blob/master/openstack/network/v2/router.py#L134 is how the route is determined in the SDK | 19:08 |
dtroyer | we should just start issuing random 3 letter names for all of these different things | 19:09 |
ankur-gupta-f4 | route, complex command, idiotic API.. should suffice | 19:10 |
dtroyer | so, back to the issue at hand, is —router a filter or a type specifier? | 19:11 |
ankur-gupta-f4 | not a filter in the sense that it filters the resulting data from hitting the common list route. rather a flag to indicate that instead of hitting the usual list route, to hit the specific route that would return a different routers list object from the API. | 19:13 |
dtroyer | ok, the problem is that the columns are different | 19:15 |
dtroyer | in your examples the router ID is the same so it is that the server returns a different object, except it is still the same router at each endpoint? | 19:16 |
ankur-gupta-f4 | yes | 19:17 |
ankur-gupta-f4 | well.. | 19:17 |
ankur-gupta-f4 | the example I posted, the paste.openstack.org link, was just to show that the commands are still listing the correct items | 19:19 |
dtroyer | so I clearly still don't understand wtf neutron is doing here. If I were to say: make a router list command always show the same columns, eept for -c and —long, what would you suggest? | 19:20 |
ankur-gupta-f4 | I just ran the commands in --debug to look at the dicts. | 19:21 |
openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: Introduce Listener for Octavia (load balancing) https://review.openstack.org/451574 | 19:21 |
ankur-gupta-f4 | It should be possible to have all the list commands return the same values. | 19:22 |
ankur-gupta-f4 | what we can do is have all the list commands have the same columns. | 19:23 |
ankur-gupta-f4 | then if the certain agent flag is given | 19:23 |
ankur-gupta-f4 | append the additional columns | 19:23 |
*** d0ugal has quit IRC | 19:23 | |
dtroyer | that would be good. if we need additional options to select specic column similar to —long, we can talk about that… say for a common use case | 19:24 |
*** d0ugal has joined #openstack-sdks | 19:25 | |
ankur-gupta-f4 | dtroyer: thanks. Headed to airport now. Will deal with all that shit Wednesday | 19:26 |
dtroyer | ok, thanks | 19:26 |
ankur-gupta-f4 | sshank: here? you will need to update your DHCP-network commands to reflect ^^^^^^ | 19:27 |
sshank | ankur-gupta-f4, Yes. I'll need to read through the logs. | 19:27 |
*** bobh has quit IRC | 19:29 | |
ankur-gupta-f4 | basically have the list commands use the common columns from the base list case. and do like a columns = columns + (whatever additional your specific list command adds on (like ha)) column_headers = column_headers + (whatever) | 19:30 |
openstackgerrit | Ankur proposed openstack/python-openstacksdk master: Introduce Base for Octavia (load balancing) https://review.openstack.org/428414 | 19:33 |
*** d0ugal has quit IRC | 19:36 | |
*** chlong has quit IRC | 19:37 | |
openstackgerrit | Shashank Kumar Shankar proposed openstack/python-openstacksdk master: Introduce Pool for Octavia (load balancing) https://review.openstack.org/449264 | 19:47 |
openstackgerrit | Merged openstack/python-openstackclient master: Fix block-device-mapping when volume_size is empty https://review.openstack.org/451432 | 19:49 |
*** chlong has joined #openstack-sdks | 19:51 | |
*** john-davidge has joined #openstack-sdks | 19:51 | |
*** john-davidge has quit IRC | 19:55 | |
*** jamielennox|away is now known as jamielennox | 20:05 | |
dtroyer | stevemar: if you can spare a minute have a look at https://review.openstack.org/#/c/450453/, it's finally passing everything and fixes our -tips jobs | 20:05 |
stevemar | ++ | 20:06 |
*** e0ne has joined #openstack-sdks | 20:08 | |
*** e0ne has quit IRC | 20:09 | |
*** e0ne has joined #openstack-sdks | 20:10 | |
dtroyer | thanks | 20:10 |
*** jkilpatr has joined #openstack-sdks | 20:25 | |
*** e0ne has quit IRC | 20:28 | |
stevemar | dtroyer: want me to push it through or wait til osc-lib is released? | 20:28 |
dtroyer | this is all for master, go ahead | 20:30 |
dtroyer | I'm working on releases, hopefully this week as I'm limited availability next week | 20:30 |
openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: Introduce Base for Octavia (load balancing) https://review.openstack.org/428414 | 20:48 |
openstackgerrit | Merged openstack/python-openstackclient master: Enable to add/remove port to/from a server https://review.openstack.org/452328 | 20:51 |
*** prg3 has quit IRC | 20:52 | |
*** annegentle has quit IRC | 20:52 | |
*** hoangcx has joined #openstack-sdks | 20:55 | |
*** corey__ has quit IRC | 20:56 | |
*** prg3 has joined #openstack-sdks | 20:58 | |
*** d0ugal has joined #openstack-sdks | 21:01 | |
openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: Introduce Listener for Octavia (load balancing) https://review.openstack.org/451574 | 21:09 |
openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: Introduce Listener for Octavia (load balancing) https://review.openstack.org/451574 | 21:10 |
openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: Introduce Listener for Octavia (load balancing) https://review.openstack.org/451574 | 21:11 |
*** annegentle has joined #openstack-sdks | 21:15 | |
openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Help/docs cleanups: marker, limit, ip-address metavars https://review.openstack.org/452961 | 21:23 |
*** gouthamr has quit IRC | 21:24 | |
openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Release notes cleanup for 3.10.0 release https://review.openstack.org/452965 | 21:32 |
*** reedip has quit IRC | 21:35 | |
dtroyer | jamielennox: when you get a sec have a look at https://review.openstack.org/#/c/452711/ and tell me "I told you that long ago" if this is what I think it is :) | 21:38 |
*** prg3 has quit IRC | 21:49 | |
openstackgerrit | Merged openstack/python-openstackclient master: Change noauth strategy for plugin loading https://review.openstack.org/450453 | 21:50 |
*** prg3 has joined #openstack-sdks | 21:54 | |
*** ssbarnea has joined #openstack-sdks | 22:05 | |
*** ZZelle has quit IRC | 22:15 | |
openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: Introduce Base for Octavia (load balancing) https://review.openstack.org/428414 | 22:16 |
*** chlong has quit IRC | 22:38 | |
*** sdague has quit IRC | 22:57 | |
*** adriant has joined #openstack-sdks | 23:01 | |
*** annegentle has quit IRC | 23:03 | |
jamielennox | dtroyer: i was going to push this up but realized you weren't the author | 23:04 |
jamielennox | all you really need is: | 23:05 |
jamielennox | - if not self._auth_ref: | 23:05 |
jamielennox | - self.setup_auth() | 23:05 |
jamielennox | - LOG.debug("Get auth_ref") | 23:05 |
jamielennox | - self._auth_ref = self.auth.get_auth_ref(self.session) | 23:05 |
jamielennox | - return self._auth_ref | 23:05 |
jamielennox | + self.setup_auth() | 23:05 |
jamielennox | + return self.auth.get_access(session) | 23:05 |
jamielennox | get_access will mean it's reused if possible and there is already a guard that means setup_auth won't execute twice | 23:05 |
dtroyer | jamielennox: ok, thanks | 23:13 |
*** ssbarnea has quit IRC | 23:16 | |
*** prg3 has quit IRC | 23:21 | |
*** prg3 has joined #openstack-sdks | 23:24 | |
*** hoangcx has quit IRC | 23:35 | |
*** bobh has joined #openstack-sdks | 23:35 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!