mordred | jamielennox: ah- I see what you mean - so I'll try to make this extra complex ... | 00:00 |
---|---|---|
mordred | but first - I mostly have stopped caring about python-*client - but let's keep them for now because they make the discussion more interesting (harder) | 00:01 |
*** gildub has quit IRC | 00:02 | |
mordred | so - for the shade case, we have nodepool uses shade which uses os-client-config which uses keystoneauth which uses requests (at least that's how I think of it in my head) | 00:02 |
mordred | then for novaclient, it would be nodepool -> shade -> os-client-config -> novaclient -> keystoneauth ... or is it? | 00:04 |
mordred | maybe for the novaclient/glanceclient path the occ part is not meaningful | 00:04 |
jamielennox | sounds right | 00:04 |
mordred | in fact, I wonder if occ is important in the user agent at all? | 00:04 |
jamielennox | i think this is what dtroyer came to as well, telling people osc-lib version wasn't that important - but it's there if you want it | 00:05 |
mordred | it's setting up objects, but it's not really involved (atm) in making actual calls | 00:05 |
mordred | nod | 00:05 |
*** amotoki has quit IRC | 00:07 | |
mordred | jamielennox: so maybe focusing on interior ordering isn't important - nodepool "the app" being first in the list seems important, and ksa/requests being at the end seems right | 00:09 |
mordred | other than that, I can make all sorts of arguments about why one sequence makes more sense than the other | 00:09 |
mordred | but I'm not sure any of them actually make sense :) | 00:09 |
jamielennox | mordred: yea, it took us a while to get to the layout we have because of these sorts of things - you can get really picky about it | 00:09 |
mordred | ++ | 00:10 |
jamielennox | realistically the best thing to do would be to have the python clients actually insert their name into the sequence | 00:10 |
*** hongbin has quit IRC | 00:10 | |
mordred | yah. although hopefully 'soon' I won't be using them for anything anymore and that can be someone else's problem | 00:10 |
mordred | jamielennox: for the other patch - the main thing was that without adding client_name to session and only on adater, we lose it when ksa makes discovery calls on behalf of the user | 00:12 |
mordred | so I figured just setting it on session would be eaiser than plumbing client_name to wherever it needed to be for discovery calls | 00:12 |
mordred | but again, it's possible I'm making it too difficult :) | 00:12 |
jamielennox | oh, because discovery is internal to ksa? | 00:12 |
jamielennox | i mean we can plumb it through - but maybe it doesn't matter | 00:13 |
mordred | yah - and ksa doens't use an adapter for it | 00:13 |
jamielennox | things done internal to ksa don't care what invoked the request | 00:13 |
jamielennox | i mean it would be useful to know what client started the call | 00:13 |
jamielennox | mordred: i don't mean to argue this too much, but it's two new params in an already complicated list for fairly small benefit | 00:14 |
mordred | right - but when I think of user-agents I think of ops looking at logs to figure out why a particuar traffic pattern came in - and if it was shade that asked ksa for something, I feel like I'd be missing part of the story? | 00:14 |
mordred | _but_.... I don't have an actual use case | 00:14 |
mordred | jamielennox: totally understand - I appreciate you curating the library well :) | 00:15 |
jamielennox | mordred: is shade creating the session? | 00:15 |
jamielennox | oh right, this is why shade is out of order with the python-*client in additional | 00:16 |
mordred | yah | 00:16 |
mordred | actually - shade does not create the session - occ creates the session for it | 00:16 |
mordred | in general, it 'should' be occ creating session, adapater and/or python-client - but shade directly instantiates Adapter because it wraps it in a wrapper class | 00:18 |
mordred | and I gave up on giving occ a "set_adapter_factory" feature because that was just too much :) | 00:19 |
*** amotoki has joined #openstack-sdks | 00:20 | |
jamielennox | so i mean shade could add itself to additional at that point | 00:23 |
*** exploreshaifali has joined #openstack-sdks | 00:25 | |
mordred | jamielennox: hrm. maybe that's not a bad idea | 00:25 |
*** amotoki has quit IRC | 00:27 | |
*** john-davidge has joined #openstack-sdks | 00:30 | |
*** amotoki has joined #openstack-sdks | 00:33 | |
*** john-davidge has quit IRC | 00:35 | |
*** ediardo has quit IRC | 00:37 | |
*** hoangcx has joined #openstack-sdks | 00:39 | |
*** exploreshaifali has quit IRC | 00:40 | |
*** bobh has quit IRC | 00:45 | |
*** amotoki has quit IRC | 00:54 | |
*** amotoki has joined #openstack-sdks | 01:02 | |
*** jkilpatr has quit IRC | 01:11 | |
*** reedip_ has quit IRC | 01:13 | |
*** jkilpatr has joined #openstack-sdks | 01:14 | |
*** reedip_ has joined #openstack-sdks | 01:17 | |
*** shu-mutou-AWAY is now known as shu-mutou | 01:22 | |
*** reedip_ has quit IRC | 01:26 | |
*** reedip_ has joined #openstack-sdks | 01:29 | |
*** yanyanhu has joined #openstack-sdks | 01:33 | |
*** huanxuan has joined #openstack-sdks | 01:44 | |
*** gildub has joined #openstack-sdks | 01:51 | |
*** bobh has joined #openstack-sdks | 02:26 | |
*** john-davidge has joined #openstack-sdks | 02:27 | |
*** john-davidge has quit IRC | 02:31 | |
*** shu-mutou has quit IRC | 03:24 | |
*** john-davidge has joined #openstack-sdks | 03:28 | |
*** john-davidge has quit IRC | 03:32 | |
*** bobh has quit IRC | 03:48 | |
*** bobh has joined #openstack-sdks | 03:55 | |
*** bobh has quit IRC | 03:57 | |
*** jamielennox is now known as jamielennox|away | 04:01 | |
*** amotoki_ has joined #openstack-sdks | 04:08 | |
openstackgerrit | Rui Chen proposed openstack/python-openstackclient master: Make block-device-mapping more stable and clear https://review.openstack.org/438141 | 04:08 |
*** amotoki has quit IRC | 04:10 | |
*** shu-mutou has joined #openstack-sdks | 04:27 | |
*** john-davidge has joined #openstack-sdks | 04:28 | |
*** jamielennox|away is now known as jamielennox | 04:29 | |
*** john-davidge has quit IRC | 04:33 | |
*** reedip_ has quit IRC | 04:40 | |
*** bobh has joined #openstack-sdks | 04:58 | |
*** bobh has quit IRC | 05:03 | |
*** john-davidge has joined #openstack-sdks | 05:29 | |
*** john-davidge has quit IRC | 05:34 | |
*** yanyanhu has quit IRC | 05:46 | |
*** amotoki has joined #openstack-sdks | 05:46 | |
*** amotoki_ has quit IRC | 05:50 | |
*** yanyanhu has joined #openstack-sdks | 05:52 | |
*** bobh has joined #openstack-sdks | 05:59 | |
*** bobh has quit IRC | 06:04 | |
openstackgerrit | Rui Chen proposed openstack/cliff master: Add smart help formatter for command parser https://review.openstack.org/454613 | 06:19 |
*** john-davidge has joined #openstack-sdks | 06:30 | |
*** gildub has quit IRC | 06:35 | |
*** john-davidge has quit IRC | 06:35 | |
*** jamielennox is now known as jamielennox|away | 06:52 | |
*** adriant has quit IRC | 06:58 | |
*** bobh has joined #openstack-sdks | 07:00 | |
*** hoangcx has quit IRC | 07:01 | |
*** bobh has quit IRC | 07:04 | |
*** hoangcx has joined #openstack-sdks | 07:10 | |
*** jpich has joined #openstack-sdks | 07:28 | |
*** gildub has joined #openstack-sdks | 07:31 | |
openstackgerrit | Reedip proposed openstack/osc-lib master: Add MultiKeyValueCommaAction to osc-lib https://review.openstack.org/425515 | 07:39 |
reedip | RuiChen : Done ^^ | 07:39 |
*** yanyanhu has quit IRC | 07:40 | |
*** yanyanhu has joined #openstack-sdks | 07:40 | |
*** Serlex has joined #openstack-sdks | 07:48 | |
*** bobh has joined #openstack-sdks | 08:00 | |
*** hoangcx_ has joined #openstack-sdks | 08:03 | |
*** bobh has quit IRC | 08:05 | |
*** hoangcx has quit IRC | 08:06 | |
*** ralonsoh has joined #openstack-sdks | 08:06 | |
*** jkilpatr has quit IRC | 08:16 | |
*** jkilpatr has joined #openstack-sdks | 08:29 | |
*** ssbarnea has joined #openstack-sdks | 08:37 | |
*** e0ne has joined #openstack-sdks | 08:43 | |
*** john-davidge has joined #openstack-sdks | 08:44 | |
*** cdent has joined #openstack-sdks | 08:47 | |
-openstackstatus- NOTICE: zuul was restarted due to an unrecoverable disconnect from gerrit. If your change is missing a CI result and isn't listed in the pipelines on http://status.openstack.org/zuul/ , please recheck | 08:52 | |
*** aarefiev_afk is now known as aarefiev | 08:57 | |
*** bobh has joined #openstack-sdks | 09:01 | |
*** bobh has quit IRC | 09:06 | |
*** cdent has quit IRC | 09:07 | |
*** shu-mutou is now known as shu-mutou-AWAY | 09:28 | |
*** jkilpatr has quit IRC | 09:29 | |
*** jkilpatr has joined #openstack-sdks | 09:35 | |
*** cdent has joined #openstack-sdks | 09:50 | |
*** yanyanhu has quit IRC | 10:02 | |
*** bobh has joined #openstack-sdks | 10:02 | |
*** bobh has quit IRC | 10:07 | |
*** sdague has joined #openstack-sdks | 10:10 | |
*** hoangcx_ has quit IRC | 10:26 | |
*** gildub has quit IRC | 10:32 | |
*** jkilpatr has quit IRC | 10:43 | |
*** erlon has joined #openstack-sdks | 11:01 | |
*** bobh has joined #openstack-sdks | 11:03 | |
*** jkilpatr has joined #openstack-sdks | 11:03 | |
*** bobh has quit IRC | 11:07 | |
*** jamielennox|away is now known as jamielennox | 11:18 | |
*** bobh has joined #openstack-sdks | 11:21 | |
openstackgerrit | Reedip proposed openstack/python-openstackclient master: Add extra dhcp option to 'port create/set/unset' https://review.openstack.org/356263 | 11:21 |
*** bobh has quit IRC | 11:48 | |
*** jamielennox is now known as jamielennox|away | 12:05 | |
openstackgerrit | Merged openstack/python-openstacksdk master: Add support for volume attachments in compute v2 https://review.openstack.org/455335 | 12:07 |
*** huanxuan has quit IRC | 12:08 | |
*** cdent has quit IRC | 12:12 | |
*** amotoki has quit IRC | 12:15 | |
*** chlong has quit IRC | 12:21 | |
*** reedip_ has joined #openstack-sdks | 12:22 | |
openstackgerrit | Brian Curtin proposed openstack/python-openstacksdk master: Add is_profile_only to Cluster resource https://review.openstack.org/455211 | 12:28 |
*** Daviey has quit IRC | 12:28 | |
*** annegentle has joined #openstack-sdks | 12:29 | |
*** amotoki has joined #openstack-sdks | 12:31 | |
*** annegentle has quit IRC | 12:33 | |
*** annegentle has joined #openstack-sdks | 12:38 | |
*** amotoki has quit IRC | 12:47 | |
*** cleong has joined #openstack-sdks | 12:48 | |
*** Daviey has joined #openstack-sdks | 12:57 | |
*** annegentle has quit IRC | 13:03 | |
elmiko | edleafe: heads up, good chance i will be a few minutes late to the meeting today | 13:15 |
edleafe | elmiko: ok, we'll gossip about you until then | 13:15 |
elmiko | haha, i would expect nothing less ;) | 13:16 |
*** amotoki has joined #openstack-sdks | 13:17 | |
*** rajpatel has joined #openstack-sdks | 13:27 | |
*** gouthamr has joined #openstack-sdks | 13:29 | |
*** cdent has joined #openstack-sdks | 13:33 | |
*** chlong has joined #openstack-sdks | 13:35 | |
*** Dinesh_Bhor has quit IRC | 13:41 | |
openstackgerrit | Brian Curtin proposed openstack/python-openstacksdk master: Add docs for volume_attachment compute methods https://review.openstack.org/456620 | 13:43 |
*** Dinesh_Bhor has joined #openstack-sdks | 13:43 | |
*** reedip_ has quit IRC | 13:55 | |
*** hongbin has joined #openstack-sdks | 14:07 | |
*** reedip_ has joined #openstack-sdks | 14:08 | |
*** fguillot has joined #openstack-sdks | 14:26 | |
openstackgerrit | Merged openstack/python-openstacksdk master: Add docs for volume_attachment compute methods https://review.openstack.org/456620 | 14:27 |
openstackgerrit | Brian Curtin proposed openstack/python-openstacksdk master: Add is_profile_only to Cluster resource https://review.openstack.org/455211 | 14:49 |
openstackgerrit | Brian Curtin proposed openstack/python-openstacksdk master: Enable warnings_as_errors in doc enforcer https://review.openstack.org/453676 | 14:50 |
*** aarefiev is now known as aarefiev_afk | 14:54 | |
*** john-dav_ has joined #openstack-sdks | 14:59 | |
*** john-davidge has quit IRC | 14:59 | |
*** john-dav_ is now known as john-davidge | 15:00 | |
*** annegentle has joined #openstack-sdks | 15:06 | |
*** zacksh_ has joined #openstack-sdks | 15:06 | |
*** lifeless_ has joined #openstack-sdks | 15:07 | |
*** zacksh_ has quit IRC | 15:07 | |
*** zacksh_ has joined #openstack-sdks | 15:07 | |
*** dstanek_ has joined #openstack-sdks | 15:09 | |
*** lbragstad_ has joined #openstack-sdks | 15:09 | |
*** zigo_ has joined #openstack-sdks | 15:09 | |
*** dtroyer_zz has joined #openstack-sdks | 15:09 | |
*** EmilienM_ has joined #openstack-sdks | 15:09 | |
*** reedip_ has quit IRC | 15:10 | |
*** mordred1 has joined #openstack-sdks | 15:10 | |
*** primusinterpares has quit IRC | 15:10 | |
*** dtroyer has quit IRC | 15:10 | |
*** lbragstad has quit IRC | 15:10 | |
*** zacksh has quit IRC | 15:10 | |
*** thingee has quit IRC | 15:10 | |
*** mordred has quit IRC | 15:10 | |
*** nakul_d has quit IRC | 15:10 | |
*** lifeless has quit IRC | 15:10 | |
*** jgriffith has quit IRC | 15:10 | |
*** stevemar has quit IRC | 15:10 | |
*** JayF has quit IRC | 15:10 | |
*** dasanind has quit IRC | 15:10 | |
*** dstanek has quit IRC | 15:10 | |
*** EmilienM has quit IRC | 15:10 | |
*** Shrews has quit IRC | 15:10 | |
*** zigo has quit IRC | 15:10 | |
*** madorn has quit IRC | 15:10 | |
*** dstanek_ is now known as dstanek | 15:10 | |
*** EmilienM_ is now known as 17WAAOC7S | 15:11 | |
*** annegentle has quit IRC | 15:11 | |
*** Shrews has joined #openstack-sdks | 15:11 | |
*** 21WAAA2JF has joined #openstack-sdks | 15:11 | |
*** stevemar has joined #openstack-sdks | 15:11 | |
*** JayF has joined #openstack-sdks | 15:12 | |
*** zacksh_ is now known as zacksh | 15:12 | |
*** madorn has joined #openstack-sdks | 15:12 | |
*** nakul_d has joined #openstack-sdks | 15:12 | |
*** zigo_ is now known as zigo | 15:12 | |
*** thingee has joined #openstack-sdks | 15:12 | |
*** zigo is now known as Guest52586 | 15:12 | |
*** lbragstad_ is now known as lbragstad | 15:14 | |
*** dasanind has joined #openstack-sdks | 15:15 | |
*** annegentle has joined #openstack-sdks | 15:19 | |
openstackgerrit | Merged openstack/python-openstacksdk master: Enable warnings_as_errors in doc enforcer https://review.openstack.org/453676 | 15:19 |
*** primusinterpares has joined #openstack-sdks | 15:21 | |
*** reedip_ has joined #openstack-sdks | 15:23 | |
*** e0ne has quit IRC | 15:35 | |
openstackgerrit | Monty Taylor proposed openstack/os-client-config master: Add ability to pass in user_agent https://review.openstack.org/452550 | 15:39 |
mordred1 | jamielennox|away: ^^ I think that is a better version of that patch | 15:40 |
*** JayF has quit IRC | 15:41 | |
*** JayF has joined #openstack-sdks | 15:45 | |
*** mordred1 is now known as mordred | 15:46 | |
*** amotoki has quit IRC | 15:48 | |
*** fguillot has quit IRC | 15:51 | |
*** fguillot has joined #openstack-sdks | 15:55 | |
*** jpich has quit IRC | 16:09 | |
*** openstack has joined #openstack-sdks | 16:36 | |
*** scottda has joined #openstack-sdks | 16:36 | |
*** ralonsoh has quit IRC | 17:02 | |
*** john-davidge has quit IRC | 17:02 | |
*** john-dav_ has joined #openstack-sdks | 17:02 | |
*** reedip_ has quit IRC | 17:03 | |
*** 21WAAA2JF is now known as EmilienM | 17:05 | |
*** EmilienM has joined #openstack-sdks | 17:05 | |
*** reedip_ has joined #openstack-sdks | 17:16 | |
*** jgriffith has joined #openstack-sdks | 17:35 | |
*** Serlex has quit IRC | 17:53 | |
*** chlong has quit IRC | 18:07 | |
*** ssbarnea has quit IRC | 18:26 | |
*** ssbarnea has joined #openstack-sdks | 18:27 | |
*** reedip_ has quit IRC | 18:43 | |
*** rajpatel has quit IRC | 18:44 | |
*** cdent has quit IRC | 18:45 | |
*** chlong has joined #openstack-sdks | 18:49 | |
*** rajpatel has joined #openstack-sdks | 18:50 | |
*** reedip_ has joined #openstack-sdks | 18:55 | |
*** rabel has joined #openstack-sdks | 18:57 | |
rabel | osc-meeting today? dtroyer_zz? | 18:58 |
*** chlong has quit IRC | 19:02 | |
rabel | dtroyer_zz: so probably no meeting today. ;) i will go then. could you please have a look at https://review.openstack.org/#/c/444924/ ? it's ready for merging, i think. current patch set is from last friday. and also if you could have a look at https://review.openstack.org/#/c/449707/ , it would be nice. just to say if it is ok to deprecate the command like that. i think the gnocchi developers are fine with it. | 19:06 |
rabel | dtroyer_zz: thanks and see you around | 19:06 |
*** rabel has quit IRC | 19:07 | |
*** jkilpatr has quit IRC | 19:08 | |
*** bobh has joined #openstack-sdks | 19:08 | |
*** jkilpatr has joined #openstack-sdks | 19:08 | |
*** bobh has quit IRC | 19:12 | |
*** jkilpatr has quit IRC | 19:15 | |
*** jkilpatr has joined #openstack-sdks | 19:15 | |
*** reedip_ has quit IRC | 19:15 | |
*** gouthamr has quit IRC | 19:17 | |
*** cdent has joined #openstack-sdks | 19:27 | |
*** ssbarnea has quit IRC | 19:28 | |
*** annegentle has joined #openstack-sdks | 19:31 | |
*** e0ne has joined #openstack-sdks | 19:33 | |
*** john-dav_ has quit IRC | 19:36 | |
*** ssbarnea has joined #openstack-sdks | 19:46 | |
-openstackstatus- NOTICE: The Gerrit service on http://review.openstack.org is being restarted to address hung remote replication tasks. | 19:52 | |
*** rajpatel has quit IRC | 19:53 | |
*** annegentle has quit IRC | 19:57 | |
*** annegentle has joined #openstack-sdks | 19:58 | |
*** cdent has quit IRC | 19:59 | |
*** cleong has quit IRC | 20:01 | |
*** gouthamr has joined #openstack-sdks | 20:10 | |
*** e0ne has quit IRC | 20:18 | |
*** fguillot has quit IRC | 20:22 | |
*** reedip_ has joined #openstack-sdks | 20:24 | |
*** ediardo has joined #openstack-sdks | 20:37 | |
*** rajpatel has joined #openstack-sdks | 20:45 | |
*** jkilpatr has quit IRC | 20:52 | |
*** cdent has joined #openstack-sdks | 21:04 | |
*** rajpatel has quit IRC | 21:07 | |
*** sdague has quit IRC | 21:11 | |
*** chlong has joined #openstack-sdks | 21:17 | |
*** rajpatel has joined #openstack-sdks | 21:21 | |
*** rajpatel has quit IRC | 21:22 | |
*** cdent has quit IRC | 21:25 | |
*** reedip_ has quit IRC | 21:33 | |
*** jkilpatr has joined #openstack-sdks | 21:42 | |
*** chlong has quit IRC | 21:42 | |
*** annegentle has quit IRC | 21:46 | |
*** john-davidge has joined #openstack-sdks | 21:47 | |
*** reedip_ has joined #openstack-sdks | 21:47 | |
*** john-davidge has quit IRC | 21:51 | |
*** jamielennox|away is now known as jamielennox | 22:19 | |
*** reedip_ is now known as reedip_afk | 22:33 | |
*** annegentle has joined #openstack-sdks | 22:33 | |
*** annegentle has quit IRC | 22:33 | |
*** gouthamr has quit IRC | 23:24 | |
openstackgerrit | ayoung proposed openstack/python-openstackclient master: Implied Roles https://review.openstack.org/290253 | 23:28 |
*** gouthamr has joined #openstack-sdks | 23:36 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!