| *** hongbin has quit IRC | 00:10 | |
| *** bobh has joined #openstack-sdks | 00:12 | |
| *** reedip_ has joined #openstack-sdks | 00:38 | |
| *** bobh has quit IRC | 00:39 | |
| *** hoangcx has joined #openstack-sdks | 00:53 | |
| *** bobh has joined #openstack-sdks | 01:00 | |
| *** bobh has quit IRC | 01:37 | |
| *** annp has joined #openstack-sdks | 01:44 | |
| *** openstackgerrit has joined #openstack-sdks | 02:09 | |
| openstackgerrit | Hong Hui Xiao proposed openstack/python-openstackclient master: Don't show hint about vlan transparent in network set https://review.openstack.org/466002 | 02:09 |
|---|---|---|
| *** reedip_ has quit IRC | 02:30 | |
| *** prg3 has quit IRC | 02:51 | |
| *** prg3 has joined #openstack-sdks | 02:55 | |
| *** bobh has joined #openstack-sdks | 03:10 | |
| *** yuanying has joined #openstack-sdks | 03:24 | |
| *** bobh has quit IRC | 03:33 | |
| *** gouthamr has quit IRC | 03:57 | |
| *** markvoelker has joined #openstack-sdks | 04:13 | |
| *** prg3 has quit IRC | 04:45 | |
| openstackgerrit | Reedip proposed openstack/python-openstackclient master: Add default-quota to subnet pool commands https://review.openstack.org/437367 | 04:52 |
| *** prg3 has joined #openstack-sdks | 05:00 | |
| *** markvoelker_ has joined #openstack-sdks | 05:11 | |
| *** markvoelker has quit IRC | 05:14 | |
| *** markvoelker has joined #openstack-sdks | 05:17 | |
| *** markvoel_ has joined #openstack-sdks | 05:19 | |
| *** markvoelker has quit IRC | 05:19 | |
| *** markvoelker_ has quit IRC | 05:21 | |
| *** prg3 has quit IRC | 05:38 | |
| *** prg3 has joined #openstack-sdks | 05:42 | |
| *** markvoel_ has quit IRC | 05:53 | |
| *** markvoelker has joined #openstack-sdks | 05:53 | |
| *** markvoelker has quit IRC | 05:54 | |
| *** Dinesh_Bhor has quit IRC | 06:06 | |
| *** Dinesh_Bhor has joined #openstack-sdks | 06:11 | |
| *** prg3 has quit IRC | 06:14 | |
| *** markvoelker has joined #openstack-sdks | 06:27 | |
| *** markvoelker has quit IRC | 06:32 | |
| *** ralonsoh has joined #openstack-sdks | 06:55 | |
| *** hoangcx_ has joined #openstack-sdks | 06:55 | |
| *** hoangcx has quit IRC | 06:57 | |
| *** hoangcx_ is now known as hoangcx | 06:58 | |
| *** markvoelker has joined #openstack-sdks | 06:59 | |
| *** markvoelker has quit IRC | 07:03 | |
| *** markvoelker has joined #openstack-sdks | 07:09 | |
| *** markvoelker has quit IRC | 07:14 | |
| *** Serlex has joined #openstack-sdks | 07:25 | |
| *** markvoelker has joined #openstack-sdks | 07:29 | |
| *** jpich has joined #openstack-sdks | 07:35 | |
| *** markvoelker has quit IRC | 07:37 | |
| *** dtantsur|afk is now known as dtantsur | 07:38 | |
| *** markvoelker has joined #openstack-sdks | 07:42 | |
| *** markvoelker has quit IRC | 07:49 | |
| *** hoangcx_ has joined #openstack-sdks | 07:59 | |
| *** hoangcx has quit IRC | 08:02 | |
| *** hoangcx_ is now known as hoangcx | 08:08 | |
| *** sheel has joined #openstack-sdks | 08:13 | |
| *** gildub has quit IRC | 08:14 | |
| *** markvoelker has joined #openstack-sdks | 08:24 | |
| *** markvoelker has quit IRC | 08:30 | |
| *** markvoelker has joined #openstack-sdks | 08:32 | |
| *** hoangcx_ has joined #openstack-sdks | 08:32 | |
| *** hoangcx has quit IRC | 08:34 | |
| *** markvoelker has quit IRC | 08:40 | |
| openstackgerrit | Rui Chen proposed openstack/python-openstackclient master: Rework server migrate to support cold and live https://review.openstack.org/460059 | 08:46 |
| *** e0ne has joined #openstack-sdks | 08:56 | |
| *** markvoelker has joined #openstack-sdks | 09:16 | |
| *** markvoelker has quit IRC | 09:21 | |
| *** hoangcx has joined #openstack-sdks | 09:25 | |
| *** hoangcx_ has quit IRC | 09:26 | |
| *** cdent has joined #openstack-sdks | 09:46 | |
| *** sdague has joined #openstack-sdks | 09:46 | |
| *** markvoelker has joined #openstack-sdks | 09:54 | |
| *** adriant has quit IRC | 09:58 | |
| *** markvoelker has quit IRC | 09:58 | |
| *** sfinucan has quit IRC | 10:19 | |
| *** sfinucan has joined #openstack-sdks | 10:19 | |
| *** hoangcx has quit IRC | 10:21 | |
| *** sheel has quit IRC | 10:22 | |
| *** annp has quit IRC | 10:27 | |
| openstackgerrit | Sean Dague proposed openstack/keystoneauth master: Add global_request_id param to Adapter constructor https://review.openstack.org/467991 | 10:43 |
| sdague | jamielennox: if you happen to still be awake ^^^^ would be great to have eyes on | 10:44 |
| *** markvoelker has joined #openstack-sdks | 10:47 | |
| *** markvoelker has quit IRC | 10:52 | |
| *** markvoelker has joined #openstack-sdks | 10:55 | |
| *** jkilpatr has quit IRC | 10:57 | |
| *** markvoelker has quit IRC | 10:59 | |
| *** jkilpatr has joined #openstack-sdks | 11:14 | |
| *** markvoelker has joined #openstack-sdks | 11:14 | |
| *** markvoelker has quit IRC | 11:19 | |
| *** markvoelker has joined #openstack-sdks | 11:29 | |
| *** markvoelker has quit IRC | 11:34 | |
| jamielennox | sdague: that spec looks remarkably like what request id was supposed to be before it got all committeed | 11:35 |
| sdague | jamielennox: yeh, well what is old is new again? | 11:40 |
| jamielennox | it's nice to see some sanity being restored | 11:41 |
| sdague | so, all that previous work predates me, but we seemed to get agreement at the summit, so I'm running at it as fast as I can while we have that | 11:41 |
| sdague | having the 2 ids does end up being useful, so you can distinguish the fact that there are a lot of cross calls some times | 11:42 |
| sdague | the oslo side changes are all landed and released, so now it's just plumbing clients and callers | 11:42 |
| jamielennox | sdague: commented, code feels odd, i don't mind which way it's fixed | 11:44 |
| jamielennox | sdague: it does feel weird to be setting this on the Adapter, adapters are created per client so you're not going to share that request_id across a lot of connections that way | 11:44 |
| jamielennox | though with sessions lasting a long time there's not really a good spot to put a request level middleware in currently | 11:45 |
| sdague | jamielennox: ok, I'm not sure I quite understand the concerns there | 11:47 |
| sdague | because we don't want to be sharing request_id more broadly, the important thing is that it's relevant to the flow right now | 11:48 |
| jamielennox | note the way i always hoped this would work is that auth_token middleware currently passes down an auth plugin. that auth plugin when used to contact another service does all the correct things like uses a service token and presents the right catalog and stuff | 11:49 |
| jamielennox | and would be able to pass through a request-id that it received to the auth plugin and auto end up in other requests | 11:49 |
| jamielennox | but it was super slow work getting people to adopt that and it didn't get very far | 11:49 |
| jamielennox | sdague: yea, if it's useful there then that's fine. Re code, i just mean to store the variable in one place. I don't mind if it's a property around additional_headers or if you manually add it to headers later like we do for user_agent, just not stored twice | 11:51 |
| sdague | ok | 11:52 |
| *** markvoelker has joined #openstack-sdks | 12:00 | |
| *** jkilpatr has quit IRC | 12:00 | |
| *** jkilpatr has joined #openstack-sdks | 12:01 | |
| *** chenyb4_ has joined #openstack-sdks | 12:02 | |
| *** markvoelker has quit IRC | 12:04 | |
| sdague | jamielennox: for reference - https://review.openstack.org/#/c/467242/ is what the nova change looks like with some passing on to clients | 12:09 |
| sdague | https://review.openstack.org/#/c/467417/ is it all glued together, you'll see some global_ids logged in cinder / neutron with that | 12:10 |
| jamielennox | sdague: yea, you can get a fair way with additional_headers now, but i'm happy to make it a real thing | 12:10 |
| *** markvoelker has joined #openstack-sdks | 12:11 | |
| sdague | jamielennox: yeh, I've been just direct plumbing into neutron/cinder/glance clients, but the neutron folks wanted it in keystonauth. I'm kind of fine either way, because it's pretty much just a single field to pop out on the constructor if it's totally at the top level | 12:12 |
| sdague | even though we're setting global_request_id in constructors quite often in time, in code, it's typically consolidated to a single location in the caller | 12:12 |
| *** markvoelker has quit IRC | 12:15 | |
| *** jkilpatr has quit IRC | 12:16 | |
| *** markvoelker has joined #openstack-sdks | 12:17 | |
| *** markvoelker has quit IRC | 12:22 | |
| openstackgerrit | Matthew Booth proposed openstack/os-client-config master: Don't pop from os.environ https://review.openstack.org/468020 | 12:27 |
| *** jkilpatr has joined #openstack-sdks | 12:43 | |
| openstackgerrit | Sean Dague proposed openstack/keystoneauth master: Add global_request_id param to Adapter constructor https://review.openstack.org/467991 | 12:47 |
| *** bobh has joined #openstack-sdks | 12:48 | |
| openstackgerrit | Rui Chen proposed openstack/python-openstackclient master: Rework server migrate to support cold and live https://review.openstack.org/460059 | 12:53 |
| *** fguillot has joined #openstack-sdks | 12:55 | |
| *** markvoelker has joined #openstack-sdks | 12:56 | |
| *** prg3 has joined #openstack-sdks | 13:00 | |
| *** gouthamr has joined #openstack-sdks | 13:02 | |
| *** chlong has quit IRC | 13:06 | |
| *** chenyb4_ has quit IRC | 13:19 | |
| openstackgerrit | Monty Taylor proposed openstack/os-client-config master: Don't pop from os.environ https://review.openstack.org/468020 | 13:31 |
| mordred | Shrews, dtroyer: if you get time, I'd really like to get the top five patches from https://review.openstack.org/#/q/project:openstack/os-client-config+status:open+label:Workflow=0 landed and a new occ out - they're all small/easy | 13:32 |
| mordred | Shrews, dtroyer: but there are a few behavior bugs that are biting people | 13:32 |
| *** markvoelker has quit IRC | 13:33 | |
| Shrews | mordred: k | 13:38 |
| *** fzdarsky has joined #openstack-sdks | 13:39 | |
| *** chenyb4_ has joined #openstack-sdks | 13:41 | |
| Shrews | mordred: is https://review.openstack.org/465195 still relevant with https://review.openstack.org/468020 ? | 13:42 |
| *** chenyb4_ has quit IRC | 13:42 | |
| *** chenyb4_ has joined #openstack-sdks | 13:42 | |
| mordred | Shrews: the reason for writing it isn't - but it's still a good idea I think - the OpenStackConfig object is really intended to be a singleton | 13:42 |
| *** reedip_ has joined #openstack-sdks | 13:57 | |
| *** fzdarsky has quit IRC | 14:09 | |
| *** chenyb4_ has quit IRC | 14:12 | |
| *** chenyb4_ has joined #openstack-sdks | 14:13 | |
| *** markvoelker has joined #openstack-sdks | 14:15 | |
| *** chenyb4_ has quit IRC | 14:17 | |
| *** fzdarsky has joined #openstack-sdks | 14:19 | |
| *** markvoelker has quit IRC | 14:23 | |
| *** chlong has joined #openstack-sdks | 14:27 | |
| *** dtantsur is now known as dtantsur|brb | 14:36 | |
| *** hongbin has joined #openstack-sdks | 14:45 | |
| *** dave-mccowan has joined #openstack-sdks | 15:00 | |
| *** markvoelker has joined #openstack-sdks | 15:01 | |
| *** marst_ has joined #openstack-sdks | 15:05 | |
| *** Serlex has quit IRC | 15:07 | |
| openstackgerrit | Reedip proposed openstack/python-openstackclient master: Introduce quota unset command https://review.openstack.org/376311 | 15:19 |
| openstackgerrit | Reedip proposed openstack/python-openstackclient master: Add extra dhcp option to 'port create/set/unset' https://review.openstack.org/356263 | 15:34 |
| openstackgerrit | Monty Taylor proposed openstack/api-wg master: Add guidelines on Version Discovery https://review.openstack.org/459710 | 15:36 |
| openstackgerrit | Monty Taylor proposed openstack/api-wg master: Add document describing consuming version discovery https://review.openstack.org/459405 | 15:36 |
| openstackgerrit | Monty Taylor proposed openstack/api-wg master: Describe the publication of service-types-authority data https://review.openstack.org/462815 | 15:36 |
| mordred | cdent, edleafe, elmiko: I believe I've gotten all current reviews taken care of | 15:37 |
| cdent | yay! | 15:37 |
| edleafe | mordred: on my list | 15:38 |
| elmiko | mordred: sweet, i'm rounding the corner on my last lap for the reviews you posted | 15:46 |
| mordred | elmiko: woot! | 15:47 |
| elmiko | also kudos on consuming-version-discovery.rst, this thing is a beast! | 15:48 |
| *** dtantsur|brb is now known as dtantsur | 15:49 | |
| *** e0ne has quit IRC | 15:51 | |
| mordred | elmiko: it really is, isn't it? | 15:52 |
| mordred | elmiko: the scary part is that somehow I actually have all of that stored in my head | 15:52 |
| elmiko | mordred: that is scary... | 15:53 |
| elmiko | mordred: i really like your enumeration of the algorithms though, i think it will help readers understand this better | 15:53 |
| mordred | elmiko: thanks! ... I certainly hope so | 15:54 |
| mordred | the fun part is that next I need to write a spec for keystone about implementing this in keystoneauth :) | 15:55 |
| elmiko | good luck sir | 15:56 |
| openstackgerrit | Yuval Shalev proposed openstack/python-openstacksdk master: Added server console output method https://review.openstack.org/468078 | 15:58 |
| *** jpich has quit IRC | 16:17 | |
| *** reedip_ has quit IRC | 16:19 | |
| *** cdent has quit IRC | 16:22 | |
| *** ralonsoh has quit IRC | 17:01 | |
| *** dtantsur is now known as dtantsur|afk | 17:03 | |
| *** prg3 has quit IRC | 17:16 | |
| elmiko | edleafe: draft up, https://etherpad.openstack.org/p/api-wg-newsletter | 17:32 |
| elmiko | i realize you may be out, i'll wait 15-20 then post it | 17:32 |
| *** fzdarsky has quit IRC | 17:51 | |
| *** prg3 has joined #openstack-sdks | 18:02 | |
| openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Add flavor value options https://review.openstack.org/302795 | 18:08 |
| *** prg3 has quit IRC | 18:13 | |
| *** dgonzalez has quit IRC | 18:22 | |
| *** dgonzalez has joined #openstack-sdks | 18:22 | |
| *** fzdarsky has joined #openstack-sdks | 18:24 | |
| *** fzdarsky has quit IRC | 18:29 | |
| *** e0ne has joined #openstack-sdks | 19:01 | |
| *** e0ne has quit IRC | 19:17 | |
| *** e0ne has joined #openstack-sdks | 19:27 | |
| openstackgerrit | Merged openstack/python-openstackclient master: Convert volume functional tests into JSON format https://review.openstack.org/465208 | 19:30 |
| openstackgerrit | Monty Taylor proposed openstack/api-wg master: Add support for historical service type aliases https://review.openstack.org/460654 | 19:31 |
| openstackgerrit | Monty Taylor proposed openstack/api-wg master: Add guidelines on Version Discovery https://review.openstack.org/459710 | 19:31 |
| openstackgerrit | Monty Taylor proposed openstack/api-wg master: Add document describing consuming version discovery https://review.openstack.org/459405 | 19:31 |
| openstackgerrit | Monty Taylor proposed openstack/api-wg master: Describe the publication of service-types-authority data https://review.openstack.org/462815 | 19:31 |
| openstackgerrit | Monty Taylor proposed openstack/api-wg master: Add guideline about consuming endpoints from catalog https://review.openstack.org/462814 | 19:31 |
| *** cdent has joined #openstack-sdks | 19:32 | |
| *** bobh has quit IRC | 19:50 | |
| *** annegentle has joined #openstack-sdks | 19:53 | |
| openstackgerrit | Merged openstack/python-openstackclient master: Add functional test for volume service https://review.openstack.org/432282 | 19:53 |
| *** jamielennox is now known as jamielennox|away | 19:56 | |
| *** amotoki is now known as amotoki_away | 19:58 | |
| *** amotoki_away is now known as amotoki | 19:59 | |
| *** amotoki is now known as amotoki_away | 19:59 | |
| *** fguillot has quit IRC | 20:00 | |
| *** cdent has quit IRC | 20:02 | |
| *** prg3 has joined #openstack-sdks | 20:08 | |
| *** chlong has quit IRC | 20:15 | |
| *** prg3 has quit IRC | 20:19 | |
| dhellmann | dtroyer : in ATL we talked about a daemon mode for cliff/OSC. My notes say "add an option to emit a null value after the formatter output". Is that really all we need there? | 20:20 |
| *** prg3 has joined #openstack-sdks | 20:28 | |
| *** jkilpatr has quit IRC | 20:29 | |
| *** chlong has joined #openstack-sdks | 20:33 | |
| *** chlong has quit IRC | 20:37 | |
| *** chlong has joined #openstack-sdks | 20:38 | |
| *** prg3 has quit IRC | 20:40 | |
| *** markvoelker has quit IRC | 20:42 | |
| *** prg3 has joined #openstack-sdks | 20:45 | |
| *** jkilpatr has joined #openstack-sdks | 20:49 | |
| dtroyer | dhellmann: that is the minimum needed to delimit return data for each command. I didn't want to invent a protocol for this so hopefully that is all we would need | 20:50 |
| dhellmann | dtroyer : ok | 20:50 |
| dhellmann | do we want a --daemon-mode that implies --interactive and also adds the null? or just a --null-delimited-output option? | 20:50 |
| dtroyer | I was only thinking about the —null option as interactive is already implied when no command is given | 20:52 |
| dhellmann | makes sense | 20:52 |
| dhellmann | just --null then? | 20:52 |
| dhellmann | not --null-delimited-output? | 20:52 |
| dtroyer | hmmm, it may need to be more specific, to be honest I have been thinking about cribbing the xargs -0 option, not sure if we need to be able to specify the delimiter char | 20:53 |
| dhellmann | oh, -0 works | 20:53 |
| dhellmann | ok, the other thing we talked about was "command extensions" | 20:53 |
| dhellmann | I'm looking at that right now | 20:54 |
| dtroyer | the semantics are not identical to xargs though so maybe that connection is not quite as useful | 20:54 |
| dhellmann | I can either load them from a separate namespace for each use (args, pre, & post hooks) | 20:54 |
| dhellmann | or I can load them from one namespace and expect a class with a specific API for each of those cases | 20:54 |
| dhellmann | any preference? | 20:54 |
| dhellmann | I'll make --null-delimited-output and -0 aliases | 20:55 |
| dtroyer | I've imagined it as a single class with essentially hook methods to override, but I don't have a huge preference yet | 20:55 |
| dtroyer | the alias sounds good | 20:55 |
| dhellmann | ok, I was leaning toward a class, too | 20:55 |
| dtroyer | having a single namespace does feel cleaner | 20:56 |
| dhellmann | I was going to make the namespace the application namespace + cmd_name.replace(' ', '_') | 20:56 |
| dhellmann | then plugins can have their own names | 20:56 |
| *** markvoelker has joined #openstack-sdks | 20:56 | |
| dtroyer | sounds good | 20:56 |
| dhellmann | k | 20:56 |
| *** markvoelker has quit IRC | 21:00 | |
| *** e0ne has quit IRC | 21:05 | |
| *** fzdarsky has joined #openstack-sdks | 21:05 | |
| *** chlong has quit IRC | 21:11 | |
| *** sdague has quit IRC | 21:24 | |
| *** marst_ has quit IRC | 21:30 | |
| *** dave-mccowan has quit IRC | 21:33 | |
| *** fzdarsky has quit IRC | 21:39 | |
| dtroyer | dhellmann: if you're still around… with the major rev of cliff on the near horizon, do you want to wait for that release for this stuff to land ^^^^ | 21:42 |
| *** bobh has joined #openstack-sdks | 21:50 | |
| *** bobh has quit IRC | 21:55 | |
| *** markvoelker has joined #openstack-sdks | 22:05 | |
| *** annegentle has quit IRC | 22:06 | |
| *** markvoelker has quit IRC | 22:15 | |
| *** markvoelker has joined #openstack-sdks | 22:16 | |
| *** prg3 has quit IRC | 22:20 | |
| *** gouthamr has quit IRC | 22:29 | |
| *** jamielennox|away is now known as jamielennox | 22:36 | |
| openstackgerrit | Merged openstack/os-client-config master: Add helper method to fetch service catalog https://review.openstack.org/464238 | 22:55 |
| openstackgerrit | Merged openstack/os-client-config master: Add ironicclient to constructors list https://review.openstack.org/464239 | 22:55 |
| openstackgerrit | Merged openstack/os-client-config master: Keep a singleton to support multiple get_config calls https://review.openstack.org/465195 | 22:55 |
| openstackgerrit | Merged openstack/os-client-config master: Don't pop from os.environ https://review.openstack.org/468020 | 22:55 |
| openstackgerrit | Doug Hellmann proposed openstack/cliff master: add cmd_name argument to CompleteCommand https://review.openstack.org/468195 | 23:05 |
| openstackgerrit | Doug Hellmann proposed openstack/cliff master: pass the command name from HelpCommand https://review.openstack.org/468196 | 23:05 |
| openstackgerrit | Doug Hellmann proposed openstack/cliff master: add hook for manipulating the argument parser https://review.openstack.org/468197 | 23:05 |
| openstackgerrit | Doug Hellmann proposed openstack/cliff master: add hook for get_epilog https://review.openstack.org/468198 | 23:05 |
| openstackgerrit | Doug Hellmann proposed openstack/cliff master: add before and after hooks https://review.openstack.org/468199 | 23:05 |
| *** gouthamr has joined #openstack-sdks | 23:05 | |
| dhellmann | dtroyer : let's see how closely this matches up with what you were thinking ^^ | 23:05 |
| openstackgerrit | Doug Hellmann proposed openstack/cliff master: add hook for get_epilog https://review.openstack.org/468198 | 23:10 |
| openstackgerrit | Doug Hellmann proposed openstack/cliff master: add before and after hooks https://review.openstack.org/468199 | 23:10 |
| openstackgerrit | Merged openstack/os-client-config master: Revert "Revert "Use interface not endpoint_type for keystoneclient"" https://review.openstack.org/464299 | 23:10 |
| *** markvoelker has quit IRC | 23:11 | |
| *** gildub has joined #openstack-sdks | 23:30 | |
| *** markvoelker has joined #openstack-sdks | 23:44 | |
| *** markvoelker has quit IRC | 23:45 | |
| *** hongbin has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!