*** dave-mccowan has joined #openstack-sdks | 00:05 | |
*** e0ne has quit IRC | 00:14 | |
*** ldl has joined #openstack-sdks | 00:21 | |
*** cdent has quit IRC | 00:25 | |
*** edmondsw has joined #openstack-sdks | 00:31 | |
*** edmondsw has quit IRC | 00:36 | |
*** fabian has joined #openstack-sdks | 00:51 | |
*** fabian is now known as chenyb4 | 00:54 | |
*** markvoelker has quit IRC | 01:08 | |
*** slaweq has joined #openstack-sdks | 01:13 | |
*** gkadam has quit IRC | 01:15 | |
*** gkadam has joined #openstack-sdks | 01:16 | |
*** slaweq has quit IRC | 01:18 | |
*** slaweq has joined #openstack-sdks | 01:20 | |
*** slaweq has quit IRC | 01:25 | |
*** dave-mccowan has quit IRC | 01:34 | |
*** tonyb has quit IRC | 01:47 | |
*** tonyb has joined #openstack-sdks | 01:49 | |
*** dave-mccowan has joined #openstack-sdks | 01:55 | |
*** gkadam has quit IRC | 01:56 | |
*** gkadam has joined #openstack-sdks | 01:59 | |
*** markvoelker has joined #openstack-sdks | 02:05 | |
*** annp has joined #openstack-sdks | 02:14 | |
*** dave-mccowan has quit IRC | 02:18 | |
*** dave-mccowan has joined #openstack-sdks | 02:19 | |
*** edmondsw has joined #openstack-sdks | 02:19 | |
*** edmondsw has quit IRC | 02:24 | |
*** gkadam has quit IRC | 03:07 | |
openstackgerrit | Merged openstack/python-openstacksdk master: Remove self argument from connect helper function https://review.openstack.org/530768 | 03:08 |
---|---|---|
*** edmondsw has joined #openstack-sdks | 04:07 | |
*** edmondsw has quit IRC | 04:12 | |
*** chenyb4 has quit IRC | 04:18 | |
openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Make resource a dict subclass usable by shade layer https://review.openstack.org/530835 | 04:25 |
openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Rename Resource.get to Resource.fetch https://review.openstack.org/530836 | 04:25 |
mordred | rods_: ^^ ok. there you go - enjoy! | 04:25 |
*** dave-mccowan has quit IRC | 05:06 | |
*** chenyb4 has joined #openstack-sdks | 05:12 | |
*** annp has quit IRC | 05:30 | |
*** annp has joined #openstack-sdks | 05:31 | |
*** edmondsw has joined #openstack-sdks | 05:56 | |
*** edmondsw has quit IRC | 06:00 | |
*** markvoelker has quit IRC | 06:28 | |
*** edmondsw has joined #openstack-sdks | 07:44 | |
*** slaweq has joined #openstack-sdks | 07:47 | |
*** edmondsw has quit IRC | 07:48 | |
*** e0ne has joined #openstack-sdks | 07:57 | |
*** e0ne has quit IRC | 08:23 | |
*** markvoelker has joined #openstack-sdks | 08:29 | |
*** markvoelker has quit IRC | 09:03 | |
*** jpich has joined #openstack-sdks | 09:05 | |
*** e0ne has joined #openstack-sdks | 09:21 | |
*** d0ugal has quit IRC | 09:27 | |
*** d0ugal has joined #openstack-sdks | 09:28 | |
*** d0ugal has quit IRC | 09:28 | |
*** d0ugal has joined #openstack-sdks | 09:28 | |
*** edmondsw has joined #openstack-sdks | 09:32 | |
*** edmondsw has quit IRC | 09:37 | |
*** ralonsoh has joined #openstack-sdks | 10:00 | |
*** markvoelker has joined #openstack-sdks | 10:01 | |
*** ralonsoh_ has joined #openstack-sdks | 10:06 | |
*** ralonsoh has quit IRC | 10:06 | |
*** annp has quit IRC | 10:21 | |
*** cdent has joined #openstack-sdks | 10:27 | |
*** markvoelker has quit IRC | 10:34 | |
cmurphy | || ggrreepp ssddbb | 10:34 |
cmurphy | rename pike.rst to master.rst i think | 10:35 |
cmurphy | || ggrreepp ssddbb | 10:35 |
*** chenyb4 has quit IRC | 10:35 | |
* cdent looks at cmurphy | 10:36 | |
cmurphy | oh wow sorry | 10:37 |
cmurphy | terminal problems | 10:38 |
cdent | no need to apologize, a) I was curious, b) it wasn't clear you knew it happened | 10:38 |
*** jkilpatr has quit IRC | 11:00 | |
*** noshankus has joined #openstack-sdks | 11:10 | |
*** nokes has joined #openstack-sdks | 11:16 | |
*** noshankus has quit IRC | 11:19 | |
*** nokes is now known as noshankus | 11:19 | |
*** edmondsw has joined #openstack-sdks | 11:20 | |
*** edmondsw has quit IRC | 11:24 | |
*** markvoelker has joined #openstack-sdks | 11:31 | |
*** edmondsw has joined #openstack-sdks | 11:36 | |
*** jkilpatr has joined #openstack-sdks | 11:49 | |
*** markvoelker has quit IRC | 12:05 | |
*** edmondsw has quit IRC | 12:15 | |
*** jkilpatr has quit IRC | 12:28 | |
*** sdague has joined #openstack-sdks | 12:49 | |
*** fabian_ has joined #openstack-sdks | 12:53 | |
*** fabian_ is now known as chenyb4 | 12:53 | |
*** markvoelker has joined #openstack-sdks | 13:02 | |
*** edmondsw has joined #openstack-sdks | 13:13 | |
*** cleong has joined #openstack-sdks | 13:15 | |
*** edmondsw has quit IRC | 13:18 | |
*** markvoelker has quit IRC | 13:19 | |
*** markvoelker has joined #openstack-sdks | 13:20 | |
*** chenyb4 has quit IRC | 13:21 | |
*** chenyb4 has joined #openstack-sdks | 13:21 | |
*** yolanda__ has joined #openstack-sdks | 13:25 | |
*** yolanda has quit IRC | 13:29 | |
*** jkilpatr has joined #openstack-sdks | 13:42 | |
*** dave-mccowan has joined #openstack-sdks | 13:49 | |
*** purplerbot has quit IRC | 14:04 | |
*** purplerbot_ has joined #openstack-sdks | 14:04 | |
*** purplerbot_ is now known as purplerbot__ | 14:04 | |
*** purplerbot__ is now known as purplerbot | 14:04 | |
*** purplerbot has quit IRC | 14:10 | |
*** purplerbot has joined #openstack-sdks | 14:10 | |
*** chenyb4 has quit IRC | 14:19 | |
*** edmondsw has joined #openstack-sdks | 14:37 | |
*** thrash is now known as thrash|biab | 14:38 | |
*** kuzko has quit IRC | 14:40 | |
*** GreenBlood has quit IRC | 14:41 | |
*** bobh has joined #openstack-sdks | 14:44 | |
*** slaweq has quit IRC | 14:54 | |
*** slaweq has joined #openstack-sdks | 15:01 | |
*** slaweq has quit IRC | 15:05 | |
mordred | cdent, cmurphy: that was my first morning irc communication to read - I think today is going to be a good day | 15:19 |
cdent | agreed | 15:19 |
*** slaweq has joined #openstack-sdks | 15:21 | |
cmurphy | always happy to entertain | 15:23 |
cmurphy | (fwiw terminator + weechat = bad) | 15:23 |
*** slaweq has quit IRC | 15:26 | |
Shrews | cmurphy: yeah, i had issues with that combo | 15:26 |
*** slaweq has joined #openstack-sdks | 15:32 | |
*** slaweq has quit IRC | 15:36 | |
*** slaweq has joined #openstack-sdks | 15:58 | |
*** ldl has quit IRC | 16:01 | |
*** jkilpatr has quit IRC | 16:06 | |
*** kmy has quit IRC | 16:09 | |
*** dims has quit IRC | 16:09 | |
*** kmy has joined #openstack-sdks | 16:09 | |
*** dims has joined #openstack-sdks | 16:10 | |
*** thrash|biab is now known as thrash | 16:10 | |
*** openstackgerrit has quit IRC | 16:19 | |
*** jkilpatr has joined #openstack-sdks | 16:19 | |
*** slaweq has quit IRC | 16:22 | |
*** jkilpatr has quit IRC | 16:22 | |
*** jkilpatr has joined #openstack-sdks | 16:23 | |
*** dave-mccowan has quit IRC | 16:24 | |
*** dave-mccowan has joined #openstack-sdks | 16:25 | |
*** slaweq has joined #openstack-sdks | 16:33 | |
*** slaweq has quit IRC | 16:38 | |
*** openstackgerrit has joined #openstack-sdks | 16:52 | |
openstackgerrit | Merged openstack/python-openstackclient master: Update new documentation PTI jobs https://review.openstack.org/530378 | 16:52 |
openstackgerrit | Merged openstack/osc-lib master: Fix sorting in Python 3 https://review.openstack.org/526046 | 16:55 |
*** slaweq has joined #openstack-sdks | 17:04 | |
*** slaweq has quit IRC | 17:09 | |
*** e0ne has quit IRC | 17:12 | |
*** slaweq has joined #openstack-sdks | 17:12 | |
*** jpich has quit IRC | 17:18 | |
openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Update for new docs PTI https://review.openstack.org/530978 | 17:26 |
*** cdent has quit IRC | 17:35 | |
*** cdent has joined #openstack-sdks | 17:36 | |
*** slaweq_ has joined #openstack-sdks | 17:40 | |
*** slaweq has quit IRC | 18:02 | |
*** jkilpatr has quit IRC | 18:03 | |
*** jkilpatr has joined #openstack-sdks | 18:03 | |
*** slaweq_ has quit IRC | 18:13 | |
*** yolanda__ is now known as yolanda | 18:14 | |
*** slaweq_ has joined #openstack-sdks | 18:15 | |
*** slaweq_ has quit IRC | 18:20 | |
*** ChanServ sets mode: +r | 18:21 | |
*** e0ne has joined #openstack-sdks | 18:27 | |
*** jkilpatr has quit IRC | 18:40 | |
*** efried has quit IRC | 19:09 | |
*** reedip has quit IRC | 19:43 | |
*** dave-mccowan has quit IRC | 19:56 | |
*** e0ne has quit IRC | 20:09 | |
*** Jeffrey4l has quit IRC | 20:11 | |
*** Jeffrey4l has joined #openstack-sdks | 20:24 | |
openstackgerrit | Hongbin Lu proposed openstack/python-openstackclient master: Allow ports filtering with device_id https://review.openstack.org/526798 | 21:11 |
mordred | cdent: you know everything, right? | 21:13 |
mordred | cdent: do you happen to know if there are any openstack services that paginate resources with limit/marker but do not return a {foo}_links dict with next links in it? | 21:14 |
mordred | cdent: the question comes up because of https://review.openstack.org/#/c/530769 and briancurtin's comments on it - I'm gonna go look and see what I can learn, but I figured if anyone happened to know off the top of their head about outliers that it would be helpful | 21:17 |
mordred | edleafe, elmiko: ^^ in case you happen to know | 21:18 |
edleafe | mordred: I confess that I do not know of any | 21:19 |
edleafe | mordred: I also confess that I haven't researched that at all :) | 21:20 |
*** cleong has quit IRC | 21:20 | |
*** edmondsw has quit IRC | 21:22 | |
*** e0ne has joined #openstack-sdks | 21:43 | |
elmiko | mordred: i haven't looked into that, and it looks like we have not done a study across projects about it. if you end up poking around, any info would be appreciated =) | 21:53 |
elmiko | https://wiki.openstack.org/wiki/API_Working_Group/Current_Design | 21:53 |
*** e0ne has quit IRC | 21:59 | |
*** e0ne has joined #openstack-sdks | 22:02 | |
*** e0ne has quit IRC | 22:08 | |
*** e0ne has joined #openstack-sdks | 22:12 | |
openstackgerrit | Merged openstack/python-openstacksdk master: Start using Connection in openstack.cloud https://review.openstack.org/523259 | 22:12 |
*** e0ne has quit IRC | 22:14 | |
openstackgerrit | Bar Elharar proposed openstack/osc-lib master: Suppress subTest() expected errors https://review.openstack.org/531025 | 22:14 |
openstackgerrit | Bar Elharar proposed openstack/osc-lib master: Suppress subTest() expected errors https://review.openstack.org/531025 | 22:18 |
openstackgerrit | Bar Elharar proposed openstack/osc-lib master: Suppress subTest() expected errors https://review.openstack.org/531025 | 22:26 |
mordred | edleafe, elmiko: thanks - I think I'm going to start with a mailing list message and see where it gets me | 22:28 |
*** e0ne has joined #openstack-sdks | 22:28 | |
*** bobh has quit IRC | 22:32 | |
*** bobh has joined #openstack-sdks | 22:33 | |
*** bobh has quit IRC | 22:38 | |
cdent | mordred, edleafe, elmiko : I was elsewhere, catching up | 22:40 |
mordred | cdent, edleafe, elmiko: I've found at least one example of a service that does not return $foo_links with a next link to indicate that there are more results available ... swift | 22:42 |
mordred | although now the question is - is it *only* swift (and therefore something that could be overridden in the sdk just for swift) or are there more, in which case adding a pagination_type flag to Resource objects may be the right choice | 22:43 |
cdent | are you using _ as an indicator of object descent, like server.links | 22:43 |
cdent | because both the api-wg guidance and looking at nova I'm not seeing what you're talking about, mordred, but I'm also not sure I know what you're talking about | 22:44 |
mordred | cdent: I've found another - glance is also different ... BUT ... for instance, https://developer.openstack.org/api-guide/compute/paginated_collections.html | 22:46 |
cdent | and https://developer.openstack.org/api-guide/compute/links_and_references.html | 22:46 |
mordred | cdent: nova returns {"servers": [...], "servers_links": [..]} | 22:46 |
mordred | so for a server list one can check servers_links for a next link, and if it exists, follow it | 22:46 |
cdent | sigh | 22:47 |
cdent | nobody ever follows the guidance ( http://specs.openstack.org/openstack/api-wg/guidelines/links.html) and even the services aren't in sync with themselves | 22:47 |
mordred | cdent: but for glance, it's {"images": [...], "next": "http:..."} | 22:48 |
cdent | blargh | 22:48 |
mordred | cdent: well - these links are a little bit different than the per-object links | 22:48 |
cdent | the pagination guidance doesn't distinguish, it's suggest generic 'links': http://specs.openstack.org/openstack/api-wg/guidelines/pagination_filter_sort.html#pagination | 22:48 |
mordred | cdent: I actually *do* see the reference links pretty frequently and consistently - other than when they're broken because reverse-proxies aren't set up correctly :) | 22:48 |
cdent | mordred: oh, I didn't mean nobody follows links. I mean projects not developing consistently. | 22:49 |
mordred | oh - yah. | 22:49 |
cdent | the pagination guidance example on that last link (heh) uses just 'links' in a relatively sane collection example | 22:50 |
briancurtin | since approximately day one, and going on until approximately forever, unfortunately | 22:50 |
mordred | cdent: that api-wg guidance is nice - and at least structurally similar to what I see from cinder and nova (naming notwithstanding) | 22:50 |
cdent | so yeah, I would guess that briancurtin is right | 22:50 |
mordred | briancurtin wins | 22:50 |
mordred | briancurtin: so - since a quick look has shown at least 4 different mechanisms, I'm thinking I should rework that patch to add a resource-level config flag choose one, with the behavior defaulting to the current sdk inferance behavior | 22:52 |
mordred | briancurtin: so that as we know or understand that a given resource provides links guidance we can opt a resource in to that behavior, but there is a good default that should work in the other cases | 22:53 |
briancurtin | mordred: that’s probably reasonable. we originally thought to go something like that direction for times when we knew for sure we wouldn’t need that extra call, so go for it | 22:53 |
briancurtin | yep | 22:53 |
mordred | woot | 22:53 |
mordred | briancurtin, cdent: see - if all the API services were consistent, we'd be issing out on all of this fun! | 22:53 |
* mordred bangs head on desk | 22:53 | |
* cdent checks the dictionary | 22:55 | |
cdent | oh look at the time, goodnight | 23:03 |
*** cdent has quit IRC | 23:03 | |
*** ralonsoh_ has quit IRC | 23:03 | |
*** e0ne has quit IRC | 23:09 | |
mordred | briancurtin: while I'm bugging you - https://review.openstack.org/#/c/530769/1/openstack/resource2.py line 765 in the original code ... seems like a bug - it'll stop iteration if yielded is < limit - shouldn't that be yielded >= query_params['limit'] - or is my brain just too melty? | 23:16 |
mordred | briancurtin: also - line 748 - yielded is reset in each loop iteration - seems like it should be moved to above line 734 - and that line 767 should be query_params['limit'] = limit - yielded | 23:18 |
mordred | briancurtin: I'm going to keep it as is in this patch so we can fix it if needed in its own patch - but just wanted to double-check my reading of the logic there | 23:19 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!