Monday, 2018-01-08

« Sunday, 2018-01-07 Index Tuesday, 2018-01-09 »
*** slaweq has joined #openstack-sdks00:11
*** slaweq has quit IRC00:15
*** d0ugal has quit IRC00:15
*** d0ugal has joined #openstack-sdks00:27
*** chenyb4 has joined #openstack-sdks00:50
*** dave-mccowan has joined #openstack-sdks01:07
*** edmondsw has joined #openstack-sdks01:21
*** edmondsw has quit IRC01:26
*** chenyb4_ has joined #openstack-sdks01:36
*** chenyb4 has quit IRC01:39
openstackgerritMichael Johnson proposed openstack/python-openstacksdk master: Add an octavia functional test gate  https://review.openstack.org/53151401:44
*** annp has joined #openstack-sdks01:54
*** chenyb4_ is now known as chenyb402:11
*** chenyb4_ has joined #openstack-sdks02:30
*** chenyb4 has quit IRC02:33
openstackgerritBar Elharar proposed openstack/osc-lib master: Suppress subTest() expected errors  https://review.openstack.org/53102502:43
openstackgerritBar Elharar proposed openstack/osc-lib master: Suppress subTest() expected errors  https://review.openstack.org/53102502:56
*** dave-mccowan has quit IRC03:09
*** edmondsw has joined #openstack-sdks03:09
*** edmondsw has quit IRC03:14
*** chenyb4 has joined #openstack-sdks03:28
*** chenyb4_ has quit IRC03:31
*** ldl has joined #openstack-sdks03:58
*** chenyb4_ has joined #openstack-sdks04:03
*** chenyb4 has quit IRC04:05
*** pooja_jadhav has joined #openstack-sdks04:11
*** chenyb4_ has quit IRC04:13
*** rate has joined #openstack-sdks04:26
*** rate is now known as chenyb404:27
*** chenyb4_ has joined #openstack-sdks04:51
*** chenyb4 has quit IRC04:54
*** edmondsw has joined #openstack-sdks04:58
*** edmondsw has quit IRC05:02
*** pooja_jadhav has quit IRC05:15
*** chenyb4 has joined #openstack-sdks05:20
*** chenyb4_ has quit IRC05:24
*** pooja_jadhav has joined #openstack-sdks05:25
*** chenyb4_ has joined #openstack-sdks05:54
*** chenyb4 has quit IRC05:57
*** ldl has quit IRC06:16
openstackgerritMerged openstack/python-openstacksdk master: Updated from global requirements  https://review.openstack.org/52568906:20
*** chenyb4 has joined #openstack-sdks06:29
*** chenyb4_ has quit IRC06:33
*** edmondsw has joined #openstack-sdks06:46
*** chenyb4 has quit IRC06:50
*** edmondsw has quit IRC06:50
*** liuyulong has joined #openstack-sdks06:55
*** reedip has quit IRC06:55
*** rate has joined #openstack-sdks07:02
*** reedip has joined #openstack-sdks07:07
*** Kevin_Zheng has quit IRC07:13
*** Shrews has quit IRC07:13
*** knikolla has quit IRC07:13
*** knikolla has joined #openstack-sdks07:13
*** Shrews has joined #openstack-sdks07:14
*** Kevin_Zheng has joined #openstack-sdks07:16
*** rate has quit IRC07:18
*** rate has joined #openstack-sdks07:24
*** ldl has joined #openstack-sdks07:26
*** slaweq has joined #openstack-sdks07:30
*** rabel_b1 has joined #openstack-sdks07:46
*** rate is now known as chenyb407:47
*** chenyb4_ has joined #openstack-sdks07:50
*** chenyb4 has quit IRC07:53
*** chenyb4 has joined #openstack-sdks08:00
*** chenyb4_ has quit IRC08:04
*** ralonsoh has joined #openstack-sdks08:09
*** fzdarsky has joined #openstack-sdks08:17
*** chenyb4 has quit IRC08:18
*** chenyb4 has joined #openstack-sdks08:19
*** honza has quit IRC08:20
*** honza has joined #openstack-sdks08:20
*** honza is now known as Guest1450008:20
*** rabel__b1 has joined #openstack-sdks08:23
*** rabel_b1 has quit IRC08:26
*** edmondsw has joined #openstack-sdks08:34
*** edmondsw has quit IRC08:39
*** rabel_b1 has joined #openstack-sdks08:53
*** rabel__b1 has quit IRC08:55
*** jpich has joined #openstack-sdks09:08
*** Guest14500 is now known as honza09:14
*** finucannot is now known as stephenfin09:16
*** thrash|g0ne has quit IRC09:19
*** thrash has joined #openstack-sdks09:21
*** thrash has joined #openstack-sdks09:21
*** e0ne has joined #openstack-sdks09:33
*** fzdarsky has quit IRC09:39
*** e0ne has quit IRC09:47
*** rabel_b1 has quit IRC09:51
*** rabel_b1 has joined #openstack-sdks09:51
*** chenyb4 has quit IRC10:12
*** cdent has joined #openstack-sdks10:13
*** edmondsw has joined #openstack-sdks10:22
-openstackstatus- NOTICE: zuul has been restarted, all queues have been reset. please recheck your patches when appropriate10:26
*** edmondsw has quit IRC10:27
*** annp has quit IRC10:32
*** cdent has quit IRC11:31
*** rcarrill1 has joined #openstack-sdks11:32
*** rcarrillocruz has quit IRC11:35
*** fzdarsky has joined #openstack-sdks11:36
*** jkilpatr has quit IRC11:50
*** sdague has joined #openstack-sdks12:00
*** zhongjun has quit IRC12:06
*** cdent has joined #openstack-sdks12:09
*** dave-mccowan has joined #openstack-sdks12:10
*** edmondsw has joined #openstack-sdks12:10
*** edmondsw has quit IRC12:15
*** jkilpatr has joined #openstack-sdks12:22
*** liuyulong has quit IRC12:24
*** rcarrill1 is now known as rcarrillocruz12:24
*** chenyb4 has joined #openstack-sdks12:30
*** ldl has quit IRC12:32
*** ldl has joined #openstack-sdks12:32
*** ldl has quit IRC12:36
*** dave-mccowan has quit IRC12:47
*** dave-mccowan has joined #openstack-sdks12:49
*** cdent has quit IRC13:01
*** cdent has joined #openstack-sdks13:09
*** cleong has joined #openstack-sdks13:28
*** jkilpatr has quit IRC13:31
*** gkadam has joined #openstack-sdks13:33
*** jkilpatr has joined #openstack-sdks13:44
*** edmondsw has joined #openstack-sdks13:51
*** ldl has joined #openstack-sdks13:58
*** nokes has joined #openstack-sdks13:58
*** noshankus has quit IRC13:58
*** nokes_ has joined #openstack-sdks13:59
*** nokes_ is now known as noshankus13:59
*** nokes has quit IRC14:02
*** ldl has quit IRC14:02
*** dayou has joined #openstack-sdks14:03
*** dayou has joined #openstack-sdks14:03
openstackgerritMonty Taylor proposed openstack/python-openstacksdk master: Rename CloudConfig to CloudRegion  https://review.openstack.org/53161114:25
mordredShrews: if you have a sec, https://review.openstack.org/#/c/530978 and https://review.openstack.org/#/c/531267 are both super simple/mechanical14:26
*** chenyb4 has quit IRC14:27
Shrewsmordred: YOU'RE super simple/mechanical14:28
*** dayou has quit IRC14:28
*** chenyb4 has joined #openstack-sdks14:35
*** e0ne has joined #openstack-sdks14:37
* cdent automates mordred 14:51
*** dayou has joined #openstack-sdks14:55
*** fzdarsky has quit IRC15:03
*** fzdarsky has joined #openstack-sdks15:03
*** sdague has quit IRC15:04
*** cdent has quit IRC15:20
*** chenyb4 has quit IRC15:24
openstackgerritMerged openstack/python-openstacksdk master: Update for new docs PTI  https://review.openstack.org/53097815:28
*** e0ne has quit IRC15:28
*** SamYaple_ has quit IRC15:30
*** SamYaple has joined #openstack-sdks15:30
*** nokes has joined #openstack-sdks15:33
*** noshankus has quit IRC15:36
*** nokes is now known as noshankus15:36
*** bobh has joined #openstack-sdks15:42
openstackgerritMerged openstack/python-openstacksdk master: Remove name from zuul project stanza  https://review.openstack.org/53126715:45
*** SamYaple has quit IRC15:57
*** slaweq has quit IRC15:57
*** SamYaple has joined #openstack-sdks15:57
*** slaweq has joined #openstack-sdks15:58
*** SamYaple has quit IRC15:58
*** SamYaple has joined #openstack-sdks15:58
*** e0ne has joined #openstack-sdks15:58
*** nokes has joined #openstack-sdks16:01
*** slaweq has quit IRC16:02
*** noshankus has quit IRC16:04
*** nokes is now known as noshankus16:04
*** cdent has joined #openstack-sdks16:09
*** e0ne has quit IRC16:24
*** kmy has quit IRC16:28
*** kmy has joined #openstack-sdks16:29
*** slaweq has joined #openstack-sdks16:32
*** d0ugal has quit IRC16:35
*** cdent has quit IRC16:35
*** slaweq has quit IRC16:37
*** kmalloc has joined #openstack-sdks16:38
*** jkilpatr has quit IRC16:44
*** e0ne has joined #openstack-sdks16:53
*** d0ugal has joined #openstack-sdks17:00
*** jkilpatr has joined #openstack-sdks17:00
*** slaweq has joined #openstack-sdks17:00
mordredbriancurtin: responded to your note on the dict patch - thanks for the background! I've got one more thing to try, will ping you when its up- might be tomorrow17:04
mordredbriancurtin: however, it's also entirely possible the results here will be "unpossible/bad idea"17:04
*** slaweq has quit IRC17:11
*** d0ugal has quit IRC17:11
*** fzdarsky is now known as fzdarsky|afk17:28
*** jpich has quit IRC17:33
briancurtinmordred: ok cool, sounds good17:48
mordrededleafe, elmiko: was just chatting with notmyname verifying that I was understanding swift pagingation correctly17:49
mordrededleafe, elmiko: and in doing so I discovered that requests parses rfc5988 headers automatically: http://docs.python-requests.org/en/master/user/advanced/#link-headers17:50
mordrededleafe, elmiko: given the variation in how pagination links are returned today, and how unlikely it is that we'd be able to get all the services aligned on one approach - since backwards compat would make it living hell ...17:50
mordredwhat if we changed the recommendation to start publishing rfc5988 compliant links headers - the data is the same as what peopel are already putting in links bodies (slightly different format, but whatever)17:51
mordredsince it's a standard header that's intended to be used for that, it shouldn't be a backwards compat issue - and clients could easily consume Links headers if they exist, and otherwise fallback to existing "look for resp.json()['links'] or resp.json['{resource}_links'] or resp.json()['next'] or an object count in resp.headers"17:53
edleafemordred: so if I understand you correctly, projects could leave their assorted formats in the response body alone, and just add the necessary headers?17:55
edleafemordred: and then clients could just check for the next/prev link from the headers?17:55
*** e0ne has quit IRC17:55
*** rabel_b1 has quit IRC17:58
*** slaweq has joined #openstack-sdks18:05
*** ralonsoh has quit IRC18:05
*** cdent has joined #openstack-sdks18:08
*** slaweq has quit IRC18:17
*** jkilpatr has quit IRC18:19
*** dtantsur is now known as dtantsur|afk18:20
*** slaweq has joined #openstack-sdks18:21
elmikomordred: assuming what edleafe says is accurate, that makes entirely too much sense ;)18:27
*** slaweq has quit IRC18:31
*** jkilpatr has joined #openstack-sdks18:33
*** slaweq has joined #openstack-sdks18:34
mordredelmiko, edleafe: yes!18:37
mordredcdent: also ... ^^18:38
cdentmordred: yeah, was just reading through that18:38
mordredcdent: http://eavesdrop.openstack.org/irclogs/%23openstack-sdks/%23openstack-sdks.2018-01-08.log.html#t2018-01-08T17:49:2318:38
mordredoh - good18:38
cdentI've never been a huge fan of link headers, but it does provide a nice solution in this case18:39
*** corey_ has joined #openstack-sdks18:39
mordredin an uncommon fit of things being nice - it's an update that would work for swift as well (GET on a container just returns a list in swift, it does not return a top-level dict, so there is no entity to which a links entity could be added)18:39
cdentmostly because it means the representation needs to carry around the headers with itself to be "complete"18:40
elmikoi don't have a strong opinion about using the headers, but agree this could be a really nice way to solve the issue for consistency's sake18:40
elmikomordred: ooh a unicorn!18:40
mordredcdent: yah18:40
*** cleong has quit IRC18:40
elmikocdent: ah, good point, i hadn't considered that angle18:41
mordredit should also be REALLY easy for people to implement, I'd think - anyone who has a links dict already has the hard bits done, just encoding it and ading it to the headers should be like an afternoon task for an intern18:41
cdenti don't think it being headers is a blocker, just violates my picky aesthetics18:41
edleafecdent: not sure I agree. If the representation is complete now, adding a header will just add a redundancy for compatibility across projects18:41
cdentfrequently the representation is not complete18:42
cdentor at least not consistent, which is how we ended up looking for a different solution18:42
edleafecdent: sure, but how does adding a header change that?18:42
edleafeah, the consistent part is the holy grail18:42
cdentit means we aren't "forcing" the representations to cohere18:42
mordredaren't pagination links temporal in nature anyway? or were you thinking about it in the more general case of links headers for things like a 'server'18:42
edleafecdent: we can't18:42
cdentthus the quotes18:43
cdentlike I said, I'm okay with it.18:43
edleafeOK, new APIs: follow our guides. Existing, non-conformant APIs: add the headers18:43
elmikoseems like pagination in specific is in a little bit of a grey area for the headers/representation issue18:44
edleafeI'm not sure where you see the problem18:44
cdentmordred: I was thinking about the representation passing through various code boundaries, but still being the "now" representation18:44
cdentedleafe: what I just said to mordred: if next is only the headers and not in the json, when it passes from library X to thing Y...18:44
cdentwhich maybe is not something we care about18:44
cdentand is certainly not something worth stopping this good idea over18:45
cdent(merely something to be aware of)18:45
edleafecdent: if it's not in the json, then a project has a choice: change the API, or add a header18:46
edleafethe header thing is a workaround only18:46
cdentright, and if they add the header, then when the client gets a representation the body will, in a sense, be incomplete after it passes away from the part of the system paying attention to headers18:47
cdentwhich may not matter18:47
mordredyah - I mean, the header is a nice thing to add since it's a known thing and even already parsed by things like requests - and is usable for corner cases like listing the objects in a swift container18:48
mordredbut having the links in the json body for new apis is the recommendation for well formed json18:48
edleafeI guess I'm understanding it in reverse. Client checks the body and either a) there are no links or b) the links do not follow the standard. Then, as a last resort, it checks the headers18:48
cdentI gotta go, will check the logs for more, if it happens, but overall, seems a good thing.18:49
*** cdent has quit IRC18:49
mordredoh - I was thinking look for the headers first, since it's an rfc 'standard' thing, and if there are no links there, then look for content in body - at least for things like following pagination18:50
mordredBUT18:50
mordredfor the love of all that is holy, we should DEFINITELY not be ok with the links headers and links in the body being out of sync18:50
mordredso a client could also totally implement it in either direction and be accurate18:50
edleafemordred: from an API-SIG POV, we want to encourage projects to form pagination links correctly in the body18:50
mordredyah18:51
elmiko+118:51
mordredI tihnk we always want links in the body18:51
elmikothe dual header/body issue seems like it could be a total pita if someone try to implement both or gets caught between the two18:51
edleafeif they are there but in the wrong format, they should update it to be correct, but that requires an API break (or microversion)18:51
elmikobut, i like the idea of recommending the rfc for older projects to gain some sort of consistency18:51
edleafeelmiko: yeah, which is why I saw things happening in the order I mentioned18:52
elmikoplus, it seems to me that header addition can be done on minor version bump, so it doesn't need to upset the whole apple cart. is that an accurate asessment?18:52
elmikoedleafe: ack18:52
mordredI don't think the header addition needs a version bump18:52
elmikowell, it should carry a minor version bump to denote the change though, shouldn't it?18:53
mordredthere is NO WAY clients are consuming headers strictly18:53
mordredno - because clients have to account for proxies/api gateways/whatever in between18:53
mordredso there's always the possibilities of more keys being in the header tahn theAPI says will be there18:53
elmikotrue that18:54
mordredso, I mean, people could bump a min, but I don't think it would be valuable to anyone - nor do I think doing a microversion dance to know if you can request a microversion that adds links headers would benefit anyone, since the consumption is "if 'links' in response.headers:"18:55
elmikothat makes sense18:56
elmikoi guess, i tend to think about bumping the version to represent changes. but i think you're absolutely correct about not needing to do the "dance" for this type of feature18:56
*** slaweq has quit IRC19:01
*** slaweq has joined #openstack-sdks19:02
*** slaweq has quit IRC19:06
*** slaweq has joined #openstack-sdks19:09
*** slaweq has quit IRC19:19
*** e0ne has joined #openstack-sdks19:22
*** slaweq has joined #openstack-sdks19:28
*** rabel_b1 has joined #openstack-sdks19:31
*** rabel__b1 has joined #openstack-sdks19:32
*** jkilpatr has quit IRC19:33
openstackgerritMichael Johnson proposed openstack/python-openstacksdk master: Add an octavia functional test gate  https://review.openstack.org/53151419:34
openstackgerritMichael Johnson proposed openstack/python-openstacksdk master: Add an octavia functional test gate  https://review.openstack.org/53151419:35
*** rabel_b1 has quit IRC19:36
openstackgerritMichael Johnson proposed openstack/python-openstacksdk master: Add an octavia functional test gate  https://review.openstack.org/53151419:37
*** e0ne has quit IRC19:40
*** fzdarsky|afk has quit IRC20:00
*** sdague has joined #openstack-sdks20:00
*** jkilpatr has joined #openstack-sdks20:11
*** edmondsw has quit IRC20:26
*** openstack has quit IRC20:38
*** openstack has joined #openstack-sdks20:42
*** ChanServ sets mode: +o openstack20:42
*** openstackgerrit has quit IRC21:03
*** corey_ has quit IRC21:25
*** Anticimex has joined #openstack-sdks21:27
*** rabel__b1 has quit IRC21:28
*** rabel_b1 has joined #openstack-sdks21:28
*** rabel_b1 has quit IRC21:37
mordredelmiko, edleafe: the existing guideline actually already references rfc598821:38
edleafemordred: well, waddya know - guess I should have reviewed that before discussion :)21:44
edleafeSo no change to the guideline is needed for this. Easy!21:46
edleafecdent: elmiko: ^^^21:46
mordrededleafe: :)21:46
mordrededleafe: I'm adding a little text and a sub-heading so that it's easy to deep-link to real quick21:47
*** slaweq has quit IRC21:50
elmikomordred: sweet! thanks for doing all the leg work =)21:51
edleafemordred: yeah, what elmiko said. I'm heads down in other stuff right now21:52
*** openstackgerrit has joined #openstack-sdks21:53
openstackgerritMonty Taylor proposed openstack/api-wg master: Expand note about rfc5988 link header  https://review.openstack.org/53191421:53
*** e0ne has joined #openstack-sdks22:28
openstackgerritMonty Taylor proposed openstack/python-openstacksdk master: Add function to make CloudRegion from session  https://review.openstack.org/53161222:30
openstackgerritMonty Taylor proposed openstack/python-openstacksdk master: Port wait_for_ methods to use iterate_timeout  https://review.openstack.org/53126822:30
openstackgerritMonty Taylor proposed openstack/python-openstacksdk master: Prefer links dicts for pagination  https://review.openstack.org/53076922:30
openstackgerritMichael Johnson proposed openstack/python-openstacksdk master: Add an octavia functional test gate  https://review.openstack.org/53151422:36
*** dave-mccowan has quit IRC22:37
openstackgerritMonty Taylor proposed openstack-infra/shade master: List ansible/ansible in required-projects  https://review.openstack.org/53191922:46
*** e0ne has quit IRC22:49
*** slaweq has joined #openstack-sdks22:58
*** slaweq has quit IRC23:00
openstackgerritMichael Johnson proposed openstack/python-openstacksdk master: Add an octavia functional test gate  https://review.openstack.org/53151423:05
*** bobh has quit IRC23:09
« Sunday, 2018-01-07 Index Tuesday, 2018-01-09 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!