mordred | rods_: I thought you'd like that! | 00:51 |
---|---|---|
*** fabian has joined #openstack-sdks | 01:01 | |
*** fabian is now known as chenyb4 | 01:01 | |
*** slaweq has joined #openstack-sdks | 01:11 | |
*** slaweq has quit IRC | 01:15 | |
openstackgerrit | Nguyen Hung Phuong proposed openstack/service-types-authority master: Remove pbr warnerrors in favor of sphinx check https://review.openstack.org/539810 | 01:21 |
*** pzchen has joined #openstack-sdks | 01:23 | |
*** dave-mccowan has joined #openstack-sdks | 01:42 | |
*** slaweq has joined #openstack-sdks | 01:49 | |
*** salv-orlando has joined #openstack-sdks | 01:50 | |
*** slaweq has quit IRC | 01:53 | |
*** salv-orlando has quit IRC | 01:55 | |
*** yolanda_ has joined #openstack-sdks | 02:06 | |
*** yolanda has quit IRC | 02:07 | |
*** annp has joined #openstack-sdks | 02:26 | |
*** markvoelker has quit IRC | 03:12 | |
*** dave-mccowan has quit IRC | 03:39 | |
*** salv-orlando has joined #openstack-sdks | 03:51 | |
*** salv-orlando has quit IRC | 03:55 | |
*** harlowja_ has quit IRC | 04:09 | |
*** pzchen_ has joined #openstack-sdks | 04:18 | |
*** pzchen has quit IRC | 04:18 | |
*** chenyb4 has quit IRC | 04:18 | |
*** chenyb4 has joined #openstack-sdks | 04:18 | |
*** chenyb4 has quit IRC | 04:51 | |
*** chenyb4 has joined #openstack-sdks | 04:52 | |
*** harlowja has joined #openstack-sdks | 04:56 | |
*** slaweq has joined #openstack-sdks | 05:11 | |
*** markvoelker has joined #openstack-sdks | 05:13 | |
*** slaweq has quit IRC | 05:15 | |
*** thrash is now known as thrash|g0ne | 05:18 | |
*** slaweq has joined #openstack-sdks | 05:41 | |
*** slaweq has quit IRC | 05:46 | |
*** markvoelker has quit IRC | 05:47 | |
*** salv-orlando has joined #openstack-sdks | 05:52 | |
*** salv-orlando has quit IRC | 05:56 | |
*** slaweq has joined #openstack-sdks | 06:32 | |
*** markvoelker has joined #openstack-sdks | 06:44 | |
*** tulivu_ has joined #openstack-sdks | 06:58 | |
*** markvoelker has quit IRC | 07:17 | |
*** yolanda_ has quit IRC | 07:23 | |
*** salv-orlando has joined #openstack-sdks | 07:43 | |
*** jpich has joined #openstack-sdks | 07:51 | |
*** irenab has quit IRC | 07:52 | |
*** irenab has joined #openstack-sdks | 07:53 | |
*** ralonsoh has joined #openstack-sdks | 08:15 | |
*** e0ne has joined #openstack-sdks | 08:23 | |
*** jpena|off is now known as jpena | 08:50 | |
*** kmy has quit IRC | 09:10 | |
*** kmy has joined #openstack-sdks | 09:11 | |
*** markvoelker has joined #openstack-sdks | 09:14 | |
*** markvoelker has quit IRC | 09:48 | |
*** annp has quit IRC | 10:03 | |
*** pzchen_ has quit IRC | 10:24 | |
*** chenyb4 has quit IRC | 10:25 | |
*** tosky has joined #openstack-sdks | 10:38 | |
*** markvoelker has joined #openstack-sdks | 10:45 | |
*** d0ugal has quit IRC | 10:48 | |
*** d0ugal has joined #openstack-sdks | 10:56 | |
*** cdent has joined #openstack-sdks | 10:59 | |
openstackgerrit | Andreas Jaeger proposed openstack/os-client-config master: Add osc tips jobs back https://review.openstack.org/526706 | 11:07 |
openstackgerrit | Andreas Jaeger proposed openstack/keystoneauth master: Remove PYTHONHASHSEED setting https://review.openstack.org/533798 | 11:10 |
*** markvoelker has quit IRC | 11:18 | |
openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Updated from global requirements https://review.openstack.org/540345 | 11:26 |
*** sdague has joined #openstack-sdks | 11:58 | |
*** dtantsur|afk is now known as dtantsur | 11:58 | |
*** jpich has quit IRC | 12:01 | |
*** dave-mccowan has joined #openstack-sdks | 12:06 | |
*** dave-mccowan has quit IRC | 12:11 | |
*** markvoelker has joined #openstack-sdks | 12:16 | |
*** edmondsw has joined #openstack-sdks | 12:17 | |
*** dave-mccowan has joined #openstack-sdks | 12:17 | |
*** reedip has joined #openstack-sdks | 12:22 | |
*** chenyb4 has joined #openstack-sdks | 12:26 | |
openstackgerrit | Merged openstack-infra/shade master: Plumb use-direct-get through factory functions https://review.openstack.org/539586 | 12:27 |
openstackgerrit | Merged openstack-infra/shade master: Fix get_server to work with use_direct_get https://review.openstack.org/539663 | 12:27 |
*** jpena is now known as jpena|lunch | 12:40 | |
*** chenyb4 has quit IRC | 12:41 | |
*** markvoelker has quit IRC | 12:50 | |
openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Update base test case to use base from oslotest https://review.openstack.org/540372 | 13:14 |
openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Update all test base classes to use base.TestCase https://review.openstack.org/540373 | 13:14 |
openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Run examples tests with functional tests https://review.openstack.org/540374 | 13:14 |
*** d0ugal has quit IRC | 13:16 | |
openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Use sdk for list_servers https://review.openstack.org/530770 | 13:16 |
*** d0ugal has joined #openstack-sdks | 13:16 | |
*** d0ugal has quit IRC | 13:16 | |
*** d0ugal has joined #openstack-sdks | 13:16 | |
*** markvoelker has joined #openstack-sdks | 13:24 | |
openstackgerrit | Merged openstack/os-client-config master: Zuul: Remove project name https://review.openstack.org/538901 | 13:28 |
*** salv-orlando has quit IRC | 13:37 | |
*** salv-orlando has joined #openstack-sdks | 13:38 | |
*** salv-orlando has quit IRC | 13:42 | |
*** jpena|lunch is now known as jpena | 13:44 | |
*** jpena is now known as jpena|off | 13:50 | |
openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Use sdk for list_servers https://review.openstack.org/530770 | 14:04 |
openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Fix get_server to work with use_direct_get https://review.openstack.org/540389 | 14:04 |
openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Add all_projects as a preferred alias for all_tenants https://review.openstack.org/540390 | 14:04 |
*** fzdarsky has joined #openstack-sdks | 14:04 | |
*** jpena|off is now known as jpena | 14:05 | |
*** fzdarsky has quit IRC | 14:07 | |
rabel_ | any opinions on https://bugs.launchpad.net/python-openstackclient/+bug/1744349 ? i'd like to implement this, shouldn't be a big deal. just want to hear some opinions before | 14:09 |
openstack | Launchpad bug 1744349 in python-openstackclient "Interface of "quota set" and "quota show" is missleading" [Undecided,New] | 14:09 |
*** edleafe is now known as figleaf | 14:11 | |
*** chenyb4 has joined #openstack-sdks | 14:20 | |
*** salv-orlando has joined #openstack-sdks | 14:39 | |
*** salv-orlando has quit IRC | 14:43 | |
openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Remove support for arbitrary attributes from CloudRegion https://review.openstack.org/540406 | 14:52 |
openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Update all test base classes to use base.TestCase https://review.openstack.org/540373 | 14:59 |
openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Run examples tests with functional tests https://review.openstack.org/540374 | 14:59 |
openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Re-enable orchestration functional tests https://review.openstack.org/540412 | 14:59 |
*** bobh has joined #openstack-sdks | 15:01 | |
*** zacksh_ is now known as zacksh | 15:01 | |
*** zacksh has quit IRC | 15:01 | |
*** zacksh has joined #openstack-sdks | 15:02 | |
*** salv-orlando has joined #openstack-sdks | 15:09 | |
*** chenyb4 has quit IRC | 15:23 | |
rods_ | mordred amazing work on https://review.openstack.org/#/c/540169/1, left two very minor comments | 15:32 |
mordred | rods_: awesome - thanks for reading through that! | 15:32 |
mordred | rods_: those are great feedback- thanks | 15:38 |
*** slaweq has quit IRC | 15:47 | |
*** salv-orlando has quit IRC | 15:59 | |
*** salv-orlando has joined #openstack-sdks | 15:59 | |
*** salv-orlando has quit IRC | 16:01 | |
*** salv-orlando has joined #openstack-sdks | 16:01 | |
*** tulivu_ has quit IRC | 16:06 | |
openstackgerrit | James E. Blair proposed openstack/openstackclient master: Zuul: Remove project name https://review.openstack.org/540433 | 16:10 |
*** dmellado has quit IRC | 16:11 | |
*** dmellado has joined #openstack-sdks | 16:14 | |
*** slaweq has joined #openstack-sdks | 16:51 | |
*** e0ne has quit IRC | 16:57 | |
*** slaweq has quit IRC | 16:59 | |
*** slaweq has joined #openstack-sdks | 17:01 | |
*** slaweq has quit IRC | 17:32 | |
*** dmellado has quit IRC | 17:34 | |
*** harlowja has quit IRC | 17:37 | |
Shrews | mordred: your proxy change is next on my todo list after lunch | 17:37 |
*** jpena is now known as jpena|off | 17:38 | |
mordred | Shrews: awesome! rods liked it. oh- I fixed it from his reviews ... | 18:02 |
openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Generate proxy methods from resource objects https://review.openstack.org/540169 | 18:06 |
mordred | rods_: ^^ updated per your comments | 18:10 |
rods_ | mordred looking | 18:10 |
*** harlowja has joined #openstack-sdks | 18:21 | |
*** dtantsur is now known as dtantsur|afk | 18:23 | |
*** tosky has quit IRC | 18:25 | |
*** ralonsoh has quit IRC | 18:30 | |
openstackgerrit | Merged openstack/openstackclient master: Zuul: Remove project name https://review.openstack.org/540433 | 18:31 |
openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Use instance.get_interface instead of instance.interface https://review.openstack.org/540481 | 18:33 |
openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Remove support for arbitrary attributes from CloudRegion https://review.openstack.org/540406 | 18:33 |
*** dmellado has joined #openstack-sdks | 18:35 | |
rods_ | mordred https://review.openstack.org/#/c/540169/2 LGTM | 18:42 |
mordred | rods_: woot | 18:42 |
rods_ | mordred if we decide that ^^ is a viable solution, I'd be happy to help updating the other Services | 18:43 |
*** cdent has quit IRC | 18:49 | |
*** sdague has quit IRC | 19:19 | |
*** sdague has joined #openstack-sdks | 19:24 | |
Shrews | mordred: comment left for you on 540169 | 20:19 |
Shrews | mordred: oh! i'm stupid. the value *is* the return of that. duh | 20:20 |
Shrews | nm | 20:20 |
Shrews | mordred: but perhaps we should set the default to False? | 20:21 |
Shrews | or would you rather an exception be raised if one of the allow_* attrs are missing? | 20:21 |
*** salv-orlando has quit IRC | 20:28 | |
*** salv-orlando has joined #openstack-sdks | 20:28 | |
Shrews | I'm going to assume that's the behavior you want. LGTM otherwise. +3 | 20:32 |
*** salv-orlando has quit IRC | 20:33 | |
mordred | Shrews: well - it is defaulted in the base Resource class: http://git.openstack.org/cgit/openstack/python-openstacksdk/tree/openstack/resource.py#n298 | 20:58 |
mordred | Shrews: but yes - if something is missing there it's a pretty fundamental internal programming error - and everything should come crashing to a halt because ZOMG everything is terrible | 20:59 |
*** dave-mccowan has quit IRC | 21:04 | |
openstackgerrit | Hongbin Lu proposed openstack/python-openstackclient master: [WIP] Add option '--mtu' to network create/update https://review.openstack.org/540530 | 21:07 |
*** dave-mccowan has joined #openstack-sdks | 21:17 | |
*** e0ne has joined #openstack-sdks | 21:17 | |
*** dave-mccowan has quit IRC | 21:24 | |
openstackgerrit | Hongbin Lu proposed openstack/python-openstackclient master: Add option '--mtu' to network create/set https://review.openstack.org/540530 | 21:28 |
*** salv-orlando has joined #openstack-sdks | 21:29 | |
*** salv-orlando has quit IRC | 21:33 | |
Shrews | mordred: so it is! apologies | 21:40 |
*** dave-mccowan has joined #openstack-sdks | 21:52 | |
openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Fix issue with url parameter strictness and OSC https://review.openstack.org/540537 | 21:55 |
*** e0ne has quit IRC | 21:58 | |
openstackgerrit | Hongbin Lu proposed openstack/python-openstackclient master: Disallow setting default on internal network https://review.openstack.org/539303 | 22:00 |
*** dave-mccowan has quit IRC | 22:03 | |
openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Stop sending tenant_id to sdk network list https://review.openstack.org/540539 | 22:06 |
openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Make Profile fallback go bye-bye https://review.openstack.org/540541 | 22:15 |
*** salv-orlando has joined #openstack-sdks | 22:31 | |
*** slaweq has joined #openstack-sdks | 22:32 | |
*** salv-orlando has quit IRC | 22:36 | |
*** madorn has quit IRC | 22:41 | |
*** madorn has joined #openstack-sdks | 22:43 | |
*** figleaf is now known as edleafe | 22:58 | |
*** edmondsw has quit IRC | 23:09 | |
openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Stop sending tenant_id to sdk network list https://review.openstack.org/540539 | 23:16 |
*** bobh has quit IRC | 23:22 | |
openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Fix issue with missing url parameters https://review.openstack.org/540537 | 23:26 |
openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Don't look for ResourceNotFound string in test https://review.openstack.org/540539 | 23:28 |
*** slaweq has quit IRC | 23:29 | |
*** salv-orlando has joined #openstack-sdks | 23:37 | |
openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Don't look for ResourceNotFound string in test https://review.openstack.org/540539 | 23:37 |
openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Make Profile fallback go bye-bye https://review.openstack.org/540541 | 23:37 |
openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Make osc-functional-devstack-tips actually use tips https://review.openstack.org/540554 | 23:37 |
mordred | dtroyer: guess what? The osc-functional-devstack-tips job? that I thought was showing us that we were ok on the devstack/sdk interactions? | 23:38 |
mordred | dtroyer: ^^ 540554 fixes it to ACTUALLY test against tips - it was very happily testing against the previously released verisons of things | 23:38 |
mordred | *headdesk* | 23:38 |
mordred | dtroyer: in any case - the carnage is surprisingly small considering the number of changes involved in this last release - I think with the one patch i've got up to sdk that's pretty small and one up for osc (which is just updating a test that was looking for a string that changed) | 23:40 |
mordred | and we'll be good to go | 23:40 |
mordred | dtroyer: I was really starting to lose my mind ... why are we seeing osc tips jobs be red NOW but they were green when we landed the changes | 23:41 |
openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Gate on osc-functional-tips https://review.openstack.org/540556 | 23:43 |
mordred | dtroyer: ^^ and that will turn that job to gating on sdk - not that we've landed any breaking changes due to ignoring it non-voting ... but let's be extra sure | 23:44 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!