adriant | not that gophercloud is your problem, but we potentially should as part of... that SDKs initiative that was started in Sydney try and have a reference spec for Auth across all libraries, and write something to help test that. | 00:02 |
---|---|---|
adriant | What was that initiative called? Am I misremembering something? OpenLabs or something? | 00:03 |
adriant | mrhillsman: You might be the person to bug about this! | 00:04 |
adriant | mrhillsman: ^ the above | 00:05 |
*** dave-mccowan has quit IRC | 00:10 | |
*** salv-orlando has joined #openstack-sdks | 00:24 | |
mrhillsman | just getting notification, reading | 00:26 |
mrhillsman | yes adriant you are absolutely right | 00:28 |
mrhillsman | not just auth but i spoke with mordred i think or maybe someone else about reference spec(s) for a number of "this is how x should work across all libraries" thing | 00:29 |
*** salv-orlando has quit IRC | 00:29 | |
adriant | mrhillsman: yeah, we really do. I keep running into weird inconsistencies and it drives me mad :( | 00:31 |
mrhillsman | that ^ | 00:32 |
adriant | like terraform expects OS_AUTH_TOKEN while we've been using OS_TOKEN for ages | 00:33 |
adriant | and I can't find the terraform code or gophercloud where that is even being read in... | 00:33 |
adriant | At this point I assume os-client-config is the reference implementation, and everyone 'should' be based on that when it comes to auth and source variables and such | 00:34 |
mrhillsman | https://github.com/gophercloud/gophercloud/blob/master/openstack/auth_env.go | 00:37 |
adriant | mrhillsman: no token in there though | 00:38 |
adriant | terraform supports token auth with OS_AUTH_TOKEN so it has to exist somewhere | 00:39 |
mrhillsman | ah, i think i understand you now | 00:40 |
adriant | mrhillsman: or in today's case, os-client-config supports token in clouds.yaml, but gophercloud doesn't :P | 00:42 |
mrhillsman | ^ that might be the actual case | 00:43 |
adriant | well, sort of. It's both. Ideally terraform/gopherclouds should use both OS_TOKEN and OS_AUTH_TOKEN and try and deprecate the latter, and then ALSO should add token support to clouds.yaml | 00:44 |
mrhillsman | hmm. well, it says it does (terraform provider at least documents it) | 00:44 |
adriant | mrhillsman: https://www.terraform.io/docs/providers/openstack/#token | 00:45 |
adriant | just through OS_AUTH_TOKEN | 00:45 |
mrhillsman | ++ | 00:46 |
* mrhillsman missed the absence _AUTH_ | 00:47 | |
mrhillsman | the good thing is that jtopjian and in general the gophercloud folks are very responsive | 00:48 |
mrhillsman | and i do not think if you opened an issue it would take long to resolve | 00:48 |
mrhillsman | seems like a if you get one or the other do these things | 00:48 |
mrhillsman | unless there is something else offered by one vs the other | 00:49 |
*** chenyb4 has joined #openstack-sdks | 00:51 | |
*** harlowja has quit IRC | 00:53 | |
mrhillsman | i'm creating an issue adriant | 00:55 |
mrhillsman | is ^ your github username? | 00:55 |
adriant | mrhillsman: adrian-turjak | 00:56 |
mrhillsman | thx | 00:56 |
adriant | mrhillsman: coworker already also opened: https://github.com/gophercloud/utils/issues/25 | 00:56 |
mrhillsman | cool | 01:02 |
adriant | hmmmm | 01:02 |
mrhillsman | i think that repo is only for figuring out if client config is being used and if so grab it | 01:02 |
adriant | mrhillsman: I've just realised something | 01:03 |
adriant | mrhillsman: https://github.com/terraform-providers/terraform-provider-openstack/blob/master/openstack/provider.go#L72-L77 | 01:03 |
adriant | the OS_AUTH_TOKEN is in the provider code. I was silly and looking in the wrong place | 01:03 |
adriant | but now I'm wondering, does that provider use gophercloud or write it's own stuff? | 01:04 |
adriant | I assumed (probably incorrectly) that it did | 01:04 |
mrhillsman | it uses gophercloud | 01:04 |
adriant | ok, then I'm not entirely mad | 01:04 |
mrhillsman | so you see the section right below that one | 01:04 |
mrhillsman | basically, the section you referenced would turn into multi like the one below | 01:04 |
mrhillsman | and OS_TOKEN as an option | 01:05 |
mrhillsman | and then - if i understand right - gophercloud needs to do the same essentially | 01:05 |
adriant | mrhillsman: so easy fix in the provide then | 01:05 |
adriant | provider* | 01:05 |
mrhillsman | for the provider yeah | 01:05 |
mrhillsman | looks like | 01:06 |
adriant | and that shouldn't need a change in gophercloud | 01:06 |
adriant | although we do want to add better clouds.yaml support there too | 01:07 |
mrhillsman | https://github.com/gophercloud/gophercloud/blob/master/auth_options.go | 01:07 |
mrhillsman | well, gophercloud will need to change | 01:07 |
*** annp has quit IRC | 01:10 | |
adriant | although on the auth front... I have to apologise in advance because I'm probably going to end up adding a lot of extra complexity once https://review.openstack.org/#/c/553670 is merged and implemented | 01:11 |
adriant | mordred: ^ don't hate me too much :P | 01:11 |
*** annp has joined #openstack-sdks | 01:11 | |
adriant | but we need a much much better way of doing multi-method auth across all of OpenStack | 01:11 |
*** salv-orlando has joined #openstack-sdks | 01:25 | |
*** salv-orlando has quit IRC | 01:29 | |
*** thrash is now known as thrash|g0ne | 01:45 | |
*** lei-zh has joined #openstack-sdks | 01:50 | |
*** lei-zh has quit IRC | 01:51 | |
*** lei-zh has joined #openstack-sdks | 01:51 | |
*** bobh has quit IRC | 02:10 | |
*** rwellum has joined #openstack-sdks | 02:11 | |
*** dave-mccowan has joined #openstack-sdks | 02:14 | |
*** salv-orlando has joined #openstack-sdks | 02:25 | |
*** salv-orlando has quit IRC | 02:30 | |
*** lei-zh has quit IRC | 02:31 | |
*** lei-zh has joined #openstack-sdks | 02:42 | |
*** kmy has quit IRC | 03:21 | |
*** kmy has joined #openstack-sdks | 03:21 | |
*** salv-orlando has joined #openstack-sdks | 03:26 | |
*** salv-orlando has quit IRC | 03:31 | |
*** dave-mccowan has quit IRC | 03:49 | |
*** lei-zh has quit IRC | 03:53 | |
*** annp has quit IRC | 04:26 | |
*** salv-orlando has joined #openstack-sdks | 04:27 | |
*** markvoelker has quit IRC | 04:27 | |
*** salv-orlando has quit IRC | 04:32 | |
*** salv-orlando has joined #openstack-sdks | 05:15 | |
*** markvoelker has joined #openstack-sdks | 05:28 | |
*** lei-zh has joined #openstack-sdks | 05:31 | |
*** lei-zh has quit IRC | 05:49 | |
*** lei-zh has joined #openstack-sdks | 05:50 | |
*** annp has joined #openstack-sdks | 06:12 | |
*** gildub has quit IRC | 06:35 | |
*** gildub has joined #openstack-sdks | 07:18 | |
*** cdent has joined #openstack-sdks | 07:29 | |
*** Qiming_ has joined #openstack-sdks | 07:34 | |
*** Qiming has quit IRC | 07:35 | |
*** salv-orlando has quit IRC | 07:36 | |
*** salv-orlando has joined #openstack-sdks | 07:37 | |
*** salv-orlando has quit IRC | 07:42 | |
*** dims_ has joined #openstack-sdks | 07:48 | |
*** dims has quit IRC | 07:49 | |
*** ralonsoh has joined #openstack-sdks | 07:53 | |
*** gkadam has joined #openstack-sdks | 07:55 | |
*** pooja_jadhav has quit IRC | 07:57 | |
*** pooja_jadhav has joined #openstack-sdks | 07:57 | |
*** salv-orlando has joined #openstack-sdks | 08:04 | |
*** jpich has joined #openstack-sdks | 08:05 | |
*** e0ne has joined #openstack-sdks | 08:09 | |
*** gildub has quit IRC | 08:35 | |
*** gildub has joined #openstack-sdks | 08:36 | |
*** gkadam_ has joined #openstack-sdks | 08:37 | |
*** gkadam has quit IRC | 08:39 | |
*** gkadam_ has quit IRC | 08:42 | |
*** gkadam_ has joined #openstack-sdks | 08:42 | |
openstackgerrit | Romain Acciari proposed openstack-infra/shade master: create_subnet: Add filter on tenant_id if specified https://review.openstack.org/556782 | 08:44 |
*** e0ne has quit IRC | 09:05 | |
*** e0ne has joined #openstack-sdks | 09:05 | |
*** gildub has quit IRC | 09:39 | |
*** sdague has joined #openstack-sdks | 09:51 | |
*** gildub has joined #openstack-sdks | 09:57 | |
*** gkadam__ has joined #openstack-sdks | 10:03 | |
*** gkadam has joined #openstack-sdks | 10:06 | |
*** gkadam_ has quit IRC | 10:07 | |
*** gkadam__ has quit IRC | 10:08 | |
*** gkadam has quit IRC | 10:32 | |
*** chenyb4 has quit IRC | 10:32 | |
*** lei-zh has quit IRC | 10:33 | |
*** gkadam has joined #openstack-sdks | 10:35 | |
*** e0ne has quit IRC | 10:43 | |
*** e0ne has joined #openstack-sdks | 10:43 | |
*** e0ne has quit IRC | 10:53 | |
*** e0ne has joined #openstack-sdks | 11:09 | |
*** gildub has quit IRC | 11:24 | |
*** openstackgerrit has quit IRC | 11:33 | |
*** dtantsur|afk is now known as dtantsur | 11:34 | |
*** bobh has joined #openstack-sdks | 12:03 | |
*** bobh has quit IRC | 12:10 | |
*** edmondsw has joined #openstack-sdks | 12:13 | |
*** thrash|g0ne is now known as thrash | 12:20 | |
*** markvoelker has quit IRC | 12:28 | |
*** markvoelker has joined #openstack-sdks | 12:28 | |
*** chenyb4 has joined #openstack-sdks | 12:34 | |
*** dave-mccowan has joined #openstack-sdks | 12:40 | |
*** kmy has quit IRC | 12:46 | |
*** openstackgerrit has joined #openstack-sdks | 12:57 | |
openstackgerrit | Romain Acciari proposed openstack-infra/shade master: create_subnet: Add filter on tenant_id if specified https://review.openstack.org/556782 | 12:57 |
*** bobh has joined #openstack-sdks | 13:06 | |
*** jamielennox has quit IRC | 14:01 | |
*** jamielennox has joined #openstack-sdks | 14:02 | |
*** chenyb4 has quit IRC | 14:12 | |
*** dayou has quit IRC | 14:23 | |
*** gkadam_ has joined #openstack-sdks | 14:36 | |
*** dayou has joined #openstack-sdks | 14:38 | |
*** gkadam has quit IRC | 14:38 | |
openstackgerrit | Merged openstack/openstacksdk master: add lower-constraints job https://review.openstack.org/556173 | 15:00 |
*** thrash is now known as thrash|biab | 15:15 | |
*** e0ne has quit IRC | 15:45 | |
*** thrash|biab is now known as thrash | 15:45 | |
*** ralonsoh has quit IRC | 15:57 | |
*** dave-mccowan has quit IRC | 16:10 | |
*** bobh has quit IRC | 16:29 | |
*** jpich has quit IRC | 16:43 | |
*** dave-mccowan has joined #openstack-sdks | 16:56 | |
*** christi3k has quit IRC | 16:58 | |
*** bobh has joined #openstack-sdks | 16:59 | |
*** gkadam_ has quit IRC | 17:00 | |
*** bobh has quit IRC | 17:01 | |
*** bobh has joined #openstack-sdks | 17:01 | |
*** dave-mccowan has quit IRC | 17:19 | |
*** dave-mccowan has joined #openstack-sdks | 17:34 | |
*** dtantsur is now known as dtantsur|afk | 18:25 | |
*** harlowja has joined #openstack-sdks | 19:34 | |
*** e0ne has joined #openstack-sdks | 19:38 | |
*** edmondsw has quit IRC | 19:58 | |
*** edmondsw has joined #openstack-sdks | 19:59 | |
*** bobh has quit IRC | 20:00 | |
*** edmondsw_ has joined #openstack-sdks | 20:01 | |
*** edmondsw has quit IRC | 20:04 | |
*** edmondsw_ has quit IRC | 20:04 | |
*** edmondsw has joined #openstack-sdks | 20:04 | |
*** edmondsw has quit IRC | 20:04 | |
*** bobh has joined #openstack-sdks | 20:06 | |
*** olivierbourdon38 has quit IRC | 20:46 | |
*** olivierbourdon38 has joined #openstack-sdks | 20:46 | |
*** edmondsw has joined #openstack-sdks | 20:59 | |
*** edmondsw_ has joined #openstack-sdks | 21:00 | |
*** dave-mccowan has quit IRC | 21:01 | |
*** edmondsw has quit IRC | 21:04 | |
*** edmondsw_ has quit IRC | 21:05 | |
*** salv-orl_ has joined #openstack-sdks | 21:06 | |
*** salv-orlando has quit IRC | 21:06 | |
*** edmondsw has joined #openstack-sdks | 21:35 | |
*** edmondsw has quit IRC | 21:36 | |
openstackgerrit | Hongbin Lu proposed openstack/python-openstackclient master: Disallow setting default on internal network https://review.openstack.org/539303 | 21:41 |
openstackgerrit | Hongbin Lu proposed openstack/python-openstackclient master: Add option '--mtu' to network create/set https://review.openstack.org/540530 | 21:41 |
*** cdent has quit IRC | 21:42 | |
*** e0ne has quit IRC | 21:49 | |
*** salv-orl_ has quit IRC | 22:01 | |
*** salv-orlando has joined #openstack-sdks | 22:01 | |
*** thrash is now known as thrash|g0ne | 22:03 | |
*** salv-orlando has quit IRC | 22:06 | |
*** lbragstad has quit IRC | 22:15 | |
*** bobh has quit IRC | 22:18 | |
*** bobh has joined #openstack-sdks | 22:18 | |
*** bobh has quit IRC | 22:23 | |
*** yolanda has quit IRC | 22:25 | |
*** yolanda has joined #openstack-sdks | 22:27 | |
*** dayou has quit IRC | 22:30 | |
*** lbragstad has joined #openstack-sdks | 22:32 | |
*** lbragstad has quit IRC | 22:32 | |
*** salv-orlando has joined #openstack-sdks | 23:02 | |
*** dayou has joined #openstack-sdks | 23:08 | |
*** salv-orlando has quit IRC | 23:08 | |
*** harlowja has quit IRC | 23:32 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!