*** edmondsw has joined #openstack-sdks | 00:27 | |
*** edmondsw has quit IRC | 00:32 | |
*** harlowja has quit IRC | 00:46 | |
*** slaweq has joined #openstack-sdks | 00:56 | |
*** slaweq has quit IRC | 01:01 | |
*** dave-mccowan has quit IRC | 01:01 | |
*** mhen has quit IRC | 01:10 | |
*** mhen has joined #openstack-sdks | 01:15 | |
*** dave-mccowan has joined #openstack-sdks | 01:26 | |
*** olaph has quit IRC | 01:39 | |
*** olaph has joined #openstack-sdks | 01:39 | |
*** dave-mccowan has quit IRC | 01:47 | |
openstackgerrit | Dongcan Ye proposed openstack/python-openstackclient master: Fix functional job failed https://review.openstack.org/562345 | 01:49 |
---|---|---|
*** olaph1 has joined #openstack-sdks | 01:50 | |
*** olaph has quit IRC | 01:51 | |
*** bobh has joined #openstack-sdks | 01:56 | |
*** salv-orl_ has joined #openstack-sdks | 01:58 | |
*** salv-orl_ has quit IRC | 02:00 | |
*** salv-orlando has quit IRC | 02:01 | |
*** edmondsw has joined #openstack-sdks | 02:15 | |
*** edmondsw has quit IRC | 02:20 | |
*** slaweq has joined #openstack-sdks | 02:57 | |
*** slaweq has quit IRC | 03:02 | |
*** bobh has quit IRC | 03:04 | |
openstackgerrit | Kiseok Kim proposed openstack/openstacksdk master: Fix typo in README.rst https://review.openstack.org/562916 | 03:06 |
adriant | mordred, dtroyer_zz: Are we moving the openstackclient to only use the SDK? I heard murmurings about that, but was curious how far along it got. | 03:20 |
adriant | I ask because I know the openstackclient uses some weird Swift layer that is unique to itself and part of me is very very tempted to replace that with the SDK because the openstackclient still lacks features that the swift-cli has. | 03:21 |
adriant | and I really want to stop telling people they have to use the swift client... | 03:21 |
adriant | lets be honest, I want to stop using the swift client :P | 03:21 |
*** bobh has joined #openstack-sdks | 03:22 | |
*** bobh has quit IRC | 03:23 | |
*** bobh has joined #openstack-sdks | 03:23 | |
*** bobh has quit IRC | 03:28 | |
*** annp has quit IRC | 03:54 | |
*** annp has joined #openstack-sdks | 03:55 | |
*** shu-mutow has joined #openstack-sdks | 04:14 | |
*** slaweq has joined #openstack-sdks | 04:58 | |
*** slaweq has quit IRC | 05:03 | |
*** salv-orlando has joined #openstack-sdks | 05:11 | |
*** e0ne has joined #openstack-sdks | 05:23 | |
*** slaweq has joined #openstack-sdks | 06:00 | |
*** slaweq has quit IRC | 06:04 | |
*** e0ne has quit IRC | 06:18 | |
openstackgerrit | Lingxian Kong proposed openstack/openstackclient master: Add python-qinlingclient to zuul job https://review.openstack.org/562949 | 06:42 |
*** kimamisa has joined #openstack-sdks | 07:16 | |
*** ralonsoh has joined #openstack-sdks | 07:19 | |
*** slaweq has joined #openstack-sdks | 07:31 | |
*** jpich has joined #openstack-sdks | 07:50 | |
*** jpena|off is now known as jpena | 08:00 | |
*** e0ne has joined #openstack-sdks | 08:19 | |
*** gkadam has joined #openstack-sdks | 08:30 | |
*** shu-mutow is now known as shu-mutow-AWAY | 08:46 | |
*** dayou has quit IRC | 09:09 | |
*** dayou has joined #openstack-sdks | 09:11 | |
*** sdague has joined #openstack-sdks | 09:28 | |
*** rcarrillocruz has joined #openstack-sdks | 09:40 | |
*** salv-orlando has quit IRC | 09:43 | |
*** salv-orlando has joined #openstack-sdks | 09:46 | |
*** cdent has joined #openstack-sdks | 10:00 | |
*** ralonsoh_ has joined #openstack-sdks | 10:01 | |
openstackgerrit | Tovin Seven proposed openstack/openstackclient master: Trivial: Update pypi url to new url https://review.openstack.org/563032 | 10:04 |
*** ralonsoh has quit IRC | 10:05 | |
openstackgerrit | Tovin Seven proposed openstack/osc-lib master: Trivial: Update pypi url to new url https://review.openstack.org/563033 | 10:05 |
openstackgerrit | Sergey Skripnick proposed openstack/openstacksdk master: Heat files parameter https://review.openstack.org/563035 | 10:08 |
*** ralonsoh__ has joined #openstack-sdks | 10:10 | |
*** ralonsoh_ has quit IRC | 10:14 | |
openstackgerrit | Tovin Seven proposed openstack/python-openstackclient master: Trivial: Update pypi url to new url https://review.openstack.org/563062 | 10:23 |
*** heatuser has joined #openstack-sdks | 10:25 | |
*** markvoelker has quit IRC | 10:30 | |
*** markvoelker has joined #openstack-sdks | 10:30 | |
*** markvoelker has quit IRC | 10:35 | |
*** olaph has joined #openstack-sdks | 10:52 | |
*** olaph1 has quit IRC | 10:54 | |
*** olaph1 has joined #openstack-sdks | 11:05 | |
*** olaph has quit IRC | 11:07 | |
*** alex_xu has quit IRC | 11:14 | |
*** alex_xu has joined #openstack-sdks | 11:19 | |
*** alex_xu has quit IRC | 11:23 | |
*** alex_xu has joined #openstack-sdks | 11:29 | |
cdent | edleafe, elmiko, dtantsur|pto : I've asked for a single day at the PTG (again). Seemed to work well last time. | 11:39 |
*** mhen has left #openstack-sdks | 12:00 | |
*** annp has quit IRC | 12:02 | |
*** kimamisa has quit IRC | 12:02 | |
*** markvoelker has joined #openstack-sdks | 12:02 | |
*** thrash|g0ne is now known as thrash | 12:05 | |
*** kimamisa has joined #openstack-sdks | 12:26 | |
*** stephenfin is now known as finucannot | 12:28 | |
*** cdent has quit IRC | 12:32 | |
*** olaph has joined #openstack-sdks | 12:35 | |
*** olaph1 has quit IRC | 12:36 | |
*** heatuser has quit IRC | 12:38 | |
*** olaph1 has joined #openstack-sdks | 12:49 | |
*** olaph has quit IRC | 12:50 | |
pooja_jadhav | cdent: Hi | 12:53 |
*** edleafe is now known as figleaf | 12:56 | |
*** olaph1 is now known as olaph | 12:57 | |
*** kimamisa has quit IRC | 12:57 | |
*** edmondsw has joined #openstack-sdks | 13:05 | |
*** dave-mccowan has joined #openstack-sdks | 13:07 | |
*** edmondsw has quit IRC | 13:10 | |
*** cdent has joined #openstack-sdks | 13:15 | |
*** kimamisa has joined #openstack-sdks | 13:28 | |
openstackgerrit | Merged openstack/osc-lib master: Trivial: Update pypi url to new url https://review.openstack.org/563033 | 13:39 |
pooja_jadhav | cdent : Hi | 13:40 |
cdent | hi pooja_jadhav | 13:40 |
pooja_jadhav | cdent: Want to dicuss about split logger | 13:41 |
openstackgerrit | Merged openstack/openstackclient master: Trivial: Update pypi url to new url https://review.openstack.org/563032 | 13:41 |
*** olaph1 has joined #openstack-sdks | 13:42 | |
*** olaph has quit IRC | 13:43 | |
pooja_jadhav | cdent: Actually, for testing purpose of split logger, I want to test nova cinder interaction. So put _SESSION._split_loggers = True after line https://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L86 | 13:43 |
cdent | pooja_jadhav: sorry, I'm not sure I know what you're talking about. I don't have a memory of talking about split logger. | 13:43 |
openstackgerrit | Merged openstack/python-openstackclient master: Trivial: Update pypi url to new url https://review.openstack.org/563062 | 13:43 |
pooja_jadhav | cdent: https://review.openstack.org/#/c/505764 | 13:45 |
pooja_jadhav | cdent: want to dicuss about this above patch Monty has proposed and merged into master branch | 13:46 |
cdent | pooja_jadhav: oh that, yeah, I don't really know much about that. mordred might but he's at a conference right now | 13:46 |
pooja_jadhav | cdent: Ohk... I have ping him several times, but haven't got rly :( | 13:47 |
pooja_jadhav | cdent: Who else can help me in this | 13:48 |
pooja_jadhav | ?? | 13:48 |
cdent | I can talking with you about it, but it will mostly be you explaining what you're trying to do to me, and maybe as part of that things will be more clear | 13:49 |
pooja_jadhav | cdent: Actually, I am facing issue while using split logger parameter in nova-cinder interaction. | 13:49 |
pooja_jadhav | cdent: i will tell you what i am trying to do. | 13:50 |
pooja_jadhav | cdent: after line https://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L86.. i am setting _SESSION._split_loggers = True just for time being testing. | 13:50 |
pooja_jadhav | so when request goes from nova to cinder ( i should request into see split logging) as passed split_logger = True | 13:51 |
pooja_jadhav | cdent: But the code in keystoneauth at line https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L613-L617 is making split_logger = False if logger is already passed. and because of this request-ids are not getting logged | 13:53 |
cdent | I think instead of doing _SESSION._split_loggers = True after that call you instead need to pass split_loggers=True in the call to load_session_from_conf_options | 13:53 |
cdent | does that make any difference | 13:53 |
pooja_jadhav | but this load_session_from_conf_options method dont have this parameter | 13:54 |
pooja_jadhav | how can I pass that split_logger to load_session_from_conf_options | 13:55 |
cdent | pooja_jadhav: from what I can tell load_session_from_conf_options takes kwargs: | 13:56 |
cdent | https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/loading/session.py#L246 | 13:57 |
pooja_jadhav | ok | 13:57 |
*** dims has quit IRC | 13:58 | |
pooja_jadhav | but the issue is, logger is getting passed from some where | 14:00 |
pooja_jadhav | and that if condition in keystoneauth at line https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L613-L617 making split_logger to False | 14:00 |
*** mnaser has quit IRC | 14:00 | |
*** mnaser has joined #openstack-sdks | 14:01 | |
pooja_jadhav | so it only logs (request, response and response body) except request-id | 14:02 |
*** dims has joined #openstack-sdks | 14:04 | |
openstackgerrit | Mário Santos proposed openstack-infra/shade master: Adds kwargs support when creating a Neutron subnet https://review.openstack.org/563134 | 14:05 |
cdent | sorry pooja_jadhav got distracted for a moment, re-reading | 14:09 |
pooja_jadhav | no issue | 14:09 |
cdent | Based on what you are saying I think you've found a bug. | 14:10 |
cdent | if you can't find mordred, you might try speaking with cmurphy or lbragstad ? | 14:12 |
cdent | If you're able to come up with a minimal test case that demostrates the problem, that would probably be useful too | 14:12 |
cmurphy | kmalloc might also be able to help with that | 14:14 |
cmurphy | I can try but would have to refresh my memory a bit | 14:14 |
pooja_jadhav | ok | 14:16 |
pooja_jadhav | in keystonenauth, in def request()- if logger is passed then split_logger sets to False, and because of this request-ids are not getting logged | 14:17 |
pooja_jadhav | In my opion also, it a bug | 14:17 |
pooja_jadhav | My aim is to use split_logger functionality wherever keystoneauth session is getting used. | 14:18 |
pooja_jadhav | I already had discussion with kmalloc | 14:19 |
cmurphy | pooja_jadhav: I think if a logger is passed then that indicates you only want to use one logger, ie the one that you passed, and so splitting loggers wouldn't make sense | 14:20 |
pooja_jadhav | cmurphy: ohk, But I am able to see (3 parts of request in splits like(keystoneauth.session.request, keystoneauth.session.response, keystoneauth.session.body) | 14:22 |
pooja_jadhav | cmurphy: Only the part I am not able to see is keystoneauth.session.request-id | 14:23 |
cmurphy | pooja_jadhav: so you think something around here is going wrong? https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L772-L775 | 14:26 |
pooja_jadhav | cmurphy: yes | 14:26 |
pooja_jadhav | cmurphy: Split_logger is getting as False and because of that request-is is not get logged. | 14:27 |
dtroyer_zz | adriant: it has been the plan for OSC to use the SDK once it has a 1.0 release since the SDK was started. We relented on the 1.0 for Network in order to not add the neutronclient dependency and other reasons, and it has been painful as the SDK has made at least two changes we have been required to work around and handle multiple SDK versions for. | 14:28 |
cmurphy | pooja_jadhav: you said you're passing in a logger and that's why it's getting set to false, can you not pass in a logger? | 14:29 |
dtroyer_zz | The api.object layer in OSC was largely lifted from swiftclient since swiftclient was still only available in the swift repo at the time. I put it into the form I was proposing for a low-level SDK that was subsequently not merged. and it has sat there ever since waiting for the SDK 1.0 as explained above | 14:30 |
dtroyer_zz | so yes, once we have an SDK 1.0 folks can go nuts converting commands to use it, with adequate compatibility testing in place | 14:31 |
pooja_jadhav | pooja_jadhav: in cinder client they are getting logger, I have comment out that code, i am able to see request-ids but, it will solve only for cinder client. | 14:32 |
pooja_jadhav | cmurphy: in cinder client they are getting logger, I have comment out that code, i am able to see request-ids but, it will solve only for cinder client. | 14:32 |
pooja_jadhav | cmurphy: at line https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v3/client.py#L115-L116 | 14:33 |
pooja_jadhav | cmuphy: IMO, we should fix at central place so that, i will solve for all other services issue | 14:34 |
pooja_jadhav | cmuphy: But still Not clear how to fix at keystoneauth. | 14:34 |
cmurphy | pooja_jadhav: I don't really agree, I think any client that want to opt into using the split loggers should be explicit about it by setting split_loggers to true and stopping passing in its own logger | 14:35 |
pooja_jadhav | cmurphy: Ohk, I will try to fix that in cinder client then, | 14:37 |
cmurphy | ok :) | 14:37 |
pooja_jadhav | cmurphy, cdent : Thanks for your inputs :) | 14:37 |
*** samueldmq has quit IRC | 14:40 | |
*** samueldmq has joined #openstack-sdks | 14:41 | |
*** cdent has quit IRC | 14:52 | |
*** edmondsw has joined #openstack-sdks | 14:54 | |
*** edmondsw has quit IRC | 14:58 | |
*** olaph has joined #openstack-sdks | 14:59 | |
*** olaph1 has quit IRC | 15:01 | |
*** dave-mccowan has quit IRC | 15:24 | |
openstackgerrit | Mário Santos proposed openstack-infra/shade master: Adds kwargs support when creating a Neutron subnet https://review.openstack.org/563134 | 15:28 |
*** e0ne has quit IRC | 15:36 | |
*** cdent has joined #openstack-sdks | 15:41 | |
*** dims has quit IRC | 16:06 | |
*** dims has joined #openstack-sdks | 16:11 | |
openstackgerrit | Stephen Finucane proposed openstack/os-api-ref master: Raise warning if top-level value is not a dict https://review.openstack.org/563178 | 16:21 |
openstackgerrit | Stephen Finucane proposed openstack/os-api-ref master: Use 'sphinx.util.logging' https://review.openstack.org/563179 | 16:21 |
*** olaph has quit IRC | 16:28 | |
*** olaph has joined #openstack-sdks | 16:30 | |
melwitt | dtroyer_zz: hi, we're trying to resolve a problem where we couldn't update the constraint for python-novaclient to 10.1.0 because of removed functionality that OSC couldn't leverage in queens. because of this, users that install queens are unable to use the volume multi-attach feature with the older novaclient (old review https://review.openstack.org/#/c/538070), | 16:33 |
melwitt | we've proposed a backport of the adjustments from rocky to queens in an effort to be able to update the queens constraint to 10.1.0 https://review.openstack.org/#/c/562840 | 16:34 |
melwitt | your review would be appreciated | 16:34 |
*** jpich has quit IRC | 16:35 | |
*** gkadam has quit IRC | 16:42 | |
*** edmondsw has joined #openstack-sdks | 16:42 | |
*** kimamisa has quit IRC | 16:44 | |
*** edmondsw has quit IRC | 16:47 | |
*** ralonsoh__ has quit IRC | 17:07 | |
*** cdent has quit IRC | 17:09 | |
*** jpena is now known as jpena|off | 17:09 | |
*** e0ne has joined #openstack-sdks | 17:31 | |
*** dave-mccowan has joined #openstack-sdks | 18:06 | |
*** thrash is now known as thrash|biab | 18:42 | |
openstackgerrit | melissaml proposed openstack/keystoneauth master: Trivial: Update pypi url to new url https://review.openstack.org/563227 | 18:50 |
*** harlowja has joined #openstack-sdks | 19:02 | |
*** olaph1 has joined #openstack-sdks | 19:07 | |
*** olaph has quit IRC | 19:08 | |
*** olaph has joined #openstack-sdks | 19:31 | |
*** olaph1 has quit IRC | 19:32 | |
*** thrash|biab is now known as thrash | 19:49 | |
*** edmondsw has joined #openstack-sdks | 20:19 | |
*** kimamisa has joined #openstack-sdks | 20:22 | |
*** edmondsw has quit IRC | 20:23 | |
dtroyer_zz | melwitt: +2 I'd like amotoki to stamp it too since this is adding functionality to a stable release. We can't properly version this when we release it… | 20:26 |
melwitt | understood. thanks dtroyer_zz | 20:30 |
openstackgerrit | melissaml proposed openstack/openstacksdk master: Trivial: Update pypi url to new url https://review.openstack.org/563287 | 20:31 |
*** dave-mccowan has quit IRC | 20:32 | |
*** slaweq has quit IRC | 21:00 | |
*** slaweq has joined #openstack-sdks | 21:01 | |
*** slaweq has quit IRC | 21:06 | |
*** olaph1 has joined #openstack-sdks | 21:08 | |
*** olaph has quit IRC | 21:08 | |
*** thrash is now known as thrash|g0ne | 21:10 | |
*** lbragstad has quit IRC | 21:17 | |
*** lbragstad has joined #openstack-sdks | 21:19 | |
*** e0ne has quit IRC | 21:25 | |
*** e0ne has joined #openstack-sdks | 21:35 | |
*** figleaf is now known as edleafe | 21:44 | |
*** e0ne has quit IRC | 22:05 | |
*** edmondsw has joined #openstack-sdks | 22:07 | |
*** sdague has quit IRC | 22:11 | |
*** edmondsw has quit IRC | 22:11 | |
kmalloc | Ok | 22:16 |
*** salv-orl_ has joined #openstack-sdks | 23:45 | |
*** salv-orlando has quit IRC | 23:48 | |
*** edmondsw has joined #openstack-sdks | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!