| openstackgerrit | Merged openstack/osc-lib master: Delete the output in "find_bulk" api https://review.openstack.org/575372 | 00:03 |
|---|---|---|
| *** edmondsw has joined #openstack-sdks | 00:23 | |
| *** JudeC_ has joined #openstack-sdks | 00:24 | |
| *** JudeC__ has quit IRC | 00:25 | |
| *** tellesnobrega has quit IRC | 00:26 | |
| *** edmondsw has quit IRC | 00:28 | |
| *** tellesnobrega has joined #openstack-sdks | 00:32 | |
| *** kimamisa has quit IRC | 00:38 | |
| openstackgerrit | Merged openstack/osc-lib master: Add OpenTracing based driver id https://review.openstack.org/566493 | 00:50 |
| *** gkadam_ has quit IRC | 01:07 | |
| *** gkadam has joined #openstack-sdks | 01:10 | |
| *** mhen has quit IRC | 01:32 | |
| *** mhen has joined #openstack-sdks | 01:32 | |
| *** annp has joined #openstack-sdks | 01:52 | |
| *** JudeC_ has quit IRC | 01:57 | |
| *** olaph has quit IRC | 04:04 | |
| *** olaph has joined #openstack-sdks | 04:06 | |
| openstackgerrit | Merged openstack/osc-lib master: fix tox python3 overrides https://review.openstack.org/572915 | 04:11 |
| *** gkadam has quit IRC | 05:04 | |
| *** gkadam has joined #openstack-sdks | 05:08 | |
| *** gkadam has quit IRC | 05:31 | |
| *** edmondsw has joined #openstack-sdks | 05:48 | |
| *** edmondsw has quit IRC | 05:53 | |
| *** Luzi has joined #openstack-sdks | 06:00 | |
| openstackgerrit | tianhui proposed openstack/python-openstackclient master: Compute:Support keypair set key-type https://review.openstack.org/577768 | 06:15 |
| openstackgerrit | tianhui proposed openstack/python-openstackclient master: Compute:Support keypair set key-type https://review.openstack.org/577768 | 06:18 |
| Luzi | mordred: I have been looking through openstacksdk, but i don't think the openstackcloud class is a suitable place for the signature generator. Where do you think we can add the signature generator class? | 06:26 |
| *** gtema has joined #openstack-sdks | 06:33 | |
| *** openstackgerrit has quit IRC | 06:49 | |
| *** liangbo has joined #openstack-sdks | 06:54 | |
| *** gtema has quit IRC | 06:59 | |
| *** gtema has joined #openstack-sdks | 07:00 | |
| *** kimamisa has joined #openstack-sdks | 07:18 | |
| *** gildub has joined #openstack-sdks | 07:18 | |
| *** peereb has joined #openstack-sdks | 07:21 | |
| *** openstackgerrit has joined #openstack-sdks | 07:32 | |
| openstackgerrit | huangshan proposed openstack/openstacksdk master: Add vip_qos_policy_id options for loadbalancer https://review.openstack.org/579794 | 07:32 |
| *** kimamisa has quit IRC | 07:35 | |
| *** edmondsw has joined #openstack-sdks | 07:36 | |
| *** edmondsw has quit IRC | 07:41 | |
| *** kimamisa has joined #openstack-sdks | 07:44 | |
| *** jpena|off is now known as jpena | 07:52 | |
| *** jpich has joined #openstack-sdks | 08:03 | |
| *** halbbalda has quit IRC | 08:14 | |
| *** halbbalda has joined #openstack-sdks | 08:16 | |
| *** ralonsoh has joined #openstack-sdks | 08:30 | |
| *** gkadam has joined #openstack-sdks | 08:33 | |
| *** cdent has joined #openstack-sdks | 08:56 | |
| *** cdent_ has joined #openstack-sdks | 09:04 | |
| *** cdent has quit IRC | 09:05 | |
| *** cdent_ is now known as cdent | 09:05 | |
| *** edmondsw has joined #openstack-sdks | 09:25 | |
| *** edmondsw has quit IRC | 09:29 | |
| *** e0ne has joined #openstack-sdks | 09:33 | |
| openstackgerrit | yanpuqing proposed openstack/python-openstackclient master: Add error message when using "set" command without all optional arguments https://review.openstack.org/579515 | 09:38 |
| *** gildub has quit IRC | 09:44 | |
| *** liangbo has quit IRC | 10:04 | |
| *** dtantsur|afk is now known as dtantsur | 10:14 | |
| *** abishop has joined #openstack-sdks | 10:15 | |
| *** cdent has quit IRC | 10:25 | |
| *** jpena is now known as jpena|lunch | 11:29 | |
| dtantsur | mordred: morning! any comments/suggestions on https://etherpad.openstack.org/p/microversions-better-than-beer ? particularly, a catchy title? | 12:15 |
| dtantsur | also do you really want to participate or am I being too pushy to force it on you? :) | 12:16 |
| *** jpena|lunch is now known as jpena | 12:28 | |
| frickler | dtantsur: mordred mentioned earlier in infra that he needs to do some bookkeeping before anything else, not sure whether that will apply here, too | 12:38 |
| dtantsur | frickler: oh, I see, thanks! | 12:39 |
| *** mriedem has joined #openstack-sdks | 12:51 | |
| *** yetiszaf has joined #openstack-sdks | 12:54 | |
| *** r-mibu has joined #openstack-sdks | 13:00 | |
| *** thrash|g0ne is now known as thrash | 13:00 | |
| *** edmondsw has joined #openstack-sdks | 13:01 | |
| *** edmondsw has quit IRC | 13:06 | |
| *** mriedem is now known as mriedem_afk | 13:09 | |
| *** crunchengine has joined #openstack-sdks | 13:11 | |
| mordred | dtantsur: morning! | 13:24 |
| mordred | dtantsur: definitely want to participate ... | 13:25 |
| frickler | dtroyer: could you add https://review.openstack.org/516701 and https://review.openstack.org/558824 to your review list, please? would be great to get these in for this cycle and also still have time to amend the Neutron docs accordingly | 13:26 |
| dtantsur | mordred: cool! no big pressure, but let's try to propose it by EOW since I'm out next week | 13:27 |
| mordred | ++ | 13:29 |
| mordred | dtantsur: I'm adding terrible titles | 13:29 |
| dtantsur | "Dmitry used Microversions and you won't believe what happened next..." AAAaaaaAAAAaaa :D | 13:29 |
| mordred | :) | 13:30 |
| mordred | that one is growing on me | 13:31 |
| dtantsur | mordred: I think #3 (unbearable lightness) is at the right crossing of being fun and acceptable for the audience :) | 13:31 |
| dtantsur | but yes, #2 is so great | 13:31 |
| mordred | \o/ | 13:32 |
| mordred | also - white trash fast food is currently closed, so it's maybe not a great metaphor | 13:32 |
| dtantsur | mordred: is it some known thing? | 13:33 |
| dtantsur | I mean, this fast food thing | 13:34 |
| mordred | dtantsur: http://www.whitetrashfastfood.com/ - it's my favorite berlin restaurant (or, it was) | 13:34 |
| dtroyer | frickler: will do… I'm wrapping up osc-lib first then back to osc itself | 13:35 |
| dtantsur | mordred: oh that's pity | 13:35 |
| mordred | yah. I'm hoping it comes back | 13:36 |
| dtantsur | yep. it's not even too far from my place (but in a, well, "funny" neighborhood) | 13:37 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Only send force parameter to live migration if supported https://review.openstack.org/578960 | 13:37 |
| frickler | dtroyer: cool, thx. I also asked a question about handling microversions, not sure whether this has been discussed globally already. mordred and dtantsur might also be interested. https://review.openstack.org/#/c/577768/4/openstackclient/compute/v2/keypair.py@84 | 13:39 |
| * dtantsur puts on this flame war costume | 13:39 | |
| dtantsur | s/this/his/ | 13:39 |
| Luzi | mordred, I have been looking through openstacksdk, but i don't think the openstackcloud class is a suitable place for the signature generator. Where do you think we can add the signature generator class? | 13:40 |
| dtantsur | frickler: well, I left the same comment on an earlier revision | 13:40 |
| * dtantsur comments | 13:41 | |
| mordred | I think that's about as good as one can do before we plumb all the discovery stuff through - since the model there is assuming a configured api version | 13:41 |
| frickler | dtantsur: oh, that was on the other review. but good to see we seem to agree | 13:42 |
| dtantsur | oh, right, another one | 13:42 |
| dtantsur | mordred: cannot we do version = max('2.2', os_compute_api_version) here? | 13:42 |
| mordred | not without checking to see what api versions the remote side supports | 13:43 |
| dtantsur | another thing to consider: we ended up with defaulting --os-baremetal-api-version to the known latest in ironicclient | 13:43 |
| dtantsur | mordred: why not? the requested will fail reasonably if the remote side only supports 2.1, no? | 13:43 |
| mordred | ah - hrm. yeah - I suppose so in this case | 13:44 |
| *** mriedem_afk is now known as mriedem | 13:44 | |
| dtantsur | assuming we can provide a microversion per request in OSC | 13:45 |
| mordred | we can using sdk - not so much with novaclient | 13:45 |
| dtantsur | which one is used by OSC? | 13:45 |
| mordred | *except* - at least in my world, if a user has explicity set a config value for a specific microversion in compute_api_version - I would argue that we should not override that setting | 13:45 |
| mordred | dtantsur: novaclient for now - although at some point we're hoping to get things shifted over to sdk - dean is waiting on a 1.0 from sdk before starting in on that | 13:46 |
| dtantsur | yep, so maybe if os_compute_api_version is None: os_compute_api_version = '2.2' elif os_compute_api_version < '2.2': boom | 13:46 |
| mordred | dtantsur: yah- I think that would be good and upwards compatible with a future where compute_api_version might not be set | 13:46 |
| mordred | (today it'll always be set because of defaults - but once we've got the discovery stuff finished plumbed through, it can start being None and things working) | 13:47 |
| dtantsur | ah, random defaults, similar to 1.6 in ironic? :) | 13:47 |
| mordred | yup | 13:47 |
| * mordred hails our lord and master 1.6 | 13:47 | |
| dtantsur | * 1.9 in ironicclient and 1.6 in openstacksdk because we LOVE consistency | 13:48 |
| mordred | \o/ | 13:48 |
| mordred | well - I've almost got the last discovery patch for sdk written in my head - so hopefully we're almost there | 13:48 |
| mordred | Luzi: hello! yes - I agree, putting it in OpenStackCloud is not the right place ... | 13:48 |
| mordred | Luzi: I've got a half-written patch on my laptop which should make a better place for you to put the generator | 13:49 |
| mordred | Luzi: let me push up the work-in-progress in just a few minutes and see what you think | 13:49 |
| Luzi | mordred, that sounds good :) | 13:50 |
| mordred | Luzi: the generator class itself should probably just go in its own file in openstack/image - and then it should get attached to the image upload code in openstack/image/v1/_proxy and openstack/image/v2/_proxy ... but step 1 is to take the existing image upload logic from openstackcloud and move it to the proxy classes | 13:51 |
| *** bobh has joined #openstack-sdks | 13:57 | |
| mordred | frickler: speaking of osc patches - https://review.openstack.org/#/c/540541/ | 13:58 |
| dtantsur | mordred: any reason Resource does not implement the dict interface? This way it would be compatible with a Munch | 14:00 |
| dtantsur | e.g. I could start returning openstack.baremetal.v1.Node from *machine* calls | 14:00 |
| mordred | dtantsur: that is the _other_ main patch I wanna finish before cutting 1.0 | 14:00 |
| dtantsur | very good :) | 14:01 |
| mordred | dtantsur: https://review.openstack.org/#/c/530835/ is the very broken WIP patch for that | 14:01 |
| dtantsur | I want to move *machine* calls to use openstack.baremetal.v1.* stuff internally, but currently they return incompatible result | 14:01 |
| mordred | yup | 14:02 |
| mordred | we share the same goal | 14:02 |
| dtantsur | good | 14:03 |
| dtantsur | I guess currently I can do munchify(node.to_dict()) as an ugly hack | 14:03 |
| dtantsur | but what I'm hitting with my provisioning state patch is that I get a redundant GET call on each conversion between a Munch and a Node | 14:04 |
| dtantsur | which is probably fine for now, but has to be fixed eventually | 14:04 |
| mordred | yah - extra calls seem lame | 14:04 |
| *** mriedem has quit IRC | 14:04 | |
| dtantsur | is it acceptable temporary? | 14:04 |
| *** mriedem has joined #openstack-sdks | 14:04 | |
| mordred | dtantsur: I'd be curious to discover why a GET call is being made during the conversion ... | 14:06 |
| openstackgerrit | Monty Taylor proposed openstack/osc-lib master: Use openstack.config for config and Session objects https://review.openstack.org/579139 | 14:07 |
| dtantsur | mordred: https://review.openstack.org/#/c/570895/4/openstack/cloud/openstackcloud.py@9400 causes uuid-to-Node conversion | 14:07 |
| mordred | dtroyer: ^^ that patch passes for me locally now, so might be not a waste of your time to review | 14:07 |
| dtantsur | even when this call is used from e.g. register_machine where we already have a Munch | 14:07 |
| dtantsur | because we cannot pass in a Munch, we need a UUID or a Node | 14:07 |
| mordred | if we have a munch, we should be able to make a Node from it without an api call - I'd think Node(**munch_node) would do the trick? | 14:09 |
| dtantsur | good idea, maybe we should generalize it as Resource.from_munch? | 14:10 |
| dtantsur | defaulting to just cls(**munch) | 14:11 |
| frickler | mordred: oh, that makes me wonder whether it'll fix my neutron ssl issues. will check. | 14:12 |
| mordred | dtantsur: good idea - although maybe make it Resource._from_munch for now - since we might not need it once we finish and land the other thing | 14:13 |
| dtantsur | mordred: okay, I'll see what I can do | 14:14 |
| dtroyer | mordred: coolio, will have a look | 14:14 |
| *** bobh has quit IRC | 14:18 | |
| dtroyer | mordred: looks nice, thank you! | 14:23 |
| mordred | dtroyer: yay! | 14:27 |
| *** gkadam_ has joined #openstack-sdks | 14:28 | |
| *** gkadam has quit IRC | 14:30 | |
| *** Luzi has quit IRC | 14:35 | |
| *** wacuuu has joined #openstack-sdks | 14:47 | |
| *** edmondsw has joined #openstack-sdks | 14:51 | |
| *** edmondsw has quit IRC | 14:55 | |
| *** peereb has quit IRC | 15:05 | |
| *** e0ne has quit IRC | 15:29 | |
| *** thrash is now known as thrash|f00dz | 16:06 | |
| *** jpich has quit IRC | 16:06 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Add Resource._from_munch class method https://review.openstack.org/579908 | 16:11 |
| dtantsur | mordred: ^^^ | 16:11 |
| dtantsur | now let's see if I can get a good use of it | 16:11 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use shade create_image method in image proxy layer https://review.openstack.org/579168 | 16:11 |
| mordred | dtantsur: neat. I could probably use that in that patch ^^ | 16:11 |
| * mordred still needs to do more work on that concept - the logic for the methods needs to get moved, etc ... | 16:12 | |
| dtantsur | mordred: oh, curious, I'm doing it the other way around in my patch: shade level calling baremetal proxy | 16:12 |
| dtantsur | is there The Right approach here? or just whatever fits? | 16:13 |
| *** kimamisa has quit IRC | 16:14 | |
| dtantsur | hmm, and should I wire this _from_munch into Proxy._get_resource? so that all proxies support it automagically? | 16:20 |
| dtantsur | this can be dangerous, maybe only for ironic for now.. | 16:20 |
| dtantsur | actually, from_munch can probably be implemented using the Body() fields | 16:22 |
| * dtantsur thinks more | 16:22 | |
| *** yolanda has joined #openstack-sdks | 16:24 | |
| *** r-mibu has quit IRC | 16:29 | |
| *** gkadam__ has joined #openstack-sdks | 16:30 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Add Resource._from_munch class method https://review.openstack.org/579908 | 16:32 |
| *** gkadam_ has quit IRC | 16:32 | |
| *** ralonsoh has quit IRC | 16:35 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Handle Munch objects in proxies https://review.openstack.org/579908 | 16:43 |
| openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Handle Munch objects in proxies https://review.openstack.org/579908 | 16:55 |
| *** dtantsur is now known as dtantsur|afk | 17:09 | |
| *** thrash|f00dz is now known as thrash | 17:12 | |
| *** jpena is now known as jpena|off | 17:35 | |
| mordred | dtantsur|afk: your way is the better way - we want to get to the shade layer calling the proxy layer rather than the other way around | 17:42 |
| mordred | dtantsur|afk: but for create_image that's going to require some surgery, so I figured invert it for now, then iterate on getting it done right as a followup | 17:43 |
| *** e0ne has joined #openstack-sdks | 17:45 | |
| *** gtema has quit IRC | 17:48 | |
| *** tellesnobrega has quit IRC | 17:52 | |
| *** cdent has joined #openstack-sdks | 18:13 | |
| *** yolanda_ has joined #openstack-sdks | 18:18 | |
| *** yolanda has quit IRC | 18:20 | |
| *** olaph1 has joined #openstack-sdks | 18:24 | |
| *** olaph has quit IRC | 18:26 | |
| *** yolanda__ has joined #openstack-sdks | 18:27 | |
| *** edmondsw has joined #openstack-sdks | 18:27 | |
| *** yolanda_ has quit IRC | 18:30 | |
| *** mriedem has quit IRC | 18:31 | |
| *** edmondsw has quit IRC | 18:32 | |
| *** mriedem has joined #openstack-sdks | 18:39 | |
| *** halbbalda has left #openstack-sdks | 18:54 | |
| *** bobh has joined #openstack-sdks | 19:00 | |
| *** tellesnobrega has joined #openstack-sdks | 19:22 | |
| *** bobh has quit IRC | 19:25 | |
| *** e0ne has quit IRC | 19:40 | |
| *** olaph1 has quit IRC | 19:40 | |
| *** bobh has joined #openstack-sdks | 19:42 | |
| *** bobh has quit IRC | 19:46 | |
| *** bobh has joined #openstack-sdks | 19:47 | |
| *** olaph has joined #openstack-sdks | 19:50 | |
| *** bobh has quit IRC | 20:05 | |
| *** yolanda_ has joined #openstack-sdks | 20:14 | |
| *** edmondsw has joined #openstack-sdks | 20:16 | |
| *** yolanda has joined #openstack-sdks | 20:16 | |
| *** yolanda__ has quit IRC | 20:18 | |
| *** yolanda_ has quit IRC | 20:18 | |
| *** yolanda_ has joined #openstack-sdks | 20:19 | |
| *** abishop has quit IRC | 20:20 | |
| *** edmondsw has quit IRC | 20:21 | |
| *** yolanda has quit IRC | 20:22 | |
| *** yolanda__ has joined #openstack-sdks | 20:24 | |
| *** yolanda_ has quit IRC | 20:24 | |
| openstackgerrit | David Shrewsbury proposed openstack-infra/shade master: Fix for passing dict for get_* methods https://review.openstack.org/579974 | 20:28 |
| Shrews | that probably could use a test | 20:29 |
| mordred | yah. also - I'm pretty sure pep8 is going to complain about the whitespace | 20:29 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/shade master: Fix for passing dict for get_* methods https://review.openstack.org/579974 | 20:32 |
| Shrews | pep8 passed for me | 20:32 |
| mordred | Shrews: cool | 20:33 |
| Shrews | mordred: you want a release note for that? | 20:35 |
| wacuuu | yyy question: are there any plans for sdk in go? | 20:38 |
| mordred | wacuuu: the gophercloud project is basically that | 20:42 |
| mordred | Shrews: nah | 20:42 |
| mordred | wacuuu: https://github.com/gophercloud/gophercloud | 20:42 |
| Shrews | oh that's interesting | 20:47 |
| Shrews | mordred: my fav part: "Backwards-Compatibility Guarantees - None. Vendor it and write tests covering the parts you use." | 20:47 |
| wacuuu | thanks | 20:49 |
| *** wacuuu has quit IRC | 21:05 | |
| *** gkadam__ has quit IRC | 21:35 | |
| *** lbragstad is now known as lbragstad_503 | 22:02 | |
| *** edmondsw has joined #openstack-sdks | 22:05 | |
| *** edmondsw has quit IRC | 22:09 | |
| *** mriedem is now known as mriedem_explosio | 22:14 | |
| *** mriedem_explosio is now known as mriedem_burnmark | 22:14 | |
| *** crunchengine has quit IRC | 22:22 | |
| *** cdent has quit IRC | 22:23 | |
| *** dtruong has quit IRC | 22:30 | |
| *** gildub has joined #openstack-sdks | 23:24 | |
| *** mriedem_burnmark has quit IRC | 23:30 | |
| *** edmondsw has joined #openstack-sdks | 23:53 | |
| *** edmondsw has quit IRC | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!