| *** mhen has quit IRC | 01:29 | |
| *** mhen has joined #openstack-sdks | 01:33 | |
| *** hansmoleman has quit IRC | 01:57 | |
| *** jgwentworth is now known as melwitt | 02:04 | |
| *** slaweq has quit IRC | 03:54 | |
| *** slaweq has joined #openstack-sdks | 04:08 | |
| *** gildub has joined #openstack-sdks | 05:11 | |
| *** gildub has quit IRC | 05:17 | |
| *** madorn has quit IRC | 07:08 | |
| *** madorn has joined #openstack-sdks | 07:09 | |
| *** mhen has quit IRC | 08:07 | |
| *** mhen has joined #openstack-sdks | 08:10 | |
| *** ssbarnea has quit IRC | 08:26 | |
| *** ssbarnea has joined #openstack-sdks | 08:27 | |
| *** ssbarnea has quit IRC | 08:27 | |
| *** ssbarnea has joined #openstack-sdks | 08:30 | |
| *** dave-mccowan has joined #openstack-sdks | 12:56 | |
| *** bobh has joined #openstack-sdks | 12:57 | |
| *** bobh has quit IRC | 13:19 | |
| *** dave-mccowan has quit IRC | 13:36 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Don't wait for task in submit_task https://review.openstack.org/588656 | 14:28 |
|---|---|---|
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Don't wait for task in submit_task https://review.openstack.org/588656 | 15:08 |
| mordred | corvus: ok, that ^^ fixes the tests - the issue at hand is that for async tasks (currently only used during uploading swift segments for large objects) the tasks are wrapped in concurrent futures, so shifting the wait was causing stuff to not finish properly | 15:10 |
| mordred | corvus: the change I made was basically to apply your fix to the sync path but not the async - I think we probably want to dig in further and wrap our heads around the problem for the async path too | 15:11 |
| corvus | mordred: are the async tasks fire-and-forget, or does the caller care whether they eventually finish? | 15:12 |
| mordred | the caller cares - but the caller uses the Future returned to get the eventual result | 15:15 |
| mordred | corvus: if you grab version 2 of the change and run the unittests you can see the 5 failures that come from the async side of the house | 15:17 |
| mordred | corvus: I can't quite wrpap my head around why version 2 of the change breaks in the way that it does | 15:18 |
| mordred | corvus: oh - wait ... I'm wrong | 15:19 |
| mordred | corvus: they are, from a task manager /caller perspective fire and forget | 15:20 |
| mordred | corvus: we only task-manager/rate-limit the start of the task - the concurrent.future that is returned handles exception propogation | 15:20 |
| mordred | so in this case I think the new version of the patch is actualy correct - it just needs more comments | 15:21 |
| mordred | (it's also ugly, so it's entirely possible it could be refactored to not have quite so many if async: in it) | 15:23 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Don't wait for task in submit_task https://review.openstack.org/588656 | 15:29 |
| mordred | corvus: ^^ added some comments and collapsed one of the copies of the code | 15:29 |
| openstackgerrit | Merged openstack/openstacksdk master: Fix filter style consistency for keystone assignment API https://review.openstack.org/569924 | 15:50 |
| *** imacdonn has quit IRC | 16:37 | |
| *** imacdonn has joined #openstack-sdks | 16:37 | |
| *** edmondsw_ has joined #openstack-sdks | 17:24 | |
| *** Tahvok_ has joined #openstack-sdks | 17:25 | |
| *** jpenag has joined #openstack-sdks | 17:27 | |
| *** Tahvok has quit IRC | 17:28 | |
| *** jpena|off has quit IRC | 17:28 | |
| *** edmondsw has quit IRC | 17:28 | |
| *** Tahvok_ is now known as Tahvok | 17:28 | |
| *** ebbex_ has quit IRC | 17:37 | |
| *** Qiming has quit IRC | 17:37 | |
| *** Qiming has joined #openstack-sdks | 17:38 | |
| *** PagliaccisCloud has quit IRC | 17:38 | |
| *** Jeffrey4l has quit IRC | 17:38 | |
| *** Jeffrey4l has joined #openstack-sdks | 17:39 | |
| *** PagliaccisCloud has joined #openstack-sdks | 17:40 | |
| *** mriedem has joined #openstack-sdks | 19:51 | |
| *** bobh has joined #openstack-sdks | 21:57 | |
| *** bobh has quit IRC | 23:44 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!