Friday, 2018-09-21

« Thursday, 2018-09-20 Index Saturday, 2018-09-22 »
*** dayou_ has joined #openstack-sdks00:09
*** slaweq has joined #openstack-sdks00:11
*** slaweq has quit IRC00:16
*** mriedem_away has quit IRC00:40
openstackgerritLIU Yulong proposed openstack/openstacksdk master: Support firewall service for SDK  https://review.openstack.org/59230300:57
*** imacdonn has quit IRC01:15
*** imacdonn has joined #openstack-sdks01:16
*** chenyb4 has joined #openstack-sdks01:30
*** slaweq has joined #openstack-sdks02:11
*** slaweq has quit IRC02:16
*** jamielennox has quit IRC03:37
*** jamielennox has joined #openstack-sdks03:38
*** slaweq has joined #openstack-sdks04:11
*** slaweq has quit IRC04:15
*** slaweq has joined #openstack-sdks05:11
*** e0ne has joined #openstack-sdks05:14
*** slaweq has quit IRC05:15
*** chenyb4 has left #openstack-sdks05:19
*** gkadam has joined #openstack-sdks06:13
*** gkadam has quit IRC06:13
*** slaweq has joined #openstack-sdks06:34
*** e0ne has quit IRC06:59
*** gkadam has joined #openstack-sdks07:19
*** jpich has joined #openstack-sdks07:31
*** tosky has joined #openstack-sdks07:40
*** dims has quit IRC08:11
*** dims has joined #openstack-sdks08:12
*** e0ne has joined #openstack-sdks08:31
*** Luzi has joined #openstack-sdks09:23
*** e0ne has quit IRC09:55
*** cdent has joined #openstack-sdks10:17
*** e0ne has joined #openstack-sdks10:25
*** cdent has quit IRC11:12
*** cdent has joined #openstack-sdks11:44
*** e0ne has quit IRC12:06
*** gkadam has quit IRC12:34
*** cdent has quit IRC13:02
*** e0ne has joined #openstack-sdks13:03
*** bobh has joined #openstack-sdks13:24
*** mriedem has joined #openstack-sdks13:29
*** cdent has joined #openstack-sdks13:30
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Use discovery instead of config to create proxies  https://review.openstack.org/60029213:45
*** stephenfin is now known as finucannot13:48
Shrews+306, -160013:57
Shrewswow13:57
Shrewsi can't wait to fully review that13:57
Shrewswhile drinking13:57
mordredShrews: one of these days it's going to pass the bifrost job and I'm going to be happy14:00
mordredShrews: for now I've put in an autohold so I can poke at it again14:01
mordredShrews: I *thought* I'd figured out the issue 2 days ago ... sigh14:02
*** openstackgerrit has quit IRC14:07
Shrewsmordred: i'm sort of waiting for all green before i look at it14:11
mordredit's the best bet14:11
* dtantsur ditto14:12
dtantsuron one hand, bifrost is pita :) on the other - it's the only thing that apparently provides this sort of coverage14:12
mordreddtantsur: yah - I've been adding unit tests as I figure out issues - but apparently there's still one I don't have :14:14
mordred:(14:14
mordreddtantsur: it's been really useful to sort out the no-catalog versioned and unversioned endpoint use-case :)14:15
dtantsuroh yeah14:17
dtantsurmordred: unrelated: do you plan on openstacksdk release any soon? I could give switching metalsmith to it a try14:17
mordreddtantsur: yes - I think we're ready for one - but I was gonna see if I could get that discovery patch landed14:20
dtantsurright14:20
mordreddtantsur: but if it doesn't turn green today, maybe we'll cut a release with what we have so far on monday14:21
*** lbragstad is now known as elbragstad14:24
dtantsuryeah, and then another one. release numbers are cheap :)14:34
*** Luzi has quit IRC14:42
mordred++14:43
*** gkadam has joined #openstack-sdks14:43
mordredShrews: if you're bored and feel like flaying your brain a little ... https://review.openstack.org/#/c/603739/14:48
Shrewsk k14:48
mordredShrews: I think we might want corvus to review it when he gets back as well - since it's a fundamental change to the internals of the task manager - but I *think* it's solid14:50
Shrewspassed pep8... ship it14:51
mordred++14:52
*** Leo_m has joined #openstack-sdks15:00
*** Leo_m has quit IRC15:06
*** gkadam has quit IRC15:10
*** Leo_m has joined #openstack-sdks15:13
Shrewsmordred: why the call to ret.exception()? We don't seem to do anything with it15:49
Shrewsret.result() should raise an exception if one occurred in the call (if i read the Futures docs correction)15:50
Shrewss/correction/correctly/15:50
mordredShrews: oh - I couldn't find mention that result would do that - so I guess it's senseless15:54
Shrewsmordred: https://docs.python.org/3/library/concurrent.futures.html#concurrent.futures.Future.result15:54
mordredShrews: so, whatyou're saying is thatif I could actually read simple english, my life would be better?15:55
* Shrews says nothing15:55
*** cdent has quit IRC15:59
*** jpich has quit IRC15:59
*** e0ne has quit IRC16:07
Shrewsmordred: left comments  :-P16:07
mordredShrews: \o/16:08
Shrewsmordred: i'm not sure if anyone actually uses submit_function_async(), but probably a bad idea to totally remove an API call16:09
Shrewscorrect me if i'm wrong16:09
Shrews'cause i know nothing about anything16:09
Shrews'cause Friday16:09
mordredShrews: yeah - I agree with you in principle, but in practice I'm 99.9% sure that nodepool is the only consumer of anything related to taskmanager16:10
Shrewsi checked nodepool for it, fwiw16:10
Shrewsnot used16:10
mordredyah16:10
Shrewsso i can be convinced to remove it16:10
* mordred hands Shrews a beer16:10
Shrewsmmmm, frothy16:11
*** openstackgerrit has joined #openstack-sdks16:18
openstackgerritMatthias Lisin proposed openstack/openstacksdk master: Support firewall service for SDK  https://review.openstack.org/59230316:18
mordreddtantsur: I think I found the issue with the bifrost16:28
dtantsurwith bifrost itself?16:28
mordrednope - with the sdk discovery patch and the failing bifrost test16:28
mordredtl;dr - auth_type='none' and endpoint=ironic_url needs to take ironic_url and put it in the endpoint_override parameter when creating the keystoneauth Adapter16:29
mordredotherwise discovery is sad16:29
mordredit's an easy fix in openstack.config16:29
mordredor - more generally- if none/endpoint are given, then that endpoint should be returned for any/all service endpoint_override values16:30
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Use discovery instead of config to create proxies  https://review.openstack.org/60029216:30
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Remove profile  https://review.openstack.org/60441416:31
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Set endpoint_override from endpoint with noauth  https://review.openstack.org/60441516:31
dtantsuryeah16:31
Shrewsis it just me, or is all of that stuff just a confusing mess?16:31
mordredShrews: bah. it's super simple ;)16:31
mordreddtantsur Shrews: https://review.openstack.org/604415 has that bit fixed - and I did it in a separate patch so that Shrews doesn't kill me16:31
dtantsurstaring at it already16:31
mordredI also broke out the profile removal so that the big patch is smaller16:31
dtantsurmordred: do you know what I'm going to ask you? hint: starts with "unit" :)16:32
mordredhahahahaha16:32
mordredyeah. good point ... lemme do that16:32
dtantsurthanks! otherwise the patch looks okay16:33
dtantsurwell, I cringe every time we have to hardcode entry points in code... but I guess it's the lesser evil16:34
mordredoh - well, everything in openstack.config is a basis for cringe :)16:35
dtantsurfair enough :)16:35
dtantsurmordred: last (potentially stupid) question: is Python None really synonym of "none" here? I would expect it to default to password..16:36
mordreddtantsur: it should default to password - but I think the codepath works if someone puts a yaml null in there16:37
mordredmaybe I should try that16:37
dtantsurmordred: yeah, I'm a bit worried about "in ("none", None)" bit16:38
dtantsuranyway, it's Friday evening, I think I should do something more productive than asking questions :)16:39
dtantsurhave a great weekend16:39
mordreddtantsur: you're right- null/None isn't a thing16:40
dtantsurok :)16:41
*** dtantsur is now known as dtantsur|afk16:41
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Set endpoint_override from endpoint with noauth  https://review.openstack.org/60441516:41
mordrednow with tests16:41
*** Leo_m has quit IRC16:47
*** Leo_m_ has joined #openstack-sdks16:48
*** gkadam has joined #openstack-sdks17:03
*** bobh has quit IRC17:03
*** bobh has joined #openstack-sdks17:13
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Set endpoint_override from endpoint with noauth  https://review.openstack.org/60441517:16
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Use discovery instead of config to create proxies  https://review.openstack.org/60029217:16
*** bobh has quit IRC17:18
*** AJaeger has left #openstack-sdks17:18
*** e0ne has joined #openstack-sdks17:22
*** bobh has joined #openstack-sdks17:27
openstackgerritMatthias Lisin proposed openstack/openstacksdk master: Support firewall service for SDK  https://review.openstack.org/59230317:40
*** e0ne has quit IRC18:36
*** dave-mccowan has quit IRC19:03
*** bobh has quit IRC19:09
*** dave-mccowan has joined #openstack-sdks19:14
*** gkadam has quit IRC19:35
*** bobh has joined #openstack-sdks19:46
*** slaweq has quit IRC19:54
mordredShrews, dtantsur|afk: ZOMG ZOMG - the discovery patch PASSED the bifrost test!!!!19:55
mordredTheJulia: you may also be interested to hear such wonderful and positive news19:56
*** slaweq has joined #openstack-sdks19:57
*** bobh has quit IRC20:02
mordredof course, the downside is that now somebody has to review the beast20:22
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Remove api version default values  https://review.openstack.org/60033020:23
TheJuliaWoot!20:35
*** dave-mccowan has quit IRC22:04
*** mriedem is now known as mriedem_away22:09
*** Leo_m has joined #openstack-sdks22:45
*** Leo_m_ has quit IRC22:47
*** tosky has quit IRC22:58
*** tosky has joined #openstack-sdks22:59
*** tosky has quit IRC23:13
« Thursday, 2018-09-20 Index Saturday, 2018-09-22 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!