*** slaweq has joined #openstack-sdks | 00:11 | |
*** slaweq has quit IRC | 00:15 | |
*** mriedem_away has quit IRC | 00:18 | |
*** gildub_ has joined #openstack-sdks | 00:24 | |
*** slaweq has joined #openstack-sdks | 01:11 | |
*** slaweq has quit IRC | 01:15 | |
*** edisonxiang has joined #openstack-sdks | 01:51 | |
*** chenyb4 has joined #openstack-sdks | 02:10 | |
*** imacdonn has quit IRC | 02:50 | |
*** markvoelker has joined #openstack-sdks | 02:50 | |
*** imacdonn has joined #openstack-sdks | 02:51 | |
*** openstackgerrit has joined #openstack-sdks | 03:07 | |
openstackgerrit | Merged openstack/openstacksdk master: Normalize security groups when using Neutron https://review.openstack.org/602147 | 03:07 |
---|---|---|
*** slaweq has joined #openstack-sdks | 03:11 | |
*** slaweq has quit IRC | 03:15 | |
openstackgerrit | Merged openstack/openstacksdk master: Allow JMESPath on searching networking resources https://review.openstack.org/599078 | 03:26 |
*** dave-mccowan has quit IRC | 03:46 | |
*** edisonxiang has quit IRC | 03:53 | |
*** haleyb has quit IRC | 04:07 | |
*** dave-mccowan has joined #openstack-sdks | 04:50 | |
*** slaweq has joined #openstack-sdks | 05:11 | |
*** slaweq has quit IRC | 05:15 | |
*** slaweq has joined #openstack-sdks | 06:11 | |
*** slaweq has quit IRC | 06:15 | |
*** slaweq has joined #openstack-sdks | 06:23 | |
*** Luzi has joined #openstack-sdks | 07:06 | |
*** gkadam has joined #openstack-sdks | 07:36 | |
*** gildub_ has quit IRC | 07:41 | |
*** tosky has joined #openstack-sdks | 07:45 | |
*** jpich has joined #openstack-sdks | 07:47 | |
*** e0ne has joined #openstack-sdks | 08:12 | |
*** dtantsur|afk is now known as dtantsur | 08:36 | |
*** ttsiouts has joined #openstack-sdks | 08:49 | |
*** gkadam is now known as gkadam-afk | 08:52 | |
*** ttsiouts has quit IRC | 08:58 | |
*** gkadam-afk is now known as gkadam | 08:59 | |
*** ttsiouts has joined #openstack-sdks | 09:00 | |
*** a-pugachev has joined #openstack-sdks | 09:01 | |
*** cdent has joined #openstack-sdks | 09:44 | |
*** gildub_ has joined #openstack-sdks | 10:04 | |
*** purplerbot has joined #openstack-sdks | 10:08 | |
*** cdent has quit IRC | 10:08 | |
*** chenyb4 has quit IRC | 10:12 | |
openstackgerrit | Merged openstack/openstacksdk master: Change the method of role update https://review.openstack.org/600671 | 10:38 |
*** ttsiouts has quit IRC | 10:41 | |
*** cdent has joined #openstack-sdks | 11:00 | |
*** tosky has quit IRC | 11:44 | |
*** tosky has joined #openstack-sdks | 11:45 | |
*** ttsiouts has joined #openstack-sdks | 11:45 | |
*** olivierb has joined #openstack-sdks | 11:47 | |
*** olivierb has quit IRC | 11:58 | |
*** olivierb has joined #openstack-sdks | 11:59 | |
*** e0ne has quit IRC | 12:09 | |
*** e0ne has joined #openstack-sdks | 12:09 | |
*** mriedem has joined #openstack-sdks | 12:22 | |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove all the deprecated stuff https://review.openstack.org/605508 | 12:26 |
* dtantsur links this ^^^ commit summary | 12:27 | |
dtantsur | s/links/likes/ | 12:27 |
mordred | \o/ | 12:27 |
mordred | dtantsur: I love deleting code | 12:27 |
mordred | dtroyer: if you have any spare time amongst all of the starlingxing ... https://review.openstack.org/#/c/600292 is the last main big-boy before 1.0 and is ready for review. it's GIANT, so I don't blame you if you don't want to review it - but a lot of the patch is just removing unneeded lines from unit tests | 12:28 |
*** mriedem has quit IRC | 12:34 | |
tosky | mordred: hi! Do you remember us discussing about https://review.openstack.org/#/c/589465/ ? Apparently openstackclient-check-plugins is still failing on older stable branches | 12:39 |
tosky | for example http://logs.openstack.org/36/588336/4/check/openstackclient-check-plugins/348b548/ | 12:39 |
mordred | tosky: oy. that's ugly | 12:47 |
mordred | tosky: I remember talking about it - I don't remember what we said or if we had come up with a solution that just needed implementing | 12:48 |
*** mriedem has joined #openstack-sdks | 12:49 | |
tosky | mordred: I think that the last discussion (before the PTG) was more or less "oh, ok, something is wrong" | 12:53 |
mordred | tosky: darn. | 12:58 |
mordred | tosky: well, I agree with pre-ptg us | 12:58 |
*** bobh has joined #openstack-sdks | 12:59 | |
tosky | mordred: could it be that openstackclient runs the tests from its master branch, thus requirement master requirements.txt, which conflicts with the requirements from a stable branch? | 13:10 |
tosky | that would explain the issue with python-keystonclient 3.15.0 installed, but conflicting with the requirement of python-keystoneclient 3.17.0 | 13:10 |
*** ttsiouts has quit IRC | 13:19 | |
mordred | tosky: it should be stable/queens of osc -- http://logs.openstack.org/36/588336/4/check/openstackclient-check-plugins/348b548/job-output.txt.gz#_2018-09-27_12_18_28_095085 | 13:19 |
mordred | oh - but openstack/openstackclient is master | 13:20 |
tosky | mordred: that's python-openstackclient, not openstackclient | 13:20 |
tosky | yep | 13:20 |
mordred | http://logs.openstack.org/36/588336/4/check/openstackclient-check-plugins/348b548/job-output.txt.gz#_2018-09-27_12_18_31_882086 | 13:20 |
mordred | yeah | 13:20 |
mordred | but requirements is also on stable/queens http://logs.openstack.org/36/588336/4/check/openstackclient-check-plugins/348b548/job-output.txt.gz#_2018-09-27_12_18_34_622015 | 13:21 |
tosky | mordred: but this requirements.txt comes from openstackclient, so from master http://git.openstack.org/cgit/openstack/openstackclient/tree/playbooks/openstackclient-check-plugins/run.yaml#n11 | 13:22 |
*** e0ne has quit IRC | 13:22 | |
mordred | yah | 13:22 |
mordred | I wonder if we need stable branch versions of that repo | 13:22 |
mordred | dtroyer, dhellmann: ^^ I'm not 100% sure of how that hangs together | 13:23 |
tosky | it used to have stable branches - was everything originally under openstack/openstackclient and then the main code was moved to openstack/python-openstackclient? | 13:23 |
*** e0ne has joined #openstack-sdks | 13:26 | |
dhellmann | tosky : no, the code was always in openstack/python-openstackclient. The openstackclient repo is a meta-package for pulling in all of the extra dependencies to make it easier to install | 13:30 |
dhellmann | tosky , mordred ,dtroyer : if we're testing against things that branch, we need to branch | 13:30 |
dhellmann | even if we never do anything with the branches, that's just how the test machinery works | 13:31 |
tosky | I guess it would make sense to keep the job definition in master only | 13:34 |
tosky | so that the only thing to take care is the check_osc_commands.py | 13:34 |
tosky | though in openstackclient has code in stable/queens | 13:35 |
*** ttsiouts has joined #openstack-sdks | 13:35 | |
tosky | uh, or there is something weird in my local checkout | 13:38 |
tosky | for some reason I needed `git remote prune origin` in my local checkout of openstackclient | 13:40 |
*** gildub_ has quit IRC | 13:44 | |
dtroyer | it is totally possible that the openstackclient repo is not properly branched… I had wanted to move the plugin tests there but don't think that was ever completed, so it needs to be handled like the main repo | 13:46 |
dtroyer | mordred: I am release-branching stx today if zuul ever catches up, but that may give me an excuse to slip into a dark corner and refrsh myself with sdk :) | 13:47 |
dtroyer | I see how you pull the strings behind the scenes :) | 13:48 |
mordred | dtroyer: I've gotta do _something_ :) | 13:49 |
*** Horrorcat has quit IRC | 14:06 | |
*** Leo_m has joined #openstack-sdks | 14:09 | |
*** ttsiouts has quit IRC | 14:15 | |
*** ttsiouts has joined #openstack-sdks | 14:30 | |
*** ttsiouts has quit IRC | 14:58 | |
*** ttsiouts has joined #openstack-sdks | 14:59 | |
*** ttsiouts has quit IRC | 15:04 | |
*** Luzi has quit IRC | 15:13 | |
*** ttsiouts has joined #openstack-sdks | 15:20 | |
*** ttsiouts has quit IRC | 15:23 | |
*** dave-mccowan has quit IRC | 15:23 | |
*** dave-mccowan has joined #openstack-sdks | 15:41 | |
*** e0ne has quit IRC | 15:51 | |
*** dave-mccowan has quit IRC | 16:08 | |
*** jpich has quit IRC | 16:12 | |
*** cdent has quit IRC | 16:26 | |
*** a-pugachev has quit IRC | 16:34 | |
*** bobh has quit IRC | 16:37 | |
elmiko | edleafe dtantsur let me know how this strikes you https://etherpad.openstack.org/p/api-sig-newsletter | 16:41 |
*** bobh has joined #openstack-sdks | 16:42 | |
edleafe | elmiko: that's not a python docstring :) | 16:42 |
elmiko | haha ;) | 16:42 |
elmiko | oh you... always making things so /grammatical/ | 16:42 |
edleafe | I removed the "meeting agenda" from the bottom | 16:43 |
elmiko | ++ thanks | 16:43 |
edleafe | I guess I need to update the meeting in governance | 16:44 |
elmiko | i took an action for that, but if you want to no worries =) | 16:44 |
edleafe | oh, go ahead. I didn't know you took that action | 16:44 |
elmiko | i snuck it in the meeting XD | 16:45 |
elmiko | i was gonna follow the format for the other office hours entries, i'll make the pr shortly | 16:45 |
elmiko | am i good to publish on the newsletter? | 16:45 |
edleafe | send it | 16:46 |
elmiko | thanks! | 16:46 |
dtantsur | elmiko: LGTM | 16:49 |
elmiko | thanks | 16:50 |
*** e0ne has joined #openstack-sdks | 16:52 | |
*** cdent has joined #openstack-sdks | 16:53 | |
*** dtantsur is now known as dtantsur|afk | 16:54 | |
*** e0ne has quit IRC | 16:54 | |
edleafe | elmiko: dtantsur|afk: I updated the meetings page: https://wiki.openstack.org/wiki/Meetings/API-SIG | 16:56 |
edleafe | elmiko: you're going to take care of the changes in openstack-infra/irc-meetings, right? | 16:57 |
elmiko | edleafe: https://review.openstack.org/#/c/605808/ | 16:58 |
elmiko | thanks ed ! | 16:59 |
*** e0ne has joined #openstack-sdks | 17:16 | |
*** cdent has quit IRC | 17:16 | |
*** gkadam has quit IRC | 17:20 | |
mnaser | https://review.openstack.org/#/c/589012 -- can we have eyes on this? | 17:32 |
mnaser | it's impossible to do live migrations without force specifying a host which isnt ideal | 17:33 |
*** dims_ is now known as dims | 18:05 | |
*** bobh has quit IRC | 18:12 | |
*** olivierb has quit IRC | 18:15 | |
*** olivierb has joined #openstack-sdks | 18:16 | |
*** olivierb has quit IRC | 18:43 | |
*** olivierb has joined #openstack-sdks | 18:43 | |
*** bobh has joined #openstack-sdks | 18:45 | |
mordred | mnaser: how about nargs='?' to make the argument to --live be optional | 19:05 |
mnaser | mordred: i like that, it doesn't break the backwards compatibility | 19:05 |
mnaser | mordred: i dunno.. should i respin that patch? push another one and this one can stay as an alternate when we want to further refactor things? | 19:06 |
mordred | mnaser: might need to also add const='<nonce>' - which will tell argparse to put '<nonce>' in as the argument to --live if none is otherwise given | 19:06 |
mnaser | could we use default=None? | 19:06 |
mordred | well, I don't think the patch in its current state is viable bdcause it's a total breaking change | 19:06 |
mnaser | i think that is the most preferable thing on the nova api side of things | 19:06 |
mordred | mnaser: maybe? it's worth a try | 19:06 |
mordred | mnaser: so - default is the value that will be put into the variable if --live isn't given. const is the value that is put in if --live is given with no argument | 19:07 |
mnaser | mordred: ah okay, so const is what we want then | 19:08 |
mordred | mnaser: so maybe nargs='?', const=False, default=None | 19:08 |
mordred | that way you can easily tell all three cases | 19:08 |
mnaser | ok ill try to look at that, i should be paying attention to the call i'm in.. but zzz | 19:08 |
mordred | mnaser: bah. calls are boring | 19:10 |
*** dayou has quit IRC | 19:10 | |
mordred | I left the feedback on the patch too | 19:10 |
*** bobh has quit IRC | 19:30 | |
*** bobh has joined #openstack-sdks | 19:30 | |
*** dayou has joined #openstack-sdks | 19:37 | |
*** e0ne has quit IRC | 19:42 | |
*** e0ne has joined #openstack-sdks | 19:47 | |
*** e0ne has quit IRC | 19:50 | |
*** bobh has quit IRC | 20:01 | |
*** e0ne has joined #openstack-sdks | 20:08 | |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Optimize the floating ip functional test a bit https://review.openstack.org/605860 | 20:10 |
*** dayou has quit IRC | 20:38 | |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove all the deprecated stuff https://review.openstack.org/605508 | 20:56 |
*** dayou has joined #openstack-sdks | 21:06 | |
*** e0ne has quit IRC | 21:14 | |
*** bobh has joined #openstack-sdks | 21:18 | |
*** bobh has quit IRC | 21:18 | |
openstackgerrit | Brian Haley proposed openstack/python-openstackclient master: Fix some spaces in help messages https://review.openstack.org/603206 | 21:54 |
*** mriedem has quit IRC | 21:55 | |
*** Leo_m has quit IRC | 22:01 | |
*** mriedem has joined #openstack-sdks | 22:07 | |
*** tosky has quit IRC | 22:53 | |
*** olivierb has quit IRC | 23:08 | |
*** olivierb has joined #openstack-sdks | 23:11 | |
*** mriedem has quit IRC | 23:26 | |
*** bobh has joined #openstack-sdks | 23:28 | |
*** olivierb has quit IRC | 23:29 | |
*** gildub_ has joined #openstack-sdks | 23:44 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!