Wednesday, 2018-10-10

*** lbragstad has joined #openstack-sdks00:16
*** slaweq has joined #openstack-sdks01:11
*** slaweq has quit IRC01:15
*** openstackgerrit has quit IRC01:37
*** d0ugal has quit IRC01:37
*** Horrorcat has quit IRC01:37
*** mugsie has quit IRC01:37
*** jroll has quit IRC01:37
*** odyssey4me has quit IRC01:37
*** dmellado has quit IRC01:37
*** markvoelker has quit IRC01:37
*** edleafe has quit IRC01:37
*** dtroyer has quit IRC01:37
*** dave-mccowan has quit IRC01:37
*** guilhermesp has quit IRC01:37
*** johnsom has quit IRC01:37
*** mgagne has quit IRC01:37
*** knikolla has quit IRC01:37
*** lastmikoi has quit IRC01:37
*** gmann has quit IRC01:37
*** gouthamr has quit IRC01:37
*** Shrews has quit IRC01:37
*** brtknr has quit IRC01:37
*** jamielennox has quit IRC01:37
*** ebbex has quit IRC01:37
*** pooja_jadhav has quit IRC01:37
*** amotoki has quit IRC01:37
*** dtantsur|afk has quit IRC01:37
*** stephenfin has quit IRC01:37
*** amito has quit IRC01:37
*** dtruong has quit IRC01:37
*** dasp has quit IRC01:37
*** kmalloc has quit IRC01:37
*** mrhillsman has quit IRC01:37
*** cmurphy has quit IRC01:37
*** Hazelesque has quit IRC01:37
*** lbragstad has quit IRC01:37
*** imacdonn has quit IRC01:37
*** olaph has quit IRC01:37
*** adriant has quit IRC01:37
*** dhellmann has quit IRC01:37
*** madorn has quit IRC01:37
*** tonyb has quit IRC01:37
*** ml has quit IRC01:37
*** rm_work has quit IRC01:37
*** fungi has quit IRC01:37
*** christi3k has quit IRC01:37
*** samueldmq has quit IRC01:37
*** melwitt has quit IRC01:37
*** ignatenkobrain has quit IRC01:37
*** rabel has quit IRC01:37
*** tobberydberg has quit IRC01:37
*** gtmanfred has quit IRC01:37
*** nicholas has quit IRC01:37
*** sc68cal has quit IRC01:37
*** mnaser has quit IRC01:37
*** TheJulia has quit IRC01:37
*** zxiiro-pto has quit IRC01:37
*** mordred has quit IRC01:37
*** rods_ has quit IRC01:37
*** dims has quit IRC01:37
*** elmiko has quit IRC01:37
*** tobiash has quit IRC01:37
*** purplerbot has quit IRC01:37
*** mmedvede has quit IRC01:37
*** timburke has quit IRC01:37
*** Jeffrey4l has quit IRC01:37
*** dayou has quit IRC01:37
*** zigo has quit IRC01:37
*** smcginnis has quit IRC01:37
*** ianw has quit IRC01:37
*** Qiming has quit IRC01:37
*** frickler has quit IRC01:37
*** charz has quit IRC01:37
*** Qiming has joined #openstack-sdks01:43
*** ianw has joined #openstack-sdks01:43
*** odyssey4me has joined #openstack-sdks01:43
*** jroll has joined #openstack-sdks01:43
*** Horrorcat has joined #openstack-sdks01:43
*** d0ugal has joined #openstack-sdks01:43
*** mugsie has joined #openstack-sdks01:43
*** zigo has joined #openstack-sdks01:43
*** smcginnis has joined #openstack-sdks01:43
*** dayou has joined #openstack-sdks01:43
*** Jeffrey4l has joined #openstack-sdks01:43
*** timburke has joined #openstack-sdks01:43
*** mmedvede has joined #openstack-sdks01:43
*** purplerbot has joined #openstack-sdks01:43
*** gmann has joined #openstack-sdks01:44
*** fungi has joined #openstack-sdks01:44
*** rm_work has joined #openstack-sdks01:44
*** christi3k has joined #openstack-sdks01:44
*** samueldmq has joined #openstack-sdks01:44
*** melwitt has joined #openstack-sdks01:44
*** gouthamr has joined #openstack-sdks01:44
*** Shrews has joined #openstack-sdks01:44
*** brtknr has joined #openstack-sdks01:44
*** jamielennox has joined #openstack-sdks01:44
*** ebbex has joined #openstack-sdks01:44
*** openstackgerrit has joined #openstack-sdks01:44
*** frickler has joined #openstack-sdks01:45
*** charz has joined #openstack-sdks01:45
*** pooja_jadhav has joined #openstack-sdks01:45
*** amotoki has joined #openstack-sdks01:45
*** dtantsur|afk has joined #openstack-sdks01:45
*** stephenfin has joined #openstack-sdks01:45
*** mrhillsman has joined #openstack-sdks01:45
*** amito has joined #openstack-sdks01:45
*** dtruong has joined #openstack-sdks01:45
*** dasp has joined #openstack-sdks01:45
*** kmalloc has joined #openstack-sdks01:45
*** cmurphy has joined #openstack-sdks01:45
*** Hazelesque has joined #openstack-sdks01:45
*** dtroyer has joined #openstack-sdks01:45
*** dmellado has joined #openstack-sdks01:46
*** markvoelker has joined #openstack-sdks01:46
*** edleafe has joined #openstack-sdks01:46
*** sc68cal has joined #openstack-sdks01:46
*** nicholas has joined #openstack-sdks01:46
*** zxiiro-pto has joined #openstack-sdks01:46
*** gtmanfred has joined #openstack-sdks01:46
*** mnaser has joined #openstack-sdks01:46
*** TheJulia has joined #openstack-sdks01:46
*** mordred has joined #openstack-sdks01:46
*** rabel has joined #openstack-sdks01:46
*** ignatenkobrain has joined #openstack-sdks01:46
*** tobberydberg has joined #openstack-sdks01:46
*** imacdonn has joined #openstack-sdks01:46
*** olaph has joined #openstack-sdks01:46
*** adriant has joined #openstack-sdks01:46
*** dhellmann has joined #openstack-sdks01:46
*** ml has joined #openstack-sdks01:46
*** madorn has joined #openstack-sdks01:46
*** tonyb has joined #openstack-sdks01:46
*** rods_ has joined #openstack-sdks01:46
*** elmiko has joined #openstack-sdks01:46
*** tobiash has joined #openstack-sdks01:46
*** lbragstad has joined #openstack-sdks01:48
*** mgagne has joined #openstack-sdks01:49
*** Guest10461 has joined #openstack-sdks01:49
*** dave-mccowan has joined #openstack-sdks01:49
*** lastmikoi has joined #openstack-sdks01:55
*** lbragstad has quit IRC02:14
openstackgerritNguyen Van Trung proposed openstack/cliff master: Don't quote {posargs} in tox.ini  https://review.openstack.org/60918502:33
*** dave-mccowan has quit IRC03:08
*** slaweq has joined #openstack-sdks03:11
*** slaweq has quit IRC03:16
*** gkadam has joined #openstack-sdks04:42
*** slaweq has joined #openstack-sdks05:11
*** gkadam has quit IRC06:18
*** olivierb has joined #openstack-sdks06:42
*** Luzi has joined #openstack-sdks06:55
*** odyssey4me has quit IRC07:07
*** odyssey4me has joined #openstack-sdks07:08
*** mugsie has quit IRC07:08
*** mgagne has quit IRC07:09
*** mgagne has joined #openstack-sdks07:10
*** jroll has quit IRC07:10
*** lastmikoi has quit IRC07:10
*** jroll has joined #openstack-sdks07:12
*** ttsiouts has joined #openstack-sdks07:12
*** lastmikoi has joined #openstack-sdks07:14
*** jpich has joined #openstack-sdks07:21
*** mgagne has quit IRC07:34
*** ttsiouts has quit IRC07:35
*** mgagne has joined #openstack-sdks07:36
*** tosky has joined #openstack-sdks07:42
*** gkadam has joined #openstack-sdks07:55
*** ttsiouts has joined #openstack-sdks07:59
*** ttsiouts has quit IRC08:05
*** ttsiouts has joined #openstack-sdks08:08
*** ttsiouts has quit IRC08:14
*** ttsiouts has joined #openstack-sdks08:21
*** jpich has quit IRC09:16
*** jpich has joined #openstack-sdks09:17
*** jpich has quit IRC09:36
*** jpich has joined #openstack-sdks09:36
*** imacdonn has quit IRC09:52
*** imacdonn has joined #openstack-sdks09:52
mordredml: that patch looks great!10:04
mordredsamueldmq: https://review.openstack.org/#/c/604811 <-- you might find this interesting10:05
mlThanks for the review!10:05
samueldmqmordred: oh that's using the sdk data model10:10
samueldmqmordred: ml : commented on that. suggested a few improvements10:15
mordredsamueldmq: yah - I haven't gotten far enough along to explore that yet - but I've been thinking that we could migrate from the normalize methods to using the sdk data model - and maybe some times have some of the logic be in the sdk proxy methods - I was going to try it with create_image10:15
mordredsamueldmq: awesome, thanks!10:15
mlsamueldmq: Thanks, will have a look#10:16
samueldmqmordred: we'd still need something like normalzie anyways10:16
samueldmqI know sdk data model already maps some of the attributes, such as enabled -> is_enabled in the data model definition10:17
samueldmqbut we'd need to map that against the current shade contract/data model10:17
samueldmqbecause we don't want to change that right10:17
mordredyes, you're exactly right10:20
mordredalthough maybe it'll be enough to just update the sdk model to be the same as the normalize contract in shade?10:20
*** ttsiouts has quit IRC10:20
samueldmqif the sdk side is okay updating their contact, it'd be awesome10:21
mlsamueldmq: you think it's a good idea to put 14 parameters in the function signature? Feels messy10:22
samueldmqml: well, see https://github.com/openstack/openstacksdk/blob/master/openstack/cloud/openstackcloud.py#L6751-L6766 for create_server10:23
samueldmqml: don't necessarily need to put in the signature, see the valid_kwargs annotation10:23
samueldmqml: I'd probably go with that as you don't do any work on the parameters before passsing on to the server10:23
mlahh, yeah. @_utils.valid_kwargs sounds good10:24
samueldmqml: awesome. btw I didn't mean you should because create_server does more params than that10:26
mlalso, sadly no, name_or_id doesn't uniquely identify the resource since multiple resources can have the same name10:26
samueldmqbut for the reasons  I put on the review :)10:26
samueldmqml:  so please make it clear in the docs that filters might need to be used when a name is provided10:27
samueldmqalso, document what happens if you provider a name and filters combination that gets you more than one resource10:27
samueldmqwhen you're callling the update or delete mehtod, for example. does it update'em all? delete them all? throws exception?10:28
samueldmqs/throws/raises , throwing exceptions remembers me of java10:28
*** gildub has joined #openstack-sdks10:29
mlalright, I'll add :raises [exc]: where necessary10:30
samueldmqml: nice. thanks for that, it's awesome work10:30
samueldmqI have to go afk for a bit10:31
mlsamueldmq: Thanks for the review. Will fix asap.10:31
*** ttsiouts has joined #openstack-sdks10:32
*** dave-mccowan has joined #openstack-sdks10:32
*** e0ne has joined #openstack-sdks10:51
*** ttsiouts has quit IRC10:53
*** ttsiouts has joined #openstack-sdks10:53
mlwow, I found more unexpected behavior than I expected. Have to touch the resources once again10:58
*** ttsiouts has quit IRC10:58
*** dtantsur|afk is now known as dtantsur11:16
*** ttsiouts has joined #openstack-sdks11:17
*** jpich has quit IRC11:40
*** jpich has joined #openstack-sdks11:41
*** bobh has joined #openstack-sdks12:06
mnasermordred: https://github.com/ansible/ansible/pull/4468612:09
mnaserI’ve reviewed it a while back12:09
mnaserAnd I think it’s mostly pretty well ready I think12:09
*** bobh has quit IRC12:11
*** gildub has quit IRC12:18
dtantsurhi folks, got a second for https://review.openstack.org/#/c/608674/ ?12:34
dtantsurapparently make baremetal update right from the first attempt is too hard :(12:34
*** mikeoschen has joined #openstack-sdks12:56
*** mriedem has joined #openstack-sdks12:58
mordreddtantsur: lgtm. Shrews ?12:58
Shrewseh?12:59
* Shrews looks12:59
Shrews{ self._alternate_id() or 'id': self.id } works?13:00
Shrewsi did not know you could do that with dict keys13:00
dtantsurI should have used brackets I guess :)13:01
dtantsurit's kind of: key = self._alternative_id() or 'id'13:01
dtantsur{ key: self.id }13:01
Shrewsyep, just threw me off. +313:02
mordredShrews: I learn python from dtantsur all the time13:03
dtantsur:D13:03
openstackgerritDmitry Tantsur proposed openstack/openstacksdk master: cloud: rename with deprecation validate_node -> validate_machine  https://review.openstack.org/60939913:08
mordreddtantsur: that's going to conflict with my delete-all-the-deprecated-things patch :)13:15
dtantsurmordred: it may :) should I switch off utils.deprecated?13:15
mordredyeah - I think maybe, especially since it's in the shade layer where we never remove old things, let's just rename the method and then do a 'validate_node = validate_machine' after it13:17
dtantsurmordred: can I still use the deprecation library itself?13:20
dtantsuror I can provide a custom warning13:20
mordreddtantsur: I think custom warning - like log.debug in this case - would be best13:23
dtantsurhmm, log.debug? I think in a similar situation you used the warnings module (because it's programmer's, not operator's choice)13:24
mordreddtantsur: oh - well ... that's because in that scenario doing the weird thing is actually a legit valid thing ... we might not support a service and the user might be using sdk to get a handle to the rest service13:25
mordredin this case, the user can totally change the call13:25
mordredalthough - you make a great point ...13:25
mordredif the user was using ansible, they wouldn't have the ability13:25
mordredbecuase the ansible module might be using the old call13:25
dtantsurand btw it probably is13:26
mordredyah13:26
mordredso yeah - maybe warnings.warn is better for this one. stupid backwards compat13:26
*** lbragstad has joined #openstack-sdks13:38
mordredShrews: if you have a sec - https://review.openstack.org/#/c/604521/ - you had some -1 on that earlier13:43
Shrewsmordred: doesn't appear you did anything with my comment  :-P13:44
jrollfungi: thanks for saying what I was trying to say, much better than I did (graphql thread)13:45
fungijroll: just trying to help get some clarity. i think you made some other good points13:46
jroll:)13:46
mordredShrews: oh - I didn't? crap13:47
Shrewsmordred: nope. comment was on ps613:57
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Remove all the deprecated stuff  https://review.openstack.org/60550813:59
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Start shifting cloud object-store methods to proxy  https://review.openstack.org/60831713:59
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Make it clear that OpenStackCloud is a mixin  https://review.openstack.org/60831813:59
openstackgerritDmitry Tantsur proposed openstack/openstacksdk master: cloud: rename with deprecation validate_node -> validate_machine  https://review.openstack.org/60939914:00
dtantsurmordred: ^^14:00
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Add support for per-service rate limits  https://review.openstack.org/60452114:02
mordredShrews: sorry about that - thanks14:02
mordreddtantsur: ++14:03
Luzimordred, did you read the mail concerning Image encryption? http://lists.openstack.org/pipermail/openstack-dev/2018-September/135167.html14:08
*** bobh has joined #openstack-sdks14:11
*** e0ne has quit IRC14:12
mordredLuzi: I did not - sounds like a thing I should read :)14:12
Luziyeah, basically we would like to use the encryption and decryption methods in nova, cinder and osc. And we still wondering where to put these.14:13
*** dtantsur is now known as dtantsur|brb14:13
mordredLuzi: awesome. I've got it open in my browser - am at openstack days nordic right now so it may take me a few minutes to fully digest14:16
Luzimordred: okay, we would appreciate input on the mailinglist too, so take your time :)14:17
openstackgerritDaniel Speichert proposed openstack/openstacksdk master: Added basic CRUD functionality around Host Aggregates  https://review.openstack.org/60941614:20
openstackgerritDaniel Speichert proposed openstack/openstacksdk master: Added basic CRUD functionality around Host Aggregates  https://review.openstack.org/60941614:28
mlthe delete methods implemented in the new data model call the delete() method of the resource, however ignore the return value14:30
mlis this intended? the return value of Resource.delete() is quiet valuable since it informs whether the resource was deleted or never existed in the first place14:31
mlexample: https://github.com/openstack/openstacksdk/blob/master/openstack/network/v2/_proxy.py#L8814:31
*** johnsom has joined #openstack-sdks14:31
mlthis would save an additional request in the openstackcloud wrapper14:33
mlnvm, the ignore_missing is obviously the way to go14:35
*** ttsiouts has quit IRC14:40
openstackgerritJohannes Kulik proposed openstack/osc-lib master: Add option to replace `shell.prompt_for_password`  https://review.openstack.org/60943314:45
*** ttsiouts has joined #openstack-sdks14:46
*** Luzi has quit IRC14:55
*** e0ne has joined #openstack-sdks14:58
*** ttsiouts has quit IRC15:21
*** ttsiouts has joined #openstack-sdks15:21
*** ttsiouts has quit IRC15:26
*** Guest10461 is now known as dims15:44
*** e0ne has quit IRC15:47
*** e0ne has joined #openstack-sdks15:50
openstackgerritSean McGinnis proposed openstack/python-openstackclient master: Handle not having cinderclient.v1 available  https://review.openstack.org/60947316:14
*** dtantsur|brb is now known as dtantsur16:15
dtantsurheads up: bifrost is broken, presumably by the oslo.messaging release16:17
dtantsurolivierb is working on a fix apparently16:17
dtantsurmordred: sorry, we ate your CI ^^^16:18
olivierbdtantsur mordred yes should be coming shortly, sorry was afk for a bit16:20
*** jpich has quit IRC16:33
*** e0ne has quit IRC16:41
olivierbavailable as https://review.openstack.org/60949917:08
*** dtantsur is now known as dtantsur|afk17:34
*** guilhermesp has joined #openstack-sdks18:38
*** olaph has quit IRC18:57
*** gildub has joined #openstack-sdks19:07
*** e0ne has joined #openstack-sdks19:22
*** olivierb has quit IRC19:30
openstackgerritDaniel Speichert proposed openstack/openstacksdk master: Added basic CRUD functionality around Host Aggregates  https://review.openstack.org/60941619:33
*** dave-mccowan has quit IRC19:34
*** dave-mccowan has joined #openstack-sdks19:44
openstackgerritSean McGinnis proposed openstack/python-openstackclient master: Handle not having cinderclient.v1 available  https://review.openstack.org/60947319:55
*** gildub has quit IRC21:01
*** slaweq has quit IRC21:04
*** bobh has quit IRC21:05
*** e0ne has quit IRC21:06
*** bobh has joined #openstack-sdks21:07
*** slaweq has joined #openstack-sdks21:11
*** bobh has quit IRC21:12
*** slaweq has quit IRC21:16
*** bobh has joined #openstack-sdks21:44
*** slaweq has joined #openstack-sdks22:11
*** slaweq has quit IRC22:15
*** tosky has quit IRC22:19
*** bobh has quit IRC22:21
*** bobh has joined #openstack-sdks22:56
*** bobh has quit IRC23:01
*** gildub has joined #openstack-sdks23:11
*** slaweq has joined #openstack-sdks23:11
*** slaweq has quit IRC23:16
*** mriedem has quit IRC23:18

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!