*** lbragstad has joined #openstack-sdks | 00:16 | |
*** slaweq has joined #openstack-sdks | 01:11 | |
*** slaweq has quit IRC | 01:15 | |
*** openstackgerrit has quit IRC | 01:37 | |
*** d0ugal has quit IRC | 01:37 | |
*** Horrorcat has quit IRC | 01:37 | |
*** mugsie has quit IRC | 01:37 | |
*** jroll has quit IRC | 01:37 | |
*** odyssey4me has quit IRC | 01:37 | |
*** dmellado has quit IRC | 01:37 | |
*** markvoelker has quit IRC | 01:37 | |
*** edleafe has quit IRC | 01:37 | |
*** dtroyer has quit IRC | 01:37 | |
*** dave-mccowan has quit IRC | 01:37 | |
*** guilhermesp has quit IRC | 01:37 | |
*** johnsom has quit IRC | 01:37 | |
*** mgagne has quit IRC | 01:37 | |
*** knikolla has quit IRC | 01:37 | |
*** lastmikoi has quit IRC | 01:37 | |
*** gmann has quit IRC | 01:37 | |
*** gouthamr has quit IRC | 01:37 | |
*** Shrews has quit IRC | 01:37 | |
*** brtknr has quit IRC | 01:37 | |
*** jamielennox has quit IRC | 01:37 | |
*** ebbex has quit IRC | 01:37 | |
*** pooja_jadhav has quit IRC | 01:37 | |
*** amotoki has quit IRC | 01:37 | |
*** dtantsur|afk has quit IRC | 01:37 | |
*** stephenfin has quit IRC | 01:37 | |
*** amito has quit IRC | 01:37 | |
*** dtruong has quit IRC | 01:37 | |
*** dasp has quit IRC | 01:37 | |
*** kmalloc has quit IRC | 01:37 | |
*** mrhillsman has quit IRC | 01:37 | |
*** cmurphy has quit IRC | 01:37 | |
*** Hazelesque has quit IRC | 01:37 | |
*** lbragstad has quit IRC | 01:37 | |
*** imacdonn has quit IRC | 01:37 | |
*** olaph has quit IRC | 01:37 | |
*** adriant has quit IRC | 01:37 | |
*** dhellmann has quit IRC | 01:37 | |
*** madorn has quit IRC | 01:37 | |
*** tonyb has quit IRC | 01:37 | |
*** ml has quit IRC | 01:37 | |
*** rm_work has quit IRC | 01:37 | |
*** fungi has quit IRC | 01:37 | |
*** christi3k has quit IRC | 01:37 | |
*** samueldmq has quit IRC | 01:37 | |
*** melwitt has quit IRC | 01:37 | |
*** ignatenkobrain has quit IRC | 01:37 | |
*** rabel has quit IRC | 01:37 | |
*** tobberydberg has quit IRC | 01:37 | |
*** gtmanfred has quit IRC | 01:37 | |
*** nicholas has quit IRC | 01:37 | |
*** sc68cal has quit IRC | 01:37 | |
*** mnaser has quit IRC | 01:37 | |
*** TheJulia has quit IRC | 01:37 | |
*** zxiiro-pto has quit IRC | 01:37 | |
*** mordred has quit IRC | 01:37 | |
*** rods_ has quit IRC | 01:37 | |
*** dims has quit IRC | 01:37 | |
*** elmiko has quit IRC | 01:37 | |
*** tobiash has quit IRC | 01:37 | |
*** purplerbot has quit IRC | 01:37 | |
*** mmedvede has quit IRC | 01:37 | |
*** timburke has quit IRC | 01:37 | |
*** Jeffrey4l has quit IRC | 01:37 | |
*** dayou has quit IRC | 01:37 | |
*** zigo has quit IRC | 01:37 | |
*** smcginnis has quit IRC | 01:37 | |
*** ianw has quit IRC | 01:37 | |
*** Qiming has quit IRC | 01:37 | |
*** frickler has quit IRC | 01:37 | |
*** charz has quit IRC | 01:37 | |
*** Qiming has joined #openstack-sdks | 01:43 | |
*** ianw has joined #openstack-sdks | 01:43 | |
*** odyssey4me has joined #openstack-sdks | 01:43 | |
*** jroll has joined #openstack-sdks | 01:43 | |
*** Horrorcat has joined #openstack-sdks | 01:43 | |
*** d0ugal has joined #openstack-sdks | 01:43 | |
*** mugsie has joined #openstack-sdks | 01:43 | |
*** zigo has joined #openstack-sdks | 01:43 | |
*** smcginnis has joined #openstack-sdks | 01:43 | |
*** dayou has joined #openstack-sdks | 01:43 | |
*** Jeffrey4l has joined #openstack-sdks | 01:43 | |
*** timburke has joined #openstack-sdks | 01:43 | |
*** mmedvede has joined #openstack-sdks | 01:43 | |
*** purplerbot has joined #openstack-sdks | 01:43 | |
*** gmann has joined #openstack-sdks | 01:44 | |
*** fungi has joined #openstack-sdks | 01:44 | |
*** rm_work has joined #openstack-sdks | 01:44 | |
*** christi3k has joined #openstack-sdks | 01:44 | |
*** samueldmq has joined #openstack-sdks | 01:44 | |
*** melwitt has joined #openstack-sdks | 01:44 | |
*** gouthamr has joined #openstack-sdks | 01:44 | |
*** Shrews has joined #openstack-sdks | 01:44 | |
*** brtknr has joined #openstack-sdks | 01:44 | |
*** jamielennox has joined #openstack-sdks | 01:44 | |
*** ebbex has joined #openstack-sdks | 01:44 | |
*** openstackgerrit has joined #openstack-sdks | 01:44 | |
*** frickler has joined #openstack-sdks | 01:45 | |
*** charz has joined #openstack-sdks | 01:45 | |
*** pooja_jadhav has joined #openstack-sdks | 01:45 | |
*** amotoki has joined #openstack-sdks | 01:45 | |
*** dtantsur|afk has joined #openstack-sdks | 01:45 | |
*** stephenfin has joined #openstack-sdks | 01:45 | |
*** mrhillsman has joined #openstack-sdks | 01:45 | |
*** amito has joined #openstack-sdks | 01:45 | |
*** dtruong has joined #openstack-sdks | 01:45 | |
*** dasp has joined #openstack-sdks | 01:45 | |
*** kmalloc has joined #openstack-sdks | 01:45 | |
*** cmurphy has joined #openstack-sdks | 01:45 | |
*** Hazelesque has joined #openstack-sdks | 01:45 | |
*** dtroyer has joined #openstack-sdks | 01:45 | |
*** dmellado has joined #openstack-sdks | 01:46 | |
*** markvoelker has joined #openstack-sdks | 01:46 | |
*** edleafe has joined #openstack-sdks | 01:46 | |
*** sc68cal has joined #openstack-sdks | 01:46 | |
*** nicholas has joined #openstack-sdks | 01:46 | |
*** zxiiro-pto has joined #openstack-sdks | 01:46 | |
*** gtmanfred has joined #openstack-sdks | 01:46 | |
*** mnaser has joined #openstack-sdks | 01:46 | |
*** TheJulia has joined #openstack-sdks | 01:46 | |
*** mordred has joined #openstack-sdks | 01:46 | |
*** rabel has joined #openstack-sdks | 01:46 | |
*** ignatenkobrain has joined #openstack-sdks | 01:46 | |
*** tobberydberg has joined #openstack-sdks | 01:46 | |
*** imacdonn has joined #openstack-sdks | 01:46 | |
*** olaph has joined #openstack-sdks | 01:46 | |
*** adriant has joined #openstack-sdks | 01:46 | |
*** dhellmann has joined #openstack-sdks | 01:46 | |
*** ml has joined #openstack-sdks | 01:46 | |
*** madorn has joined #openstack-sdks | 01:46 | |
*** tonyb has joined #openstack-sdks | 01:46 | |
*** rods_ has joined #openstack-sdks | 01:46 | |
*** elmiko has joined #openstack-sdks | 01:46 | |
*** tobiash has joined #openstack-sdks | 01:46 | |
*** lbragstad has joined #openstack-sdks | 01:48 | |
*** mgagne has joined #openstack-sdks | 01:49 | |
*** Guest10461 has joined #openstack-sdks | 01:49 | |
*** dave-mccowan has joined #openstack-sdks | 01:49 | |
*** lastmikoi has joined #openstack-sdks | 01:55 | |
*** lbragstad has quit IRC | 02:14 | |
openstackgerrit | Nguyen Van Trung proposed openstack/cliff master: Don't quote {posargs} in tox.ini https://review.openstack.org/609185 | 02:33 |
---|---|---|
*** dave-mccowan has quit IRC | 03:08 | |
*** slaweq has joined #openstack-sdks | 03:11 | |
*** slaweq has quit IRC | 03:16 | |
*** gkadam has joined #openstack-sdks | 04:42 | |
*** slaweq has joined #openstack-sdks | 05:11 | |
*** gkadam has quit IRC | 06:18 | |
*** olivierb has joined #openstack-sdks | 06:42 | |
*** Luzi has joined #openstack-sdks | 06:55 | |
*** odyssey4me has quit IRC | 07:07 | |
*** odyssey4me has joined #openstack-sdks | 07:08 | |
*** mugsie has quit IRC | 07:08 | |
*** mgagne has quit IRC | 07:09 | |
*** mgagne has joined #openstack-sdks | 07:10 | |
*** jroll has quit IRC | 07:10 | |
*** lastmikoi has quit IRC | 07:10 | |
*** jroll has joined #openstack-sdks | 07:12 | |
*** ttsiouts has joined #openstack-sdks | 07:12 | |
*** lastmikoi has joined #openstack-sdks | 07:14 | |
*** jpich has joined #openstack-sdks | 07:21 | |
*** mgagne has quit IRC | 07:34 | |
*** ttsiouts has quit IRC | 07:35 | |
*** mgagne has joined #openstack-sdks | 07:36 | |
*** tosky has joined #openstack-sdks | 07:42 | |
*** gkadam has joined #openstack-sdks | 07:55 | |
*** ttsiouts has joined #openstack-sdks | 07:59 | |
*** ttsiouts has quit IRC | 08:05 | |
*** ttsiouts has joined #openstack-sdks | 08:08 | |
*** ttsiouts has quit IRC | 08:14 | |
*** ttsiouts has joined #openstack-sdks | 08:21 | |
*** jpich has quit IRC | 09:16 | |
*** jpich has joined #openstack-sdks | 09:17 | |
*** jpich has quit IRC | 09:36 | |
*** jpich has joined #openstack-sdks | 09:36 | |
*** imacdonn has quit IRC | 09:52 | |
*** imacdonn has joined #openstack-sdks | 09:52 | |
mordred | ml: that patch looks great! | 10:04 |
mordred | samueldmq: https://review.openstack.org/#/c/604811 <-- you might find this interesting | 10:05 |
ml | Thanks for the review! | 10:05 |
samueldmq | mordred: oh that's using the sdk data model | 10:10 |
samueldmq | mordred: ml : commented on that. suggested a few improvements | 10:15 |
mordred | samueldmq: yah - I haven't gotten far enough along to explore that yet - but I've been thinking that we could migrate from the normalize methods to using the sdk data model - and maybe some times have some of the logic be in the sdk proxy methods - I was going to try it with create_image | 10:15 |
mordred | samueldmq: awesome, thanks! | 10:15 |
ml | samueldmq: Thanks, will have a look# | 10:16 |
samueldmq | mordred: we'd still need something like normalzie anyways | 10:16 |
samueldmq | I know sdk data model already maps some of the attributes, such as enabled -> is_enabled in the data model definition | 10:17 |
samueldmq | but we'd need to map that against the current shade contract/data model | 10:17 |
samueldmq | because we don't want to change that right | 10:17 |
mordred | yes, you're exactly right | 10:20 |
mordred | although maybe it'll be enough to just update the sdk model to be the same as the normalize contract in shade? | 10:20 |
*** ttsiouts has quit IRC | 10:20 | |
samueldmq | if the sdk side is okay updating their contact, it'd be awesome | 10:21 |
ml | samueldmq: you think it's a good idea to put 14 parameters in the function signature? Feels messy | 10:22 |
samueldmq | ml: well, see https://github.com/openstack/openstacksdk/blob/master/openstack/cloud/openstackcloud.py#L6751-L6766 for create_server | 10:23 |
samueldmq | ml: don't necessarily need to put in the signature, see the valid_kwargs annotation | 10:23 |
samueldmq | ml: I'd probably go with that as you don't do any work on the parameters before passsing on to the server | 10:23 |
ml | ahh, yeah. @_utils.valid_kwargs sounds good | 10:24 |
samueldmq | ml: awesome. btw I didn't mean you should because create_server does more params than that | 10:26 |
ml | also, sadly no, name_or_id doesn't uniquely identify the resource since multiple resources can have the same name | 10:26 |
samueldmq | but for the reasons I put on the review :) | 10:26 |
samueldmq | ml: so please make it clear in the docs that filters might need to be used when a name is provided | 10:27 |
samueldmq | also, document what happens if you provider a name and filters combination that gets you more than one resource | 10:27 |
samueldmq | when you're callling the update or delete mehtod, for example. does it update'em all? delete them all? throws exception? | 10:28 |
samueldmq | s/throws/raises , throwing exceptions remembers me of java | 10:28 |
*** gildub has joined #openstack-sdks | 10:29 | |
ml | alright, I'll add :raises [exc]: where necessary | 10:30 |
samueldmq | ml: nice. thanks for that, it's awesome work | 10:30 |
samueldmq | I have to go afk for a bit | 10:31 |
ml | samueldmq: Thanks for the review. Will fix asap. | 10:31 |
*** ttsiouts has joined #openstack-sdks | 10:32 | |
*** dave-mccowan has joined #openstack-sdks | 10:32 | |
*** e0ne has joined #openstack-sdks | 10:51 | |
*** ttsiouts has quit IRC | 10:53 | |
*** ttsiouts has joined #openstack-sdks | 10:53 | |
ml | wow, I found more unexpected behavior than I expected. Have to touch the resources once again | 10:58 |
*** ttsiouts has quit IRC | 10:58 | |
*** dtantsur|afk is now known as dtantsur | 11:16 | |
*** ttsiouts has joined #openstack-sdks | 11:17 | |
*** jpich has quit IRC | 11:40 | |
*** jpich has joined #openstack-sdks | 11:41 | |
*** bobh has joined #openstack-sdks | 12:06 | |
mnaser | mordred: https://github.com/ansible/ansible/pull/44686 | 12:09 |
mnaser | I’ve reviewed it a while back | 12:09 |
mnaser | And I think it’s mostly pretty well ready I think | 12:09 |
*** bobh has quit IRC | 12:11 | |
*** gildub has quit IRC | 12:18 | |
dtantsur | hi folks, got a second for https://review.openstack.org/#/c/608674/ ? | 12:34 |
dtantsur | apparently make baremetal update right from the first attempt is too hard :( | 12:34 |
*** mikeoschen has joined #openstack-sdks | 12:56 | |
*** mriedem has joined #openstack-sdks | 12:58 | |
mordred | dtantsur: lgtm. Shrews ? | 12:58 |
Shrews | eh? | 12:59 |
* Shrews looks | 12:59 | |
Shrews | { self._alternate_id() or 'id': self.id } works? | 13:00 |
Shrews | i did not know you could do that with dict keys | 13:00 |
dtantsur | I should have used brackets I guess :) | 13:01 |
dtantsur | it's kind of: key = self._alternative_id() or 'id' | 13:01 |
dtantsur | { key: self.id } | 13:01 |
Shrews | yep, just threw me off. +3 | 13:02 |
mordred | Shrews: I learn python from dtantsur all the time | 13:03 |
dtantsur | :D | 13:03 |
openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: cloud: rename with deprecation validate_node -> validate_machine https://review.openstack.org/609399 | 13:08 |
mordred | dtantsur: that's going to conflict with my delete-all-the-deprecated-things patch :) | 13:15 |
dtantsur | mordred: it may :) should I switch off utils.deprecated? | 13:15 |
mordred | yeah - I think maybe, especially since it's in the shade layer where we never remove old things, let's just rename the method and then do a 'validate_node = validate_machine' after it | 13:17 |
dtantsur | mordred: can I still use the deprecation library itself? | 13:20 |
dtantsur | or I can provide a custom warning | 13:20 |
mordred | dtantsur: I think custom warning - like log.debug in this case - would be best | 13:23 |
dtantsur | hmm, log.debug? I think in a similar situation you used the warnings module (because it's programmer's, not operator's choice) | 13:24 |
mordred | dtantsur: oh - well ... that's because in that scenario doing the weird thing is actually a legit valid thing ... we might not support a service and the user might be using sdk to get a handle to the rest service | 13:25 |
mordred | in this case, the user can totally change the call | 13:25 |
mordred | although - you make a great point ... | 13:25 |
mordred | if the user was using ansible, they wouldn't have the ability | 13:25 |
mordred | becuase the ansible module might be using the old call | 13:25 |
dtantsur | and btw it probably is | 13:26 |
mordred | yah | 13:26 |
mordred | so yeah - maybe warnings.warn is better for this one. stupid backwards compat | 13:26 |
*** lbragstad has joined #openstack-sdks | 13:38 | |
mordred | Shrews: if you have a sec - https://review.openstack.org/#/c/604521/ - you had some -1 on that earlier | 13:43 |
Shrews | mordred: doesn't appear you did anything with my comment :-P | 13:44 |
jroll | fungi: thanks for saying what I was trying to say, much better than I did (graphql thread) | 13:45 |
fungi | jroll: just trying to help get some clarity. i think you made some other good points | 13:46 |
jroll | :) | 13:46 |
mordred | Shrews: oh - I didn't? crap | 13:47 |
Shrews | mordred: nope. comment was on ps6 | 13:57 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove all the deprecated stuff https://review.openstack.org/605508 | 13:59 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Start shifting cloud object-store methods to proxy https://review.openstack.org/608317 | 13:59 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Make it clear that OpenStackCloud is a mixin https://review.openstack.org/608318 | 13:59 |
openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: cloud: rename with deprecation validate_node -> validate_machine https://review.openstack.org/609399 | 14:00 |
dtantsur | mordred: ^^ | 14:00 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add support for per-service rate limits https://review.openstack.org/604521 | 14:02 |
mordred | Shrews: sorry about that - thanks | 14:02 |
mordred | dtantsur: ++ | 14:03 |
Luzi | mordred, did you read the mail concerning Image encryption? http://lists.openstack.org/pipermail/openstack-dev/2018-September/135167.html | 14:08 |
*** bobh has joined #openstack-sdks | 14:11 | |
*** e0ne has quit IRC | 14:12 | |
mordred | Luzi: I did not - sounds like a thing I should read :) | 14:12 |
Luzi | yeah, basically we would like to use the encryption and decryption methods in nova, cinder and osc. And we still wondering where to put these. | 14:13 |
*** dtantsur is now known as dtantsur|brb | 14:13 | |
mordred | Luzi: awesome. I've got it open in my browser - am at openstack days nordic right now so it may take me a few minutes to fully digest | 14:16 |
Luzi | mordred: okay, we would appreciate input on the mailinglist too, so take your time :) | 14:17 |
openstackgerrit | Daniel Speichert proposed openstack/openstacksdk master: Added basic CRUD functionality around Host Aggregates https://review.openstack.org/609416 | 14:20 |
openstackgerrit | Daniel Speichert proposed openstack/openstacksdk master: Added basic CRUD functionality around Host Aggregates https://review.openstack.org/609416 | 14:28 |
ml | the delete methods implemented in the new data model call the delete() method of the resource, however ignore the return value | 14:30 |
ml | is this intended? the return value of Resource.delete() is quiet valuable since it informs whether the resource was deleted or never existed in the first place | 14:31 |
ml | example: https://github.com/openstack/openstacksdk/blob/master/openstack/network/v2/_proxy.py#L88 | 14:31 |
*** johnsom has joined #openstack-sdks | 14:31 | |
ml | this would save an additional request in the openstackcloud wrapper | 14:33 |
ml | nvm, the ignore_missing is obviously the way to go | 14:35 |
*** ttsiouts has quit IRC | 14:40 | |
openstackgerrit | Johannes Kulik proposed openstack/osc-lib master: Add option to replace `shell.prompt_for_password` https://review.openstack.org/609433 | 14:45 |
*** ttsiouts has joined #openstack-sdks | 14:46 | |
*** Luzi has quit IRC | 14:55 | |
*** e0ne has joined #openstack-sdks | 14:58 | |
*** ttsiouts has quit IRC | 15:21 | |
*** ttsiouts has joined #openstack-sdks | 15:21 | |
*** ttsiouts has quit IRC | 15:26 | |
*** Guest10461 is now known as dims | 15:44 | |
*** e0ne has quit IRC | 15:47 | |
*** e0ne has joined #openstack-sdks | 15:50 | |
openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Handle not having cinderclient.v1 available https://review.openstack.org/609473 | 16:14 |
*** dtantsur|brb is now known as dtantsur | 16:15 | |
dtantsur | heads up: bifrost is broken, presumably by the oslo.messaging release | 16:17 |
dtantsur | olivierb is working on a fix apparently | 16:17 |
dtantsur | mordred: sorry, we ate your CI ^^^ | 16:18 |
olivierb | dtantsur mordred yes should be coming shortly, sorry was afk for a bit | 16:20 |
*** jpich has quit IRC | 16:33 | |
*** e0ne has quit IRC | 16:41 | |
olivierb | available as https://review.openstack.org/609499 | 17:08 |
*** dtantsur is now known as dtantsur|afk | 17:34 | |
*** guilhermesp has joined #openstack-sdks | 18:38 | |
*** olaph has quit IRC | 18:57 | |
*** gildub has joined #openstack-sdks | 19:07 | |
*** e0ne has joined #openstack-sdks | 19:22 | |
*** olivierb has quit IRC | 19:30 | |
openstackgerrit | Daniel Speichert proposed openstack/openstacksdk master: Added basic CRUD functionality around Host Aggregates https://review.openstack.org/609416 | 19:33 |
*** dave-mccowan has quit IRC | 19:34 | |
*** dave-mccowan has joined #openstack-sdks | 19:44 | |
openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Handle not having cinderclient.v1 available https://review.openstack.org/609473 | 19:55 |
*** gildub has quit IRC | 21:01 | |
*** slaweq has quit IRC | 21:04 | |
*** bobh has quit IRC | 21:05 | |
*** e0ne has quit IRC | 21:06 | |
*** bobh has joined #openstack-sdks | 21:07 | |
*** slaweq has joined #openstack-sdks | 21:11 | |
*** bobh has quit IRC | 21:12 | |
*** slaweq has quit IRC | 21:16 | |
*** bobh has joined #openstack-sdks | 21:44 | |
*** slaweq has joined #openstack-sdks | 22:11 | |
*** slaweq has quit IRC | 22:15 | |
*** tosky has quit IRC | 22:19 | |
*** bobh has quit IRC | 22:21 | |
*** bobh has joined #openstack-sdks | 22:56 | |
*** bobh has quit IRC | 23:01 | |
*** gildub has joined #openstack-sdks | 23:11 | |
*** slaweq has joined #openstack-sdks | 23:11 | |
*** slaweq has quit IRC | 23:16 | |
*** mriedem has quit IRC | 23:18 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!