| *** dave-mccowan has joined #openstack-sdks | 01:03 | |
| *** slaweq has joined #openstack-sdks | 01:11 | |
| *** chenyb4 has joined #openstack-sdks | 01:15 | |
| *** slaweq has quit IRC | 01:15 | |
| openstackgerrit | wangxiyuan proposed openstack/openstacksdk master: Add registered limit CRUD support https://review.openstack.org/609572 | 01:34 |
|---|---|---|
| openstackgerrit | wangxiyuan proposed openstack/openstacksdk master: Add limit CRUD support https://review.openstack.org/609604 | 01:34 |
| openstackgerrit | wangxiyuan proposed openstack/openstacksdk master: Add registered limit CRUD support https://review.openstack.org/609572 | 01:36 |
| openstackgerrit | wangxiyuan proposed openstack/openstacksdk master: Add limit CRUD support https://review.openstack.org/609604 | 01:36 |
| *** dave-mccowan has quit IRC | 01:53 | |
| *** d0ugal has quit IRC | 02:16 | |
| *** d0ugal has joined #openstack-sdks | 02:20 | |
| openstackgerrit | wangxiyuan proposed openstack/openstacksdk master: Add registered limit CRUD support https://review.openstack.org/609572 | 03:01 |
| openstackgerrit | wangxiyuan proposed openstack/openstacksdk master: Add limit CRUD support https://review.openstack.org/609604 | 03:01 |
| openstackgerrit | wangxiyuan proposed openstack/openstacksdk master: Remove duplicate code https://review.openstack.org/610404 | 03:06 |
| *** slaweq has joined #openstack-sdks | 03:45 | |
| *** slaweq has quit IRC | 03:49 | |
| *** e0ne has joined #openstack-sdks | 06:00 | |
| *** Luzi has joined #openstack-sdks | 06:10 | |
| *** e0ne has quit IRC | 06:28 | |
| *** pooja_jadhav has joined #openstack-sdks | 06:31 | |
| *** slaweq has joined #openstack-sdks | 06:42 | |
| *** tosky has joined #openstack-sdks | 07:45 | |
| *** ttsiouts has joined #openstack-sdks | 08:04 | |
| *** jpich has joined #openstack-sdks | 08:06 | |
| *** ttsiouts has quit IRC | 08:06 | |
| *** ttsiouts has joined #openstack-sdks | 08:17 | |
| *** ttsiouts has quit IRC | 08:22 | |
| *** ttsiouts has joined #openstack-sdks | 08:24 | |
| *** olivierb has joined #openstack-sdks | 08:51 | |
| *** ttsiouts has quit IRC | 09:11 | |
| *** ttsiouts has joined #openstack-sdks | 09:12 | |
| *** ttsiouts has quit IRC | 09:16 | |
| *** ttsiouts has joined #openstack-sdks | 09:17 | |
| dtantsur | mordred: impressive! | 09:41 |
| *** imacdonn has quit IRC | 09:54 | |
| *** imacdonn has joined #openstack-sdks | 09:54 | |
| samueldmq | morning | 10:13 |
| samueldmq | does recall if there was ever a version 1 of keystone, nova and neutron? | 10:13 |
| samueldmq | I suspect there was but only in the first days of openstack. I don't remember why we chose to jump to 2.0 on all those.. | 10:14 |
| samueldmq | mordred: ^ I know you were here since the first days ... so you might know somehting about thsi | 10:14 |
| *** charz has quit IRC | 10:15 | |
| *** ttsiouts has quit IRC | 10:19 | |
| frickler | samueldmq: this has a bit of history for keystone https://docs.openstack.org/keystone/pike/contributor/http-api.html#history . I'm also pretty sure neutron only ever implemented v2, but I can only guess that that happened in order to match nova when it was split out | 10:22 |
| frickler | samueldmq: and this makes me assume that nova v1 was also the legacy rackspace api https://blueprints.launchpad.net/openstack-sdk-php/+spec/nova-api-v1 | 10:24 |
| samueldmq | Hmm. Awesome | 10:37 |
| samueldmq | Thanks frickler | 10:37 |
| *** dave-mccowan has joined #openstack-sdks | 11:01 | |
| *** chenyb4 has quit IRC | 11:07 | |
| dtantsur | frickler++ this is interesting | 11:10 |
| *** dtantsur is now known as dtantsur|brb | 11:30 | |
| *** ttsiouts has joined #openstack-sdks | 11:40 | |
| *** ttsiouts has quit IRC | 12:25 | |
| *** ttsiouts has joined #openstack-sdks | 12:35 | |
| *** jroll has quit IRC | 12:38 | |
| *** jroll has joined #openstack-sdks | 12:39 | |
| *** dtantsur|brb is now known as dtantsur | 12:59 | |
| *** bobh has joined #openstack-sdks | 13:07 | |
| mordred | frickler: yes - nova v1 was the legacy rackspace api ... keystone v1 was, iirc, the legacy rackspace auth | 13:18 |
| mordred | ah - yes, that link above says much the same about keystone | 13:18 |
| mordred | samueldmq: ^^ | 13:18 |
| *** mriedem has joined #openstack-sdks | 13:19 | |
| *** lbragstad has joined #openstack-sdks | 13:20 | |
| *** zxiiro-pto is now known as zxiiro | 13:23 | |
| samueldmq | mordred: awesome, thanks for confirming | 13:32 |
| samueldmq | that helps answering the question "why does sdk not support those API versions?" | 13:32 |
| mordred | dtantsur: so - in a very slow answer to your question - yes, you should be worried about http methods ignoring error_message ... error_message is a parameter to _adapter._json_response - so that means we missed an update to a callsite | 13:32 |
| mordred | samueldmq: ++ | 13:32 |
| samueldmq | mordred: it would probably be useful to have that somewhere in our docs | 13:33 |
| dtantsur | mordred: that's what I suspected | 13:33 |
| * mordred is fixing | 13:33 | |
| *** dave-mccowan has quit IRC | 13:42 | |
| *** dave-mccowan has joined #openstack-sdks | 13:43 | |
| *** cdent has joined #openstack-sdks | 13:56 | |
| *** Luzi has quit IRC | 13:58 | |
| *** elmiko has joined #openstack-sdks | 14:07 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use network proxy in openstack.cloud https://review.openstack.org/604645 | 14:15 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove all the deprecated stuff https://review.openstack.org/605508 | 14:15 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Start shifting cloud object-store methods to proxy https://review.openstack.org/608317 | 14:15 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Make it clear that OpenStackCloud is a mixin https://review.openstack.org/608318 | 14:15 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Revert the Proxy metaclass https://review.openstack.org/609747 | 14:15 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rearrange shade image code https://review.openstack.org/609683 | 14:15 |
| mordred | dtantsur: ok. I think 604645 is good now | 14:16 |
| dtantsur | great :) | 14:20 |
| dtantsur | mordred: re _normalize_* stuffs: what is its role? | 14:20 |
| dtantsur | I thought as a bare minimum we should remove "links", etc? | 14:20 |
| *** jamielennox has quit IRC | 14:27 | |
| *** jamielennox has joined #openstack-sdks | 14:29 | |
| mordred | dtantsur: well - long term I think _normalize_* should go away and the data model contract should just be expressed in the Resource objects ... | 14:53 |
| mordred | but that's a little handwavey | 14:54 |
| dtantsur | the Resource objects do have a bit technical things like "links". do we want to keep them in the output? | 14:54 |
| mordred | dtantsur: it's a good question. I'm less opposed to them than I was in years past because we have the underlying structure to do something with them now (it use to be you got a link in a novaclient object, but didn't have any configured rest client that could actually make a request from that link) | 15:05 |
| mordred | so maybe they're ok to keep around now? or maybe they're a terrible idea ... | 15:05 |
| dtantsur | I'm fine with either way, but we need it consistent | 15:07 |
| dtantsur | currently we're quite inconsistent, at least in the baremetal world | 15:07 |
| mordred | yah. I agre - consistency is the most important | 15:08 |
| mordred | dtantsur: to me I think it's more important that we get to a place where you get the same return object whether you use shade layer or proxy layer - because that way you can write nicer programs that sometimes use a higher-level helper method and sometimes lower-level methods | 15:09 |
| dtantsur | okay, then hiding links probably does not make much sense.. | 15:09 |
| mordred | yah | 15:09 |
| dtantsur | okay, so I'll probably drop _normalize_machine and won't introduce _normalize_nic | 15:10 |
| *** ttsiouts has quit IRC | 15:21 | |
| mordred | ++ | 15:23 |
| *** ttsiouts has joined #openstack-sdks | 15:40 | |
| *** melwitt has joined #openstack-sdks | 15:46 | |
| *** openstackgerrit has quit IRC | 15:47 | |
| *** openstackgerrit has joined #openstack-sdks | 15:47 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: WIP Use proxy layer in shade networks https://review.openstack.org/610624 | 15:47 |
| mordred | samueldmq: there's a half-written stab at using self.network.networks() for list_networks ... | 15:47 |
| mordred | samueldmq: which I think may get us further than doing new normalize methods like https://review.openstack.org/#/c/602218 | 15:50 |
| dtantsur | heh, openstackcloud.py is so big, it even makes vim slow :D | 15:50 |
| mordred | dtantsur: hehe | 15:50 |
| openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Switch bare metal NIC actions in OpenStackCloud to baremetal Proxy calls https://review.openstack.org/610024 | 15:51 |
| *** e0ne has joined #openstack-sdks | 16:04 | |
| samueldmq | mordred: kk, I'll take a look at that today | 16:06 |
| samueldmq | mordred: it'd be awesome to have that and the rest of the patches approved soon | 16:07 |
| samueldmq | they're all ready for review, passing tests | 16:07 |
| mordred | yah | 16:08 |
| mordred | samueldmq: it's also possible that what we should do is start by landing your normalize patches (possibly making sure that they normalize things into a form that also looks like the fields in the Resource classes) | 16:09 |
| samueldmq | except for a _metadata test that insists on failing intermitently | 16:09 |
| samueldmq | mordred: have you seen some gates breaking with taht? | 16:10 |
| *** ttsiouts has quit IRC | 16:10 | |
| mordred | and then a second set of patches to shift to using Resource- so that we can see the test updates along with the normalize (I think we're likely going to need to change some of the tests to be better) | 16:10 |
| samueldmq | mordred: ++ | 16:10 |
| mordred | I haven't? | 16:10 |
| mordred | samueldmq: although - my network patch from above (https://review.openstack.org/604645) is totally gonna merge-conflict yours | 16:10 |
| samueldmq | mordred: because for the specific esources that we don't normalize yet we need to include all the known attributes anyway | 16:10 |
| samueldmq | otherwise we wouldn't keep backwards compatibility upon normalziaiotn | 16:11 |
| mordred | samueldmq: yah | 16:11 |
| *** ttsiouts has joined #openstack-sdks | 16:11 | |
| mordred | samueldmq: well - althugh - within reason I'm ok with some skew here as we haven't ever defined a contract, and neutron objects are very variable depending on deployer plugins and stuff | 16:11 |
| samueldmq | mordred: so it's really free in the wild | 16:12 |
| mordred | so - I don't think we should go crazy, but I also don't think our tests of that api surface are particularly great, so I think we can make a best effort | 16:12 |
| mordred | yah | 16:12 |
| samueldmq | kk sounds reasonable | 16:12 |
| mordred | for instance - we're letting values like provider:physical_network through as keys directly - while the sdk resource is normalizing that to provider_physical_network | 16:13 |
| mordred | we might have to get clever at some point ... | 16:14 |
| samueldmq | mordred: you want to nomalize that? or should we keep both?[ | 16:14 |
| samueldmq | mordred: yes. I think we all understand we need to improve things at some point | 16:14 |
| mordred | :) | 16:15 |
| samueldmq | but we don't liek to talk about not being backwards compatible. perhaps a deprecation approach that is very solid could be adopted | 16:15 |
| *** ttsiouts has quit IRC | 16:15 | |
| mordred | yeah. or - maybe resource gives us enough tools to define 'provider:physical_network' as an alias for provider_physical_network | 16:15 |
| samueldmq | mordred: but then we keep including both formats forever? | 16:16 |
| mordred | so that if a user does network['provider:physical_network'] it'll still return a value - but the api docs will show network.provider_physical_network | 16:16 |
| samueldmq | hmm, we would need to support that while reading the munch | 16:16 |
| mordred | samueldmq: yeah - I think it's more generally thinking about how we provide a good and consistent interface but also letting people use the names from the service api docs? | 16:16 |
| samueldmq | even though it's not in the munch if you only do print(my_resource) | 16:17 |
| mordred | yeah. I *think* resource can already handle that | 16:17 |
| samueldmq | mordred: maybe. I don't like to think about the services at all | 16:17 |
| samueldmq | I like to think as a newcomer that just wants things done in a cloud | 16:17 |
| samueldmq | I don't care about being too clever, just use the basic things (get a server up) | 16:18 |
| samueldmq | and that's all shade is about right | 16:18 |
| *** e0ne has quit IRC | 16:21 | |
| samueldmq | mordred: I don't think we have a clear picture of what goes in abstraction layer and what doesn't in terms of depth in the resources | 16:22 |
| samueldmq | I get confused whether we want to have a one handle'em all abstraction layer, or really the most important/common | 16:23 |
| samueldmq | "Clouds can do many many many things - but there are probably only about 10 of them that most people care about with any regularity." | 16:23 |
| mordred | samueldmq: yah. I agree - it's definitely unclear | 16:24 |
| mordred | samueldmq: how I've been thinking about it recently is to try to make the Resource layer be similar to the _normalize_* methods from shade - so that we can have objects that are returned with consistent field names no matter which api you're using | 16:25 |
| samueldmq | mordred: sure for that part yes, I agree 100% | 16:26 |
| mordred | and then have shade have the "10 things more people care about" methods - and the sdk/proxy layer have the more service-oriented specific methods | 16:26 |
| mordred | so - like with that image patch as an example - there are methods in the proxy layer for image.v1.upload_image and image.v2.upload_image and block_storage.v2.create_image_from_volume - but in the shade layer there's still just 'create_image' that just works | 16:27 |
| *** e0ne has joined #openstack-sdks | 16:27 | |
| *** e0ne has quit IRC | 16:28 | |
| samueldmq | mordred: that makes total sense | 16:28 |
| samueldmq | what I was saying is that we should watch for how deep we go in representing resources. we might be normalizing to attributes that require not basic usage, let's keep abstraction layer simple | 16:29 |
| samueldmq | mordred: what if the user could define what their resources look like by defining their own aliases. does that make sense at all? | 16:30 |
| samueldmq | my rationale is that simple may vary from user to user, | 16:31 |
| *** cdent has left #openstack-sdks | 16:32 | |
| samueldmq | maybe that's not the best api design. can be crazy to maintain | 16:33 |
| mordred | samueldmq: hrm. it's an interesting thought ... but I think maybe what I'm thinking is somewhere in the middle | 16:35 |
| mordred | like, since Resource does magic with __getattribute__ anyway - we should be able to make any attribute of the original json from the service accessible? | 16:36 |
| samueldmq | what if I inherit Munch in MunchWithAliases | 16:36 |
| samueldmq | hmm yes that's the same concept | 16:37 |
| samueldmq | if I do print(network) it gives me {"provider_physical_network": True}, but I can access with | 16:38 |
| samueldmq | network['provider_physical_network'] == network['provider:physical_network'] == network.provider_physical_network | 16:38 |
| *** jpich has quit IRC | 16:44 | |
| samueldmq | mordred: yes you're right, https://github.com/openstack/openstacksdk/blob/master/openstack/object_store/v1/container.py#L42 | 16:53 |
| samueldmq | Resource can do that for us, with a single alias, but should be enoguh for now | 16:54 |
| *** dtantsur is now known as dtantsur|afk | 17:38 | |
| mordred | samueldmq: \o/ | 17:54 |
| openstackgerrit | Corey Bryant proposed openstack/keystoneauth master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610685 | 18:05 |
| *** dmellado has quit IRC | 18:05 | |
| *** dmellado has joined #openstack-sdks | 18:05 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove all the deprecated stuff https://review.openstack.org/605508 | 18:22 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Start shifting cloud object-store methods to proxy https://review.openstack.org/608317 | 18:22 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Make it clear that OpenStackCloud is a mixin https://review.openstack.org/608318 | 18:22 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Revert the Proxy metaclass https://review.openstack.org/609747 | 18:22 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rearrange shade image code https://review.openstack.org/609683 | 18:22 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: WIP Use proxy layer in shade networks https://review.openstack.org/610624 | 18:22 |
| *** bobh has quit IRC | 18:27 | |
| openstackgerrit | Maxime Guyot proposed openstack/openstacksdk master: Update Auro cloud profile https://review.openstack.org/610699 | 18:38 |
| *** Miouge has joined #openstack-sdks | 19:00 | |
| openstackgerrit | Maxime Guyot proposed openstack/openstacksdk master: Update ElastX cloud profile https://review.openstack.org/610704 | 19:04 |
| *** bobh has joined #openstack-sdks | 19:05 | |
| *** bobh has quit IRC | 19:05 | |
| *** bobh has joined #openstack-sdks | 19:06 | |
| openstackgerrit | Maxime Guyot proposed openstack/openstacksdk master: Update ElastX cloud profile https://review.openstack.org/610704 | 19:09 |
| *** bobh has quit IRC | 19:11 | |
| *** mriedem has quit IRC | 19:32 | |
| *** mriedem has joined #openstack-sdks | 19:35 | |
| *** bobh has joined #openstack-sdks | 20:08 | |
| *** bobh has quit IRC | 20:43 | |
| *** openstackgerrit has quit IRC | 21:56 | |
| *** openstackgerrit has joined #openstack-sdks | 21:58 | |
| *** openstackgerrit has quit IRC | 21:58 | |
| *** openstackgerrit has joined #openstack-sdks | 22:00 | |
| *** slaweq has quit IRC | 22:05 | |
| *** eandersson has joined #openstack-sdks | 22:07 | |
| openstackgerrit | Merged openstack/python-openstackclient master: Handle not having cinderclient.v1 available https://review.openstack.org/609473 | 22:07 |
| *** slaweq has joined #openstack-sdks | 22:11 | |
| *** openstackgerrit has quit IRC | 22:12 | |
| *** openstackgerrit has joined #openstack-sdks | 22:14 | |
| mordred | Shrews: if you're bored, the stack ending at https://review.openstack.org/#/c/609683 is green now | 22:15 |
| *** slaweq has quit IRC | 22:15 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: DNM Testing magnum gate fix https://review.openstack.org/610744 | 22:38 |
| *** openstackgerrit has quit IRC | 22:43 | |
| *** openstackgerrit has joined #openstack-sdks | 22:50 | |
| openstackgerrit | Filippo Inzaghi proposed openstack/cliff master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610746 | 22:50 |
| openstackgerrit | Filippo Inzaghi proposed openstack/openstackclient master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610748 | 22:50 |
| openstackgerrit | Filippo Inzaghi proposed openstack/osc-lib master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610749 | 22:52 |
| openstackgerrit | Filippo Inzaghi proposed openstack/python-openstackclient master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610751 | 22:52 |
| *** mriedem has quit IRC | 23:00 | |
| *** slaweq has joined #openstack-sdks | 23:11 | |
| *** slaweq has quit IRC | 23:16 | |
| *** tosky has quit IRC | 23:25 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!