| *** markvoelker has quit IRC | 00:02 | |
| openstackgerrit | Merged openstack/keystoneauth master: Update sphinx extension logging https://review.openstack.org/611135 | 00:44 |
|---|---|---|
| *** markvoelker has joined #openstack-sdks | 00:58 | |
| *** imacdonn has quit IRC | 01:22 | |
| *** imacdonn has joined #openstack-sdks | 01:22 | |
| *** markvoelker has quit IRC | 01:32 | |
| *** pooja_jadhav has quit IRC | 01:45 | |
| *** mhen has quit IRC | 01:47 | |
| *** pooja_jadhav has joined #openstack-sdks | 01:53 | |
| *** bobh has joined #openstack-sdks | 02:45 | |
| *** bobh has quit IRC | 02:46 | |
| *** bobh has joined #openstack-sdks | 02:46 | |
| *** bobh has quit IRC | 02:51 | |
| *** dave-mccowan has quit IRC | 03:53 | |
| *** Luzi has joined #openstack-sdks | 05:45 | |
| *** e0ne has joined #openstack-sdks | 06:37 | |
| openstackgerrit | Vishakha Agarwal proposed openstack/python-openstackclient master: Add project param in LimitList parser https://review.openstack.org/611789 | 06:59 |
| *** slaweq has quit IRC | 07:32 | |
| *** slaweq has joined #openstack-sdks | 07:33 | |
| *** tosky has joined #openstack-sdks | 07:36 | |
| *** e0ne has quit IRC | 08:03 | |
| *** e0ne has joined #openstack-sdks | 09:09 | |
| *** ttsiouts has joined #openstack-sdks | 09:12 | |
| openstackgerrit | Vlad Gusev proposed openstack/python-openstackclient master: Add support for get details of Quota https://review.openstack.org/515401 | 09:49 |
| *** cdent has joined #openstack-sdks | 10:35 | |
| openstackgerrit | Vishakha Agarwal proposed openstack/python-openstackclient master: Add project param in LimitList parser https://review.openstack.org/611789 | 10:37 |
| *** dtantsur|afk is now known as dtantsur | 10:43 | |
| dtantsur | mordred: hey, you need to re-add your +W to https://review.openstack.org/#/c/609984/ now that the dependency has merged | 10:44 |
| openstackgerrit | Vlad Gusev proposed openstack/python-openstackclient master: Add support for get details of Quota https://review.openstack.org/515401 | 10:47 |
| *** e0ne has quit IRC | 11:01 | |
| openstackgerrit | Vlad Gusev proposed openstack/python-openstackclient master: Add support for get details of Quota https://review.openstack.org/515401 | 11:38 |
| *** e0ne has joined #openstack-sdks | 11:52 | |
| *** mriedem has joined #openstack-sdks | 12:19 | |
| mordred | dtantsur: done | 12:24 |
| *** cdent has quit IRC | 12:24 | |
| dtantsur | thnx | 12:25 |
| mordred | dtantsur, Shrews, dtroyer, slaweq: I pushed up a release request for sdk for an 0.18.0 - I'm thinking it's *basically* an RC, but I was thinking that it would be a good idea to start making some python-openstackclient patches to start using it more there - so we can see what shakes out of that. I also think we should figure out the baremetal resource normalization question and finish those image api | 12:46 |
| mordred | patches | 12:46 |
| dtantsur | yep, cool | 12:46 |
| dtantsur | I think we'll need more deprecation for baremetal stuff in the shade part.. but we can left removals for 2.0 | 12:47 |
| mordred | but I'm figuring we can use writing osc patches to use sdk for images instead of python-glanceclient to spur finishing the image api stuff | 12:47 |
| mordred | dtantsur: ++ | 12:47 |
| mordred | frickler: if you're around, would you mind +Aing https://review.openstack.org/#/c/585030/ ? | 12:48 |
| dtantsur | mordred: oh, and we need to finish the story around rate limiting | 12:49 |
| mordred | oh - actually - hang on, let me bump mins in that | 12:49 |
| mordred | dtantsur: yes. thanks - that's the other thing we should finish | 12:49 |
| mordred | we should chat with cmurphy about whether the keystoneauth retries feature justifies putting the rate limiting down in keystoneauth | 12:50 |
| cmurphy | ah hmm that is a somewhat compelling case | 12:51 |
| *** gkadam has joined #openstack-sdks | 12:52 | |
| openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Make use of keystoneauth service-type filtering for versions https://review.openstack.org/585030 | 12:52 |
| mordred | cmurphy: yah - I wrote more words on that review - but dtantsur had a patch to sdk to make use of the retriable_status_codes feature - and that made me realize that if ksa is doing retries under the covers, it makes higher-level rate limiting have a hole where it doesn't know about some of the interactions | 12:53 |
| cmurphy | yeah that makes sense | 12:53 |
| frickler | mordred: that patch seems to have a merge conflict now that you updated it | 12:54 |
| mordred | that said - there's still a potential slight weirdness, as retries are implemented in the session, while a rate limit is really an adapter-level concept (so that it can be per-service) | 12:54 |
| mordred | frickler: *awesome* | 12:54 |
| mordred | lemme fix | 12:54 |
| openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Make use of keystoneauth service-type filtering for versions https://review.openstack.org/585030 | 12:55 |
| mordred | frickler: that should do it :) | 12:55 |
| *** stephenfin is now known as finucannot | 12:57 | |
| *** slaweq has quit IRC | 12:57 | |
| mordred | cmurphy: so I guess the important next step for that patch would be "write tests"? | 12:57 |
| cmurphy | mordred: I'm kind of hoping there is a non-DIY way of implementing the semaphore thing | 12:58 |
| cmurphy | mordred: but assuming there's not then tests would be a good next step | 12:59 |
| mordred | cmurphy: I didn't find one when I was looking - although I totally agree with you | 12:59 |
| mordred | I'm a bit sad there isn't one of these in the standard lib | 12:59 |
| frickler | mordred: oh, that's osc, I can only +1 there anyway, but lgtm | 12:59 |
| mordred | frickler: awesome, thanks! | 13:00 |
| mordred | cmurphy: maybe we should upstream this one to the python stdlib once we're happy with it. I'm sure that'll only take 8 years or something | 13:00 |
| cmurphy | :D | 13:00 |
| dtantsur | heh | 13:00 |
| dtantsur | Python 4.2 | 13:00 |
| cmurphy | lol | 13:01 |
| *** slaweq has joined #openstack-sdks | 13:07 | |
| samueldmq | morning sdk | 13:12 |
| mordred | morning samueldmq ! | 13:15 |
| *** lbragstad is now known as elbragstad | 13:23 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/openstacksdk master: DNM: Logging image code path https://review.openstack.org/611868 | 13:25 |
| *** slaweq has quit IRC | 13:27 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/openstacksdk master: DNM: Logging public server code path https://review.openstack.org/611869 | 13:29 |
| *** slaweq has joined #openstack-sdks | 13:49 | |
| *** mriedem has quit IRC | 14:06 | |
| *** Luzi has quit IRC | 14:07 | |
| *** mriedem has joined #openstack-sdks | 14:09 | |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Add support for client-side rate limiting https://review.openstack.org/605043 | 14:15 |
| mordred | dtantsur: ^^ I reworked it a bit based on your review and put the rate limit wait into the semaphore itself | 14:18 |
| mordred | dtantsur: I tried to add some comments - but it's still a pretty dense class | 14:18 |
| dtantsur | cool, will check | 14:18 |
| mordred | kmalloc, cmurphy: ^^ also y'all. of course, it can't land without tests - so I still have to figure that out - but if you feel like attacking it logically, awesome | 14:19 |
| * cmurphy gets out the torpedos | 14:24 | |
| dtantsur | mordred: I have a feeling there is a deadlock lurking there | 14:25 |
| dtantsur | see inline | 14:25 |
| mordred | dtantsur: ah - yeah. it should be fine as long as there are more than one thread executing at the same time - but not for the 1st thread or in a single-threaded mode ... good catch | 14:28 |
| dtantsur | mordred: I'm not sure how multiple thread would help. You're calling wait() while holding a lock. For wait() to return something needs to acquire the same lock and fire the event. | 14:30 |
| dtantsur | It cannot acquire the lock held during wait(). Am I missing something? | 14:30 |
| mordred | dtantsur: no - you're totally right | 14:31 |
| mordred | dtantsur: I need another coffee :) | 14:32 |
| dtantsur | mordred: the resource starvation problem you mention in the commit message.. is it really so bad to justify writing your own semaphore class? :) | 14:32 |
| mordred | dtantsur: yup :) | 14:33 |
| openstackgerrit | Stephen Finucane proposed openstack/cliff master: Remove dead files https://review.openstack.org/611888 | 14:34 |
| openstackgerrit | Stephen Finucane proposed openstack/cliff master: Stop wildcard importing argparse https://review.openstack.org/611889 | 14:34 |
| openstackgerrit | Stephen Finucane proposed openstack/cliff master: WIP: Add support for environment variables https://review.openstack.org/611890 | 14:34 |
| mordred | dtantsur: amazingly enough - all of the varied use cases this solves for are represented by actual real-world issues | 14:34 |
| mordred | dtantsur: you're think that the server side would just be able to handle all of this without the client needing to care ... but oh golly | 14:35 |
| dtantsur | that damn reality; I like dealing with round things in vacuum much more | 14:35 |
| mordred | right? | 14:35 |
| dtantsur | ofc | 14:35 |
| mordred | dtantsur: remind me to tell you the story of the time we crashed the HP Public Cloud | 14:35 |
| mordred | just by running nodepool against its public api | 14:35 |
| dtantsur | OH I'd LOVE to hear that | 14:35 |
| mordred | they had a hardware load balancer / api gateway in front of the api services - which would time out client connections for requests that took too long | 14:37 |
| mordred | so, on receiving a 500 from the load balancer - we'd auto retry again | 14:37 |
| mordred | problem was - the requests were taking so long because there was a missing index on a sql table, so each request was causing a long running query to get started in mysql | 14:37 |
| *** bobh has joined #openstack-sdks | 14:38 | |
| dtantsur | LOOOL | 14:39 |
| mordred | bcause it was doing a full table scan on the server table for every operation - oh, and also they hadn't been cleaning out old deleted entries from the table | 14:39 |
| dtantsur | hashtag successstory | 14:40 |
| mordred | so we'd to, while True: try: create_server ; break except: delete_server | 14:40 |
| mordred | every create would fail, at which point we'd attempt to clean up after ourselves | 14:40 |
| *** slaweq has quit IRC | 14:40 | |
| mordred | in a tight loop with no pausing | 14:40 |
| mordred | and then everything melted to the ground :) | 14:41 |
| dtantsur | well, you gave them a free DoS attack testing :D some people pay for that | 14:41 |
| mordred | RIGHT? | 14:41 |
| mordred | this is how we try to convince more people to give us resources for nodepool | 14:41 |
| mordred | "we promise we can find the errors in your cloud deployment" | 14:42 |
| dtantsur | okay, I should stop laughing so loudly, my wife will become suspicious :D | 14:43 |
| mordred | hehehe | 14:50 |
| *** ttsiouts has quit IRC | 14:50 | |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Add support for client-side rate limiting https://review.openstack.org/605043 | 14:50 |
| mordred | dtantsur: figuring out how to write unittests for this thing is going to be ... fun | 14:51 |
| kmalloc | Mock | 14:51 |
| kmalloc | Lots of mock | 14:51 |
| mordred | kmalloc: I dunno ... seems like a good risk of testing that we wrote some mocks | 14:51 |
| kmalloc | My recommendation is mock plus freezegun, check to make sure x calls were made | 14:51 |
| dtantsur | mock the heck out of it \o/ | 14:52 |
| kmalloc | With the right args | 14:52 |
| *** e0ne has quit IRC | 14:52 | |
| kmalloc | You can introspect the magicmock object and see what was called | 14:53 |
| kmalloc | The underlying request stuff is tested elsewhere. | 14:54 |
| mordred | oh - totally - definitely not worried about testing that | 14:54 |
| kmalloc | So we just want to check the ratelimiting and locking. | 14:54 |
| dtantsur | oh, how I "love" ironicclient+keystoneauth spitting "Service catalog is empty" on wrong magical combination of arguments.. | 14:55 |
| mordred | mostly just want to make sure we're hitting things like dead locks and max concurrency and stuff | 14:55 |
| kmalloc | All doable with simple wsgiref webtest app. | 14:55 |
| kmalloc | You're looking to do a simple reflector thing :) | 14:56 |
| mordred | you're a simple reflector thing | 14:56 |
| dtantsur | lol | 14:56 |
| * kmalloc borrows the zoo keys and hand a slightly damp lemur to mordred | 14:56 | |
| mordred | kmalloc: this is more moist than I prefer | 14:59 |
| kmalloc | I suggest a lemur dryer then ;) | 14:59 |
| *** ttsiouts has joined #openstack-sdks | 15:01 | |
| *** ttsiouts has quit IRC | 15:12 | |
| *** gkadam has quit IRC | 15:18 | |
| *** mriedem is now known as mriedem_afk | 15:27 | |
| *** ttsiouts has joined #openstack-sdks | 15:37 | |
| mnaser | mordred: i was just hit by this .. https://github.com/ansible/ansible/pull/42913 -- do you mind giving it another shipit if it makes sense to you? | 15:45 |
| mnaser | cc Shrews rcarrillocruz ^ | 15:45 |
| mordred | mnaser: seems reasonable - but also that kinda feels like a default behavior sdk should have on the backend | 15:55 |
| mordred | oh - wait- I misread soemthing | 15:55 |
| *** bobh has quit IRC | 16:03 | |
| mnaser | mordred: in this case a cloud with multiple users having “admin” would fail (in different domains) | 16:09 |
| mnaser | mordred: thank you! | 16:09 |
| *** openstackgerrit has quit IRC | 16:24 | |
| *** ttsiouts has quit IRC | 16:30 | |
| *** bobh has joined #openstack-sdks | 16:35 | |
| *** e0ne has joined #openstack-sdks | 16:35 | |
| *** e0ne has quit IRC | 16:37 | |
| *** dtantsur is now known as dtantsur|afk | 16:44 | |
| kmalloc | mordred: the limits code for SDK looks correct | 17:07 |
| *** tosky has quit IRC | 17:18 | |
| *** cdent has joined #openstack-sdks | 17:20 | |
| *** bobh has quit IRC | 17:34 | |
| *** e0ne has joined #openstack-sdks | 17:53 | |
| *** e0ne has quit IRC | 18:00 | |
| *** e0ne has joined #openstack-sdks | 18:08 | |
| mordred | kmalloc: yay! | 18:17 |
| *** bobh has joined #openstack-sdks | 18:26 | |
| *** mriedem_afk is now known as mriedem | 18:41 | |
| *** bobh has quit IRC | 19:18 | |
| *** bobh has joined #openstack-sdks | 19:19 | |
| *** bobh has quit IRC | 19:23 | |
| *** bobh has joined #openstack-sdks | 19:23 | |
| *** e0ne has quit IRC | 19:34 | |
| *** e0ne has joined #openstack-sdks | 19:34 | |
| *** e0ne has quit IRC | 19:36 | |
| *** cdent has quit IRC | 20:12 | |
| *** e0ne has joined #openstack-sdks | 20:28 | |
| *** e0ne has quit IRC | 20:33 | |
| *** e0ne has joined #openstack-sdks | 20:44 | |
| *** e0ne has quit IRC | 20:48 | |
| *** bobh has quit IRC | 21:01 | |
| *** bobh has joined #openstack-sdks | 21:01 | |
| *** dave-mccowan has joined #openstack-sdks | 21:05 | |
| *** bobh has quit IRC | 21:05 | |
| *** dave-mccowan has quit IRC | 21:13 | |
| *** mriedem has quit IRC | 21:40 | |
| *** bobh has joined #openstack-sdks | 23:37 | |
| *** bobh has quit IRC | 23:50 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!