| dtruong | mordred Would it be possible to cut a new openstacksdk release off master branch? That would fix the connection leak problem for Senlin. | 00:31 |
|---|---|---|
| dtruong | I also send an email to openstack-discuss with the same question: http://lists.openstack.org/pipermail/openstack-discuss/2019-March/004295.html | 00:32 |
| *** gouthamr has quit IRC | 02:10 | |
| *** gouthamr has joined #openstack-sdks | 02:12 | |
| *** whoami-rajat has joined #openstack-sdks | 02:58 | |
| *** markvoelker has joined #openstack-sdks | 05:04 | |
| *** whoami-rajat has quit IRC | 05:07 | |
| *** slaweq has quit IRC | 06:07 | |
| *** whoami-rajat has joined #openstack-sdks | 06:31 | |
| mordred | dtruong: yes, I thnk that should be no problem | 06:46 |
| mordred | dtantsur|afk: boo to that being broken. :( | 06:49 |
| mordred | dtruong: oh - I say that - doing it as a release for stein might be harder because of the various freezes. | 07:02 |
| mordred | dtruong: I'm going to ask the release team what they think | 07:06 |
| *** slaweq has joined #openstack-sdks | 07:14 | |
| *** e0ne has joined #openstack-sdks | 07:17 | |
| *** e0ne has quit IRC | 07:19 | |
| *** holser_ has joined #openstack-sdks | 07:41 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add support for generating form-post signatures https://review.openstack.org/639760 | 07:48 |
| mordred | timburke: ^^ thanks! nice catch | 07:48 |
| mordred | Shrews, dtantsur|afk: ^^ timburke found a bug in that. I fixed the bug and added unit tests to actually exercise the methods in question which would have shown how horribly broken they were | 07:49 |
| *** ttsiouts has joined #openstack-sdks | 07:50 | |
| *** tosky has joined #openstack-sdks | 08:04 | |
| *** gtema has joined #openstack-sdks | 08:15 | |
| *** ttsiouts has quit IRC | 08:26 | |
| *** ttsiouts has joined #openstack-sdks | 08:26 | |
| *** ttsiouts has quit IRC | 08:30 | |
| *** jpena|off is now known as jpena | 08:39 | |
| *** jpich has joined #openstack-sdks | 08:49 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Move set_temp_url_key logic into resource objects https://review.openstack.org/648347 | 08:59 |
| gtema | mordred, dtantsur: can you please do a next quick review on https://review.openstack.org/#/c/642218/ (split openstackcloud.py) | 09:01 |
| gtema | I only did a "rebase" | 09:01 |
| gtema | I would like to ask you to try to integrate it soon, as rebasing in it is a terrible mess with each new change | 09:01 |
| *** ttsiouts has joined #openstack-sdks | 09:01 | |
| *** ralonsoh has joined #openstack-sdks | 09:06 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove and rearrange object bonged proxy tests https://review.openstack.org/648352 | 09:16 |
| mordred | gtema: +2 from e | 09:16 |
| gtema | thks mordred | 09:16 |
| gtema | btw, I would like to modify service_descriptions.__set__ and __delete__ to be able to be able to override default descriptors (you know OTC case with the DNS implementation) | 09:18 |
| gtema | are you ok with that? | 09:18 |
| mordred | gtema: I *think* that should be ok - although my brain isn't super functional today, so I might be missing an implication :) | 09:20 |
| gtema | ok, will prepare patch. My problem is that in a particular cloud a service might differ from upstream. We currently do have possibility to add service implementation in runtime, but not to "replace" the ones delivered in SDK | 09:22 |
| mordred | yah | 09:22 |
| gtema | so for me DNS implementation should be replaced | 09:22 |
| mordred | of course, insert obligatory grumbling about clouds having incompatible services ... | 09:22 |
| gtema | yupp | 09:22 |
| gtema | thks | 09:23 |
| *** e0ne has joined #openstack-sdks | 09:47 | |
| *** dtantsur|afk is now known as dtantsur | 09:59 | |
| *** cdent has joined #openstack-sdks | 10:01 | |
| dtantsur | gtema: sure thing! btw, how did you visa application go? | 10:03 |
| dtantsur | and unrelated, but we need to fix the masakari job: http://logs.openstack.org/18/642218/9/check/openstacksdk-functional-devstack-masakari/bd6a050/job-output.txt.gz#_2019-03-26_16_03_12_675170 | 10:05 |
| *** melwitt has quit IRC | 10:26 | |
| *** e0ne has quit IRC | 10:31 | |
| *** melwitt has joined #openstack-sdks | 10:32 | |
| *** e0ne has joined #openstack-sdks | 10:36 | |
| *** ttsiouts has quit IRC | 10:57 | |
| *** ttsiouts has joined #openstack-sdks | 10:57 | |
| *** e0ne has quit IRC | 10:58 | |
| *** ttsiouts has quit IRC | 11:02 | |
| *** e0ne has joined #openstack-sdks | 11:05 | |
| *** cdent has quit IRC | 11:21 | |
| *** cdent has joined #openstack-sdks | 11:27 | |
| openstackgerrit | Merged openstack/openstacksdk master: Split OpenStackCloud into reasonable pieces https://review.openstack.org/642218 | 11:49 |
| openstackgerrit | Merged openstack/openstacksdk master: Do not disregard tags when updating stacks https://review.openstack.org/643195 | 11:49 |
| *** jpena is now known as jpena|lunch | 11:56 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Make PATCH a first class operation and support it for baremetal https://review.openstack.org/647730 | 11:57 |
| gtema | dtantsur: thanks. Visa is there. And I was really surprised to get it on 3 days after interview | 11:59 |
| gtema | s/on/in/ | 12:00 |
| *** holser_ is now known as holser|lunch | 12:01 | |
| dtantsur | yeah, it's nice :) | 12:06 |
| *** ttsiouts has joined #openstack-sdks | 12:08 | |
| *** whoami-rajat has quit IRC | 12:10 | |
| *** markvoelker has quit IRC | 12:20 | |
| *** whoami-rajat has joined #openstack-sdks | 12:21 | |
| *** e0ne has quit IRC | 12:41 | |
| *** e0ne has joined #openstack-sdks | 12:43 | |
| *** Luzi has joined #openstack-sdks | 13:03 | |
| *** ttsiouts has quit IRC | 13:13 | |
| *** ttsiouts has joined #openstack-sdks | 13:13 | |
| *** jpena|lunch is now known as jpena | 13:16 | |
| *** ttsiouts has quit IRC | 13:18 | |
| *** e0ne has quit IRC | 13:20 | |
| ITD27M01 | mordred: My name is Igor, can you please do a review on https://review.openstack.org/#/c/648117/ (missing "params" for mistral workflow execution) we are developing some utilities on-site for mistral and blocked on this change. Thank you! | 13:26 |
| *** ttsiouts has joined #openstack-sdks | 13:40 | |
| *** holser|lunch is now known as holser_ | 13:45 | |
| dtantsur | mordred, gtema, when you have a second, I had to rebase: https://review.openstack.org/#/c/647730/ | 13:47 |
| *** ttsiouts has quit IRC | 13:50 | |
| *** ttsiouts has joined #openstack-sdks | 13:51 | |
| gtema | yupp - done | 13:54 |
| *** ttsiouts has quit IRC | 13:55 | |
| *** ttsiouts has joined #openstack-sdks | 14:01 | |
| dtantsur | thx | 14:02 |
| *** ttsiouts has quit IRC | 14:17 | |
| *** ttsiouts has joined #openstack-sdks | 14:18 | |
| *** ttsiouts has quit IRC | 14:22 | |
| *** ttsiouts has joined #openstack-sdks | 14:29 | |
| *** whoami-rajat has quit IRC | 14:30 | |
| *** e0ne has joined #openstack-sdks | 14:38 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/openstacksdk master: Add "name" filter in "list" call when retrieving a single register https://review.openstack.org/637238 | 14:39 |
| *** edleafe_ has joined #openstack-sdks | 14:59 | |
| *** e0ne has quit IRC | 15:14 | |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Cleanup split of openstackcloud https://review.openstack.org/648435 | 15:16 |
| *** ricolin has joined #openstack-sdks | 15:16 | |
| *** edleafe_ has quit IRC | 15:17 | |
| *** e0ne has joined #openstack-sdks | 15:20 | |
| ricolin | cdent, edleafe elmiko Hi any chance we can get your help on http://lists.openstack.org/pipermail/openstack-discuss/2019-March/004246.html ?:) | 15:21 |
| cdent | ricolin: I'll punt to edleafe and elmiko on that. I'm not as involved in the api-sig as I used to be | 15:22 |
| edleafe | ricolin: I was going to bring that up at the office hour that starts in about 40 minutes | 15:22 |
| ricolin | cdent, thanks for the help:) | 15:22 |
| ricolin | edleafe, nice! where will the office hour hold, here? | 15:23 |
| elmiko | ricolin: taking a look, but i agree with edleafe | 15:23 |
| edleafe | ricolin: yup | 15:23 |
| cdent | dr, I concur | 15:23 |
| ricolin | will try to join you guys if I can:) | 15:23 |
| elmiko | ah yes, i remember this email. i was kinda curious about our response | 15:23 |
| *** Luzi has quit IRC | 15:25 | |
| *** e0ne has quit IRC | 15:40 | |
| mnaser | mordred: how do we go about updating patches to Ansible modules for code that recently landed in openstacksdk ? | 15:49 |
| mnaser | i.e. brtknr has landed https://github.com/ansible/ansible/pull/53757 but it depends on a patch in openstacksdk | 15:49 |
| mnaser | given we haven't released one (yet) afaik that includes it, do we hold off, do we push anyways and release openstacksdk when people yell? I'm a bit stuck on that | 15:49 |
| mordred | mnaser: well, we've also got a request from dtruong for an sdk release containing the taskmanager patch - so I think in this case the next step is "cut an sdk release" - at which point the ansible features needing that release can check for the version and whatnot | 15:56 |
| mordred | mnaser: in general we're generally pretty responsive to just cutting new sdk releases when needed - we happen to be in the middle of release freeze this week so it's slightly more complicated | 15:57 |
| mordred | mnaser: I mean - I have no problem landing the ansible patch before we release sdk as long as it's protected by an "if version" - so we might want to ask brtknr to add in a check for sdk version and only add tags to the kwargs there if sdk isn't going to vomit - and maybe throw a warning if sdk is too old and tag is in params | 15:59 |
| edleafe | The API-SIG Office Hour is now underway! Have your tickets ready! | 16:00 |
| elmiko | \o/ | 16:00 |
| * ricolin is holding his wonderland ticket | 16:00 | |
| edleafe | dtantsur: around? | 16:01 |
| edleafe | Well, let's get started | 16:02 |
| edleafe | ricolin: has brought up the email sent to the WGs/SIGs | 16:02 |
| edleafe | #link http://lists.openstack.org/pipermail/openstack-discuss/2019-March/004246.html | 16:02 |
| edleafe | I would be happy to respond to point #1 with the requested info | 16:03 |
| elmiko | i think #1 is the most important for us | 16:03 |
| elmiko | we have been pretty stable for awhile and i don't think there is a ton of "we need help on this!" type work out there | 16:04 |
| edleafe | As for #2 (the "Help Most Needed"), do we need to add anything to that? | 16:04 |
| edleafe | jinx-ish | 16:04 |
| elmiko | hehe =) | 16:04 |
| elmiko | maybe we could re-state our position about guidelines growing out of needs in the community where gaps are found? | 16:04 |
| elmiko | a call to action for anyone who might have a need | 16:04 |
| ricolin | edleafe, #2 it's still something we encourage people to put in since that doc itself just recently created | 16:04 |
| edleafe | ricolin: as elmiko mentioned, we don't have a lot of activity that we undertake | 16:05 |
| edleafe | We are here these days mostly for clarification of existing guidelines, filling in missing things, and adjudicating API disputes | 16:06 |
| edleafe | We've tried to act as a guiding force for SDKs, but none have really stepped up to work with us | 16:06 |
| ricolin | The help most needed also can point to some features/help that you think it's really really important but just can't get projects to join | 16:07 |
| elmiko | imo, the help most needed might just be a call for more folks to consider what the sig has done and reach out to us if questions arise | 16:07 |
| edleafe | ricolin: sure, but as elmiko said, we are more of a responsive group to the community | 16:07 |
| elmiko | i'm fine with pushing more a message as the "what do we need help with" as opposed to asking for direct help on something that doesn't quite exist | 16:08 |
| edleafe | If the community isn't clamoring for API guidance, well, we aren't going to just do things to keep busy | 16:08 |
| elmiko | ++ | 16:08 |
| edleafe | elmiko: sounds like you're volunteering to add something for #2 | 16:08 |
| elmiko | i'll give it my best =) | 16:09 |
| elmiko | assuming ricolin is ok with the approach i am talking about | 16:09 |
| *** holser_ has quit IRC | 16:09 | |
| edleafe | As far as #3 is concerned, I don't really see our work as being suitable for a community goal. Thoughts? | 16:09 |
| ricolin | edleafe, I don't think to list out needed most means you have to put yourself in that action. It might be some statement/goal for other teams to know that the community should reach | 16:10 |
| elmiko | community goal is definitely for folks to know about the guidelines, and how to reach out for help when needed | 16:10 |
| elmiko | so, i could see 2 and 3 intermingling a little | 16:11 |
| ricolin | elmiko, yes, I'm totally okay:) this should be whatever SIG itself needs or a suggestion goal from SIG to community | 16:11 |
| elmiko | ok, cool | 16:11 |
| edleafe | I see community goals as something that the TC is leading because OpenStack needs to do it. Moving to Python3 is a great example. But we've clearly stated that we do not expect teams to change their existing APIs to match the guidelines; in fact, we would consider that a very bad thing | 16:11 |
| elmiko | ++, awareness and spreading knowledge have always been our pillars, we don't advocate for action in the project teams | 16:12 |
| elmiko | (unless asked) | 16:12 |
| elmiko | well, i guess, edleafe should you and i take some actions to get these filled out by next week? | 16:14 |
| mordred | edleafe, elmiko: with the exception of when there is something _Additional_ we'd like for everyone to add to their api that can be done in a backwards compatible manner | 16:14 |
| elmiko | that's a good call out mordred | 16:14 |
| mordred | (that being a time when a community goal *could* emmanate from api-sig work - but I generally agree, it's not the primary or normal output | 16:15 |
| edleafe | preach, brother mordred! | 16:15 |
| * mordred just wants everyone to have sane version discovery documents come hell or high water | 16:15 | |
| gtema | ++ | 16:15 |
| elmiko | hahaha | 16:16 |
| elmiko | ricolin: looking at https://etherpad.openstack.org/p/community-goals i am really not feeling that our group's activity merit an entry there | 16:24 |
| openstackgerrit | Merged openstack/openstacksdk master: Add image.service_info resources https://review.openstack.org/638227 | 16:24 |
| *** ttsiouts has quit IRC | 16:24 | |
| elmiko | i feel like our community goal is "make sure everyone knows where the api guidelines are at and how to get help" does not seem to fit the same level of completion that the others have | 16:25 |
| ricolin | elmiko, That's fine if we don't think any of API SIG goal match community goal (request #3) | 16:25 |
| elmiko | ricolin: i will read through the "help most needed" list to see if we have an addition to propose | 16:26 |
| elmiko | edleafe: you are going to reply with the info from item 1 ? | 16:27 |
| *** e0ne has joined #openstack-sdks | 16:27 | |
| edleafe | elmiko: typing it up as we speak | 16:28 |
| elmiko | edleafe++ | 16:28 |
| edleafe | Sent! | 16:30 |
| edleafe | ...and we're only halfway through the office hour! :) | 16:31 |
| elmiko | so productive! | 16:31 |
| ricolin | edleafe, that's quick:) | 16:31 |
| cdent | api-sig, can you guys help me automate translating the placement api to graphql or grpc? this http rest-like stuff is too old | 16:32 |
| edleafe | Hey, we don't mess around!! | 16:32 |
| cdent | or soap | 16:32 |
| *** whoami-rajat has joined #openstack-sdks | 16:32 | |
| elmiko | whoo-boy, that's a big ask cdent | 16:32 |
| mordred | cdent: grpc ftw | 16:33 |
| elmiko | might i propose a binary socket with completely custom message types? have you considered that approach? | 16:33 |
| cdent | I only want it if I can automate | 16:33 |
| dustinc | so I have been working on moving Nova-Ironic interaction from using the ironicclient to using the SDK and have found a lot of funkiness in field mapping between client/SDK/API | 16:33 |
| edleafe | cdent: first print it out onto punched cards... | 16:33 |
| mordred | dustinc: you can blame me for a lot of that | 16:33 |
| dustinc | good to know, but not here to lay blame :) | 16:34 |
| mordred | dustinc: :) | 16:34 |
| elmiko | cdent: i do have a project for arbritrary code generation from openapi specs | 16:34 |
| dustinc | just hoping to get some insight on how best to solve this | 16:34 |
| dustinc | http://paste.openstack.org/show/bKnExS60mZXtsBAFgSgJ/ | 16:34 |
| dustinc | those are my notes | 16:34 |
| elmiko | what are the issues you are having trouble with? | 16:35 |
| dustinc | my main concern is that currently we pass kwargs off to the client with any keys we didn't pick up, which means that somewhere there may be existing code using the key names in client that would cause issues if we dropped in SDK without some sort of wrapper or something to fix the key names | 16:35 |
| mordred | dustinc: for things where the sdk is missing something, it's easy - we should add the things that are missing | 16:36 |
| dustinc | there are basically 2 or 3 things missing from SDK, but the issue I am seeing is the mismatched key names | 16:37 |
| dustinc | *biggest | 16:37 |
| mordred | for things where the names are different ... that's a bit trickier and we should probably think about the best way to handle it | 16:37 |
| *** dayou has quit IRC | 16:37 | |
| dtantsur | edleafe: sorry, has to run to the post office to fetch the lost delivery | 16:37 |
| dustinc | https://www.irccloud.com/pastebin/M8AuozRG/ | 16:37 |
| mordred | but basically dtantsur can solve all of the problems just by being magical | 16:37 |
| elmiko | good luck dtantsur ! | 16:37 |
| * dtantsur applies magic | 16:37 | |
| * dustinc stares in wonder | 16:37 | |
| dustinc | I *could* just put use a map to convert them, but that's obviously not ideal | 16:38 |
| dustinc | and really shouldn't make it through code review ;) | 16:38 |
| mordred | yeah - it's a thing where I'd love to be able to capture things appropriately if it's a general problem | 16:39 |
| dtantsur | Things like instance_id vs instance_uuid and maintanance vs is_maintenance are by design.. | 16:39 |
| mordred | in general, the sdk already knows how to map the server-side names of things to the sdk property name (has to be able to do a bi-directional mapping to be able to deal with the server json) | 16:39 |
| dustinc | are they? | 16:39 |
| mordred | yes | 16:39 |
| dtantsur | I mean, it sucks that ironic uses uuid where many services use id.. but it's a bit too late to change. | 16:40 |
| dtantsur | "a bit" | 16:40 |
| dtantsur | and SDK-level consistency is the very reason openstacksdk exists and we're migrating to it | 16:40 |
| dustinc | ok that is good to know...I am pretty new to stack and didn't even realize those were different | 16:40 |
| mordred | the sdk strives for consistent parameter names across the sdk vs. being consistent with the remote json names - so for instance booleans start with verbs - and then the ironic id vs. uuid thing | 16:40 |
| mordred | yeah. what dtantsur said in less words | 16:41 |
| dustinc | ok I see | 16:41 |
| edleafe | dtantsur: you could be like nova that uses both a uuid and an id :) | 16:41 |
| mordred | but - since I think the sdk already knows how to deal with remote server-side names, if you're dealing with **kwargs things we shold PROBABLY be able to figure out some way to have the sdk understand what you're wanting to do | 16:41 |
| dtantsur | edleafe: does it? O_o | 16:41 |
| mordred | edleafe: you're purposefully trying to hurt our brains :) | 16:42 |
| edleafe | Unfortunately, that got carried into placement as well. :( | 16:42 |
| dtantsur | \o/ | 16:43 |
| mordred | dustinc: we may not be helping a ton here | 16:44 |
| dtantsur | I'm not sure it really blocks the migration, but I do agree it can be confusing | 16:45 |
| *** dayou has joined #openstack-sdks | 16:54 | |
| *** holser_ has joined #openstack-sdks | 16:59 | |
| elmiko | catch ya later folks, have a good weekend =) | 17:00 |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Cleanup split of openstackcloud https://review.openstack.org/648435 | 17:03 |
| *** e0ne has quit IRC | 17:07 | |
| *** e0ne has joined #openstack-sdks | 17:08 | |
| *** e0ne has quit IRC | 17:17 | |
| *** e0ne has joined #openstack-sdks | 17:21 | |
| openstackgerrit | Ian Y. Choi proposed openstack/openstacksdk master: DNM - Start building pdfs of docs https://review.openstack.org/601659 | 17:26 |
| *** ricolin has quit IRC | 17:26 | |
| *** jpich has quit IRC | 17:30 | |
| *** ricolin has joined #openstack-sdks | 17:38 | |
| *** holser_ has quit IRC | 17:38 | |
| *** e0ne has quit IRC | 17:45 | |
| *** ricolin has quit IRC | 17:46 | |
| *** gtema has quit IRC | 17:47 | |
| openstackgerrit | Merged openstack/openstacksdk master: Make PATCH a first class operation and support it for baremetal https://review.openstack.org/647730 | 17:54 |
| *** dtantsur is now known as dtantsur|afk | 18:08 | |
| *** jpena is now known as jpena|off | 18:08 | |
| elmiko | edleafe++ i like your response to the email | 18:30 |
| edleafe | elmiko: well sure, because I spelled your nick correctly. :) | 18:30 |
| *** ralonsoh has quit IRC | 18:31 | |
| elmiko | LOL | 18:34 |
| *** jkulik has quit IRC | 18:53 | |
| *** e0ne has joined #openstack-sdks | 19:33 | |
| *** e0ne has quit IRC | 20:00 | |
| *** holser_ has joined #openstack-sdks | 20:05 | |
| *** efried has quit IRC | 20:22 | |
| dustinc | ubnt 8-port | 20:23 |
| dustinc | love browser-base clients...sorry | 20:23 |
| *** efried has joined #openstack-sdks | 20:26 | |
| *** cdent has quit IRC | 20:27 | |
| *** efried has quit IRC | 20:44 | |
| *** openstackgerrit has quit IRC | 21:07 | |
| *** holser_ has quit IRC | 22:43 | |
| *** whoami-rajat has quit IRC | 22:52 | |
| *** slaweq has quit IRC | 23:17 | |
| *** adriant has quit IRC | 23:34 | |
| *** holser_ has joined #openstack-sdks | 23:40 | |
| *** adriant has joined #openstack-sdks | 23:49 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!