*** ttsiouts has joined #openstack-sdks | 00:10 | |
*** ttsiouts has quit IRC | 00:16 | |
*** ttsiouts has joined #openstack-sdks | 00:45 | |
*** markvoelker has joined #openstack-sdks | 00:50 | |
*** slaweq has joined #openstack-sdks | 00:57 | |
*** slaweq has quit IRC | 01:01 | |
*** ttsiouts has quit IRC | 01:18 | |
*** whoami-rajat has joined #openstack-sdks | 01:31 | |
*** ricolin has joined #openstack-sdks | 01:36 | |
*** slaweq has joined #openstack-sdks | 02:11 | |
*** slaweq has quit IRC | 02:15 | |
*** edleafe has quit IRC | 02:26 | |
*** irclogbot_1 has quit IRC | 02:26 | |
*** irclogbot_0 has joined #openstack-sdks | 02:30 | |
*** ttsiouts has joined #openstack-sdks | 02:30 | |
openstackgerrit | Brin Zhang proposed openstack/python-openstackclient master: Add changes-before attribute to server list https://review.opendev.org/657373 | 02:36 |
---|---|---|
*** bobh has joined #openstack-sdks | 02:39 | |
*** ttsiouts has quit IRC | 03:04 | |
*** bobh has quit IRC | 03:12 | |
*** samueldmq has quit IRC | 03:50 | |
*** ttsiouts has joined #openstack-sdks | 04:09 | |
*** slaweq has joined #openstack-sdks | 04:11 | |
*** slaweq has quit IRC | 04:16 | |
openstackgerrit | Merged openstack/osc-lib master: Final switch to stestr https://review.opendev.org/660815 | 04:37 |
*** ttsiouts has quit IRC | 04:43 | |
*** ttsiouts has joined #openstack-sdks | 05:12 | |
*** ttsiouts has quit IRC | 05:16 | |
*** zbr has joined #openstack-sdks | 05:35 | |
*** ttsiouts has joined #openstack-sdks | 05:49 | |
*** slaweq has joined #openstack-sdks | 05:59 | |
openstackgerrit | Chinmay Naik proposed openstack/keystoneauth master: Resolves a typo in a link to use Application Credentials https://review.opendev.org/660886 | 06:00 |
*** Luzi has joined #openstack-sdks | 06:02 | |
*** slaweq has quit IRC | 06:03 | |
*** slaweq has joined #openstack-sdks | 06:11 | |
*** ttsiouts has quit IRC | 06:23 | |
openstackgerrit | zhulingjie proposed openstack/keystoneauth master: Replace git.openstack.org URLs with opendev.org URLs https://review.opendev.org/655016 | 06:38 |
*** markvoelker has quit IRC | 07:03 | |
*** markvoelker has joined #openstack-sdks | 07:03 | |
*** markvoelker has quit IRC | 07:08 | |
openstackgerrit | ZhouHeng proposed openstack/python-openstackclient master: openstack port create support --extra-dhcp-option https://review.opendev.org/657519 | 07:24 |
*** dhellmann_ has joined #openstack-sdks | 07:25 | |
*** dhellmann has quit IRC | 07:26 | |
*** dhellmann_ is now known as dhellmann | 07:29 | |
*** ttsiouts has joined #openstack-sdks | 07:29 | |
*** e0ne has joined #openstack-sdks | 07:31 | |
*** tosky has joined #openstack-sdks | 07:32 | |
openstackgerrit | ZhouHeng proposed openstack/python-openstackclient master: openstack port create support --extra-dhcp-option https://review.opendev.org/657519 | 07:43 |
*** jpena|off is now known as jpena | 07:45 | |
*** tssurya has joined #openstack-sdks | 07:46 | |
*** gtema has joined #openstack-sdks | 07:48 | |
*** holser_ has joined #openstack-sdks | 07:49 | |
*** tosky has quit IRC | 07:55 | |
*** tosky has joined #openstack-sdks | 07:55 | |
*** ralonsoh has joined #openstack-sdks | 08:04 | |
*** tssurya has quit IRC | 08:05 | |
openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Rework statistics reporting https://review.opendev.org/659841 | 08:08 |
dtantsur | mordred, gtema, 2x +2, anything blocking approval? https://review.opendev.org/#/c/660578/ | 08:17 |
gtema | :) - done | 08:18 |
dtantsur | thx! | 08:18 |
*** ttsiouts has quit IRC | 08:32 | |
openstackgerrit | Merged openstack/osc-lib master: Dropping the py35 testing https://review.opendev.org/654659 | 08:37 |
*** jangutter has joined #openstack-sdks | 08:54 | |
*** ttsiouts has joined #openstack-sdks | 09:03 | |
*** markvoelker has joined #openstack-sdks | 09:04 | |
*** gtema has quit IRC | 09:15 | |
*** ricolin has quit IRC | 09:15 | |
*** gtema has joined #openstack-sdks | 09:16 | |
*** ttsiouts has quit IRC | 09:37 | |
*** markvoelker has quit IRC | 09:38 | |
openstackgerrit | Vishakha Agarwal proposed openstack/keystoneauth master: Bump bandit version and cap sphinx https://review.opendev.org/660956 | 09:44 |
openstackgerrit | Merged openstack/openstacksdk master: baremetal: allow updating name and extra fields of an allocation https://review.opendev.org/660578 | 09:55 |
*** cdent has joined #openstack-sdks | 10:03 | |
openstackgerrit | Merged openstack/openstacksdk master: Add support for vendor hooks https://review.opendev.org/657848 | 10:11 |
openstackgerrit | Merged openstack/openstacksdk master: Add ability to provide qos_policy_id for port https://review.opendev.org/660680 | 10:21 |
*** holser_ is now known as holser|lunch | 10:33 | |
*** markvoelker has joined #openstack-sdks | 10:35 | |
*** ttsiouts has joined #openstack-sdks | 10:40 | |
*** gtema has quit IRC | 10:57 | |
*** gtema has joined #openstack-sdks | 10:58 | |
*** ttsiouts has quit IRC | 10:59 | |
*** ttsiouts has joined #openstack-sdks | 11:00 | |
*** jpena is now known as jpena|lunch | 11:01 | |
*** markvoelker has quit IRC | 11:08 | |
*** ttsiouts has quit IRC | 11:14 | |
*** dave-mccowan has joined #openstack-sdks | 11:26 | |
*** bobh has joined #openstack-sdks | 11:47 | |
openstackgerrit | Surya Seetharaman proposed openstack/python-openstackclient master: Microversion 2.73: Support adding the reason behind a server lock https://review.opendev.org/659124 | 11:58 |
*** markvoelker has joined #openstack-sdks | 11:59 | |
*** tosky has quit IRC | 12:01 | |
*** tosky has joined #openstack-sdks | 12:03 | |
*** tosky__ has joined #openstack-sdks | 12:08 | |
*** tosky has quit IRC | 12:11 | |
*** edleafe has joined #openstack-sdks | 12:16 | |
*** gtema has quit IRC | 12:17 | |
openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: Add 'openstack server resurrect' command https://review.opendev.org/643578 | 12:26 |
*** ttsiouts has joined #openstack-sdks | 12:28 | |
*** jpena|lunch is now known as jpena | 12:30 | |
*** tosky has joined #openstack-sdks | 12:33 | |
*** tosky__ has quit IRC | 12:36 | |
*** tosky__ has joined #openstack-sdks | 12:38 | |
*** tosky has quit IRC | 12:40 | |
*** tosky__ is now known as tosky | 12:40 | |
*** gtema has joined #openstack-sdks | 12:47 | |
*** bobh has quit IRC | 12:49 | |
*** Luzi has quit IRC | 12:54 | |
*** e0ne has quit IRC | 12:57 | |
*** ttsiouts has quit IRC | 12:58 | |
*** holser|lunch is now known as holser_ | 13:07 | |
*** dave-mccowan has quit IRC | 13:12 | |
*** dave-mccowan has joined #openstack-sdks | 13:13 | |
*** gtema has quit IRC | 13:27 | |
*** samueldmq has joined #openstack-sdks | 13:36 | |
*** ricolin has joined #openstack-sdks | 13:49 | |
*** yolanda__ has joined #openstack-sdks | 14:02 | |
*** ttsiouts has joined #openstack-sdks | 14:02 | |
*** yolanda__ is now known as yolanda | 14:03 | |
openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: Make 'destination' optional for live migration https://review.opendev.org/626949 | 14:16 |
openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: Add 'openstack server resurrect' command https://review.opendev.org/643578 | 14:29 |
*** gtema has joined #openstack-sdks | 14:32 | |
*** ttsiouts has quit IRC | 14:36 | |
*** dave-mccowan has quit IRC | 14:52 | |
*** dave-mccowan has joined #openstack-sdks | 14:52 | |
openstackgerrit | Matt Riedemann proposed openstack/python-openstackclient master: Compute: Add user id support for keypair https://review.opendev.org/576507 | 14:52 |
*** ttsiouts has joined #openstack-sdks | 15:43 | |
*** ttsiouts has quit IRC | 15:45 | |
*** ttsiouts has joined #openstack-sdks | 15:46 | |
openstackgerrit | Sergii Golovatiuk proposed openstack/openstacksdk master: Log OpenStackCloudResourceNotFound exceptions https://review.opendev.org/637169 | 15:46 |
*** whoami-rajat has quit IRC | 15:50 | |
edleafe | Wow! Time for another API-SIG Office Hour!! | 16:00 |
cdent | I wonder if the api-sig saw the discussion between me and cmurphy about the errors guideline? | 16:03 |
* cdent looks for link | 16:03 | |
cdent | this thread: http://lists.openstack.org/pipermail/openstack-discuss/2019-May/006377.html | 16:03 |
cdent | and colleen's comments: http://lists.openstack.org/pipermail/openstack-discuss/2019-May/006425.html | 16:04 |
elmiko | o/ | 16:05 |
edleafe | I saw it, but I wasn't around for any of the original discussions, so I can't add much | 16:05 |
edleafe | elmiko: you +W'd that change - any impressions? | 16:11 |
*** gtema has quit IRC | 16:13 | |
elmiko | i'm reading now | 16:14 |
* cdent must go vote | 16:14 | |
cdent | but if you've got stuff to say please add to the thread | 16:14 |
*** cdent has quit IRC | 16:15 | |
*** ttsiouts has quit IRC | 16:16 | |
elmiko | i'm really not sure how to respond to colleen's question | 16:17 |
elmiko | i mean, having a list of errors seemed like a good idea at the time because more than one could be returned | 16:17 |
elmiko | i think it was also inspired by prior art within the openstack community | 16:17 |
edleafe | Are you aware of any other API that does anything similar? | 16:17 |
edleafe | jinxish | 16:17 |
elmiko | i vaguely recall at the time we had examples of others doing it that way | 16:23 |
*** logan- has joined #openstack-sdks | 16:24 | |
elmiko | after looking around, maybe we just need to revisit that guideline? | 16:28 |
elmiko | i don't remember how we arrived at that, and i can't seem to find the reference materials | 16:29 |
edleafe | I don't understand the confusion surrounding this. Wouldn't a developer *want* to know about all the errors that happened? Usually the last error isn't the genesis of the problem. | 16:31 |
elmiko | right, and that goes in line with our thinking about having a possible list of errors | 16:32 |
logan- | hello! in a vendor config, is there a way to specify that a certain provider network is only available in a certain list of regions? I'm asking because https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/config/vendors/limestonenetworks.json#L22 is only available in the us-dfw-1 region. We had a user receiving errors when trying to schedule nodes in the us-slc region related to this network. | 16:38 |
logan- | the error was: http://paste.openstack.org/show/751177/, and it was worked around with a config for nodepool-launcher to exclude this network: https://github.com/ansible-network/windmill-config/pull/437/files | 16:38 |
mordred | logan-: yes - all of the settings that you can make can be tied to a region | 16:39 |
mordred | logan-: let me find you an example | 16:39 |
mordred | logan-: https://docs.openstack.org/openstacksdk/latest/user/config/configuration.html#per-region-settings | 16:41 |
mordred | logan-: the regions list can also be a list of dicts | 16:41 |
elmiko | edleafe: i need to fix an issue with my emails to the list, then i will respond to colleen | 16:41 |
logan- | thanks mordred | 16:41 |
edleafe | elmiko: thx | 16:41 |
*** zbr has quit IRC | 16:45 | |
*** ttsiouts has joined #openstack-sdks | 16:48 | |
*** whoami-rajat has joined #openstack-sdks | 16:51 | |
*** ttsiouts has quit IRC | 16:53 | |
*** dtantsur is now known as dtantsur|afk | 16:54 | |
*** ricolin has quit IRC | 16:55 | |
elmiko | take care edleafe, have a nice holiday weekend =) | 17:00 |
edleafe | I shall! You too! | 17:03 |
*** tosky has quit IRC | 17:08 | |
*** tosky has joined #openstack-sdks | 17:12 | |
*** jpena is now known as jpena|off | 17:19 | |
*** tosky has quit IRC | 17:22 | |
*** tosky__ has joined #openstack-sdks | 17:23 | |
*** ttsiouts has joined #openstack-sdks | 17:26 | |
*** e0ne has joined #openstack-sdks | 17:29 | |
openstackgerrit | Logan V proposed openstack/openstacksdk master: Update Limestone Networks vendor config https://review.opendev.org/661063 | 17:44 |
*** holser_ is now known as holser|eod | 17:44 | |
openstackgerrit | Logan V proposed openstack/openstacksdk master: Update Limestone Networks vendor config https://review.opendev.org/661063 | 17:45 |
openstackgerrit | Logan V proposed openstack/openstacksdk master: Update Limestone Networks vendor config https://review.opendev.org/661063 | 17:45 |
*** ralonsoh has quit IRC | 17:51 | |
*** ttsiouts has quit IRC | 17:59 | |
*** holser|eod has quit IRC | 18:08 | |
*** e0ne has quit IRC | 18:53 | |
*** e0ne has joined #openstack-sdks | 18:54 | |
*** ttsiouts has joined #openstack-sdks | 19:09 | |
*** e0ne has quit IRC | 19:39 | |
*** ttsiouts has quit IRC | 19:42 | |
*** tosky__ is now known as tosky | 20:18 | |
*** whoami-rajat has quit IRC | 20:31 | |
cmurphy | edleafe: elmiko cdent my issue is that if more than one error is returned, eg if nova fails because glance fails, I don't think it's the user's business to know what happened on the backend, it could even leak sensitive information, so it should just be nova's job to capture the error and reformat it as one error for the user, the operator has logs to see what really happened on the backend | 20:34 |
*** slaweq has quit IRC | 20:41 | |
mordred | cmurphy, edleafe, elmiko: it can be confusing as well - because those errors are not actionable. I know we've gotten that at times in Infra - an error booting a node because there was some issue between nova and glance that had nothing to do with our boot command or the image contents | 20:49 |
mordred | so it tells us "blah blah cna't find /dev/xx05a blah blah ceph blah" - and it's both scary and makes us try to troubleshoot why we were trying to do something with ceph - and it turns out we're not we're just trying to boot a vm | 20:49 |
edleafe | cmurphy: I don't think that you should ever return internal details in a user-facing API, whether it's a single message or multiple. Your example of glance-level errors should only be on admin APIs | 20:50 |
mordred | edleafe: should and are have so many differences | 20:50 |
mordred | edleafe: (but I agree with you) | 20:50 |
edleafe | mordred: Guidelines are for "should" | 20:50 |
edleafe | :) | 20:50 |
mordred | edleafe: life is friendly in should | 20:51 |
edleafe | cmurphy: But to get back to your point: error messages and details should be informative. Packing every known bit of data in an error messages is just as bad as not including enough | 20:52 |
*** slaweq has joined #openstack-sdks | 20:52 | |
edleafe | cmurphy: So if there are more than one relevant bits of information about the error, they should be included, not just one of them | 20:53 |
edleafe | The guideline is more about how to handle multiple bits of information. It doesn't require that you include more than one, though | 20:53 |
*** ttsiouts has joined #openstack-sdks | 20:56 | |
*** slaweq has quit IRC | 20:57 | |
*** ttsiouts has quit IRC | 21:26 | |
elmiko | cmurphy: i don't think the intent was for a single service to bubble out errors from other services. i had always thought of it as a single service emitting multiple errors to a single call. | 21:41 |
*** bobh has joined #openstack-sdks | 21:42 | |
*** ttsiouts has joined #openstack-sdks | 21:42 | |
elmiko | and i agree with edleafe re: the api not /requiring/ more than one | 21:42 |
*** bobh has quit IRC | 21:45 | |
*** tosky has quit IRC | 23:05 | |
openstackgerrit | Matt Riedemann proposed openstack/python-openstackclient master: WIP: Deprecate openstack server migrate --host option https://review.opendev.org/659382 | 23:30 |
*** ttsiouts has quit IRC | 23:42 | |
*** ttsiouts has joined #openstack-sdks | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!