*** slaweq has joined #openstack-sdks | 00:11 | |
*** slaweq has quit IRC | 00:24 | |
*** dave-mccowan has joined #openstack-sdks | 00:31 | |
*** markvoelker has quit IRC | 00:33 | |
*** dave-mccowan has quit IRC | 00:35 | |
*** efried has quit IRC | 00:37 | |
*** ricolin_ has joined #openstack-sdks | 00:44 | |
*** efried has joined #openstack-sdks | 00:45 | |
*** slaweq has joined #openstack-sdks | 01:16 | |
*** slaweq has quit IRC | 01:24 | |
*** slaweq has joined #openstack-sdks | 02:11 | |
*** slaweq has quit IRC | 02:25 | |
openstackgerrit | jacky06 proposed openstack/keystoneauth master: Replace git.openstack.org URLs with opendev.org URLs https://review.opendev.org/655016 | 02:30 |
---|---|---|
*** markvoelker has joined #openstack-sdks | 02:34 | |
*** markvoelker has quit IRC | 03:08 | |
*** slaweq has joined #openstack-sdks | 03:11 | |
*** slaweq has quit IRC | 03:25 | |
*** altlogbot_0 has quit IRC | 03:44 | |
*** altlogbot_3 has joined #openstack-sdks | 03:46 | |
*** markvoelker has joined #openstack-sdks | 04:05 | |
*** slaweq has joined #openstack-sdks | 04:16 | |
*** slaweq has quit IRC | 04:24 | |
*** whoami-rajat has joined #openstack-sdks | 04:31 | |
*** markvoelker has quit IRC | 04:37 | |
*** altlogbot_3 has quit IRC | 04:38 | |
*** altlogbot_0 has joined #openstack-sdks | 04:42 | |
*** slaweq has joined #openstack-sdks | 05:11 | |
*** slaweq has quit IRC | 05:18 | |
*** markvoelker has joined #openstack-sdks | 05:34 | |
*** gtema has joined #openstack-sdks | 05:55 | |
*** dtantsur|afk is now known as dtantsur | 06:00 | |
*** markvoelker has quit IRC | 06:08 | |
*** slaweq has joined #openstack-sdks | 06:12 | |
*** holser_ has joined #openstack-sdks | 06:52 | |
*** markvoelker has joined #openstack-sdks | 07:05 | |
*** tosky has joined #openstack-sdks | 07:11 | |
*** ralonsoh has joined #openstack-sdks | 07:21 | |
*** markvoelker has quit IRC | 07:37 | |
*** tosky has quit IRC | 07:40 | |
*** tosky has joined #openstack-sdks | 07:42 | |
*** jpena|off is now known as jpena | 07:58 | |
*** e0ne has joined #openstack-sdks | 07:59 | |
*** ricolin_ has quit IRC | 08:07 | |
*** ricolin has joined #openstack-sdks | 08:07 | |
*** markvoelker has joined #openstack-sdks | 08:34 | |
openstackgerrit | Andreas Jaeger proposed openstack/openstackclient master: Remove pbrx https://review.opendev.org/661914 | 08:39 |
*** cdent has joined #openstack-sdks | 09:05 | |
*** markvoelker has quit IRC | 09:08 | |
*** markvoelker has joined #openstack-sdks | 10:05 | |
*** slaweq has quit IRC | 10:30 | |
*** dave-mccowan has joined #openstack-sdks | 10:31 | |
*** dave-mccowan has quit IRC | 10:37 | |
*** markvoelker has quit IRC | 10:37 | |
*** dtantsur is now known as dtantsur|lunch | 10:43 | |
*** gtema has quit IRC | 10:48 | |
*** slaweq has joined #openstack-sdks | 10:54 | |
*** jpena is now known as jpena|lunch | 11:30 | |
*** jangutter_ has joined #openstack-sdks | 11:32 | |
*** markvoelker has joined #openstack-sdks | 11:34 | |
*** jangutter has quit IRC | 11:36 | |
*** redrobot has quit IRC | 11:39 | |
*** markvoelker has quit IRC | 11:54 | |
*** markvoelker has joined #openstack-sdks | 11:54 | |
openstackgerrit | Akihiro Motoki proposed openstack/openstackclient master: Update sphinx dependency for python 2.7 https://review.opendev.org/661947 | 11:55 |
*** e0ne has quit IRC | 12:16 | |
*** redrobot has joined #openstack-sdks | 12:23 | |
*** jpena|lunch is now known as jpena | 12:34 | |
*** mtreinish has quit IRC | 12:36 | |
*** mtreinish has joined #openstack-sdks | 12:36 | |
*** AJaeger has joined #openstack-sdks | 12:40 | |
AJaeger | mordred: for fixing openstackclient, you need to fix sphinx first - see https://review.opendev.org/#/c/661947/ and then the py27 bug in there ;( | 12:40 |
*** whoami-rajat has quit IRC | 12:51 | |
*** jangutter has joined #openstack-sdks | 12:51 | |
*** gmann has quit IRC | 12:53 | |
*** jangutter_ has quit IRC | 12:54 | |
AJaeger | amotoki, mordred, I pushed a change on top of 661947. Interesting, you do not publish docs - is that intentional? | 12:56 |
* AJaeger pushes an update to publish as well... | 12:57 | |
openstackgerrit | Andreas Jaeger proposed openstack/openstackclient master: Update sphinx dependency for python 2.7 https://review.opendev.org/661947 | 13:02 |
openstackgerrit | Andreas Jaeger proposed openstack/openstackclient master: Switch to openstackdocstheme https://review.opendev.org/661974 | 13:02 |
AJaeger | amotoki: updated your change | 13:03 |
elmiko | cmurphy: in answer to your last question, when i went to look back through the comments on the initial guideline proposal, it /looked/ lke someone had posted an example of returning multiple errors to a single call. outside of that though, i don't have an example at the ready. | 13:08 |
openstackgerrit | Andreas Jaeger proposed openstack/openstackclient master: Update sphinx dependency for python 2.7 https://review.opendev.org/661947 | 13:23 |
openstackgerrit | Andreas Jaeger proposed openstack/openstackclient master: Switch to openstackdocstheme https://review.opendev.org/661974 | 13:23 |
*** e0ne has joined #openstack-sdks | 13:24 | |
*** dmellado has quit IRC | 13:25 | |
*** dmellado has joined #openstack-sdks | 13:25 | |
*** dtantsur|lunch is now known as dtantsur | 13:35 | |
AJaeger | mordred, dtroyer, so https://review.opendev.org/661947 fixes all the failures that openstackclient currently has and is the next change you need to merge... | 13:57 |
amotoki | AJaeger: thanks for the update. As you pointed, we need to check the necessity of doc dependency and I will check it, but it looks good to merge 661947 first as it affects various changes. | 13:59 |
AJaeger | amotoki: yes, we can discuss 661974 separately. Please discuss whether you want to publish docs, only build them - or just take the change without jobs to install less packages ;) | 14:00 |
*** whoami-rajat has joined #openstack-sdks | 14:03 | |
*** gmann has joined #openstack-sdks | 14:10 | |
*** ricolin has quit IRC | 14:20 | |
*** ricolin has joined #openstack-sdks | 14:26 | |
cmurphy | elmiko: what i still find strange is that this would all be stuffed into the body of a single response, while the actual http response would only have one error code | 14:50 |
cmurphy | it looks like rfc 7230 says that multiple responses could be returned for a single request but that's not how i read the guideline | 14:51 |
elmiko | cmurphy: i think you are right that it does seem odd for the http request to return a single error, but the body could express multiple internal errors | 15:23 |
elmiko | and i would imagine in most cases the error in the body would reflect a single error about the return code | 15:23 |
elmiko | if memory serves me correctly, and it might not, i think the idea was that a 500 error could expose more internal detail through this mechanism | 15:24 |
elmiko | obviously for something like 404 it doesn't make much sense | 15:24 |
elmiko | and yeah, i think the intent in 7230 is different than what we are describing in the guideline | 15:25 |
*** altlogbot_0 has quit IRC | 15:34 | |
*** altlogbot_3 has joined #openstack-sdks | 15:36 | |
*** irclogbot_0 has quit IRC | 15:36 | |
*** irclogbot_3 has joined #openstack-sdks | 15:38 | |
*** irclogbot_0 has joined #openstack-sdks | 15:38 | |
*** dtantsur is now known as dtantsur|afk | 15:51 | |
cdent | cmurphy, elmiko: the goal, as I remember, is to encapsulate the fact that there could be a suite of several system errors that led up to a particular http error, and knowing both is desirable, thus the sepraration between and status and code | 16:01 |
cdent | and yeah 7230 is something else | 16:01 |
cdent | not that I'm trying to defend the guideline. I've always thought it a bit weird, just trying to dredge up the reasons | 16:01 |
openstackgerrit | Clark Boylan proposed openstack/python-openstackclient master: Replace pkg_resources with importlib-metadata https://review.opendev.org/661856 | 16:02 |
cmurphy | as i said in the thread i don't mind patching keystoneauth to conform to the guideline, i just think the guideline is weird | 16:09 |
elmiko | cmurphy cdent, for clarity sake, i'm not trying to defend the guideline either, and it may in fact be weird. | 16:18 |
elmiko | this does provide an excellent opportunity to reflect on how we might change things when turn out to not make sense | 16:18 |
elmiko | i'm curious if we need to re-open that guideline and discuss it again if it turns out that a majority think it's weird and will probably never implement it | 16:19 |
cdent | i suspect, unfortunately, that now that implementations of multiple styles are lose in the wild, we need to support them both forever | 16:20 |
cdent | because though we've been willing to say that message in errors are okay to change whenever, changing their structure probably less so | 16:20 |
*** cdent has quit IRC | 16:22 | |
*** ricolin has quit IRC | 16:42 | |
*** holser_ is now known as holser|eod | 16:47 | |
*** kmalloc_away is now known as kmalloc | 16:55 | |
*** e0ne has quit IRC | 16:58 | |
openstackgerrit | Merged openstack/keystoneauth master: Resolves a typo in a link to use Application Credentials https://review.opendev.org/660886 | 16:59 |
*** holser|eod has quit IRC | 17:06 | |
*** jpena is now known as jpena|off | 17:15 | |
*** tosky__ has joined #openstack-sdks | 17:59 | |
*** tosky has quit IRC | 18:00 | |
*** tosky__ is now known as tosky | 18:00 | |
*** ralonsoh has quit IRC | 18:35 | |
openstackgerrit | Merged openstack/keystoneauth master: Replace git.openstack.org URLs with opendev.org URLs https://review.opendev.org/655016 | 18:45 |
mordred | if cdent was here, I'd say "of course, there are multiple forms of error payloads, so some things, like openstacksdk for instance, just do a shotgun approach and try their best to find some structure that might have error information in it" | 18:50 |
*** slaweq has quit IRC | 21:03 | |
*** slaweq has joined #openstack-sdks | 21:11 | |
*** whoami-rajat has quit IRC | 21:13 | |
*** slaweq has quit IRC | 21:16 | |
*** efried has quit IRC | 21:49 | |
*** tosky has quit IRC | 21:49 | |
*** efried has joined #openstack-sdks | 21:51 | |
*** slaweq has joined #openstack-sdks | 22:11 | |
*** slaweq has quit IRC | 22:16 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!