openstackgerrit | Merged openstack/python-openstackclient master: Update the constraints url https://review.opendev.org/668366 | 00:09 |
---|---|---|
*** slaweq has joined #openstack-sdks | 00:16 | |
*** slaweq has quit IRC | 00:21 | |
*** ricolin_ has joined #openstack-sdks | 00:51 | |
*** ricolin_ is now known as ricolin | 00:52 | |
*** bobh has joined #openstack-sdks | 01:53 | |
*** dasp has quit IRC | 02:46 | |
*** bobh has quit IRC | 02:47 | |
*** dasp has joined #openstack-sdks | 03:03 | |
*** ricolin_ has joined #openstack-sdks | 03:54 | |
*** ricolin has quit IRC | 03:57 | |
openstackgerrit | Merged openstack/python-openstackclient master: Add Python 3 Train unit tests https://review.opendev.org/668364 | 04:03 |
*** toabctl has quit IRC | 04:31 | |
*** whoami-rajat has joined #openstack-sdks | 04:34 | |
*** e0ne has joined #openstack-sdks | 05:20 | |
*** ricolin_ is now known as ricolin | 05:37 | |
*** Luzi has joined #openstack-sdks | 05:54 | |
*** e0ne has quit IRC | 06:12 | |
*** slaweq has joined #openstack-sdks | 06:45 | |
openstackgerrit | zhufl proposed openstack/openstacksdk master: Fix invalid assert state https://review.opendev.org/668794 | 06:50 |
*** ricolin_ has joined #openstack-sdks | 06:51 | |
*** ricolin has quit IRC | 06:53 | |
*** ttsiouts has joined #openstack-sdks | 06:58 | |
*** cdent has joined #openstack-sdks | 07:04 | |
*** gtema has joined #openstack-sdks | 07:14 | |
*** tosky has joined #openstack-sdks | 07:20 | |
*** ttsiouts has quit IRC | 07:26 | |
*** ttsiouts has joined #openstack-sdks | 07:27 | |
*** toabctl has joined #openstack-sdks | 07:30 | |
*** ttsiouts has quit IRC | 07:31 | |
*** ttsiouts has joined #openstack-sdks | 07:51 | |
*** jpich has joined #openstack-sdks | 07:53 | |
*** ralonsoh has joined #openstack-sdks | 07:59 | |
*** ricolin__ has joined #openstack-sdks | 08:44 | |
*** ricolin_ has quit IRC | 08:47 | |
*** ricolin__ is now known as ricolin | 08:55 | |
*** vishakha has joined #openstack-sdks | 09:01 | |
*** e0ne has joined #openstack-sdks | 09:37 | |
*** tosky has quit IRC | 09:39 | |
*** tosky has joined #openstack-sdks | 09:40 | |
*** gtema_ has joined #openstack-sdks | 09:51 | |
*** gtema has quit IRC | 09:53 | |
*** ttsiouts has quit IRC | 10:16 | |
*** ttsiouts has joined #openstack-sdks | 10:16 | |
*** ttsiouts has quit IRC | 10:21 | |
*** gtema_ has quit IRC | 10:47 | |
*** gtema has joined #openstack-sdks | 10:47 | |
*** cdent has quit IRC | 10:58 | |
*** ttsiouts has joined #openstack-sdks | 11:01 | |
*** cdent has joined #openstack-sdks | 11:28 | |
*** gtema has quit IRC | 11:35 | |
*** gtema has joined #openstack-sdks | 11:35 | |
*** cdent has quit IRC | 12:08 | |
*** priteau has joined #openstack-sdks | 12:20 | |
brtknr | priteau: mordred gtema mnaser | 12:21 |
priteau | Hi folks. I submitted a patch to Ansible about a month ago to fix an error when no volume service is available. Would anyone be able to review it? https://github.com/ansible/ansible/pull/57364 | 12:22 |
*** cdent has joined #openstack-sdks | 12:29 | |
mordred | priteau: lgtm | 12:46 |
priteau | Thanks mordred | 12:50 |
*** vishakha has quit IRC | 13:10 | |
*** priteau has quit IRC | 13:15 | |
*** ttsiouts has quit IRC | 13:27 | |
cdent | dtroyer: if you have a moment to gaze on an osc-placement naming discussion, that would be helpful: https://review.opendev.org/666542 | 13:31 |
cdent | also: hi | 13:31 |
dtroyer | cdent: oh that looks like a fun one, thanks ;) | 13:41 |
cdent | dtroyer: I'm all about fun for you | 13:42 |
cdent | I suspect placement's nature as "mostly admin" gives it a bit off leeway | 13:42 |
dtroyer | (just thinking out loud here) I am not much of a fan of complex queries build from CLI options, if you need a complex query, build a DSL for that? | 13:43 |
dtroyer | in OSC so far we have mostly gotten away with that | 13:43 |
*** ttsiouts has joined #openstack-sdks | 13:44 | |
dtroyer | using the options to detect/attempt specific API microversions in itself is fine with me, sometimes it can be obvious, but that in: magic doesn't sit well with me. I don't like options with values that contain keywords but that turned out to be unavoidable in some places, so there is a bit of precedent for how those should look | 13:46 |
dtroyer | so if I read that right the review is basically a straight port of the REST API semantics to the cli options? | 13:49 |
*** mriedem has joined #openstack-sdks | 13:59 | |
mordred | CLI arguments like "--member-of in:<uuid1>:<uuid>" give me hives | 14:13 |
mordred | passing complex need-to-be-parsed data structures is hard to deal with on the CLI (although makes sense in the REST API itself) - and invariably gets really brittle (see anything related to block_device_mapping) | 14:14 |
mordred | (which I think is me saying I agree with dtroyer :) ) | 14:15 |
*** ricolin has quit IRC | 14:16 | |
mordred | I'd rather see multiple options - like --member-of <uuid1> --member-of <uuid2> to make the && case like mentioned, but then maybe like --member-in <uuid> --member-in <uuid2> to construct member_of="in:uuid1:uuid2" ... but that's just off the top of my head, and I'm not sure how weird that woudl be to actually use | 14:17 |
mordred | or, heck - a --member-in <uuid1>,<uuid2> would bother me less than the in: prefix | 14:17 |
mordred | maybe I should say some of that in the review ... | 14:18 |
cdent | dtroyer: sorry, stepped away. the suggestion from gibi is to do a straight port of the new microversin | 14:19 |
cdent | and for the most part that's what's been doing in several places, but...not always | 14:19 |
cdent | thus leading to the current confusion | 14:19 |
*** gtema has quit IRC | 14:28 | |
*** gtema has joined #openstack-sdks | 14:29 | |
dtroyer | cdent: in meeting now, part way writing a reply in the review. In short, the implicit AND/OR operators are confusing and I don't think OSC has a clear precedent there. Multiple —property options are effectively an AND in create/set commands for example… | 14:31 |
cdent | yes, that confusion is why I think explicitly copying the query structure (which is at least somewhat documented and familiar to people who will even care to use that specific microversion) | 14:32 |
cdent | I suspect we are overthinking this because we are trying to incrementally support microversions, rather than simply support use cases | 14:33 |
cdent | we can already filter resource providers by aggregate membership | 14:33 |
cdent | and the need to do complex booleans, I would think, is rather rare | 14:33 |
cdent | so I'd almost be inclined to say "we don't do what 1.24 supports" | 14:33 |
*** gtema has quit IRC | 14:34 | |
*** gtema has joined #openstack-sdks | 14:34 | |
cdent | dtroyer: this keeps happening with osc-placement but I'm hard pressed to believe that it is actually necessary | 14:34 |
cdent | people who want advanced filtering functionality should perhaps be able to pass a raw filter query, exactly as it would be formed in the URL | 14:35 |
cdent | and there should also be simple things (as there already are) | 14:35 |
dtroyer | cdent: we outlined a basic method for passing in structured data for doing things like bulk create operations at PTG, using that (once it is written) for queries seems logical… | 14:45 |
*** factor has quit IRC | 14:51 | |
*** factor has joined #openstack-sdks | 14:52 | |
*** jpich has quit IRC | 14:54 | |
*** jpich has joined #openstack-sdks | 14:54 | |
*** Luzi has quit IRC | 14:58 | |
*** icarusfactor has joined #openstack-sdks | 15:00 | |
*** factor has quit IRC | 15:00 | |
*** bobh has joined #openstack-sdks | 15:05 | |
*** cdent has quit IRC | 15:11 | |
*** ttsiouts has quit IRC | 15:30 | |
*** ttsiouts has joined #openstack-sdks | 15:31 | |
*** icarusfactor has quit IRC | 15:34 | |
*** factor__ has joined #openstack-sdks | 15:34 | |
*** ttsiouts has quit IRC | 15:36 | |
*** factor has joined #openstack-sdks | 15:38 | |
*** factor__ has quit IRC | 15:39 | |
*** jangutter has quit IRC | 15:42 | |
*** jpich has quit IRC | 15:48 | |
*** jpich has joined #openstack-sdks | 15:48 | |
*** gtema has quit IRC | 15:53 | |
*** bobh has quit IRC | 15:58 | |
openstackgerrit | Sergey Vilgelm proposed openstack/keystoneauth master: OIDC supports public clients https://review.opendev.org/668951 | 16:03 |
*** gtema has joined #openstack-sdks | 16:05 | |
*** gtema has quit IRC | 16:07 | |
*** jpich has quit IRC | 16:32 | |
*** bobh has joined #openstack-sdks | 16:33 | |
*** bobh has quit IRC | 16:38 | |
*** e0ne has quit IRC | 16:39 | |
*** factor has quit IRC | 17:03 | |
*** openstackgerrit has quit IRC | 17:04 | |
*** e0ne has joined #openstack-sdks | 17:44 | |
*** openstackgerrit has joined #openstack-sdks | 17:47 | |
openstackgerrit | Merged openstack/os-service-types master: Sync Sphinx requirement https://review.opendev.org/666384 | 17:47 |
*** e0ne has quit IRC | 18:06 | |
*** e0ne has joined #openstack-sdks | 18:09 | |
*** gtema has joined #openstack-sdks | 18:11 | |
*** gtema has quit IRC | 18:15 | |
*** gtema has joined #openstack-sdks | 18:17 | |
*** e0ne has quit IRC | 18:22 | |
*** ralonsoh has quit IRC | 18:35 | |
*** whoami-rajat has quit IRC | 19:12 | |
*** whoami-rajat has joined #openstack-sdks | 19:29 | |
*** gtema has quit IRC | 19:36 | |
*** gtema has joined #openstack-sdks | 19:36 | |
*** e0ne has joined #openstack-sdks | 19:39 | |
*** e0ne has quit IRC | 19:55 | |
*** e0ne has joined #openstack-sdks | 20:20 | |
*** goldyfruit has quit IRC | 20:24 | |
*** goldyfruit has joined #openstack-sdks | 20:24 | |
*** goldyfruit has quit IRC | 20:47 | |
*** goldyfruit has joined #openstack-sdks | 21:02 | |
*** slaweq has quit IRC | 21:11 | |
*** slaweq has joined #openstack-sdks | 21:27 | |
*** e0ne has quit IRC | 21:28 | |
*** e0ne has joined #openstack-sdks | 21:29 | |
*** slaweq has quit IRC | 21:32 | |
*** slaweq has joined #openstack-sdks | 21:38 | |
*** slaweq has quit IRC | 21:43 | |
*** e0ne has quit IRC | 21:46 | |
*** slaweq has joined #openstack-sdks | 21:59 | |
*** slaweq has quit IRC | 22:04 | |
*** bobh has joined #openstack-sdks | 22:31 | |
*** tosky has quit IRC | 22:38 | |
*** whoami-rajat has quit IRC | 22:42 | |
*** efried is now known as efried_pto | 22:45 | |
*** slaweq has joined #openstack-sdks | 23:14 | |
*** slaweq has quit IRC | 23:19 | |
*** bobh has quit IRC | 23:32 | |
*** bobh has joined #openstack-sdks | 23:33 | |
*** bobh has quit IRC | 23:37 | |
*** bobh has joined #openstack-sdks | 23:48 | |
*** bobh has quit IRC | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!