*** ricolin has joined #openstack-sdks | 02:48 | |
*** black_ant has quit IRC | 03:50 | |
*** gtema has joined #openstack-sdks | 04:40 | |
*** Luzi has joined #openstack-sdks | 05:13 | |
*** slaweq has joined #openstack-sdks | 06:08 | |
*** yolanda has quit IRC | 06:34 | |
*** e0ne has joined #openstack-sdks | 07:04 | |
*** gtema has quit IRC | 07:04 | |
*** e0ne has quit IRC | 07:09 | |
*** Luzi has quit IRC | 07:18 | |
*** tobiash has quit IRC | 07:27 | |
*** tobiash has joined #openstack-sdks | 07:31 | |
*** ralonsoh has joined #openstack-sdks | 07:34 | |
*** jpich has joined #openstack-sdks | 08:01 | |
*** gtema has joined #openstack-sdks | 08:06 | |
*** enriquetaso has joined #openstack-sdks | 08:12 | |
*** enriquetaso has quit IRC | 08:19 | |
*** enriquetaso has joined #openstack-sdks | 08:19 | |
*** enriquetaso has quit IRC | 08:30 | |
*** jpena|off is now known as jpena | 08:30 | |
*** enriquetaso has joined #openstack-sdks | 08:34 | |
*** black_ant has joined #openstack-sdks | 08:36 | |
*** mtreinish has quit IRC | 08:43 | |
*** mtreinish has joined #openstack-sdks | 08:44 | |
*** stephenfin has quit IRC | 08:44 | |
*** frickler has quit IRC | 08:45 | |
*** stephenfin has joined #openstack-sdks | 08:45 | |
*** frickler has joined #openstack-sdks | 08:46 | |
*** ricolin_ has joined #openstack-sdks | 09:05 | |
*** ricolin has quit IRC | 09:08 | |
openstackgerrit | Vishakha Agarwal proposed openstack/keystoneauth master: Generate pdf documentation https://review.opendev.org/682272 | 09:16 |
---|---|---|
*** ricolin_ is now known as ricolin | 09:23 | |
*** cdent has joined #openstack-sdks | 09:37 | |
*** ttsiouts has joined #openstack-sdks | 09:39 | |
*** enriquetaso has quit IRC | 09:40 | |
*** enriquetaso has joined #openstack-sdks | 09:48 | |
*** e0ne has joined #openstack-sdks | 09:54 | |
*** e0ne has quit IRC | 09:55 | |
*** e0ne has joined #openstack-sdks | 09:55 | |
*** gtema has quit IRC | 10:00 | |
*** enriquetaso has quit IRC | 10:05 | |
*** openstackstatus has quit IRC | 10:12 | |
*** openstack has joined #openstack-sdks | 10:16 | |
*** ChanServ sets mode: +o openstack | 10:16 | |
*** dtantsur|afk is now known as dtantsur | 10:17 | |
*** ttsiouts has quit IRC | 10:28 | |
*** ttsiouts has joined #openstack-sdks | 10:28 | |
*** ttsiouts has quit IRC | 10:33 | |
*** enriquetaso has joined #openstack-sdks | 10:45 | |
*** ttsiouts has joined #openstack-sdks | 11:07 | |
*** jpena is now known as jpena|lunch | 11:34 | |
mordred | enriquetaso: I think dtroyer got you - but I agree with dtantsur and dtroyer - and I think the best outcome would be switching to sdk | 11:38 |
enriquetaso | mordred, thanks for answering me. This is my first time working with openstacksdk. Is openstack cli going to deprecate? | 11:42 |
*** noama has joined #openstack-sdks | 11:45 | |
mordred | oh no - openstack cli is the future. sdk is what we want to use for REST interactions with services instead of the per-service python-*client libraries | 11:53 |
mordred | but the idea is that we put shared needed logic for things into sdk - then it's available to python users, as well as other sdk consumers like ansible and salt, and we can build the osc commands from that same logic | 11:54 |
mordred | *AND* - nova is starting to use sdk to talk to services - so the same logic can be reused for service-to-service interactions... but we don't have to maintain 30 different libraries | 11:55 |
enriquetaso | mordred++ | 11:56 |
enriquetaso | thanks! | 11:56 |
*** jpich has quit IRC | 11:58 | |
*** goldyfruit has quit IRC | 12:13 | |
*** enriquetaso has quit IRC | 12:33 | |
*** jpena|lunch is now known as jpena | 12:35 | |
*** enriquetaso has joined #openstack-sdks | 12:40 | |
*** gtema has quit IRC | 13:00 | |
*** mriedem has joined #openstack-sdks | 13:24 | |
*** goldyfruit has joined #openstack-sdks | 13:36 | |
*** gtema has joined #openstack-sdks | 14:15 | |
mriedem | dtroyer: got a question about an osc-placement patch proposed to stable/train b/c of an osc 4.0.0 change to remove support for --os-url and replace it with --os-endpoint https://review.opendev.org/#/c/684292/1 | 14:18 |
mriedem | cdent says that if you have python-openstackclient < 4.0 that won't work | 14:18 |
*** gtema has quit IRC | 14:19 | |
mriedem | but #14 on https://docs.openstack.org/python-openstackclient/latest/cli/backwards-incompatible.html makes it sound like that was a long-standing thing that we should have just not been using | 14:19 |
*** gtema has joined #openstack-sdks | 14:19 | |
cdent | I made it not work by only changing python-openstackclient, not osc-lib at the same time, so that may have been a factor | 14:19 |
mriedem | so we're trying to figure out if we need to bump the minimum required version of osc to >= 4.0.0 in osc-placement's test-requirements | 14:20 |
dtroyer | I'd have to refresh my memory, but —os-endpoint did not change, only the removal of —os-url. The plugin I took out basically just aliased the option names | 14:21 |
mriedem | cdent: ok so maybe you have to downgrade osc-lib to stein level and see if it works | 14:21 |
cdent | one mo | 14:21 |
mriedem | osc-lib 1.12.1 i guess? | 14:21 |
dtroyer | I do not recall making the sorts of changes to osc-lib that would affect this going backward, only to support taking things out of osc4 itself | 14:21 |
*** ttsiouts has quit IRC | 14:21 | |
dtroyer | but then my head went back to stx-land so who knows what I recall now… ;) | 14:22 |
mriedem | so --os-endpoint should work with osc 3.19.0 | 14:22 |
*** ttsiouts has joined #openstack-sdks | 14:22 | |
* cdent tries again | 14:22 | |
*** ttsiouts has quit IRC | 14:22 | |
*** ttsiouts has joined #openstack-sdks | 14:23 | |
cdent | if I downgrade just python-openstackclient it fails | 14:23 |
cdent | if I downgrade also osc-lib it still fails | 14:24 |
cdent | osc-lib 1.12.1 and p-osc 3.19.0 | 14:24 |
dtroyer | I want to say osc-lib should not be a factor here | 14:25 |
cdent | dtroyer: as you may recall, this is from the weird stuff that osc-placement is doing for its functional tests where it is sending an explicit token ("admin") to a defined url/endpoint | 14:26 |
cdent | the change that "fixes it" just replaces the use of --os-url with --os-endpoint in a call to shell.run() | 14:26 |
dtroyer | some of the logic for deducing the proper auth-type has been removed from osc to make it compatible with sdk/ksa, that included changing os-url to os-endpoint to specifically set —os-auth-type to 'admin_token' | 14:31 |
dtroyer | https://review.opendev.org/#/c/677795/4/openstackclient/shell.py | 14:31 |
dtroyer | I can't imagine that ksa has changed in this area at all recently, that should not be a factor | 14:32 |
dtroyer | cdent: look at the comment in https://review.opendev.org/#/c/678059/1/openstackclient/tests/functional/base.py and see if that applies to what you are doing | 14:34 |
dtroyer | it is about setting —os-auth-type in some cases and letting it default in others | 14:35 |
* cdent looks | 14:36 | |
*** jpich has joined #openstack-sdks | 14:37 | |
cdent | dtroyer: what the osc-p functional tests are doing is shell.OpenStackShell().run(list_of_args) without setting --os-cloud or --os-auth-type. Solely: --os-endpoint, --os-token, --os-placement-api-version (if asked), -f json, and then whatever the command being tested happens to be | 14:40 |
cdent | things work correctly like that in 4.0.0 | 14:41 |
cdent | and when it was --os-url they worked correctly in < 4.0.0 | 14:41 |
cdent | If I'm hearing you properly, what might be going on is that the os-endpoint support in < 4.0.0 needed an explicit --os-auth-type when --os-url did not? | 14:42 |
dtroyer | yes, the check in osc was only on —os-url to set os-auth-type to 'token_endpoint'. We never did a default for —os-endpoint before 4.0 | 14:43 |
mriedem | ah, so cdent - if you specify --os-auth-type in the functional test maybe we don't need to bump the required version of osc | 14:44 |
cdent | how should I orchestrate that patch wise? | 14:47 |
cdent | just do it on train? | 14:47 |
cdent | do it on both and backport | 14:48 |
cdent | something else? | 14:48 |
mriedem | do it on both and backport | 14:48 |
mriedem | if we want to require osc>=4.0 we should do that on master only | 14:48 |
mriedem | but i'm not sure it's necessary anymore | 14:48 |
cdent | roger con aye, 10 degree down bubble | 14:48 |
dtroyer | osc4 will be the stable/train branch f that matters… | 14:48 |
cdent | dtroyer: what is the proper auth-type to specify? | 14:51 |
cdent | I guess 'admin_token'? | 14:54 |
efried | mordred: is a versioned root endpoint supposed to require auth? | 14:56 |
efried | e.g. http://192.168.218.28/compute/v2.1 | 14:56 |
openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Microversion 2.78 - server show topology https://review.opendev.org/680928 | 14:57 |
dtroyer | cdent, mriedem: yes, admin_token is correct | 14:58 |
cdent | thanks dtroyer | 14:59 |
*** enriquetaso has quit IRC | 15:03 | |
*** goldyfruit_ has joined #openstack-sdks | 15:47 | |
*** ttsiouts has quit IRC | 15:49 | |
*** goldyfruit has quit IRC | 15:50 | |
*** dtantsur is now known as dtantsur|afk | 16:15 | |
*** gtema has quit IRC | 16:20 | |
*** jpich has quit IRC | 16:21 | |
*** gtema has joined #openstack-sdks | 16:21 | |
*** gtema has quit IRC | 16:26 | |
*** e0ne has quit IRC | 16:57 | |
*** KeithMnemonic has quit IRC | 17:00 | |
*** KeithMnemonic has joined #openstack-sdks | 17:00 | |
*** ricolin has quit IRC | 17:03 | |
*** jpena is now known as jpena|off | 17:32 | |
*** ralonsoh has quit IRC | 17:42 | |
*** e0ne has joined #openstack-sdks | 17:47 | |
*** cdent has quit IRC | 18:08 | |
*** e0ne has quit IRC | 18:09 | |
openstackgerrit | guang-yee proposed openstack/keystoneauth master: Generate pdf documentation https://review.opendev.org/682272 | 18:21 |
*** e0ne has joined #openstack-sdks | 18:32 | |
*** e0ne has quit IRC | 18:33 | |
*** mriedem has quit IRC | 18:48 | |
*** mriedem has joined #openstack-sdks | 18:49 | |
*** e0ne has joined #openstack-sdks | 18:54 | |
*** gtema has joined #openstack-sdks | 19:53 | |
*** e0ne has quit IRC | 19:59 | |
*** noama has quit IRC | 20:07 | |
openstackgerrit | guang-yee proposed openstack/keystoneauth master: Generate pdf documentation https://review.opendev.org/682272 | 20:25 |
*** black_ant has quit IRC | 20:29 | |
*** black_ant has joined #openstack-sdks | 20:30 | |
*** e0ne has joined #openstack-sdks | 20:38 | |
*** slaweq has quit IRC | 22:00 | |
*** e0ne has quit IRC | 22:04 | |
*** gtema has quit IRC | 22:13 | |
openstackgerrit | Eric Fried proposed openstack/openstacksdk master: Make proxy honor raise_exc in REST primitives https://review.opendev.org/684433 | 22:23 |
openstackgerrit | Eric Fried proposed openstack/openstacksdk master: Make proxy honor raise_exc in REST primitives https://review.opendev.org/684433 | 22:25 |
*** black_ant has quit IRC | 22:28 | |
*** ccamel has joined #openstack-sdks | 22:44 | |
*** camelCaser has quit IRC | 22:47 | |
*** dtantsur|afk has quit IRC | 22:51 | |
*** goldyfruit_ has quit IRC | 23:14 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!