| *** enriquetaso has quit IRC | 00:12 | |
| *** goldyfruit_ has joined #openstack-sdks | 00:23 | |
| *** factor has joined #openstack-sdks | 02:47 | |
| *** dave-mccowan has quit IRC | 03:37 | |
| *** ttsiouts has joined #openstack-sdks | 07:07 | |
| *** tosky has joined #openstack-sdks | 07:16 | |
| *** cdent has joined #openstack-sdks | 07:21 | |
| *** ttsiouts has quit IRC | 07:26 | |
| *** ttsiouts has joined #openstack-sdks | 07:27 | |
| *** ttsiouts has quit IRC | 07:31 | |
| *** ttsiouts has joined #openstack-sdks | 07:33 | |
| *** jangutter has joined #openstack-sdks | 07:46 | |
| *** ttsiouts has quit IRC | 07:48 | |
| *** ttsiouts has joined #openstack-sdks | 07:49 | |
| *** jpena|off is now known as jpena | 07:49 | |
| *** e0ne has joined #openstack-sdks | 07:52 | |
| *** e0ne has quit IRC | 07:53 | |
| *** ttsiouts has quit IRC | 07:53 | |
| *** slaweq has joined #openstack-sdks | 08:06 | |
| *** ttsiouts has joined #openstack-sdks | 08:07 | |
| *** gtema has joined #openstack-sdks | 08:11 | |
| *** jpich has joined #openstack-sdks | 08:13 | |
| *** gtema_ has joined #openstack-sdks | 08:19 | |
| *** slaweq has quit IRC | 08:41 | |
| *** e0ne has joined #openstack-sdks | 08:49 | |
| *** slaweq has joined #openstack-sdks | 08:52 | |
| *** gtema_ has quit IRC | 09:00 | |
| *** ricolin has quit IRC | 09:15 | |
| *** gtema_ has joined #openstack-sdks | 09:16 | |
| stephenfin | amotoki: Morning. Could I ask you to look at this change for me, please? https://review.opendev.org/#/c/664393/ It's been around for some time and is blocking some doc rework I want to do in nova | 09:26 |
|---|---|---|
| mordred | hey stephenfin | 09:27 |
| mordred | looking | 09:27 |
| stephenfin | mordred: Yo. Thanks :) | 09:27 |
| mordred | stephenfin: done | 09:28 |
| stephenfin | \o/ Appreciate it | 09:28 |
| mordred | stephenfin: you know things ... | 09:28 |
| stephenfin | don't you do it | 09:28 |
| mordred | stephenfin: what's the python2 story for U again? support goes away, right? | 09:28 |
| stephenfin | phew, thought you were threatening me with core on something I didn't want for a second | 09:29 |
| stephenfin | Yup, kill it | 09:29 |
| * mordred makes stephenfin core on sdk just to mess with him | 09:29 | |
| stephenfin | We haven't started removing stuff in nova yet and probably won't until Train GA | 09:29 |
| stephenfin | but after that... | 09:29 |
| mordred | stephenfin: cool. I have someone interested in adding some type annotations - which obviously need 2 to go away | 09:30 |
| stephenfin | mordred: https://review.opendev.org/#/c/676209/ | 09:30 |
| stephenfin | ignore all the failures - I rushed it :) | 09:30 |
| mordred | nice! | 09:30 |
| stephenfin | We might want to put this in openstack-zuul-jobs though https://review.opendev.org/#/c/676210/ | 09:31 |
| mordred | stephenfin: zuul projects are already py3 - this one: https://review.opendev.org/#/c/686249/ added annotations but had to put in an ignore on the "import openstack" line | 09:31 |
| mordred | yeah - probably so. we've actually caught bugs with mypy in zuul | 09:32 |
| stephenfin | mordred: That's because we're using an old version of flake8 because hacking hasn't been updated. New versions support type hints | 09:32 |
| stephenfin | or rather, detect that an import is necessary due to type hints | 09:32 |
| stephenfin | alas, updating hacking to work with flake8 3.x is easier said that done because it was completely rewritten. I've tried and failed a few times :( | 09:32 |
| mordred | oh - no - I mean we had to mypy ignore it becuase there's no type information from openstack I think | 09:32 |
| stephenfin | ohhh | 09:32 |
| mordred | oh goodie | 09:33 |
| mordred | stephenfin: yeah - line 17: https://review.opendev.org/#/c/686249/3/zuul_registry/swift.py | 09:33 |
| stephenfin | mordred: This should do the same thing, I think https://review.opendev.org/#/c/676208/1/setup.cfg@91 | 09:33 |
| stephenfin | but maybe not. I'm at about 3/10 on the "understanding how mypy works" scale rn | 09:34 |
| mordred | stephenfin: ignore_missing_imports? or follow_imports=skip? | 09:34 |
| stephenfin | ignore_missing_imports | 09:34 |
| stephenfin | hmm, maybe not actually | 09:34 |
| mordred | ah - no, follow_imports=skip | 09:35 |
| mordred | https://mypy.readthedocs.io/en/latest/running_mypy.html#follow-imports | 09:35 |
| stephenfin | Hmm, worth experimenting with those flags, I imagine | 09:36 |
| stephenfin | That's cool though | 09:36 |
| mordred | yeah | 09:37 |
| stephenfin | I'd like to see them in most of oslo too, though I think I'll need to request help from the mypy folks for o.v.o. That's a weird one | 09:37 |
| stephenfin | zuul doesn't use oslo though, does it? | 09:37 |
| mordred | that said - it would be nice to add the annotations so that you could annotate things with signatures of the imported objects | 09:37 |
| mordred | stephenfin: that's right - zuul does not use oslo | 09:37 |
| stephenfin | cool. probably won't affect you much so :) | 09:37 |
| *** cdent has quit IRC | 09:51 | |
| mordred | stephenfin: oh - actually - fwiw, we just run mypy in our pep8 tox env | 09:55 |
| mordred | which is really "static code analysis tox env" | 09:55 |
| stephenfin | Hmm, I wanted to keep it separate because (a) pep8 is already _really_ slow in nova and I did not want to make it even slower, and (b) we're all luddites there and I didn't want to foist stuff onto people before they were ready :) | 09:57 |
| stephenfin | I could go with pep8 though. Don't some project use a 'linters' target? | 09:57 |
| stephenfin | *projects | 09:57 |
| stephenfin | or 'style' or something? /me tries to recall where he saw it | 09:57 |
| mordred | stephenfin: yeah - we tried switching to linters a while back, but didn't really get any traction | 10:07 |
| mordred | but - you know - mostly thinking about it from a gate pov and not a local dev pov - I imagine pep8+mypy is still quicker than py36 unittests | 10:08 |
| mordred | it's a good point re: local dev though, especially if pep8 is slow for y'all | 10:08 |
| mordred | poo. the connection metaclass makes sdk almost impossible to type hint | 10:14 |
| mordred | maybe we should replace it with a generated file and a zuul job that runs when os-service-types list updates | 10:15 |
| *** cdent has joined #openstack-sdks | 10:27 | |
| *** ttsiouts has quit IRC | 10:31 | |
| *** ttsiouts has joined #openstack-sdks | 10:31 | |
| *** ttsiouts has quit IRC | 10:36 | |
| openstackgerrit | Merged openstack/os-client-config master: Update master for stable/train https://review.opendev.org/683481 | 10:50 |
| *** jpena is now known as jpena|lunch | 11:00 | |
| *** ttsiouts has joined #openstack-sdks | 11:01 | |
| openstackgerrit | Merged openstack/shade master: Update master for stable/train https://review.opendev.org/683658 | 11:02 |
| openstackgerrit | Merged openstack/shade master: fix "How To Contribute",bugs,review url https://review.opendev.org/682801 | 11:02 |
| openstackgerrit | Merged openstack/python-openstackclient master: Add 'openstack server migrate (confirm|revert)' commands https://review.opendev.org/664393 | 11:19 |
| *** gtema_ has quit IRC | 11:39 | |
| *** tosky_ has joined #openstack-sdks | 11:44 | |
| *** tosky has quit IRC | 11:46 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use has_service in functional test's require_service https://review.opendev.org/685995 | 11:49 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix server for later microversion https://review.opendev.org/685999 | 11:49 |
| *** tosky_ is now known as tosky | 12:01 | |
| *** jpena|lunch is now known as jpena | 12:12 | |
| *** ttsiouts has quit IRC | 12:17 | |
| *** ttsiouts has joined #openstack-sdks | 12:17 | |
| *** ttsiouts has quit IRC | 12:19 | |
| *** goldyfruit_ has quit IRC | 12:19 | |
| *** ttsiouts has joined #openstack-sdks | 12:19 | |
| *** enriquetaso has joined #openstack-sdks | 12:26 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: WIP Start supporting type info https://review.opendev.org/686397 | 13:11 |
| *** mriedem has joined #openstack-sdks | 13:22 | |
| *** goldyfruit_ has joined #openstack-sdks | 13:23 | |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: WIP Add typing flag file https://review.opendev.org/686401 | 13:32 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use has_service in functional test's require_service https://review.opendev.org/685995 | 13:50 |
| *** gtema has quit IRC | 13:55 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix server for later microversion https://review.opendev.org/685999 | 13:56 |
| openstackgerrit | Pierre Prinetti proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408 | 13:56 |
| mordred | dtantsur|afk: when you get a sec, I left a note in 685999 - I'm wondering if you have any ideas on how a "good" way to handle that is since you've been doing more with microversions so far | 14:00 |
| mordred | I'm guessing I'd want to put something into the ServerGroup resource that controlled which mv it used when doing the creation call | 14:00 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix server for later microversion https://review.opendev.org/685999 | 14:08 |
| mordred | dtantsur|afk: neverind - mriedem tells me that in this case it's easy - old mv never actually supported a list | 14:10 |
| mriedem | child's play | 14:11 |
| *** ricolin has joined #openstack-sdks | 14:17 | |
| openstackgerrit | Pierre Prinetti proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408 | 14:19 |
| openstackgerrit | Pierre Prinetti proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408 | 14:23 |
| *** goldyfruit_ has quit IRC | 14:49 | |
| *** ttsiouts has quit IRC | 14:51 | |
| *** ttsiouts has joined #openstack-sdks | 14:51 | |
| *** ttsiouts has quit IRC | 14:53 | |
| *** ttsiouts has joined #openstack-sdks | 14:53 | |
| *** goldyfruit_ has joined #openstack-sdks | 14:57 | |
| *** jpena is now known as jpena|off | 14:59 | |
| *** goldyfruit_ has quit IRC | 15:25 | |
| *** goldyfruit_ has joined #openstack-sdks | 15:28 | |
| openstackgerrit | Pierre Prinetti proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408 | 15:33 |
| *** ttsiouts has quit IRC | 15:37 | |
| openstackgerrit | Matt Riedemann proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408 | 15:37 |
| *** ttsiouts has joined #openstack-sdks | 15:37 | |
| *** ttsiouts has quit IRC | 15:42 | |
| openstackgerrit | Pierre Prinetti proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408 | 15:46 |
| openstackgerrit | Tristan Cacqueray proposed openstack/openstacksdk master: WIP: annotate some swift function used by the zuul_registry https://review.opendev.org/686433 | 15:56 |
| openstackgerrit | Matt Riedemann proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408 | 15:59 |
| elmiko | API SIG office hour is now open | 16:00 |
| *** cdent has quit IRC | 16:18 | |
| *** goldyfruit___ has joined #openstack-sdks | 16:24 | |
| *** goldyfruit_ has quit IRC | 16:27 | |
| *** e0ne has quit IRC | 16:36 | |
| *** jpich has quit IRC | 16:39 | |
| *** jpena|off is now known as jpena | 16:41 | |
| *** goldyfruit___ has quit IRC | 17:08 | |
| *** tosky has quit IRC | 17:14 | |
| *** openstackgerrit has quit IRC | 17:21 | |
| *** ricolin has quit IRC | 17:35 | |
| *** e0ne has joined #openstack-sdks | 17:59 | |
| *** jpena is now known as jpena|off | 18:05 | |
| *** e0ne has quit IRC | 18:06 | |
| *** ralonsoh has quit IRC | 18:10 | |
| *** goldyfruit___ has joined #openstack-sdks | 18:16 | |
| *** zbr|ruck is now known as zbr | 19:14 | |
| *** gmann is now known as gmann_afk | 19:52 | |
| *** gtema has joined #openstack-sdks | 20:10 | |
| *** gtema has quit IRC | 20:12 | |
| *** factor has quit IRC | 20:49 | |
| *** tosky has joined #openstack-sdks | 20:50 | |
| *** slaweq has quit IRC | 21:14 | |
| *** goldyfruit___ has quit IRC | 21:15 | |
| *** goldyfruit has joined #openstack-sdks | 21:15 | |
| *** camelCaser has quit IRC | 21:28 | |
| *** camelCaser has joined #openstack-sdks | 21:28 | |
| *** enriquetaso has quit IRC | 21:35 | |
| *** goldyfruit_ has joined #openstack-sdks | 23:00 | |
| *** goldyfruit has quit IRC | 23:02 | |
| *** tosky has quit IRC | 23:23 | |
| *** mriedem has quit IRC | 23:26 | |
| *** goldyfruit_ has quit IRC | 23:56 | |
| *** openstackgerrit has joined #openstack-sdks | 23:59 | |
| openstackgerrit | Brin Zhang proposed openstack/python-openstackclient master: Add server migrate list CLI https://review.opendev.org/675304 | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!