*** mriedem has quit IRC | 00:32 | |
*** senrique__ has joined #openstack-sdks | 00:33 | |
*** tobberydberg has quit IRC | 00:35 | |
*** senrique_ has quit IRC | 00:36 | |
*** tobberydberg has joined #openstack-sdks | 00:37 | |
*** ricolin has joined #openstack-sdks | 00:43 | |
*** senrique__ has quit IRC | 00:51 | |
*** ricolin has quit IRC | 01:09 | |
*** ricolin has joined #openstack-sdks | 01:09 | |
*** enriquetaso has joined #openstack-sdks | 01:17 | |
*** enriquetaso has quit IRC | 02:00 | |
*** gtema has joined #openstack-sdks | 02:05 | |
*** gtema has quit IRC | 02:09 | |
*** gtema has joined #openstack-sdks | 04:05 | |
*** gtema has quit IRC | 04:10 | |
*** dave-mccowan has quit IRC | 05:30 | |
*** gtema has joined #openstack-sdks | 06:06 | |
*** ricolin has quit IRC | 06:10 | |
*** gtema has quit IRC | 06:11 | |
*** logan- has quit IRC | 07:09 | |
*** logan_ has joined #openstack-sdks | 07:10 | |
*** logan_ is now known as logan- | 07:10 | |
*** gtema has joined #openstack-sdks | 07:47 | |
*** gtema has quit IRC | 07:59 | |
*** gtema has joined #openstack-sdks | 07:59 | |
*** ricolin has joined #openstack-sdks | 08:06 | |
*** ricolin has quit IRC | 08:06 | |
*** ricolin has joined #openstack-sdks | 08:07 | |
*** slaweq has quit IRC | 08:21 | |
*** jpich has joined #openstack-sdks | 08:29 | |
openstackgerrit | Vishakha Agarwal proposed openstack/python-openstackclient master: Adding options to user cli https://review.opendev.org/697444 | 08:31 |
---|---|---|
*** jangutter has joined #openstack-sdks | 08:33 | |
*** tosky has joined #openstack-sdks | 08:40 | |
*** slaweq has joined #openstack-sdks | 08:42 | |
*** ricolin has quit IRC | 08:47 | |
*** ralonsoh has joined #openstack-sdks | 08:49 | |
*** jpena|off is now known as jpena | 08:54 | |
*** yolanda has quit IRC | 10:53 | |
*** ricolin has joined #openstack-sdks | 10:59 | |
*** ricolin_ has joined #openstack-sdks | 11:02 | |
*** ricolin has quit IRC | 11:04 | |
openstackgerrit | Artem Goncharov proposed openstack/osc-lib master: Add get_osc_show_columns_for_sdk_resource function https://review.opendev.org/698874 | 11:15 |
*** ricolin_ has quit IRC | 11:18 | |
*** yolanda has joined #openstack-sdks | 11:25 | |
*** jangutter has quit IRC | 11:47 | |
*** jangutter_ has joined #openstack-sdks | 11:47 | |
*** dtantsur|afk is now known as dtantsur | 12:02 | |
*** jpena is now known as jpena|lunch | 12:29 | |
*** mgoddard has quit IRC | 12:30 | |
*** dave-mccowan has joined #openstack-sdks | 12:40 | |
*** mgariepy has joined #openstack-sdks | 12:40 | |
*** jpich has quit IRC | 12:59 | |
*** goldyfruit has joined #openstack-sdks | 13:07 | |
*** mgoddard has joined #openstack-sdks | 13:21 | |
*** gtema has quit IRC | 13:25 | |
*** jangutter_ is now known as jangutter | 13:30 | |
*** jpena|lunch is now known as jpena | 13:37 | |
*** lbragstad has joined #openstack-sdks | 13:48 | |
*** mriedem has joined #openstack-sdks | 14:00 | |
*** gtema has joined #openstack-sdks | 14:06 | |
*** gtema has quit IRC | 14:08 | |
*** gtema has joined #openstack-sdks | 14:09 | |
openstackgerrit | Merged openstack/openstacksdk master: Remove duplicate job definition https://review.opendev.org/698057 | 14:32 |
*** dmellado has quit IRC | 14:36 | |
*** enriquetaso has joined #openstack-sdks | 14:37 | |
*** dmellado has joined #openstack-sdks | 14:39 | |
*** lbragstad has quit IRC | 15:47 | |
*** dtroyer has quit IRC | 15:52 | |
*** ricolin_ has joined #openstack-sdks | 15:53 | |
*** enriquetaso has quit IRC | 16:06 | |
mriedem | efried: mordred: see the question in the ML - i'm not sure how a volume-backed server in the sdk is represented for the Server.image attribute because the sdk defines that as an Image type but for a volume-backed server the actual server.image response body param is an empty string | 16:11 |
efried | ack, I'll have to get back to that later. | 16:12 |
*** efried is now known as efried_afk | 16:12 | |
mordred | mriedem: I'll have to go dig around (and look at that) - I know for server creation we have a large pile of logic | 16:12 |
mordred | in the resource layer there - we have image = resource.Body('image', type=image.Image | 16:14 |
mordred | so that's going to mean the sdk is going to pass the empty string value to the Image constructor - meaning that code looking for not image is not going to work | 16:14 |
mordred | however - that should be a ludicrously empty Image with an id of '' | 16:15 |
gtema | I'm not really sure, image_id will be empty | 16:15 |
mordred | so maybe an easy fix would be if not server.image.id | 16:15 |
mordred | or test for image_id | 16:15 |
mordred | (is imageRef also an empty string in the response?) | 16:15 |
gtema | in my cloud even for servers booted from image I still see image in the response | 16:15 |
mriedem | yeah i at least picked up that the Image field isn't going to be Falsey | 16:16 |
mordred | yeah | 16:16 |
mriedem | gtema: that would be expected... | 16:16 |
mordred | now - maybe we should add some logic to look for an empty string image and set Image to None if so | 16:16 |
mriedem | the servers body response will always have 'image'; if it's volume-backed the value is '', else it's a dict | 16:16 |
mriedem | mordred: or some sugar on the Server object like is_volume_backed that hides those details based on the internal image object? | 16:17 |
mordred | mriedem: that's a great idea | 16:17 |
mriedem | because it is a confusing API wrinkle few know about | 16:18 |
mordred | yup | 16:18 |
* mordred is trying to think where he has a volume backed server - vexxhost probably ... | 16:18 | |
mriedem | in your pet nfv cloud duh | 16:19 |
gtema | mordred: but I mean for volume booted image is not an empty struct in my case | 16:21 |
gtema | volume booted server | 16:21 |
mordred | actually - server.image is totally truthy | 16:21 |
gtema | and this is against mriedem statement | 16:21 |
mriedem | show me a raw GET /servers/<server_id> response of a volume-backed server that you have | 16:22 |
mordred | I just grabbed a volume-backed server and it has an empty server.image property from sdk | 16:22 |
mriedem | where volume-backed means the server was created with a block_device_mapping_v2 list where one entry has boot_index=0 and destination_type=volume | 16:22 |
mordred | one sec - I'll reproduce with http calls | 16:22 |
gtema | http://paste.openstack.org/show/787562/ | 16:23 |
gtema | formatted output http://paste.openstack.org/show/787563/ | 16:24 |
*** stephenfin is now known as finucannot | 16:25 | |
mordred | http://paste.openstack.org/show/787564/ | 16:26 |
gtema | and only request about one of the volumes contain volume_image_metadata | 16:26 |
mriedem | gtema: can you show me the block_device_mappings table entries for that server? | 16:26 |
mriedem | *block_device_mapping table | 16:26 |
mordred | so - in my case at least, the server returned from sdk correctly has an empty image property | 16:26 |
gtema | in the second past - os-extended-volumes:volumes_attached | 16:26 |
mriedem | gtema: that doesn't mean the server is volume-backed, it just means there are volumes attached | 16:27 |
mordred | OH FOR T?HE LOVE OF | 16:27 |
mordred | why is this not doing /detail ? | 16:27 |
mriedem | as i said, volume-backed == boot_index=0 and destination_type=volume | 16:27 |
gtema | one of them is with volume_image_metadata | 16:27 |
mriedem | that doesn't matter | 16:27 |
mriedem | i would need to see your block_device_mapping entries for that server | 16:28 |
gtema | if only I could get them that easy | 16:28 |
mordred | gtema: can we change sdk to NEVER make server calls with /detail ? | 16:29 |
mordred | the non /detail response is useless | 16:29 |
mordred | land I don't se a way to make find_server do a /detail call | 16:29 |
gtema | my response is actually from the server GET | 16:30 |
mordred | yah - I'm just trying to explore what properties I get from the actual sdk interaction - and the first issue is that I get back an almost empty server with no intormation in it | 16:30 |
mordred | so now I'm fixated on that horrible experience | 16:30 |
gtema | do you want to switch your focus? | 16:31 |
mordred | ok. NOW - I confirm that none of the servers I was looking at are actually volume backed | 16:32 |
mordred | and I need to go find a new one | 16:33 |
mordred | c.compute.servers() does details calls - so looking at the results from that gives you valid server objects | 16:33 |
mordred | I will now look for a different cloud where I have booted a volume backed server to I can look at the question at hand :) | 16:34 |
mriedem | mordred: note that /detail is when listing servers so that's not what you want | 16:34 |
gtema | which are at least in my case always with image filled independently on volume_backed or not | 16:34 |
mriedem | you want GET /server/<server_id> for find_server | 16:34 |
mriedem | that has the details | 16:34 |
mordred | mriedem: it totally doesn't | 16:34 |
mriedem | GET /servers/ is listing servers w/o details | 16:34 |
mordred | well - ok - let's pause here for a sec | 16:34 |
mriedem | https://docs.openstack.org/api-ref/compute/#show-server-details | 16:34 |
mriedem | https://docs.openstack.org/api-ref/compute/#list-servers is the mostly useless thing | 16:35 |
mordred | when I do the sdk call that is the equiv of GET /server/<server_id> I'm getting a Server with an empty image property | 16:35 |
mordred | when I do the equiv of /servers/details - I get image with an Image object in it | 16:35 |
mordred | for the same servers | 16:35 |
mordred | so - let's consider that a bug that should be addressed | 16:35 |
gtema | what exactly do you consider as a bug? | 16:36 |
mordred | I would expect find_server(server_id) to return an object that is similar to servers()[0] | 16:36 |
mordred | rather than a minimal object wiht almost no information | 16:36 |
*** ricolin_ has quit IRC | 16:36 | |
mordred | because wht is returned by find_server is USELESS | 16:36 |
gtema | ok, I was never using it in this context, but from the code looks like that | 16:38 |
mordred | yeah - I've never used it either :) | 16:38 |
mordred | ok - I switched clouds and found one that is volume backed | 16:38 |
mordred | and can confirm that it gets an empty Image object | 16:41 |
gtema | good for you, this is not same for me | 16:41 |
gtema | but you know my cloud - there are definitely some additional patches on top | 16:42 |
mordred | gtema: yah | 16:43 |
mordred | mriedem: how do I get the block_device_mapping for a server? | 16:43 |
gtema | so for me the only "reliable" way is that one of 2 volumes attached shows really image information | 16:43 |
mordred | gtema: what does the image field show? | 16:44 |
gtema | links + id | 16:44 |
mordred | gtema: and you're sure you did boot-from-volume on that server? | 16:44 |
gtema | 99.9% | 16:45 |
mordred | cause that sounds like boot-from-image with a root volujme | 16:45 |
gtema | that is the only chance to get different size for the root volume | 16:45 |
mordred | no - you can do boot-from-image and pass a voluem to be used as the root filesystem | 16:45 |
gtema | is than boot from volume something different? | 16:45 |
mordred | yes | 16:45 |
gtema | ah, ok | 16:46 |
mordred | or - I think it is | 16:46 |
mordred | I might be smoking crack | 16:46 |
mordred | mriedem: ? | 16:46 |
mordred | gtema: it all has to do with block_device_mapping - which is hella com[ex | 16:46 |
gtema | boot-from-image seems exactly what I was doing | 16:46 |
mriedem | mordred: the actual volumes attached to the server? | 16:46 |
mriedem | https://docs.openstack.org/api-ref/compute/#list-volume-attachments-for-an-instance | 16:47 |
mriedem | that doesn't tell you the boot_index though | 16:47 |
mriedem | that's in thedb | 16:47 |
gtema | well, my "assumption" is that I was passing (or relying on SDK to do this) block_device_mapping with boot volume from image | 16:47 |
mordred | mriedem: I don't have access to the db | 16:47 |
mriedem | boot_index=0 and destination_type=volume == volume-backed server | 16:47 |
mriedem | was pretty sure we had a spec at one point to expose the boot_index in that api but must have never landed | 16:48 |
mordred | ok - sdk created servers with boot from volume do boot_index=0 and destination_type=volume for both | 16:48 |
mriedem | oh this was the spec that was going to expose boot_index in the volume attachments api but never landed https://specs.openstack.org/openstack/nova-specs/specs/train/approved/detach-boot-volume.html#proposed-change | 16:50 |
*** finucannot is now known as stephenfin | 16:51 | |
mordred | here's what we do create-side: https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/cloud/_compute.py#L978-L1049 | 16:55 |
gtema | just now tried to create separately volume from image, and using OSC create server from volume: http://paste.openstack.org/show/787569/ | 17:02 |
gtema | still image is filled | 17:02 |
gtema | 'block_device_mapping_v2': [{'uuid': 'd30f638f-655d-4999-9bb7-205b3c082a0e', 'boot_index': '0', 'source_type': 'volume', 'destination_type': 'volume'}] | 17:03 |
mordred | gtema: your cloud is weird man | 17:11 |
gtema | sure | 17:11 |
mordred | gtema: what's in image? | 17:11 |
gtema | cirros | 17:11 |
mordred | that's what you created the volume from? | 17:11 |
gtema | yes - pure cirros image | 17:11 |
gtema | not even our customized one | 17:12 |
mordred | and the image field in the serer record shows cirror even though you did that boot_index / destination_type above? | 17:12 |
gtema | yes | 17:12 |
gtema | I find it useful | 17:12 |
gtema | it might be not what is expected, but really useful | 17:13 |
gtema | what might be also different - it should be somewhere on Queens level | 17:13 |
mordred | yeah - except now it's hard to know if it's a BFV ... :) | 17:13 |
gtema | agree. But according to api-ref: The image object might be an empty string when you boot the server from a volume. | 17:14 |
gtema | __MIGHT__ | 17:14 |
*** enriquetaso has joined #openstack-sdks | 17:19 | |
gtema | mordred, btw thanks for comment in image patch. It's not what I was expecting, but ok. | 17:19 |
*** jangutter has quit IRC | 17:25 | |
mordred | gtema: sure nuff - the main thing I'd be opposed to is losing any of the existing sdk functionality ijn chasing support for stdin. If there's a way to support it for osc that doesn't screw up everything else ... I mean, who am I to judge. | 17:25 |
mordred | it's definitely not a thing *I* want to use | 17:26 |
gtema | I'm going to push patch to SDK soon, while it again affect lot, seems to be pretty strait forward | 17:26 |
mordred | cool | 17:26 |
gtema | would be nice to add src-sdk job to OSC not to depend on release | 17:28 |
*** openstackgerrit has quit IRC | 17:29 | |
*** openstackgerrit has joined #openstack-sdks | 17:32 | |
openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Support uploading image from data and stdin https://review.opendev.org/698972 | 17:32 |
gtema | need to fall out. See ya | 17:33 |
mriedem | "_MIGHT__" - the api-ref wording shouldn't probably say that | 17:34 |
mriedem | it will be an empty string if bfv | 17:34 |
mriedem | https://github.com/openstack/nova/blob/2f0f8b8cf13b7441ce6a7a524b33d30d40f1d468/nova/api/openstack/compute/views/servers.py#L540 | 17:35 |
mriedem | https://review.opendev.org/#/c/698976/ | 17:37 |
*** lbragstad has joined #openstack-sdks | 17:39 | |
*** senrique_ has joined #openstack-sdks | 17:39 | |
gtema | mriedem, according to this block image_ref is populated in my case when BFV. Can this happen in some cases? | 17:40 |
gtema | I have no access to sources, but will try to figure out | 17:40 |
*** dtantsur is now known as dtantsur|afk | 17:40 | |
mriedem | it shouldn't be i don't think https://github.com/openstack/nova/blob/2f0f8b8cf13b7441ce6a7a524b33d30d40f1d468/nova/compute/api.py#L1433 | 17:41 |
gtema | ok | 17:41 |
gtema | means some extra patch on my cloud | 17:42 |
mriedem | maybe a problem when creating a server with an image specified and a bdm list, or that | 17:42 |
mriedem | but when booting from volume the specified imageRef should be ignored | 17:42 |
*** mriedem is now known as mriedem_away | 17:42 | |
*** enriquetaso has quit IRC | 17:42 | |
*** gtema has quit IRC | 17:42 | |
*** cmurphy is now known as cmorpheus | 17:43 | |
*** jpena is now known as jpena|off | 17:53 | |
*** melwitt is now known as jgwentworth | 17:57 | |
*** gtema has joined #openstack-sdks | 18:18 | |
*** gtema has quit IRC | 18:23 | |
*** ralonsoh has quit IRC | 18:30 | |
*** lbragstad has quit IRC | 18:41 | |
*** lbragsta_ has joined #openstack-sdks | 18:41 | |
*** yolanda has quit IRC | 18:43 | |
*** tosky has quit IRC | 18:57 | |
*** gtema has joined #openstack-sdks | 19:13 | |
*** gtema has quit IRC | 19:19 | |
*** mriedem_away has quit IRC | 19:29 | |
*** mriedem has joined #openstack-sdks | 19:31 | |
*** lbragsta_ is now known as lbragstad | 19:31 | |
*** efried_afk is now known as efried | 19:32 | |
*** senrique__ has joined #openstack-sdks | 19:39 | |
*** lbragsta_ has joined #openstack-sdks | 19:40 | |
*** senrique_ has quit IRC | 19:42 | |
*** lbragstad has quit IRC | 19:43 | |
*** gtema has joined #openstack-sdks | 19:59 | |
*** gtema has quit IRC | 20:06 | |
*** gmann is now known as gmann_afk | 20:13 | |
*** lbragstad has joined #openstack-sdks | 20:42 | |
*** lbragsta_ has quit IRC | 20:44 | |
*** gtema has joined #openstack-sdks | 20:50 | |
*** senrique__ has quit IRC | 20:52 | |
*** gtema has quit IRC | 20:55 | |
*** gtema has joined #openstack-sdks | 21:05 | |
openstackgerrit | Keith Berger proposed openstack/python-openstackclient master: WIP:Fix openstack server list --deleted --marker option https://review.opendev.org/691045 | 21:10 |
*** gtema has quit IRC | 21:11 | |
*** gtema has joined #openstack-sdks | 21:17 | |
*** gtema has quit IRC | 21:24 | |
*** gtema has joined #openstack-sdks | 21:34 | |
*** gtema has quit IRC | 21:38 | |
*** lbragstad has quit IRC | 21:40 | |
*** lbragstad has joined #openstack-sdks | 21:42 | |
*** gtema has joined #openstack-sdks | 21:54 | |
*** gtema has quit IRC | 22:02 | |
*** logan- has quit IRC | 22:04 | |
*** logan- has joined #openstack-sdks | 22:06 | |
*** slaweq has quit IRC | 22:14 | |
*** KeithMnemonic1 has joined #openstack-sdks | 22:15 | |
*** KeithMnemonic has quit IRC | 22:19 | |
*** lbragsta_ has joined #openstack-sdks | 22:42 | |
*** lbragstad has quit IRC | 22:43 | |
*** gtema has joined #openstack-sdks | 22:51 | |
*** lbragsta_ has quit IRC | 22:54 | |
*** mriedem has quit IRC | 22:54 | |
*** gtema has quit IRC | 22:55 | |
openstackgerrit | Keith Berger proposed openstack/python-openstackclient master: WIP:Fix openstack server list --deleted --marker option https://review.opendev.org/691045 | 23:12 |
*** gtema has joined #openstack-sdks | 23:12 | |
*** gtema has quit IRC | 23:17 | |
*** KeithMnemonic1 has quit IRC | 23:19 | |
*** gtema has joined #openstack-sdks | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!