*** slaweq has joined #openstack-sdks | 00:11 | |
*** slaweq has quit IRC | 00:15 | |
*** dayou has quit IRC | 00:36 | |
*** dayou has joined #openstack-sdks | 00:37 | |
*** slaweq has joined #openstack-sdks | 01:11 | |
*** slaweq has quit IRC | 01:16 | |
*** slaweq has joined #openstack-sdks | 02:11 | |
*** slaweq has quit IRC | 02:15 | |
*** __ministry has quit IRC | 02:59 | |
*** slaweq has joined #openstack-sdks | 03:11 | |
*** __ministry has joined #openstack-sdks | 03:12 | |
*** slaweq has quit IRC | 03:16 | |
*** slaweq has joined #openstack-sdks | 04:11 | |
*** slaweq has quit IRC | 04:17 | |
*** slaweq has joined #openstack-sdks | 05:11 | |
*** slaweq has quit IRC | 05:15 | |
*** evrardjp has quit IRC | 05:35 | |
*** evrardjp has joined #openstack-sdks | 05:35 | |
*** slaweq has joined #openstack-sdks | 06:11 | |
*** slaweq has quit IRC | 06:16 | |
*** slaweq has joined #openstack-sdks | 07:11 | |
*** slaweq has quit IRC | 07:15 | |
*** slaweq has joined #openstack-sdks | 07:38 | |
*** slaweq has quit IRC | 07:43 | |
*** slaweq has joined #openstack-sdks | 07:49 | |
*** tosky has joined #openstack-sdks | 08:32 | |
*** ralonsoh has joined #openstack-sdks | 08:33 | |
*** jpena|off is now known as jpena | 08:48 | |
*** jpich has joined #openstack-sdks | 09:03 | |
*** tkajinam has quit IRC | 09:30 | |
openstackgerrit | Slawek Kaplonski proposed openstack/openstacksdk master: Add description field to portforwarding NAT rules https://review.opendev.org/705038 | 09:55 |
---|---|---|
*** dtantsur|afk is now known as dtantsur | 10:09 | |
*** openstackstatus has joined #openstack-sdks | 11:51 | |
*** ChanServ sets mode: +v openstackstatus | 11:51 | |
openstackgerrit | Hervé Beraud proposed openstack/python-openstackclient stable/train: Add parent project filter for listing projects https://review.opendev.org/711208 | 11:56 |
*** jpena is now known as jpena|lunch | 12:32 | |
*** amito has quit IRC | 12:54 | |
*** TheJulia has quit IRC | 12:54 | |
*** TheJulia has joined #openstack-sdks | 12:54 | |
*** vdrok has quit IRC | 12:54 | |
*** Shrews has quit IRC | 12:54 | |
*** amito has joined #openstack-sdks | 12:54 | |
*** masayukig has quit IRC | 12:55 | |
*** vdrok has joined #openstack-sdks | 12:55 | |
*** Shrews has joined #openstack-sdks | 12:55 | |
*** masayukig has joined #openstack-sdks | 12:56 | |
*** vdrok has quit IRC | 13:23 | |
*** efried1 has joined #openstack-sdks | 13:24 | |
*** vdrok has joined #openstack-sdks | 13:25 | |
*** efried has quit IRC | 13:25 | |
*** efried1 is now known as efried | 13:25 | |
*** enriquetaso has joined #openstack-sdks | 13:30 | |
*** jpena|lunch is now known as jpena | 13:33 | |
openstackgerrit | Javier Peña proposed openstack/openstacksdk master: [TEST DO NOT MERGE] Replace assertItemsEqual with assertCountEqual https://review.opendev.org/711235 | 13:50 |
openstackgerrit | Lajos Katona proposed openstack/openstacksdk master: Add port property: ip_allocation https://review.opendev.org/711237 | 14:09 |
openstackgerrit | Bharat Kunwar proposed openstack/openstacksdk master: Return uuid alias for coe_cluster in non strict mode https://review.opendev.org/710823 | 14:15 |
brtknr | Shrews: ^^ | 14:15 |
brtknr | also mordred ^ | 14:15 |
mordred | brtknr: beautiful - thanks | 14:23 |
*** ricolin has quit IRC | 14:25 | |
mordred | slaweq: https://review.opendev.org/#/c/711237/ look ok to you? also - I rechecked that description patch - it seems to just keep being unlucky | 14:26 |
openstackgerrit | Bharat Kunwar proposed openstack/openstacksdk master: Return uuid alias for coe_cluster in non strict mode https://review.opendev.org/710823 | 14:29 |
brtknr | mordred: sorry, i had to fix the brackets out of OCD | 14:29 |
mordred | brtknr: I agree with your fix :) | 14:33 |
brtknr | mordred: :D | 14:33 |
Shrews | brtknr: thank you for the tests! | 14:38 |
brtknr | Shrews: my pleasure | 14:38 |
*** dtantsur is now known as dtantsur|brb | 14:46 | |
slaweq | mordred: looking | 14:55 |
slaweq | mordred: +2 this patch and thx for rechecking the other one :) | 15:00 |
openstackgerrit | Javier Peña proposed openstack/openstacksdk master: Replace assertItemsEqual with assertCountEqual https://review.opendev.org/711235 | 15:14 |
openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Build utility image for using osc https://review.opendev.org/711246 | 15:16 |
*** dtantsur|brb is now known as dtantsur | 16:00 | |
*** jpich has quit IRC | 16:14 | |
*** jpich has joined #openstack-sdks | 16:14 | |
openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Build utility image for using osc https://review.opendev.org/711246 | 16:15 |
openstackgerrit | Bharat Kunwar proposed openstack/openstacksdk master: Return uuid alias for coe_cluster in non strict mode https://review.opendev.org/710823 | 16:20 |
*** iurygregory has quit IRC | 16:20 | |
openstackgerrit | Bharat Kunwar proposed openstack/openstacksdk master: Return uuid alias for coe_cluster in non strict mode https://review.opendev.org/710823 | 16:20 |
brtknr | mordred: Shrews: Sorry i should have run tox -e pep8 before submitting | 16:21 |
mordred | brtknr: hahahaha | 16:21 |
*** gtema has joined #openstack-sdks | 16:26 | |
*** ricolin has joined #openstack-sdks | 16:37 | |
*** gtema has quit IRC | 17:02 | |
openstackgerrit | Clark Boylan proposed openstack/python-openstackclient master: Replace pkg_resources with importlib-metadata https://review.opendev.org/661856 | 17:03 |
smcginnis | Thanks mordred. Sad to see how many names are in the "no longer around" list. | 17:03 |
mordred | smcginnis: right? | 17:03 |
smcginnis | Just imagine if there were still that many cores working on things here. That OSC thread definitely wouldn't have been an issue. | 17:04 |
dtantsur | le sigh | 17:04 |
mordred | smcginnis: _seriously_ | 17:04 |
dtantsur | ... and I'm not even officially assigned to work on SDK ... | 17:08 |
smcginnis | Heh, I'm not even officially assigned to work on OpenStack. I just have a hard time moving on. :D | 17:09 |
dtantsur | oh wow | 17:10 |
openstackgerrit | Riccardo Pittau proposed openstack/openstacksdk master: Add retired and retired_reason fields to baremetal node https://review.opendev.org/711032 | 17:10 |
openstackgerrit | Riccardo Pittau proposed openstack/openstacksdk master: Add retired and retired_reason fields to baremetal node https://review.opendev.org/711032 | 17:11 |
*** openstackgerrit has quit IRC | 17:20 | |
mordred | dtantsur: I've *never* been officially assigned to work on SDK ;) | 17:20 |
dtantsur | LOOOL | 17:21 |
*** jpich has quit IRC | 17:21 | |
*** evrardjp has quit IRC | 17:35 | |
*** evrardjp has joined #openstack-sdks | 17:35 | |
umbSublime | Is it possible to specify microversion to use on openstack.proxy.Proxy calls. Or at least force one to be used by the proxy. I know I've asked this in the past, but it wasn't possible then. Maybe it is now ? | 17:37 |
*** dtantsur is now known as dtantsur|afk | 17:41 | |
umbSublime | I still get None on for example conn.compute.min_version and conn.compute.max_version yet information is there when inspecting: conn.compute.get_all_version_data() | 17:41 |
umbSublime | openstack.version.__version__ == 0.41.0, keystoneauth1.__version__ == 3.18.0 | 17:43 |
mordred | umbSublime: the intent is that as a user of the library you should never have to specify a microversion - let me look at the min_version / max_version thing ... what are you trying to do that isn't working? (other than specifying a microversion) | 17:44 |
mordred | (I believe we did add the ability for you to force one - but I'm more curious why you need to) | 17:44 |
*** jpena is now known as jpena|off | 17:46 | |
umbSublime | Well say I cann conn.compute.hypervisors(), then the 'id' is an int while when using microversion 2.53 I get UUIDs. Same can be observed with openstackclient: `openstack hypervisor list` vs `openstack --os-compute-api-version 2.53 hypervisor list` | 17:47 |
umbSublime | I can force it with conn.compute.get('/os-hypervisors', microversion="2.53"). But it would be awesome if i could do conn.compute.hypervisors(microversion="2.53") | 17:49 |
mordred | should we not maybe just default to 2.53 if it's available in this case? | 17:49 |
umbSublime | yes or whatever the max_microversion is for the endpoint | 17:50 |
mordred | well - we have to pick max_microversion we can support- this doesn't sound like one we'd need to update anything else in the sdk to support, so it's pretty easy (sometimes thigs change key names or the liek and we need to add compat code to be able to safely provide them) | 17:51 |
*** openstackgerrit has joined #openstack-sdks | 17:52 | |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Set max_microversion to 2.53 for hypervisors https://review.opendev.org/711294 | 17:52 |
umbSublime | so then each api call requiring a specific microversion should be hard-coded on sdk side ? | 17:52 |
mordred | umbSublime: ^^ that should do the trick for you | 17:52 |
mordred | umbSublime: yes - otherwise microversion changes don't protect the user from very much and we might as well not have them | 17:52 |
mordred | but if we use them well, they're pretty awesome | 17:52 |
mordred | we don't hard-core the api calls themselves, we have a system where we can express what microversion a given resource knows how to handle the requests and responses for | 17:53 |
umbSublime | Ahh I see. | 17:53 |
umbSublime | Regardless of that though in the event that new microversion is not yet supported by SDK, wouldn't it be also pretty neat to be able to specifiy it as kwarg on the method too ? | 17:54 |
umbSublime | Because there are cases where a feature is supported between microverion X and Y and then removed or again modified in microversion Z | 17:55 |
mordred | not necessarily, because the SDK has to map the responses into the Resource objects. that said - I'm _pretty_ sure if you set compute_api_version to 2.53 in our clouds.yaml then we'll set default_microversion of it | 17:55 |
mordred | umbSublime: oh that's joyous :) | 17:56 |
umbSublime | mordred, I'll give that a shot | 17:56 |
mordred | dtantsur|afk: darn, you're not here- we added support for configuring a defaut_microversion override didn't we? | 17:56 |
mordred | yes | 17:57 |
mordred | umbSublime: so you can either be _explicit_ and do compute_default_microversion=2.53 | 17:57 |
mordred | or you can do compute_api_version=2.53 and we'll infer that you mean default_microversion | 17:57 |
mordred | however - just know that your mileage may vary if you do that - we may not necessarily know how to deal with all of the responses on all of the calls and it could blow up in fascinating ways :) | 17:58 |
mordred | (always looking for improvements though - so if you do find a place where you do that and it blows up, let us know and we can figure out how to support that mv) | 17:58 |
umbSublime | indeed forcing compute_api_version in clouds.yaml does the job. | 17:59 |
umbSublime | I wasn't aware of that trick. Very useful!! | 17:59 |
*** sshnaidm is now known as sshnaidm|afk | 17:59 | |
mordred | woot! | 18:00 |
* mordred has been helpful today - will now go back to hiding | 18:00 | |
umbSublime | ^^ | 18:00 |
umbSublime | Am I correct in assuming that if I set compute_default_microversion=2.53, then the microversion header will be sent to ALL compute requests ? | 18:01 |
mordred | yes | 18:01 |
umbSublime | \o/ | 18:01 |
mordred | well - all compute requests where sdk isn't already setting something more explicitly | 18:02 |
umbSublime | right, like for example the patch on hypervisors you just did ? | 18:02 |
mordred | there are places with more explicit mv negotiation - live_migrate comes to mind | 18:02 |
mordred | and yeah | 18:02 |
mordred | so like I said - the GOAL is that you never have to do that - but we're obviously not 100% there on that goal | 18:03 |
umbSublime | Asside from debug log and reading the code, is there a programatic way to know what API version will be used by conn.compute.<method> ? | 18:03 |
mordred | that's an excellent question | 18:04 |
umbSublime | Well for me this clouds.yaml trick fixes a lot of headaches !! | 18:04 |
mordred | I'm gonna say - "no" ... but I think that's an excellent thing to want to know | 18:04 |
mordred | so I'll think about how we might accomplish that | 18:04 |
umbSublime | mordred, thanks a lot ! | 18:06 |
openstackgerrit | Merged openstack/openstacksdk master: Replace assertItemsEqual with assertCountEqual https://review.opendev.org/711235 | 18:07 |
mordred | slaweq: if you have a sec, https://review.opendev.org/#/c/710030/ is neutron related | 18:19 |
mordred | slaweq: as is https://review.opendev.org/#/c/710820/ | 18:20 |
*** tosky has quit IRC | 18:44 | |
mordred | dtantsur|afk: whence you are back - I'm looking at switching to futurist ... we use concurrent.futures.as_completed currently - futurist seems to have wait_for_all and wait_for_any ... do you have a suggestion of the best way to accomplish a similar pattern to as_completed? | 18:47 |
mordred | dtantsur|afk: hrm. actually - looking at the code wait_for_all should still work | 18:48 |
mordred | dtantsur|afk: ACTUALLY - nothing shoudl stop us from using concurrent.futures.as_completed since futurist is using that as a base | 18:50 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Switch to futurist for concurrency https://review.opendev.org/711301 | 18:56 |
*** dmellado has quit IRC | 19:24 | |
*** dmellado has joined #openstack-sdks | 19:25 | |
*** mgoddard has quit IRC | 19:27 | |
*** mgoddard has joined #openstack-sdks | 19:28 | |
umbSublime | I just watched a talk from OS summit about the SDK. The speaker says a proxy object is created for every service_types_authority even if the target cloud doens't have the service in it's endpoints and even if no ressource objects are created (we should at least be able to get/put/post/delete). Has this been rolled back ? I have placement-api in my deployment but get and error with conn.placement. This is also something i've | 19:29 |
umbSublime | discussed here in the past (don't remembeer who). i had a work-around where I added a placement adapter to keystoneauth, but it was a bit dirty | 19:29 |
mordred | umbSublime: WELL - that was probably me, and you should always take anything I say with a grain of salt | 19:30 |
mordred | that said - I could expect conn.placement to exist and be a proxy - how ever, if you don't have placement in your service-catalog, it's not going to know how to configure that proxy to be able to talk to anything because it's not going to know where the placement endpoint is | 19:31 |
mordred | umbSublime: you can put placement_endpoint_override in your clouds.yaml with the placement endpoint and that should tell it where your placement service is | 19:32 |
umbSublime | I do see it with `openstack endpoint list` | 19:32 |
mordred | ok. so it is in your catalog | 19:32 |
umbSublime | yup | 19:32 |
mordred | in that case I fully expect conn.placement to give you a working proxy | 19:32 |
* mordred is trying to think the best way to debug why you don't | 19:33 | |
umbSublime | Any debug or things you want me to check (I assume there might be a bug) | 19:33 |
umbSublime | Great talk BTW :D | 19:33 |
openstackgerrit | James Denton proposed openstack/openstacksdk stable/stein: Add "name" filter in "list" call when retrieving a single register https://review.opendev.org/711314 | 19:33 |
umbSublime | mordred, here is the stack-trace what the stacktrace looks like: https://hastebin.com/vizuhufiqi.rb | 19:37 |
mordred | umbSublime: can you run http://paste.openstack.org/show/790311/ (obviosly change the connect call if you need to) and paste the output? | 19:37 |
mordred | oh - hrm | 19:37 |
mordred | what version of keystoneauth - and do you know what version of placement? | 19:37 |
umbSublime | keystoneauth1.__version__ == '3.18.0 | 19:38 |
*** ralonsoh has quit IRC | 19:38 | |
umbSublime | :facepalm: I didn't install osc-placement in that venv. potential pebcak | 19:38 |
mordred | possibly - however ... are you setting a placement_api_version there? | 19:39 |
umbSublime | Ok so I get same stack-trace with osc-placement installed. And I have nothing related to placement in my clouds.yaml | 19:40 |
mordred | yeah - I think this is placement not returning a proper version discovery doc for some reason - which is a thing I thought we'd put in a workaround for before | 19:41 |
mordred | could you run that little script above? that should catch the full http trace | 19:41 |
* mordred grumbles | 19:41 | |
umbSublime | being an private cloud do you mind If I just remove endpoint dict from the output i share with you ? (that's probably what you want to check :/ ) | 19:42 |
mordred | nah - actually I thnk that's fine - I mostly want to see the payload returned from the root of your placement service | 19:43 |
umbSublime | After the token request i see a call on the endpoint with the port my placement-api is running on. This is the response: {"versions": [{"min_version": "1.0", "max_version": "1.17", "id": "v1.0"}]} | 19:43 |
mordred | sigh | 19:44 |
mordred | ok. so - that's a broken discovery dict - which I *think* we got fixed in upstream placement (I'll go check that next - it doesn't match my test fixture for placement) | 19:44 |
umbSublime | Is this correct response format? | 19:44 |
mordred | for now - set placement_endpoint_override | 19:44 |
mordred | yeah | 19:44 |
mordred | it's jst missing a status: field | 19:44 |
umbSublime | Ahh so then i'd need to update my placement-api service | 19:45 |
mordred | yeah - although I *also* want to see if I can't work around that in sdk too | 19:45 |
mordred | because that's a bad experience for people | 19:45 |
mordred | I thought we already had - but I see clearly we didn't | 19:45 |
mordred | but for now - if you set placement_endpoint_override to the base endpoint of the placement service it should work for you | 19:45 |
umbSublime | would be awesome. For newer clouds, I can update the version, but this legacy cloud will probably have to live with it's current placement version | 19:45 |
mordred | yah | 19:45 |
umbSublime | testing now | 19:46 |
mordred | and we aim to support older clouds too - so it's fair for us to deal with that | 19:46 |
*** iurygregory has joined #openstack-sdks | 19:46 | |
umbSublime | I put the endpoint I get for `endpoint list` as a value right ? | 19:46 |
mordred | yeah | 19:46 |
umbSublime | \o/ print(conn.placement) -> <openstack.proxy.Proxy object at 0x7ffbdaf5a5c0> | 19:47 |
mordred | WOOT | 19:47 |
mordred | cool. I can work up a test case that has a broken old placement discovery dict and then figure out how to fix it :) | 19:48 |
mordred | thanks for helping track that down | 19:48 |
umbSublime | Man I'm going to get rid of so much hacky code today ^^ | 19:48 |
mordred | \o/ | 19:48 |
mordred | my main goal in life is facilitating the deletion of code | 19:48 |
umbSublime | thanks a bunch !!! | 19:48 |
umbSublime | hahaha it's working XD | 19:48 |
openstackgerrit | Merged openstack/openstacksdk master: Return uuid alias for coe_cluster in non strict mode https://review.opendev.org/710823 | 20:05 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Handle old status-less placement service https://review.opendev.org/711328 | 20:23 |
mordred | umbSublime: ^^ that produces the same error - so there's that at leat | 20:25 |
mordred | least | 20:25 |
umbSublime | :) | 20:28 |
umbSublime | Do you want me to file a bug for this. I'm not sure if the fix has to be implemented in keystoneauth1 or the SDK directly | 20:29 |
mordred | umbSublime: nah - I'm working on it | 20:32 |
mordred | umbSublime: although I feel lke I'm going to need a shower when I'm done :) | 20:33 |
umbSublime | <3 | 20:33 |
*** iurygregory has quit IRC | 20:43 | |
umbSublime | Say I wanted (one day) to try and tackle some low hanging fruit bugs on the SDK where are issues tracked. I don't see much stuff related to sdk in launchpad | 21:04 |
mordred | we're in storyboard ... https://storyboard.openstack.org/#!/project/openstack/openstacksdk | 21:06 |
mordred | I'm pretty bad about using it myself though (hides) | 21:06 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Handle old status-less placement service https://review.opendev.org/711328 | 21:09 |
mordred | umbSublime: and there's the workaround :) | 21:10 |
mordred | Shrews: I feel like it's been too long since you've had to review patches from me touching version discovery in the guts of SDK ^^ | 21:10 |
mordred | efried: ^^ same story | 21:10 |
efried | mordred: can you link to the commit that corrected the missing status field in placement? | 21:13 |
mordred | efried: uh ... I was sort of hoping you just magically new ... let me go look | 21:19 |
efried | mordred: I could have gone and looked myself. <lazy> | 21:19 |
efried | I probably wrote that patch. Or at least reviewed it. | 21:19 |
efried | But I'm way behind memorizing the gerrit numbers and commit hashes of all the patches I've been involved in. | 21:20 |
mordred | efried: https://review.opendev.org/#/c/575117/ | 21:21 |
mordred | efried: you want me to put a referene to that in the commit message? | 21:21 |
efried | mordred: yes please, but also one other comment... | 21:21 |
efried | mordred: ...posted | 21:22 |
efried | JSON doesn't allow comments??? | 21:24 |
efried | I'll be back to +2 that in ~.5h | 21:24 |
Shrews | mordred: oh, i can't wait. really. no, seriously. | 21:24 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Handle old status-less placement service https://review.opendev.org/711328 | 21:24 |
mordred | efried: nope. that's one of teh nice things about yaml | 21:25 |
umbSublime | Thanks mordred ! | 21:25 |
mordred | Shrews: well - no need to wait - there you are, all nice and ready for you | 21:25 |
efried | mordred: +2 | 21:25 |
mordred | \o/ | 21:25 |
mordred | umbSublime: thak you - that was very helpful debugging info - and I imagine you won't be the only one to hit that | 21:26 |
umbSublime | That was the easy part ;) | 21:31 |
openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Add bindep file https://review.opendev.org/711055 | 21:36 |
openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Build utility image for using osc https://review.opendev.org/711246 | 21:36 |
*** KeithMnemonic has joined #openstack-sdks | 21:37 | |
*** enriquetaso has quit IRC | 21:59 | |
openstackgerrit | Sam Morrison proposed openstack/python-openstackclient master: Always display direction for security group rules https://review.opendev.org/709017 | 22:04 |
openstackgerrit | Sam Morrison proposed openstack/python-openstackclient master: Always display direction for security group rules https://review.opendev.org/709017 | 22:05 |
*** tosky has joined #openstack-sdks | 22:11 | |
*** slaweq has quit IRC | 22:21 | |
openstackgerrit | Merged openstack/ansible-collections-openstack master: Fix H236 and remove exclusion https://review.opendev.org/698066 | 22:22 |
openstackgerrit | Merged openstack/ansible-collections-openstack master: Remove from __future__ lines https://review.opendev.org/698067 | 22:27 |
openstackgerrit | Merged openstack/ansible-collections-openstack master: Test with and assert support for python3 https://review.opendev.org/710641 | 22:27 |
openstackgerrit | Merged openstack/openstacksdk master: Fix: Set image name correctly if filename is not passed https://review.opendev.org/710368 | 22:57 |
*** tkajinam has joined #openstack-sdks | 22:59 | |
*** slaweq has joined #openstack-sdks | 23:11 | |
*** slaweq has quit IRC | 23:16 | |
openstackgerrit | Merged openstack/openstacksdk stable/train: Handle HTTP errors in add/remove router interface calls https://review.opendev.org/710994 | 23:19 |
openstackgerrit | Merged openstack/openstacksdk stable/train: Fix error handling on add/remove router iface calls https://review.opendev.org/710995 | 23:19 |
*** tosky has quit IRC | 23:40 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!