| *** gtema has joined #openstack-sdks | 00:29 | |
| *** gtema has quit IRC | 00:34 | |
| *** tosky has quit IRC | 00:52 | |
| *** diablo_rojo has quit IRC | 02:01 | |
| *** gtema has joined #openstack-sdks | 02:30 | |
| *** gtema has quit IRC | 02:34 | |
| *** gkadam has joined #openstack-sdks | 03:03 | |
| *** diablo_rojo has joined #openstack-sdks | 03:10 | |
| *** gtema has joined #openstack-sdks | 04:31 | |
| *** gtema has quit IRC | 04:36 | |
| *** evrardjp has quit IRC | 05:36 | |
| *** evrardjp has joined #openstack-sdks | 05:36 | |
| *** diablo_rojo has quit IRC | 05:39 | |
| *** gtema has joined #openstack-sdks | 06:32 | |
| *** gtema has quit IRC | 06:37 | |
| *** nightmare_unreal has joined #openstack-sdks | 06:51 | |
| *** ralonsoh has joined #openstack-sdks | 07:09 | |
| openstackgerrit | Merged openstack/openstacksdk master: [tests] Improve devstack/post playbook efficiency https://review.opendev.org/715052 | 07:17 |
|---|---|---|
| *** gtema has joined #openstack-sdks | 07:28 | |
| *** factor has quit IRC | 07:29 | |
| *** gtema has quit IRC | 07:42 | |
| *** gtema has joined #openstack-sdks | 07:45 | |
| *** evrardjp has quit IRC | 07:57 | |
| *** evrardjp has joined #openstack-sdks | 08:01 | |
| *** slaweq has joined #openstack-sdks | 08:01 | |
| *** amoralej|off is now known as amoralej | 08:02 | |
| *** dtroyer has quit IRC | 08:06 | |
| *** guilhermesp has quit IRC | 08:06 | |
| *** dmellado has quit IRC | 08:06 | |
| *** dtroyer has joined #openstack-sdks | 08:06 | |
| *** dmellado has joined #openstack-sdks | 08:10 | |
| *** gtema_ has joined #openstack-sdks | 08:17 | |
| *** tkajinam has quit IRC | 08:19 | |
| *** gtema has quit IRC | 08:20 | |
| *** rpittau|afk is now known as rpittau | 08:26 | |
| *** jpich has joined #openstack-sdks | 08:53 | |
| *** jpena|off is now known as jpena | 08:53 | |
| *** tosky has joined #openstack-sdks | 09:00 | |
| openstackgerrit | Sagi Shnaidman proposed openstack/openstacksdk stable/train: Add ansible collection job to train branch https://review.opendev.org/714077 | 09:24 |
| *** sshnaidm is now known as sshnaidm|afk | 09:56 | |
| openstackgerrit | Bence Romsics proposed openstack/python-openstackclient master: Add command: router add/remove route --route https://review.opendev.org/674325 | 10:05 |
| *** jpich has quit IRC | 10:10 | |
| *** jpich has joined #openstack-sdks | 10:11 | |
| openstackgerrit | Sean McGinnis proposed openstack/openstacksdk master: Add cap for hacking https://review.opendev.org/715155 | 10:40 |
| *** dtantsur|afk is now known as dtantsur | 10:48 | |
| *** gtema_ has quit IRC | 11:16 | |
| *** gtema has joined #openstack-sdks | 11:25 | |
| *** sshnaidm|afk is now known as sshnaidm | 11:25 | |
| *** rpittau is now known as rpittau|bbl | 11:45 | |
| *** jpena is now known as jpena|lunch | 11:58 | |
| *** gtema_ has joined #openstack-sdks | 12:04 | |
| *** gtema has quit IRC | 12:08 | |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Change default image type in the OTC vendor profile https://review.opendev.org/715183 | 12:16 |
| mordred | smcginnis: your hacking patch hit a set of errors that were apparently getting missed before - you wanna fix them or I can? | 12:27 |
| smcginnis | mordred: I can. Confused on why adding a cap introduced failures though. | 12:28 |
| smcginnis | mordred: Looks like something else going on there - fixtures._fixtures.timeout.TimeoutException | 12:29 |
| smcginnis | But I can fix up the pep8 issues at least. | 12:29 |
| mordred | smcginnis: yeah - that seems super unlikely to be caused by flake8 ... but oy | 12:29 |
| smcginnis | "F821 undefined name 'Optional'" Wasn't that just added? | 12:30 |
| smcginnis | Hmm, and doesn't fail locally for me. | 12:31 |
| tremble | smcginnis, I kept hitting those timeout exceptions too, I think there's a flakey test somewhere. | 12:32 |
| mordred | smcginnis: I LOVE when flake8 is weird like that | 12:32 |
| smcginnis | At least a few of the things are legitimate. Might need to add some ignores in there for others. | 12:32 |
| mordred | smcginnis: maybe it has something to do with the python version? | 12:32 |
| smcginnis | And hopefully another pass through the check queue will get around those UT failures. | 12:33 |
| mordred | the Optional error would be solved by importing Optional from typing | 12:33 |
| smcginnis | Ohhhh, interesting... | 12:33 |
| smcginnis | Current master that states hacking>=2.0.0 results in "hacking==1.1.0" getting installed. | 12:33 |
| smcginnis | And with the patch just adding a cap, 2.0.0 gets installed. | 12:34 |
| mordred | aroo? | 12:34 |
| mordred | can we agree that doesn't make sense? | 12:34 |
| smcginnis | Glad I just pulled a shot. | 12:34 |
| smcginnis | Completely. | 12:34 |
| mordred | tremble: new release of sdk is winding its way through the machinery | 12:35 |
| smcginnis | OK, I need more coffee. | 12:36 |
| smcginnis | I am NOT just adding a cap. | 12:36 |
| sshnaidm | odyssey4me, hi, are you going to backport https://review.opendev.org/#/c/715052/ to stable branches? | 12:36 |
| smcginnis | I actually am bumping hacking to 2.0, which now makes total sense why it would trigger new errors. | 12:36 |
| odyssey4me | sshnaidm: yep, happy to once the preceding patches merge | 12:36 |
| openstackgerrit | Bence Romsics proposed openstack/python-openstackclient master: Add command: router add/remove route --route https://review.opendev.org/674325 | 12:36 |
| smcginnis | And obviously needed more coffee when I did that in the first place, because I should have expected new things to pop up. | 12:36 |
| sshnaidm | odyssey4me, preceding patches..? | 12:38 |
| mordred | smcginnis: haha. well, that at least makes more sense? | 12:38 |
| odyssey4me | sshnaidm: https://review.opendev.org/#/q/I50b1020c896d7d8a7d58e62de778bb8c2b6e970e - I'll pick the patch on top of those | 12:38 |
| openstackgerrit | Jesse Pretorius (odyssey4me) proposed openstack/openstacksdk stable/train: [tests] Improve devstack/post playbook efficiency https://review.opendev.org/715192 | 12:39 |
| sshnaidm | odyssey4me, I can just abandon mines, you have a full solution in yours | 12:39 |
| openstackgerrit | Sagi Shnaidman proposed openstack/openstacksdk stable/train: Run fetch-subunit-output role conditionally https://review.opendev.org/714770 | 12:40 |
| openstackgerrit | Igor Malinovskiy proposed openstack/python-openstackclient master: Add 'address_scope' type support to network rbac commands https://review.opendev.org/709124 | 12:40 |
| openstackgerrit | Jesse Pretorius (odyssey4me) proposed openstack/openstacksdk stable/stein: [tests] Improve devstack/post playbook efficiency https://review.opendev.org/715193 | 12:40 |
| sshnaidm | odyssey4me, train and stein should be fine, rocky is waiting for pep8 fix | 12:40 |
| openstackgerrit | Jesse Pretorius (odyssey4me) proposed openstack/openstacksdk stable/train: [tests] Improve devstack/post playbook efficiency https://review.opendev.org/715192 | 12:41 |
| openstackgerrit | Igor Malinovskiy proposed openstack/python-openstackclient master: Add 'subnetpool' type support to rbac commands https://review.opendev.org/712705 | 12:41 |
| tremble | mordred, zo/ | 12:41 |
| odyssey4me | sshnaidm: either way works - I've picked them already | 12:41 |
| tremble | mordred, \o/ | 12:41 |
| tremble | mordred, Anything I can watch to see it go through? | 12:42 |
| mordred | tremble: https://review.opendev.org/#/c/715090/ | 12:42 |
| mordred | although it looks like it just went through | 12:43 |
| mordred | tremble: there's release jobs in https://zuul.opendev.org/t/openstack/status for the openstack/releases project that will actually publish to pypi | 12:44 |
| *** gtema_ has quit IRC | 12:45 | |
| tremble | Will the test jobs pick it up already? | 12:45 |
| openstackgerrit | Sean McGinnis proposed openstack/openstacksdk master: Raise hacking to 2.x https://review.opendev.org/715155 | 12:47 |
| smcginnis | tremble: If you filter on "release", there is a job that just started in teh release-post queue. | 12:48 |
| smcginnis | That will tag the repo, among other things. | 12:48 |
| smcginnis | Once that tagging happens, that triggers yet another job to run that will package it up and publish to pypi. | 12:48 |
| smcginnis | So probably 15-20 minutes or so until it's published and available. | 12:48 |
| tremble | Jobs triggering jobs triggering jobs. That looks like the kind of crazy I'd set up. | 12:49 |
| smcginnis | ;) | 12:51 |
| sshnaidm | mordred, can we merge? https://review.opendev.org/#/c/714771/ odyssey4me set his backport on top of that | 12:58 |
| mordred | sshnaidm: done | 13:00 |
| sshnaidm | mordred, thanks, odyssey4me ^^ | 13:00 |
| odyssey4me | np :) | 13:00 |
| *** jpena|lunch is now known as jpena | 13:01 | |
| *** amoralej is now known as amoralej|lunch | 13:01 | |
| openstackgerrit | Pedro Henrique Pereira Martins proposed openstack/python-openstackclient master: Add description field to portforwarding NAT rules https://review.opendev.org/714512 | 13:05 |
| *** rpittau|bbl is now known as rpittau | 13:10 | |
| *** enriquetaso has joined #openstack-sdks | 13:10 | |
| *** gkadam has quit IRC | 13:10 | |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_mapping https://review.opendev.org/713643 | 13:15 |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New module: os_keystone_mapping_info https://review.opendev.org/713686 | 13:15 |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_identity_provider https://review.opendev.org/714632 | 13:15 |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_identity_provider_info https://review.opendev.org/714633 | 13:15 |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_federation_protocol https://review.opendev.org/714991 | 13:15 |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_federation_protocol_info https://review.opendev.org/714992 | 13:15 |
| *** gtema has joined #openstack-sdks | 13:22 | |
| *** tkajinam has joined #openstack-sdks | 13:22 | |
| *** gtema has quit IRC | 13:26 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add link to image sharing api docs https://review.opendev.org/677266 | 13:28 |
| *** gtema has joined #openstack-sdks | 13:31 | |
| openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Add libc6-dev to bindep https://review.opendev.org/715210 | 13:47 |
| openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Be explicit about python version in image https://review.opendev.org/715211 | 13:50 |
| mordred | amoralej|lunch: ^^ the libc6-dev patch should fix the https://review.opendev.org/#/c/697444/ patch | 13:50 |
| mordred | gah | 13:51 |
| mordred | amotoki: ^^ | 13:51 |
| mordred | amoralej|lunch: sorry - bad tab-complete | 13:51 |
| openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Adding options to user cli https://review.opendev.org/697444 | 13:51 |
| *** amoralej|lunch is now known as amoralej | 14:02 | |
| gtema | nodepool builds seem to be failing everywhere in SDK | 14:28 |
| gtema | I mean nodepool jobs | 14:29 |
| *** sshnaidm has quit IRC | 14:30 | |
| *** dulek has quit IRC | 14:30 | |
| *** corvus has quit IRC | 14:30 | |
| mordred | there's an issue in setuptools | 14:30 |
| mordred | that has been fixed | 14:30 |
| gtema | ah, ok | 14:30 |
| mordred | but it's gonna be a minute before it winds its way through the layers of things to dib | 14:30 |
| gtema | oki, keep waiting ;) | 14:30 |
| mordred | (the bug caused non-entrypoint scripts to lose their executable bit when they were installed) | 14:30 |
| gtema | cool | 14:31 |
| mordred | yeah. so awesome | 14:31 |
| *** sshnaidm has joined #openstack-sdks | 14:31 | |
| *** corvus has joined #openstack-sdks | 14:31 | |
| smcginnis | Hah, oops. | 14:31 |
| gtema | but from our logs you don't see this really - just that it failed | 14:31 |
| *** dulek has joined #openstack-sdks | 14:33 | |
| *** gtema_ has joined #openstack-sdks | 14:47 | |
| *** gtema has quit IRC | 14:51 | |
| mordred | gtema_: have a sec for 2 easy patches: https://review.opendev.org/#/c/715210/ https://review.opendev.org/#/c/715211/ ? | 14:55 |
| *** gtema_ is now known as gtema | 14:57 | |
| gtema | yupp, looking now | 14:58 |
| mordred | gtema: thanks! | 14:59 |
| gtema | should I +A for the py3.7? | 14:59 |
| mordred | gtema: sure. it's a pretty mechanical change | 15:00 |
| gtema | done | 15:00 |
| mordred | I think "let's upgrade to 3.8" would be one where we shoudl actually discuss :) | 15:00 |
| gtema | agree | 15:00 |
| gtema | btw this libc - today figured out, that in my zuul F30 image does not include by default bzip2 - pretty weird | 15:01 |
| mordred | gtema: yeah - I think we just had a patch for that in zuul | 15:01 |
| *** vphilippon2 has joined #openstack-sdks | 15:01 | |
| mordred | oh even weirder ... | 15:02 |
| gtema | can you please point me to it? I just did a dirty hack to keep it running | 15:02 |
| mordred | https://review.opendev.org/#/c/715041/ | 15:02 |
| mordred | but the issue was that it was only installing for rpm | 15:02 |
| mordred | but I'd expect it to be installed on F30 | 15:02 |
| mordred | oh - wait ... | 15:02 |
| gtema | yeah, should have been there | 15:03 |
| *** vphilippon has joined #openstack-sdks | 15:03 | |
| mordred | your zuul F30 image - you mean an F30 image you're using with zuul - not that you're running zuul in | 15:03 |
| gtema | right - F30 image with jobs | 15:03 |
| *** vphilippon2 has quit IRC | 15:03 | |
| mordred | yeah - so - in opendev we try to install as little as possible in the images so that projects can express their depends in their bindep files | 15:04 |
| mordred | so if you have a job fail due to lack of bzip2, you might need to add it to the bindep of the project in question? | 15:04 |
| gtema | I remember it was working always fine, but today finally reenabled building docs and that is where I noticed it | 15:04 |
| gtema | exact | 15:04 |
| mordred | yeah - tox-docs is the thing that people were discussing yesterday | 15:05 |
| gtema | https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/fetch-sphinx-tarball/tasks/html.yaml | 15:05 |
| mordred | there's a giant scrollback in the #zuul channel log about it | 15:05 |
| mordred | I didn't follow the whole thing | 15:05 |
| gtema | oh god, no interest for scroll | 15:05 |
| mordred | gtema: https://review.opendev.org/#/c/715028 is what mnaser put together - I believe the idea is that gzip is more common | 15:06 |
| gtema | yeah, this seem reasonable. I use zuul-jobs, so whenever it lands I get it as well | 15:07 |
| mordred | however - if you had the bzip issue with tox-docs - it's likely that your zuul executor did not have bzip - and if you're running a zuul from the container images - they were missing bzip2 because of that bindep line. it's all a bit confusing | 15:07 |
| vphilippon | Hello! I think I've stumbled on an issue with Python openstacksdk 0.44.0 dependencies. In short, it depends on futurist>=2.1.0, which is Py3-only, effectively making openstacksdk also Py3-only. | 15:08 |
| gtema | exact - running zuul itself in containers | 15:08 |
| mnaser | seems like everyone is hitting that heh | 15:08 |
| gtema | underneath podman as non-root - so even more cool bels and whistles | 15:08 |
| *** KeithMnemonic has quit IRC | 15:13 | |
| vphilippon | I barged in with that message, sorry. Is there a channel better suited for Python openstacksdk specific issues? | 15:14 |
| mordred | vphilippon: yes - starting with this openstack release openstacksdk is python3 only | 15:15 |
| mordred | vphilippon: let me find the version you should pin to if you're using py2 | 15:15 |
| vphilippon | @mordred: Thanks. Although, the missing Requires-Python metadata will make a poor user experience with pip then :( | 15:16 |
| mordred | vphilippon: agree - I'll get that fixed | 15:16 |
| vphilippon | The only solution I know for this would be to pull v0.44.0 from pypi and republish it with the metadata | 15:17 |
| mordred | vphilippon: 0.40.0 is the first release in which python2 is no longer tested/supported | 15:17 |
| mordred | we can't do that - republishing a release breaks the universe. we can publish a fixed 0.45 though | 15:17 |
| vphilippon | Because of 0.44.1 is released, pip will go back to 0.44.0, that is purely broken | 15:18 |
| vphilippon | Because if* | 15:18 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add requires-python entry indicating 3.6 is required https://review.opendev.org/715243 | 15:19 |
| mordred | vphilippon: yeah - I think we can remove 0.44 once 0.44.1 is there | 15:19 |
| vphilippon | Oh, that works too! | 15:20 |
| vphilippon | Even better, taking note of that option (this not the first time I get to report this to maintainers, sadly) | 15:20 |
| mordred | smcginnis, gtema: ^^ see discussion and patch - let's land that and cut an 0.44.1 real quick | 15:20 |
| mordred | actually - let me add a release note explanation real quick | 15:21 |
| gtema | sure, but we can't unless nodepool build are fixed ;) | 15:21 |
| gtema | perhaps also removing "Programming Language :: Python :: 2" | 15:21 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add requires-python entry indicating 3.6 is required https://review.opendev.org/715243 | 15:22 |
| vphilippon | Thanks for the quick response btw :) | 15:23 |
| smcginnis | mordred: Good on the new release. Not so sure about removing anything. That's generally bad. And not clear what the issue is here. | 15:23 |
| mordred | ++ | 15:23 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add requires-python entry indicating 3.6 is required https://review.opendev.org/715243 | 15:23 |
| gtema | yupp | 15:23 |
| mordred | smcginnis: so - the situation is that we neglected adding requires-python>=3.6 to the first release where that was actually physically true | 15:24 |
| mordred | which means python2 installs of openstack with no versions are finding it and trying to install it | 15:24 |
| smcginnis | I'd say only about 50% (or less) of our ussuri deliverables have done that. | 15:24 |
| mordred | yeah- but openstacksdk is a much wider audience of people who pip install it | 15:24 |
| mordred | since it's end-user and not operator | 15:24 |
| smcginnis | I guess openstacksdk is probably more prevalent outside of openstack, so we can't rely on upper-constraints. | 15:25 |
| mordred | yeah | 15:25 |
| smcginnis | Yeah | 15:25 |
| smcginnis | ;) | 15:25 |
| mordred | so - in this case, I think releasing a quick 0.44.1 bugfix and then removing 0.44.0 from pypi will unbreak people - as long as we wait for u-c to bump to 0.44.1 in openstack before doing so | 15:26 |
| mordred | obviously a discussion for release team | 15:26 |
| mordred | and first step is getting the fix landed so we can release 0.44.1 which is uncontroversial | 15:26 |
| mordred | gtema: I think maybe let's disable the nodepool test for the requires-python fix so we can get it landed, then re-enable | 15:26 |
| gtema | ok, agree | 15:27 |
| gtema | but then also have otc vendor profile fix in | 15:27 |
| mordred | ++ | 15:28 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add requires-python entry indicating 3.6 is required https://review.opendev.org/715243 | 15:28 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Re-add nodepool functional test https://review.opendev.org/715245 | 15:28 |
| gtema | cool | 15:28 |
| mordred | gtema: you wanna rebase otc patch on requires-python patch? | 15:28 |
| gtema | sure | 15:28 |
| *** enriquetaso has quit IRC | 15:29 | |
| vphilippon | An alternative to having to remove 0.44.0 would be to re-release 0.43.0 as 0.44.1, and release the "original" 0.44.0 with the metadata, as 0.45.0. | 15:29 |
| gtema | oh, this would be too complicated | 15:30 |
| mordred | smcginnis: I -2'd the UC bump for sdk: https://review.opendev.org/#/c/715199/ | 15:30 |
| mordred | actually ... | 15:30 |
| *** tkajinam has quit IRC | 15:30 | |
| vphilippon | I believe so, but I share the option :) | 15:30 |
| mordred | I think I like that idea, weirdly | 15:30 |
| gtema | 43 with content of 44? | 15:31 |
| mordred | actually | 15:31 |
| mordred | I think it should be "revert furturist patch. land. release. unrevert and add requires-python. land. release" | 15:31 |
| gtema | eeh, project cleanup now depends on futurist | 15:32 |
| mordred | yeah. lemme see if I can make a patch real quick - we can look at it in parallel and see which we like | 15:32 |
| vphilippon | I'd say if you are able to act quickly, the option of removing 0.44.0 remains sane-ish. If times has to pass (for whatever reason, build system, discussion, etc.), Then the revert-fix-release pattern by republishing older version as newer becomes better, IMHO | 15:34 |
| vphilippon | I'm not a maintainers here though, simply sharing my pip experience expertise here. | 15:35 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Revert "Switch to futurist for concurrency" https://review.opendev.org/715249 | 15:40 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Revert "Revert "Switch to futurist for concurrency"" https://review.opendev.org/715250 | 15:40 |
| mordred | gtema: ^^ I think we can get both of those landed and released today | 15:40 |
| dtantsur | and the cleanup patch too? | 15:40 |
| dtantsur | I wonder if it's much easier to re-release the same hash as a newer version | 15:41 |
| mordred | then the release notes would be very strange :) | 15:41 |
| dtantsur | maybe :) | 15:41 |
| dtantsur | you can try it locally with `git tag` and see | 15:41 |
| mordred | dtantsur: I modified the revert so that we don't need to revert the cleanup patch - it just won't use futurist for it for that one release | 15:41 |
| mordred | dtantsur: k. I'll try that real quick | 15:42 |
| gtema | and actually nobody will use it so far (likely) | 15:42 |
| mordred | dtantsur: considering we just released the cleanup feature today - I think if we rleease 0.45 and 0.46 back to back - it should be safe | 15:42 |
| dtantsur | mordred: maybe we can/should default to concurrent.futures.ThreadPoolExecutor actually? | 15:42 |
| dtantsur | the same API as futurist, so people can switch easily? | 15:43 |
| mordred | dtantsur: oh - that's not a terrible idea | 15:44 |
| gtema | keep your thought, otherwise mordred will create 30 different patches and we will die ensuring we approve them in correct order ;) | 15:45 |
| mordred | people who want to use futurist.GreenThreadExecutor can still pass it | 15:45 |
| dtantsur | exactly | 15:45 |
| mordred | I think I like that even more. it's basically what we have above except without the second re-revert | 15:45 |
| mordred | maybe should rewrite the release note slightly differently | 15:45 |
| tremble | mordred, Should doing dict(some_resource) result in a *all* parameters (body and URI based) showing up in the new dict ? | 15:46 |
| mordred | tremble: that's an excellent question - I believe so? | 15:46 |
| *** elmiko has joined #openstack-sdks | 15:46 | |
| mordred | dtantsur: the re-tag idea did not work :) | 15:47 |
| gtema | oh, I remember some interesting stuff about that when fighting with replacing cloud layer - something funny was there for sure | 15:47 |
| dtantsur | mordred: oookay, let's go with this patch | 15:47 |
| dtantsur | (the release note could use an update indeed) | 15:48 |
| gtema | tremble, we prefer using https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/resource.py#L918 (to_dict) for those reasons | 15:49 |
| tremble | gtema, That'll do me as a fix :) | 15:50 |
| tremble | gtema, Would misbehaving with dict() be considered a bug? | 15:50 |
| tremble | and if so, where do you want reports :) | 15:51 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Revert "Switch to futurist for concurrency" https://review.opendev.org/715249 | 15:51 |
| mordred | dtantsur, gtema: ^^ I think that should fix the issue. we can land that, gtema's otc fix and then cut an 0.45 | 15:51 |
| gtema | tremble - I would not say it is a bug, resource implementation is incredible woodoo | 15:51 |
| mordred | then I still think we should put ina. requires-python for 0.46 | 15:52 |
| tremble | gtema, I noticed :) | 15:52 |
| mordred | smcginnis: per scrollback - I think we found a solution that doesn't require removing anything | 15:52 |
| mordred | vphilippon: thanks for the report! we shoudl have a fixed release up soonish (will take a couple of hours for all of the gears to crank) | 15:53 |
| gtema | mordred, so I rebase vendor patch on top of 715249, right? | 15:53 |
| smcginnis | I will watch for the release and try to get it through asap. | 15:54 |
| smcginnis | And the requirements update. | 15:54 |
| vphilippon | @mordred: Alrighty, thanks a lot for the quick reaction. And thanks to everyone else too :) | 15:55 |
| tremble | gtema, to_dict() still seems to exclude the resource.URI entry | 15:55 |
| gtema | ah, and you need those explicitely? | 15:56 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Change default image type in the OTC vendor profile https://review.opendev.org/715183 | 15:56 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add requires-python entry indicating 3.6 is required https://review.opendev.org/715243 | 15:56 |
| mordred | gtema: rebase done ^^ | 15:57 |
| gtema | ok, thks mordred | 15:57 |
| mordred | gtema: I'm guessing this is for returning data to an ansible module - which needs json-able dict | 15:57 |
| mordred | smcginnis: I think the constraints patch that's there for us already is now safe | 15:57 |
| mordred | smcginnis: but - we can also just wait to reduce churn | 15:58 |
| mordred | smcginnis: I'll get release patches up asap | 15:58 |
| smcginnis | OK. I need to update that so it's python_version aware. Might as well wait a bit. | 15:58 |
| tremble | gtema, I wanted one for completeness, I can manually copy it over | 15:59 |
| gtema | we can add a parameter for it in to_dict if necessary | 15:59 |
| tremble | yeah, which then requires another release before I could use it in my Ansible module :) | 15:59 |
| gtema | sure :D | 16:00 |
| elmiko | API SIG office hour now open \o/ | 16:00 |
| gtema | lots of releases last days, therefore you might need to wait just one day, or one hour | 16:00 |
| mordred | we're killing tremble here | 16:00 |
| tremble | It'd be nice as a parameter, but I wouldn't prioritise it. | 16:00 |
| openstackgerrit | Duc Truong proposed openstack/openstacksdk master: Remove kwargs validation for identity project updates https://review.opendev.org/715255 | 16:02 |
| openstackgerrit | Duc Truong proposed openstack/openstacksdk master: Remove kwargs validation for identity project updates https://review.opendev.org/715255 | 16:03 |
| openstackgerrit | Duc Truong proposed openstack/openstacksdk master: Remove kwargs validation for identity project updates https://review.opendev.org/715255 | 16:04 |
| tremble | gtema, I just got really confused because I tried to do "dict(my_resource)" and some of the parameters disappears compared to just passing the resource directly to Ansible's "exit_json" | 16:04 |
| gtema | oh yes, this is really fun - was also enjoying it writing some modules | 16:05 |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_federation_protocol https://review.opendev.org/714991 | 16:09 |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_federation_protocol_info https://review.opendev.org/714992 | 16:09 |
| tremble | gtema, On the plus side my integration tests actually caught it :) | 16:13 |
| gtema | ah, there is one more thing to remember - switch on proxy in the cloud layer is not complete, therefore you might have different object types (munch vs resource) for different resources when using cloud layer | 16:14 |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Add possibility to include URI attributes in the resource dict https://review.opendev.org/715256 | 16:16 |
| gtema | I was starting to work on that, but there are everywhere things to clear, so stuck at some point | 16:17 |
| gtema | will try to revive this | 16:17 |
| mordred | yeah - same | 16:17 |
| gtema | ah, now I know what was the problem - resource object is not cacheable | 16:17 |
| gtema | and this is where we stuck wanting to discuss at some point | 16:18 |
| mordred | oh right | 16:25 |
| gtema | I guess make sense to discuss it before PTG :D | 16:26 |
| gtema | ok guys, need to go off while there is still bit of sun outside | 16:30 |
| elmiko | carpe them diems ;) | 16:31 |
| gtema | thks | 16:31 |
| *** gtema is now known as gtema|afk | 16:31 | |
| *** mgariepy has quit IRC | 16:36 | |
| *** mgariepy has joined #openstack-sdks | 16:43 | |
| openstackgerrit | Duc Truong proposed openstack/ansible-collections-openstack master: Add properties for os_project https://review.opendev.org/715266 | 16:44 |
| elmiko | have a good weekend all, stay safe out there o/ | 17:04 |
| *** enriquetaso has joined #openstack-sdks | 17:05 | |
| openstackgerrit | Vishakha Agarwal proposed openstack/python-openstackclient master: Adding options to user cli https://review.opendev.org/697444 | 17:09 |
| openstackgerrit | Vishakha Agarwal proposed openstack/python-openstackclient master: [WIP] Add immutable option https://review.opendev.org/715269 | 17:09 |
| *** gtema|afk has joined #openstack-sdks | 17:11 | |
| *** jpich has quit IRC | 17:12 | |
| *** rpittau is now known as rpittau|afk | 17:12 | |
| openstackgerrit | Merged openstack/python-openstackclient master: Add libc6-dev to bindep https://review.opendev.org/715210 | 17:13 |
| *** gtema|afk has quit IRC | 17:15 | |
| openstackgerrit | Merged openstack/python-openstackclient master: Be explicit about python version in image https://review.opendev.org/715211 | 17:25 |
| *** dtantsur is now known as dtantsur|afk | 17:32 | |
| *** evrardjp has quit IRC | 17:49 | |
| *** evrardjp has joined #openstack-sdks | 17:49 | |
| *** openstack has quit IRC | 17:49 | |
| *** openstack has joined #openstack-sdks | 17:52 | |
| *** ChanServ sets mode: +o openstack | 17:52 | |
| *** jpena is now known as jpena|off | 18:02 | |
| openstackgerrit | Duc Truong proposed openstack/ansible-collections-openstack master: Add properties for os_project https://review.opendev.org/715266 | 18:15 |
| *** Shrews has left #openstack-sdks | 18:17 | |
| *** sshnaidm is now known as sshnaidm|afk | 18:17 | |
| *** amoralej is now known as amoralej|off | 18:30 | |
| *** nightmare_unreal has quit IRC | 18:41 | |
| *** diablo_rojo has joined #openstack-sdks | 18:47 | |
| *** ralonsoh has quit IRC | 18:51 | |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: New Module: os_keystone_mapping https://review.opendev.org/713643 | 19:14 |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Ignore more things for the final artifact https://review.opendev.org/715302 | 20:22 |
| openstackgerrit | Monty Taylor proposed openstack/cliff master: Re-add support for python 3.5 https://review.opendev.org/715305 | 20:34 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add requires-python entry indicating 3.5 is required https://review.opendev.org/715243 | 20:36 |
| openstackgerrit | Monty Taylor proposed openstack/cliff master: Re-add support for python 3.5 https://review.opendev.org/715305 | 20:37 |
| openstackgerrit | Monty Taylor proposed openstack/cliff master: Re-add support for python 3.5 https://review.opendev.org/715305 | 20:38 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add requires-python entry indicating 3.5 is required https://review.opendev.org/715243 | 20:46 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add requires-python entry indicating 3.5 is required https://review.opendev.org/715243 | 20:49 |
| openstackgerrit | Andreas Jaeger proposed openstack/openstacksdk master: Add requires-python entry indicating 3.5 is required https://review.opendev.org/715243 | 20:51 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add requires-python entry indicating 3.5 is required https://review.opendev.org/715243 | 20:52 |
| mordred | smcginnis: good catch | 20:52 |
| smcginnis | Good, I feel better with that. ;) | 20:53 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add requires-python entry indicating 3.5 is required https://review.opendev.org/715243 | 20:53 |
| smcginnis | mordred: Looks like you had a clash with Andreas. He made a minor typo fix. | 20:53 |
| mordred | smcginnis: yeah - just picked it up | 20:53 |
| smcginnis | And there you go.. | 20:53 |
| openstackgerrit | Andreas Jaeger proposed openstack/openstacksdk master: Small cleanups after Python2 drop https://review.opendev.org/715309 | 20:55 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Small cleanups after Python2 drop https://review.opendev.org/715309 | 20:57 |
| openstackgerrit | Andreas Jaeger proposed openstack/openstacksdk master: Re-add nodepool functional test https://review.opendev.org/715245 | 21:01 |
| openstackgerrit | Duc Truong proposed openstack/ansible-collections-openstack master: Add properties for os_project https://review.opendev.org/715266 | 21:12 |
| *** gtema|afk has joined #openstack-sdks | 21:12 | |
| *** gtema|afk has quit IRC | 21:17 | |
| openstackgerrit | Merged openstack/openstacksdk master: Revert "Switch to futurist for concurrency" https://review.opendev.org/715249 | 21:40 |
| *** enriquetaso has quit IRC | 21:49 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add requires-python entry indicating 3.5 is required https://review.opendev.org/715243 | 22:19 |
| vphilippon | @mordred: so just to make sure, the plan is still to make a release (which supports py2) before adding the py3.5 constraint? | 22:22 |
| mordred | vphilippon: yes, that's right ... I've submitted this: https://review.opendev.org/#/c/715317/ | 22:23 |
| mordred | which will trigger the release of 0.45 with py2 supported properly | 22:23 |
| mordred | then we'll land the 3.5 patch above and cut a 0.46 | 22:23 |
| mordred | so the world should be in a sensible position again after that | 22:23 |
| vphilippon | Great, thanks! I can make a quick test of 0.45 when it lands to validate before you go forward :) | 22:26 |
| mordred | vphilippon: sweet! | 22:26 |
| openstackgerrit | Sam Morrison proposed openstack/openstacksdk master: Add availability zone and availability zone profile resources to load balancer https://review.opendev.org/714345 | 22:50 |
| *** tkajinam has joined #openstack-sdks | 22:54 | |
| *** slaweq has quit IRC | 22:59 | |
| *** slaweq has joined #openstack-sdks | 23:10 | |
| *** gtema|afk has joined #openstack-sdks | 23:13 | |
| *** slaweq has quit IRC | 23:15 | |
| *** gtema|afk has quit IRC | 23:18 | |
| openstackgerrit | Merged openstack/cliff master: Re-add support for python 3.5 https://review.opendev.org/715305 | 23:43 |
| *** tosky has quit IRC | 23:53 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!