*** __ministry has quit IRC | 01:59 | |
*** __ministry has joined #openstack-sdks | 02:01 | |
*** enriquetaso has quit IRC | 02:11 | |
*** lbragstad has quit IRC | 02:21 | |
*** diablo_rojo has quit IRC | 03:41 | |
*** evrardjp has quit IRC | 04:33 | |
*** evrardjp has joined #openstack-sdks | 04:33 | |
*** yolanda has quit IRC | 06:31 | |
*** yolanda has joined #openstack-sdks | 06:36 | |
*** gtema has joined #openstack-sdks | 06:41 | |
*** noonedeadpunk has joined #openstack-sdks | 06:41 | |
*** rpittau|afk is now known as rpittau | 06:43 | |
openstackgerrit | Merged openstack/openstacksdk master: Add query parameter 'id' for security_groups https://review.opendev.org/735601 | 06:45 |
---|---|---|
*** ttsiouts has joined #openstack-sdks | 07:06 | |
*** slaweq has joined #openstack-sdks | 07:06 | |
*** ttsiouts has quit IRC | 07:19 | |
*** ttsiouts has joined #openstack-sdks | 07:19 | |
*** ralonsoh has joined #openstack-sdks | 07:21 | |
*** tosky has joined #openstack-sdks | 07:25 | |
*** ttsiouts has quit IRC | 07:54 | |
*** jpena|off is now known as jpena | 07:57 | |
*** ttsiouts has joined #openstack-sdks | 07:58 | |
*** jpich has joined #openstack-sdks | 08:07 | |
*** ttsiouts has quit IRC | 08:12 | |
*** ttsiouts has joined #openstack-sdks | 08:13 | |
*** ttsiouts_ has joined #openstack-sdks | 08:16 | |
*** ttsiouts has quit IRC | 08:17 | |
*** dtantsur|afk is now known as dtantsur | 08:29 | |
*** ttsiouts has joined #openstack-sdks | 08:36 | |
*** ttsiout__ has joined #openstack-sdks | 08:37 | |
*** ttsiouts_ has quit IRC | 08:40 | |
*** ttsiouts has quit IRC | 08:41 | |
*** jawad_axd has joined #openstack-sdks | 09:09 | |
*** jpich has quit IRC | 09:20 | |
*** jpich has joined #openstack-sdks | 09:21 | |
*** ttsiouts has joined #openstack-sdks | 09:32 | |
*** ttsiout__ has quit IRC | 09:32 | |
*** tkajinam has quit IRC | 10:05 | |
*** rpittau is now known as rpittau|bbl | 10:06 | |
*** gtema has quit IRC | 10:43 | |
*** gtema has joined #openstack-sdks | 10:56 | |
openstackgerrit | Pratik Raj proposed openstack/cliff master: optimize size and time using --no-cache-dir https://review.opendev.org/736641 | 11:36 |
*** jpena is now known as jpena|lunch | 11:38 | |
*** mgariepy has quit IRC | 11:43 | |
*** ttsiouts has quit IRC | 12:06 | |
openstackgerrit | jayaditya gupta proposed openstack/cliff master: Output correct json for security groups in 'openstack server show' https://review.opendev.org/735128 | 12:07 |
*** ttsiouts has joined #openstack-sdks | 12:07 | |
*** ttsiouts has quit IRC | 12:11 | |
mordred | slaweq: see comment from frickler on https://review.opendev.org/#/c/736005/ - it's possible there is a neutron bug | 12:13 |
slaweq | mordred: looking | 12:13 |
mordred | slaweq: (it's possible it's not - but when I see "unintended information leak" ...) | 12:14 |
*** mgariepy has joined #openstack-sdks | 12:19 | |
*** rpittau|bbl is now known as rpittau | 12:20 | |
*** ttsiouts has joined #openstack-sdks | 12:28 | |
slaweq | mordred: I just opened https://bugs.launchpad.net/neutron/+bug/1884067 | 12:34 |
openstack | Launchpad bug 1884067 in neutron "[API] Filtering by fields not allowed to see is possible for regular users" [High,Confirmed] | 12:34 |
slaweq | mordred: frickler thx for finding this | 12:34 |
slaweq | mordred: frickler I think we are not checking what fields are available for user during filtering, we are only removing such fields from the returned data | 12:35 |
frickler | slaweq: sorry, I wanted to ping you earlier about this but then got distracted, it just looked odd to me when testing mnaser's patch | 12:35 |
slaweq | I will ask amotoki to take a look into it | 12:35 |
mordred | \o/. we're helpful! good catch frickler :) | 12:38 |
*** jpena|lunch is now known as jpena | 12:38 | |
mordred | mnaser: you made things betterer | 12:38 |
mnaser | what did I do oops | 12:39 |
mnaser | oh no | 12:39 |
mnaser | that’s no good | 12:39 |
mnaser | we should fix that soon :) | 12:40 |
mnaser | (and if no one has the time to do that, I can, cause you know, that’s a little important) | 12:40 |
mnaser | I’m not that worried though, we don’t expose the host id anywhere so I don’t think anyone can see it to use it later | 12:41 |
*** ttsiouts has quit IRC | 12:47 | |
*** jawad_axd has quit IRC | 12:47 | |
*** ttsiouts has joined #openstack-sdks | 12:47 | |
*** ttsiouts has quit IRC | 12:52 | |
*** ttsiouts has joined #openstack-sdks | 12:54 | |
*** noonedeadpunk is now known as noonedeadpunk_ | 12:57 | |
*** lbragstad has joined #openstack-sdks | 13:16 | |
*** ttsiouts has quit IRC | 13:18 | |
*** ttsiouts has joined #openstack-sdks | 13:19 | |
*** enriquetaso has joined #openstack-sdks | 13:19 | |
*** ttsiouts has quit IRC | 13:23 | |
*** sshnaidm is now known as sshnaidm|mtg | 13:23 | |
*** ttsiouts has joined #openstack-sdks | 13:26 | |
*** shaohe_feng has joined #openstack-sdks | 13:50 | |
shaohe_feng | hi, mordred and gtema | 13:51 |
shaohe_feng | there is a issue when I connect glance from cyborg | 13:52 |
shaohe_feng | Need you help | 13:52 |
shaohe_feng | Traceback (most recent call last): | 13:53 |
shaohe_feng | "/opt/stack/cyborg/cyborg/image/api.py", line 163, in download | 13:53 |
*** shaohe_feng has quit IRC | 13:53 | |
mordred | I want to help shaohe_feng | 13:56 |
*** shaohe_feng has joined #openstack-sdks | 13:56 | |
shaohe_feng | Traceback (most recent call last): | 13:56 |
shaohe_feng | "/opt/stack/cyborg/cyborg/image/api.py", line 163, in download | 13:56 |
*** shaohe_feng has quit IRC | 13:56 | |
*** shaohe_feng has joined #openstack-sdks | 13:58 | |
*** senrique_ has joined #openstack-sdks | 14:09 | |
*** enriquetaso has quit IRC | 14:12 | |
mordred | shaohe_feng: try pasting to paste.openstack.org and then copying the link here | 14:12 |
shaohe_feng | mordred: this is the traceback http://paste.openstack.org/show/794946/ | 14:14 |
shaohe_feng | mordred: this is the conf http://paste.openstack.org/show/794948/ | 14:17 |
shaohe_feng | mordred: this is the cyborg repo https://github.com/openstack/cyborg and glance api code is here: https://github.com/openstack/cyborg/blob/6dab512af226677c9065f85f264a691f3aeb6eab/cyborg/image/glance.py | 14:19 |
mordred | shaohe_feng: sadly I don't think we're going to be much help with that - it's using glanceclient not openstacksdk - I'm really not sure what's going on :( | 14:20 |
shaohe_feng | mordred I'm using SDK: | 14:21 |
shaohe_feng | + ksa_adap = utils.get_sdk_adapter( | 14:21 |
shaohe_feng | in my code I chage it to get_sdk_adapter | 14:22 |
shaohe_feng | here I change get_ksa_adapter to get_sdk_adapter https://github.com/openstack/cyborg/blob/6dab512af226677c9065f85f264a691f3aeb6eab/cyborg/image/glance.py#L113 | 14:23 |
mordred | shaohe_feng: yes - but the traceback you pasted is flowing through glanceclient - so it seems that sdk adapter is just being used to find the list of glance servers | 14:24 |
mordred | so - at some point that info is being passed to a Glanceclient constructor - and god only knows what it's doing | 14:25 |
shaohe_feng | https://github.com/openstack/cyborg/blob/master/cyborg/common/utils.py#L135 | 14:25 |
shaohe_feng | ^ mordred: what the get_sdk_adapter define | 14:25 |
shaohe_feng | so why it still use glanceclient ? | 14:26 |
shaohe_feng | I already change it to get_sdk_adapter | 14:26 |
shaohe_feng | something wrong when I change it to get_sdk_adapter ? | 14:26 |
shaohe_feng | mordred can you tell me what should I do? | 14:27 |
mordred | shaohe_feng: that looks fine - but there is still this: https://github.com/openstack/cyborg/blob/6dab512af226677c9065f85f264a691f3aeb6eab/cyborg/image/glance.py#L129 | 14:28 |
mordred | shaohe_feng: let me look at the code a little more and see if I can make some suggestions | 14:28 |
shaohe_feng | mordred: thank you. | 14:28 |
*** noonedeadpunk_ is now known as noonedeadpunk | 14:29 | |
gtema | shaone_feng - I guess you should be targeting dropping your cyborg/image/glance completely and modify cyborg/image/api to use SDK instead | 14:30 |
*** ttsiouts has quit IRC | 14:30 | |
mordred | gtema: looking at the master branch, it looks like they're laready doing that | 14:31 |
*** ttsiouts has joined #openstack-sdks | 14:31 | |
gtema | oh, I was looking to the posted particular commit | 14:31 |
mordred | oh - wait | 14:31 |
mordred | eah | 14:31 |
mordred | ZOMG - the method is returning a GlanceClient and calling it a session | 14:32 |
gtema | even in master there is still from cyborg.image import glance | 14:32 |
mordred | yup. | 14:33 |
mordred | I was fooled by "session.delete()" | 14:33 |
*** ttsiouts has quit IRC | 14:36 | |
shaohe_feng | gtema: mordred: I'm still use GlanceClient ? | 14:38 |
*** shaohe_feng has quit IRC | 14:38 | |
mordred | gtema: they're going to nerdsnipe me in to fixing cyborg aren't they? | 14:39 |
*** shaohe_feng has joined #openstack-sdks | 14:42 | |
gtema | shaone_feng - you stacktrace exactly points into that | 14:42 |
gtema | mordred - right | 14:42 |
shaohe_feng | gtema: mordred: sorry, I'm offline just now. something wrong with my network. | 14:42 |
shaohe_feng | may I missing something? | 14:43 |
gtema | shaohe_feng - guess not | 14:43 |
mordred | shaohe_feng: cyborg.image.api.API._get_session_and_image_id is constructing a Glanceclient object | 14:43 |
mordred | shaohe_feng: which in turn is used in API.download | 14:44 |
shaohe_feng | good, so what should I change? | 14:44 |
mordred | probably the entire cyborg/image/glance.py file | 14:44 |
shaohe_feng | the FPGA need to download image | 14:44 |
gtema | yes - drop it and modify the cyborg/image/api | 14:44 |
shaohe_feng | we need to program the FPGA | 14:44 |
shaohe_feng | any example for it? | 14:44 |
mordred | shaohe_feng: I'm going to see if I can make a non-working example patch that can point you in the right direction | 14:44 |
shaohe_feng | mordred good. thanks. | 14:45 |
mordred | gtema: it's the same code as from nova, so if we fix it here for cyborg, we'll have a good example of how to fix it for nova too :) | 14:45 |
gtema | :) | 14:45 |
*** ttsiouts has joined #openstack-sdks | 14:46 | |
*** Luzi has joined #openstack-sdks | 15:01 | |
*** senrique__ has joined #openstack-sdks | 15:03 | |
*** senrique_ has quit IRC | 15:05 | |
*** ttsiouts has quit IRC | 15:07 | |
*** ttsiouts has joined #openstack-sdks | 15:07 | |
*** mgariepy has quit IRC | 15:08 | |
*** ttsiouts has quit IRC | 15:09 | |
*** ttsiouts has joined #openstack-sdks | 15:09 | |
*** ttsiouts has quit IRC | 15:14 | |
*** senrique_ has joined #openstack-sdks | 15:23 | |
*** senrique__ has quit IRC | 15:25 | |
*** mgariepy has joined #openstack-sdks | 15:28 | |
*** slaweq has quit IRC | 15:33 | |
*** sshnaidm|mtg is now known as sshnaidm|ruck | 15:41 | |
*** gtema_ has joined #openstack-sdks | 15:54 | |
*** gtema has quit IRC | 15:57 | |
*** also_stingrayza has joined #openstack-sdks | 15:58 | |
*** diablo_rojo has joined #openstack-sdks | 16:00 | |
*** Luzi has quit IRC | 16:01 | |
*** stingrayza has quit IRC | 16:01 | |
elmiko | API SIG office hour open | 16:02 |
elmiko | mordred: i haven't seen much more activity on the service discovery PRs, i'm going to move towards a freeze and asking for wider review if that sounds good to you? | 16:04 |
mordred | elmiko: ++ | 16:07 |
elmiko | thank you sir =) | 16:07 |
mordred | thank you! | 16:09 |
*** shaohe_feng has quit IRC | 16:20 | |
*** jpich has quit IRC | 16:27 | |
elmiko | ok, frozen and email sent | 16:34 |
dtantsur | \o/ | 16:51 |
*** sshnaidm|ruck is now known as sshnaidm|off | 16:52 | |
*** olaph has joined #openstack-sdks | 16:54 | |
*** olaph is now known as stinky | 16:56 | |
*** stinky is now known as olaph | 16:56 | |
*** olaph has quit IRC | 16:58 | |
*** olaph has joined #openstack-sdks | 16:58 | |
*** rpittau is now known as rpittau|afk | 17:00 | |
*** gtema_ has quit IRC | 17:02 | |
elmiko | have a good weekend all, stay safe and healthy out there =) o/ | 17:08 |
*** dtantsur is now known as dtantsur|afk | 17:10 | |
*** jpena is now known as jpena|off | 17:21 | |
*** senrique__ has joined #openstack-sdks | 17:47 | |
*** senrique_ has quit IRC | 17:49 | |
*** ralonsoh has quit IRC | 17:57 | |
*** factor__ has quit IRC | 18:11 | |
*** factor__ has joined #openstack-sdks | 18:11 | |
*** senrique__ has quit IRC | 18:54 | |
*** gtema has joined #openstack-sdks | 19:03 | |
*** gtema has quit IRC | 19:08 | |
*** gmann is now known as gmann_afk | 19:22 | |
*** gmann_afk is now known as gmann | 19:37 | |
*** gmann is now known as gmann_afk | 20:10 | |
*** slaweq has joined #openstack-sdks | 20:23 | |
*** senrique__ has joined #openstack-sdks | 20:30 | |
*** senrique__ has quit IRC | 21:26 | |
*** gmann_afk is now known as gmann | 22:04 | |
*** tonyb has joined #openstack-sdks | 22:05 | |
openstackgerrit | Merged openstack/keystoneauth stable/ussuri: Fix E741 pep8 failure https://review.opendev.org/731188 | 22:06 |
*** slaweq has quit IRC | 22:13 | |
*** slaweq has joined #openstack-sdks | 22:24 | |
*** tosky has quit IRC | 22:25 | |
*** slaweq has quit IRC | 22:28 | |
*** tkajinam has joined #openstack-sdks | 23:00 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!