Monday, 2020-07-27

« Sunday, 2020-07-26 Index Tuesday, 2020-07-28 »
openstackgerritGhanshyam Mann proposed openstack/keystoneauth master: DNM: testing gate on ubuntu focal  https://review.opendev.org/74311800:03
*** ricolin has joined #openstack-sdks03:41
*** dave-mccowan has quit IRC04:37
*** tosky has joined #openstack-sdks06:42
*** vishakha has joined #openstack-sdks07:11
*** jpena|off is now known as jpena07:21
*** holser has joined #openstack-sdks07:23
*** holser_ has joined #openstack-sdks07:39
*** holser__ has joined #openstack-sdks07:40
*** holser has quit IRC07:41
*** ricolin has quit IRC07:43
*** holser has joined #openstack-sdks07:44
*** holser_ has quit IRC07:44
*** holser__ has quit IRC07:45
*** nightmare_unreal has joined #openstack-sdks07:52
*** ralonsoh has joined #openstack-sdks07:53
*** jpich has joined #openstack-sdks07:55
*** tosky has quit IRC08:03
*** dtantsur|afk is now known as dtantsur08:05
*** gtema has joined #openstack-sdks08:24
*** gtema has quit IRC08:32
*** rpittau has joined #openstack-sdks08:34
*** holser_ has joined #openstack-sdks08:39
*** holser has quit IRC08:40
*** holser_ has quit IRC08:40
*** holser has joined #openstack-sdks08:42
*** holser_ has joined #openstack-sdks08:47
*** holser has quit IRC08:50
*** holser_ has quit IRC08:52
*** holser has joined #openstack-sdks08:57
*** holser has quit IRC09:01
*** holser has joined #openstack-sdks09:02
*** holser has quit IRC09:09
*** holser has joined #openstack-sdks09:09
*** tosky has joined #openstack-sdks09:33
openstackgerritDmitry Tantsur proposed openstack/ansible-collections-openstack master: Add non-voting bifrost jobs  https://review.opendev.org/74317609:37
openstackgerritDmitry Tantsur proposed openstack/ansible-collections-openstack master: DNM try breaking ironic  https://review.opendev.org/74317709:40
*** also_stingrayza is now known as stingrayza09:56
openstackgerritDmitry Tantsur proposed openstack/openstacksdk master: DNM nothing to see here  https://review.opendev.org/74287010:05
*** tkajinam has quit IRC10:10
dtantsurhey folks, config.get_endpoint seems to misbehave in the SDK :(10:42
dtantsursee the patch above, it fails on bifrost on the assertion error10:42
openstackgerritDmitry Tantsur proposed openstack/openstacksdk master: DNM nothing to see here  https://review.opendev.org/74287010:45
openstackgerritDmitry Tantsur proposed openstack/ansible-collections-openstack master: Add non-voting bifrost jobs  https://review.opendev.org/74317610:47
*** jpich has quit IRC10:48
*** jpich has joined #openstack-sdks10:49
*** iurygregory has quit IRC10:59
*** iurygregory has joined #openstack-sdks11:01
*** mgariepy has quit IRC11:02
dtantsur'auth': {'username': '********', 'password': '********', 'endpoint': '********'}11:06
dtantsurfor god's sake, what on earth is replacing endpoint with stars? Oo11:06
openstackgerritDmitry Tantsur proposed openstack/openstacksdk master: DNM nothing to see here  https://review.opendev.org/74287011:08
*** jpena is now known as jpena|lunch11:38
*** mgariepy has joined #openstack-sdks12:14
*** mordred has joined #openstack-sdks12:20
dtantsurmordred: hey! so, we use get_api_major_version in our service discovery, which does not work without endpoint_override, right?\12:23
dtantsurwhich sounds.. wrong to me12:24
*** enriquetaso has joined #openstack-sdks12:28
mordredthat sounds wrong to me too12:29
mordredoh - I think it's possible that we set endpoint_override as part of proxy creation12:30
mordredlike - iirc, we do a round of discovery to find the endpoint and then create an adapter with that endpoint set via endpoint_override12:30
mordredmaybe12:30
* mordred is still coffeeing12:30
*** evrardjp has quit IRC12:32
*** evrardjp has joined #openstack-sdks12:32
*** evrardjp has quit IRC12:32
*** evrardjp has joined #openstack-sdks12:33
*** jpena|lunch is now known as jpena12:34
dtantsurwell, I'm trying to use http_basic auth and get_api_major_version is broken in two palces12:42
dtantsurfirst, get_endpoint_data always returns None if endpoint_override is None (ignoring self.endpoint)12:42
dtantsurI have no clue how it works for no-auth now, it should not12:42
mordredhrm12:43
dtantsurseconds, this condition is hit for ironic https://opendev.org/openstack/keystoneauth/src/branch/master/keystoneauth1/discover.py#L1115-L111912:43
dtantsuragain, no clue why it works for no-auth, but here it ends up with EndpointData populated with None12:43
dtantsurbecause we don't run any discovery whatsoever12:44
mordredwell - you need to run some discovery to get microversion info - even with an endpoint_override12:44
dtantsureven to get major version info12:45
dtantsurkilling the code in the 2nd link with fire and fixing http_basic.py to implement get_endpoint_data allows me to progress12:45
mordredyeah. because otherwise how would it know12:45
dtantsurbut I wonder what I'm missing since it works for no-auth..12:45
mordredit's a good question12:46
*** KeithMnemonic has joined #openstack-sdks12:46
dtantsurit HAS to hit all the same problems. I don't understand why it does not.12:47
* dtantsur has been fighting with this for nearly a week already12:47
*** lbragstad has joined #openstack-sdks12:53
mordreddtantsur: I agree with you - I cannot see any difference between the two13:16
KeithMnemonicis there anyone here he wolud be kind enough to do a few review on openstackclient that passed a while back but are stuck waiting on reviews?  thank you  https://review.opendev.org/#/q/project:openstack/python-openstackclient+owner:%22Keith+Berger+%253Ckeith.berger%2540suse.com%253E%22+status:open13:19
dtantsur:(13:19
dtantsurI'm close to giving up on this, honestly.. but that would be a big loss if we cannot use authentication in bifrost without keystone13:19
mordreddtantsur: there's a couple of unit tests we have for noauth but not for httpbasic - let me see what adding similar ones for basic doe13:21
dtantsur+++13:21
* dtantsur -> short walk to reduce frustration13:21
mordreddtantsur: oh - when you get back ...13:22
mordredno, nevermind13:22
*** dtantsur is now known as dtantsur|brb13:22
*** stingrayza has quit IRC13:25
*** stingrayza has joined #openstack-sdks13:26
openstackgerritMonty Taylor proposed openstack/keystoneauth master: Add unit test for httpbasicauth and discovery  https://review.opendev.org/74322713:26
mordreddtantsur: when you get back, can you point me to an example anywhere of this not working? unit test for the auth plugin calls get_api_major_version just fine on an http basic auth plugin13:27
mordreddtantsur: remote:   https://review.opendev.org/743227 Add unit test for httpbasicauth and discovery13:27
*** stingrayza has quit IRC13:30
*** stingrayza has joined #openstack-sdks13:33
openstackgerritjayaditya gupta proposed openstack/python-openstackclient master: openstack CLI migration list support  https://review.opendev.org/74221013:35
nightmare_unrealhello can someone review this patch and also leave a response to my comment regarding it. https://review.opendev.org/#/c/742210/13:36
*** ricolin has joined #openstack-sdks14:31
*** dtantsur|brb is now known as dtantsur15:06
dtantsurmordred: if you have a spare VM, I can show you how to reproduce the bifrost failure15:07
dtantsurI don't have a simple reproducer (which is another reason why I'm so frustrated)15:07
dtantsurmordred: may I take over https://review.opendev.org/#/c/743227 and add a fix things there that might be a partial fix for my situation?15:12
openstackgerritDmitry Tantsur proposed openstack/keystoneauth master: Fix get_endpoint_data for non-keystone plugins  https://review.opendev.org/74322715:21
dtantsurmordred: ^^^15:21
mordreddtantsur: neat15:26
mordreddtantsur: oh - that looks good15:27
mordreddtantsur: still no clue why it works for one and not the other :)15:27
mordreddtantsur: I had a thought - is it possible that ironic is http-auth protecting the discovery endpoit and ksa is just not sending auth when it talks to it?15:28
mordredso ksa is trying to do discovery on the endpoint and failing?15:28
mordred(which would explain why noauth works)15:28
dtantsurmordred: checked that already15:28
mordrednod15:29
dtantsurcurl works correctly15:29
dtantsur(we had this problem with ironic-inspector, but we seem to be past it )15:29
*** mgariepy has quit IRC15:36
*** jpich has quit IRC16:01
dtantsurAttributeError: 'EntryPoint' object has no attribute 'module_name'16:04
dtantsurhasn't it been fixed? I see it in keystoneauth on `tox -edocs`16:04
mordredI thougth so?16:06
* mordred trying locally16:06
mordredI thought it was a version something something16:07
mordreddtantsur: I agree - I see that same issue16:07
dtantsuryep :(16:08
mordreddtantsur: maybe we fixed it in sdk but not ksa16:08
mordreddtantsur: fix coming16:12
dtantsurnice! if you also guess why this bloody discovery does not work, you'll be my saviour today :)16:12
openstackgerritMonty Taylor proposed openstack/keystoneauth master: Fix docs builds for modern stevedors  https://review.opendev.org/74327416:13
mordreddtantsur: ^^ that16:13
mordreddtantsur: I like being saviors :)16:13
*** ricolin has quit IRC16:16
*** mgariepy has joined #openstack-sdks16:17
dtantsurbut I think that get_endpoint_data patch is a part of the puzzle16:17
dtantsurmordred: mmm, look. the adapter calls get_endpoint_data with service_type:baremetal, version:1 and so on, but it all goes to /dev/null16:21
dtantsurbecause **kwargs are ignored in BaseAuthPlugin.get_endpoint_data16:21
dtantsuris it intended?16:21
dtantsurokay, I guess ignoring service_type is fine, but ignoring version seems to inhibit the discovery?16:22
mordrednot to my knowlege - probably just oversight. does passing the **kwargs on help?16:22
mordredyeah16:22
mordred(still confused why noauth works)16:22
dtantsurwhich brings me back to the question why we inhibit discovery when a version is not requested..16:22
dtantsuryep. me too16:22
dtantsurquite a few tests break if I remove the no_version handling from discover.py16:26
dtantsurmaybe I should go the other way and set max_version=min_version=kwargs.get('version')?16:26
dtantsurwait, it's much easier!16:27
mordreddtantsur: I think we inhibit discovery when a version isn't provided because we just assume that whatever is the default in the catalog is fine16:28
mordredoh?16:28
mordredcool!16:28
dtantsurmordred: do you have a clue why inside get_api_major_version we call get_endpoint_data with discover_version=False?16:28
dtantsurit seems like a version is what we need to discover16:28
dtantsurif I change that to true, things start to work for me16:28
mordredhrm. I think it's because we're trying to avoid a full discovery call if we don't need one16:29
mordredbut honestly - I kind of feel like perhaps that's effort we should stop caring about16:29
dtantsuryeah, but then we short-circuit discovery if no versions are requested16:29
dtantsurresulting in api_version being None16:30
* dtantsur still has no clue why the same thing work for no-auth16:30
mordreddoes is break things to set it to true? :)16:30
dtantsurlemme try!16:30
mordredis there any chance that noauth vs httpauth we're using versioned vs unversioned endpoints as input?16:30
mordredlike - because we'll infer major api version from the /v1 in the endpoint if its there16:31
mordredso maybe we've just accidentally worked with noauth based on input data?16:31
dtantsurmordred: in case of bifrost the endpoints should be the same (unversioned)16:31
mordrednod16:31
mordredso yeah - no clue here16:31
dtantsurif I change it, the no-auth/http_basic tests fail with: No mock address: GET http://keystone.example.com:5000/v316:32
dtantsurwhich is pretty expected16:32
dtantsurI guess what we need is "please do discover the major version but don't discovery microversions"16:32
mordredor just add in mocks for mv discovery to those tests16:33
dtantsuryeah, I'm still trying to avoid discovering microversions.. but it seems non-trivial with the code we have16:35
dtantsurmordred: and this is why it works for keystone ;) https://opendev.org/openstack/keystoneauth/src/branch/master/keystoneauth1/identity/base.py#L501-L50616:37
mordreddtantsur: hahahahah16:38
dtantsurokay, I'll update the same patch and hope I don't break anything else :D16:38
* dtantsur will probably throw a testing patch on bifrost to make sure it works16:39
mordred++16:39
dtantsurand I think I see why the unit tests don't catch: we're using a versioned endpoint there16:41
*** jpena is now known as jpena|off16:41
dtantsurand if I change it, everything breaks16:48
dtantsurmordred: actually, discover_versions is also responsible for populating EndpointData.url16:58
openstackgerritDmitry Tantsur proposed openstack/keystoneauth master: [WIP] Correct endpoint discovery for non-keystone plugins  https://review.opendev.org/74328216:59
dtantsurthis is a rabbit hole ^^^16:59
dtantsurI'll continue tomorrow16:59
*** dtantsur is now known as dtantsur|afk16:59
*** nightmare_unreal has quit IRC17:20
*** ralonsoh has quit IRC17:23
*** ralonsoh has joined #openstack-sdks17:23
*** ralonsoh has quit IRC18:08
*** evrardjp has quit IRC18:21
*** evrardjp has joined #openstack-sdks18:24
*** tosky has quit IRC18:33
openstackgerritMerged openstack/ansible-collections-openstack master: Add non-voting bifrost jobs  https://review.opendev.org/74317618:34
*** vishakha has quit IRC18:50
*** enriquetaso has quit IRC19:25
*** slaweq has quit IRC20:36
*** slaweq has joined #openstack-sdks20:47
*** slaweq has quit IRC20:52
*** manasareddybethi has joined #openstack-sdks21:21
manasareddybethiLooking for +2 reviews please: https://review.opendev.org/#/c/741320/ Delete the testcase that is not needed anymore21:23
*** tosky has joined #openstack-sdks21:25
openstackgerritmelanie witt proposed openstack/python-openstackclient master: WIP Show words indicating booted from volume for server image  https://review.opendev.org/74342922:14
openstackgerritMerged openstack/keystoneauth master: Fix docs builds for modern stevedors  https://review.opendev.org/74327422:20
*** enriquetaso has joined #openstack-sdks22:45
*** senrique_ has joined #openstack-sdks22:48
*** enriquetaso has quit IRC22:50
*** tkajinam has joined #openstack-sdks22:52
*** dtroyer has quit IRC23:03
openstackgerritMerged openstack/python-openstackclient master: Delete the testcases that arent needed anymore  https://review.opendev.org/74132023:11
*** tosky has quit IRC23:25
*** senrique_ has quit IRC23:28
*** holser has quit IRC23:30
*** holser has joined #openstack-sdks23:34
« Sunday, 2020-07-26 Index Tuesday, 2020-07-28 »

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!