| *** tosky has quit IRC | 00:01 | |
| *** holser has quit IRC | 00:35 | |
| *** LinPeiWen has joined #openstack-sdks | 00:40 | |
| *** LinPeiWen has quit IRC | 01:08 | |
| *** khomesh24 has joined #openstack-sdks | 01:09 | |
| *** LinPeiWen94 has joined #openstack-sdks | 01:19 | |
| *** tkajinam has quit IRC | 01:41 | |
| *** tkajinam has joined #openstack-sdks | 01:42 | |
| *** tkajinam has quit IRC | 02:09 | |
| *** tkajinam has joined #openstack-sdks | 02:10 | |
| openstackgerrit | wushiming proposed openstack/openstacksdk master: Drop lower-constraints job https://review.opendev.org/c/openstack/openstacksdk/+/770527 | 02:19 |
|---|---|---|
| *** enriquetaso has joined #openstack-sdks | 03:02 | |
| *** ysandeep|away is now known as ysandeep | 03:24 | |
| *** ricolin_ has joined #openstack-sdks | 03:39 | |
| *** udesale has joined #openstack-sdks | 03:48 | |
| *** ricolin_ has quit IRC | 03:54 | |
| *** enriquetaso has quit IRC | 04:15 | |
| *** evrardjp has quit IRC | 05:20 | |
| *** evrardjp has joined #openstack-sdks | 05:24 | |
| *** evrardjp has quit IRC | 05:33 | |
| *** evrardjp has joined #openstack-sdks | 05:35 | |
| *** nikparasyr has joined #openstack-sdks | 06:05 | |
| *** ralonsoh has joined #openstack-sdks | 07:19 | |
| *** gtema has joined #openstack-sdks | 07:31 | |
| *** gtema has quit IRC | 07:43 | |
| *** BakaKuna has joined #openstack-sdks | 07:45 | |
| *** openstackgerrit has quit IRC | 07:47 | |
| *** gtema has joined #openstack-sdks | 07:51 | |
| *** nightmare_unreal has joined #openstack-sdks | 07:53 | |
| *** gtema has quit IRC | 07:55 | |
| *** slaweq has joined #openstack-sdks | 07:59 | |
| *** diablo_rojo__ has quit IRC | 08:01 | |
| *** slaweq has quit IRC | 08:04 | |
| *** slaweq has joined #openstack-sdks | 08:10 | |
| *** openstackgerrit has joined #openstack-sdks | 08:10 | |
| openstackgerrit | Takashi Kajinami proposed openstack/python-openstackclient master: Volume type: Update is_public attribute https://review.opendev.org/c/openstack/python-openstackclient/+/768800 | 08:10 |
| *** gtema has joined #openstack-sdks | 08:14 | |
| *** rpittau|afk is now known as rpittau | 08:25 | |
| *** holser has joined #openstack-sdks | 08:34 | |
| *** tosky has joined #openstack-sdks | 08:39 | |
| *** jpich has joined #openstack-sdks | 09:06 | |
| *** dasp_ has quit IRC | 09:16 | |
| *** dasp has joined #openstack-sdks | 09:17 | |
| stephenfin | gtema: Are you okay with me self-approving OSC compute-related patches that have +1s from nova cores? | 09:19 |
| gtema | yes | 09:20 |
| stephenfin | cool, thanks | 09:20 |
| gtema | thank you for taking care of that also | 09:20 |
| stephenfin | no problem at all | 09:20 |
| stephenfin | gtema: Oh, I do have one non-nova gate fix patch that needs attention though /o\ https://review.opendev.org/c/openstack/python-openstackclient/+/769980 | 09:22 |
| stephenfin | (python-karborclient was removed from tracking in openstack/requirements so the requirements job is failing) | 09:23 |
| gtema | I thought I was approving it, weird | 09:23 |
| gtema | done | 09:23 |
| stephenfin | thanks | 09:23 |
| gtema | can you please have a look at https://review.opendev.org/c/openstack/openstacksdk/+/769484 | 09:25 |
| gtema | I want to cut SDK release soon | 09:25 |
| stephenfin | sure, looking now | 09:25 |
| gtema | and complete this hypervisor patch | 09:25 |
| *** jpich has quit IRC | 09:34 | |
| *** jpich has joined #openstack-sdks | 09:34 | |
| *** BakaKuna has quit IRC | 09:37 | |
| stephenfin | gtema: Done | 10:01 |
| gtema | cool, thks | 10:01 |
| stephenfin | It's a -1 btw. I think some of the methods from the TagMixin don't work. Apologies if I've misunderstood something | 10:02 |
| gtema | no problem. For image I (I guess) it was not a complete TagMixin (some methods are also not existing) | 10:03 |
| gtema | need to think whether to override functions to raise NotImplemented or what else | 10:03 |
| stephenfin | Maybe we could split it into two mixins? | 10:03 |
| gtema | would affect lot's of other services | 10:03 |
| stephenfin | Oh yeah, that's mixin is pretty widely spread | 10:04 |
| stephenfin | Could split the query and body parameters part of the mixin into a new e.g. TagBodyMixin and have the existing TagMixin subclass that and add the methods. You could then use TagBodyMixin here | 10:06 |
| stephenfin | We could audit existing uses of TagMixin to make sure they all make sense | 10:06 |
| stephenfin | later, that is | 10:06 |
| gtema | except of image others seem to implement tagging properly | 10:06 |
| stephenfin | Yeah, I know nova does that properly | 10:07 |
| stephenfin | at least | 10:07 |
| gtema | network also | 10:07 |
| stephenfin | Would a separate subclass work so? TagBodyMixin isn't a great name. Maybe MinimalTagMixin or something better again | 10:08 |
| gtema | you propose separate query params and attributes from methods? | 10:08 |
| openstackgerrit | Stephen Finucane proposed openstack/openstacksdk master: Demonstrate separate tag mixin https://review.opendev.org/c/openstack/openstacksdk/+/770565 | 10:09 |
| stephenfin | yeah, like that ^ | 10:09 |
| stephenfin | tbc I still don't like the name 'MinimalTagMixin' but I can't think of anything better right now, but you get the idea | 10:10 |
| gtema | I would say in that case it is easier to manually use query params and attribute without really using mixin | 10:10 |
| stephenfin | That's fair. It doesn't really give us a lot | 10:10 |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Add query parameters to listing heat stacks https://review.opendev.org/c/openstack/openstacksdk/+/769484 | 10:17 |
| stephenfin | gtema: Do we add release notes for this kind of change? | 10:35 |
| gtema | not really | 10:35 |
| stephenfin | ack, +2 so | 10:35 |
| stephenfin | and +W | 10:35 |
| gtema | thks | 10:35 |
| gtema | what should we do with hypervisor patch and planned (2.88) changes? | 10:39 |
| stephenfin | well they're no longer planned - they're now merged | 10:40 |
| gtema | okay | 10:40 |
| stephenfin | so we could merge this as-is and then do a follow-up for 2.88 | 10:40 |
| stephenfin | or fix now | 10:40 |
| stephenfin | whatever suits you | 10:40 |
| *** dtantsur|afk is now known as dtantsur | 10:41 | |
| gtema | idea was to prepare SDK to finilaze OSC for hypervisors | 10:41 |
| gtema | so I think we can then spend some more time making SDK proper | 10:41 |
| gtema | I do not really like dropped functions | 10:41 |
| gtema | and uptime handling becomes really terrbile | 10:42 |
| gtema | I think we need to orient on 2.88 and drop things from OSC that are not there anymore | 10:44 |
| gtema | so complete disk and memory info about hypervisor disappears, right? | 10:45 |
| stephenfin | yes, all that info is gone | 10:45 |
| gtema | but we show it in OSC now | 10:45 |
| gtema | I would really just drop them from SDK/OSC not to have this mess | 10:46 |
| stephenfin | yeah, we'll just have to drop those fields | 10:46 |
| stephenfin | that's fine by me | 10:46 |
| stephenfin | it's bad info | 10:46 |
| gtema | yupp | 10:46 |
| gtema | statistics go away also? | 10:47 |
| stephenfin | yes, for the same reason (bad info) | 10:47 |
| gtema | ok | 10:47 |
| gtema | dropping code is fun from that perspective | 10:47 |
| gtema | how do we want to treat uptime: fetch automatically if under 2.88 or leave it optionally to user? | 10:50 |
| stephenfin | I think leave it optional | 10:51 |
| gtema | ok, agree | 10:51 |
| *** ysandeep is now known as ysandeep|afk | 11:04 | |
| *** udesale has quit IRC | 11:07 | |
| *** BakaKuna has joined #openstack-sdks | 11:16 | |
| *** udesale has joined #openstack-sdks | 11:17 | |
| openstackgerrit | Stephen Finucane proposed openstack/os-client-config stable/train: Uncap jsonschema https://review.opendev.org/c/openstack/os-client-config/+/770598 | 11:19 |
| *** sshnaidm|afk is now known as sshnaidm|ruck | 11:19 | |
| stephenfin | dtantsur: gtema: yet another pip 20.3 fix there ^ | 11:19 |
| gtema | done | 11:20 |
| stephenfin | thanks | 11:20 |
| stephenfin | we can recheck https://review.opendev.org/c/openstack/openstacksdk/+/767526 once that merges | 11:20 |
| gtema | yes | 11:20 |
| openstackgerrit | Stephen Finucane proposed openstack/os-client-config stable/stein: Uncap jsonschema https://review.opendev.org/c/openstack/os-client-config/+/770599 | 11:22 |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Complete compute.hypervisor functions https://review.opendev.org/c/openstack/openstacksdk/+/763202 | 11:32 |
| openstackgerrit | Takashi Kajinami proposed openstack/python-openstackclient master: Volume type: Update is_public attribute https://review.opendev.org/c/openstack/python-openstackclient/+/768800 | 11:48 |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Complete compute.hypervisor functions https://review.opendev.org/c/openstack/openstacksdk/+/763202 | 11:50 |
| *** mgariepy has quit IRC | 12:04 | |
| *** jpich has quit IRC | 12:19 | |
| *** jpich has joined #openstack-sdks | 12:19 | |
| *** jpich has quit IRC | 12:40 | |
| *** jpich has joined #openstack-sdks | 12:41 | |
| *** brinzhang has quit IRC | 13:11 | |
| *** brinzhang has joined #openstack-sdks | 13:11 | |
| openstackgerrit | Jakob Meng proposed openstack/ansible-collections-openstack master: Fix volume_info result for SDK < 0.19 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770267 | 13:18 |
| *** mgariepy has joined #openstack-sdks | 13:21 | |
| *** udesale has quit IRC | 13:25 | |
| *** ysandeep|afk is now known as ysandeep | 13:25 | |
| *** Hybrid512 has joined #openstack-sdks | 13:34 | |
| *** jpich has quit IRC | 13:34 | |
| *** jpich has joined #openstack-sdks | 13:35 | |
| *** nikparasyr has left #openstack-sdks | 13:41 | |
| *** whoami-rajat__ has joined #openstack-sdks | 13:46 | |
| *** enriquetaso has joined #openstack-sdks | 14:01 | |
| *** udesale has joined #openstack-sdks | 14:04 | |
| gtema | dtantsur, stephenfin, slaweq, what do you think of dropping support for compute networking from SDK now. I am reworking cloud layer networking functions and nova there is disturbing a lot | 15:00 |
| dtantsur | has it been dropped from nova already? | 15:00 |
| gtema | we passed Ussuri (where Nova dropped support for it) | 15:00 |
| dtantsur | ahh | 15:00 |
| dtantsur | so it affects Train and older (potentially)? | 15:01 |
| *** udesale has quit IRC | 15:01 | |
| gtema | seems to be so | 15:01 |
| gtema | I am not sure somebody was recently using it in cloud layer at all | 15:01 |
| gtema | "These will fail with a 404 starting from microversion 2.36. They were removed in the 21.0.0 (Ussuri) release." | 15:02 |
| gtema | mordred, not sure whether you are here, if yes - ^^ | 15:04 |
| mordred | I'm pretty sure we still use nova-network calls for rackspace | 15:06 |
| mordred | I mean - it's not actually calls ... but the server network info dict is the nova version iirc | 15:06 |
| gtema | really? Oh that's sad | 15:06 |
| mordred | but yeah - I'm not sure who out there might still be running an older cloud, but the theory at least was that things should still work | 15:07 |
| mordred | THAT SAID | 15:07 |
| gtema | that's around 1500 loc, that nobody else is really using | 15:07 |
| mordred | yeah - there's a bunch in here that's essentially in support of rackspace that I kept wanting to come up with a plan for dealing with better | 15:08 |
| gtema | perhaps we can move it similarly to what I do for my cloud with profile? | 15:08 |
| mordred | it made more sense when there were two clouds and one of them was rackspace | 15:08 |
| slaweq | gtema: I'm ok with that, I think nova already removed all of that | 15:08 |
| mordred | yeah - that's sort of what I was thinking | 15:08 |
| mordred | make a rackspace plugin essentially | 15:09 |
| mordred | except - doing the work for that would be tricky - especially because of the cloud-layer fallback logic | 15:09 |
| gtema | mordred: https://github.com/opentelekomcloud/python-otcextensions/blob/master/otcextensions/sdk/__init__.py that's kind of initialization hack that I do | 15:09 |
| gtema | when the package is present and in clouds.yaml there is profile: otc - it get's injected and override some things | 15:10 |
| mordred | it might be more work to engiineer a good plugin layer that can handle the current use cases than to just maintian the existing code | 15:10 |
| mordred | yeah. trickiest part is not breaking the opendev nodepool while doing the work :) | 15:10 |
| gtema | at least according to https://graphite.opendev.org/ nova/os-floating-ip seem to be the only used stuff | 15:12 |
| gtema | networking comes from network | 15:12 |
| gtema | (whether it all reliable source of truth) | 15:12 |
| mordred | oh - you're mostly talking about the actual network calls, like list networks, list routers, etc? | 15:12 |
| gtema | pretty much everything in cloud | 15:13 |
| mordred | the nova-network related paths in cloud layer that are important are the things in meta - like get_server_external_ipv4 and the things its calls | 15:13 |
| gtema | disturbing thing is that normally we would invoke network.find_subnet, but currently we mostly go through complete list | 15:13 |
| mordred | I don't think any of that actually calls nova net endpoints | 15:13 |
| mordred | yah - we do full lists so that the caching works better and it's not a thundering herd in nodepool | 15:14 |
| mordred | one thread calling list subnets once and caching it and 1000 threads doing a lookup in the list rather than 1000 threads doing find_subnet | 15:15 |
| gtema | ugh | 15:16 |
| mordred | which for some of the thigns (liek servers) it could totally work to just move into the nodepool openstack driver - but for the stuff in meta it's called behind the scenes - so it's hard to defer the batching logic to nodepool | 15:16 |
| mordred | yeah. sorry - this is the area where the most complex use cases lurk | 15:16 |
| gtema | which meta exactly you mean? | 15:17 |
| mordred | basically anything that touches openstack.cloud.meta is a potential nightmare to change | 15:17 |
| gtema | ah, yes | 15:17 |
| gtema | okay. Then it is clear that we can't drop it without leaving backup for Rack (nodepool) | 15:18 |
| mordred | that said - it almost certainly _should_ get reworked - it's carrying too much complexity on its shoulders. but - it's carrying too much complexity on its shoulders so reworking it without major breakages will be "fun" | 15:18 |
| gtema | makes my night complex | 15:18 |
| * mordred hands gtema a few beers | 15:18 | |
| gtema | yeah, I liked US beers | 15:19 |
| mordred | remember when we could sit down an have a beer in the same room? | 15:23 |
| gtema | puh, when can this happen again | 15:23 |
| mordred | you can visit new orleans and we can have beers outside - but then you might not be allowed back in germany | 15:25 |
| gtema | yupp ;-) | 15:25 |
| gtema | listing functions in cloud layer already return empty lists for nova case | 15:26 |
| *** ricolin has quit IRC | 15:38 | |
| *** ricolin has joined #openstack-sdks | 15:47 | |
| gtema | I doubt "filters" in calls like get_subnet where name_or_id is always present are making any sense | 15:49 |
| gtema | am I missing something? | 15:50 |
| openstackgerrit | Lee Yarwood proposed openstack/openstacksdk stable/train: Fix aggregate functional test for id restriction https://review.opendev.org/c/openstack/openstacksdk/+/767526 | 15:51 |
| mordred | filters can additionally filter - for cases where the only thing that's passed to name_or_id is name? | 15:52 |
| mordred | (subnet names are not guaranteed to be unique iirc) | 15:52 |
| gtema | aaah, right | 15:52 |
| dtantsur | beers with people.. I seem to be vaguely remembering.. | 15:53 |
| openstackgerrit | Stephen Finucane proposed openstack/os-client-config stable/train: Uncap jsonschema https://review.opendev.org/c/openstack/os-client-config/+/770598 | 15:58 |
| *** ysandeep is now known as ysandeep|out | 16:12 | |
| *** khomesh24 has quit IRC | 16:16 | |
| *** mgariepy has quit IRC | 16:20 | |
| *** khomesh24 has joined #openstack-sdks | 16:31 | |
| *** slaweq has quit IRC | 16:34 | |
| *** slaweq has joined #openstack-sdks | 16:36 | |
| *** tosky has quit IRC | 16:41 | |
| *** tosky has joined #openstack-sdks | 16:42 | |
| *** khomesh24 has quit IRC | 17:08 | |
| *** mgariepy has joined #openstack-sdks | 17:20 | |
| *** jpich has quit IRC | 17:22 | |
| *** Hybrid512 has quit IRC | 17:27 | |
| *** sshnaidm|ruck is now known as sshnaidm|afk | 17:30 | |
| *** gtema has quit IRC | 17:46 | |
| stephenfin | dtantsur: If you're still about, could you push this through? gtema approved earlier but there were more issues https://review.opendev.org/c/openstack/os-client-config/+/770598 | 17:50 |
| stephenfin | CI is green now | 17:50 |
| * dtantsur looks | 17:50 | |
| *** rpittau is now known as rpittau|afk | 18:05 | |
| *** gtema has joined #openstack-sdks | 18:08 | |
| *** ralonsoh has quit IRC | 18:20 | |
| *** dtantsur is now known as dtantsur|afk | 18:43 | |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Switch networking function in cloud layer to proxy https://review.opendev.org/c/openstack/openstacksdk/+/766783 | 18:59 |
| *** gtema has quit IRC | 18:59 | |
| openstackgerrit | Merged openstack/os-client-config stable/train: Uncap jsonschema https://review.opendev.org/c/openstack/os-client-config/+/770598 | 19:43 |
| *** whoami-rajat__ has quit IRC | 19:55 | |
| *** nightmare_unreal has quit IRC | 20:16 | |
| *** slaweq has quit IRC | 20:41 | |
| *** BakaKuna has quit IRC | 22:52 | |
| *** brinzhang_ has joined #openstack-sdks | 23:02 | |
| *** brinzhang has quit IRC | 23:05 | |
| rm_work | anyone here familiar with gophercloud + openstack? would love to snipe someone for just a minute to ask a couple questions about passing mTLS data with connections | 23:38 |
| mordred | rm_work: I know that it exists and people use it | 23:55 |
| rm_work | :P | 23:56 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!