| *** dave-mccowan has quit IRC | 00:08 | |
| *** dave-mccowan has joined #openstack-sdks | 00:10 | |
| *** tkajinam has joined #openstack-sdks | 01:13 | |
| *** evrardjp has quit IRC | 02:33 | |
| *** evrardjp has joined #openstack-sdks | 02:33 | |
| openstackgerrit | 江治林 proposed openstack/keystoneauth master: setup.cfg: Replace dashes with underscores https://review.opendev.org/c/openstack/keystoneauth/+/789699 | 02:45 |
|---|---|---|
| openstackgerrit | 江治林 proposed openstack/keystoneauth master: setup.cfg: Replace dashes with underscores https://review.opendev.org/c/openstack/keystoneauth/+/789699 | 02:46 |
| *** enriquetaso has quit IRC | 03:26 | |
| *** ralonsoh has joined #openstack-sdks | 06:11 | |
| *** whoami-rajat has joined #openstack-sdks | 06:18 | |
| *** slaweq has joined #openstack-sdks | 06:26 | |
| openstackgerrit | YuehuiLei proposed openstack/python-openstackclient master: setup.cfg: Replace dashes with underscores https://review.opendev.org/c/openstack/python-openstackclient/+/789710 | 06:58 |
| *** rpittau|afk is now known as rpittau | 07:12 | |
| *** gtema has joined #openstack-sdks | 07:14 | |
| *** tosky has joined #openstack-sdks | 07:30 | |
| *** gtema has quit IRC | 07:45 | |
| *** jpich has joined #openstack-sdks | 07:54 | |
| *** LinPeiWen has joined #openstack-sdks | 07:57 | |
| *** gtema has joined #openstack-sdks | 07:59 | |
| *** ysandeep is now known as ysandeep|lunch | 08:28 | |
| *** Hybrid512 has joined #openstack-sdks | 08:39 | |
| *** dtantsur|afk is now known as dtantsur | 09:21 | |
| frickler | this looks like a regression in glance to me, not like an issue with osc https://zuul.opendev.org/t/openstack/build/5811986c8be64dab843a1871773a030d | 09:41 |
| *** udesale has joined #openstack-sdks | 09:45 | |
| *** holser has joined #openstack-sdks | 09:49 | |
| *** ysandeep|lunch is now known as ysandeep | 10:10 | |
| *** LinPeiWen has quit IRC | 10:20 | |
| *** sshnaidm|afk is now known as sshnaidm | 10:34 | |
| *** tosky has quit IRC | 10:38 | |
| *** tosky has joined #openstack-sdks | 10:38 | |
| *** nightmare_unreal has joined #openstack-sdks | 10:43 | |
| *** tosky_ has joined #openstack-sdks | 10:45 | |
| *** tosky has quit IRC | 10:47 | |
| *** tosky_ is now known as tosky | 10:49 | |
| openstackgerrit | Merged openstack/openstacksdk stable/wallaby: Increase RAM for the Ironic CI jobs https://review.opendev.org/c/openstack/openstacksdk/+/789439 | 11:01 |
| *** mgariepy has quit IRC | 11:08 | |
| *** jpich has quit IRC | 11:29 | |
| *** jpich has joined #openstack-sdks | 11:30 | |
| openstackgerrit | Artem Goncharov proposed openstack/ansible-collections-openstack master: Switch project and project_info module to OpenStackModule https://review.opendev.org/c/openstack/ansible-collections-openstack/+/789793 | 11:34 |
| *** artom has quit IRC | 11:40 | |
| openstackgerrit | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: WIP add TripleO job on collections used in TripleO https://review.opendev.org/c/openstack/ansible-collections-openstack/+/789818 | 11:49 |
| *** Luzi has joined #openstack-sdks | 12:00 | |
| *** mgariepy has joined #openstack-sdks | 12:13 | |
| *** jpich has quit IRC | 12:15 | |
| *** jpich has joined #openstack-sdks | 12:16 | |
| *** enriquetaso has joined #openstack-sdks | 12:52 | |
| frickler | gtema: noonedeadpunk: actually https://review.opendev.org/c/openstack/openstacksdk/+/783849 is causing the above regression, seems it was a mistake to ignore the failing osc job, sadly logs have already expired | 12:54 |
| frickler | also not sure if you can find a quick fix or want to revert first | 12:54 |
| gtema | not that I understand why it is causing this | 12:57 |
| noonedeadpunk | this one https://review.opendev.org/c/openstack/openstacksdk/+/783849/2/openstack/image/v2/image.py | 12:57 |
| noonedeadpunk | so yeah, might be worth at least partially reverting it... | 12:57 |
| noonedeadpunk | or at least really quick fix | 12:58 |
| gtema | someone show me logs where it fails? | 12:59 |
| gtema | I was not really looking into the discussion recently | 12:59 |
| noonedeadpunk | It tries to ` tempest.lib.exceptions.CommandFailed: Command 'openstack --os-cloud=devstack-admin image list --tag my_tag --long -f json' returned non-zero exit status 1.` | 12:59 |
| gtema | I need to see API call | 13:01 |
| noonedeadpunk | well with patch I renamed option I gues :((( | 13:02 |
| noonedeadpunk | I jsut kind of assumed, that it can't be used since it's not really working properly | 13:04 |
| openstackgerrit | Dmitriy Rabotyagov proposed openstack/openstacksdk master: Revert tags option back to tag https://review.opendev.org/c/openstack/openstacksdk/+/789827 | 13:05 |
| noonedeadpunk | not super sure about that though ^ | 13:05 |
| noonedeadpunk | I don't think it even comes to API call | 13:06 |
| gtema | noho, the fix should be in https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/image/v2/image.py#L613 | 13:06 |
| noonedeadpunk | it fails just on running openstack as unknown option is passed | 13:06 |
| gtema | compare with https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/image/v2/image.py#L323 | 13:07 |
| gtema | this should be also constructing array of tags | 13:07 |
| frickler | hmm, for list-image, the filter is called "tag", but for show-image, a "tags" field is returned https://docs.openstack.org/api-ref/image/v2/index.html?expanded=list-images-detail,show-image-detail#list-images | 13:07 |
| noonedeadpunk | oh, well, I think you're right gtema | 13:08 |
| noonedeadpunk | frickler: well, you can use --tag several times, right? | 13:08 |
| gtema | noonedeadpunk - will you prepare change or should I? | 13:08 |
| gtema | yes - you should be able to have same interface of repeating multiple --tag | 13:09 |
| noonedeadpunk | doesn't matter for me:) | 13:09 |
| noonedeadpunk | probably to merge things faster (in terms of self vote) I can push it | 13:09 |
| gtema | if you have time - please, I'm pretty overloaded right now | 13:09 |
| *** jpich has quit IRC | 13:23 | |
| *** jpich has joined #openstack-sdks | 13:23 | |
| noonedeadpunk | sure, testing it :) | 13:27 |
| gtema | thks | 13:27 |
| *** efried has joined #openstack-sdks | 13:33 | |
| noonedeadpunk | gtema: nah, I was right with https://review.opendev.org/c/openstack/openstacksdk/+/789827 | 13:40 |
| gtema | why? | 13:40 |
| noonedeadpunk | as with your suggestion sdk sends request /v2/images?tags=openstack | 13:40 |
| *** artom has joined #openstack-sdks | 13:41 | |
| noonedeadpunk | and glance list api has only tag | 13:41 |
| noonedeadpunk | while create is tags | 13:41 |
| noonedeadpunk | https://docs.openstack.org/api-ref/image/v2/index.html?expanded=list-images-detail,create-image-detail#id10 | 13:41 |
| gtema | oh thats not cool | 13:42 |
| noonedeadpunk | so there's kind of inconsistency in glance itself I really skipped | 13:42 |
| gtema | and what if we pass array of tags as "tag" into SDK. What does it send to glance? I roughly remenber some other case | 13:43 |
| gtema | where we need to send same attirbute multiple times, but I can't recall where it was | 13:44 |
| noonedeadpunk | it's sending only last mentioned one | 13:44 |
| noonedeadpunk | ie `openstack image list --tag openstack --tag test ` ends up in `/v2/images?tag=test` | 13:44 |
| noonedeadpunk | but maybe we can make it list... not sure | 13:45 |
| gtema | there is way, I'm searching | 13:45 |
| noonedeadpunk | Yeah, I think we can just change to append here | 13:45 |
| noonedeadpunk | https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/image/v2/image.py#L612-L616 | 13:46 |
| noonedeadpunk | will produce /v2/images?tag=openstack&tag=test | 13:47 |
| gtema | that's what I meant, but exactly here I'm not sure how SDK passes this to glance | 13:47 |
| noonedeadpunk | doh. indeed | 13:49 |
| noonedeadpunk | reverting like 789827 breaks image update... | 13:51 |
| openstackgerrit | Dmitriy Rabotyagov proposed openstack/openstacksdk master: Revert tags option back to tag https://review.opendev.org/c/openstack/openstacksdk/+/789827 | 13:53 |
| openstackgerrit | Dmitriy Rabotyagov proposed openstack/python-openstackclient master: Allow to filter multiple tags for image list https://review.opendev.org/c/openstack/python-openstackclient/+/789838 | 13:59 |
| *** Luzi has quit IRC | 13:59 | |
| *** LinPeiWen has joined #openstack-sdks | 14:08 | |
| *** efried has quit IRC | 14:21 | |
| nightmare_unreal | https://www.irccloud.com/pastebin/1JKwl1hg/ | 14:23 |
| *** efried has joined #openstack-sdks | 14:25 | |
| openstackgerrit | Dmitriy Rabotyagov proposed openstack/openstacksdk master: Revert tags option back to tag https://review.opendev.org/c/openstack/openstacksdk/+/789827 | 14:28 |
| openstackgerrit | Dmitriy Rabotyagov proposed openstack/openstacksdk master: Revert tags query_params back to tag https://review.opendev.org/c/openstack/openstacksdk/+/789827 | 14:29 |
| *** efried has quit IRC | 14:41 | |
| *** efried has joined #openstack-sdks | 14:41 | |
| *** LinPeiWen has quit IRC | 14:46 | |
| *** mgariepy has quit IRC | 15:14 | |
| openstackgerrit | Artem Goncharov proposed openstack/ansible-collections-openstack master: Switch project and project_info module to OpenStackModule https://review.opendev.org/c/openstack/ansible-collections-openstack/+/789793 | 15:20 |
| *** ysandeep is now known as ysandeep|away | 15:27 | |
| openstackgerrit | Dmitriy Rabotyagov proposed openstack/python-openstackclient master: Allow to filter multiple tags for image list https://review.opendev.org/c/openstack/python-openstackclient/+/789838 | 15:30 |
| *** udesale has quit IRC | 15:30 | |
| openstackgerrit | Dmitriy Rabotyagov proposed openstack/python-openstackclient master: Allow to filter multiple tags for image list https://review.opendev.org/c/openstack/python-openstackclient/+/789838 | 15:33 |
| openstackgerrit | Dmitriy Rabotyagov proposed openstack/python-openstackclient master: Allow to filter multiple tags for image list https://review.opendev.org/c/openstack/python-openstackclient/+/789838 | 15:37 |
| *** mgariepy has joined #openstack-sdks | 15:46 | |
| *** rpittau is now known as rpittau|afk | 15:52 | |
| *** jpich has quit IRC | 16:22 | |
| openstackgerrit | Artem Goncharov proposed openstack/ansible-collections-openstack master: Switch project and project_info module to OpenStackModule https://review.opendev.org/c/openstack/ansible-collections-openstack/+/789793 | 16:33 |
| *** gtema has quit IRC | 16:37 | |
| *** dtantsur is now known as dtantsur|afk | 16:38 | |
| openstackgerrit | Dmitriy Rabotyagov proposed openstack/python-openstackclient master: Allow to filter multiple tags for image list https://review.opendev.org/c/openstack/python-openstackclient/+/789838 | 16:57 |
| *** enriquetaso has quit IRC | 17:02 | |
| *** enriquetaso has joined #openstack-sdks | 17:02 | |
| *** ralonsoh has quit IRC | 17:36 | |
| *** knikolla has joined #openstack-sdks | 18:11 | |
| *** gtema has joined #openstack-sdks | 18:38 | |
| *** gtema has quit IRC | 18:42 | |
| *** Jeffrey4l has quit IRC | 18:44 | |
| *** Jeffrey4l has joined #openstack-sdks | 18:47 | |
| *** nightmare_unreal has quit IRC | 19:22 | |
| *** slaweq has quit IRC | 20:10 | |
| *** holser has quit IRC | 22:33 | |
| *** tosky has quit IRC | 23:03 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!