| gshippey | any possibility on getting feedback on https://review.opendev.org/c/openstack/openstacksdk/+/799508? Looking to add support for keystone service providers, first time contributing to this project | 15:09 |
|---|---|---|
| gouthamr | gtema diablo_rojo_phone: have you folks had any further thoughts on adding one/more manila reviewers? | 17:00 |
| gtema | Guys, you need to start reviewing patches yourself. If we add you as reviewers, but you do not review - why's that? | 17:01 |
| gtema | From manilla patches only one was reviewed by you | 17:01 |
| gouthamr | gtema: ? sorry, i perhaps missed review notifications | 17:03 |
| gtema | From around 10 manila patches only one was finally approved by you. Others had some iterations, but are now not reviewed | 17:04 |
| gouthamr | yes | 17:04 |
| gtema | And this is normally a signal for me when I see you approve the patch | 17:04 |
| gouthamr | i've been looking at these; i can add my comments there | 17:04 |
| gouthamr | so if you see a +1 from one of us, you're looking to treat that as a +2? | 17:08 |
| gouthamr | i'm okay with that - just want to know what the operating procedure should be around here :) | 17:09 |
| gouthamr | i'd love to see https://review.opendev.org/c/openstack/openstacksdk/+/796040 merge for one - its been worked on for a while | 17:10 |
| gouthamr | gtema: hey you might know the answer to my prior queries to this channel - i'd like to specify a microversion for a particular SDK call; is this possible today? | 17:41 |
| gouthamr | i tried doing something like this: https://review.opendev.org/c/openstack/openstacksdk/+/799208/2/openstack/tests/functional/shared_file_system/base.py | 17:41 |
| gouthamr | but it didn't seem to have an effect | 17:41 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!