| thomasb06 | gtema: hello. Did you find something for me to do? (hehe...) | 06:21 |
|---|---|---|
| gtema | Yes, yesterday evening I wrote here | 06:22 |
| gtema | Can you see history? | 06:22 |
| thomasb06 | arg, I haven't a bouncer yet... By the way, if you have a link on how to set up one, I'm interested | 06:23 |
| gtema | https://meetings.opendev.org/irclogs/%23openstack-sdks/%23openstack-sdks.2021-09-02.log.html | 06:25 |
| gtema | But generally - install matrix client (i.e. Element) and enter this room through irc bridge | 06:25 |
| thomasb06 | got it, thank you | 06:25 |
| gtema | https://github.com/matrix-org/matrix-appservice-irc/wiki/Bridged-IRC-networks | 06:26 |
| gtema | This is really the best way for staying connected (for those not grown up in IRC age;-) | 06:27 |
| thomasb06 | great, I'll give it a try | 06:30 |
| gtema | Cool | 06:30 |
| thomasb06 | what about https://x0.at/OYEh.txt ? | 06:42 |
| gtema | almost | 06:43 |
| gtema | you still should have exception handling block to prevent that the key (alternate_id) is known, but attribute is still missing | 06:44 |
| gtema | we can potentially try elif ... return self._body.get(key) - this is kinda exception handling | 06:45 |
| gtema | and also, I would potentially try to get _alternate_id() first not to invoke it 2 times | 06:46 |
| thomasb06 | do we have a Walrus operator: https://x0.at/-qjT.txt | 06:58 |
| thomasb06 | ? | 06:58 |
| gtema | you can always try if you not sure | 08:14 |
| gtema | our jobs will run all required tests with multiple py versions and you will see whether something is not working in particular py version | 08:15 |
| thomasb06 | ok, this afternoon I'll commit the modification. What I need to do is clone the sdk repo and activate gerrit in it: https://opendev.org/openstack/openstacksdk.git ? | 08:25 |
| gtema | yes, but please remember - try to make change for feature/r1 branch | 08:28 |
| gtema | if doesn't work - do in master | 08:29 |
| thomasb06 | if I remember well, the command to switch branch is `git checkout feature/r1` ? Option -b is when the branch doesn't exists but it's not the case: https://opendev.org/openstack/openstacksdk/src/branch/feature/r1 | 08:35 |
| gtema | right. You might try to do `git checkout origin/feature/r1` | 08:36 |
| gtema | I remember there was a challenge, but do not remember how exactly I managed this | 08:36 |
| thomasb06 | it said: «HEAD is now at ed63ed6e Merge "Vpn ike policy resource" into feature/r1» | 08:38 |
| gtema | good | 08:38 |
| thomasb06 | sent: https://review.opendev.org/c/openstack/openstacksdk/+/807274 | 08:51 |
| gtema | Good. Now you can sit and relay waiting for the results (up to 2 hours, since we have really lots of jobs) | 08:51 |
| thomasb06 | cool. Time to go for my meal then | 08:52 |
| gtema | and prepare to rework you change by changing commit message renaming it and giving reasonable description of the change | 08:52 |
| gtema | enjoy | 08:52 |
| thomasb06 | ah, of course... Until now, I've only made commits to training repos | 08:53 |
| gtema | yupp | 08:53 |
| gtema | remember to use `git commit --amend` not to produce new change | 08:54 |
| thomasb06 | ok, I didn't now this command. The manual says it's like a reset and commit -c combined | 09:00 |
| gtema | no - this is "rewrite last commit" | 09:01 |
| opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | 09:49 |
| thomasb06 | gtema: the operator `:=` doesn't work but with a key it went well: https://review.opendev.org/c/openstack/openstacksdk/+/807334 | 21:05 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!