| *** gmann is now known as gmann_afk | 00:07 | |
| *** gmann_afk is now known as gmann | 01:11 | |
| *** frickler_ is now known as frickler | 07:25 | |
| opendevreview | Alexandru Verdes proposed openstack/ansible-collections-openstack master: Add client and member listener timeouts for persistence (Ex. SSH) https://review.opendev.org/c/openstack/ansible-collections-openstack/+/812110 | 08:59 |
|---|---|---|
| opendevreview | Alexandru Verdes proposed openstack/ansible-collections-openstack master: Add client and member listener timeouts for persistence (Ex. SSH) https://review.opendev.org/c/openstack/ansible-collections-openstack/+/812110 | 09:17 |
| noonedeadpunk | hey! I was wondering if there's any good way to import one of the commands to reuse code inside other one? I guess no? | 14:57 |
| noonedeadpunk | regsarding openstackclient | 14:57 |
| gtema | can you be please more precise with your example? what are you thinking of? | 14:58 |
| noonedeadpunk | So, I'm trying to write host-evacuate command for openstackclient. And what I;d ove to do is re-use https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/compute/v2/server.py#L3458 | 15:03 |
| noonedeadpunk | But I guess I can't do that? | 15:03 |
| noonedeadpunk | so the way would be copy/pasting code? Which I'd hate doing... | 15:03 |
| gtema | reuse in the sense of a complete copy or only parts? | 15:04 |
| noonedeadpunk | I guess that was kind of reason why it hasn't been implemented yet... | 15:05 |
| noonedeadpunk | complete copy but pass different parsed_args | 15:05 |
| gtema | and what about the action itself? it currently invoke server.evacuate(xx) | 15:06 |
| noonedeadpunk | yeah, it will be the same. So host evacuate is basically retrieves all servers for hypervisors and iterate on them | 15:07 |
| noonedeadpunk | ie https://github.com/openstack/python-novaclient/blob/8066f8c745054caeb7bd66d4c2be15ab5fac1d1f/novaclient/v2/shell.py#L5190-L5199 | 15:07 |
| gtema | but it is the still not really same. I would suggest just move evacuate implementation into helper function | 15:08 |
| gtema | so that you can also iterate and invoke it | 15:08 |
| *** artom_ is now known as artom | 15:13 | |
| noonedeadpunk | Sounds reasonable. And can you kindly point to some helper sample? Can find quickly in tree. Or they are osc_lib or somewhere? | 15:13 |
| gtema | https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/common/sdk_utils.py | 15:14 |
| gtema | whatever is currently in common | 15:14 |
| gtema | but I would rather simply have something in the compute part | 15:14 |
| gtema | https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/network/common.py | 15:14 |
| noonedeadpunk | yeah, great, thanks! | 15:16 |
| opendevreview | Merged openstack/osc-lib stable/xena: Update .gitreview for stable/xena https://review.opendev.org/c/openstack/osc-lib/+/808361 | 18:23 |
| opendevreview | Merged openstack/osc-lib stable/xena: Update TOX_CONSTRAINTS_FILE for stable/xena https://review.opendev.org/c/openstack/osc-lib/+/808362 | 18:23 |
| -opendevstatus- NOTICE: The review.opendev.org Gerrit server has become unreachable as of approximately 19:10 UTC due to a networking issue in the provider, but should be reachable again shortly | 19:45 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!