opendevreview | Suneeth Ravi proposed openstack/python-openstackclient master: Switch server lock to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/819517 | 01:38 |
---|---|---|
opendevreview | Suneeth Ravi proposed openstack/python-openstackclient master: Switch server lock to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/819517 | 02:59 |
stephenfin | gtema: Got a few +W opportunities for you https://review.opendev.org/c/openstack/python-openstackclient/+/815913 https://review.opendev.org/c/openstack/python-openstackclient/+/817860 https://review.opendev.org/c/openstack/python-openstackclient/+/817853 | 11:13 |
gtema | ack | 11:13 |
gtema | thks | 11:13 |
opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: DNM: Deprecate "force" behavior for network quotas https://review.opendev.org/c/openstack/python-openstackclient/+/819627 | 11:30 |
stephenfin | ralonsoh: wdyt? ^ If you agree with that approach, feel free to squash it into your patch. If not, that's fine also 0:) I just think it would be nice to _eventually_ harmonize behaviour, even if that takes a year or two | 11:31 |
ralonsoh | stephenfin, I'm Ok but not the community | 11:32 |
ralonsoh | I don't think Neutron will accept this | 11:32 |
ralonsoh | the want the current behaviour ("force" implicitly specified) | 11:32 |
ralonsoh | in any case, I can propose it | 11:33 |
ralonsoh | but I already had this conversation several times | 11:33 |
stephenfin | Oh, really? That seems odd considering the server behaviour isn't changed and there's going to be a long deprecation period proposed for the OSC change | 11:34 |
stephenfin | Ack, yeah I'm aware you've been through the wars on this and am reluctant to bikeshed too much, but once an option is there it's very hard to remove it again so I want to be _really_ sure :) | 11:34 |
ralonsoh | I can propose this change in the Neutron drivers meeting | 11:34 |
stephenfin | cool, let me know if you need anything from me | 11:35 |
*** tosky is now known as Guest7142 | 13:37 | |
*** tosky_ is now known as tosky | 13:37 | |
opendevreview | Merged openstack/python-openstackclient master: Switch server image create to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/815913 | 13:38 |
opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | 13:46 |
isabek | Hi stephenfin ! I have updated my patch. Should I wait for sdk patch when it will be landed to master branch? or first leave what was before? https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | 14:07 |
opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch openstack server remove port/network to using sdk https://review.opendev.org/c/openstack/python-openstackclient/+/817838 | 14:31 |
opendevreview | Suneeth Ravi proposed openstack/python-openstackclient master: Switch server lock to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/819517 | 14:58 |
stephenfin | isabek: Yeah, you'll have to wait for that patch to land on master and a new release be cut before you can merge that, I'm afraid | 15:05 |
isabek | stephenfin: Thanks! When it planned to land r1 to master? | 15:08 |
stephenfin | isabek: I'm not sure. Does that patch cherry-pick cleanly to master? | 15:15 |
isabek | stephenfin: Patch on master is abandoned. Now patch is now on feature r1 branch https://review.opendev.org/c/openstack/openstacksdk/+/814765 | 15:17 |
stephenfin | isabek: Right, yes. My question is once it's landed on feature/r1, you can cherry-pick back to master to get it released faster | 15:21 |
stephenfin | isabek: You can cherry-pick the following three changes to get it released sooner: 1909df1f4219fbf2a1bb0f9ba087ef39758ffded 93f69e42f125fb87c3269881509b3913b9374f34 f5b60d2b03e611854822f17bd5487d322ca0b71f | 15:24 |
stephenfin | isabek: cherry-pick those and propose them to master and we can merge and cut a new release (cc gtema) | 15:25 |
isabek | stephenfin: Thank you! I will do it right now | 15:25 |
opendevreview | Mamatisa Nurmatov proposed openstack/openstacksdk master: Vpn ike policy resource https://review.opendev.org/c/openstack/openstacksdk/+/819585 | 15:26 |
stephenfin | isabek: Maybe drop the '-x' option | 15:28 |
stephenfin | given this isn't really a "backport" | 15:28 |
stephenfin | (i.e. the thing that adds the "cherry picked from" lines) | 15:28 |
isabek | stephenfin: I cherry picked from UI, should i drop commit message? | 15:30 |
isabek | * drop from commit message | 15:30 |
stephenfin | yes | 15:33 |
stephenfin | fwiw, it would be easier to do this locally since you've got to stack a few changes | 15:33 |
opendevreview | Mamatisa Nurmatov proposed openstack/openstacksdk master: Splits class `TestNetworkProxy` https://review.opendev.org/c/openstack/openstacksdk/+/819586 | 15:33 |
stephenfin | They need to be stacked on top of each other in the order I indicated above | 15:34 |
stephenfin | otherwise you'll get the merge conflicts you're seeing at https://review.opendev.org/c/openstack/openstacksdk/+/819586 | 15:34 |
isabek | Sorry, you mean as related patches? | 15:35 |
isabek | Yes there merge conflicts now | 15:35 |
stephenfin | git checkout master | 15:35 |
stephenfin | git reset --hard origin/master | 15:35 |
stephenfin | git checkout -b bug/1930200 | 15:36 |
stephenfin | git cherry-pick 1909df1f4219fbf2a1bb0f9ba087ef39758ffded | 15:36 |
stephenfin | git cherry-pick 93f69e42f125fb87c3269881509b3913b9374f34 | 15:36 |
stephenfin | git cherry-pick f5b60d2b03e611854822f17bd5487d322ca0b71f | 15:36 |
stephenfin | git review -fy | 15:36 |
stephenfin | ^ that | 15:36 |
stephenfin | or something similar | 15:36 |
isabek | :-) ok I will do it | 15:36 |
isabek | Should I abandon that cherrypicked patches first? | 15:37 |
stephenfin | nope, they'll be updated when you push the local changes (since there's the same Change ID) | 15:37 |
opendevreview | Mamatisa Nurmatov proposed openstack/openstacksdk master: Vpn ike policy resource https://review.opendev.org/c/openstack/openstacksdk/+/819585 | 15:43 |
opendevreview | Mamatisa Nurmatov proposed openstack/openstacksdk master: Splits class `TestNetworkProxy` https://review.opendev.org/c/openstack/openstacksdk/+/819586 | 15:43 |
opendevreview | Mamatisa Nurmatov proposed openstack/openstacksdk master: Add Neutron Local IP CRUD https://review.opendev.org/c/openstack/openstacksdk/+/804988 | 15:43 |
opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | 15:44 |
isabek | stephenfin: Thanks a lot! | 15:46 |
opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | 15:50 |
opendevreview | Manuel Holtgrewe proposed openstack/ansible-collections-openstack master: Adding "files/config_drive_files" to server module. https://review.opendev.org/c/openstack/ansible-collections-openstack/+/819657 | 16:16 |
opendevreview | Suneeth Ravi proposed openstack/python-openstackclient master: Switch server lock to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/819517 | 16:19 |
*** sshnaidm is now known as sshnaidm|afk | 16:22 | |
opendevreview | Thrivikram Mudunuri proposed openstack/python-openstackclient master: Switch server pause and server unpause to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/817853 | 16:48 |
opendevreview | Thrivikram Mudunuri proposed openstack/python-openstackclient master: Switch server suspend and server resume to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/817860 | 16:48 |
opendevreview | Thrivikram Mudunuri proposed openstack/python-openstackclient master: Switch server suspend and server resume to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/817860 | 16:50 |
diablo_rojo | stephenfin, gtema before you both run away for the day. This Friday is the 'deadline' for submitting a proposal for a project for students from NDSU after new years through spring. I am happy to start throwing stuff together if we want to? Otherwise I will try to mobilize another group of mentors somewhere in OpenStack to get a proposal in. | 17:43 |
gtema | facepalm | 17:43 |
gtema | :) | 17:43 |
gtema | I would suggest - not this time | 17:44 |
diablo_rojo | gtema, fair enough :) | 17:46 |
diablo_rojo | stephenfin, you agree? | 17:46 |
diablo_rojo | I was kind of thinking that myself gtema, just wanted to check before I gave it away to another group. | 17:46 |
gtema | :) | 17:46 |
stephenfin | Yeah, agreed | 17:47 |
diablo_rojo | Okay cool. Will find another group to hand it to then :) | 17:47 |
gtema | thanks a lot | 17:47 |
opendevreview | Artom Lifshitz proposed openstack/python-openstackclient master: compute: Reorder building of columns for 'server list' https://review.opendev.org/c/openstack/python-openstackclient/+/772641 | 18:39 |
opendevreview | Artom Lifshitz proposed openstack/python-openstackclient master: compute: Show flavor in 'server list' with API >= 2.47 https://review.opendev.org/c/openstack/python-openstackclient/+/761772 | 18:39 |
opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch compute service list, delete and set to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/818434 | 18:48 |
*** tosky is now known as Guest7167 | 20:17 | |
*** tosky_ is now known as tosky | 20:17 | |
opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch compute service list, delete and set to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/818434 | 20:58 |
opendevreview | Merged openstack/python-openstackclient master: image: Remove dead test helper methods https://review.opendev.org/c/openstack/python-openstackclient/+/818223 | 21:54 |
opendevreview | Merged openstack/openstacksdk master: compute: Add support for server lock reason https://review.opendev.org/c/openstack/openstacksdk/+/819293 | 21:54 |
*** tosky_ is now known as tosky | 21:57 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!