| opendevreview | Rafael Castillo proposed openstack/openstacksdk master: Use /volumes/detail endpoint in find_volume proxy method https://review.opendev.org/c/openstack/openstacksdk/+/854293 | 01:53 |
|---|---|---|
| opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Updates volume for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/853749 | 01:54 |
| opendevreview | yangjianfeng proposed openstack/python-openstackclient master: Add router ndp proxy commands https://review.opendev.org/c/openstack/python-openstackclient/+/749038 | 05:28 |
| opendevreview | Merged openstack/openstacksdk master: Use /volumes/detail endpoint in find_volume proxy method https://review.opendev.org/c/openstack/openstacksdk/+/854293 | 05:37 |
| opendevreview | yangjianfeng proposed openstack/python-openstackclient master: Add router ndp proxy commands https://review.opendev.org/c/openstack/python-openstackclient/+/749038 | 06:22 |
| opendevreview | yangjianfeng proposed openstack/python-openstackclient master: Add router ndp proxy commands https://review.opendev.org/c/openstack/python-openstackclient/+/749038 | 06:37 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored baremetal_node and baremetal_node_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854113 | 09:25 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored baremetal_node_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854357 | 09:30 |
| stephenfin | gtema: easy OSC review for a new nova microversion here https://review.opendev.org/c/openstack/python-openstackclient/+/831902 | 09:37 |
| gtema | oki, looking | 09:37 |
| stephenfin | as I paste that, I wonder if we need to bump the novaclient version in requirements.txt? | 09:37 |
| stephenfin | we probably do | 09:37 |
| stephenfin | (pity lower-constraints is no longer a thing for stuff like this) | 09:38 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Bump python-novaclient version https://review.opendev.org/c/openstack/python-openstackclient/+/854363 | 10:04 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Remove invalid note from requirements files https://review.opendev.org/c/openstack/python-openstackclient/+/854364 | 10:04 |
| *** seongsoocho_ is now known as seongsoocho | 11:06 | |
| *** PrinzElvis_ is now known as PrinzElvis | 11:06 | |
| *** rpittau_ is now known as rpittau | 11:06 | |
| *** vkmc_ is now known as vkmc | 11:06 | |
| *** TheJulia_ is now known as TheJulia | 11:06 | |
| *** sfinucan is now known as stephenfin | 11:06 | |
| *** tweining___ is now known as tweining | 11:08 | |
| *** arne_wiebalck_ is now known as arne_wiebalck | 11:24 | |
| stephenfin | frickler: I left a lot of comments on https://review.opendev.org/c/openstack/python-openstackclient/+/749038/ Maybe you can help me understand some of the naming decisions? | 11:41 |
| frickler | stephenfin: already at it ;) | 11:52 |
| stephenfin | thanks! | 11:52 |
| frickler | slaweq: ^^ maybe you have some opinion on this, too. I actually like stephenfin's idea of using "router ndp proxy" as command prefix instead of "network ndp proxy" | 12:04 |
| opendevreview | Will Szumski proposed openstack/ansible-collections-openstack master: Allow networks to be updated https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854170 | 12:37 |
| jm1 | gtema: are you sure that openstacksdk's self._baremetal_client.post() will accept sdk attribute names instead of openstack api attribute names? e.g. schema validation fails because i am passing 'id' https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_908/854113/12/check/bifrost-collections-src/90849ec/job-output.txt | 12:40 |
| opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Updates volume for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/853749 | 12:54 |
| opendevreview | ribaudr proposed openstack/openstacksdk master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/openstacksdk/+/853949 | 13:02 |
| gtema | <jm1> "gtema: are you sure that..." <- nom xxx_client.post accepts server side structure | 13:04 |
| gtema | you will only need this way if there is no corresponding proxy method already existing | 13:04 |
| jm1 | gtema: i was thinking the same but "<gtema> <jm1> "gtema: or will _baremetal_client..." <- it does exactly that" ;) | 13:05 |
| gtema | na ja, it depends on how you formulated your question and how I understood it ;-) | 13:05 |
| jm1 | gtema: XD anyway. this means we need something like dtantsur's https://review.opendev.org/c/openstack/openstacksdk/+/849402/7 | 13:06 |
| dtantsur | I want to allocate time next week to finish it properly and see if I need to address anything else | 13:08 |
| gtema | maybe. If I would correctly understand what and where is wrong. Point of switching cloud layer to rely on proxy layer is to get rid of xx_client.<METHOD> calls. Ansible module "should" also rely on proxy layer itself (as long as possible and makes sense) | 13:08 |
| jm1 | gtema: register_machine will do two things, first create a baremetal node and then create baremetal ports. if anything fails, operations will be rolled back. so register_machine consists of funtionality which i do not want to replicate in aoc. imho it belongs to openstacksdk. | 13:13 |
| gtema | yupp, but for some reason you was asking me whether you can do baremetal_client.post and that confused me on the purpose. All good | 13:25 |
| jm1 | gtema: ah ok sorry. will you fix it anyway? 😳 | 13:27 |
| gtema | fix what? and that is exactly what is confusing: I do not really understand what should be fixed | 13:27 |
| opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Updates volume for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/853749 | 13:38 |
| *** mnasiadka_ is now known as mnasiadka | 14:25 | |
| jm1 | gtema: register_machine assumes that kwargs consists of keys which openstack api accepts. For example, you have to pass instance_uuid. you cannot pass keys of openstacksdk's baremetal.*.Node class such as 'id'. | 14:42 |
| jm1 | gtema: it would be great if register_machine would be changed in a way that you do not have to use openstack api keys but openstacksdk's baremetal.*.Node keys | 14:43 |
| jm1 | gtema: all other methods are somehow passing the resource/proxy layer. register_machine is one of those relicts which expose openstack api directly to the user/developer | 14:44 |
| jm1 | gtema: hence it would be great to change register_machine to offer a resource/proxy layer based api to the user instead of exposing openstack api | 14:48 |
| gtema | jm1: copied your messages into my "notes" to not to loose them. Will try to dig deeper around Friday | 15:21 |
| jm1 | gtema: ok great! thanks! | 15:26 |
| opendevreview | Merged openstack/openstacksdk master: Allow Resource.to_dict to allow returning unknown values https://review.opendev.org/c/openstack/openstacksdk/+/843963 | 15:46 |
| opendevreview | Will Szumski proposed openstack/ansible-collections-openstack master: Allow networks to be updated https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854170 | 16:02 |
| opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Updates volume for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/853749 | 20:47 |
| opendevreview | Rafael Castillo proposed openstack/openstacksdk master: Support unknown attributes in resource.__getitem__ https://review.opendev.org/c/openstack/openstacksdk/+/854461 | 23:11 |
| opendevreview | Rafael Castillo proposed openstack/openstacksdk master: Support unknown attributes in resource.__getitem__ https://review.opendev.org/c/openstack/openstacksdk/+/854461 | 23:16 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!