Thursday, 2023-01-05

*** tkajinam is now known as Guest29904:46
jm1gtema: hey :) openstacksdk's remove_floating_ip_from_server() is failing randomly in aoc ci tests. often a simple recheck solves the issue. looking at nova's api doc it looks like the action being called is deprecated, so maybe we shall mark that sdk function as deprecated as well? https://docs.openstack.org/api-ref/compute/#remove-disassociate-floating-ip-removefloatingip-action-deprecated07:59
gtemaI will have a deeper look. Can you see any dependency whether this fails when running on certain cloud?08:01
opendevreviewJakob Meng proposed openstack/ansible-collections-openstack master: Use Neutron instead of Nova when detaching floating ips if available  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86928408:09
jm1gtema: we run tests only against devstack https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_921/869167/1/check/ansible-collections-openstack-functional-devstack/9219698/job-output.txt08:11
jm1gtema: error at 2023-01-04 21:23:49.82193208:11
opendevreviewFelix Huettner proposed openstack/openstacksdk master: Support passing a subnetpool for create_subnet  https://review.opendev.org/c/openstack/openstacksdk/+/86810408:12
jm1gtema: ah, its failing now because of this: https://review.opendev.org/c/openstack/openstacksdk/+/86789008:13
gtemaOk, will check. Even it is devstack things sometimes run differently depending on whether they run in ovh or rax or vex (timeouts and co)08:13
jm1gtema: stephenfin's patch is fine, its just our code which is using deprecated code. submitted a patch to aoc already08:13
gtemaBut why then recheck helps, this is what disturbs me08:14
opendevreviewJakob Meng proposed openstack/ansible-collections-openstack master: Use Neutron instead of Nova when detaching floating ips if available  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86928408:15
jm1gtema: forget about my recheck comment. that was about the other floating ip error we are chasing in cloud layer08:16
jm1gtema: when checking ci output i was first assuming its the same random floating ip error which happens from time to time. but its a different issue08:18
gtemaOk08:19
opendevreviewJakob Meng proposed openstack/ansible-collections-openstack master: Refactored security_group{,_info} modules  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86774009:21
opendevreviewArnaud Morin proposed openstack/ansible-collections-openstack master: Rename reboot into reboot_soft  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86934310:36
sshnaidmdtantsur, hi, probably https://review.opendev.org/c/openstack/openstacksdk/+/868099 broke baremetal node module and SDK,it fails in bifrost job: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_edf/869284/2/check/bifrost-keystone-collections-src/edf27b6/job-output.txt11:12
opendevreviewJakob Meng proposed openstack/ansible-collections-openstack master: Refactored security_group_rule{,_info} modules  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86935512:10
opendevreviewDr. Jens Harbott proposed openstack/openstacksdk master: Revert "Add 'details' parameter to various 'find' proxy methods"  https://review.opendev.org/c/openstack/openstacksdk/+/86931512:46
fricklergtema: stephenfin: ^^ see sshnaidm's comment, this was shown in the non-voting jobs on that patch already, I guess we should make at least the ironic job voting?12:47
frickleralso take better care of hard broken n-v jobs like legacy so that people do not get used to simply ignoring them12:48
gtemaack12:48
fricklerif you can fix it instead of reverting, that would of course be fine, too12:48
stephenfinYeah, better to fix. I'll take a look now12:49
opendevreviewMerged openstack/ansible-collections-openstack master: Use Neutron instead of Nova when detaching floating ips if available  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86928412:52
opendevreviewTaehyun Park proposed openstack/openstacksdk master: Add image metadef object operations  https://review.opendev.org/c/openstack/openstacksdk/+/85835013:04
opendevreviewJakob Meng proposed openstack/ansible-collections-openstack master: Refactored compute_service_info module  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86916713:09
opendevreviewJakob Meng proposed openstack/ansible-collections-openstack master: Refactored project{,_info} modules  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86925413:10
opendevreviewJakob Meng proposed openstack/ansible-collections-openstack master: Refactored loadbalancer module breaking backward compatibility  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86755813:10
opendevreviewJakob Meng proposed openstack/ansible-collections-openstack master: Refactored lb_{health_monitor,listener,member,pool} modules  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86756013:11
opendevreviewJakob Meng proposed openstack/ansible-collections-openstack master: Refactored coe_cluster{,_template} modules  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86679613:11
opendevreviewStephen Finucane proposed openstack/openstacksdk master: Rework 'details' parameter for baremetal proxy  https://review.opendev.org/c/openstack/openstacksdk/+/86937013:45
stephenfinfrickler: ^13:45
fricklerstephenfin: thx, I'll mostly have to defer to what the CI says though14:23
opendevreviewArtem Goncharov proposed openstack/openstacksdk master: Move _normalize_coe_* into _coe class  https://review.opendev.org/c/openstack/openstacksdk/+/86504315:10
lajoskatonastephenfin, frickler: Hi, a question to think about regarding networking stadium projects CLI and python binding code15:50
lajoskatonastephenfin, frickler: back in December we discussed it on team meeting: https://meetings.opendev.org/meetings/networking/2022/networking.2022-12-20-14.01.log.html#l-10815:50
lajoskatonastephenfin, frickler:  frickler already shared his opinion but I think it is better to have the discussion here also perhaps with more people15:51
gtemacan you please reiterate what is stadium and what you want to achieve?15:52
lajoskatonagtema: stadium projects for Neutron are projects that implement some networking feature/functionality with extra API that is not in core Neutron (like neutron-fwaas for Firewalls, neutron-dynamic-routing for BGP etc...)15:53
gtemavpnaas as well?15:54
lajoskatonagtema: so these are not core networking features, but now we have the CLI code (both old neutron commands and OSC plugin) in most cases in python-neutronclient repo15:54
lajoskatonagtema yes vpnaas is also a stadium project15:54
gtemaokay15:54
lajoskatonagtema: and we already deprecated the CLI code in python-neutronclient but the python bining code is also there, and even some OSC plugins call into the python binding of neutronclient instead of SDK15:56
gtemaok, and so we should add those into the sdk and cli15:58
lajoskatonagtema: and the question is that can we put these SDK methods (like add_bgp_speaker_to_dragent) to openstacksdk or keep them in neutronclient, and the same for the CLI part, shall we add these to osc or keep them as plugins in neutronclient?15:59
gtemaI would really like to see us starting adding those to sdk so that later also ansible modules can make use of that15:59
gtemaand once sdk is done also osc15:59
lajoskatonagtema: if you can check the meeting log from December which I linked, the argument was to move only openstack network * commands, but that was just a first glance idea at that time16:00
gtemaor alternatively keep those in neutronclient (cli part), but use sdk as base16:00
lajoskatonagtema: ok16:00
gtemafrom my pov it is really important to have sdk coverage16:01
gtemasooner or later somebody would want to use those things with ansible (as is now the case for vpn)16:01
gtemaand having sdk support is crucial here16:01
lajoskatonagtema: I pushed a first wip for tap-as-a-service (https://review.opendev.org/c/openstack/tap-as-a-service/+/867786 ) its CLI code is in tap-as-a-service repo so not in neutronclient but perhaps good to see what it means16:02
lajoskatonaif we have to do everythin outside SDK, so if we can add these methods to openstacksdk that is a big help I think16:02
gtemadefinitely move to sdk16:02
gtemaI see no reason not to do this16:02
gtemacli part may be separate OSC plugin, but sdk from my pov should be having support for everything what exists in openstack16:03
lajoskatonagteam: sounds cool16:04
lajoskatonagtema: do we need to bring this to some formal meeting, or open some spec or bug or similar?16:04
gtemanope, just feel free to start adding directly to sdk16:05
lajoskatonagtema: ok, thanks, we have a neutron bug to track this effort, so I can use that for tag and in commit msg to have the context for everybody16:06
gtemasounds great16:06
opendevreviewMerged openstack/openstacksdk master: Move normalize security group to sg class  https://review.opendev.org/c/openstack/openstacksdk/+/86502516:25
opendevreviewJakob Meng proposed openstack/ansible-collections-openstack master: Refactored coe_cluster{,_template} modules  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86679616:33
opendevreviewMerged openstack/openstacksdk master: Move normalize_server to compute mixin  https://review.opendev.org/c/openstack/openstacksdk/+/86656716:47

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!