opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored security_group{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/867740 | 06:37 |
---|---|---|
opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored security_group_rule{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869355 | 06:37 |
opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | 06:38 |
opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored compute_service_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869167 | 06:39 |
opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored project{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869254 | 06:39 |
opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Drop munch dependency https://review.opendev.org/c/openstack/openstacksdk/+/865045 | 07:35 |
opendevreview | Merged openstack/openstacksdk master: Drop _normalize class https://review.opendev.org/c/openstack/openstacksdk/+/865044 | 09:01 |
opendevreview | Merged openstack/openstacksdk master: baremetal: Add Node.inject_nmi method https://review.opendev.org/c/openstack/openstacksdk/+/866569 | 09:11 |
opendevreview | Merged openstack/ansible-collections-openstack master: Refactored loadbalancer module breaking backward compatibility https://review.opendev.org/c/openstack/ansible-collections-openstack/+/867558 | 10:03 |
opendevreview | Merged openstack/ansible-collections-openstack master: Refactored lb_{health_monitor,listener,member,pool} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/867560 | 10:03 |
opendevreview | Merged openstack/ansible-collections-openstack master: Refactored coe_cluster{,_template} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/866796 | 10:03 |
opendevreview | Merged openstack/ansible-collections-openstack master: Refactored security_group{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/867740 | 10:03 |
opendevreview | Merged openstack/ansible-collections-openstack master: Refactored security_group_rule{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869355 | 10:03 |
opendevreview | Merged openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | 10:03 |
opendevreview | Merged openstack/ansible-collections-openstack master: Refactored compute_service_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869167 | 10:03 |
opendevreview | Merged openstack/ansible-collections-openstack master: Refactored project{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869254 | 10:03 |
whoami-rajat | stephenfin, hey, I'm adding a new command which has the parameter '--prefix' but it's ignored by the doc builder, any reason why it's done that way and any workaround for that? https://github.com/openstack/python-openstackclient/blob/master/doc/source/conf.py#L264 | 10:30 |
whoami-rajat | I know i can write down the whole thing but if we could "not ignore" it for specific commands | 10:31 |
frickler | whoami-rajat: iiuc --prefix is a parameter already defined and used by cliff, so you would need to name your new parameter differently | 10:45 |
whoami-rajat | frickler, hmm, but in the context of my specific command, it shouldn't be an issue right? openstack volume service get log --prefix | 10:46 |
whoami-rajat | and it works fine, just causing issue in the doc build | 10:46 |
frickler | whoami-rajat: it is an issue, as you are overriding a global default option for the shell formatter. what is the semantic for your prefix, can it be called --log-prefix or similar? | 10:49 |
stephenfin | whoami-rajat: There's no easy way to address that. As frickler notes, that's ignored because it's an argument implied by cliff and we don't want to dump a load of duplicated options for every command | 10:50 |
stephenfin | It will work, as you note, because cliff (or perhaps argparse) has a hierarchy of options and will map the option to the correct subparser, but we've no way to indicate that we should ignore the option *only from this subparser* for that Sphinx extension | 10:50 |
stephenfin | So the easiest thing to do would be to come up with a slightly different name for the option | 10:51 |
frickler | plus we should avoid confusing our users by having identically named options doing completely different things | 10:52 |
whoami-rajat | frickler, stephenfin ack, thanks for the help, will update that. also note that --prefix is also used in object/v1/object.py file in the ListObject command, not sure if v1 is still in use though (might be added before sphinxext integration) | 10:53 |
stephenfin | Yeah, I suspect that was just missed | 10:55 |
frickler | we might add a new option and at least deprecate this one, not sure if we could ever remove it though. also it is no direct conflict because the list actions don't support the shell formatter | 11:00 |
opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Add volume service {get, set} log commands https://review.opendev.org/c/openstack/python-openstackclient/+/869811 | 11:20 |
opendevreview | Merged openstack/openstacksdk master: Add query mappings for vpnaas resources https://review.opendev.org/c/openstack/openstacksdk/+/868867 | 11:30 |
*** artom_ is now known as artom | 11:33 | |
opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added resource{,s} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869822 | 13:10 |
opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Refactored coe_cluster{,_template} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869824 | 13:37 |
opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added resource{,s} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869822 | 13:39 |
opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Refactored coe_cluster{,_template} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869824 | 14:09 |
opendevreview | Merged openstack/openstacksdk stable/zed: Update tox.ini for tox v4 compatibility https://review.opendev.org/c/openstack/openstacksdk/+/869200 | 14:11 |
opendevreview | Merged openstack/openstacksdk stable/yoga: Update tox.ini for tox v4 compatibility https://review.opendev.org/c/openstack/openstacksdk/+/869201 | 14:37 |
opendevreview | Merged openstack/openstacksdk stable/yoga: Replace deprecated inspect.getargspec call https://review.opendev.org/c/openstack/openstacksdk/+/869081 | 14:37 |
opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Inlined network_external variable https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869851 | 14:49 |
opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added resource{,s} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869822 | 14:49 |
opendevreview | Jesse Pretorius proposed openstack/python-openstackclient stable/wallaby: volume: Allow more versions https://review.opendev.org/c/openstack/python-openstackclient/+/869832 | 17:45 |
opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added resource{,s} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869822 | 19:54 |
opendevreview | Arvid Requate proposed openstack/keystoneauth master: New auth plugin v3oidcdeviceauthz https://review.opendev.org/c/openstack/keystoneauth/+/869876 | 22:15 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!