Wednesday, 2023-01-11

opendevreviewJakob Meng proposed openstack/ansible-collections-openstack master: Refactored security_group{,_info} modules  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86774006:37
opendevreviewJakob Meng proposed openstack/ansible-collections-openstack master: Refactored security_group_rule{,_info} modules  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86935506:37
opendevreviewJakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86320806:38
opendevreviewJakob Meng proposed openstack/ansible-collections-openstack master: Refactored compute_service_info module  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86916706:39
opendevreviewJakob Meng proposed openstack/ansible-collections-openstack master: Refactored project{,_info} modules  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86925406:39
opendevreviewArtem Goncharov proposed openstack/openstacksdk master: Drop munch dependency  https://review.opendev.org/c/openstack/openstacksdk/+/86504507:35
opendevreviewMerged openstack/openstacksdk master: Drop _normalize class  https://review.opendev.org/c/openstack/openstacksdk/+/86504409:01
opendevreviewMerged openstack/openstacksdk master: baremetal: Add Node.inject_nmi method  https://review.opendev.org/c/openstack/openstacksdk/+/86656909:11
opendevreviewMerged openstack/ansible-collections-openstack master: Refactored loadbalancer module breaking backward compatibility  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86755810:03
opendevreviewMerged openstack/ansible-collections-openstack master: Refactored lb_{health_monitor,listener,member,pool} modules  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86756010:03
opendevreviewMerged openstack/ansible-collections-openstack master: Refactored coe_cluster{,_template} modules  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86679610:03
opendevreviewMerged openstack/ansible-collections-openstack master: Refactored security_group{,_info} modules  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86774010:03
opendevreviewMerged openstack/ansible-collections-openstack master: Refactored security_group_rule{,_info} modules  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86935510:03
opendevreviewMerged openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86320810:03
opendevreviewMerged openstack/ansible-collections-openstack master: Refactored compute_service_info module  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86916710:03
opendevreviewMerged openstack/ansible-collections-openstack master: Refactored project{,_info} modules  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86925410:03
whoami-rajatstephenfin, hey, I'm adding a new command which has the parameter '--prefix' but it's ignored by the doc builder, any reason why it's done that way and any workaround for that? https://github.com/openstack/python-openstackclient/blob/master/doc/source/conf.py#L26410:30
whoami-rajatI know i can write down the whole thing but if we could "not ignore" it for specific commands10:31
fricklerwhoami-rajat: iiuc --prefix is a parameter already defined and used by cliff, so you would need to name your new parameter differently10:45
whoami-rajatfrickler, hmm, but in the context of my specific command, it shouldn't be an issue right? openstack volume service get log --prefix10:46
whoami-rajatand it works fine, just causing issue in the doc build10:46
fricklerwhoami-rajat: it is an issue, as you are overriding a global default option for the shell formatter. what is the semantic for your prefix, can it be called --log-prefix or similar?10:49
stephenfinwhoami-rajat: There's no easy way to address that. As frickler notes, that's ignored because it's an argument implied by cliff and we don't want to dump a load of duplicated options for every command10:50
stephenfinIt will work, as you note, because cliff (or perhaps argparse) has a hierarchy of options and will map the option to the correct subparser, but we've no way to indicate that we should ignore the option *only from this subparser* for that Sphinx extension10:50
stephenfinSo the easiest thing to do would be to come up with a slightly different name for the option10:51
fricklerplus we should avoid confusing our users by having identically named options doing completely different things10:52
whoami-rajatfrickler, stephenfin ack, thanks for the help, will update that. also note that --prefix is also used in object/v1/object.py file in the ListObject command, not sure if v1 is still in use though (might be added before sphinxext integration)10:53
stephenfinYeah, I suspect that was just missed10:55
fricklerwe might add a new option and at least deprecate this one, not sure if we could ever remove it though. also it is no direct conflict because the list actions don't support the shell formatter11:00
opendevreviewRajat Dhasmana proposed openstack/python-openstackclient master: Add volume service {get, set} log commands  https://review.opendev.org/c/openstack/python-openstackclient/+/86981111:20
opendevreviewMerged openstack/openstacksdk master: Add query mappings for vpnaas resources  https://review.opendev.org/c/openstack/openstacksdk/+/86886711:30
*** artom_ is now known as artom11:33
opendevreviewJakob Meng proposed openstack/ansible-collections-openstack master: Added resource{,s} modules  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86982213:10
opendevreviewJakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Refactored coe_cluster{,_template} modules  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86982413:37
opendevreviewJakob Meng proposed openstack/ansible-collections-openstack master: Added resource{,s} modules  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86982213:39
opendevreviewJakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Refactored coe_cluster{,_template} modules  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86982414:09
opendevreviewMerged openstack/openstacksdk stable/zed: Update tox.ini for tox v4 compatibility  https://review.opendev.org/c/openstack/openstacksdk/+/86920014:11
opendevreviewMerged openstack/openstacksdk stable/yoga: Update tox.ini for tox v4 compatibility  https://review.opendev.org/c/openstack/openstacksdk/+/86920114:37
opendevreviewMerged openstack/openstacksdk stable/yoga: Replace deprecated inspect.getargspec call  https://review.opendev.org/c/openstack/openstacksdk/+/86908114:37
opendevreviewJakob Meng proposed openstack/ansible-collections-openstack master: Inlined network_external variable  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86985114:49
opendevreviewJakob Meng proposed openstack/ansible-collections-openstack master: Added resource{,s} modules  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86982214:49
opendevreviewJesse Pretorius proposed openstack/python-openstackclient stable/wallaby: volume: Allow more versions  https://review.opendev.org/c/openstack/python-openstackclient/+/86983217:45
opendevreviewJakob Meng proposed openstack/ansible-collections-openstack master: Added resource{,s} modules  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/86982219:54
opendevreviewArvid Requate proposed openstack/keystoneauth master: New auth plugin v3oidcdeviceauthz  https://review.opendev.org/c/openstack/keystoneauth/+/86987622:15

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!