| opendevreview | suzhengwei proposed openstack/openstacksdk master: support notification vmoves for masakari https://review.opendev.org/c/openstack/openstacksdk/+/872080 | 00:54 |
|---|---|---|
| *** ministry is now known as __ministry | 03:31 | |
| opendevreview | suzhengwei proposed openstack/openstacksdk master: support notification vmoves for masakari https://review.opendev.org/c/openstack/openstacksdk/+/872080 | 10:30 |
| gtema | stephenfin: diablo_rojo_phone willing to give a go for https://review.opendev.org/c/openstack/openstacksdk/+/872030? | 10:57 |
| stephenfin | gtema: 🥳 Looking | 11:01 |
| gtema | thanks stephenfin. What have you meant with comments on "Resource" and "Munch"? | 11:07 |
| stephenfin | Oh, I was just suggesting to format them as ``literals`` | 11:08 |
| stephenfin | double backticks | 11:08 |
| gtema | got it | 11:08 |
| opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Prepare release note for R1.0 https://review.opendev.org/c/openstack/openstacksdk/+/872030 | 11:11 |
| opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Prepare release note for R1.0 https://review.opendev.org/c/openstack/openstacksdk/+/872030 | 11:13 |
| opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Do not create prometheus_client registry by default https://review.opendev.org/c/openstack/openstacksdk/+/872075 | 11:22 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Publish 2.0.0 release https://review.opendev.org/c/openstack/ansible-collections-openstack/+/872077 | 13:05 |
| *** tkajinam is now known as Guest2882 | 13:11 | |
| gtema | stephenfin: another look at https://review.opendev.org/c/openstack/openstacksdk/+/872030? | 13:32 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Publish 2.0.0 release https://review.opendev.org/c/openstack/ansible-collections-openstack/+/872077 | 13:33 |
| stephenfin | gtema: one small typo there but otherwise good (y) | 15:33 |
| stephenfin | gtema: Unrelated: are you happy to backport https://review.opendev.org/c/openstack/python-openstackclient/+/869832/ ? | 15:33 |
| gtema | another typo (facepalm) | 15:33 |
| opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Prepare release note for R1.0 https://review.opendev.org/c/openstack/openstacksdk/+/872030 | 15:35 |
| gtema | fixed. I seem to make lot of typos in a hurry to make this happen | 15:36 |
| stephenfin | ta, +2 | 15:37 |
| gtema | stephenfin, your opinion on https://review.opendev.org/c/openstack/openstacksdk/+/872075 is also welcome. Would be nice to get it into R1.0 since it can be treated as backward incompatible | 15:37 |
| stephenfin | looking | 15:38 |
| stephenfin | gtema: I prefer Vasyl's approach, personally, though I think we should do it for all collectors (i.e. statsd and InfluxDB too) | 15:47 |
| stephenfin | but I can be swayed either way | 15:47 |
| gtema | hmmm | 15:48 |
| gtema | adding "enabled: true" to them feel real awkward for me. Either section is present (which means we gather metrics) or absent - means not | 15:48 |
| stephenfin | I'll defer to you then. At least what you've done is backwards compatible. Could we improve documentation around this, beyond the release note? | 15:54 |
| stephenfin | i.e. add a worked example to doc/source/user/guides/stats.rst | 15:55 |
| gtema | in my eyes this is matching currently to https://docs.openstack.org/openstacksdk/latest/user/guides/stats.html | 16:02 |
| opendevreview | Merged openstack/python-openstackclient stable/wallaby: volume: Allow more versions https://review.opendev.org/c/openstack/python-openstackclient/+/869832 | 16:35 |
| opendevreview | Merged openstack/openstacksdk master: Prepare release note for R1.0 https://review.opendev.org/c/openstack/openstacksdk/+/872030 | 18:29 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Publish 2.0.0 release https://review.opendev.org/c/openstack/ansible-collections-openstack/+/872077 | 18:43 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Publish 2.0.0 release https://review.opendev.org/c/openstack/ansible-collections-openstack/+/872077 | 18:55 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!