| *** ministry is now known as __ministry | 08:23 | |
| gtema | stephenfin, around? | 12:00 |
|---|---|---|
| stephenfin | yup | 12:02 |
| gtema | wrt new attribute properties (min_microversion and max_microversion). I now have a feeling they should be converted to min_version and max_version | 12:02 |
| gtema | keystone is not supporting microversions as well, so also there having possibility to verify whether version is matching is better then only look at microversion | 12:03 |
| stephenfin | hmm, version != microversion, at least from a service catalog perspective. I think we'd need both, tbh | 12:03 |
| stephenfin | microversion for nova, cinder etc. version for glance, keystone, etc. | 12:03 |
| gtema | yes, but: once you look at the api specs you normally see "added in version". | 12:04 |
| gtema | so when service support MV we check mv | 12:04 |
| gtema | when no MV support - verify that api_version is matching | 12:04 |
| stephenfin | okay, so we'd treat it differently depending on whether the service supports microversions or not | 12:05 |
| gtema | from the service pov I think it is still something like api version (whether MV or not MV) | 12:05 |
| stephenfin | question is, should we do that automatically ("magically") or do it explicitly? | 12:05 |
| stephenfin | I'd usually lean towards explicitness for this stuff | 12:05 |
| gtema | yes, depending on the service catalog information treat it either as MV or as not MV | 12:05 |
| gtema | I just do not want to have min_microversion and min_version property or the resource attribute | 12:06 |
| stephenfin | okay, fair enough. I wouldn't personally munge them together but if you really care about it, I'll manage :) | 12:07 |
| gtema | so the usecase to talk explicitly ;-) => compute.server.host requires MV 2.90, while identity.project.is_domain requires version 3.6 | 12:08 |
| gtema | explicitness require resource to know the difference between MV and ver, while technically it is just a matter of different attrs of the endpoint discovery | 12:09 |
| gtema | according to https://docs.openstack.org/api-guide/compute/microversions.html: when min_version is empty and max_version is empty => look at api_version, otherwise look at min_version&max_version | 12:10 |
| stephenfin | okay, if you can document that in the docstrings for the variable then I'll be happy | 12:10 |
| stephenfin | ideally with a link to that doc | 12:10 |
| gtema | deal | 12:11 |
| gtema | the change grows quite lot once I added verification logic for versions ;-) | 12:12 |
| gtema | wlcm | 12:12 |
| gtema | sorry, wrong window | 12:12 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: volume: Add missing attributes to Extension https://review.opendev.org/c/openstack/openstacksdk/+/885132 | 13:35 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: Encode type of 'links' for Extension objects https://review.opendev.org/c/openstack/openstacksdk/+/885133 | 13:35 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: volume: Add Extension to volume v2 API https://review.opendev.org/c/openstack/openstacksdk/+/885134 | 13:35 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: network: Use SDK, not neutronclient, for AZ tests https://review.opendev.org/c/openstack/python-openstackclient/+/885135 | 13:37 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Migrate 'availablity zone list' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/885136 | 13:37 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: volume: Migrate 'availablity zone list' to SDK" https://review.opendev.org/c/openstack/python-openstackclient/+/885137 | 13:37 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: tests: Use SDK for extensions tests https://review.opendev.org/c/openstack/python-openstackclient/+/885138 | 13:37 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: volume: Migrate 'extension list' to SDK" https://review.opendev.org/c/openstack/python-openstackclient/+/885139 | 13:37 |
| *** ministry is now known as __ministry | 15:02 | |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: Remove unnecessary quotes https://review.opendev.org/c/openstack/openstacksdk/+/885153 | 16:52 |
| *** ralonsoh is now known as ralonsoh_afk | 16:56 | |
| opendevreview | Merged openstack/openstacksdk master: cloud: Remove '_ShadeAdapter' https://review.opendev.org/c/openstack/openstacksdk/+/846216 | 17:17 |
| opendevreview | Merged openstack/openstacksdk master: cloud: Rename shade-specific method https://review.opendev.org/c/openstack/openstacksdk/+/884423 | 17:17 |
| opendevreview | Merged openstack/openstacksdk master: cloud: Remove ClusteringCloudMixin https://review.opendev.org/c/openstack/openstacksdk/+/884493 | 17:17 |
| opendevreview | Merged openstack/openstacksdk master: utils: Add 'supports_version' https://review.opendev.org/c/openstack/openstacksdk/+/884494 | 17:17 |
| opendevreview | Merged openstack/openstacksdk master: cloud: Move identity-related helpers https://review.opendev.org/c/openstack/openstacksdk/+/884495 | 17:17 |
| opendevreview | Merged openstack/openstacksdk master: docs: Replace/remove shade-specific docs https://review.opendev.org/c/openstack/openstacksdk/+/878644 | 17:17 |
| opendevreview | Merged openstack/openstacksdk master: tests: Use uuid, not randint https://review.opendev.org/c/openstack/openstacksdk/+/884514 | 17:17 |
| opendevreview | Merged openstack/openstacksdk master: Use custom warnings everywhere https://review.opendev.org/c/openstack/openstacksdk/+/884417 | 17:17 |
| opendevreview | Merged openstack/openstacksdk master: tests: Ignore our own deprecation warnings https://review.opendev.org/c/openstack/openstacksdk/+/884418 | 17:17 |
| opendevreview | Rajat Dhasmana proposed openstack/openstacksdk master: Add block storage summary support https://review.opendev.org/c/openstack/openstacksdk/+/884397 | 19:09 |
| opendevreview | ribaudr proposed openstack/python-openstackclient master: WIP Add share commands to compute https://review.opendev.org/c/openstack/python-openstackclient/+/881540 | 19:23 |
| opendevreview | ribaudr proposed openstack/openstacksdk master: Add shares API to compute https://review.opendev.org/c/openstack/openstacksdk/+/880056 | 19:24 |
| opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Migrate 'volume summary' command to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/884398 | 19:25 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!