| opendevreview | Yamato Tanaka proposed openstack/openstacksdk master: Do exact-matching when finding one instance by name https://review.opendev.org/c/openstack/openstacksdk/+/887127 | 02:43 |
|---|---|---|
| opendevreview | Rico Lin proposed openstack/openstacksdk master: Fix broken python3.6 support https://review.opendev.org/c/openstack/openstacksdk/+/887137 | 06:21 |
| opendevreview | Rico Lin proposed openstack/openstacksdk master: Fix broken python3.6 support https://review.opendev.org/c/openstack/openstacksdk/+/887137 | 07:54 |
| opendevreview | Yamato Tanaka proposed openstack/openstacksdk master: Do exact-matching when finding one instance by name https://review.opendev.org/c/openstack/openstacksdk/+/887127 | 09:07 |
| opendevreview | Mridula Joshi proposed openstack/openstacksdk master: Adding support for image upload https://review.opendev.org/c/openstack/openstacksdk/+/881939 | 10:07 |
| mnaser | stephenfin: could you have a look at https://review.opendev.org/c/openstack/openstacksdk/+/887137 (since that was introduced by https://review.opendev.org/c/openstack/openstacksdk/+/884494) | 12:14 |
| ricolin | ralonsoh: slaweq gtema appreciate if you can help to review on https://review.opendev.org/c/openstack/openstacksdk/+/887137 as it's currently broken for python3.6 | 12:32 |
| ralonsoh | ricolin, I've commented in the patch. I don't think this is the correct fix | 13:07 |
| opendevreview | Rico Lin proposed openstack/openstacksdk master: Revert "utils: Add 'supports_version'" https://review.opendev.org/c/openstack/openstacksdk/+/887068 | 13:09 |
| opendevreview | Rico Lin proposed openstack/openstacksdk master: Revert "utils: Add 'supports_version'" https://review.opendev.org/c/openstack/openstacksdk/+/887068 | 13:18 |
| opendevreview | Rico Lin proposed openstack/openstacksdk master: Fix broken python3.6 support https://review.opendev.org/c/openstack/openstacksdk/+/887137 | 13:51 |
| ricolin | ralonsoh: please review it again, thanks https://review.opendev.org/c/openstack/openstacksdk/+/887137 | 13:52 |
| opendevreview | Rico Lin proposed openstack/openstacksdk master: Fix broken python3.6 support https://review.opendev.org/c/openstack/openstacksdk/+/887137 | 13:59 |
| ricolin | gtema: hey need your review again to the updated one thanks https://review.opendev.org/c/openstack/openstacksdk/+/887137 | 14:08 |
| gtema | sure | 14:09 |
| ralonsoh | ricolin, Stepehn has replied to it | 14:16 |
| stephenfin | I've no issues fixing it now since we do advertise support but can we drop python3.6 and python3.7 in our next major version bump? Both versions are EOL upstream and unsupported by the rest of OpenStack. Also RHEL8 has app streams so there shouldn't be any issues installing a newer Python 3 version. | 14:17 |
| opendevreview | Rico Lin proposed openstack/openstacksdk master: Fix broken python3.6 support https://review.opendev.org/c/openstack/openstacksdk/+/887137 | 14:19 |
| ricolin | stephenfin: updated^^^ | 14:20 |
| ricolin | ralonsoh: ^^^ | 14:20 |
| stephenfin | yup +2 | 14:20 |
| ralonsoh | is reviewed | 14:20 |
| frickler | ricolin: on what platform do you actually need py3.6 support? | 14:21 |
| ricolin | frickler: it was this command triggers this patch https://github.com/openstack/openstacksdk/commit/3cb5bc98573e8eb7d3487121b7b59ebd535035c5 | 14:22 |
| ricolin | s/command/comments/ | 14:22 |
| stephenfin | tbf, if you attempt to install SDK on python3.6 right now you'll get the latest version since python_requires = >=3.6 in setup.cfg. I think we just need to get this fix out the door and in a release and then we should bump 'python_requires' to avoid the issue | 14:24 |
| frickler | I was just wondering whether supporting old clouds would also imply keeping support for old python version for as long as possible | 14:29 |
| stephenfin | We can still support them via stable branches. They just won't get newer features. | 14:31 |
| mnaser | stephenfin, frickler, ricolin: yeah, imho since we advertise py3.6 it makes sense to land this | 14:37 |
| frickler | I'm not questioning that fix, I'm pondering whether we can drop py3.6 support after that or whether it would be better to reintroduce 3.6 testing and keep that running as long as it works, like when opendev drops the images needed for that | 14:42 |
| stephenfin | frickler: What would the advantage be? | 15:07 |
| stephenfin | The two big use cases of sdk are service-driven operations (nova talking to cinder) and user-driven operations (OSC, Ansible, and SDK itself) | 15:11 |
| stephenfin | The former isn't a concern since a released nova will use a release SDK. For the latter, surely people are deploying from environment with more recent toolchains (or the ability to enable them: see RHEL AppStreams)? | 15:11 |
| mnaser | stephenfin: yeah i've just been wondering about people who want to use something like ansible.. but yeah if you're saying rhel appstream is a workaround then sure | 16:27 |
| mnaser | gtema: https://review.opendev.org/c/openstack/openstacksdk/+/887137 round 2 if you dont mind :P | 16:28 |
| ricolin | Hey stephenfin gtema , check job passed now, can you kindly help to give it a +w? thanks https://review.opendev.org/c/openstack/openstacksdk/+/887137 | 17:12 |
| opendevreview | Danila Balagansky proposed openstack/openstacksdk master: Add missing `return` in `upload_volume_to_image` https://review.opendev.org/c/openstack/openstacksdk/+/887221 | 18:41 |
| opendevreview | Anvi Joshi proposed openstack/openstacksdk master: Implemented methods for share metadata https://review.opendev.org/c/openstack/openstacksdk/+/886123 | 18:50 |
| opendevreview | Merged openstack/openstacksdk master: Fix broken python3.6 support https://review.opendev.org/c/openstack/openstacksdk/+/887137 | 22:41 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!