| whoami-rajat | stephenfin, hey, can you take another look at this patch? https://review.opendev.org/c/openstack/python-openstackclient/+/919820 | 14:52 |
|---|---|---|
| stephenfin | whoami-rajat: Ah, I had a draft comment but never submitted it. Done now | 14:53 |
| whoami-rajat | stephenfin, tbh, I'm not sure what the difference is between % and comma (,) in oslo logging but i was using similar code for snapshot unmanage (being proposed first) and volume unmanage and in snapshot delete % is used https://github.com/openstack/python-openstackclient/blob/master/openstackclient/volume/v2/volume_snapshot.py#L193-L198 | 14:58 |
| stephenfin | whoami-rajat: https://docs.python.org/3/howto/logging.html#optimization | 14:59 |
| stephenfin | tldr: if you pass the arguments separate rather than with %, the arguments are deferred until if/when they're needed. I was pretty sure hacking had a check for that but maybe it's not enabled by default | 15:00 |
| stephenfin | Ah, yes, 'H904' which is disabled by default | 15:02 |
| opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Add support for volume unmanage https://review.opendev.org/c/openstack/python-openstackclient/+/919820 | 15:10 |
| whoami-rajat | stephenfin, ack, understood now, updated ^ | 15:11 |
| stephenfin | cool, one comment but +2 | 15:13 |
| opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Add support for volume unmanage https://review.opendev.org/c/openstack/python-openstackclient/+/919820 | 15:18 |
| whoami-rajat | stephenfin, yeah, my bad, updated now | 15:19 |
| opendevreview | Baek Seung Ju proposed openstack/openstacksdk master: Implemented snapshot-related features of the stack. https://review.opendev.org/c/openstack/openstacksdk/+/921471 | 15:44 |
| opendevreview | Antonia Gaete proposed openstack/python-openstackclient master: identity: Migrate 'service' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/906395 | 16:56 |
| M0weng[m] | stephenfin: Quick question about the role commands in openstackclient - should --inherited no longer be an allowable argument for the role add commands since the option isn't passed in to SDK? | 23:53 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!