| opendevreview | Lars Kellogg-Stedman proposed openstack/openstacksdk master: Ignore AuthPluginException in get_all() https://review.opendev.org/c/openstack/openstacksdk/+/940087 | 01:54 |
|---|---|---|
| opendevreview | Artem Goncharov proposed openstack/codegenerator master: Drop overloaded federation service provider schema https://review.opendev.org/c/openstack/codegenerator/+/939584 | 08:26 |
| *** tosky_ is now known as tosky | 08:53 | |
| slaweq | gtema hi, how are you? Can you help me with https://review.opendev.org/c/openstack/openstacksdk/+/939703 maybe? I have no idea why osc-tox-py{39,312}-tips jobs are failing on this patch really, the same tests are passing for me locally :/ | 09:39 |
| slaweq | maybe I am missing something obvious there and you will spot it quickly | 09:39 |
| slaweq | thx in advance | 09:39 |
| gtema | hey hey. It's a curse. I am vice-versa trying to understand why certain patch doesn't work locally while it works remotely :) | 09:40 |
| gtema | looking | 09:40 |
| slaweq | haha | 09:40 |
| slaweq | thx a lot | 09:40 |
| gtema | I see order of columns in the response differs | 09:41 |
| slaweq | there is one "not expected" column there and it is "is_vlan_qinq" | 09:42 |
| gtema | actually this new attr is_vlan_qinq is not defined in the unittest while it is now returned | 09:42 |
| slaweq | this is new thing added by the patch on which it is running | 09:42 |
| slaweq | but why it is passing for me locally? | 09:42 |
| slaweq | I don't understand it :/ | 09:42 |
| gtema | and you see the attr returned when you invoke osc? | 09:43 |
| gtema | slaweq: the test fails for me locally. Can it be that you changed the test locally but didn't pushed it? | 09:48 |
| slaweq | when I run this test locally this new column is there too | 09:48 |
| slaweq | all changes are pushed | 09:50 |
| gtema | I think the problem is (and we had it already) osc respects depends-on, sdk can not install osc patch and it uses the master branch of it | 09:50 |
| slaweq | but then isn't it chicken-egg problem? | 09:51 |
| gtema | it is a circular dependency and you should first prepare osc test (disable it or extend with dummy) | 09:51 |
| gtema | we had this clearly some time ago | 09:51 |
| slaweq | ok, I will do it that way | 09:51 |
| slaweq | thx | 09:51 |
| gtema | once this osc change merges you can proceed with your changes | 09:51 |
| gtema | you are welcome | 09:52 |
| gtema | I see historically there were your/Rodolfo changes that used also depends-on on the sdk change | 09:56 |
| gtema | and Zuul was itself resolving circular dependency - try it this way, slaweq | 09:56 |
| gtema | i.e. https://review.opendev.org/c/openstack/python-openstackclient/+/892792 | 09:57 |
| opendevreview | Slawek Kaplonski proposed openstack/python-openstackclient master: Temporary ignore "is_vlan_qinq" column in the output https://review.opendev.org/c/openstack/python-openstackclient/+/940111 | 10:09 |
| opendevreview | Slawek Kaplonski proposed openstack/python-openstackclient master: Temporary ignore "is_vlan_qinq" column in the output https://review.opendev.org/c/openstack/python-openstackclient/+/940111 | 10:12 |
| opendevreview | Slawek Kaplonski proposed openstack/python-openstackclient master: Add "qinq-vlan" and "no-qinq-vlan" params to the "network create" cmd https://review.opendev.org/c/openstack/python-openstackclient/+/939706 | 10:12 |
| opendevreview | Slawek Kaplonski proposed openstack/openstacksdk master: Add "vlan_qinq" attribute to the "network" resource https://review.opendev.org/c/openstack/openstacksdk/+/939703 | 10:13 |
| slaweq | gtema ok, lets see how ^^ will work | 10:15 |
| *** tosky is now known as Guest6863 | 13:19 | |
| *** tosky_ is now known as tosky | 13:19 | |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: loading.opts: Add 'argparse_envvars' helper https://review.opendev.org/c/openstack/keystoneauth/+/933110 | 14:39 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: doc: Fix indentation https://review.opendev.org/c/openstack/keystoneauth/+/933111 | 14:39 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: docs: Rework plugin-options doc https://review.opendev.org/c/openstack/keystoneauth/+/933112 | 14:39 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: loading: Add blurb for most plugins https://review.opendev.org/c/openstack/keystoneauth/+/933113 | 14:39 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: docs: Document CLI options, envvars https://review.opendev.org/c/openstack/keystoneauth/+/933114 | 14:39 |
| stephenfin | gtema: If you've time, would you be able to sweep through those? ^ | 14:49 |
| gtema | ack | 14:49 |
| stephenfin | thanks | 14:53 |
| opendevreview | Matthias Rabe proposed openstack/ansible-collections-openstack master: Let clouds_yaml_path behave as documented (Override path to clouds.yaml file) https://review.opendev.org/c/openstack/ansible-collections-openstack/+/940137 | 15:10 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Simplify some types, other TODOs https://review.opendev.org/c/openstack/keystoneauth/+/935764 | 15:18 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Remove unused AuthMethod.get_auth_data arguments https://review.opendev.org/c/openstack/keystoneauth/+/935765 | 15:18 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Remove unused BaseAuthPlugin.get_auth_ref kwargs https://review.opendev.org/c/openstack/keystoneauth/+/935766 | 15:18 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Remove unused _Rescoped.get_unscoped_auth_ref kwargs https://review.opendev.org/c/openstack/keystoneauth/+/935767 | 15:18 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Remove unused BaseAuthPlugin.get_headers kwargs https://review.opendev.org/c/openstack/keystoneauth/+/935768 | 15:18 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Remove unused BaseAuthPlugin.get_token kwargs https://review.opendev.org/c/openstack/keystoneauth/+/935769 | 15:18 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: WIP: typing: Deprecate use of AuthConstructor https://review.opendev.org/c/openstack/keystoneauth/+/935770 | 15:18 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: WIP: typing: Removing remaining unused kwargs https://review.opendev.org/c/openstack/keystoneauth/+/935771 | 15:18 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: pre-commit: Bump versions https://review.opendev.org/c/openstack/keystoneauth/+/940138 | 15:18 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Use builtins https://review.opendev.org/c/openstack/keystoneauth/+/940139 | 15:19 |
| opendevreview | Merged openstack/keystoneauth master: loading.opts: Add 'argparse_envvars' helper https://review.opendev.org/c/openstack/keystoneauth/+/933110 | 18:51 |
| opendevreview | Merged openstack/keystoneauth master: doc: Fix indentation https://review.opendev.org/c/openstack/keystoneauth/+/933111 | 18:51 |
| opendevreview | Merged openstack/keystoneauth master: docs: Rework plugin-options doc https://review.opendev.org/c/openstack/keystoneauth/+/933112 | 19:01 |
| opendevreview | Merged openstack/keystoneauth master: loading: Add blurb for most plugins https://review.opendev.org/c/openstack/keystoneauth/+/933113 | 19:01 |
| opendevreview | Merged openstack/keystoneauth master: docs: Document CLI options, envvars https://review.opendev.org/c/openstack/keystoneauth/+/933114 | 19:01 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!