| M0weng[m] | stephenfin: I just realized SetRegisteredLimit also had the `--region None` behavior; would a `--no-region` option be useful there, or should I just deprecate the behavior? I can imagine creating a registered limit with a region, and then wanting to set the region to none. | 16:51 |
|---|---|---|
| stephenfin | M0weng[m]: What happens if you call 'registered limit set' *without* a '--region' argument? | 16:54 |
| stephenfin | My theory is that it will unset the region | 16:55 |
| stephenfin | Actually, no, this is using keystoneclient. So it will currently do nothing since that filters out None values iirc | 16:56 |
| stephenfin | M0weng[m]: Assuming that's the case, a '--no-region' value would be useful, but only once we're using an SDK that doesn't strip None values (i.e. after your patch openstacksdk migrating us to SDK). Until then, we should just log about '--region None' being deprecated for removal | 16:57 |
| M0weng[m] | My devstack is moving at a turtle | 16:57 |
| M0weng[m] | 's pace | 16:57 |
| M0weng[m] | But yes I imagine it wouldn't change it | 16:57 |
| stephenfin | Check your available disk space on the VM | 16:57 |
| stephenfin | (Just in case. I've seen DevStack filling up the disk. Didn't investigate further and just tore it down/rebuilt it) | 16:59 |
| M0weng[m] | I think it's network issues, my wifi's been a bit slow recently + using a VPN | 16:59 |
| stephenfin | ah, fair | 16:59 |
| M0weng[m] | Yep it doesn't change the region if no --region switch is passed. | 16:59 |
| M0weng[m] | Hmm funnily enough, passing --region None doesn't change it to none either...? | 17:00 |
| stephenfin | Yeah, it's a junk option. I'd nearly be inclined to just remove it outright but the potential complaints aren't worth it | 17:01 |
| stephenfin | https://xkcd.com/1172/ | 17:01 |
| *** priteau is now known as Guest7267 | 17:04 | |
| *** priteau2 is now known as priteau | 17:04 | |
| M0weng[m] | Ok, I'll add the --no-region option and deprecate the other one :) | 17:04 |
| M0weng[m] | (oops, I mean I'll add it to my SDK patch potentially) | 17:06 |
| opendevreview | Oria Weng proposed openstack/python-openstackclient master: Identity: Deprecate using `--region None` https://review.opendev.org/c/openstack/python-openstackclient/+/940321 | 17:11 |
| opendevreview | Oria Weng proposed openstack/python-openstackclient master: Identity: Deprecate `--region None` in limits/registered limits https://review.opendev.org/c/openstack/python-openstackclient/+/940321 | 17:19 |
| opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | 17:20 |
| opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | 17:31 |
| opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | 21:12 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!