| opendevreview | Yaguang Tang proposed openstack/keystoneauth master: fix logic issue for getting IDP data with HTTP 400 response https://review.opendev.org/c/openstack/keystoneauth/+/942171 | 01:17 |
|---|---|---|
| Yanks | Hello team! I've got this streaming image download support PR: https://review.opendev.org/c/openstack/openstacksdk/+/927778 I've resolved all the comments as well, may I know if this could be merged? :) | 06:27 |
| opendevreview | Merged openstack/os-api-ref master: Run pyupgrade to clean up Python 2 syntaxes https://review.opendev.org/c/openstack/os-api-ref/+/941103 | 06:53 |
| opendevreview | Artem Goncharov proposed openstack/codegenerator master: Increase openapi job timeout https://review.opendev.org/c/openstack/codegenerator/+/942676 | 08:07 |
| stephenfin | dtantsur: It's not hugely urgent, but do you think you'd be able to look at the ironic failures that have crept into SDK recently? https://review.opendev.org/c/openstack/openstacksdk/+/942625 | 09:19 |
| stephenfin | I'd like to make that job voting again, as I see no reason for it to be non-voting long-term | 09:20 |
| stephenfin | (They're all scope-related issues) | 09:21 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: cloud: Switch remaining compute functions to proxy https://review.opendev.org/c/openstack/openstacksdk/+/923426 | 10:04 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: cloud: Add missing parameter docs https://review.opendev.org/c/openstack/openstacksdk/+/923427 | 10:04 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: cloud: Deprecate jmespath-style filters https://review.opendev.org/c/openstack/openstacksdk/+/942609 | 10:04 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Add missing proxy arguments https://review.opendev.org/c/openstack/openstacksdk/+/942595 | 10:30 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Remove duplicate TypeVar https://review.opendev.org/c/openstack/openstacksdk/+/942596 | 10:30 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: proxy: Remove '_check_resource' decorator https://review.opendev.org/c/openstack/openstacksdk/+/942597 | 10:30 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.proxy https://review.opendev.org/c/openstack/openstacksdk/+/942598 | 10:30 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.connection https://review.opendev.org/c/openstack/openstacksdk/+/942599 | 10:30 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: WIP: typing: Annotate openstack.service_description https://review.opendev.org/c/openstack/openstacksdk/+/942600 | 10:30 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Don't abuse Proxy._create https://review.opendev.org/c/openstack/openstacksdk/+/942685 | 10:30 |
| opendevreview | Artem Goncharov proposed openstack/codegenerator master: Drop role assignment schema hardcode https://review.opendev.org/c/openstack/codegenerator/+/942635 | 10:32 |
| opendevreview | Merged openstack/openstacksdk master: cloud: Switch remaining image functions to proxy https://review.opendev.org/c/openstack/openstacksdk/+/923422 | 10:45 |
| opendevreview | Merged openstack/openstacksdk master: cloud: Switch remaining block storage functions to proxy https://review.opendev.org/c/openstack/openstacksdk/+/923423 | 10:54 |
| opendevreview | Merged openstack/openstacksdk master: cloud: Replace use of cloud methods in identity cloud layer https://review.opendev.org/c/openstack/openstacksdk/+/923424 | 10:54 |
| opendevreview | Merged openstack/openstacksdk master: cloud: Switch remaining identity functions to proxy https://review.opendev.org/c/openstack/openstacksdk/+/923425 | 10:54 |
| opendevreview | Merged openstack/openstacksdk master: identity: Extract info from created registered limit https://review.opendev.org/c/openstack/openstacksdk/+/942649 | 12:22 |
| opendevreview | Merged openstack/codegenerator master: Drop role assignment schema hardcode https://review.opendev.org/c/openstack/codegenerator/+/942635 | 13:10 |
| dtantsur | stephenfin: noted | 13:19 |
| dtantsur | stephenfin, gtema, do you have a quick idea how I can change the functional tests to use the system scope | 13:32 |
| dtantsur | It's less of an Ironic question and move of an SDK/keystoneauth one :) | 13:32 |
| gtema | afaik in devstack there is already clouds.yaml entry with system scope | 13:33 |
| stephenfin | yes, `devstack-system-admin` | 13:34 |
| gtema | yupp: devstack-system-admin, devstack-system-member and devstack-system-reader | 13:34 |
| stephenfin | dtantsur: I'm guessing you're going to need a new cloud type variable in openstack/tests/functional/base.py, to go along with `user_cloud`, `user_cloud_alt`, etc.? | 13:36 |
| dtantsur | stephenfin: I assume you so, yes | 13:43 |
| dtantsur | In the new RBAC world, some Ironic operations are system-scoped by default (listing drivers, conductors) | 13:43 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Add missing proxy arguments https://review.opendev.org/c/openstack/openstacksdk/+/942595 | 13:47 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Don't abuse Proxy._update https://review.opendev.org/c/openstack/openstacksdk/+/942685 | 13:47 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Remove duplicate TypeVar https://review.opendev.org/c/openstack/openstacksdk/+/942596 | 13:47 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: proxy: Remove '_check_resource' decorator https://review.opendev.org/c/openstack/openstacksdk/+/942597 | 13:47 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.proxy https://review.opendev.org/c/openstack/openstacksdk/+/942598 | 13:47 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.connection https://review.opendev.org/c/openstack/openstacksdk/+/942599 | 13:47 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: WIP: typing: Annotate openstack.service_description https://review.opendev.org/c/openstack/openstacksdk/+/942600 | 13:47 |
| opendevreview | Dmitry Tantsur proposed openstack/openstacksdk master: Fix the Ironic functional tests to use the correct scope https://review.opendev.org/c/openstack/openstacksdk/+/942705 | 15:25 |
| dtantsur | stephenfin, my attempt at it ^^ | 15:25 |
| cardoe | What do I need to do to land https://review.opendev.org/c/openstack/python-openstackclient/+/940595 ? | 16:10 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: tests: Rename cloud name variables https://review.opendev.org/c/openstack/openstacksdk/+/942712 | 16:19 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: test: Use specific cloud in functional test https://review.opendev.org/c/openstack/openstacksdk/+/942713 | 16:19 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Don't abuse Proxy._update https://review.opendev.org/c/openstack/openstacksdk/+/942685 | 16:21 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Remove duplicate TypeVar https://review.opendev.org/c/openstack/openstacksdk/+/942596 | 16:21 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: proxy: Remove '_check_resource' decorator https://review.opendev.org/c/openstack/openstacksdk/+/942597 | 16:21 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.proxy https://review.opendev.org/c/openstack/openstacksdk/+/942598 | 16:21 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.connection https://review.opendev.org/c/openstack/openstacksdk/+/942599 | 16:21 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: WIP: typing: Annotate openstack.service_description https://review.opendev.org/c/openstack/openstacksdk/+/942600 | 16:22 |
| M0weng[m] | stephenfin or gtema : I'm finding that the `limit` functional tests don't seem to be getting a limit ID back either, but somehow they're not failing. This is the output when I print `raw_output`, `items`, and `limit_id` in turn in the `test_limit.LimitTestCase.test_limit_create_with_options` test: | 17:21 |
| * M0weng[m] sent a code block: https://matrix.org/oftc/media/v1/media/download/ARiqPxhH7AaFJlITjcyCWOQUXZs6RNGFI-NQIvZYDjMJLNcSWtugdbVYHltqUYe0LnbMJeuW9kJFCzYfFB6yKMBCeVhjqJTQAG1hdHJpeC5vcmcvRFBvaHFzdHZLcVZleWdOSmV0anpadHdJ | 17:22 | |
| M0weng[m] | (or pastebin if you prefer https://paste.openstack.org/show/bDxU7qOBl2WseY8CeyeX/) | 17:23 |
| gtema | pls check directly whether the SDK gets the ID mapped properly | 17:23 |
| M0weng[m] | SDK does not either; this is its output from printing the whole limit and the limit ID in turn: | 17:23 |
| M0weng[m] | openstack.identity.v3.limit.Limit(description=test, project_id=235fb40de1474c06b2756eaf9d66bff8, service_id=6c34e452f0b64587b442a29ff6889b2b, region_id=tempest-TestRegion-260053066, resource_name=tempest-resource_name-1709327697, resource_limit=15, location=Munch({'cloud': 'devstack-system-admin', 'region_name': 'RegionOne', 'zone': None, 'project': Munch({'id': '235fb40de1474c06b2756eaf9d66bff8', 'name': None, 'domain_id': None, | 17:24 |
| M0weng[m] | 'domain_name': None})})) | 17:24 |
| M0weng[m] | None | 17:24 |
| M0weng[m] | (this is the output in the test) | 17:24 |
| M0weng[m] | * (this is the output as I'm getting it from the test) | 17:24 |
| gtema | weird, but at least now you know SDK is to blame | 17:25 |
| gtema | with the SDK test script you could verify that id is being present in the response, not that we have keystone to blame | 17:26 |
| stephenfin | M0weng[m]: What happens if you run this? https://paste.opendev.org/show/b247JKxsPqlVh3sZMNBM/ | 17:29 |
| M0weng[m] | stephenfin: I'm getting an error that I need an auth_url argument when creating the connection object; what should I be putting there? | 17:31 |
| stephenfin | Set OS_CLOUD first | 17:31 |
| stephenfin | s/Set/Export/ | 17:32 |
| M0weng[m] | ahh ok | 17:32 |
| M0weng[m] | Hmm I'm getting a 400 error; OS_CLOUD is things like devstack-admin, devstack-system-admin right? | 17:34 |
| stephenfin | Yep. Something like `export OS_CLOUD=devstack-admin` should do the trick | 17:34 |
| M0weng[m] | Oh wait changing it to devstack-admin worked | 17:35 |
| M0weng[m] | I'm getting an empty array back though | 17:35 |
| M0weng[m] | Let me create a new limit first | 17:35 |
| M0weng[m] | Ah wait I remember, I can't use devstack-admin to list, I need to use devstack-reader | 17:36 |
| M0weng[m] | Response here:... (full message at <https://matrix.org/oftc/media/v1/media/download/AaxUKZUTsOrXZ1SgnN3G6eSVytWi3sQWiRC-kGVVZNDR7OaK5Tdwk1NO4OJE7DruuOpBwWGwAWTNPPfvAZWwfHVCeVhkj2zgAG1hdHJpeC5vcmcvSUhlR1BaSVJlblZPWnVyZHlVZWxnV2ll>) | 17:38 |
| M0weng[m] | I need to head to class soon but I will take another look later today | 17:39 |
| opendevreview | Merged openstack/openstacksdk master: typing: Add missing proxy arguments https://review.opendev.org/c/openstack/openstacksdk/+/942595 | 17:47 |
| stephenfin | M0weng[m]: So I see the 'id' field in the output there (the line starting with 'limit 0: ') | 18:15 |
| stephenfin | Are you *certain* you are using the correct openstacksdk in your test environment? | 18:15 |
| stephenfin | Assuming you are running tests like e.g. 'tox -e functional-py39', you will need to install openstacksdk manually into the test environment in order to pick up your fix | 18:16 |
| stephenfin | So e.g. 'source .tox/functional-py39/bin/activate; pip install -e $path_to_openstacksdk_repo_with_patches; deactivate; tox -e functional-py39' | 18:17 |
| stephenfin | obviously you can sub 'py39' for 'py310' etc. | 18:17 |
| M0weng[m] | Yeah I am seeing the install line where it installs from my local instead of the upstream. I'm using tox -e functional-tips and it re-installs every time. | 18:17 |
| stephenfin | ah | 18:17 |
| M0weng[m] | I edited tox.ini to point to my local version | 18:17 |
| stephenfin | and your local version: you're on the correct branch with the fixes applied? | 18:18 |
| M0weng[m] | Yep, it all seems to be there | 18:19 |
| stephenfin | Very strange. I can't reproduce locally using `master` https://paste.opendev.org/show/byefSAYfIXTuuYWRgy1G/ | 18:21 |
| stephenfin | You might just need to tidy up the PR and push it as a draft so, so one of us can take a look. I can't blame sdk quite yet | 18:22 |
| M0weng[m] | Ok, will do when my next shift starts 👍️ | 18:27 |
| opendevreview | Tim Burke proposed openstack/python-openstackclient master: Fix credential creation https://review.opendev.org/c/openstack/python-openstackclient/+/942721 | 18:30 |
| *** timburke_ is now known as timburke | 18:39 | |
| timburke | FYI, ^^^ is needed to fix Swift's gate | 18:40 |
| opendevreview | Merged openstack/codegenerator master: Increase openapi job timeout https://review.opendev.org/c/openstack/codegenerator/+/942676 | 19:06 |
| opendevreview | Douglas Viroel proposed openstack/openstacksdk master: Bump compute max microversion to 2.100 https://review.opendev.org/c/openstack/openstacksdk/+/938833 | 19:57 |
| opendevreview | Douglas Viroel proposed openstack/python-openstackclient master: Add support for showing scheduler_hints in server details https://review.opendev.org/c/openstack/python-openstackclient/+/938834 | 19:58 |
| opendevreview | Merged openstack/python-openstackclient master: Fix credential creation https://review.opendev.org/c/openstack/python-openstackclient/+/942721 | 21:19 |
| opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'registered limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/942735 | 21:31 |
| M0weng[m] | stephenfin / gtema : New patch for registered limits: https://review.opendev.org/c/openstack/python-openstackclient/+/942735 | 21:31 |
| M0weng[m] | The limits patch has been around for a while already (waiting on deprecation for `--region 'None'` behavior in six months): https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | 21:31 |
| opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | 22:05 |
| opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | 22:06 |
| opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | 22:08 |
| opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | 22:10 |
| opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | 22:15 |
| opendevreview | Merged openstack/python-openstackclient master: handle 'router create --flavor' option https://review.opendev.org/c/openstack/python-openstackclient/+/940595 | 22:48 |
| opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'registered limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/942735 | 23:11 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!