| opendevreview | Stephen Finucane proposed openstack/osc-lib master: Correct getattr call https://review.opendev.org/c/openstack/osc-lib/+/949860 | 09:28 |
|---|---|---|
| opendevreview | Stephen Finucane proposed openstack/osc-lib master: Correct getattr call https://review.opendev.org/c/openstack/osc-lib/+/949860 | 09:30 |
| stephenfin | gtema: Tricky bug here https://bugs.launchpad.net/python-openstackclient/+bug/2107339 | 09:48 |
| stephenfin | I added all the typing to osc-lib in the last release and used some Python 3.9-style code (e.g. list[str] instead of typing.List[str]). However, our python-requires had not been bumped as it should have been | 09:50 |
| stephenfin | So to fix, I think we either need to revert the removal of Python 3.8 and 3.9 supports, changes all those type hints, cut a new release, and then re-remove. Or we need to cut a new release and yank that one | 09:51 |
| stephenfin | wdyt? | 09:51 |
| gtema | honestly I am getting sick of python. Every day there is some crap not really related to the code but due to the ecosystem stuff | 09:51 |
| gtema | are we capable at yanking at all? I hate that setuptools now weekly yanks a release - it's a bad style | 09:52 |
| stephenfin | I think we are, but I suspect it would be better form to cut a proper release and then dorp | 09:53 |
| stephenfin | *drop | 09:53 |
| stephenfin | I'm happy to do the work if you are happy to review the osc-lib and releases patches | 09:53 |
| stephenfin | and then we go and revert all the things | 09:53 |
| gtema | I would prefer reverting drop of old pythons honestly | 09:54 |
| gtema | yes, lets do it this way. Thanks | 09:54 |
| gtema | pls ensure you ping me with patches to review since i usually oversee changes in so many projects I need to have an eye on | 09:55 |
| opendevreview | Stephen Finucane proposed openstack/osc-lib master: Bump Python version used for linters to 3.10 https://review.opendev.org/c/openstack/osc-lib/+/949020 | 10:31 |
| opendevreview | Stephen Finucane proposed openstack/osc-lib master: Temporarily undrop support for Python 3.8, 3.9 https://review.opendev.org/c/openstack/osc-lib/+/949869 | 10:31 |
| opendevreview | Stephen Finucane proposed openstack/osc-lib master: Use Python 3.8-style type hints https://review.opendev.org/c/openstack/osc-lib/+/949870 | 10:31 |
| opendevreview | Stephen Finucane proposed openstack/osc-lib master: Temporarily revert dependency bumps https://review.opendev.org/c/openstack/osc-lib/+/949871 | 10:31 |
| opendevreview | Stephen Finucane proposed openstack/osc-lib master: Drop support for Python 3.8, 3.9 (again) https://review.opendev.org/c/openstack/osc-lib/+/949872 | 10:31 |
| opendevreview | Stephen Finucane proposed openstack/osc-lib master: Revert "Temporarily revert dependency bumps" https://review.opendev.org/c/openstack/osc-lib/+/949873 | 10:31 |
| opendevreview | Stephen Finucane proposed openstack/osc-lib master: Revert "Use Python 3.8-style type hints" https://review.opendev.org/c/openstack/osc-lib/+/949874 | 10:31 |
| stephenfin | gtema: ^ | 10:32 |
| stephenfin | Obviously don't review the WIP ones | 10:32 |
| gtema | sure, thks | 10:32 |
| stephenfin | fwiw, the root cause of this (other than us "supporting" a version we don't support) is that we're specifying our minimum Python version in multiple places. If it was in pyproject.toml, ruff and mypy would just consume from there | 10:35 |
| stephenfin | we should change those | 10:35 |
| opendevreview | Merged openstack/osc-lib master: Correct getattr call https://review.opendev.org/c/openstack/osc-lib/+/949860 | 12:03 |
| stephenfin | gtema: Those are passing CI now | 12:33 |
| stephenfin | (I tested with python 3.8 locally) | 12:33 |
| gtema | cool, looking now | 12:33 |
| opendevreview | Merged openstack/osc-lib master: Temporarily undrop support for Python 3.8, 3.9 https://review.opendev.org/c/openstack/osc-lib/+/949869 | 13:38 |
| opendevreview | Merged openstack/osc-lib master: Use Python 3.8-style type hints https://review.opendev.org/c/openstack/osc-lib/+/949870 | 13:41 |
| opendevreview | Merged openstack/osc-lib master: Temporarily revert dependency bumps https://review.opendev.org/c/openstack/osc-lib/+/949871 | 13:47 |
| stephenfin | gtema: https://review.opendev.org/c/openstack/releases/+/949898 | 14:09 |
| stephenfin | Those other 4 patches can be reviewed now too. I'll propose another releases patch to release 4.1.0 once they're in. | 14:10 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: identity: Fix listing of applications credentials by user https://review.opendev.org/c/openstack/python-openstackclient/+/949903 | 15:00 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: identity: Normalise output of application credentials commands https://review.opendev.org/c/openstack/python-openstackclient/+/949904 | 15:00 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: identity: Add missing user argument https://review.opendev.org/c/openstack/python-openstackclient/+/949906 | 15:06 |
| opendevreview | Merged openstack/python-openstackclient master: Don't warn about unsupported version with SDK-based commands https://review.opendev.org/c/openstack/python-openstackclient/+/946946 | 16:19 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!