| opendevreview | djp proposed openstack/openstacksdk master: Fix volume attachments limit https://review.opendev.org/c/openstack/openstacksdk/+/951517 | 04:16 |
|---|---|---|
| opendevreview | Takashi Kajinami proposed openstack/python-openstackclient master: Replace deprecated datetime.utcfromtimestamp https://review.opendev.org/c/openstack/python-openstackclient/+/952808 | 09:15 |
| opendevreview | Takashi Kajinami proposed openstack/python-openstackclient master: Replace deprecated datetime.utcfromtimestamp https://review.opendev.org/c/openstack/python-openstackclient/+/952808 | 09:16 |
| stephenfin | gtema: If I do `volume list --limit 1`, what do you think that should do? | 16:39 |
| gtema | hehe, I know what you mean | 16:40 |
| stephenfin | and likewise for `volume list --limit 1000` | 16:40 |
| gtema | due to that sort of "conflict" I added --max-items dedicated param in the rust cli | 16:41 |
| gtema | and use limit as an API page limit, but still fetch all pages until I reach max-items | 16:42 |
| stephenfin | yeah, I've been looking at https://review.opendev.org/c/openstack/openstacksdk/+/951517. idk if `limit` means "fetch all the resources in batches/pages of size N" or "fetch N resources" | 16:42 |
| stephenfin | s/means/should mean/ | 16:42 |
| stephenfin | good to hear it's not just me that's confused though :) | 16:42 |
| gtema | we are passing it to the API as page size fetching all pages | 16:42 |
| gtema | there are few other things that I explicitly decided to drop this old "convention" to cleanup the UX | 16:43 |
| stephenfin | yup, which probably makes more sense from a library perspective, but not from a CLI perspective | 16:43 |
| gtema | right. Keeping backward compatibility in lot of things limit us making a good UX | 16:45 |
| gtema | so time to start switching to the new stuff ;-) | 16:45 |
| gtema | I think now it would be good to rename limit to page_size in the rust cli explicitly to erase any confusion | 16:55 |
| stephenfin | that would be a good clal | 17:02 |
| stephenfin | *call | 17:02 |
| opendevreview | Merged openstack/python-openstackclient master: Replace deprecated datetime.utcfromtimestamp https://review.opendev.org/c/openstack/python-openstackclient/+/952808 | 18:53 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!